[PATCH v2] examples/vhost: fix retry logic on eth rx path

2022-06-17 Thread Yuan Wang
drain_eth_rx() uses rte_vhost_avail_entries() to calculate the available entries to determine if a retry is required. However, this function only works with split rings, and calculating packed rings will return the wrong value and cause unnecessary retries resulting in a significant performance pen

[PATCH v3 0/4] introduce PMCI driver

2022-06-17 Thread Wei Huang
The first patch introduce PMCI base driver to provide interface to access MAX10 register. The second patch support new board information. The third patch update flash access interfaces. The fourth patch support new board sensors. Changes from v2: 1. split PMCI driver into three parts: base driver,

[PATCH v3 1/4] raw/ifpga/base: add PMCI base driver

2022-06-17 Thread Wei Huang
PMCI (Platform Management Control Interface) is a new module in FPGA, which is designed to cooperate with BMC chip to fulfill board management functions. This base driver implements interfaces to access registers of BMC chip. Signed-off-by: Wei Huang --- v2: fix typo. 'spi_master' is not misspell

[PATCH v3 2/4] raw/ifpga/base: update board information

2022-06-17 Thread Wei Huang
N6000 ADP platform has different definition of board information, they can be recognized after this patch. Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_defines.h| 101 +++-- drivers/raw/ifpga/base/ifpga_fme.c| 121 -- drive

[PATCH v3 3/4] raw/ifpga/base: update flash operation interface

2022-06-17 Thread Wei Huang
In N6000 ADP platform, SPI protocol, master and QSPI flash are transparent to host software. The SPI master implemented in PMCI automatically converts the mailbox commands to the SPI protocol required by SPI slave. That means flash operation is different from old platform, new interfaces are introd

[PATCH v3 4/4] raw/ifpga/base: add PMCI sensor driver

2022-06-17 Thread Wei Huang
N6000 ADP platform support more sensors than N3000, they are accessed with the help of PMCI sensor driver. Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/opae_hw_api.c | 29 +++ drivers/raw/ifpga/base/opae_hw_api.h | 1 + drivers/raw/ifpga/base/opae_intel_max10.c | 326

RE: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-06-17 Thread Morten Brørup
> From: Morten Brørup > Sent: Thursday, 16 June 2022 16.36 > > > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > Sent: Thursday, 16 June 2022 15.58 > > > > On 2022-06-16 08:44, Morten Brørup wrote: > > > +CC Olivier Matz , Network Headers > maintainer > > > > > >> -Original Message--

[PATCH 0/4] support stream cipher chained operations

2022-06-17 Thread Tejasree Kondoj
This series adds support for zuc, snow3g and aes-ctr-cmac chained operations in cn9k PMD and autotest application. Tejasree Kondoj (4): crypto/cnxk: fix CMAC IV crypto/cnxk: support stream cipher chained operations crypto/cnxk: support scatter gather mode app/test: add additional stream ci

[PATCH 1/4] crypto/cnxk: fix CMAC IV

2022-06-17 Thread Tejasree Kondoj
Fixing CMAC IV length to 16 bytes. Fixes: 759b5e653580 ("crypto/cnxk: support AES-CMAC") Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index 8ed3a

[PATCH 2/4] crypto/cnxk: support stream cipher chained operations

2022-06-17 Thread Tejasree Kondoj
Adding support for zuc, snow3g and aes-ctr-cmac chained operations on cn9k using key and IV scheme in microcode. Signed-off-by: Tejasree Kondoj --- drivers/common/cnxk/roc_se.c | 271 +-- drivers/common/cnxk/roc_se.h | 74 +-- drivers/crypto/cnxk/

[PATCH 3/4] crypto/cnxk: support scatter gather mode

2022-06-17 Thread Tejasree Kondoj
Adding scatter gather support for zuc, snow3g and aes-ctr-cmac chained operations on cn9k. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_se.h | 149 +- 1 file changed, 128 insertions(+), 21 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/d

[PATCH 4/4] app/test: add additional stream cipher tests

2022-06-17 Thread Tejasree Kondoj
Adding zuc, snow3g and aes-ctr-cmac auth-cipher test vectors with same auth and cipher offsets and total digest data encrypted. Also skipping other tests with different cipher and auth offsets and partial or no digest encrypted ones on cn9k platform. Signed-off-by: Tejasree Kondoj --- app/test/t

[PATCH v2 1/2] examples/l3fwd: common packet group functionality

2022-06-17 Thread Rahul Bhansali
This will make the packet grouping function common, so that other examples can utilize as per need. Signed-off-by: Rahul Bhansali --- Changes in v2: New patch to address review comment. examples/common/neon_common.h | 50 examples/common/pkt_group.h | 139 +++

[PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode

2022-06-17 Thread Rahul Bhansali
This adds the support of NEON based lpm lookup along with multi packet processing for burst send in packets routing. Performance impact: On cn10k, with poll mode inline protocol, outbound performance increased by upto ~8% and inbound performance increased by upto ~6%. Signed-off-by: Rahul Bhansal

RE: [PATCH v2 1/2] examples/l3fwd: common packet group functionality

2022-06-17 Thread Rahul Bhansali
CC: Konstantin Ananyev > -Original Message- > From: Rahul Bhansali > Sent: Friday, June 17, 2022 1:13 PM > To: dev@dpdk.org; Ruifeng Wang > Cc: Jerin Jacob Kollanukkaran ; Rahul Bhansali > > Subject: [PATCH v2 1/2] examples/l3fwd: common packet group functionality > > This will make th

RE: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON with poll mode

2022-06-17 Thread Rahul Bhansali
CC: Konstantin Ananyev > -Original Message- > From: Rahul Bhansali > Sent: Friday, June 17, 2022 1:13 PM > To: dev@dpdk.org; Radu Nicolau ; Akhil Goyal > ; Ruifeng Wang > Cc: Jerin Jacob Kollanukkaran ; Rahul Bhansali > > Subject: [PATCH v2 2/2] examples/ipsec-secgw: add support of NEON

Re: [PATCH v1] bbdev: allow operation type enum for growth

2022-06-17 Thread Thomas Monjalon
This solution is what I proposed to the techboard some years ago, but the preference was to completely remove the MAX values. 13/06/2022 20:24, Nicolas Chautru: > Updating the last enum for rte_bbdev_op_type > to allow for enum insertion. Please explain that the reason is to keep ABI compatible,

[PATCH] net: fix checksum with unaligned buffer

2022-06-17 Thread Morten Brørup
With this patch, the checksum can be calculated on an unligned part of a packet buffer. I.e. the buf parameter is no longer required to be 16 bit aligned. The DPDK invariant that packet buffers must be 16 bit aligned remains unchanged. This invariant also defines how to calculate the 16 bit checks

RE: [PATCH v3 1/4] raw/ifpga/base: add PMCI base driver

2022-06-17 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Friday, June 17, 2022 3:20 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 1/4] raw/ifpga/base

RE: [PATCH v3 2/4] raw/ifpga/base: update board information

2022-06-17 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Friday, June 17, 2022 3:20 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 2/4] raw/ifpga/base

RE: [PATCH v3 3/4] raw/ifpga/base: update flash operation interface

2022-06-17 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Friday, June 17, 2022 3:20 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 3/4] raw/ifpga/base

RE: [PATCH v3 4/4] raw/ifpga/base: add PMCI sensor driver

2022-06-17 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Friday, June 17, 2022 3:20 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 4/4] raw/ifpga/base

RE: [PATCH] net: fix checksum with unaligned buffer

2022-06-17 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Friday, 17 June 2022 10.45 > > With this patch, the checksum can be calculated on an unligned part of > a packet buffer. > I.e. the buf parameter is no longer required to be 16 bit aligned. > > The DPDK invariant that packet buffer

[PATCH v3 00/13] Add support of NFP3800 chip and firmware with NFDk

2022-06-17 Thread Jin Liu
NFD is part of NFP firmware, and there only exist a NFD3 version before this patch series. This patch series mainly add the support of the new NFP3800 chip use firmware with NFD3/NFDk. * Changes since v1 - Added updated documentation for NFP to cover NFD. - Documented the addition of NFD in the

[PATCH v3 01/13] net/nfp: change the coding style

2022-06-17 Thread Jin Liu
Change the coding style of some logics, to make it more compatible with the DPDK coding style. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 149 drivers/net/nfp/nfp_ethdev_vf.c | 8 +-

[PATCH v3 02/13] net/nfp: remove unnecessary forward function declaration

2022-06-17 Thread Jin Liu
This commit remove some unnecessary forward function declarations. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 22 -- drivers/net/nfp/nfp_ethdev_vf.c | 12 drivers/net/nfp/nfp_rxtx.c

[PATCH v3 03/13] net/nfp: remove pessimistic limit

2022-06-17 Thread Jin Liu
Multiple writes cause intermediate pointer values that do not end on complete TX descriptors. The QCP peripheral on the NFP provides a number of access modes. In some access modes, the maximum amount to add must be restricted to a 6bit value. The particular access mode used by _nfp_qcp_ptr_add() h

[PATCH v3 04/13] net/nfp: rename set MAC function

2022-06-17 Thread Jin Liu
The NFP eth driver function name start with 'nfp_net', but set_mac function start with 'nfp' only, rename it, be consistent with others. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/n

[PATCH v3 05/13] net/nfp: rename function and struct

2022-06-17 Thread Jin Liu
Add 'nfd3' into the firmware with NFD3 eth driver function name, preparation for the next work, as we will support another version firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- dri

[PATCH v3 06/13] net/nfp: support NFP3800 card

2022-06-17 Thread Jin Liu
Add support for a new type of NIC NFP3800 card, and update some network card data acquisition interface functions. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- doc/guides/nics/nfp.rst

[PATCH v3 07/13] net/nfp: support firmware with NFDk

2022-06-17 Thread Jin Liu
Modify nfp driver logic, add firmware version (NFD3 or NFDK) judgment, will according to the firmware version, mount different driver functions. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- doc/guide

[PATCH v3 08/13] net/nfp: structure adjustment

2022-06-17 Thread Jin Liu
Add and modify the nfp PMD struct and macro that will be used by firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.h | 58 +

[PATCH v3 09/13] net/nfp: nfdk netdev option and queue function

2022-06-17 Thread Jin Liu
Add ethdev option for firmware with NFDk, implement tx_queue setup function for firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 32 - drive

[PATCH v3 10/13] net/nfp: add queue stop and close helper function

2022-06-17 Thread Jin Liu
This commit does not introduce new features, just integrate some common logic into helper functions to reduce the same logic and increase code reuse, include queue stop and queue close logic, will be used when NFP net stop and close. queue stop: reset queue queue close: reset and release queue Mo

[PATCH v3 11/13] net/nfp: move macro from C file to head file

2022-06-17 Thread Jin Liu
Move macro __round_mask, round_up and round_down from C file to corresponding head file, will be used by TX function of nfp net firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- driver

[PATCH v3 12/13] net/nfp: nfdk packet xmit function

2022-06-17 Thread Jin Liu
Implement NFP3800 card packet transmit function for firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 3 +- drivers/net/nfp/nfp_ethdev_vf.c | 3 +-

[PATCH v3 13/13] net/nfp: modify RSS logic

2022-06-17 Thread Jin Liu
Now NFP NIC support two type of RSS logic, NFP_NET_CFG_CTRL_RSS and NFP_NET_CFG_CTRL_RSS2, use NFP_NET_CFG_CTRL_RSS2 if NIC capability support, otherwise use NFP_NET_CFG_CTRL_RSS. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-b

[PATCH] doc: update async enqueue API usage

2022-06-17 Thread xuan . ding
From: Xuan Ding This patch updates the correct usage for async enqueue APIs. The rte_vhost_poll_enqueue_completed() needs to be called in time to avoid packet loss due to full dma ring. Signed-off-by: Xuan Ding --- doc/guides/prog_guide/vhost_lib.rst | 9 + 1 file changed, 9 insertions

RE: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support more flow patterns and actions

2022-06-17 Thread Zhang, Roy Fan
Hi, > -Original Message- > From: psathe...@marvell.com > Sent: Friday, June 3, 2022 4:17 AM > To: Nicolau, Radu ; Akhil Goyal > Cc: dev@dpdk.org; Satheesh Paul > Subject: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support more flow > patterns and actions > > From: Satheesh Paul > >

[PATCH 0/2] app/eventdev: fix issues with cop alloc and qp size

2022-06-17 Thread Volodymyr Fialko
- Handle cop allocation failures and count them. - QP default size increased, previous size of 128 was too small for most of the cases Volodymyr Fialko (2): app/eventdev: add null checks for cop allocations app/eventdev: increase number of qp descriptors app/test-eventdev/test_perf_common.

[PATCH 1/2] app/eventdev: add null checks for cop allocations

2022-06-17 Thread Volodymyr Fialko
Crypto operation allocation may fail in case when total size of queue pairs is bigger then pool size. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/app/test-eventdev/test_

[PATCH 2/2] app/eventdev: increase number of qp descriptors

2022-06-17 Thread Volodymyr Fialko
Increase number of cryptodev queue pair descriptors by default. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c index a5e03187

RE: [dpdk-dev v4 1/4] crypto/openssl: 3.0 EVP update on HMAC routine

2022-06-17 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, June 14, 2022 2:26 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v4 1/4] crypto/openssl: 3.0 EVP update on HMAC routine > > This patch update the symmetric HMAC routine in crypto openssl > pmd to adopt op

RE: [dpdk-dev v4 2/4] crypto/openssl: 3.0 EVP update on RSA routine

2022-06-17 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, June 14, 2022 2:26 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v4 2/4] crypto/openssl: 3.0 EVP update on RSA routine > > This patch updates asymmetric RSA routine in crypto openssl pmd > to adopt openss

RE: [dpdk-dev v4 3/4] crypto/openssl: 3.0 EVP update on DH routine

2022-06-17 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, June 14, 2022 2:26 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v4 3/4] crypto/openssl: 3.0 EVP update on DH routine > > This patch updates asymmetric DH routine in crypto openssl pmd > to adopt openssl

RE: [dpdk-dev v4 4/4] crypto/openssl: 3.0 EVP update on DSA routine

2022-06-17 Thread Zhang, Roy Fan
> -Original Message- > From: Kai Ji > Sent: Tuesday, June 14, 2022 2:26 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v4 4/4] crypto/openssl: 3.0 EVP update on DSA routine > > This patch updates asymmetric DSA routine in crypto openssl pmd > to adopt openss

RE: [PATCH] crypto/openssl: support cmac operations

2022-06-17 Thread Zhang, Roy Fan
Hi, > -Original Message- > From: Ashwin Sekhar T K > Sent: Friday, June 10, 2022 5:29 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; sk...@marvell.com; skotesh...@marvell.com; > pbhagavat...@marvell.com; kirankum...@marvell.com; > psathe...@marvell.com; asek...@marvell.com; ano...@marvel

RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch

2022-06-17 Thread Zhang, Roy Fan
Hi, IPsec-mb PMD should not be built at all if the library is not installed. Also, the code you are warping with macro only prevents initializing the vector mode param to SSE which is later used to add feature flag bits. To me this change does not make much sense. Can you share with me the purpo

RE: [PATCH] crypto/ipsec_mb: enable compilation for non x86 arch

2022-06-17 Thread Ashwin Sekhar Thalakalath Kottilveetil
Hi Fan, There is an ARM64 port for IPSEC-MB https://gitlab.arm.com/arm-reference-solutions/ipsec-mb . When we compile DPDK with this IPSEC-MB port for ARM64, the vector_mode value doesn't matter. And the cpuflag #defines RTE_CPUFLAG_AVX512F, RTE_CPUFLAG_AVX2 etc. are not available in ARM64.

RE: [PATCH 1/2] crypto/qat: add gen4 ecdsa functions

2022-06-17 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, April 8, 2022 8:58 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH 1/2] crypto/qat: add gen4 ecdsa functions > > This commit adds generation of ecdsa with named > cur

[dpdk-dev] [PATCH v4] examples/ipsec-secgw: support more flow patterns and actions

2022-06-17 Thread psatheesh
From: Satheesh Paul Added support to create flow rules with count, mark and security actions and mark pattern. Signed-off-by: Satheesh Paul --- v4: * Added more description in documenation for flow rule options. v3: * Fixed IPv4 and IPv6 dst addr setting in flow pattern spec v2: * Updated docum

RE: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support more flow patterns and actions

2022-06-17 Thread Satheesh Paul Antonysamy
Hi, Please find reply inline. Thanks, Satheesh. -Original Message- From: Zhang, Roy Fan Sent: 17 June 2022 03:22 PM To: Satheesh Paul Antonysamy ; Nicolau, Radu ; Akhil Goyal Cc: dev@dpdk.org Subject: [EXT] RE: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: support more flow patterns a

RE: [PATCH v2 1/5] telemetry: escape special char when tel string

2022-06-17 Thread Morten Brørup
> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Friday, 17 June 2022 11.46 > > This patch supports escape special characters (including: \",\\,/,\b, > /f,/n,/r,/t) when telemetry string. > This patch is used to support telemetry xxx-dump commands which the > string may include speci

[PATCH v2 0/4] Improve documentation for running as non-root

2022-06-17 Thread Dmitry Kozlyuk
v1: Address comments by Stephen Hemminger: - Use hugetlbfs options instead of chown. - Suggest using OS or container runtime where possible. - Improve wording. Add SYS_RAWIO requirement for legacy virtio. Explain SYS_RAWIO requirement for MLX5 PMD. Dmitry Kozlyuk (4): usertoo

[PATCH v2 1/4] usertools: add option to select hugetlbfs directory

2022-06-17 Thread Dmitry Kozlyuk
dpdk-hugepages.py had /dev/hugepages hardcoded as the mount point. It may be desirable to setup hugepage directory at another path, for example, when using hugepages of multiple sizes in different directories or when granting different permissions to mount points. Add --directory/-d option to the s

[PATCH v2 2/4] usertools: add option to change mount point owner

2022-06-17 Thread Dmitry Kozlyuk
Per mount(8), the previous owner and mode of the mount point become invisible as long as this filesystem remains mounted. Because dpdk-hugepages.py must be run as root, the new owner would be root. This is undesirable if the hugepage directory is being set up by the administrator for an unprivilege

[PATCH v2 3/4] doc: give specific instructions for running as non-root

2022-06-17 Thread Dmitry Kozlyuk
The guide to run DPDK applications as non-root in Linux did not provide specific instructions to configure the required access and did not explain why each bit is needed. The latter is important because running as non-root is one of the ways to tighten security and grant minimal permissions. Cc: s

[PATCH v2 4/4] doc: update instructions for running as non-root for MLX5

2022-06-17 Thread Dmitry Kozlyuk
Reference the common guide for generic setup. Remove excessive capabilities from the recommended list. Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk --- doc/guides/platform/mlx5.rst | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/doc/gui

RE: [dpdk-dev v7] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-06-17 Thread Power, Ciara
Hi Kai, > -Original Message- > From: Kai Ji > Sent: Monday 13 June 2022 18:03 > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Zhang, Roy Fan > > Subject: [dpdk-dev v7] crypto/qat: use intel-ipsec-mb for partial hash & aes > > Since openssl 3.0 now deprecates the low level API QAT

RE: [PATCH 4/4] doc: update instructions for running as non-root for MLX5

2022-06-17 Thread Dmitry Kozlyuk
> From: Stephen Hemminger > Sent: Wednesday, June 8, 2022 3:14 AM > [...] > This change needs additional changes to make it correct English > grammar. Thank you for the useful comments to this and other patches. I hope you don't mind that I took some sentences almost verbatim for v2. > [...] > >

Re: [PATCH v4] gro: bug fix in identifying fragmented packets

2022-06-17 Thread kumaraparameshwaran rathinavel
> -Original Message- > From: Kumara Parameshwaran > Sent: Wednesday, June 8, 2022 5:57 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Kumara Parameshwaran > ; sta...@dpdk.org > Subject: [PATCH v4] gro: bug fix in identifying fragmented packets > > From: Kumara Parameshwaran > > A packet with RTE

Re: [PATCH 0/2] fix compilation with GCC 12

2022-06-17 Thread David Marchand
On Fri, Jun 17, 2022 at 8:15 AM Ankur Dwivedi wrote: > > This patch series resolves compilation warning observed with GCC 12, > in common/cpt and crypto/cnxk. > > Ankur Dwivedi (2): > common/cpt: fix compilation with GCC 12 > crypto/cnxk: fix compilation with GCC 12 > Two small nits in commit

Re: [PATCH] common/cnxk: update CN103XX subsystem device ID

2022-06-17 Thread Jerin Jacob
On Mon, Jun 13, 2022 at 4:59 PM Rahul Bhansali wrote: > > Updates the subsystem device ID for CN103XX. > > Signed-off-by: Rahul Bhansali Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: fix CN103XX subsystem device ID Fix the subsys

Re: [PATCH] net/qede: fix build with GCC 13

2022-06-17 Thread Jerin Jacob
On Thu, Jun 16, 2022 at 10:32 PM Ferruh Yigit wrote: > > Reproduced with "gcc (GCC) 13.0.0 20220616 (experimental)" > > Build error: > In file included from ../drivers/net/qede/qede_debug.c:9: > ../drivers/net/qede/qede_debug.c: In function ‘qed_grc_dump_addr_range’: > ../drivers/net/qede/base/eco

Re: [PATCH 2/2] app/eventdev: increase number of qp descriptors

2022-06-17 Thread Jerin Jacob
On Fri, Jun 17, 2022 at 3:32 PM Volodymyr Fialko wrote: > > Increase number of cryptodev queue pair descriptors by default. Please add more details for the reason for the change > > Signed-off-by: Volodymyr Fialko > --- > app/test-eventdev/test_perf_common.c | 2 +- > 1 file changed, 1 inserti

Re: [PATCH v2] test/ipsec: fix build with GCC 12

2022-06-17 Thread David Marchand
On Thu, Jun 16, 2022 at 11:33 AM David Marchand wrote: > > GCC 12 raises the following warning: > > In function ‘_mm256_loadu_si256’, > inlined from ‘rte_mov32’ at > ../lib/eal/x86/include/rte_memcpy.h:319:9, > inlined from ‘rte_mov128’ at > ../lib/eal/x86/include/rte_memcp

Re: [PATCH 1/2] app/eventdev: add null checks for cop allocations

2022-06-17 Thread Jerin Jacob
On Fri, Jun 17, 2022 at 3:32 PM Volodymyr Fialko wrote: > > Crypto operation allocation may fail in case when total size of queue > pairs is bigger then pool size. ^^^ ^^^ pairs are bigger than the pool size. Acked-by: Jerin Jacob Please send v2 with other changes in 1/2

Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12

2022-06-17 Thread David Marchand
On Fri, Jun 17, 2022 at 8:15 AM Ankur Dwivedi wrote: > > The following warning is observed with GCC 12 compilation: > > In function ‘fill_sg_comp_from_iov’, > inlined from ‘cpt_zuc_snow3g_enc_prep’ at > ../drivers/common/cpt/cpt_ucode.h:1672:9, > inlined from ‘cpt_fc_enc_hmac_prep’

Re: [PATCH v2] common/cnxk: add cnf10kb support

2022-06-17 Thread Jerin Jacob
On Mon, Jun 13, 2022 at 5:15 PM Harman Kalra wrote: > > Support for cnf10kb soc by adding its PCI device ID > > Signed-off-by: Harman Kalra Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: support CNF10KB SoC Support for CNF10KB SoC

[PATCH v2 0/2] app/eventdev: fix issues with cop alloc and qp size

2022-06-17 Thread Volodymyr Fialko
- Handle cop allocation failures and count them. - QP default size increased, previous size of 128 was too small for most of the cases --- v2: - resolve issues with the patch description Volodymyr Fialko (2): app/eventdev: add null checks for cop allocations app/eventdev: increase number of

[PATCH v2 1/2] app/eventdev: add null checks for cop allocations

2022-06-17 Thread Volodymyr Fialko
Crypto operation allocation may fail in case when total size of queue pairs are bigger then the pool size. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/app/test-eventdev/

[PATCH v2 2/2] app/eventdev: increase number of qp descriptors

2022-06-17 Thread Volodymyr Fialko
Increase number of cryptodev queue pair descriptors by default. Current size of 128 descriptors does not satisfying minimal requirements of crypto drivers. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

RE: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12

2022-06-17 Thread Ankur Dwivedi
Hi David, >-Original Message- >From: David Marchand >Sent: Friday, June 17, 2022 5:38 PM >To: Ankur Dwivedi >Cc: dev ; Anoob Joseph ; Akhil Goyal >; Tejasree Kondoj ; Jerin >Jacob Kollanukkaran ; dpdk stable >Subject: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12 > >Exte

RE: [PATCH] crypto/qat: add ec point verify function

2022-06-17 Thread Zhang, Roy Fan
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, April 7, 2022 5:45 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH] crypto/qat: add ec point verify function > > This commit adds elliptic curve point verification

Re: [PATCH v2] vdpa/ifc: fix null pointer dereference

2022-06-17 Thread Maxime Coquelin
On 6/15/22 08:23, Andy Pei wrote: Fix null pointer dereference reported in coverity scan. Coverity issue: 378882 Fixes: 5d75517beffe ("vdpa/ifc/base: access correct register for blk device") Signed-off-by: Andy Pei Acked-by: Xiao Wang --- drivers/vdpa/ifc/base/ifcvf.c | 9 + 1 f

Re: [PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding"

2022-06-17 Thread Maxime Coquelin
On 6/13/22 14:24, Singh, Aman Deep wrote: Hi Maxime, On 6/8/2022 6:19 PM, Maxime Coquelin wrote: This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), as the checksum forwarding is expected to only perform checksum and not also overwrites the source and dest

Re: [dpdk-dev] [PATCH v2] common/cnxk: add ROC API to free MCAM entry

2022-06-17 Thread Jerin Jacob
On Wed, Jun 15, 2022 at 7:29 PM wrote: > > From: Satheesh Paul > > Add ROC API to free the given MCAM entry. If the MCAM > entry has flow counter associated, this API will clear > and free the flow counter. > > Signed-off-by: Satheesh Paul > Reviewed-by: Jerin Jacob Applied to dpdk-next-net-mr

RE: [PATCH] crypto/qat: add ecdh key exchange algorithm

2022-06-17 Thread Zhang, Roy Fan
Sorry for the confusion - unack the patch as it needs rebasing. > -Original Message- > From: Zhang, Roy Fan > Sent: Friday, June 17, 2022 1:37 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: gak...@marvell.com > Subject: RE: [PATCH] crypto/qat: add ecdh key exchange algorithm > > >

Re: [PATCH v2 2/2] common/cnxk: add include for macro definition

2022-06-17 Thread Jerin Jacob
On Wed, Jun 15, 2022 at 10:41 PM Bruce Richardson wrote: > > The header file "roc_io.h" uses the "__plt_always_inline" macro but > don't include "roc_platform.h" to get the definition of it. This > inclusion is not necessary for compilation, but the lack of it can > confuse some indexers - such as

Re: [PATCH] add support for async vhost packed ring dequeue

2022-06-17 Thread Maxime Coquelin
Hi Cheng, On 6/13/22 10:21, Cheng Jiang wrote: This patch implements packed ring dequeue data path for asynchronous vhost. Signed-off-by: Cheng Jiang Reviewed-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 218 - 1 file changed, 192 insertions(+),

Re: [PATCH v3 00/13] Add support of NFP3800 chip and firmware with NFDk

2022-06-17 Thread Ferruh Yigit
On 6/17/2022 10:34 AM, Jin Liu wrote: NFD is part of NFP firmware, and there only exist a NFD3 version before this patch series. This patch series mainly add the support of the new NFP3800 chip use firmware with NFD3/NFDk. * Changes since v1 - Added updated documentation for NFP to cover NF

[PATCH v2 0/2] fix compilation with GCC 12

2022-06-17 Thread Ankur Dwivedi
This patch series resolves compilation warning observed with GCC 12, in common/cpt and crypto/cnxk. --- v2: - Add Bugzilla ID in patch 1. - Remove empty line between Fixes: and Cc:. Ankur Dwivedi (2): common/cpt: fix compilation with GCC 12 crypto/cnxk: fix compilation with GCC 12 drivers/c

[PATCH v2 1/2] common/cpt: fix compilation with GCC 12

2022-06-17 Thread Ankur Dwivedi
The following warning is observed with GCC 12 compilation: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_zuc_snow3g_enc_prep’ at ../drivers/common/cpt/cpt_ucode.h:1672:9, inlined from ‘cpt_fc_enc_hmac_prep’ at ../drivers/common/cpt/cpt_ucode.h:2472:3, inlined f

[PATCH v2 2/2] crypto/cnxk: fix compilation with GCC 12

2022-06-17 Thread Ankur Dwivedi
The following warning is observed with GCC 12 compilation: In file included from ../drivers/crypto/cnxk/cn10k_cryptodev_ops.c:17: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_pdcp_chain_alg_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1194:8, inlined from ‘cpt_fc_enc_hmac_pr

Re: [PATCH] vhost: rename number of available entries

2022-06-17 Thread David Marchand
On Thu, Jun 16, 2022 at 10:20 AM Maxime Coquelin wrote: > > This patchs renames the local variables free_entries to > avail_entries in the dequeue path. > > Indeed, this variable represents the number of new packets > available in the Virtio transmit queue, so these entries > are actually used, no

RE: [PATCH] net: fix checksum with unaligned buffer

2022-06-17 Thread Emil Berg
> -Original Message- > From: Morten Brørup > Sent: den 17 juni 2022 11:07 > To: Emil Berg > Cc: sta...@dpdk.org; bugzi...@dpdk.org; hof...@lysator.liu.se; > olivier.m...@6wind.com; dev@dpdk.org > Subject: RE: [PATCH] net: fix checksum with unaligned buffer > > > From: Morten Brørup [mail

Re: [PATCH v3] vhost/crypto: fix build with GCC 12

2022-06-17 Thread Maxime Coquelin
On 6/16/22 16:46, David Marchand wrote: GCC 12 raises the following warning: In file included from ../lib/mempool/rte_mempool.h:46, from ../lib/mbuf/rte_mbuf.h:38, from ../lib/vhost/vhost_crypto.c:7: ../lib/vhost/vhost_crypto.c: In function ‘rte_vhost_crypt

Re: [PATCH] vhost: fix log for async dequeue

2022-06-17 Thread Maxime Coquelin
On 6/17/22 07:40, David Marchand wrote: Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"), vhost logs contain the socket path as a prefix. Async dequeue path was copied from the sync dequeue path but a log was incorrect. Fixes: 84d5204310d7 ("vhost: support async dequeue

Re: [PATCH v2 0/6] Vhost checksum offload improvements

2022-06-17 Thread Maxime Coquelin
On 6/8/22 14:49, Maxime Coquelin wrote: This series aims at improving Vhost checksum offloading support. The first patch reverts overwritting MAC address in testpmd CSUM forward mode. This is required to be able to test checksum offloading with real traffic. MAC forwarding mode should be used

Re: [PATCH v5 0/2] support to clear in-flight packets for async

2022-06-17 Thread Maxime Coquelin
On 6/9/22 19:34, Yuan Wang wrote: These patches support to clear in-flight packets for async dequeue and introduce thread-safe version of this function. v5: - Add dma_id check v4: - Rebase to latest DPDK v3: - Rebase to latest DPDK v2: - Use the thread-safe version in destroy_device v1: -

Re: [PATCH v2] vdpa/ifc: fix null pointer dereference

2022-06-17 Thread Maxime Coquelin
On 6/15/22 08:23, Andy Pei wrote: Fix null pointer dereference reported in coverity scan. Coverity issue: 378882 Fixes: 5d75517beffe ("vdpa/ifc/base: access correct register for blk device") Signed-off-by: Andy Pei Acked-by: Xiao Wang --- drivers/vdpa/ifc/base/ifcvf.c | 9 + 1 f

Re: [PATCH v3] vdpa/mlx5: workaround var offset within page

2022-06-17 Thread Maxime Coquelin
On 6/15/22 12:02, Yajun Wu wrote: vDPA driver first uses kernel driver to allocate doorbell(VAR) area for each device. Then uses var->mmap_off and var->length to mmap uverbs device file as doorbell userspace virtual address. Current kernel driver provides var->mmap_off equal to page start of

Re: [PATCH] vhost: rename number of available entries

2022-06-17 Thread Maxime Coquelin
On 6/16/22 10:20, Maxime Coquelin wrote: This patchs renames the local variables free_entries to avail_entries in the dequeue path. Indeed, this variable represents the number of new packets available in the Virtio transmit queue, so these entries are actually used, not free. Signed-off-by:

Re: [PATCH v2] vhost: fix missing statistics update

2022-06-17 Thread Maxime Coquelin
On 6/16/22 11:44, xuan.d...@intel.com wrote: From: Xuan Ding This patch adds missing per-virtqueue statistics in async dequeue path. Fixes: 84d5204310d7("vhost: support async dequeue for split ring") Signed-off-by: Xuan Ding --- v2: * Since this issue was introduced and fixed in same rel

Re: [PATCH] vhost: fix log for async dequeue

2022-06-17 Thread Maxime Coquelin
On 6/17/22 07:40, David Marchand wrote: Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"), vhost logs contain the socket path as a prefix. Async dequeue path was copied from the sync dequeue path but a log was incorrect. Fixes: 84d5204310d7 ("vhost: support async dequeue

Re: [PATCH v2 01/15] vdpa/mlx5: fix usage of capability for max number of virtqs

2022-06-17 Thread Maxime Coquelin
On 6/16/22 04:29, Li Zhang wrote: The driver wrongly takes the capability value for the number of virtq pairs instead of just the number of virtqs. Adjust all the usages of it to be the number of virtqs. Fixes: c2eb33a ("vdpa/mlx5: manage virtqs by array") Cc: sta...@dpdk.org Signed-off-by:

Re: [PATCH v2] net/nfp: initialize the flbufsz

2022-06-17 Thread Ferruh Yigit
On 6/15/2022 11:14 AM, Peng Zhang wrote: When the testpmd start-up, it will check MTU range, if MTU > flubfsz, it will lead testpmd start fail. Because the hw->flbufsz doesn't have the initialized value, so it will lead the bug. Fixes: 97a30c4d4c7b ("net/nfp: make sure MTU is never larger than m

Re: [PATCH v2 02/15] vdpa/mlx5: support pre create virtq resource

2022-06-17 Thread Maxime Coquelin
On 6/16/22 04:29, Li Zhang wrote: From: Yajun Wu The motivation of this change is to reduce vDPA device queue creation time by create some queue resource in vDPA device probe stage. s/create/creating/ In VM live migration scenario, this can reduce 0.8ms for each queue creation, thus red

Re: [PATCH v2 03/15] common/mlx5: add DevX API to move QP to reset state

2022-06-17 Thread Maxime Coquelin
On 6/16/22 04:30, Li Zhang wrote: From: Yajun Wu Support set QP to RESET state. Signed-off-by: Yajun Wu Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++ drivers/common/mlx5/mlx5_prm.h | 17 + 2 files changed, 24 insertions(+) Review

Re: [PATCH v2 05/15] common/mlx5: extend virtq modifiable fields

2022-06-17 Thread Maxime Coquelin
On 6/16/22 04:30, Li Zhang wrote: A virtq configuration can be modified after the virtq creation. Added the following modifiable fields: 1.address fields: desc_addr/used_addr/available_addr 2.hw_available_index 3.hw_used_index 4.virtio_q_type 5.version type 6.queue mkey 7.feature bit mask: tso

  1   2   >