[Bug 1027] mempool cache size parameter is misleading

2022-06-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1027 Bug ID: 1027 Summary: mempool cache size parameter is misleading Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [PATCH v4 3/7] ethdev: introduce Rx queue based fill threshold

2022-06-07 Thread Andrew Rybchenko
On 6/7/22 00:30, Thomas Monjalon wrote: It seems we share a common understanding and we need to agree on a good wording for the most meaningful API. Questions inline below: 06/06/2022 19:15, Andrew Rybchenko: On 6/6/22 16:16, Spike Du wrote: Hi Andrew, Please see below for "fill thresh

Re: [PATCH v2 1/2] cmdline: add function to verify valid commands

2022-06-07 Thread Olivier Matz
Hi Bruce, Just few minor comments below. On Fri, May 20, 2022 at 04:12:39PM +0100, Bruce Richardson wrote: > The cmdline library cmdline_parse() function parses a command and > executes the action automatically too. The cmdline_valid_buffer function > also uses this function to validate commands,

[PATCH v2] eventdev: add adapter instance get API

2022-06-07 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() and rte_event_eth_tx_adapter_instance_get() api's to get the adapter instance id for a specified event port and queue index. Signed-off-by: Ganapati Kundapura --- v2: * Fixed build issues * Added telemetry support for rte_event_eth_rx_adapter_instance

Re: [PATCH v2 2/2] test: use cmdline library to validate args

2022-06-07 Thread Olivier Matz
On Fri, May 20, 2022 at 04:12:40PM +0100, Bruce Richardson wrote: > When passing in test names to run via either the DPDK_TEST environment > variable or via extra argv parameters, the checks run on those commands > can miss valid commands that are registered with the cmdline library in > the initia

Re: Intro to DPDK and Installation for DPI

2022-06-07 Thread Muhammad Siddique .
Ok, thanks. but I want to integrate the DPDK with any open Source DPI solution i.e., nDPI How can I do that kindly help me where I have to specifically Write or Integrate my DPI code with DPDK. On Sun, Jun 5, 2022 at 8:56 PM Stephen Hemminger wrote: > On Fri, 3 Jun 2022 11:13:27 +0500 > "Muhamm

Re: [PATCH v4] kni: fix build with Linux 5.18

2022-06-07 Thread Jiri Slaby
On 05. 06. 22, 10:22, Andrew Rybchenko wrote: On 6/1/22 09:53, Jiri Slaby wrote: Since commit 2655926aea9b (net: Remove netif_rx_any_context() and netif_rx_ni().) in 5.18, netif_rx_ni() no longer exists as netif_rx() can be called from any context. So define HAVE_NETIF_RX_NI for older releases a

[PATCH] kni: fix double #else typo

2022-06-07 Thread Jiri Slaby
Commit c98600d4bed6 (kni: fix build with Linux 5.18), added a new preprocessor sequence: #if ... ... #else ... #else The latter #else should have been #endif obviously and I forgot to amend that change to the commit above. Fix this. Cc: Andrew Rybchenko Cc: Stephen Hemminger Cc: Ferruh Yig

[PATCH v3] eventdev: add adapter instance get API

2022-06-07 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() and rte_event_eth_tx_adapter_instance_get() api's to get the adapter instance id for a specified event port and queue index. Signed-off-by: Ganapati Kundapura --- v3: * Fixed checkpatch error v2: * Fixed build issues * Added telemetry support for rte

RE: [PATCH v2 1/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-06-07 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, May 30, 2022 6:57 AM > To: Kathleen Capella ; Wu, Jingjing > ; Xing, Beilei ; Ruifeng Wang > > Cc: dev@dpdk.org; n...@arm.com; honnappa.nagaraha...@arm.com; > dharmik.thak...@arm.com > Subject: RE: [PATCH v2 1/1] net/iavf: add ve

[PATCH v5 0/5] Support OFS card

2022-06-07 Thread Wei Huang
Changes from v4: 1. update afu driver name in diagram in ifpga doc. Wei Huang (5): raw/ifpga: remove experimental tag from ifpga APIs raw/ifpga: remove vdev when ifpga is closed raw/ifpga: unregister interrupt in ifpga close function raw/ifpga: support ofs card probe guides/rawdevs: add

[PATCH v5 1/5] raw/ifpga: remove experimental tag from ifpga APIs

2022-06-07 Thread Wei Huang
These APIs are introduced in DPDK 21.05 and have been tested in several release, experimental tag can be formally removed. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Reviewed-by: Rosen Xu --- drivers/raw/ifpga/rte_pmd_ifpga.h | 48 --- drivers/raw/ifpg

[PATCH v5 2/5] raw/ifpga: remove vdev when ifpga is closed

2022-06-07 Thread Wei Huang
Virtual devices created on ifpga raw device will not be removed when ifpga device has closed. To avoid resource leak problem, this patch introduces an ifpga virtual device remove function, virtual devices will be destroyed after the ifpga raw device closed. Fixes: ef1e8ede3da5 ("raw/ifpga: add Int

[PATCH v5 3/5] raw/ifpga: unregister interrupt in ifpga close function

2022-06-07 Thread Wei Huang
There is an API rte_pmd_ifpga_cleanup provided by ifpga driver to free the software resource used by ifpga card. The function call of rte_pmd_ifpga_cleanup is list below. rte_pmd_ifpga_cleanup() ifpga_rawdev_cleanup() rte_rawdev_pmd_release() rte_rawdev_close() ifpga_rawdev_c

[PATCH v5 4/5] raw/ifpga: support ofs card probe

2022-06-07 Thread Wei Huang
PAC N6000 is the first OFS platform, its device id is added to ifpga device support list. Previous FPGA platform like Intel PAC N3000 and N5000, FME DFL (Device Feature List) starts from BAR0 by default, port DFL location is indicated in PORTn_OFFSET register in FME. In OFS implementation, FME DFL

[PATCH v5 5/5] guides/rawdevs: add description of ofs in ifpga doc

2022-06-07 Thread Wei Huang
OFS (Open FPGA Stack) specification is introduced briefly. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Reviewed-by: Rosen Xu --- v2: update description per Tianfei's comment --- v3: update afu driver name in diagram --- doc/guides/rawdevs/ifpga.rst | 105 ++

Re: [PATCH 05/10] raw/cnxk_bphy: support switching from eCPRI to CPRI

2022-06-07 Thread Ray Kinsella
Tomasz Duszynski writes: > Add support for switching from ethernet (eCPRI) to CPRI mode. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jakub Palider > Reviewed-by: Jerin Jacob Kollanukkaran > --- > doc/guides/rawdevs/cnxk_bphy.rst| 11 +++ > drivers/common/cnxk/roc_bphy_cgx

Re: [PATCH 06/10] raw/cnxk_bphy: support enabling TX for CPRI SERDES

2022-06-07 Thread Ray Kinsella
Tomasz Duszynski writes: > Add support for enabling or disablig TX for SERDES > configured in CPRI mode. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jakub Palider > Reviewed-by: Jerin Jacob Kollanukkaran > --- > doc/guides/rawdevs/cnxk_bphy.rst| 10 +++ > drivers/common/c

Re: [PATCH 07/10] raw/cnxk_bphy: support changing CPRI misc settings

2022-06-07 Thread Ray Kinsella
Tomasz Duszynski writes: > Add support for changing miscellaneous CPRI settings. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jerin Jacob Kollanukkaran > --- > doc/guides/rawdevs/cnxk_bphy.rst| 11 > drivers/common/cnxk/roc_bphy_cgx.c | 30 + >

RE: [PATCH] examples/pipeline: fix build

2022-06-07 Thread Dumitrescu, Cristian
> -Original Message- > From: Ali Alnubani > Sent: Thursday, June 2, 2022 1:34 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/pipeline: fix build > > This patch fixes the following build failure seen on Ubuntu 16.04 > with gcc 5.4.0 because of uninitialize

Re: [PATCH v9] eal: add seqlock

2022-06-07 Thread David Marchand
On Mon, May 23, 2022 at 4:24 PM Mattias Rönnblom wrote: > > A sequence lock (seqlock) is a synchronization primitive which allows > for data-race free, low-overhead, high-frequency reads, suitable for > data structures shared across many cores and which are updated > relatively infrequently. > > A

[Bug 1020] Can not detect E810-CQDA2 on Ubuntu 20.04

2022-06-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1020 Thomas Dethier (t.deth...@deltacast.tv) changed: What|Removed |Added Resolution|--- |FIXED Statu

[Bug 1020] Can not detect E810-CQDA2 on Ubuntu 20.04

2022-06-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1020 Thomas Dethier (t.deth...@deltacast.tv) changed: What|Removed |Added Resolution|FIXED |INVALID --- Comment #3

Re: [v9, 00/10] Add JSON vector set support to fips validation

2022-06-07 Thread David Marchand
On Tue, May 31, 2022 at 5:23 PM Akhil Goyal wrote: > > > > Subject: [v9, 00/10] Add JSON vector set support to fips validation > > > > > > Adds a very basic introduction to JSON vector sets in > > > the fips validation example application. This patch set > > > will only introduce the AES-GCM test

[PATCH] examples/fips_validation: fix link to libjansson

2022-06-07 Thread David Marchand
When compiling this example out of DPDK, linking the executable fails with: ## Building fips_validation /usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_init': fips_validation.c:(.text+0x7ab): undefined reference to `json_loadf' /usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test

RE: [PATCH v8 1/3] ethdev: introduce protocol hdr based buffer split

2022-06-07 Thread Ding, Xuan
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Saturday, June 4, 2022 10:26 PM > To: Ding, Xuan ; Wu, WenxuanX > ; tho...@monjalon.net; Li, Xiaoyun > ; ferruh.yi...@xilinx.com; Singh, Aman Deep > ; dev@dpdk.org; Zhang, Yuying > ; Zhang, Qi Z ; > jerinjac...@gmail.com > C

RE: [PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-06-07 Thread Zeng, ZhichaoX
Hi David, Harman Please review this patch at your convenience. Thanks! In addition, I tried to figure out the reason for the failure of the CI test. There is a saying that this is a problem with Asan when cancelling a thread that is waiting on epoll. After adding the '-fstack-protector-all' pa

Re: [PATCH v3 0/2] add thread priority accessors

2022-06-07 Thread David Marchand
On Tue, May 24, 2022 at 1:09 PM Tyler Retzlaff wrote: > > this series introduces accessors for get and set of thread > priority based on original patches from Narcisa Vasile. > > v3: > * synchronize exit of thread_main to maintain thread > life for duration of affinity and priority tests. >

RE: [PATCH v2] sched: enable CMAN at runtime

2022-06-07 Thread Danilewicz, MarcinX
Hi Cristian, Please find answers inline. > > Log: v2 change in rte_sched.h to avoid ABI breakage. Lessons learned, so I have fixed also positioning of this above. > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index > > ec74bee939..db14934832 100644 > > --- a/lib/sched/r

Re: [PATCH 0/4] bugfix and feature for Hisilicon DMA PMD

2022-06-07 Thread Thomas Monjalon
27/05/2022 05:40, Chengwen Feng: > This patch contains four patches for Hisilicon DMA PMD. > > Chengwen Feng (4): > dma/hisilicon: fix return last-idx when no DMA completed > app/test: support test last-idx when no DMA completed > dma/hisilicon: enhance robustness of scan CQ > dma/hisilic

[PATCH RESEND v4 0/8] Introduce support for RISC-V architecture

2022-06-07 Thread Stanislaw Kardach
RESEND: To trigger CI as all dependent patches have been merged already. This patchset adds support for building and running DPDK on 64bit RISC-V architecture. The initial support targets rv64gc (rv64imafdc) ISA and was tested on SiFive Unmatched development board with the Freedom U740 SoC running

[PATCH RESEND v4 1/8] eal: add initial support for RISC-V architecture

2022-06-07 Thread Stanislaw Kardach
From: Michal Mazurek Add all necessary elements for DPDK to compile and run EAL on SiFive Freedom U740 SoC which is based on SiFive U74-MC (ISA: rv64imafdc) core complex. This includes: - EAL library implementation for rv64imafdc ISA. - meson build structure for 'riscv' architecture. RTE_ARCH_R

[PATCH RESEND v4 2/8] net/ixgbe: enable vector stubs for RISC-V

2022-06-07 Thread Stanislaw Kardach
Re-use vector processing stubs in ixgbe PMD defined for PPC for RISC-V. This enables ixgbe PMD usage in scalar mode on this architecture. The ixgbe PMD driver was validated with Intel X520-DA2 NIC and the test-pmd application. Packet transfer checked using all UIO drivers available for non-IOMMU p

[PATCH RESEND v4 4/8] net/tap: set BPF syscall ID for RISC-V

2022-06-07 Thread Stanislaw Kardach
Define the missing __NR_bpf syscall id to enable the tap PMD. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- drivers/net/tap/meson.build | 5 - drivers/net/tap/tap_bpf.h | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/

[PATCH RESEND v4 3/8] net/memif: set memfd syscall ID on RISC-V

2022-06-07 Thread Stanislaw Kardach
Define the missing __NR_memfd_create syscall id to enable the memif PMD. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- drivers/net/memif/meson.build | 5 - drivers/net/memif/rte_eth_memif.h | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-)

[PATCH RESEND v4 5/8] examples/l3fwd: enable RISC-V operation

2022-06-07 Thread Stanislaw Kardach
Add missing em_mask_key() implementation and fix l3fwd_common.h inclusion in FIB lookup functions to enable the l3fwd to be run on RISC-V. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- examples/l3fwd/l3fwd_em.c | 8 examples/l3fwd/l3fwd_fib.c |

[PATCH RESEND v4 6/8] test/cpuflags: add test for RISC-V cpu flag

2022-06-07 Thread Stanislaw Kardach
From: Michal Mazurek Add checks for all flag values defined in the RISC-V misa CSR register. Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Michal Mazurek Signed-off-by: Stanislaw Kardach --- app/test/test_cpuflags.c | 81 1 file cha

[PATCH RESEND v4 7/8] devtools: add RISC-V to test-meson-builds.sh

2022-06-07 Thread Stanislaw Kardach
Validate RISC-V compilation when test-meson-builds.sh is called. The check will be only performed if appropriate toolchain is present on the system (same as with other architectures). Sponsored-by: Frank Zhao Sponsored-by: Sam Grove Signed-off-by: Stanislaw Kardach --- devtools/test-meson-buil

[PATCH RESEND v4 8/8] ci: add RISCV64 cross compilation job

2022-06-07 Thread Stanislaw Kardach
Checks cross-compilation using Ubuntu 20.04 x86. Signed-off-by: David Marchand Signed-off-by: Stanislaw Kardach --- .ci/linux-build.sh | 4 .github/workflows/build.yml | 11 ++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.ci/linux-build.sh b/.ci/linux-

Re: [PATCH v3] dma/idxd: add generic option for queue config

2022-06-07 Thread Thomas Monjalon
01/04/2022 12:51, Bruce Richardson: > On Fri, Apr 01, 2022 at 11:35:00AM +0100, Kevin Laatz wrote: > > The device config script currently uses some defaults to configure > > devices in a generic way. > > > > With the addition of this option, users have more control over how > > queues are configur

Re: [PATCH v8 1/3] ethdev: introduce protocol hdr based buffer split

2022-06-07 Thread Andrew Rybchenko
On 6/7/22 13:13, Ding, Xuan wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Saturday, June 4, 2022 10:26 PM To: Ding, Xuan ; Wu, WenxuanX ; tho...@monjalon.net; Li, Xiaoyun ; ferruh.yi...@xilinx.com; Singh, Aman Deep ; dev@dpdk.org; Zhang, Yuying ; Zhang, Qi Z ; jerin

Re: [PATCH] dma/skeleton: support multiple instances

2022-06-07 Thread Thomas Monjalon
Chengwen, as the maintainer of this driver, what do you think? 28/03/2022 16:40, Varghese, Vipin: > [AMD Official Use Only] > > Verified on ` AMD EPYC 7713 64-Core Processor` platform with argument ` > --vdev=dma_skeleton0,lcore=4 --vdev=dma_skeleton1,lcore=5`. > > Tested-by: Vipin Varghese

Re: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread Thomas Monjalon
07/06/2022 04:56, wenxuanx...@intel.com: > From: Wenxuan Wu > > GCC version greater than 10.0, with compile option -O2, several warnings info > would appear, > this fix omitted these warnings. [...] > # FIXME: Bugzilla 396 > -warning_flags += '-Wno-zero-length-bounds' > +warning_flags +

RE: [PATCH] dma/idxd: fix return value for pci device commands

2022-06-07 Thread Walsh, Conor
> Subject: [PATCH] dma/idxd: fix return value for pci device commands > > When sending a command to an idxd device via pci bar, the response from > HW is checked to ensure it was successful. The response was incorrectly > being negated before being returned by the function, meaning error codes >

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-07 Thread Thomas Monjalon
03/06/2022 16:36, Kevin Laatz: > During EAL init, all buses are probed and the devices found are > initialized. On eal_cleanup(), the inverse does not happen, meaning any > allocated memory and other configuration will not be cleaned up > appropriately on exit. [...] > --- a/devtools/libabigail.abi

Re: [PATCH] examples/pipeline: fix build

2022-06-07 Thread Thomas Monjalon
> > This patch fixes the following build failure seen on Ubuntu 16.04 > > with gcc 5.4.0 because of uninitialized variable: > > [..] > > examples/pipeline/cli.c:2853:9: error: 'session_id' may be used > > uninitialized in this function [-Werror=maybe-uninitialized] > > [..] > > > > Fixes

[v2] net/mlx5: support represented port item

2022-06-07 Thread Sean Zhang
Add support for represented_port item in pattern. And if the spec and mask both are NULL, translate function will not add source vport to matcher. For example, testpmd starts with PF, VF-rep0 and VF-rep1, below command will redirect packets from VF0 and VF1 to wire: testpmd> flow create 0 ingress

[v2 0/3] Add support for modifying ECN in IPv4/IPv6 header

2022-06-07 Thread Sean Zhang
This patch set adds support for modifying ECN fields in IPv4/IPv6 header, and also adds support for modify_filed action in meter. --- v2 --- rebase and add missing doc --- Sean Zhang (3): common/mlx5: add modify ECN capability check net/mlx5: add support to modify ECN field net/mlx5: add mod

[v2 1/3] common/mlx5: add modify ECN capability check

2022-06-07 Thread Sean Zhang
Flag outer_ip_ecn in header modify capabilities properties layout is added in order to check if the firmware supports modification of ecn field. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 +

[v2 3/3] net/mlx5: add modify field support in meter

2022-06-07 Thread Sean Zhang
This patch introduces MODIFY_FIELD action support in meter. User can create meter policy with MODIFY_FIELD action in green/yellow action. For example: testpmd> add port meter policy 0 21 g_actions modify_field op set dst_type ipv4_ecn src_type value src_value 3 width 2 / ... Signed-off-b

[v2 2/3] net/mlx5: add support to modify ECN field

2022-06-07 Thread Sean Zhang
This patch is to support modify ECN field in IPv4/IPv6 header. Signed-off-by: Sean Zhang Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 1 + doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/mlx5/mlx5_flow_dv.c| 20 3 files cha

Re: [PATCH v1] bbdev: add new operation for FFT processing

2022-06-07 Thread David Marchand
Hi guys, On Thu, May 26, 2022 at 8:05 AM Hemant Agrawal wrote: > On 5/26/2022 3:37 AM, Chautru, Nicolas wrote: > > Hi Hernant, > > Gentle reminder in case you can find the time. Could please have a look > > this patch for bbdev api extension. This is targeting 22.11. > > New operation type for F

[PATCH 1/3] examples/vhost: update makefile to match meson build system

2022-06-07 Thread Herakliusz Lipiec
Meson build system creates a vhost binary but Makefile and docs reference same as vhost-switch. Updating makefile to match meson. Signed-off-by: Herakliusz Lipiec --- examples/vhost/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vhost/Makefile b/examples/vh

[PATCH 2/3] doc: update vhost sample app docs

2022-06-07 Thread Herakliusz Lipiec
Vhost sample app documentation describes parameters that are not in the code and ommits parameters that exist. Also switching the order of sections on running vhost and VM, since the --client parameter in the sample line requires a socket to be created by VM. Removing uio references and updating wi

[PATCH 3/3] examples/vhost: update vhost usage message

2022-06-07 Thread Herakliusz Lipiec
updating vhost usage message to be aligned with the documentation. Signed-off-by: Herakliusz Lipiec --- examples/vhost/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index c4d46de1c5..bb1aadffa9 100644 --- a/e

RE: [EXT] [PATCH] examples/fips_validation: fix link to libjansson

2022-06-07 Thread Gowrishankar Muthukrishnan
> -Original Message- > From: David Marchand > Sent: Tuesday, June 7, 2022 3:32 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Fan Zhang ; Brian > Dooley ; Gowrishankar Muthukrishnan > ; Brandon Lo > Subject: [EXT] [PATCH] examples/fips_validation: fix link to libjansson > > External

Re: [PATCH v1] bbdev: add device status info

2022-06-07 Thread Maxime Coquelin
Hi Stephen, On 6/7/22 02:09, Stephen Hemminger wrote: On Mon, 6 Jun 2022 15:50:08 -0700 Nicolas Chautru wrote: @@ -298,6 +313,8 @@ struct rte_bbdev_driver_info { const struct rte_bbdev_op_cap *capabilities; /** Device cpu_flag requirements */ const enum rte_cpu_flag_t

[PATCH v5 0/7] introduce per-queue available descriptor threshold and host shaper

2022-06-07 Thread Spike Du
available descriptor threshold(ADT for short) is per RX queue attribute, when RX queue available descriptors for HW is below ADT, HW sends an event to application. Host shaper can configure shaper rate and avail_thresh-triggered for a host port. The shaper limits the rate of traffic from host po

[PATCH v5 1/7] net/mlx5: add LWM support for Rxq

2022-06-07 Thread Spike Du
Add lwm(Limit WaterMark) field to Rxq object which indicates the percentage of RX queue size used by HW to raise LWM event to the user. Allow LWM setting in modify_rq command. Allow the LWM configuration dynamically by adding RDY2RDY state change. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx

[PATCH v5 3/7] ethdev: introduce Rx queue based available descriptor threshold

2022-06-07 Thread Spike Du
available descriptor threshold describes the availability of a Rx queue for hardware. If the availability is below the threshold, the device will trigger the event RTE_ETH_EVENT_RX_AVAIL_THRESH. available descriptor threshold is defined as a percentage of Rx queue size with valid value of [0,99]. S

[PATCH v5 5/7] net/mlx5: support Rx queue based available descriptor threshold

2022-06-07 Thread Spike Du
Add mlx5 specific available descriptor threshold configuration and query handler. In mlx5 PMD, available descriptor threshold is also called LWM(limit watermark). While the Rx queue fullness reaches the LWM limit, the driver catches an HW event and invokes the user callback. The query handler finds

[PATCH v5 7/7] app/testpmd: add Host Shaper command

2022-06-07 Thread Spike Du
Add command line options to support host shaper configure. - Command syntax: mlx5 set port host_shaper avail_thresh_triggered <0|1> rate - Example commands: To enable avail_thresh_triggered on port 1 and disable current host shaper: testpmd> mlx5 set port 1 host_shaper avail_thresh_triggered 1

[PATCH v5 6/7] net/mlx5: add private API to config host port shaper

2022-06-07 Thread Spike Du
Host port shaper can be configured with QSHR(QoS Shaper Host Register). Add check in build files to enable this function or not. The host shaper configuration affects all the ethdev ports belonging to the same host port. Host shaper can configure shaper rate and lwm-triggered for a host port. The

Re: [PATCH] eal: fix segment fault when exit trace

2022-06-07 Thread David Marchand
On Tue, Jun 7, 2022 at 2:06 PM Chengwen Feng wrote: > > Bug scenario: > 1. start testpmd: > dpdk-testpmd -l 4-6 -a :7d:00.0 --trace=.* -- -i > 2. quit testpmd and then observed segment fault: > Bye... > Segmentation fault (core dumped) > > The root cause is that rte_tra

[PATCH v5 2/7] common/mlx5: share interrupt management

2022-06-07 Thread Spike Du
There are many duplicate code of creating and initializing rte_intr_handle. Add a new mlx5_os API to do this, replace all PMD related code with this API. Signed-off-by: Spike Du --- drivers/common/mlx5/linux/mlx5_common_os.c | 131 ++ drivers/common/mlx5/linux/mlx5_comm

[PATCH v5 4/7] net/mlx5: add LWM event handling support

2022-06-07 Thread Spike Du
When LWM meets RQ WQE, the kernel driver raises an event to SW. Use devx event_channel to catch this and to notify the user. Allocate this channel per shared device. The channel has a cookie that informs the specific event port and queue. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx5.c

RE: [PATCH v3] eventdev: add adapter instance get API

2022-06-07 Thread Jayatheerthan, Jay
Hi Ganapati, This patch could be split into multiple patches in a patchset to make it easier to review. One way to split: 1. Rx adapter API 2. Telemetry changes for Rx adapter 3. Test changes for Rx adapter API 4. Tx adapter API 5. Telemetry changes for Tx adapter ? 6. Test changes for Tx adapter

Minutes of Technical Board Meeting, 2022-06-01

2022-06-07 Thread Olivier Matz
Members Attending = 9/11 - Aaron - Bruce - Hemant - Jerin - Kevin - Maxime - Olivier (chair) - Stephen - Thomas NOTE: The technical board meetings are on every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community members are welcome to

Re: [PATCH v5 0/5] Support OFS card

2022-06-07 Thread Thomas Monjalon
> Wei Huang (5): > raw/ifpga: remove experimental tag from ifpga APIs > raw/ifpga: remove vdev when ifpga is closed > raw/ifpga: unregister interrupt in ifpga close function > raw/ifpga: support ofs card probe > guides/rawdevs: add description of ofs in ifpga doc Applied, thanks.

Re: [PATCH v4 0/4] clean up zero-length arrays

2022-06-07 Thread David Marchand
On Fri, Jun 3, 2022 at 1:16 PM Bruce Richardson wrote: > > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the result of running > that script on the DPDK repository. > > > Bruce Richardson (4): > cocci: add script for zero-length arra

Re: [PATCH v4] app/testpmd: fix slave device isn't released

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:10 AM, Dongdong Liu wrote: From: Huisong Li Currently, some eth devices are added to bond device, these devices are not released when the quit command is executed in testpmd. This patch adds the release operation for all active slaves under a bond device. Fixes: 0e545d3047fe ("ap

Re: [PATCH] drivers: rename octeon ep PMD

2022-06-07 Thread Ray Kinsella
Sathesh B Edara writes: > This patch renames octeon end point driver from > octeontx_ep to octeon_ep > > Signed-off-by: Sathesh B Edara > --- > MAINTAINERS | 6 +- > .../{octeontx_ep.ini => octeon_ep.ini}| 2 +- > doc/guides/nics/index.rst

Re: [PATCH] drivers: rename octeon ep PMD

2022-06-07 Thread Thomas Monjalon
07/06/2022 16:38, Ray Kinsella: > Sathesh B Edara writes: > > > This patch renames octeon end point driver from > > octeontx_ep to octeon_ep > > > > Signed-off-by: Sathesh B Edara > > Straight forward rename, > > Acked-by: Ray Kinsella The name change was not announced. Why is it required?

Re: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread Stephen Hemminger
On Tue, 07 Jun 2022 12:52:32 +0200 Thomas Monjalon wrote: > 07/06/2022 04:56, wenxuanx...@intel.com: > > From: Wenxuan Wu > > > > GCC version greater than 10.0, with compile option -O2, several warnings > > info would appear, > > this fix omitted these warnings. > [...] > > # FIXME: Bugzill

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-06-07 Thread David Marchand
On Tue, Jun 7, 2022 at 1:09 PM Thomas Monjalon wrote: > > 03/06/2022 16:36, Kevin Laatz: > > During EAL init, all buses are probed and the devices found are > > initialized. On eal_cleanup(), the inverse does not happen, meaning any > > allocated memory and other configuration will not be cleaned

Re: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread David Marchand
On Tue, Jun 7, 2022 at 5:10 PM Stephen Hemminger wrote: > On Tue, 07 Jun 2022 12:52:32 +0200 > Thomas Monjalon wrote: > > 07/06/2022 04:56, wenxuanx...@intel.com: > > > From: Wenxuan Wu > > > > > > GCC version greater than 10.0, with compile option -O2, several warnings > > > info would appear,

[PATCH v4] eventdev: add adapter instance get API

2022-06-07 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() and rte_event_eth_tx_adapter_instance_get() api's to get the adapter instance id for a specified event port and queue index. Signed-off-by: Ganapati Kundapura --- v4: * Moved instance array allocation and instance id storage before adapter's nb_queu

Re: [PATCH] build: fix meson build when gcc >= 10.0

2022-06-07 Thread Stephen Hemminger
On Tue, 7 Jun 2022 17:13:07 +0200 David Marchand wrote: > On Tue, Jun 7, 2022 at 5:10 PM Stephen Hemminger > wrote: > > On Tue, 07 Jun 2022 12:52:32 +0200 > > Thomas Monjalon wrote: > > > 07/06/2022 04:56, wenxuanx...@intel.com: > > > > From: Wenxuan Wu > > > > > > > > GCC version greater

Re: [PATCH] bus/fslmc: fix invalid use of default VFIO config

2022-06-07 Thread Thomas Monjalon
03/06/2022 17:18, Romain Delhomel: > At device probe, the fslmc bus driver calls rte_vfio_get_group_fd() to > get a fd associated to a vfio group. This function first checks if the > group is already opened, else it opens /dev/vfio/%u, and increases the > number of active groups in default_vfio_cfg

RE: [PATCH v1] bbdev: add device status info

2022-06-07 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 7, 2022 5:43 AM > To: Stephen Hemminger ; Chautru, Nicolas > > Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; > hemant.agra...@nxp.com; Vargas, Hernan > Subject: Re: [PATCH v1] bbdev: add device statu

Re: [PATCH V3 app/testpmd 1/4] app/testpmd: fix supported RSS offload display

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:32 AM, Huisong Li wrote: And rte_eth_dev_info.flow_type_rss_offloads is populated in terms of RTE_ETH_RSS_* bits. If PMD sets RTE_ETH_RSS_L3_SRC_ONLY to dev_info->flow_type_rss_offloads. testpmd will display "user defined 63" when run 'show port info 0'. Because testpmd use flowty

Re: [PATCH V3 app/testpmd 2/4] app/testpmd: unify RSS types display and obtaination

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:32 AM, Huisong Li wrote: The 'rss_type_table[]' maintains string name and value of RSS types. This patch unifies a common interface to display or obtain RSS types. Signed-off-by: Huisong Li Signed-off-by: Ferruh Yigit <...> @@ -5669,6 +5681,7 @@ set_record_burst_stats(uint8

Re: [PATCH V3 app/testpmd 3/4] app/testpmd: compact RSS types output in some commands

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:32 AM, Huisong Li wrote: From: Ferruh Yigit In port info command output, 'show port info all', supported RSS offload types printed one type per line, and although this information is not most important part of the command it takes big part of the command output. In port RSS has

Re: [PATCH V3 app/testpmd 4/4] app/testpmd: remove duplicated flow type to string table

2022-06-07 Thread Ferruh Yigit
On 6/7/2022 9:32 AM, Huisong Li wrote: From: Ferruh Yigit Flow type table has two instance, one is used for flow type to string conversion, and other is used for string to flow type conversion. And tables are diverged by time. Unifying tables to prevent maintaining two different tables. Not

[PATCH v3 1/7] devtools: add Atomic Rules acronyms for commit checks

2022-06-07 Thread Ed Czeck
DDM -> Downstream Data Mover MPU -> Mbuf Prefetch Unit UDM -> Upstream Data Mover Signed-off-by: Ed Czeck --- devtools/words-case.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devtools/words-case.txt b/devtools/words-case.txt index bc33470532..fa92ab273e 100644 --- a/devtools/words-

[PATCH v3 2/7] net/ark: update MPU functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for MPU (Mbuf Prefetch Unit) remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- v2: - document version compatibility between firmware and DPDK - reword commit message --- doc/guides/nics/ark.rst | 15 +++

[PATCH v3 3/7] net/ark: update DDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for DDM (Downstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware Signed-off-by: Ed Czeck --- v2: reword commit message --- drivers/net/ark/ark_ddm.c | 80 +-

[PATCH v3 4/7] net/ark: update UDM functions for firmware update

2022-06-07 Thread Ed Czeck
new firmware version for UDM (Upstream Data Mover) remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by firmware remove performance structs as they are not in the firmware module Signed-off-by: Ed Czeck --- v2: reword commit message v3: inclu

[PATCH v3 5/7] net/ark: report additional errors from firmware

2022-06-07 Thread Ed Czeck
detect and report completion errors from firmware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_rqp.c | 6 -- drivers/net/ark/ark_rqp.h | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ark/ark_rqp.c b/drivers/net/ark/ark_rqp.c index ef9ccd0706..efb9730fe6

[PATCH v3 6/7] net/ark: add new devices to support list

2022-06-07 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- v3: clarification in doc for LTS support --- doc/guides/nics/ark.rst | 7 +-- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst

[PATCH v3 7/7] net/ark: add PMD support for devices as virtual functions

2022-06-07 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- v2: feature Arkville vf support in release notes v3: feature new PCI device ids in release notes --- doc/guides/rel_notes/release_22_07.rst | 5 ++ drivers/net/ark/ark_ethdev.c

Re: [PATCH v3] build: add definitions for use as meson subproject

2022-06-07 Thread Thomas Monjalon
21/05/2022 02:54, Ben Magistro: > Currently utilizing this in an upcoming set of changes for TLDK and all > seems to be working for fallback dependency support under both shared and > static linkage. > > Reviewed-by: Ben Magistro > Tested-by: Ben Magistro > > On Fri, May 6, 2022 at 10:43 AM Bru

Re: [PATCH v1] bbdev: add device status info

2022-06-07 Thread Maxime Coquelin
Hi Nicolas, On 6/7/22 17:44, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Tuesday, June 7, 2022 5:43 AM To: Stephen Hemminger ; Chautru, Nicolas Cc: dev@dpdk.org; gak...@marvell.com; t...@redhat.com; hemant.agra...@nxp.com; Vargas, Hernan Subject

[BUG] out of bounds reference in crypto snow3g driver.

2022-06-07 Thread Stephen Hemminger
Gcc-12 finds a bug in crypto_ipsec_mb_pmd_snow3g. The code here is trying to be clever and put the crypto operations into a ring. But if there are multiple operations in will dereference outside of the valid ops. The offending line is here: enqueued_op = rte_ring_enqueue_burst(qp->ingre

Re: [PATCH] app/test: update skipped count when setup returns skipped

2022-06-07 Thread Thomas Monjalon
25/05/2022 08:10, Akhil Goyal: > > Subject: [PATCH] app/test: update skipped count when setup returns skipped > > > > If the setup function returns TEST_SKIPPED, the logs would say the test > > case is skipped while the summary count would consider it under failed > > cases. Address this by counti

Re: [PATCH v1] bbdev: add device status info

2022-06-07 Thread Stephen Hemminger
On Tue, 7 Jun 2022 18:20:38 +0200 Maxime Coquelin wrote: > Hi Nicolas, > > On 6/7/22 17:44, Chautru, Nicolas wrote: > > Hi Maxime, > > > >> -Original Message- > >> From: Maxime Coquelin > >> Sent: Tuesday, June 7, 2022 5:43 AM > >> To: Stephen Hemminger ; Chautru, Nicolas > >> > >>

[PATCH 0/4] net/ena: v2.7.0 driver release

2022-06-07 Thread Michal Krawczyk
Hi, this patchset contains 1 generic feature support (fast mbuf free), one improvement (simplification of the MTU verification), and 1 new device argument which enhances the ENA user's experience by allowing them to disable the LLQ (Low Latency Queue) mode. Thanks, Michal Dawid Gorecki (2): ne

[PATCH 1/4] net/ena: add fast mbuf free support

2022-06-07 Thread Michal Krawczyk
From: Dawid Gorecki Add support for RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload. It can be enabled if all the mbufs for a given queue belong to the same mempool and their reference count is equal to 1. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes Reviewed-

[PATCH 2/4] net/ena: skip MTU verification

2022-06-07 Thread Michal Krawczyk
From: Dawid Gorecki Remove MTU verification from ena_mtu_set() and ena_start(). It is done by rte_ethdev already, so there is no reason to repeat it inside the ENA driver. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes Reviewed-by: Amit Bernstein --- dri

[PATCH 3/4] net/ena: add an option to disable LLQ

2022-06-07 Thread Michal Krawczyk
The PMD attempts to enable the LLQ (Low Latency Queue) whenever it's possible. The LLQ requires the user to enable the Write Combining for the supported igb_uio/vfio-pci modules. The vfio-pci module officially doesn't support the WC. Moreover, in some Linux distributions, it can be built into the

  1   2   >