sriov net_mlx5 error - Unexpected error in DR drop action support detection

2022-03-31 Thread Yaron Illouz
Hi I am using dpd19.11 and having error when trying to use sriov vf of a mlx5 100G card net_mlx5: Unexpected error in DR drop action support detection The same code work for pf I am not trying to do filtering on nic, but just to read from the port, 1 rx queue, 1 tx queue Network devices usin

Re: [PATCH v2] eal: add seqlock

2022-03-31 Thread Mattias Rönnblom
On 2022-03-30 16:26, Mattias Rönnblom wrote: > A sequence lock (seqlock) is synchronization primitive which allows > for data-race free, low-overhead, high-frequency reads, especially for > data structures shared across many cores and which are updated with > relatively infrequently. > > Some qu

Re: [RFC PATCH v2 4/9] vhost: fix async access

2022-03-31 Thread Maxime Coquelin
Hi Jiayu, On 3/30/22 15:49, David Marchand wrote: vq->async accesses must be protected with vq->access_lock. Fixes: eb666d24085f ("vhost: fix async unregister deadlock") Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async vhost") Cc: sta...@dpdk.org Signed-off-by: David Mar

Re: [PATCH] app/testpmd: fix quit testpmd with vfs and pf

2022-03-31 Thread Singh, Aman Deep
On 3/28/2022 3:36 PM, Singh, Aman Deep wrote: On 3/22/2022 12:48 PM, Ke Zhang wrote: When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port val

Re: [PATCH v2] eal: add seqlock

2022-03-31 Thread Ola Liljedahl
On 3/31/22 09:46, Mattias Rönnblom wrote: On 2022-03-30 16:26, Mattias Rönnblom wrote: A sequence lock (seqlock) is synchronization primitive which allows for data-race free, low-overhead, high-frequency reads, especially for data structures shared across many cores and which are updated with

Re: [RFC,v3 1/2] vhost: support async dequeue for split ring

2022-03-31 Thread Maxime Coquelin
On 3/10/22 07:54, xuan.d...@intel.com wrote: From: Xuan Ding This patch implements asynchronous dequeue data path for vhost split ring, with dmadev library integrated. Signed-off-by: Xuan Ding Signed-off-by: Yuan Wang --- lib/vhost/rte_vhost_async.h | 37 ++- lib/vhost/version.map

Re: [RFC PATCH v2 2/9] eal: annotate spinlock and rwlock

2022-03-31 Thread David Marchand
On Wed, Mar 30, 2022 at 3:50 PM David Marchand wrote: > diff --git a/lib/eal/include/generic/rte_rwlock.h > b/lib/eal/include/generic/rte_rwlock.h > index da9bc3e9c0..dabbac0131 100644 > --- a/lib/eal/include/generic/rte_rwlock.h > +++ b/lib/eal/include/generic/rte_rwlock.h [snip] > @@ -90,7 +9

RE: [PATCH v2] eal: add seqlock

2022-03-31 Thread Morten Brørup
> From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Thursday, 31 March 2022 11.05 > > On 3/31/22 09:46, Mattias Rönnblom wrote: > > On 2022-03-30 16:26, Mattias Rönnblom wrote: > >> A sequence lock (seqlock) is synchronization primitive which allows > >> for data-race free, low-overhead,

Re: [PATCH v2] eal: add seqlock

2022-03-31 Thread Ola Liljedahl
On 3/31/22 11:25, Morten Brørup wrote: From: Ola Liljedahl [mailto:ola.liljed...@arm.com] Sent: Thursday, 31 March 2022 11.05 On 3/31/22 09:46, Mattias Rönnblom wrote: On 2022-03-30 16:26, Mattias Rönnblom wrote: A sequence lock (seqlock) is synchronization primitive which allows for data-r

Re: 19.11.12 patches review and test

2022-03-31 Thread Christian Ehrhardt
On Wed, Mar 30, 2022 at 1:04 PM Jiang, YuX wrote: > > -Original Message- > > From: christian.ehrha...@canonical.com > > > Sent: Monday, March 21, 2022 7:55 PM > > To: sta...@dpdk.org > > Cc: dev@dpdk.org; Abhishek Marathe ; > > Ali Alnubani ; Walker, Benjamin > > ; David Christensen > >

RE: [PATCH v2] eal: add seqlock

2022-03-31 Thread Morten Brørup
> From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Thursday, 31 March 2022 11.39 > > On 3/31/22 11:25, Morten Brørup wrote: > >> From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > >> Sent: Thursday, 31 March 2022 11.05 > >> > >> On 3/31/22 09:46, Mattias Rönnblom wrote: > >>> On 2022-0

Re: [PATCH v2] net/dpaa2: fix dpdmux default interface

2022-03-31 Thread Hemant Agrawal
Acked-by:  Hemant Agrawal On 3/30/2022 3:31 AM, Tianli Lai wrote: if dpdmux objects created by restool tools with the argument "--default-if=", this function would change it to 1 Fixes: 1def64c2d79e ("net/dpaa2: add dpdmux initialization and configuration") Cc: nipun.gu...@nxp.com Signed-off-

RE: [RFC PATCH v2 4/9] vhost: fix async access

2022-03-31 Thread Hu, Jiayu
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 31, 2022 4:00 PM > To: David Marchand ; dev@dpdk.org > Cc: Xia, Chenbo ; Hu, Jiayu ; > Wang, YuanX ; Ding, Xuan ; > sta...@dpdk.org; Patrick Fu > Subject: Re: [RFC PATCH v2 4/9] vhost: fix async access > > Hi Jiayu, >

Re: 20.11.5 patches review and test

2022-03-31 Thread Christian Ehrhardt
On Mon, Mar 28, 2022 at 5:29 PM Luca Boccassi wrote: > On Mon, 2022-03-28 at 14:55 +0200, Christian Ehrhardt wrote: > > > > > > On Mon, Mar 28, 2022 at 1:50 PM Luca Boccassi > > wrote: > > > On Mon, 2022-03-28 at 09:40 +0200, Christian Ehrhardt wrote: > > > > On Fri, Mar 18, 2022 at 4:21 PM wro

Re: 19.11.12 patches review and test

2022-03-31 Thread Christian Ehrhardt
Hi (to myself) exercised tests that I usually run for Ubuntu 1.0.0 (12:51:18): phys (BM) tests 1.1.0 (12:51:18): initialize environment 1.1.1 (12:54:03): testpmd => Pass 1.1.2 (12:54:51): check testpmd output => Pass 2.0.0 (12:54:51): prep virtual test environment 1.0.0 (12:58:39): vi

RE: [RFC,v3 1/2] vhost: support async dequeue for split ring

2022-03-31 Thread Ding, Xuan
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 31, 2022 5:15 PM > To: Ding, Xuan ; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil ; > lian...@liangbit.com; Wang, YuanX > Subject: Re: [RFC,v3 1/2] vhost: support async dequeue f

Re: [PATCH v2] eal: add seqlock

2022-03-31 Thread Ola Liljedahl
I think lock()/unlock() should be avoided in the read operation names, because no lock is taken during read. I like the critical region begin()/end() names. I was following the naming convention of rte_rwlock. Isn't the seqlock just a more scalable implementation of a reader/writer lock? I se

RE: [PATCH v2] eal: add seqlock

2022-03-31 Thread Morten Brørup
> From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Thursday, 31 March 2022 13.44 > > > >>> I think lock()/unlock() should be avoided in the read operation > >>> names, because no lock is taken during read. I like the critical > region > >>> begin()/end() names. > >> I was following the

Re: 20.11.5 patches review and test

2022-03-31 Thread Luca Boccassi
On Thu, 31 Mar 2022 at 11:51, Christian Ehrhardt wrote: > > > > On Mon, Mar 28, 2022 at 5:29 PM Luca Boccassi wrote: >> >> On Mon, 2022-03-28 at 14:55 +0200, Christian Ehrhardt wrote: >> > >> > >> > On Mon, Mar 28, 2022 at 1:50 PM Luca Boccassi >> > wrote: >> > > On Mon, 2022-03-28 at 09:40 +020

Re: [PATCH] app/pdump: close program if --pdump argument is missing

2022-03-31 Thread Usman Tanveer
The 20.11 release is not coming out till August, in the meantime, this patch can be applied to print help if mandatory argument is not passed. On Wed, Mar 2, 2022 at 9:52 PM Stephen Hemminger wrote: > > On Wed, 2 Mar 2022 14:26:14 +0500 > "usman.tanveer" wrote: > > > --pdump is a mandatory arg

[PATCH] doc: add eal_args.include to toctree

2022-03-31 Thread Kevin Traynor
A warning is observed on RHEL 8.4. [1/1] Generating html_guides with a custom command /root/dpdk/doc/guides/linux_gsg/eal_args.include.rst: WARNING: document isn't included in any toctree Add file to toctree to remove warning. Fixes: 3ee567cfec37 ("doc: document all EAL parameters in one place")

Re: [PATCH v2] eal: add seqlock

2022-03-31 Thread Mattias Rönnblom
On 2022-03-31 11:04, Ola Liljedahl wrote: > > On 3/31/22 09:46, Mattias Rönnblom wrote: >> On 2022-03-30 16:26, Mattias Rönnblom wrote: >>> A sequence lock (seqlock) is synchronization primitive which allows >>> for data-race free, low-overhead, high-frequency reads, especially for >>> data struct

Re: [PATCH] doc: add eal_args.include to toctree

2022-03-31 Thread Bruce Richardson
On Thu, Mar 31, 2022 at 02:26:54PM +0100, Kevin Traynor wrote: > A warning is observed on RHEL 8.4. > > [1/1] Generating html_guides with a custom command > /root/dpdk/doc/guides/linux_gsg/eal_args.include.rst: > WARNING: document isn't included in any toctree > > Add file to toctree to remove wa

Re: [PATCH v2] eal: add seqlock

2022-03-31 Thread Mattias Rönnblom
On 2022-03-31 11:25, Morten Brørup wrote: >> From: Ola Liljedahl [mailto:ola.liljed...@arm.com] >> Sent: Thursday, 31 March 2022 11.05 >> >> On 3/31/22 09:46, Mattias Rönnblom wrote: >>> On 2022-03-30 16:26, Mattias Rönnblom wrote: A sequence lock (seqlock) is synchronization primitive which a

Re: [PATCH v2] eal: add seqlock

2022-03-31 Thread Mattias Rönnblom
On 2022-03-31 13:44, Ola Liljedahl wrote: > I think lock()/unlock() should be avoided in the read operation names, because no lock is taken during read. I like the critical region begin()/end() names. >>> I was following the naming convention of rte_rwlock. Isn't the seqlock >>> jus

[PATCH] common/mlx5: fix MR range calculation

2022-03-31 Thread Dmitry Kozlyuk
MR end for a mempool chunk may be calculated incorrectly. For example, for chunk with addr=1.5M and len=1M with 2M page size the range would be [0, 2M), while the proper result is [0, 4M). Fix the calculation. Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities") Cc: sta...@dpdk

Re: [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind

2022-03-31 Thread Burakov, Anatoly
On 21-Mar-22 12:27 PM, Fidaullah Noonari wrote: binding with vfio driver, when IOMMU is disabled, causes program to crash. this patch adds a flag for noiommmu-mode. when this is set, if IOMMU is disabled, it changes vfio into unsafe noiommu mode and prints warning message. Signed-off-by: Fidaull

[PATCH] net/mlx5: fix TxQ failure when inlining is impossible

2022-03-31 Thread Dmitry Kozlyuk
When txq_inline_max is too large and an mbuf is multi-segment it may be impossible to inline data and build a valid WQE, because WQE length would be larger then HW can represent. It is impossible to detect misconfiguration at startup, because the condition depends on the mbuf composition. The check

Re: [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind

2022-03-31 Thread Bruce Richardson
On Thu, Mar 31, 2022 at 03:37:40PM +0100, Burakov, Anatoly wrote: > On 21-Mar-22 12:27 PM, Fidaullah Noonari wrote: > > binding with vfio driver, when IOMMU is disabled, causes program to crash. > > this patch adds a flag for noiommmu-mode. when this is set, if IOMMU is > > disabled, it changes vfi

Re: [PATCH] eal/linux: enable the hugepage mem dump

2022-03-31 Thread Burakov, Anatoly
On 08-Mar-22 9:41 AM, Li Feng wrote: These hugepages include important structures. We should dump these hugepages into a coredump file for debugging when generating a coredump. Signed-off-by: Li Feng --- lib/eal/linux/eal_memalloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/e

Re: [PATCH v2] eal: add seqlock

2022-03-31 Thread Ola Liljedahl
(Thunderbird suddenly refuses to edit in plain text mode, hope the mail gets sent as text anyway) On 3/31/22 15:38, Mattias Rönnblom wrote: On 2022-03-31 11:04, Ola Liljedahl wrote: On 3/31/22 09:46, Mattias Rönnblom wrote: On 2022-03-30 16:26, Mattias Rönnblom wrote: Should the rte_seql

Re: [PATCH] dma/idxd: add generic option for queue config

2022-03-31 Thread Bruce Richardson
On Wed, Mar 30, 2022 at 04:07:00PM +0100, Kevin Laatz wrote: > The device config script currently uses some defaults to configure > devices in a generic way. > > With the addition of this option, users have more control over how > queues are configured. > > Signed-off-by: Kevin Laatz > --- > dr

Re: [PATCH] dma/idxd: add generic option for queue config

2022-03-31 Thread Kevin Laatz
On 31/03/2022 15:57, Bruce Richardson wrote: On Wed, Mar 30, 2022 at 04:07:00PM +0100, Kevin Laatz wrote: The device config script currently uses some defaults to configure devices in a generic way. With the addition of this option, users have more control over how queues are configured. Signe

Re: [PATCH] doc: add eal_args.include to toctree

2022-03-31 Thread Kevin Traynor
On 31/03/2022 14:51, Bruce Richardson wrote: On Thu, Mar 31, 2022 at 02:26:54PM +0100, Kevin Traynor wrote: A warning is observed on RHEL 8.4. [1/1] Generating html_guides with a custom command /root/dpdk/doc/guides/linux_gsg/eal_args.include.rst: WARNING: document isn't included in any toctree

[PATCH v2] dma/idxd: add generic option for queue config

2022-03-31 Thread Kevin Laatz
The device config script currently uses some defaults to configure devices in a generic way. With the addition of this option, users have more control over how queues are configured. Signed-off-by: Kevin Laatz --- drivers/dma/idxd/dpdk_idxd_cfg.py | 39 --- 1 file ch

[PATCH v2] dmadev: add telemetry support

2022-03-31 Thread Sean Morrissey
Telemetry commands are now registered through the dmadev library for the gathering of DSA stats. The corresponding callback functions for listing dmadevs and providing info and stats for a specific dmadev are implemented in the dmadev library. An example usage can be seen below: Connecting to /va

[PATCH 0/3] doc: build on Windows

2022-03-31 Thread Dmitry Kozlyuk
Enable biulding documentation on Windows natively. Thanks to Vipin for raising the issue. Dmitry Kozlyuk (3): doc: simplify CSS customization for Doxygen doc: fix API index Markdown syntax doc: rewrite shell scripts in Python doc/api/custom.css | 6 + doc/api/doxy-api-index.md

[PATCH 1/3] doc: simplify CSS customization for Doxygen

2022-03-31 Thread Dmitry Kozlyuk
CSS for API documentation was customized by a shell script modifying the file that Doxygen produces. This way CSS code is kept in a script and an extra build step is added. Move custom style to a plain CSS file. Use Doxygen capability to attach this extra stylesheet. Signed-off-by: Dmitry Kozlyuk

[PATCH 2/3] doc: fix API index Markdown syntax

2022-03-31 Thread Dmitry Kozlyuk
API documentation index had spaces between link caption and URL, which may be unsupported by some Markdown implementations. That is, "[caption](URL)" is valid but "[caption] (URL)" is not. The problematic behavior is observed with Doxygen on Windows. Remove the spaces. Unfortunately, Markdown synta

[PATCH 3/3] doc: rewrite shell scripts in Python

2022-03-31 Thread Dmitry Kozlyuk
Shell used in documentation generation could not run on Windows. Rewrite scripts in Python. New scripts use proper path separators and handle paths with spaces. Signed-off-by: Dmitry Kozlyuk --- doc/api/generate_doxygen.py | 19 +++ doc/api/generate_doxygen.sh | 12

[PATCH v1] net/ice: fix not support VXLAN RSS hash in raw flow

2022-03-31 Thread Ting Xu
When creating raw flow RSS hash rule for VXLAN tunnel type, a step to set VXLAN tunnel config is missed. This patch adds this set to support VXLAN in RSS hash with raw pattern. Fixes: 1b9c68120a1c ("net/ice: enable protocol agnostic flow offloading in RSS") Cc: sta...@dpdk.org Signed-off-by: Ting

[RFC 0/6] net/mlx5: introduce limit watermark and host shaper

2022-03-31 Thread Spike Du
LWM(limit watermark) is per RX queue attribute, when RX queue fullness reach the LWM limit, HW sends an event to dpdk application. Host shaper can configure shaper rate and lwm-triggered for a host port. The shaper limits the rate of traffic from host port to wire port. If lwm-triggered is enabled,

[RFC 1/6] net/mlx5: add LWM support for Rxq

2022-03-31 Thread Spike Du
Add lwm(Limit WaterMark) field to Rxq object which indicates the percentage of RX queue size used by HW to raise LWM event to the user. Allow LWM setting in modify_rq command. Allow the LWM configuration dynamically by adding RDY2RDY state change. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx

[RFC 2/6] common/mlx5: share interrupt management

2022-03-31 Thread Spike Du
There are many duplicate code of creating and initializing rte_intr_handle. Add a new mlx5_os API to do this, replace all PMD related code with this API. Signed-off-by: Spike Du --- drivers/common/mlx5/linux/mlx5_common_os.c | 131 ++ drivers/common/mlx5/linux/mlx5_comm

[RFC 3/6] net/mlx5: add LWM event handling support

2022-03-31 Thread Spike Du
When LWM meets RQ WQE, the kernel driver raises an event to SW. Use devx event_channel to catch this and to notify the user. Allocate this channel per shared device. The channel has a cookie that informs the specific event port and queue. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx5.c

[RFC 4/6] net/mlx5: add private API to configure Rxq LWM

2022-03-31 Thread Spike Du
The new API allows setting/unsetting/modifying an LWM(limit watermark) event per Rxq. While the Rx queue fullness reaches the LWM limit, the driver catches an HW event and invokes the user callback. Signed-off-by: Spike Du --- doc/guides/nics/mlx5.rst | 4 ++ doc/guides/rel_notes/

[RFC 5/6] net/mlx5: add private API to config host port shaper

2022-03-31 Thread Spike Du
Host port shaper can be configured with QSHR(QoS Shaper Host Register). Add check in build files to enable this function or not. The host shaper configuration affects all the ethdev ports belonging to the same host port. Host shaper can configure shaper rate and lwm-triggered for a host port. The

[RFC 6/6] app/testpmd: add LWM and Host Shaper command

2022-03-31 Thread Spike Du
Add command line options to support LWM per-rxq configure. - Command syntax: set port rxq lwm set port host_shaper lwm_triggered <0|1> rate - Example commands: To configure LWM as 30% of rxq size on port 1 rxq 0: testpmd> set port 1 rxq 0 lwm 30 To disable LWM on port 1 rxq 0: testpmd> s

Re: dpdk rte rss flow with sriov

2022-03-31 Thread Asaf Penso
I understand your scenario. I want referring to action VF. Can you share the testpmd commands line you use in the VM? Regards, Asaf Penso From: Yaron Illouz Sent: Tuesday, March 29, 2022 5:33:39 PM To: Asaf Penso ; us...@dpdk.org ; dev@dpdk.org Subject: RE: dpd