RE: [RFC] eal: add seqlock

> diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build > index 9700494816..48df5f1a21 100644 > --- a/lib/eal/include/meson.build > +++ b/lib/eal/include/meson.build > @@ -36,6 +36,7 @@ headers += files( > 'rte_per_lcore.h', > 'rte_random.h', > 'rte_recip

[PATCH v4 00/16] add virtio_blk device support to vdpa/ifc

This patch set add virtio_blk device support to vdpa/ifc driver. With a lot of similarities, I re-use part of vdpa/ifc driver. Distinguish the virtio net and blk device by device id, and implement specific features and ops. Add example to vdpa to support virtio_blk device. To support blk device li

[PATCH v4 01/16] vdpa/ifc: add support for virtio blk device

Re-use the vdpa/ifc code, distinguish blk and net device by pci_device_id. Blk and net device are implemented with proper feature and ops. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/base/ifcvf.h | 16 +++- drivers/vdpa/ifc/ifcvf_vdpa.c | 92 +++

[PATCH v4 02/16] vhost: add vdpa ops for blk device

Get_config and set_config are necessary ops for blk device. Add get_config and set_config ops to vdpa ops. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- lib/vhost/vdpa_driver.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vdpa_driver.h b/lib/v

[PATCH v4 03/16] vhost: add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG

Add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG. VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG message is only supported by virtio blk VDPA device. Signed-off-by: Andy Pei --- lib/vhost/vhost_user.c | 50 ++ lib/vhost/vhost_user.h

[PATCH v4 04/16] vdpa/ifc: add blk ops for ifc device

For virtio blk device, re-use part of ifc driver ops. Implement ifcvf_blk_get_config for virtio blk device. Support VHOST_USER_PROTOCOL_F_CONFIG feature for virtio blk device. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin --- drivers/vdpa/ifc/base/ifcvf.h | 4 ++ drivers/vdpa/ifc/ifcvf_

[PATCH v4 05/16] vdpa/ifc: add vdpa interrupt for blk device

For the block device type, we have to relay the commands on all queues. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 46 --- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifc

[PATCH v4 06/16] vdpa/ifc: add block device SW live-migration

Add SW live-migration support to block device. Add dirty page logging to block device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 4 +- drivers/vdpa/ifc/base/ifcvf.h | 6 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 128 +++--- 3 files changed, 115

[PATCH v4 07/16] example/vdpa:add vdpa blk support in example

Add virtio blk device support to vdpa example. Signed-off-by: Andy Pei --- examples/vdpa/main.c | 61 +- examples/vdpa/vdpa_blk_compact.h | 72 + examples/vdpa/vhost_user.h | 169 +++ 3 files changed, 301 inserti

[PATCH v4 08/16] usertools: add support for virtio blk device

Signed-off-by: Andy Pei --- usertools/dpdk-devbind.py | 8 1 file changed, 8 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index ace4627..cbe336f 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -14,6 +14,8 @@ from os.path imp

[PATCH v4 09/16] vdpa/ifc: set_vring_state op is mandatory, add set_vring_state for blk device

Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index a23dc2d..28191e4 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf_v

[PATCH v4 10/16] vdpa/ifc: add some log at VDPA lauch before qemu connect

Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 28191e4..9bc2f47 100644 --- a/drivers/vdpa/ifc/ifcvf_vdpa.c +++ b/drivers/vdpa/ifc/ifcvf

[PATCH v4 11/16] vdpa/ifc: read virtio max_queues from hardware

original code max_queues is set to IFCVF_MAX_QUEUES. New code max_queues is the min of IFCVF_MAX_QUEUES and hardware num_queues. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcv

[PATCH v4 12/16] vdpa: add config space change interrupt register and handle for virtio_blk

Create a thread to poll and relay config space change interrupt. Use VHOST_USER_SLAVE_CONFIG_CHANGE_MSG to info qemu. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/ifcvf_vdpa.c | 113 ++ 1 file changed, 113 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf

[PATCH v4 13/16] vdpa/ifc: add is_blk flag to ifcvf_hw, and init is_blk during probe

Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 1 + drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h index 6dd7925..8e602af 100644 --- a/drivers/vdpa/ifc/base/ifcvf.h +++ b/drivers/vdpa/

[PATCH v4 14/16] vdpa/ifc/base: for blk device, live migration register is different from net device

1.last_avail_idx is lower 16 bit of the register. 2.address of ring_state register is different between net and blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 36 +--- drivers/vdpa/ifc/base/ifcvf.h | 1 + 2 files changed, 30 insertions(+)

[PATCH v4 15/16] vdpa/ifc: make sure hardware last_avail_idx and last_used_idx is the same when blk device pause

Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 2 +- drivers/vdpa/ifc/base/ifcvf.h | 3 +++ drivers/vdpa/ifc/ifcvf_vdpa.c | 32 +++- 3 files changed, 27 insertions(+), 10 deletions(-) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/if

[PATCH v4 16/16] vhost: make sure each queue callfd is configured

During the vhost data path building process, qemu will create a call fd at first, and create another call fd in the end. The final call fd will be used to relay notify. In the original code, after kick fd is set, dev_conf will set the first call fd. Even though the actual call fd will set, the data

Re: [RFC] eal: add seqlock

On 2022-03-27 16:49, Ananyev, Konstantin wrote: >> diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build >> index 9700494816..48df5f1a21 100644 >> --- a/lib/eal/include/meson.build >> +++ b/lib/eal/include/meson.build >> @@ -36,6 +36,7 @@ headers += files( >> 'rte_per_lco

Re: [PATCH v4 08/16] usertools: add support for virtio blk device

On Sun, 27 Mar 2022 22:51:31 +0800 Andy Pei wrote: > Signed-off-by: Andy Pei Shouldn't we just recommend driverctl instead? I had patches for devbind to use vmbus rejected because of that.

[PATCH v2] net/ice: fix raw flow input pattern value change in FDIR

When parsing raw flow pattern in FDIR, the input parameter spec and mask are used directly and the original value will be changed. It will cause error if these values are used in other functions. In this patch, temporary variables are created to store the spec and mask. Fixes: 25be39cc1760 ("net/i

[PATCH] vhost: fix null pointer dereference

NULL check for vq->async must be protected by lock. Otherwise, it is possible that the data plane thread dereferences vq->async with NULL value, since the control plane thread is freeing vq->async. Fixes: ee8024b3d4ad (vhost: move async data in dedicated structure) Cc: sta...@dpdk.org Signed-off-

[Bug 944] [dpdk 22.03-rc2] inline_ipsec/test_Ipsec_Encryption_Rss: run dpdk-ipsec-secgw with assigned parameter fail

https://bugs.dpdk.org/show_bug.cgi?id=944 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Resolution|--- |INVALID CC|

RE: [PATCH] usertools: enhance logic to display NUMA

[AMD Official Use Only] Hi Thomas, 26/03/2022 08:32, Vipin Varghese: > enhance python logic to accomadate NUMA information. Current logic > considers physical socket with CPU threads to core map. With new AMD > SKU vairant NUMA is no longer same as SOCKET. Single physical socket > can be pa

RE: [PATCH] meson: update doc logic for Windows

[AMD Official Use Only] Hi Thomas, Thank you for looking at this problem. 26/03/2022 03:59, Vipin Varghese: > Support for shell scripts doxy-html-custom, generate_doxygen and > generate_examples are absent. The current patch address the same by > disabling document build notifying the user.

RE: [RFC v2 1/2] vhost: support clear in-flight packets for async dequeue

Hi Yuan, Thanks for the patch, comment inline. > +uint16_t > +rte_vhost_clear_queue(int vid, uint16_t queue_id, struct rte_mbuf **pkts, > + uint16_t count, int16_t dma_id, uint16_t vchan_id) { > + struct virtio_net *dev = get_device(vid); > + struct vhost_virtqueue *vq; > +

[PATCH 4/4] net/cnxk: add barrier after meta batch free in scalar

Add barrier after meta batch free in scalar routine when lmt lines are exactly full to make sure that next LMT line user in Tx only starts writing the lines only when previous stoerl's are complete. Fixes: 4382a7ccf781 ("net/cnxk: support Rx security offload on cn10k") Cc: sta...@dpdk.org Signed-

[PATCH 1/4] common/cnxk: use aggregate level rr prio from mbox

Use aggregate level Round Robin Priority from mbox response instead of fixing it to single macro. This is useful when kernel AF driver changes the constant. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_priv.h | 5 +++-- drivers/common/cnxk/roc_nix_tm.c | 3 ++- driv

[PATCH 2/4] net/cnxk: support loopback mode on AF VF's

Support internal loopback mode on AF VF's using RoC by setting Tx channel same as Rx channel. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cnxk_ethdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 1fa41

[PATCH 3/4] net/cnxk: update LBK ethdev link info

Update link info of LBK ethdev i.e AF's VF's as always up and 100G. This is because there is no phy for the LBK interfaces and we won't get a link update notification for the same. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cnxk_link.c | 11 +++ 1 file changed, 11 insertions(+

[PATCH 4/4] net/cnxk: add barrier after meta batch free in scalar

Add barrier after meta batch free in scalar routine when lmt lines are exactly full to make sure that next LMT line user in Tx only starts writing the lines only when previous stoerl's are complete. Fixes: 4382a7ccf781 ("net/cnxk: support Rx security offload on cn10k") Cc: sta...@dpdk.org Signed-