Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior

2022-03-24 Thread Harold Huang
Hi, all, On Thu, Mar 3, 2022 at 12:59 AM Stephen Hemminger wrote: > > On Wed, 02 Mar 2022 15:46:37 +0100 > Thomas Monjalon wrote: > > > 02/03/2022 15:07, Ori Kam: > > > From: lihuisong (C) > > > > 在 2022/3/1 0:42, Ferruh Yigit 写道: > > > > > On 2/28/2022 3:21 AM, Min Hu (Connor) wrote: > > > > >

RE: [PATCH v1] net/ice: support 256 queues

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Thursday, March 24, 2022 1:13 PM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wu, Wenjun1 > Subject: [PATCH v1] net/ice: support 256 queues > > 256 queues can be allowed now. This patch improves the code to support 256 > queu

Re: [PATCH] eal: factorize lcore main loop

2022-03-24 Thread Tyler Retzlaff
On Wed, Mar 23, 2022 at 10:30:01AM +0100, David Marchand wrote: > All OS implementations provide the same main loop. > Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation > between main and threads and factorize the rest as common code. > Thread id are now logged as string in

Intel roadmap for 22.07

2022-03-24 Thread Mcnamara, John
The following are the proposed Intel roadmap items for DPDK 22.07: * dmadev library add telemetry support * pipeline connection tracking improvements * pipeline packet mirroring support * pipeline hash support * pipeline default action arguments * ethdev library add protocol-based header split API

RE: [PATCH v3] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, March 24, 2022 9:01 AM > To: Daly, Jeff ; dev@dpdk.org > Cc: Stephen Douthit ; Daly, Jeff > > Subject: RE: [PATCH v3] net/ixgbe: Retry SFP ID read field to handle > misbehaving SFPs Slightly reword the title as below to fix c

RE: [PATCH] net/iavf: replace SMP barrier with thread fence

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Kathleen Capella > Sent: Tuesday, March 8, 2022 3:27 AM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; n...@arm.com; honnappa.nagaraha...@arm.com; > joyce.k...@arm.com; Kathleen Capella > Subject: [PATCH] net/iavf: replace SMP barrier with thread fe

RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, March 16, 2022 4:12 PM > To: Yang, SteveX ; dev@dpdk.org > Cc: Wu, Jingjing ; Zhang, Qi Z > ; sta...@dpdk.org > Subject: RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid > > > > > -Original Message- >

RE: [PATCH v1] net/i40e: remove redundant number of packets check

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, March 4, 2022 7:10 PM > To: Zhang, Qi Z ; Feifei Wang > ; Xing, Beilei ; David > Christensen ; Richardson, Bruce > ; Ananyev, Konstantin > ; Ruifeng Wang > Cc: dev@dpdk.org; n...@arm.com; Honnappa Nagarahalli > ; Thomas Monjalon

RE: [PATCH v4] net/ice: improve performance of RX timestamp offload

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Monday, February 28, 2022 3:36 PM > To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > > Cc: Van Haaren, Harry ; Su, Simei > ; Wu, Wenjun1 > Subject: [PATCH v4] net/ice: improve performance of RX timestamp offload > > Previously, each time

[PATCH v1] lib: remove x86 atomic header loop include

2022-03-24 Thread Haiyue Wang
Remove the x86 top atomic header include from the architecture related header file, since this x86 top atomic header file has included them. Signed-off-by: Haiyue Wang --- lib/eal/x86/include/rte_atomic_32.h | 1 - lib/eal/x86/include/rte_atomic_64.h | 1 - 2 files changed, 2 deletions(-) diff

RE: [PATCH] net/i40e: Populate error in flow_parse_fdir_pattern

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: David Marchand > Sent: Tuesday, March 22, 2022 4:36 PM > To: Mike Pattrick > Cc: Xing, Beilei ; murphyx.y...@intel.com; dev > ; dpdk stable > Subject: Re: [PATCH] net/i40e: Populate error in flow_parse_fdir_pattern > Renamed title to "net/i40e: populate

[Bug 978] [dpdk-19.11.12-rc1] drivers/net/qede make build failed on Fedora35 with Clang13.0.0

2022-03-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=978 Bug ID: 978 Summary: [dpdk-19.11.12-rc1] drivers/net/qede make build failed on Fedora35 with Clang13.0.0 Product: DPDK Version: 19.11 Hardware: All OS: All

Re: [PATCH v4] net/ice: improve performance of RX timestamp offload

2022-03-24 Thread Kevin Traynor
On 24/03/2022 09:09, Zhang, Qi Z wrote: -Original Message- From: Wu, Wenjun1 Sent: Monday, February 28, 2022 3:36 PM To: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming Cc: Van Haaren, Harry ; Su, Simei ; Wu, Wenjun1 Subject: [PATCH v4] net/ice: improve performance of RX timestamp offload

Re: DPDK seqlock

2022-03-24 Thread Mattias Rönnblom
On 2022-03-24 05:52, Honnappa Nagarahalli wrote: > > >> Hi Mattias, >> >>> Would it make sense to have a seqlock implementation in DPDK? > I do not have any issues with adding the seqlock to DPDK. > > However, I am interested in understanding the use case. As I understand, > seqlock is a type of

RE: [PATCH v4] net/ice: improve performance of RX timestamp offload

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor > Sent: Thursday, March 24, 2022 7:17 PM > To: Zhang, Qi Z ; Wu, Wenjun1 > ; dev@dpdk.org; Yang, Qiming > > Cc: Van Haaren, Harry ; Su, Simei > ; Luca Boccassi ; Christian Ehrhardt > > Subject: Re: [PATCH v4] net/ice: improve performance of RX

Re: [PATCH v4] net/ice: improve performance of RX timestamp offload

2022-03-24 Thread Kevin Traynor
On 24/03/2022 11:51, Zhang, Qi Z wrote: -Original Message- From: Kevin Traynor Sent: Thursday, March 24, 2022 7:17 PM To: Zhang, Qi Z ; Wu, Wenjun1 ; dev@dpdk.org; Yang, Qiming Cc: Van Haaren, Harry ; Su, Simei ; Luca Boccassi ; Christian Ehrhardt Subject: Re: [PATCH v4] net/ice: im

[PATCH v2 0/5] vhost: introduce per-virtqueue stats API

2022-03-24 Thread Maxime Coquelin
This series introduces a new Vhost API that provides per-virtqueue statistics to the application. It will be generally useful, but initial motivation for this series was to be able to get to get virtqueues stats when Virtio RSS feature will be supported in Vhost library. First patch is a fix that

[PATCH v2 2/5] vhost: add per-virtqueue statistics support

2022-03-24 Thread Maxime Coquelin
This patch introduces new APIs for the application to query and reset per-virtqueue statistics. The patch also introduces generic counters. Signed-off-by: Maxime Coquelin --- doc/guides/prog_guide/vhost_lib.rst | 24 ++ lib/vhost/rte_vhost.h | 99 + li

[PATCH v2 1/5] vhost: fix missing virtqueue lock protection

2022-03-24 Thread Maxime Coquelin
This patch ensures virtqueue metadata are not being modified while rte_vhost_vring_call() is executed. Fixes: 6c299bb7322f ("vhost: introduce vring call API") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/vho

[PATCH v2 3/5] net/vhost: move to Vhost library stats API

2022-03-24 Thread Maxime Coquelin
Now that we have Vhost statistics APIs, this patch replaces Vhost PMD extented statistics implementation with calls to the new API. It will enable getting more statistics for counters that cannot be implmented at the PMD level. Signed-off-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c

[PATCH v2 4/5] vhost: add statistics for guest notifications

2022-03-24 Thread Maxime Coquelin
This patch adds a new virtqueue statistic for guest notifications. It is useful to deduce from hypervisor side whether the corresponding guest Virtio device is using Kernel Virtio-net driver or DPDK Virtio PMD. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 1 + lib/vhost/vhost.h | 5 +++

[PATCH v2 5/5] vhost: add statistics for IOTLB

2022-03-24 Thread Maxime Coquelin
This patch adds statistics for IOTLB hits and misses. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 10 +- lib/vhost/vhost.h | 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index 58b58fc40e..7f4fafdcb0 100644 --- a/l

RE: [PATCH v4] net/ice: improve performance of RX timestamp offload

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor > Sent: Thursday, March 24, 2022 8:18 PM > To: Zhang, Qi Z ; Wu, Wenjun1 > ; dev@dpdk.org; Yang, Qiming > > Cc: Van Haaren, Harry ; Su, Simei > ; Luca Boccassi ; Christian Ehrhardt > > Subject: Re: [PATCH v4] net/ice: improve performance of RX

Re: [PATCH v4] net/ice: improve performance of RX timestamp offload

2022-03-24 Thread Kevin Traynor
On 24/03/2022 13:05, Zhang, Qi Z wrote: -Original Message- From: Kevin Traynor Sent: Thursday, March 24, 2022 8:18 PM To: Zhang, Qi Z ; Wu, Wenjun1 ; dev@dpdk.org; Yang, Qiming Cc: Van Haaren, Harry ; Su, Simei ; Luca Boccassi ; Christian Ehrhardt Subject: Re: [PATCH v4] net/ice: im

RE: DPDK for Windows with MSVC compiler

2022-03-24 Thread Tarun Badnora
Hello Dmitry, Thanks for providing this information. For better planning at our end, I like to ask couple of questions: Is there a way to integrate DPDK module, built with clang/mingw, to our MSVC application ? I know both are different compilers, but in case if you are aware of a way/tweak t

RE: [PATCH v4] net/ice: improve performance of RX timestamp offload

2022-03-24 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor > Sent: Thursday, March 24, 2022 9:45 PM > To: Zhang, Qi Z ; Wu, Wenjun1 > ; dev@dpdk.org; Yang, Qiming > > Cc: Van Haaren, Harry ; Su, Simei > ; Luca Boccassi ; Christian Ehrhardt > > Subject: Re: [PATCH v4] net/ice: improve performance of RX

Re: [PATCH] eal: factorize lcore main loop

2022-03-24 Thread David Marchand
On Thu, Mar 24, 2022 at 9:31 AM Tyler Retzlaff wrote: > > diff --git a/lib/eal/common/eal_common_thread.c > > b/lib/eal/common/eal_common_thread.c > > index 684bea166c..256de91abc 100644 > > --- a/lib/eal/common/eal_common_thread.c > > +++ b/lib/eal/common/eal_common_thread.c > > @@ -9,6 +9,7 @@

[PATCH] ci: run more checks in private repositories

2022-03-24 Thread David Marchand
Though devtools/checkpatches.sh is run as part of our CI, some other (not well known) checks could help when run in private repositories before submitting to the mailing list and even when run from the ovsrobot. Most of them require a git history or checked sources to run. And I can't guarantee th

[Bug 979] hash: invalid shift expression in rte_thash

2022-03-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=979 Bug ID: 979 Summary: hash: invalid shift expression in rte_thash Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH] net/failsafe: fix interrupt handle leak

2022-03-24 Thread David Marchand
A intr_handle is being allocated as a hack to get a (proxy) eventfd from the Linux interrupt implementation. But this handle is never freed. Remove this convoluted hack and create an eventfd in Linux case. Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Cc: sta...@dpdk.o

[Bug 980] bnxt: use of uninitalized data

2022-03-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=980 Bug ID: 980 Summary: bnxt: use of uninitalized data Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Nor

[PATCH] eventdev: fix telemetry Rx adapters stats reset

2022-03-24 Thread David Marchand
Caught by covscan: 1. dpdk-21.11/lib/eventdev/rte_event_eth_rx_adapter.c:3279: logical_vs_bitwise: "~(*__ctype_b_loc()[(int)*params] & 2048 /* (unsigned short)_ISdigit */)" is always 1/true regardless of the values of its operand. This occurs as the logical second operand of "||". 2. dpdk-21.11/li

OVS DPDK DMA-Dev library/Design Discussion

2022-03-24 Thread Stokes, Ian
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:GMT Standard Time BEGIN:STANDARD DTSTART:16010101T02 TZOFFSETFROM:+0100 TZOFFSETTO:+ RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T01 T

[PATCH] app/testpmd: remove useless pointer checks

2022-03-24 Thread David Marchand
Parameters to this static helper can't be NULL. str has already been dereferenced in caller. dst and size point to variable in stack. Fixes: 169a9fed1f4c ("app/testpmd: fix hex string parser support for flow API") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test-pmd/cmdline_flow.c

[Patch v2] net/netvsc: report correct stats values

2022-03-24 Thread longli
From: Long Li The netvsc should add to the values from the VF and report the sum. Fixes: 4e9c73e96e ("net/netvsc: add Hyper-V network device") Cc: sta...@dpdk.org Signed-off-by: Long Li --- drivers/net/netvsc/hn_ethdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --

[Patch v2] net/netvsc: fix the calculation of checksums based on mbuf flag

2022-03-24 Thread longli
From: Long Li The netvsc should use RTE_MBUF_F_TX_L4_MASK and check the masked value to decide the correct way to calculate checksums. Not checking for RTE_MBUF_F_TX_L4_MASK results in incorrect RNDIS packets sent to VSP and incorrect checksums calculated by the VSP. Fixes: 4e9c73e96e ("net/net

[PATCH] net/netvsc: fix issues with hot adding multiple VF PCI devices

2022-03-24 Thread longli
From: Long Li This patch fixes two issues with hot removing/adding a VF PCI device: 1. The original device argument is lost when it's hot added 2. If there are multiple VFs hot adding at the same time, some of the VFs may not get added successfully because only one single VF status is stored in t

Re: [Bug 976] rte_rib (and rte_rib6) do not handle /0 correctly

2022-03-24 Thread Medvedkin, Vladimir
Hi Stephen, If I understand correctly, the only problem is that "rte_rib_get_nxt(rib, 0, 0, ..." does not return 0/0 prefix? If so, that's what was intended. From the documentation: * Retrieve next more specific prefix from the RIB * that is covered by ip/depth supernet in an ascending order

Re: [PATCH 1/1] mempool: implement index-based per core cache

2022-03-24 Thread Dharmik Thakkar
Hi, Thank you for the comments! Based on the suggestions, I tested the patch for single core L3Fwd performance with increased number of routes/flows (maximum 8K) to increase cache footprint. However, I don’t see much improvement with the patch. > On Jan 21, 2022, at 5:25 AM, Ananyev, Konstantin

RE: [PATCH v1] net/iavf: fix select wrong scan hw ring by rxdid

2022-03-24 Thread Kathleen Capella
Tested okay on N1SDP and on Intel(R) Xeon(R) Platinum 8268 CPU @ 2.90GHz Tested-by: Kathleen Capella > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, March 24, 2022 3:52 AM > To: Xing, Beilei ; Yang, SteveX > ; dev@dpdk.org > Cc: Wu, Jingjing ; sta...@dpdk.org > Subject: RE: [

[PATCH] net/iavf: remove extra copy step in Rx bulk path

2022-03-24 Thread Kathleen Capella
In the Rx bulk path, packets which are taken from the HW ring, are first copied to the stage data structure and then later copied from the stage to the rx_pkts array. For the number of packets requested immediately by the receiving function, this two-step process adds extra overhead that is not nec

RE: [PATCH] net/ice: fix raw flow input pattern value change in FDIR

2022-03-24 Thread Guo, Junfeng
> -Original Message- > From: Xu, Ting > Sent: Friday, March 18, 2022 11:17 > To: dev@dpdk.org > Cc: Guo, Junfeng ; Xu, Ting > ; sta...@dpdk.org; Yang, Qiming > ; Zhang, Qi Z > Subject: [PATCH] net/ice: fix raw flow input pattern value change in FDIR > > When parsing raw flow pattern i