Re: [PATCH] app/procinfo: add device private info dump

20/02/2022 02:04, Stephen Hemminger: > On Sat, 19 Feb 2022 09:59:16 +0800 > "Min Hu (Connor)" wrote: > > > +static void > > +show_port_private_info(void) > > +{ > > + int i; > > + > > + snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private "); > > + STATS_BDR_STR(10, bdr_str); > > + >

[PATCH V3] app/testpmd: fix GENEVE parsing in csum forward mode

The csum FWD mode parses any received packet to set mbuf offloads for the transmitting burst, mainly in the checksum/TSO areas. In the case of a tunnel header, the csum FWD tries to detect known tunnels by the standard definition using the header'sdata and fallback to check the packet type in the m

[PATCH v3 0/8] yet more unnecessary NULL checks

Thomas suggested there are some other functions that could use the nullfree cleanup; this covers the rest of the story. Note: this does not change existing API/ABI, there are still some outliers that don't use the convention but fixing these will have to wait until next LTS. v3 - fix another typo

[PATCH v3 1/8] cocci/nullfree: add more functions

There are more functions in DPDK which have the semantics as free() when passed NULL pointer. Also, put the checks in alpha order. Signed-off-by: Stephen Hemminger --- devtools/cocci/nullfree.cocci | 108 -- 1 file changed, 102 insertions(+), 6 deletions(-) diff

[PATCH v3 2/8] acl: remove unnecessary null checks

This function already handles NULL as valid input. Signed-off-by: Stephen Hemminger --- app/test/test_acl.c | 12 lib/acl/rte_acl.h| 1 + lib/table/rte_swx_table_wm.c | 3 +-- lib/table/rte_table_acl.c| 15 +-- 4 files changed, 11 insertions(+)

[PATCH v3 3/8] lpm: remove unnecessary NULL checks

The functions rte_lpm_free() and rte_lpm6_free() already handle NULL pointer case. Signed-off-by: Stephen Hemminger --- app/test/test_func_reentrancy.c | 3 +-- lib/lpm/rte_lpm.h | 1 + lib/lpm/rte_lpm6.h | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --

[PATCH v3 4/8] lib: document existing free functions

These functions all accept NULL as parameter. Signed-off-by: Stephen Hemminger --- lib/bitratestats/rte_bitrate.h | 1 + lib/compressdev/rte_comp.h | 1 + lib/cryptodev/rte_crypto.h | 1 + lib/eal/include/rte_interrupts.h | 4 +++- lib/efd/rte_efd.h| 1 + lib/eventd

[PATCH v3 5/8] test: remove unnecessary NULL checks before free

These are all cases in test code where there is unnecessary NULL check before free caught by coccinelle nullfree script. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_lib.c | 3 +-- app/test/test_cryptodev.c | 9 +++- app/test/test_cryptodev_asym.c

[PATCH v3 6/8] fips_validation: remove unnecessary NULL check

No need to check for null pointer here. Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/fips_validation/fips_dev_self_test.c b/examples/fips_validation/fips_dev_self_test.c index 07

[PATCH v3 7/8] event/sw: remove unnecessary NULL check

The XXX_free() functions already handle NULL pointer. Signed-off-by: Stephen Hemminger --- drivers/event/sw/sw_evdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index ba82a80385b6..f93313b31b5c 100644 --- a

[PATCH v3 8/8] pipeline: remove unnecessary checks for NULL pointer before free

This library (mostly) uses convention that allows caller to pass NULL. Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_port_in_action.h | 6 -- lib/pipeline/rte_swx_ctl.c| 3 +-- lib/pipeline/rte_swx_ctl.h| 1 + lib/pipeline/rte_swx_pipeline.c | 6 ++ lib/pipeline

Re: [PATCH v18 8/8] eal: implement functions for mutex management

2022-02-09 13:57 (UTC+), Ananyev, Konstantin: > > > Actually, please scrap that comment. > > > Obviously it wouldn't work for static variables, > > > and doesn't make much sense. > > > Though few thoughts remain: > > > for posix we probably don't need an indirection and > > > rte_thread_mutex c

[PATCH v3] raw/ifpga: initialize scalar variable before using

Scalar variable sub_brg_bdf may be used uninitialized in function ifpga_rawdev_fill_info(). It is initialized now in this fix. Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- v2: add space after comma to meet coding style requirement

Re:RE: [PATCH v2] ip_frag: add IPv4 options fragment and test data

Hi Konstantin, >Who will define this macro and when? >In general we trying to avoid conditional compilations within DPDK. >Can we always use one way or another? >As you are doing a copy anyway, probably no harm just >completely remove RTE_IPOPT_KEEP_IP_HLEN and related behaviour >and copy only op

RE: [PATCH v3] raw/ifpga: initialize scalar variable before using

Hi, > -Original Message- > From: Huang, Wei > Sent: Monday, February 21, 2022 10:20 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > ; nipun.gu...@nxp.com; hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; Huang, Wei > Subject: [PATCH v3] raw/ifpga: initialize

RE: [PATCH v3 3/8] lpm: remove unnecessary NULL checks

> -Original Message- > From: Stephen Hemminger > Sent: Monday, February 21, 2022 2:22 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Bruce > Richardson ; Vladimir Medvedkin > ; Yipeng Wang ; > Sameh Gobriel ; Anatoly Burakov > ; Olivier Matz ; > Andrew Rybchenko ; Honnappa > Nagarahalli ;

RE: [PATCH] net/mlx5: support matching optional fields of GRE

Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, February 17, 2022 4:34 PM > To: Matan Azrad ; Slava Ovsiienko > ; Sean Zhang (Networking SW) > > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: support matching optional fields of GRE > > External email: Use ca

[PATCH v3] ip_frag: add IPv4 options fragment and test data

According to RFC791,the options may appear or not in datagrams. They must be implemented by all IP modules (host and gateways). What is optional is their transmission in any particular datagram, not their implementation.So we have to deal with it during the fragmenting process.Add some test data fo

[PATCH v4] raw/ifpga: initialize scalar variable before using

Scalar variable sub_brg_bdf may be used uninitialized in function ifpga_rawdev_fill_info(). It is initialized now in this fix. Coverity issue: 375805 Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- v2: add space after comma to meet co

DPDK LTS release

Hi Team, We are planning to upgrade the DPDK stable LTS version from DPDK19.11. Could you please suggest what would be the stable LTS version of DPDK ? Thanks, Kamaraj

RE: [PATCH v1] raw/ifpga: fix interrupt handle allocation

> -Original Message- > From: Huang, Wei > Sent: Friday, February 18, 2022 3:39 PM > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > ; nipun.gu...@nxp.com; hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; Huang, Wei > Subject: [PATCH v1] raw/ifpga: fix interr

[PATCH] doc: remove multi-queue reconnection known issue

From: Xuan Ding Since QEMU 5.2.0 fixes the vhost multi-queue reconnection issue in commit f66337bdbfda ("vhost-user: save features of multiqueues if chardev is closed"), this patch removes the previous description from known issue. Signed-off-by: Xuan Ding --- doc/guides/rel_notes/known_issues

[PATCH v2] examples/multi_process: reconfigure port when rss or csum isn't supported

The default values of rx mq_mode and rx offloads for port will cause symmetric_mp startup failure if the port do not support rss or csum. This Patch make the app to reconfigure the NIC without them. Only quit the app if the second reconfiguration fails. Signed-off-by: Wenwu Ma --- examples/multi

[PATCH v5] raw/ifpga: initialize scalar variable before using

Scalar variable sub_brg_bdf may be used uninitialized in function ifpga_rawdev_fill_info(). It is initialized now in this fix. Coverity issue: 375805 Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- v2: add space after comma to meet co