[PATCH 2/2] event/cnxk: update SQB fc check for Tx adapter

2022-02-19 Thread pbhagavatula
From: Pavan Nikhilesh Update SQB limit to include CPT queue size when Security offload is enabled. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 30 +++ drivers/event/cnxk/cn10k_worker.h| 18 +-- drivers/event/cnxk/cn9k_eventdev.c

[PATCH 1/2] event/cnxk: remove deschedule usage in CN9K

2022-02-19 Thread pbhagavatula
From: Pavan Nikhilesh Using deschedule cmd might incorrectly ignore updates to WQE, GGRP on CN9K. Use addwork to pipeline work instead. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_worker.h | 41 +--- 1 file changed, 32 insertions(+), 9 deletions(-) d

[PATCH 0/3] more unnecessary null checks

2022-02-19 Thread Stephen Hemminger
Thomas suggested there are some other functions that could use the nullfree cleanup. And ACL and LPM are both candidates. Stephen Hemminger (3): cocci/nullfree: add more functions acl: remove unncessary null checks in calls to rte_acl_free() lpm: remove unnecessary NULL checks app/test/tes

[PATCH 1/3] cocci/nullfree: add more functions

2022-02-19 Thread Stephen Hemminger
There are more functions in DPDK which have the semantics as free() when passed NULL pointer. Signed-off-by: Stephen Hemminger --- devtools/cocci/nullfree.cocci | 9 + 1 file changed, 9 insertions(+) diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci index 363b61

[PATCH 2/3] acl: remove unncessary null checks in calls to rte_acl_free()

2022-02-19 Thread Stephen Hemminger
This function already handles NULL as valid input. Signed-off-by: Stephen Hemminger --- app/test/test_acl.c | 12 lib/acl/rte_acl.h| 1 + lib/table/rte_swx_table_wm.c | 3 +-- lib/table/rte_table_acl.c| 15 +-- 4 files changed, 11 insertions(+)

[PATCH 3/3] lpm: remove unnecessary NULL checks

2022-02-19 Thread Stephen Hemminger
The functions rte_lpm_free() and rte_lpm6_free() alread handle NULL pointer case. Signed-off-by: Stephen Hemminger --- app/test/test_func_reentrancy.c | 3 +-- lib/lpm/rte_lpm.h | 1 + lib/lpm/rte_lpm6.h | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --g

[PATCH v2 0/7] fix more unnecessary null checks

2022-02-19 Thread Stephen Hemminger
Thomas suggested there are some other functions that could use the nullfree cleanup; this covers the rest of the story. v2 - fix spelling typo and add more functions Stephen Hemminger (7): cocci/nullfree: add more functions acl: remove unnecessary null checks lpm: remove unnecessary NULL ch

[PATCH v2 1/7] cocci/nullfree: add more functions

2022-02-19 Thread Stephen Hemminger
There are more functions in DPDK which have the semantics as free() when passed NULL pointer. Also, put the checks in alpha order. Signed-off-by: Stephen Hemminger --- devtools/cocci/nullfree.cocci | 63 +++ 1 file changed, 57 insertions(+), 6 deletions(-) diff -

[PATCH v2 2/7] acl: remove unnecessary null checks

2022-02-19 Thread Stephen Hemminger
This function already handles NULL as valid input. Signed-off-by: Stephen Hemminger --- app/test/test_acl.c | 12 lib/acl/rte_acl.h| 1 + lib/table/rte_swx_table_wm.c | 3 +-- lib/table/rte_table_acl.c| 15 +-- 4 files changed, 11 insertions(+)

[PATCH v2 3/7] lpm: remove unnecessary NULL checks

2022-02-19 Thread Stephen Hemminger
The functions rte_lpm_free() and rte_lpm6_free() already handle NULL pointer case. Signed-off-by: Stephen Hemminger --- app/test/test_func_reentrancy.c | 3 +-- lib/lpm/rte_lpm.h | 1 + lib/lpm/rte_lpm6.h | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --

[PATCH v2 4/7] lib: document existing free functions

2022-02-19 Thread Stephen Hemminger
These functions all accept NULL as parameter. Signed-off-by: Stephen Hemminger --- lib/compressdev/rte_comp.h | 1 + lib/cryptodev/rte_crypto.h | 1 + lib/eal/include/rte_interrupts.h | 4 +++- lib/efd/rte_efd.h| 1 + lib/eventdev/rte_event_ring.h| 1 + lib/member

[PATCH v2 5/7] test: remove unecessary NULL checks before free

2022-02-19 Thread Stephen Hemminger
These are all cases in test code where there is unnecessary NULL check before free caught by coccinelle nullfree script. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_lib.c | 3 +-- app/test/test_cryptodev.c | 9 +++- app/test/test_cryptodev_asym.c

[PATCH v2 6/7] fips_validation: remove unnecessary NULL check

2022-02-19 Thread Stephen Hemminger
No need to check for null pointer here. Signed-off-by: Stephen Hemminger --- examples/fips_validation/fips_dev_self_test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/examples/fips_validation/fips_dev_self_test.c b/examples/fips_validation/fips_dev_self_test.c index 07

[PATCH v2 7/7] event/sw: remove unnecessary NULL check

2022-02-19 Thread Stephen Hemminger
The rte_event_ring_free() function already handles NULL pointer. Signed-off-by: Stephen Hemminger --- drivers/event/sw/sw_evdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c index ba82a80385b6..f93313b31b5c 1

Re: [PATCH] app/procinfo: add device private info dump

2022-02-19 Thread Stephen Hemminger
On Sat, 19 Feb 2022 09:59:16 +0800 "Min Hu (Connor)" wrote: > +static void > +show_port_private_info(void) > +{ > + int i; > + > + snprintf(bdr_str, MAX_STRING_LEN, " show - Port PMD Private "); > + STATS_BDR_STR(10, bdr_str); > + > + for (i = 0; i < RTE_MAX_ETHPORTS; i++) { > +

[PATCH v8 00/10] ethdev: datapath-focused flow rules management

2022-02-19 Thread Alexander Kozyrev
Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1. Pre-configuration hints. Application may give us some hints on what type of resources are

[PATCH v8 01/11] ethdev: introduce flow engine configuration

2022-02-19 Thread Alexander Kozyrev
The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared during the flow rule creation. In order to optimi

[PATCH v8 03/11] ethdev: bring in async queue-based flow rules operations

2022-02-19 Thread Alexander Kozyrev
A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flow rules creation/destruction on the datapath.

[PATCH v8 02/11] ethdev: add flow item/action templates

2022-02-19 Thread Alexander Kozyrev
Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can be grouped and classified together. This knowl

[PATCH v8 04/11] ethdev: bring in async indirect actions operations

2022-02-19 Thread Alexander Kozyrev
Queue-based flow rules management mechanism is suitable not only for flow rules creation/destruction, but also for speeding up other types of Flow API management. Indirect action object operations may be executed asynchronously as well. Provide async versions for all indirect action operations, nam

[PATCH v8 05/11] app/testpmd: add flow engine configuration

2022-02-19 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_configure API. Provide the command line interface for the Flow management. Usage example: flow configure 0 queues_number 8 queues_size 256 Implement rte_flow_info_get API to get available resources: Usage example: flow info 0 Signed-off-by: Alexander Kozyrev

[PATCH v8 07/11] app/testpmd: add flow table management

2022-02-19 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_table API. Provide the command line interface for the flow table creation/destruction. Usage example: testpmd> flow template_table 0 create table_id 6 group 9 priority 4 ingress mode 1 rules_number 64 pattern_template 2 actions_template 4 testpmd> fl

[PATCH v8 08/11] app/testpmd: add async flow create/destroy operations

2022-02-19 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. Provide the command line interface for enqueueing flow creation/destruction operations. Usage example: testpmd> flow queue 0 create 0 postpone no template_table 6 pattern_template 0 actions_template 0 patt

[PATCH v8 06/11] app/testpmd: add flow template management

2022-02-19 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_pattern_template and rte_flow_actions_template APIs. Provide the command line interface for the template creation/destruction. Usage example: testpmd> flow pattern_template 0 create pattern_template_id 2 template eth dst is 00:16:3e:31:15:c3 / end

[PATCH v8 09/11] app/testpmd: add flow queue push operation

2022-02-19 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_push API. Provide the command line interface for pushing operations. Usage example: flow queue 0 push 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 - app/test-pmd/config.c

[PATCH v8 10/11] app/testpmd: add flow queue pull operation

2022-02-19 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_pull API. Provide the command line interface for pulling operations results. Usage example: flow pull 0 queue 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 +++- app/test-pmd/config.c

[PATCH v8 11/11] app/testpmd: add async indirect actions operations

2022-02-19 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_async_action_handle API. Provide the command line interface for operations dequeue. Usage example: flow queue 0 indirect_action 0 create action_id 9 ingress postpone yes action rss / end flow queue 0 indirect_action 0 update action_id 9 action queue

RE: [PATCH] net/ice: fix overwriting of LSE bit by DCF

2022-02-19 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Friday, February 18, 2022 9:35 PM > To: Wilczynski, Michal ; dev@dpdk.org > Cc: Zhang, Qi Z > Subject: RE: [PATCH] net/ice: fix overwriting of LSE bit by DCF > > > -Original Message- > > From: Wilczynski, Michal > > Sent: Frid

Re: [PATCH 0/3] more unnecessary null checks

2022-02-19 Thread Jerin Jacob
On Sun, Feb 20, 2022 at 5:13 AM Stephen Hemminger wrote: > > Thomas suggested there are some other functions that could > use the nullfree cleanup. And ACL and LPM are both candidates. > > Stephen Hemminger (3): > cocci/nullfree: add more functions Can ./devtools/cocci.sh to integrated to devto

RE: [PATCH v2] net/iavf: fix segmentation offload buffer size

2022-02-19 Thread Zhang, Qi Z
> -Original Message- > From: Radu Nicolau > Sent: Tuesday, February 15, 2022 11:50 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Jiang, YuX ; Huang, ZhiminX > ; Yigit, Ferruh ; > ingjing...@intel.com; bl...@debian.org; ktray...@redhat.com; Nicolau, Radu > > Subject: [PATCH