Re: [PATCH 1/3] net/enic: add support for eCPRI matching

2022-01-27 Thread Thomas Monjalon
26/01/2022 15:01, Ferruh Yigit: > On 1/26/2022 2:00 PM, Ferruh Yigit wrote: > > On 1/14/2022 3:10 AM, John Daley wrote: > >> eCPRI message can be over Ethernet layer (.1Q supported also) or over > >> UDP layer. Message header formats are the same in these two variants. > >> > >> Only up though the

RE: [PATCH v2] doc: update matching versions in ice guide

2022-01-27 Thread Guo, Junfeng
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, January 25, 2022 09:26 > To: Yang, Qiming > Cc: Guo, Junfeng ; dev@dpdk.org; > david.march...@redhat.com; Zhang, Qi Z ; > sta...@dpdk.org > Subject: [PATCH v2] doc: update matching versions in ice guide > > Add recommended matc

Re: [PATCH v3 0/9] vhost: improve logging

2022-01-27 Thread David Marchand
On Thu, Jan 27, 2022 at 6:37 AM Xia, Chenbo wrote: > > From: Maxime Coquelin > > > > This series aims at easing Vhost logs analysis, by > > prepending the Vhost-user socket path to all logs and to > > remove multi-line comments. Doing so, filtering Vhost-user > > ports logs is much easier. > > >

RE: [PATCH v2] net/af_xdp: use libxdp if available

2022-01-27 Thread Loftus, Ciara
> > On Tue, Jan 25, 2022 at 07:20:43AM +, Ciara Loftus wrote: > > AF_XDP support is deprecated in libbpf since v0.7.0 [1]. The > > libxdp library now provides the functionality which once was in > > libbpf and which the AF_XDP PMD relies on. This commit updates the > > AF_XDP meson build to us

[PATCH v2] vhost: add vDPA resource cleanup callback

2022-01-27 Thread Xueming Li
This patch adds vDPA device cleanup callback to release resources on vhost user connection close. Signed-off-by: Xueming Li --- lib/vhost/vdpa_driver.h | 3 +++ lib/vhost/vhost_user.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h in

Re: [PATCH] vhost: add vDPA resource cleanup callback

2022-01-27 Thread Xueming(Steven) Li
On Wed, 2022-01-26 at 11:03 +0100, Maxime Coquelin wrote: > Hi Xueming, > > On 11/3/21 14:49, Maxime Coquelin wrote: > > > > > > On 11/3/21 14:45, Xueming(Steven) Li wrote: > > > On Wed, 2021-11-03 at 09:46 +0100, Maxime Coquelin wrote: > > > > > > > > On 11/3/21 09:41, Xia, Chenbo wrote: > > >

[Bug 928] [dpdk-next-*] drivers/librte_event_cnxk meson build failure with icc 19.1.3.304 on RedHat8.4/64 and UB20.04/64

2022-01-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=928 Bug ID: 928 Summary: [dpdk-next-*] drivers/librte_event_cnxk meson build failure with icc 19.1.3.304 on RedHat8.4/64 and UB20.04/64 Product: DPDK Version: unspecified

RE: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function

2022-01-27 Thread Huang, Wei
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, January 26, 2022 21:25 > To: Huang, Wei ; dev@dpdk.org; Xu, Rosen > ; Zhang, Qi Z ; Nipun Gupta > ; Hemant Agrawal > Cc: sta...@dpdk.org; Zhang, Tianfei > Subject: Re: [PATCH v1] raw/ifpga: fix ifpga devices cleanup funct

[DPDK 1/3] net/ice: display/reset VF stats on DCF representor

2022-01-27 Thread Ke Zhang
this feature need to update ice kernel driver (newer than v1.8.0_3) Signed-off-by: Ke Zhang --- drivers/net/ice/ice_dcf_vf_representor.c | 128 +++ 1 file changed, 128 insertions(+) diff --git a/drivers/net/ice/ice_dcf_vf_representor.c b/drivers/net/ice/ice_dcf_vf_represent

[DPDK 2/3] net/ice: configure the VLAN filter for VFs on DCF representor

2022-01-27 Thread Ke Zhang
this feature need to update ice kernel driver (newer than v1.8.0_3) Signed-off-by: Ke Zhang --- drivers/net/ice/ice_dcf_vf_representor.c | 51 1 file changed, 51 insertions(+) diff --git a/drivers/net/ice/ice_dcf_vf_representor.c b/drivers/net/ice/ice_dcf_vf_represento

[DPDK 3/3] net/ice: Add / Remove VF mac address on DCF representor

2022-01-27 Thread Ke Zhang
this feature need to update ice kernel driver (newer than v1.8.0_3) Signed-off-by: Ke Zhang --- drivers/net/ice/ice_dcf_ethdev.h | 1 + drivers/net/ice/ice_dcf_vf_representor.c | 81 +++- 2 files changed, 81 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/

[PATCH] net/ice: Add / Remove VF mac address on DCF representor

2022-01-27 Thread Ke Zhang
this feature need to update ice kernel driver (newer than v1.8.0_3) Signed-off-by: Ke Zhang --- drivers/net/ice/ice_dcf_ethdev.h | 1 + drivers/net/ice/ice_dcf_vf_representor.c | 81 +++- 2 files changed, 81 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/

[PATCH] net/ice: configure the VLAN filter for VFs on DCF representor

2022-01-27 Thread Ke Zhang
this feature need to update ice kernel driver (newer than v1.8.0_3) Signed-off-by: Ke Zhang --- drivers/net/ice/ice_dcf_vf_representor.c | 51 1 file changed, 51 insertions(+) diff --git a/drivers/net/ice/ice_dcf_vf_representor.c b/drivers/net/ice/ice_dcf_vf_represento

[PATCH] net/ice: display/reset VF stats on DCF representor

2022-01-27 Thread Ke Zhang
this feature need to update ice kernel driver (newer than v1.8.0_3) Signed-off-by: Ke Zhang --- drivers/net/ice/ice_dcf_vf_representor.c | 128 +++ 1 file changed, 128 insertions(+) diff --git a/drivers/net/ice/ice_dcf_vf_representor.c b/drivers/net/ice/ice_dcf_vf_represent

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-27 Thread Jerin Jacob
On Thu, Jan 27, 2022 at 3:32 AM Alexander Kozyrev wrote: > > On Tuesday, January 25, 2022 13:44 Jerin Jacob wrote: > > On Tue, Jan 25, 2022 at 6:58 AM Alexander Kozyrev > > wrote: > > > > > > On Monday, January 24, 2022 12:41 Ajit Khaparde > > wrote: > > > > On Mon, Jan 24, 2022 at 6:37 AM Jeri

Re: [PATCH] mempool: fix rte primary program coredump

2022-01-27 Thread Olivier Matz
Hi Tianli, On Wed, Nov 10, 2021 at 11:57:19PM +0800, Tianli Lai wrote: > the primary program(such as ofp app) run first, then run the secondary > program(such as dpdk-pdump), the primary program would receive signal > SIGSEGV. the function stack as follow: > > aived signal SIGSEGV, Segmentation f

RE: [PATCH] vhost: fix data-plane access to released vq

2022-01-27 Thread Wang, YuanX
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, January 26, 2022 10:03 PM > To: Wang, YuanX ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Ling, > WeiX > Subject: Re: [PATCH] vhost: fix data-plane access to released vq > > Hi Yuan

Re: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options

2022-01-27 Thread Ferruh Yigit
On 1/27/2022 7:13 AM, Sunil Kumar Kori wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 25, 2022 11:07 PM To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Xiaoyun Li ; Aman Singh ; Yuying Zhang Cc: tho...@monjalon.net; ajit.khapa...@broadcom.com; abo...@pensando.io; an

Re: [PATCH] vhost: fix data-plane access to released vq

2022-01-27 Thread Maxime Coquelin
Hi, On 1/27/22 11:30, Wang, YuanX wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Wednesday, January 26, 2022 10:03 PM To: Wang, YuanX ; Xia, Chenbo Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan ; Ma, WenwuX ; Ling, WeiX Subject: Re: [PATCH] vhost: fix data-plane access

[PATCH] devtools: fix comment detection in forbidden token check

2022-01-27 Thread David Marchand
After a comment section was detected, passing to a new hunk was not seen as ending the section and all subsequent hunks were ignored. Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs") Cc: sta...@dpdk.org Reported-by: Thomas Monjalon Signed-off-by: David Marchand --- devtoo

RE: [PATCH v2 1/4] crypto: use single buffer for asymmetric session

2022-01-27 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Monday, January 24, 2022 3:04 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; gak...@marvell.com; > ano...@marvell.com; m...@ashroe.eu; Power, Ciara > ; Doherty, Declan ; > Ankur Dwivedi ; Tejasree Kondoj > ; Griffin, John ; Trahe, > Fiona ; J

RE: [PATCH v2 2/4] crypto: hide asym session structure

2022-01-27 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Monday, January 24, 2022 3:04 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; gak...@marvell.com; > ano...@marvell.com; m...@ashroe.eu; Power, Ciara > ; Doherty, Declan ; > Ankur Dwivedi ; Tejasree Kondoj > ; Griffin, John ; Trahe, > Fiona ; J

RE: [PATCH v2 3/4] crypto: add asym session user data API

2022-01-27 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Monday, January 24, 2022 3:04 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; gak...@marvell.com; > ano...@marvell.com; m...@ashroe.eu; Power, Ciara > ; Doherty, Declan > Subject: [PATCH v2 3/4] crypto: add asym session user data API > > A u

RE: [PATCH v2 4/4] crypto: modify return value for asym session create

2022-01-27 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Monday, January 24, 2022 3:04 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; gak...@marvell.com; > ano...@marvell.com; m...@ashroe.eu; Power, Ciara > ; Doherty, Declan > Subject: [PATCH v2 4/4] crypto: modify return value for asym session cr

RE: [PATCH v2 77/83] compressdev: remove unnecessary NULL checks

2022-01-27 Thread Zhang, Roy Fan
> -Original Message- > From: Stephen Hemminger > Sent: Monday, January 24, 2022 5:47 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Zhang, Roy Fan > ; Ashish Gupta > Subject: [PATCH v2 77/83] compressdev: remove unnecessary NULL checks > > Remove redundant NULL pointer checks before fre

RE: [PATCH v2 32/83] crypto/ipsec_mb: remove unnecessary NULL checks

2022-01-27 Thread Zhang, Roy Fan
> -Original Message- > From: Stephen Hemminger > Sent: Monday, January 24, 2022 5:46 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Zhang, Roy Fan > ; De Lara Guarch, Pablo > > Subject: [PATCH v2 32/83] crypto/ipsec_mb: remove unnecessary NULL > checks > > Remove redundant NULL pointer

[PATCH] vhost: fix unsafe vrings addresses modifications

2022-01-27 Thread Maxime Coquelin
This patch adds missing protection around vring_invalidate and translate_ring_addresses calls in vhost_user_iotlb_msg. Fixes: eefac9536a90 ("vhost: postpone device creation until rings are mapped") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost_user.c | 10 -- 1

Re: [PATCH v2 0/6] Fast restart with many hugepages

2022-01-27 Thread Bruce Richardson
On Wed, Jan 19, 2022 at 11:09:11PM +0200, Dmitry Kozlyuk wrote: > This patchset is a new design and implementation of [1]. > > v2: > * Fix hugepage file removal when they are no longer used. > Disable removal with --huge-unlink=never as intended. > Document this behavior difference. (Bru

Re: [PATCH v2] net/enic: add support for eCPRI matching

2022-01-27 Thread Ferruh Yigit
On 1/26/2022 9:48 PM, John Daley wrote: eCPRI message can be over Ethernet layer (.1Q supported also) or over UDP layer. Message header formats are the same in these two variants. Only up though the first packet header in the PDU can be matched. RSS on the eCPRI header fields is not supported.

Re: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function

2022-01-27 Thread Ferruh Yigit
On 1/27/2022 8:57 AM, Huang, Wei wrote: Hi, -Original Message- From: Yigit, Ferruh Sent: Wednesday, January 26, 2022 21:25 To: Huang, Wei ; dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z ; Nipun Gupta ; Hemant Agrawal Cc: sta...@dpdk.org; Zhang, Tianfei Subject: Re: [PATCH v1] raw/ifpga: fix

Re: [PATCH v2 00/15] fix and feature for hns3 PMD

2022-01-27 Thread Ferruh Yigit
On 1/22/2022 1:51 AM, Min Hu (Connor) wrote: This patch contains 15 patches, which include fixing codecheck warning ,code refactor and indirect counter action support. Chengwen Feng (4): net/hns3: remove invalid encapsulation function net/hns3: delete strerror invoke net/hns3: rename fu

Re: [PATCH v2 11/15] net/hns3: remove invalid encapsulation function

2022-01-27 Thread Ferruh Yigit
On 1/22/2022 1:51 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch remove invalid encapsulation functions. removed functions don't look like encapsulation functions, updating commit log while merging. Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns3_ethdev.c| 27 +

RE: [PATCH v2 5/6] net/axgbe: add support for new port mode

2022-01-27 Thread Namburu, Chandu-babu
[Public] Acked-by: Chandubabu Namburu -Original Message- From: sseba...@amd.com Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 5/6] net/axgbe: add support for new port mode From: Selwin Sebastian Add support for a new port mode that is a backplane connec

RE: [PATCH v2 4/6] net/axgbe: reset PHY Rx when mailbox command timeout

2022-01-27 Thread Namburu, Chandu-babu
[Public] Acked-by: Chandubabu Namburu -Original Message- From: sseba...@amd.com Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 4/6] net/axgbe: reset PHY Rx when mailbox command timeout From: Selwin Sebastian Sometimes mailbox commands timeout when the RX

RE: [PATCH v2 3/6] net/axgbe: simplify mailbox interface rate change code

2022-01-27 Thread Namburu, Chandu-babu
[Public] Acked-by: Chandubabu Namburu -Original Message- From: sseba...@amd.com Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 3/6] net/axgbe: simplify mailbox interface rate change code From: Selwin Sebastian Simplify and centralize the mailbox command

RE: [PATCH v2 2/6] net/axgbe: toggle PLL settings during rate change

2022-01-27 Thread Namburu, Chandu-babu
[Public] Acked-by: Chandubabu Namburu -Original Message- From: sseba...@amd.com Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 2/6] net/axgbe: toggle PLL settings during rate change From: Selwin Sebastian For each rate change command submission, the FW h

RE: [PATCH v2 1/6] net/axgbe: always attempt link training in KR mode

2022-01-27 Thread Namburu, Chandu-babu
[Public] Acked-by: Chandubabu Namburu -Original Message- From: sseba...@amd.com Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 1/6] net/axgbe: always attempt link training in KR mode From: Selwin Sebastian Link training is always attempted when in KR mod

Re: [PATCH v2 00/15] fix and feature for hns3 PMD

2022-01-27 Thread Ferruh Yigit
On 1/27/2022 12:49 PM, Ferruh Yigit wrote: On 1/22/2022 1:51 AM, Min Hu (Connor) wrote: This patch contains 15 patches, which include fixing codecheck warning ,code refactor and indirect counter action support. Chengwen Feng (4):    net/hns3: remove invalid encapsulation function    net/hns3: d

Re: [PATCH v2 1/6] doc: add hugepage mapping details

2022-01-27 Thread Bruce Richardson
On Wed, Jan 19, 2022 at 11:09:12PM +0200, Dmitry Kozlyuk wrote: > Hugepage mapping is a layer of EAL malloc builds upon. > There were implicit references to its details, > like mentions of segment file descriptors, > but no explicit description of its modes and operation. > Add an overview of mecha

Re: [PATCH v2 6/6] net/axgbe: alter the port speed bit range

2022-01-27 Thread Ferruh Yigit
On 1/25/2022 4:21 PM, Namburu, Chandu-babu wrote: [Public] Moving ack down, please don't top post. -Original Message- From: sseba...@amd.com Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 6/6] net/axgbe: alter the port speed bit range From: Selwin Sebas

[PATCH 0/5] Add JSON vector set support to fips validation

2022-01-27 Thread Brandon Lo
Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. Brandon Lo (5): examples/fips

[PATCH 1/5] examples/fips_validation: add jansson dependency

2022-01-27 Thread Brandon Lo
Added a check for RTE_HAS_JANSSON into the meson configuration file for JSON support. Signed-off-by: Brandon Lo --- examples/fips_validation/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/meson.build b/examples/fips_validation/meson.build index 7eef

[PATCH 2/5] examples/fips_validation: add json info to header

2022-01-27 Thread Brandon Lo
Added json-specific functions and other information needed to test the new FIPS test vectors. Signed-off-by: Brandon Lo --- examples/fips_validation/fips_validation.h | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/examples/fips_validation/fips_validati

[PATCH 3/5] examples/fips_validation: add json parsing

2022-01-27 Thread Brandon Lo
Added functions to parse the required information from a vector set given in the new json format. Signed-off-by: Brandon Lo --- examples/fips_validation/fips_validation.c | 84 ++ 1 file changed, 84 insertions(+) diff --git a/examples/fips_validation/fips_validation.c b/exa

[PATCH 4/5] examples/fips_validation: allow json file as input

2022-01-27 Thread Brandon Lo
Added the ability to use the json format as the input and output of the example application. Signed-off-by: Brandon Lo --- examples/fips_validation/main.c | 192 +++- 1 file changed, 189 insertions(+), 3 deletions(-) diff --git a/examples/fips_validation/main.c b/exa

[PATCH 5/5] examples/fips_validation: add json to gcm test

2022-01-27 Thread Brandon Lo
Adds json-specific testing and writeback function. Allows the user to test AES-GCM vector sets. Signed-off-by: Brandon Lo --- .../fips_validation/fips_validation_gcm.c | 149 ++ 1 file changed, 149 insertions(+) diff --git a/examples/fips_validation/fips_validation_gcm.c b/

[PATCH 0/5] vhost: introduce per-virtqueue stats API

2022-01-27 Thread Maxime Coquelin
This series introduces a new Vhost API that provides per-virtqueue statistics to the application. It will be generally useful, but initial motivation for this series was to be able to get to get virtqueues stats when Virtio RSS feature will be supported in Vhost library. First patch is a fix that

[PATCH 1/5] vhost: fix missing virtqueue lock protection

2022-01-27 Thread Maxime Coquelin
This patch ensures virtqueue metadata are not being modified while rte_vhost_vring_call() is executed. Fixes: 6c299bb7322f ("vhost: introduce vring call API") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/vho

[PATCH 2/5] vhost: add per-virtqueue statistics support

2022-01-27 Thread Maxime Coquelin
This patch introduces new APIs for the application to query and reset per-virtqueue statistics. The patch also introduces generic counters. Signed-off-by: Maxime Coquelin --- lib/vhost/rte_vhost.h | 89 + lib/vhost/socket.c | 4 +- lib/vhost/version.map |

[PATCH 4/5] vhost: add statistics for guest notifications

2022-01-27 Thread Maxime Coquelin
This patch adds a new virtqueue statistic for guest notifications. It is useful to deduce from hypervisor side whether the corresponding guest Virtio device is using Kernel Virtio-net driver or DPDK Virtio PMD. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 1 + lib/vhost/vhost.h | 5 +++

[PATCH 5/5] vhost: add statistics for IOTLB

2022-01-27 Thread Maxime Coquelin
This patch adds statistics for IOTLB hits and misses. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 10 +- lib/vhost/vhost.h | 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index 2d0d9e7f51..bda974d34f 100644 --- a/l

[PATCH 3/5] net/vhost: move to Vhost library stats API

2022-01-27 Thread Maxime Coquelin
Now that we have Vhost statistics APIs, this patch replaces Vhost PMD extented statistics implementation with calls to the new API. It will enable getting more statistics for counters that cannot be implmented at the PMD level. Signed-off-by: Maxime Coquelin --- drivers/net/vhost/rte_eth_vhost.c

[PATCH 00/20] mlx5: refactor devargs management

2022-01-27 Thread Michael Baum
These patches rearrange the management of the devargs on two different levels. The first splits the net driver's devargs into two categories, device-dependent devargs and port-dependent devargs. Arguments that depend on the device are updated once in the creation of the shared device context struc

[PATCH 01/20] net/mlx5: fix wrong check sibling device config mismatch

2022-01-27 Thread Michael Baum
The MLX5 net driver supports "probe again". In probing again, it creates a new ethdev under an existing infiniband device context. Sibling devices sharing infiniband device context should have compatible configurations, so some of the devargs given in the probe again, the ones that are mainly rele

[PATCH 02/20] net/mlx5: fix ineffective metadata argument adjustment

2022-01-27 Thread Michael Baum
In "dv_xmeta_en" devarg there is an option of dv_xmeta_en=3 which engages tunnel offload mode. In E-Switch configuration, that mode implicitly activates dv_xmeta_en=1. The update according to E-switch support is done immediately after the first parsing of the devargs, but there is another adjustme

[PATCH 03/20] net/mlx5: fix wrong place of ASO CT object release

2022-01-27 Thread Michael Baum
The ASO connection tracking structure is initialized once for sharing device context. Its release takes place in the close function which is called for each ethdev individually. i.e. when there is more than one ethdev under the same sharing device context, it will be destroyed when one of them is

[PATCH 04/20] net/mlx5: fix inconsistency errno update in SH creation

2022-01-27 Thread Michael Baum
The mlx5_alloc_shared_dev_ctx() function has a local variable named "err" which contains the errno value in case of failure. When functions called by this function are failed, this variable is updated with their return value (that should be a positive errno value). However, some functions doesn't

[PATCH 05/20] net/mlx5: remove declaration duplications

2022-01-27 Thread Michael Baum
In mlx5_ethdev.c file are implemented those 4 functions: - mlx5_dev_infos_get - mlx5_fw_version_get - mlx5_dev_set_mtu - mlx5_hairpin_cap_get In mlx5.h file they are declared twice. First time under mlx5.c file and second time under mlx5_ethdev.c file. This patch removes the redundant declara

[PATCH 06/20] net/mlx5: remove checking devargs duplication

2022-01-27 Thread Michael Baum
The device arguments are parsed and updated twice during spawning. First time before creating the share device context, and again later after updating a default value to one of the arguments. This patch consolidates them into one parsing and updates the default values before it. Signed-off-by: Mi

[PATCH 08/20] net/mlx5: remove DevX flag duplication

2022-01-27 Thread Michael Baum
The sharing device context structure has a field named "devx" which indicates if DevX is supported. The common configure stracture has also field named "devx" with the same meaning. There is no need for this duplication, because there is a reference to the common structure from within the sharing

[PATCH 07/20] net/mlx5: remove HCA attr structure duplication

2022-01-27 Thread Michael Baum
The HCA attribute structure is field of net configure structure. It is also field of common configure structure. There is no need for this duplication, because there is a reference to the common structure from within the net structures. This patch removes it from net configure structure and uses

[PATCH 09/20] net/mlx5: remove Verbs query device duplication

2022-01-27 Thread Michael Baum
The sharing device context structure has a field named "device_attr" which s filled by mlx5_os_get_dev_attr() function. The spawn function calls mlx5_os_get_dev_attr() again and save it to local variable identical to "device_attr" field. There is no need for this duplication, because there is a re

[PATCH 11/20] net/mlx5: share realtime timestamp configure

2022-01-27 Thread Michael Baum
The realtime timestamp configure work for Linux as same as Windows. This patch removes it to the function implemented in the folder shared between the operating systems, removing the duplication. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 23 ++---

[PATCH 10/20] common/mlx5: share VF checking function

2022-01-27 Thread Michael Baum
The check if device is VF work for Linux as same as Windows. This patch removes it to the function implemented in the folder shared between the operating systems, removing the duplication. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h | 15 +

[PATCH 13/20] net/mlx5: add E-switch mode flag

2022-01-27 Thread Michael Baum
This patch adds in SH structure a flag which indicates whether is E-Switch mode. When configure "dv_esw_en" from devargs, it is enabled only when is E-switch mode. So, since dv_esw_en has been configure, it is enough to check if "dv_esw_en" is valid. This patch also removes E-Switch mode check when

[PATCH 14/20] net/mlx5: rearrange device attribute structure

2022-01-27 Thread Michael Baum
Rearrange the mlx5_os_get_dev_attr() function in such a way that it first executes the queries and only then updates the fields. In addition, it changed its name in preparation for expanding its operations to configure the capabilities inside it. Signed-off-by: Michael Baum Acked-by: Matan Azrad

[PATCH 12/20] net/mlx5: share counter config function

2022-01-27 Thread Michael Baum
The mlx5_flow_counter_mode_config function exists for both Linux and Windows with the same name and content. This patch moves its implementation to the folder shared between the operating systems, removing the duplication. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/l

[PATCH 15/20] net/mlx5: concentrate all device configurations

2022-01-27 Thread Michael Baum
Move all device configure to be performed by mlx5_os_cap_config() function instead of the spawn function. In addition move all relevant fields from mlx5_dev_config structure to mlx5_dev_cap. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 497 ++

[PATCH 16/20] net/mlx5: add share device context config structure

2022-01-27 Thread Michael Baum
Add configuration structure for shared device context. This structure contains all configurations coming from devargs which oriented to device. It is a field of shared device context (SH) structure, and is updated once in mlx5_alloc_shared_dev_ctx() function. This structure cannot be changed when p

[PATCH 17/20] net/mlx5: using function to detect operation by DevX

2022-01-27 Thread Michael Baum
Add inline function indicating whether HW objects operations can be created by DevX. It makes the code more readable. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 6 ++ drivers/net/mlx5/mlx5.h | 24 drivers/net/m

[PATCH 19/20] common/mlx5: add check for common devargs in probing again

2022-01-27 Thread Michael Baum
MLX5 common driver supports probing again in two scenarios: - Add new driver under existing device. common probe function gets it in devargs, then calls the requested driver's probe function (regardless of the driver's own support in probing again) with the existing device as parameter.

[PATCH 18/20] net/mlx5: separate per port configuration

2022-01-27 Thread Michael Baum
Add configuration structure for port (ethdev). This structure contains all configurations coming from devargs which oriented to port. It is a field of mlx5_priv structure, and is updated in spawn function for each port. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linu

[PATCH 20/20] common/mlx5: refactor devargs management

2022-01-27 Thread Michael Baum
Improve the devargs handling in two aspects: - Parse the devargs string only once. - Return error and report for unknown keys. The common driver parses once the devargs string into a dictionary, then provides it to all the drivers' probe. Each driver updates within it which keys it has used, the

Re: [PATCH] devtools: fix comment detection in forbidden token check

2022-01-27 Thread Thomas Monjalon
27/01/2022 11:55, David Marchand: > After a comment section was detected, passing to a new hunk was not seen > as ending the section and all subsequent hunks were ignored. > > Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs") > Cc: sta...@dpdk.org > > Reported-by: Thomas Monj

RE: 回复: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

2022-01-27 Thread Ananyev, Konstantin
> > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Tuesday, 18 January 2022 17.54 > > > > > > [quick summary: ethdev API to bypass mempool] > > > > > > 18/01/2022 16:51, Ferruh Yigit: > > > > On 12/28/2021 6:55 AM, Feifei Wang wrote: > > > > > Morten Brørup : > > > > >> The patc

Re: [PATCH v3 1/1] dma/cnxk: fix installing internal cnxk DMA headers

2022-01-27 Thread Thomas Monjalon
> > DMA module internal header files are currently being installed to the prefix > > directory. This patch updates DMA meson config file to exclude internal > > headers during install stage. > > > > Fixes: 53f6d7328b (dma/cnxk: create and initialize device on PCI probing) > > Cc: sta...@dpdk.org >

Re: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options

2022-01-27 Thread Ajit Khaparde
On Thu, Jan 27, 2022 at 2:40 AM Ferruh Yigit wrote: > > On 1/27/2022 7:13 AM, Sunil Kumar Kori wrote: > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Tuesday, January 25, 2022 11:07 PM > >> To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Xiaoyun > >> Li ; Aman Singh ; Yuying

RE: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

2022-01-27 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Thursday, 27 January 2022 05.07 > > Thanks Morten, appreciate your comments. Few responses inline. > > > -Original Message- > > From: Morten Brørup > > Sent: Sunday, December 26, 2021 4:25 AM > > > > > From: Feife

[PATCH v3] app/test-fib: fix possible division by zero

2022-01-27 Thread Vladimir Medvedkin
This patch fixes the division by 0, which occurs if the number of routes is less than 10. Can be triggered by passing -n argument with value < 10: ./dpdk-test-fib -- -n 9 ... Floating point exception (core dumped) Fixes: 103809d032cd ("app/test-fib: add test application for FIB") Cc: sta...@dpdk.

[PATCH v3] net/enic: add support for eCPRI matching

2022-01-27 Thread John Daley
eCPRI message can be over Ethernet layer (.1Q supported also) or over UDP layer. Message header formats are the same in these two variants. Only up though the first packet header in the PDU can be matched. RSS on the eCPRI payload is not supported. Signed-off-by: John Daley Reviewed-by: Hyong Yo

[PATCH v3] net/enic: support max descriptors allowed by adapter

2022-01-27 Thread John Daley
Newer VIC adapters have the max number of supported RX and TX descriptors in their configuration. Use these values as the maximums. Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- v3: add line just below so 0-day bot applies dependency Depends-on: patch-105799 ("net/enic: update VIC fi

[Bug 929] rte_dump_stack() is not safe to call from signal handler

2022-01-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=929 Bug ID: 929 Summary: rte_dump_stack() is not safe to call from signal handler Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v3 3/6] eal: support libunwind based backtrace

2022-01-27 Thread Stephen Hemminger
On Mon, 6 Sep 2021 09:47:29 +0530 wrote: > From: Jerin Jacob > > adding optional libwind library dependency to DPDK for > enhanced backtrace based on ucontext. > > Signed-off-by: Jerin Jacob Was looking for better backtrace and noticed that there is libbacktrace on github (BSD licensed). It

RE: [PATCH v2 03/10] ethdev: bring in async queue-based flow rules

2022-01-27 Thread Alexander Kozyrev
On Wednesday, January 26, 2022 13:54 Ajit Khaparde wrote: > > On Tue, Jan 25, 2022 at 9:03 PM Alexander Kozyrev > wrote: > > > > On Monday, January 24, 2022 19:00 Ivan Malov > wrote: > > > This series is very helpful as it draws attention to > > > the problem of making flow API efficient. That

[PATCH v2] net/ice: fix missing clock initialization

2022-01-27 Thread Simei Su
Rx PHY timer init value is not same as primary timer init value when power up which will lead Rx timestamp always have big gap compared with PTP timestamp. This patch adds PHC init time in initializing PTP hardware clock. Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP") Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v3 3/6] eal: support libunwind based backtrace

2022-01-27 Thread Jerin Jacob
On Fri, Jan 28, 2022 at 2:18 AM Stephen Hemminger wrote: > > On Mon, 6 Sep 2021 09:47:29 +0530 > wrote: > > > From: Jerin Jacob > > > > adding optional libwind library dependency to DPDK for > > enhanced backtrace based on ucontext. > > > > Signed-off-by: Jerin Jacob > > > Was looking for bette

[Bug 930] ConnectX6 DPDK dpdk-testpmd Receive tcp ,udp Mixed flow performance is very low!

2022-01-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=930 Bug ID: 930 Summary: ConnectX6 DPDK dpdk-testpmd Receive tcp ,udp Mixed flow performance is very low! Product: DPDK Version: 21.11 Hardware: x86 OS: Linux

RE: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function

2022-01-27 Thread Huang, Wei
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, January 27, 2022 20:34 > To: Huang, Wei ; dev@dpdk.org; Xu, Rosen > ; Zhang, Qi Z ; Nipun Gupta > ; Hemant Agrawal > Cc: sta...@dpdk.org; Zhang, Tianfei > Subject: Re: [PATCH v1] raw/ifpga: fix ifpga devices cleanup funct

RE: [PATCH v3] net/i40e: reduce redundant reset operation

2022-01-27 Thread Zhang, Qi Z
> -Original Message- > From: Feifei Wang > Sent: Thursday, January 27, 2022 3:40 PM > To: Xing, Beilei > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang ; > Ruifeng Wang > Subject: [PATCH v3] net/i40e: reduce redundant reset operation > > For free buffer operation in i40e vector path, it