[PATCH v1 0/6] Fast restart with many hugepages

2022-01-17 Thread Dmitry Kozlyuk
This patchset is a new design and implementation of [1]. Changes since RFC: * Fix bugs with -m and --single-file-segments. * Reject optimization of mmap() call number (see below). # Problem Statement Large allocations that involve mapping new hugepages are slow. This is problematic, for example,

[PATCH v1 1/6] doc: add hugepage mapping details

2022-01-17 Thread Dmitry Kozlyuk
Hugepage mapping is a layer of EAL malloc builds upon. There were implicit references to its details, like mentions of segment file descriptors, but no explicit description of its modes and operation. Add an overview of mechanics used on ech supported OS. Convert memory management subsections from

[PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-17 Thread Dmitry Kozlyuk
Memory allocator performance is crucial to applications that deal with large amount of memory or allocate frequently. DPDK allocator performance is affected by EAL options, API used and, at least, allocation size. New autotest is intended to be run with different EAL options. It measures performanc

[PATCH v1 3/6] mem: add dirty malloc element support

2022-01-17 Thread Dmitry Kozlyuk
EAL malloc layer assumed all free elements content is filled with zeros ("clean"), as opposed to uninitialized ("dirty"). This assumption was ensured in two ways: 1. EAL memalloc layer always returned clean memory. 2. Freed memory was cleared before returning into the heap. Clearing the memory can

[PATCH v1 4/6] eal: refactor --huge-unlink storage

2022-01-17 Thread Dmitry Kozlyuk
In preparation to extend --huge-unlink option semantics refactor how it is stored in the internal configuration. It makes future changes more isolated. Signed-off-by: Dmitry Kozlyuk --- lib/eal/common/eal_common_options.c | 9 + lib/eal/common/eal_internal_cfg.h | 8 +++- lib/eal/l

[PATCH v1 5/6] eal/linux: allow hugepage file reuse

2022-01-17 Thread Dmitry Kozlyuk
Linux EAL ensured that mapped hugepages are clean by always mapping from newly created files: existing hugepage backing files were always removed. In this case, the kernel clears the page to prevent data leaks, because the mapped memory may contain leftover data from the previous process that was u

[PATCH v1 6/6] eal: extend --huge-unlink for hugepage file reuse

2022-01-17 Thread Dmitry Kozlyuk
Expose Linux EAL ability to reuse existing hugepage files via --huge-unlink=never switch. Default behavior is unchanged, it can also be specified using --huge-unlink=existing for consistency. Old --huge-unlink switch is kept, it is an alias for --huge-unlink=always. Signed-off-by: Dmitry Kozlyuk

[PATCH] vhost: fix guest physical address to host physical address mapping

2022-01-17 Thread Yuan Wang
Async copy fails when looking up hpa in the gpa to hpa mapping table. This happens because the gpa is matched exactly in the merged mapping table, and the merge loses the mapping entries. A new range comparison method is introduced to solve this issue. Fixes: 6563cf92380 ("vhost: fix async copy on

Re: [PATCH v1 1/6] doc: add hugepage mapping details

2022-01-17 Thread Thomas Monjalon
Thanks for the nice addition to the documentation, this is really needed. Some comments below. 17/01/2022 09:07, Dmitry Kozlyuk: > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > -Memory reservations done using the APIs provided b

Re: [PATCH] net/bonding: fix RSS not work for bonding in DPDK21.11

2022-01-17 Thread Ferruh Yigit
On 1/15/2022 1:06 AM, Min Hu (Connor) wrote: Hi, I got your meaning. The key is the API call sequence about bond_ethdev_configure and rte_eth_bond_slave_add. testpmd ensure that rte_eth_bond_slave_add is first called before bond_ethdev_configure, so this is no bug. Of course I also

Re: [PATCH v2] net/axgbe: use PCI root complex device to distinguish AMD hardware

2022-01-17 Thread Ferruh Yigit
On 1/17/2022 5:40 AM, Sebastian, Selwin wrote: Acked by: Selwin Sebastian Hi Selwin, Patchwork doesn't recognize the tag, I guess because it is looking for exact "Acked-by: " tag, with '-'. Can you please pay attention next time, able to see the status in the patchwork help maintainers to t

Re: [PATCH] net/bonding: fix RSS not work for bonding in DPDK21.11

2022-01-17 Thread Ferruh Yigit
On 1/17/2022 10:15 AM, Ferruh Yigit wrote: On 1/15/2022 1:06 AM, Min Hu (Connor) wrote: Hi,  I got your meaning.  The key is the API call sequence about bond_ethdev_configure and rte_eth_bond_slave_add. testpmd ensure that rte_eth_bond_slave_add is first called before bond_ethdev_configu

RE: [PATCH v2] net/axgbe: use PCI root complex device to distinguish AMD hardware

2022-01-17 Thread Sebastian, Selwin
Acked-by: Selwin Sebastian -Original Message- From: Namburu, Chandu-babu Sent: Monday, January 10, 2022 12:08 PM To: dev@dpdk.org; david.march...@redhat.com; ferruh.yi...@intel.com Cc: Sebastian, Selwin ; arsalan_a...@mentor.com; sta...@dpdk.org Subject: RE: [PATCH v2] net/axgbe: use PC

RE: [PATCH v2] net/axgbe: use PCI root complex device to distinguish AMD hardware

2022-01-17 Thread Sebastian, Selwin
[AMD Official Use Only] Hi Ferruh, I'm Sorry... corrected and sent it again. Thanks Selwin -Original Message- From: Ferruh Yigit Sent: Monday, January 17, 2022 3:52 PM To: Sebastian, Selwin ; Namburu, Chandu-babu ; dev@dpdk.org; david.march...@redhat.com Cc: arsalan_a...@mentor.com;

[PATCH v2] vdpa/sfc: make MCDI memzone name unique

2022-01-17 Thread abhimanyu.saini
From: Abhimanyu Saini Buffer for MCDI channel is allocated using rte_memzone_reserve_aligned with zone name 'mcdi'. Since multiple MCDI channels are needed to support multiple VF(s) and rte_memzone_reserve_aligned expects unique zone names, append PCI address to zone name to make it unique. Sign

[PATCH] mempool: optimize put objects to mempool with cache

2022-01-17 Thread Morten Brørup
This patch optimizes the rte_mempool_do_generic_put() caching algorithm. The algorithm was: 1. Add the objects to the cache 2. Anything greater than the cache size (if it crosses the cache flush threshold) is flushed to the ring. (Please note that the description in the source code said tha

RE: rte_memcpy alignment

2022-01-17 Thread Morten Brørup
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Friday, 14 January 2022 12.52 > > > > > > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > > > Sent: Friday, 14 January 2022 11.54 > > > > > > > From: Morten Brørup > > > > Sent: Friday, January 14, 2022 9:

RE: [RFC] DTS Commit Policies

2022-01-17 Thread Juraj Linkeš
From: Owen Hilyard Sent: Wednesday, January 12, 2022 4:08 PM To: dev ; d...@dpdk.org Subject: [RFC] DTS Commit Policies Hello Everyone, The DTS Working Group wanted to let everyone give feedback on the proposed DTS commit policies. Please leave a comment with any feedback you have. We will be

RE: [PATCH] build: add missing arch define for Arm

2022-01-17 Thread Juraj Linkeš
> -Original Message- > From: Ruifeng Wang > Sent: Friday, January 14, 2022 10:05 AM > To: tho...@monjalon.net > Cc: dev@dpdk.org; sta...@dpdk.org; vikto...@rehivetech.com; > bruce.richard...@intel.com; step...@networkplumber.org; Juraj Linkeš > ; Honnappa Nagarahalli > ; nd ; nd > Subj

[PATCH v2 1/1] eal: add internal function to get base address

2022-01-17 Thread Srikanth Yalavarthi
Added an internal helper to get OS-specific EAL mappping base addreess This helper can be used by the drivers to map host address range with offload devices and would be need for device specific operations like firmware load Signed-off-by: Srikanth Yalavarthi --- v2: * Dropped Change-Id lib/e

[PATCH v3 1/1] eal: add internal function to get base address

2022-01-17 Thread Srikanth Yalavarthi
Added an internal helper to get OS-specific EAL mapping base address This helper can be used by the drivers to map host address range with offload devices and would be need for device specific operations like firmware load Signed-off-by: Srikanth Yalavarthi Change-Id: I19eec79e46066e3b08896d84ce

[PATCH v4 1/1] eal: add internal function to get base address

2022-01-17 Thread Srikanth Yalavarthi
Added an internal helper to get OS-specific EAL mapping base address This helper can be used by the drivers to map host address range with offload devices and would be need for device specific operations like firmware load Signed-off-by: Srikanth Yalavarthi --- lib/eal/common/eal_common_config.

RE: [PATCH] build: add missing arch define for Arm

2022-01-17 Thread Morten Brørup
> From: Juraj Linkeš [mailto:juraj.lin...@pantheon.tech] > Sent: Monday, 17 January 2022 14.12 > > > From: Ruifeng Wang > > Sent: Friday, January 14, 2022 10:05 AM > > > > > From: Thomas Monjalon > > > Sent: Friday, January 14, 2022 1:33 AM > > > > > > 17/12/2021 09:54, Ruifeng Wang: > > > > As

[PATCH] net/cnxk: fix dangling pointer in meter for gcc12

2022-01-17 Thread Ferruh Yigit
Observed with: gcc (GCC) 12.0.0 20220116 (experimental) In file included from ../drivers/net/cnxk/cnxk_ethdev.h:16, from ../drivers/net/cnxk/cnxk_ethdev_mtr.c:5: In function ‘rte_mtr_error_set’, inlined from ‘cnxk_nix_mtr_policy_validate’ at ../drivers/net/cnxk/cnxk_ethdev_mt

Re: [PATCH v1 3/6] mem: add dirty malloc element support

2022-01-17 Thread Thomas Monjalon
17/01/2022 09:07, Dmitry Kozlyuk: > EAL malloc layer assumed all free elements content > is filled with zeros ("clean"), as opposed to uninitialized ("dirty"). > This assumption was ensured in two ways: > 1. EAL memalloc layer always returned clean memory. > 2. Freed memory was cleared before retur

Re: [PATCH v1 4/6] eal: refactor --huge-unlink storage

2022-01-17 Thread Thomas Monjalon
17/01/2022 09:07, Dmitry Kozlyuk: > In preparation to extend --huge-unlink option semantics > refactor how it is stored in the internal configuration. > It makes future changes more isolated. > > Signed-off-by: Dmitry Kozlyuk > --- > +/** Hugepage backing files discipline. */ > +struct hugepage_f

Re: [PATCH v2] net/axgbe: use PCI root complex device to distinguish AMD hardware

2022-01-17 Thread Ferruh Yigit
On 1/17/2022 10:29 AM, Sebastian, Selwin wrote: <...> -Original Message- From: Namburu, Chandu-babu Sent: Thursday, December 2, 2021 9:41 PM To: dev@dpdk.org; david.march...@redhat.com Cc: Sebastian, Selwin ; arsalan_a...@mentor.com; ferruh.yi...@intel.com; Namburu, Chandu-babu ; sta.

Re: [PATCH v1 5/6] eal/linux: allow hugepage file reuse

2022-01-17 Thread Thomas Monjalon
17/01/2022 09:14, Dmitry Kozlyuk: > Linux EAL ensured that mapped hugepages are clean > by always mapping from newly created files: > existing hugepage backing files were always removed. > In this case, the kernel clears the page to prevent data leaks, > because the mapped memory may contain leftov

Re: [PATCH v1 6/6] eal: extend --huge-unlink for hugepage file reuse

2022-01-17 Thread Thomas Monjalon
17/01/2022 09:14, Dmitry Kozlyuk: > Expose Linux EAL ability to reuse existing hugepage files > via --huge-unlink=never switch. > Default behavior is unchanged, it can also be specified > using --huge-unlink=existing for consistency. > Old --huge-unlink switch is kept, > it is an alias for --huge-u

[PATCH] net/cxgbe: fix dangling pointer for gcc12

2022-01-17 Thread Ferruh Yigit
Observed with: gcc (GCC) 12.0.0 20220116 (experimental) In file included from ../lib/eal/linux/include/rte_os.h:14, from ../lib/eal/include/rte_common.h:28, from ../lib/eal/include/rte_log.h:25, from ../lib/ethdev/rte_ethdev.h:164,

Re: [PATCH v4 1/1] eal: add internal function to get base address

2022-01-17 Thread Dmitry Kozlyuk
2022-01-17 05:42 (UTC-0800), Srikanth Yalavarthi: > Added an internal helper to get OS-specific EAL mapping base address > > This helper can be used by the drivers to map host address range with > offload devices and would be need for device specific operations like > firmware load Hello Srikanth

softnic pull request

2022-01-17 Thread Thomas Monjalon
Please check this pull request in GitHub: https://github.com/DPDK/dpdk/pull/35

Re: [PATCH] kernel/kni: retry the xmit in case ring is full

2022-01-17 Thread Tudor Cornea
Hi Stephen, > NAK > Doing this risks having a CPU lockup if userspace does not keep up > or the DPDK application gets stuck. > > There are better ways to solve the TCP stack queue overrun issue: > 1. Use a better queueing discipline on the kni device. The Linux default >of pfifo_fast has buff

[PATCH v5] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-01-17 Thread Luc Pelletier
Calls to rte_memcpy_generic could result in unaligned loads/stores for 1 < n < 16. This is undefined behavior according to the C standard, and it gets flagged by the clang undefined behavior sanitizer. rte_memcpy_generic is called with unaligned src and dst addresses. When 1 < n < 16, the code wou

Re: [PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-17 Thread Bruce Richardson
On Mon, Jan 17, 2022 at 10:07:57AM +0200, Dmitry Kozlyuk wrote: > Memory allocator performance is crucial to applications that deal > with large amount of memory or allocate frequently. DPDK allocator > performance is affected by EAL options, API used and, at least, > allocation size. New autotest

Re: [PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-17 Thread Bruce Richardson
On Mon, Jan 17, 2022 at 03:47:41PM +, Bruce Richardson wrote: > On Mon, Jan 17, 2022 at 10:07:57AM +0200, Dmitry Kozlyuk wrote: > > Memory allocator performance is crucial to applications that deal > > with large amount of memory or allocate frequently. DPDK allocator > > performance is affecte

Re: [PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-17 Thread Aaron Conole
Dmitry Kozlyuk writes: > Memory allocator performance is crucial to applications that deal > with large amount of memory or allocate frequently. DPDK allocator > performance is affected by EAL options, API used and, at least, > allocation size. New autotest is intended to be run with different >

Re: [PATCH v5] kni: allow configuring the kni thread granularity

2022-01-17 Thread Tudor Cornea
On Fri, 14 Jan 2022 at 18:44, Ferruh Yigit wrote: > On 1/14/2022 4:24 PM, Stephen Hemminger wrote: > > On Fri, 14 Jan 2022 17:18:19 +0200 > > Tudor Cornea wrote: > > > >> +module_param(min_scheduling_interval, long, 0644); > >> +MODULE_PARM_DESC(min_scheduling_interval, > >> +"\t\tKni thread min

Re: [PATCH v1 0/6] Fast restart with many hugepages

2022-01-17 Thread Bruce Richardson
On Mon, Jan 17, 2022 at 10:07:55AM +0200, Dmitry Kozlyuk wrote: > This patchset is a new design and implementation of [1]. > Changes since RFC: > * Fix bugs with -m and --single-file-segments. > * Reject optimization of mmap() call number (see below). > > # Problem Statement > > Large allocations

Re: [PATCH] mempool: fix get objects from mempool with cache

2022-01-17 Thread Bruce Richardson
On Fri, Jan 14, 2022 at 05:36:50PM +0100, Morten Brørup wrote: > A flush threshold for the mempool cache was introduced in DPDK version > 1.3, but rte_mempool_do_generic_get() was not completely updated back > then, and some inefficiencies were introduced. > > This patch fixes the following in rte

[PATCH] common/mlx5: fix probing return value when failing

2022-01-17 Thread Bing Zhao
While probing the device with unsupported class, the process should fail because no appropriate driver was found. After traversing all the drivers, an error value should be returned for the case. In the previous implementation, zero value indicating probing success was wrongly returned. Fixes: ad

Re: [PATCH v2] build/eal: add OS defines for C conditional checks

2022-01-17 Thread Thomas Monjalon
16/12/2021 16:21, Bruce Richardson: > Define a set of macros in the build configuration to allow C runtime > code to check the current OS environment. This saves the user having to > use ifdefs for e.g. disabling particular tests on Windows. See included > documentation changes for usage examples.

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Ferruh Yigit
On 11/26/2021 4:15 AM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the pro

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Ferruh Yigit
On 11/26/2021 4:15 AM, Kumara Parameshwaran wrote: From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the pro

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Thomas Monjalon
17/01/2022 19:28, Ferruh Yigit: > > + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); > > + if (ret) { > > + TAP_LOG(ERR, "Failed to get port id for %s", > > + request_param->port_name); > > + return -1; > > + } > > + dev = &rte_

Re: dev Digest, Vol 381, Issue 38

2022-01-17 Thread Thomas Monjalon
13/12/2021 16:41, McDaniel, Timothy: [...] > Reviewed-by: Timothy McDaniel This isn't usable because you reply to a digest email. Please do not register as digest. You change it in the mailman options.

Re: [PATCH v14 04/11] app/test: skip interrupt tests on Windows

2022-01-17 Thread Thomas Monjalon
The proposal below is now merged. Please Jie, use it in a v15 of this series. 10/12/2021 10:30, Bruce Richardson: > On Fri, Dec 10, 2021 at 12:23:59PM +0300, Dmitry Kozlyuk wrote: > > 2021-12-09 16:39 (UTC+), Bruce Richardson: > > > On Thu, Dec 09, 2021 at 04:17:08PM +, Bruce Richardson w

[PATCH v5 00/50] introduce IWYU

2022-01-17 Thread Sean Morrissey
This patchset introduces the include-what-you-use script which removes unused header includes. IWYU GitHub: https://github.com/include-what-you-use/include-what-you-use Along with the script there are some patches which make a start on removing unneeded headers. V4: * Re-added removed headers th

[PATCH v5 01/50] devtools: script to remove unused headers includes

2022-01-17 Thread Sean Morrissey
This script can be used for removing headers flagged for removal by the include-what-you-use (IWYU) tool. The script has the ability to remove headers from specified sub-directories or dpdk as a whole and tests the build after each removal by calling meson compile. example usages: Remove headers

[PATCH v5 02/50] telemetry: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ciara Power --- lib/telemetry/telemetry.c | 1 - lib/telemetry/telemetry_data.h | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/tele

[PATCH v5 03/50] ring: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ring/rte_ring.c | 9 - 1 file changed, 9 deletions(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index f17bd966be..7945e5d9ed 100644 --- a/lib/ring/rte_ring.c +++ b/li

[PATCH v5 04/50] kvargs: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kvargs/rte_kvargs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c index 11f624ef14..9a59c500bf 100644 --- a/lib/kvargs/rte_kvargs.c

[PATCH v5 05/50] eal: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Reviewed-by: Harry van Haaren Reviewed-by: Mattias Rönnblom Reviewed-by: David Christensen --- lib/eal/common/eal_common_dev.c| 5 - lib/eal/common/eal_common_devargs.c| 1

[PATCH v5 06/50] vhost: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/vhost/fd_man.c | 6 -- lib/vhost/fd_man.h | 1 - lib/vhost/socket.c | 1 - lib/vhost/vdpa.c | 1 - lib/vhost/vhost.c | 4 lib/vhost/vhost.h | 2 -- lib

[PATCH v5 07/50] timer: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/timer/rte_timer.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 6d19ce469b..b3f3e229f6 100644 --- a/lib/timer/rte_timer.c ++

[PATCH v5 08/50] table: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/table/rte_swx_table_em.c | 1 - lib/table/rte_swx_table_em.h | 1 - lib/table/rte_swx_table_learner.c | 1 - lib/table/rte_swx_table_learner.h | 1 - lib/table/rte_swx_table_

[PATCH v5 09/50] stack: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/stack/rte_stack.c | 2 -- lib/stack/rte_stack.h | 1 - 2 files changed, 3 deletions(-) diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c index 56bf2c8d6d..1fabec2bfe 100644 --- a

[PATCH v5 10/50] security: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/security/rte_security.c | 2 -- lib/security/rte_security.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/security/rte_security.c b/lib/security/rte_security.c index 6e45a03fa

[PATCH v5 11/50] sched: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/sched/rte_pie.c | 2 -- lib/sched/rte_red.h | 1 - lib/sched/rte_sched.c | 1 - lib/sched/rte_sched.h | 1 - 4 files changed, 5 deletions(-) diff --git a/lib/sched/rte_pie.c b/lib/sch

[PATCH v5 12/50] rib: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rib/rte_rib.c | 2 -- lib/rib/rte_rib.h | 1 - lib/rib/rte_rib6.c | 2 -- lib/rib/rte_rib6.h | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c in

[PATCH v5 13/50] reorder: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/reorder/rte_reorder.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index 9445853b79..f40a48201f 100644 --- a/lib/reorder/rte_reo

[PATCH v5 14/50] regexdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ori Kam --- lib/regexdev/rte_regexdev.c | 2 -- lib/regexdev/rte_regexdev.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexd

[PATCH v5 15/50] rcu: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rcu/rte_rcu_qsbr.c | 4 lib/rcu/rte_rcu_qsbr.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c index 7510db2f81..17be93e830 100

[PATCH v5 16/50] rawdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rawdev/rte_rawdev.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c index a6134e76ea..2f0a4f132e 100644 --- a/lib/rawde

[PATCH v5 17/50] power: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Also added rte_string_fns.h to example app vm_power_manager for users without libbsd. Signed-off-by: Sean Morrissey --- examples/vm_power_manager/guest_cli/main.c | 1 + lib/power/guest_channel.c | 2 -- lib/p

[PATCH v5 18/50] port: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/port/rte_port_fd.h | 1 - lib/port/rte_port_frag.c| 2 -- lib/port/rte_port_frag.h| 1 - lib/port/rte_port_kni.c | 1 - lib/port/rte_port_kni.h | 1

[PATCH v5 19/50] pipeline: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pipeline/rte_pipeline.c | 4 lib/pipeline/rte_port_in_action.c| 2 -- lib/pipeline/rte_swx_ctl.h | 2 -- lib/pipeline/rte_swx_pipeline.c | 1 - lib/pipelin

[PATCH v5 20/50] pdump: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pdump/rte_pdump.c | 1 - lib/pdump/rte_pdump.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c index af450695ec..b3a62df591 100644 --- a

[PATCH v5 21/50] pci: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pci/rte_pci.c | 15 +-- lib/pci/rte_pci.h | 2 -- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/lib/pci/rte_pci.c b/lib/pci/rte_pci.c index c91be8b167..355772

[PATCH v5 22/50] pcapng: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/pcapng/rte_pcapng.c | 1 - lib/pcapng/rte_pcapng.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/pcapng/rte_pcapng.c b/lib/pcapng/rte_pcapng.c index 03edabe73e..5ae96a5bc9 1006

[PATCH v5 23/50] node: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/node/ethdev_ctrl.c | 2 -- lib/node/ethdev_rx.c | 1 - lib/node/ethdev_tx.c | 1 - lib/node/ip4_lookup.c | 5 - lib/node/ip4_rewrite.c | 4 lib/node/pkt_cls.c | 4 l

[PATCH v5 24/50] net: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/net/net_crc_avx512.c | 3 --- lib/net/net_crc_sse.c| 1 - lib/net/rte_arp.c| 1 - lib/net/rte_ether.h | 1 - lib/net/rte_net.h| 1 - lib/net/rte_net_crc.c| 2 -

[PATCH v5 25/50] metrics: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/metrics/rte_metrics.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/metrics/rte_metrics.c b/lib/metrics/rte_metrics.c index e2a0fbeda8..0c7878e65f 100644 --- a/lib/metrics/rte_

[PATCH v5 26/50] mempool: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mempool/rte_mempool.c | 7 --- lib/mempool/rte_mempool.h | 4 2 files changed, 11 deletions(-) diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c index c5a699b1d6

[PATCH v5 27/50] member: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/member/rte_member.c | 2 -- lib/member/rte_member.h | 1 - lib/member/rte_member_vbf.c | 1 - 3 files changed, 4 deletions(-) diff --git a/lib/member/rte_member.c b/lib/member/rte

[PATCH v5 28/50] mbuf: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mbuf/rte_mbuf.c | 11 --- lib/mbuf/rte_mbuf.h | 2 -- lib/mbuf/rte_mbuf_dyn.h | 2 -- lib/mbuf/rte_mbuf_pool_ops.c | 1 - lib/mbuf/rte_mbuf_pool_ops.h |

[PATCH v5 29/50] lpm: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/lpm/rte_lpm.c | 7 --- lib/lpm/rte_lpm.h | 4 lib/lpm/rte_lpm6.c | 7 --- lib/lpm/rte_lpm6.h | 1 - 4 files changed, 19 deletions(-) diff --git a/lib/lpm/rte_lpm.c b/lib/lp

[PATCH v5 30/50] latencystats: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/latencystats/rte_latencystats.c | 4 1 file changed, 4 deletions(-) diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c index ab8db7a139..8985a377

[PATCH v5 31/50] kni: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kni/rte_kni.c | 2 -- lib/kni/rte_kni.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c index fc8f0e7b5a..7971c56bb4 100644 --- a/lib/kni/rte_kn

[PATCH v5 32/50] jobstats: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/jobstats/rte_jobstats.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/jobstats/rte_jobstats.c b/lib/jobstats/rte_jobstats.c index 9b8fde5d55..af565a14ea 100644 --- a/lib/jobsta

[PATCH v5 33/50] ipsec: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ipsec/esp_inb.c | 1 - lib/ipsec/esp_outb.c | 1 - lib/ipsec/ipsec_sad.c | 1 - lib/ipsec/sa.c| 3 --- lib/ipsec/sa.h| 1 - 5 files changed, 7 deletions(-) diff --git a

[PATCH v5 34/50] ip_frag: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ip_frag/rte_ip_frag_common.c | 1 - lib/ip_frag/rte_ipv4_fragmentation.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/lib/ip_frag/rte_ip_frag_common.c b/lib/ip_frag/rte_ip_fra

[PATCH v5 35/50] hash: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/hash/rte_cuckoo_hash.c | 4 lib/hash/rte_fbk_hash.c| 6 -- lib/hash/rte_fbk_hash.h| 1 - lib/hash/rte_thash.c | 1 - lib/hash/rte_thash.h | 1 - 5 files change

[PATCH v5 36/50] gro: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gro/gro_tcp4.c | 1 - lib/gro/gro_tcp4.h | 2 -- lib/gro/gro_udp4.c | 1 - lib/gro/gro_udp4.h | 2 -- lib/gro/gro_vxlan_tcp4.c | 1 - lib/gro/gro_vxlan_udp4.c | 1 -

[PATCH v5 37/50] graph: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/graph/graph_debug.c| 2 -- lib/graph/graph_ops.c | 1 - lib/graph/graph_populate.c | 2 -- lib/graph/node.c | 1 - 4 files changed, 6 deletions(-) diff --git a/lib/grap

[PATCH v5 38/50] gpudev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index 9ae36dbae9..98bb759fb2 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

[PATCH v5 39/50] flow_classify: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/flow_classify/rte_flow_classify.c | 3 --- lib/flow_classify/rte_flow_classify.h | 4 lib/flow_classify/rte_flow_classify_parse.c | 1 - lib/flow_classify/rte_flow_classif

[PATCH v5 40/50] fib: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/fib/dir24_8.c | 4 lib/fib/rte_fib.c | 2 -- lib/fib/rte_fib.h | 1 - lib/fib/rte_fib6.c | 2 -- lib/fib/rte_fib6.h | 1 - lib/fib/trie.c | 5 - lib/fib/trie.h | 2 --

[PATCH v5 41/50] eventdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eventdev/rte_event_ring.c | 6 -- lib/eventdev/rte_event_ring.h | 2 -- lib/eventdev/rte_event_timer_adapter.c | 5 - lib/eventdev/rte_event_timer_adapter.h |

[PATCH v5 42/50] efd: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/efd/rte_efd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c index 86ef46863c..560cd78961 100644 --- a/lib/efd/rte_efd.c +++ b/lib/efd/rte_efd.

[PATCH v5 43/50] dmadev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/dmadev/rte_dmadev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index 4abe79c536..ad9e7a0975 100644 --- a/lib/dmadev/rte_dmadev.h +

[PATCH v5 44/50] distributor: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/distributor/rte_distributor.c | 2 -- lib/distributor/rte_distributor_match_sse.c | 2 -- lib/distributor/rte_distributor_single.c| 2 -- 3 files changed, 6 deletions(-) dif

[PATCH v5 45/50] compressdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/compressdev/rte_comp.c| 1 - lib/compressdev/rte_comp.h| 1 - lib/compressdev/rte_compressdev.c | 1 - lib/compressdev/rte_compressdev.h | 1 - lib/compress

[PATCH v5 46/50] cmdline: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline.c| 2 -- lib/cmdline/cmdline_parse.c | 3 --- lib/cmdline/cmdline_parse_num.c | 4 lib/cmdline/cmdline_parse_portlist.c | 3 --- lib/cmdl

[PATCH v5 47/50] bpf: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bpf/bpf.c | 4 lib/bpf/bpf_exec.c | 6 -- lib/bpf/bpf_jit_x86.c | 5 - lib/bpf/bpf_load.c | 8 lib/bpf/bpf_pkt.c | 12 lib/bpf

[PATCH v5 48/50] bbdev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/bbdev/rte_bbdev.c | 4 lib/bbdev/rte_bbdev.h | 4 2 files changed, 8 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index 7f353d4f7e..aaee7b7872 100644

[PATCH v5 49/50] cryptodev: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cryptodev/cryptodev_pmd.h | 4 lib/cryptodev/rte_cryptodev.c | 11 --- lib/cryptodev/rte_cryptodev.h | 2 -- 3 files changed, 17 deletions(-) diff --git a/lib/cryptodev/cry

[PATCH v5 50/50] acl: remove unneeded header includes

2022-01-17 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/acl/rte_acl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/acl/rte_acl.c b/lib/acl/rte_acl.c index 4e693b2488..a61c3ba188 100644 --- a/lib/acl/rte_acl.c +++ b/lib/acl/rte_acl.c @

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-17 Thread Stephen Hemminger
On Fri, 26 Nov 2021 09:45:15 +0530 Kumara Parameshwaran wrote: > + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); > + if (ret) { > + TAP_LOG(ERR, "Failed to get port id for %s", > + request_param->port_name); > + return

[PATCH] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.

2022-01-17 Thread Michael Barker
Signed-off-by: Michael Barker --- lib/eal/include/rte_compat.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/eal/include/rte_compat.h b/lib/eal/include/rte_compat.h index 2718612cce..9556bbf4d0 100644 --- a/lib/eal/include/rte_compat.h +++ b/lib/eal/include/rte_compa

  1   2   >