Re: [PATCH v1] net/axgbe: use PCI root complex device to distinguish AMD hardware

Hi Chandu, I have tested this in the following configurations and it works very well in all cases: * V1000 with Yocto v3.3.2 & Linux v5.10.47 * E3000 with Yocto v3.3.2 & Linux v5.10.47 * V1000 with Ubuntu Server v20.04.3 LTS * E3000 with Ubuntu Server v20.04.3 LTS I think this is a much better

Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000

Hi Chandu, I have provided my comments on your patch acknowledging your solution as a better approach than this one. Thanks and regards, Arsalan From: Namburu, Chandu-babu Sent: Friday, November 26, 2021 3:35 PM To: Awan, Arsalan; dev@dpdk.org Cc: Somala

Re: [PATCH v1] net/axgbe: use PCI root complex device to distinguish AMD hardware

On Fri, Nov 26, 2021 at 11:24 AM Chandubabu Namburu wrote: > > "bus/pci: optimize bus scan" broke axgbe on V1000/R1000. > RV root complex pci device does not have any kernel driver assigned > so it is removed from pci scan list which is used in > "net/axgbe: add a HW quirk for register definitions

[PATCH] net/cnxk: fix promiscuous mode in multicast enable flow

From: Asaf Ravid When multicast promisc was being enabled it caused the unicast promisc to be disabled. This fix resolves this by setting NIX_RX_MODE_PROMISC when eth_dev->data->promiscuous is set, regardless. ci: skip_checkpatch skip_roc_check Fixes: 325d79c00a5a ("net/cnxk: support all multic

Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

On Wed, 24 Nov 2021 16:47:06 +0800, Huichao Cai wrote: > +/* > + * Options "fragmenting", just fill options not > + * allowed in fragments with NOOPs. > + * Simple and stupid 8), but the most efficient way. > + */ > +static inline void ip_options_fragment(struct rte_ipv4_hdr *iph) > +{

PRM release mailing list

If you wish to get the PRM release mail, you can subscribe to nbu-adapter-prm mailing list via https://dlrequest/ Regards, Asaf Penso

[PATCH] pipeline: add check against loops

Detect when a jump instruction, either conditional or unconditional, is jumping to itself, thus creating a loop, which is not allowed in data plane code. Signed-off-by: Cristian Dumitrescu Signed-off-by: Harshad Narayane --- lib/pipeline/rte_swx_pipeline.c | 13 + 1 file changed, 13

RE: PRM release mailing list

Sent by mistake to this ML. Sorry for this. Regards, Asaf Penso From: Asaf Penso Sent: Wednesday, December 1, 2021 1:55 PM To: dpdk-dev Subject: PRM release mailing list If you wish to get the PRM release mail, you can subscribe to nbu-adapter-prm mailing list via https://dlrequest/ Regards,

[PATCH v3] devtools: spell check

A spell check script to check for errors in patches. An example of usage being cat PATCH_FILE | spell_check.sh. Errors will be printed to console, following the file they are located in. Word exclusions can be made by making additions to the dictionary, and problematic patterns can be added t

RE: [PATCH v3 1/2] doc: note KNI alternatives

> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, 24 November 2021 18.16 > > Add more information on alternatives of KNI and the cons of KNI against > these alternatives. > > Signed-off-by: Ferruh Yigit > --- > Cc: Olivier Matz Olivier Matz > Cc: David Marchand David March

[PATCH v4] devtools: spell check

A spell check script to check for errors in patches. An example of usage being cat PATCH_FILE | spell_check.sh. Errors will be printed to console, following the file they are located in. Word exclusions can be made by making additions to the dictionary, and problematic patterns can be added to

[PATCH v9 1/9] eal/windows: return ENOTSUP for not supported API

UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

[PATCH v9 3/9] app/test: fix incorrect errno variable

Fix incorrect errno variable used in memory autotest. Use rte_errno instead. Fixes: 086d426406bd ("app/test: fix memory autotests on FreeBSD") Cc: bruce.richard...@intel.com Signed-off-by: Jie Zhou --- app/test/test_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/a

[PATCH v9 0/9] app/test: enable subset of tests on Windows

From: Jie Zhou This patchset is to enable a subset of unit tests on windows. It mainly includes: - Replace POSIX specific codes - Add test stubs for not supported ones on Windows - Fix some lib and tests per failures investigation - Replace .sh script with .py script for meson.build - Enable bui

[PATCH v9 2/9] app/test: remove POSIX-specific code

- Remove header inclusion of netinet/in.h and terminos.h - Include rte_os_shim.h - Replace sleep and usleep with rte_delay_us_sleep - Use NUL on Windows as /dev/null for Linux - Exclude tests not yet supported on Windows, e.g. multi-process, and IP address parsing (the test cases use linux netine

[PATCH v9 4/9] app/test: skip interrupt tests on Windows

Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou --- app/test/test_interrupts.c | 10 ++ 1 file changed, 1

[PATCH v9 5/9] app/test: skip two logs_autotest cases on Windows

DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

[PATCH v9 8/9] app/test: replace .sh script with .py script

- Add python script to check if system supports hugepages - Remove corresponding .sh script - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou --- app/test/has-hugepage.sh | 11 --- app/test/has_hugepage.py | 26 ++ app/test/me

[PATCH v9 7/9] app/test: remove two alarm_autotest cases

Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/app/test/test_alarm.c +++

[PATCH v9 6/9] app/test: differentiate a strerror on different OS

On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[PATCH v9 9/9] app/test: enable subset of unit tests on Windows

- For fast tests and perf tests, add test stubs to skip not supported ones. - For driver tests, for now skip on Windows totally to avoid unnecessary amount of test stubs. For example, there are about 30 cryptodev related tests (even though in the meson for CI it only listed about half) whic

[PATCH v10 1/9] eal/windows: return ENOTSUP for not supported API

UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

[PATCH v10 3/9] app/test: fix incorrect errno variable

Fix incorrect errno variable used in memory autotest. Use rte_errno instead. Fixes: 086d426406bd ("app/test: fix memory autotests on FreeBSD") Signed-off-by: Jie Zhou --- app/test/test_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_memory.c b/app/tes

[PATCH v10 4/9] app/test: skip interrupt tests on Windows

Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou --- app/test/test_interrupts.c | 10 ++ 1 file changed, 1

[PATCH v10 2/9] app/test: remove POSIX-specific code

- Remove header inclusion of netinet/in.h and terminos.h - Include rte_os_shim.h - Replace sleep and usleep with rte_delay_us_sleep - Use NUL on Windows as /dev/null for Linux - Exclude tests not supported on Windows yet, e.g. multi-process, and IP address parsing (the test cases use linux netine

[PATCH v10 0/9] app/test: enable subset of tests on Windows

This patchset is to enable a subset of unit tests on windows. It mainly includes: - Replace POSIX specific codes - Add test stubs for not supported ones on Windows - Fix some lib and tests per failures investigation - Replace .sh script with .py script for meson.build - Enable build and run subset

[PATCH v10 7/9] app/test: remove two alarm_autotest cases

Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/app/test/test_alarm.c +++

[PATCH v10 8/9] app/test: replace .sh script with .py script

- Add python script to check if system supports hugepages - Remove corresponding .sh script - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou --- app/test/has-hugepage.sh | 11 --- app/test/has_hugepage.py | 26 ++ app/test/me

[PATCH v10 5/9] app/test: skip two logs_autotest cases on Windows

DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

[PATCH v10 6/9] app/test: differentiate a strerror on different OS

On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[PATCH v10 9/9] app/test: enable subset of unit tests on Windows

- For fast tests and perf tests, add test stubs to skip not supported ones. - For driver tests, for now skip on Windows totally to avoid unnecessary amount of test stubs. For example, there are about 30 cryptodev related tests (even though in the meson for CI it only listed about half) whic

Re: [PATCH v9 9/9] app/test: enable subset of unit tests on Windows

On Wed, 1 Dec 2021 10:05:38 -0800 Jie Zhou wrote: > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c > index b206db27ae..c2ea9090cf 100644 > --- a/app/test/test_dmadev.c > +++ b/app/test/test_dmadev.c > @@ -2,6 +2,17 @@ > * Copyright(c) 2021 HiSilicon Limited > * Copyright(c) 202

Re: [PATCH v9 9/9] app/test: enable subset of unit tests on Windows

On Wed, Dec 01, 2021 at 10:45:35AM -0800, Stephen Hemminger wrote: > On Wed, 1 Dec 2021 10:05:38 -0800 > Jie Zhou wrote: > > > diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c > > index b206db27ae..c2ea9090cf 100644 > > --- a/app/test/test_dmadev.c > > +++ b/app/test/test_dmadev.c >

Re: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

On Wed, Nov 24, 2021 at 06:04:56PM +, Bruce Richardson wrote: > On Wed, Nov 24, 2021 at 09:24:42AM -0800, Tyler Retzlaff wrote: > > On Fri, Nov 19, 2021 at 10:56:36AM +0100, Thomas Monjalon wrote: > > > 19/11/2021 10:34, Ferruh Yigit: > > > > >> +if (ptr == NULL) { > > > > >> +r

Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

Hi Dariusz Substituting options with NOOP might cause rte_ipv4_fragment_packet to produce more fragments than necessary, since options with copied flag unset will still occupy space in IPv4 header. --The "ip_options_fragment" just make a replacement and doesn't change the length of the IPv4

[PATCH] net/ixgbe: add vector Rx parameter check

Under the circumstance that `rx_tail` wrap back to zero and the advance speed of `rx_tail` is greater than `rxrearm_start`, `rx_tail` will catch up with `rxrearm_start` and surpass it. This may cause some mbufs be reused by applicaion. So we need to make some restrictions to ensure that `rx_tail`

[PATCH] net/ixgbe: add vector Rx parameter check

Under the circumstance that `rx_tail` wrap back to zero and the advance speed of `rx_tail` is greater than `rxrearm_start`, `rx_tail` will catch up with `rxrearm_start` and surpass it. This may cause some mbufs be reused by applicaion. So we need to make some restrictions to ensure that `rx_tail`

RE: [PATCH] net/ixgbe: add vector Rx parameter check

> -Original Message- > From: Bin Zheng > Sent: Thursday, December 2, 2021 11:19 > To: dev@dpdk.org > Cc: Wang, Haiyue ; lian...@liangbit.com; Bin Zheng > ; jia@intel.com; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: add vector Rx parameter check > > Under the circumstance that `rx_ta

RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000

[Public] Hi Arsalan, Thank you for your comments. Regards, Chandu -Original Message- From: Awan, Arsalan Sent: Wednesday, December 1, 2021 2:19 PM To: Namburu, Chandu-babu ; dev@dpdk.org Cc: Somalapuram, Amaranath ; Sebastian, Selwin ; Giriyapura, Maheshwaramurthy Subject: Re: [PAT

RE: [PATCH v1] net/axgbe: use PCI root complex device to distinguish AMD hardware

[Public] Hi David Marchand, Thank you for your comments. Will change patch and submit v2 for review Regards, Chandu -Original Message- From: David Marchand Sent: Wednesday, December 1, 2021 2:31 PM To: Namburu, Chandu-babu Cc: dev ; Sebastian, Selwin ; arsalan_a...@mentor.com; Yigit

Re: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

01/12/2021 22:37, Tyler Retzlaff: > On Wed, Nov 24, 2021 at 06:04:56PM +, Bruce Richardson wrote: > > if (ret < 0 && rte_errno == EAGAIN) > > i only urge that this be explicit as opposed to a range i.e. ret == -1 > preferred over ret < 0 I don't understand why you think it is important to l