Re: [dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-10-24 Thread Bing Zhao
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Sunday, October 24, 2021 12:13 AM > To: Bing Zhao > Cc: NBU-Contact-Thomas Monjalon ; > ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; dev@dpdk.org; > konstantin.anan...@intel.com > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures

2021-10-24 Thread David Marchand
Hello guys, On Fri, Oct 22, 2021 at 3:27 PM Konstantin Ananyev wrote: > > link bounding auto-test internally creates emulated ethdev. > Some tests change Rx/Tx functions of this emulated device on the fly: > by directly modifying rte_eth_dev fields and without doing stop/start > for these devices

Re: [dpdk-dev] [PATCH] test/bonding: fix failures after hiding ethdev internal structures

2021-10-24 Thread Ananyev, Konstantin
Hi David, > Hello guys, > > On Fri, Oct 22, 2021 at 3:27 PM Konstantin Ananyev > wrote: > > > > link bounding auto-test internally creates emulated ethdev. > > Some tests change Rx/Tx functions of this emulated device on the fly: > > by directly modifying rte_eth_dev fields and without doing sto

Re: [dpdk-dev] [PATCH v2 0/4] mbuf: offload flags namespace

2021-10-24 Thread David Marchand
On Fri, Oct 15, 2021 at 9:24 PM Olivier Matz wrote: > > This patchset fixes the mbuf offload flags namespace by adding an RTE_ > prefix to the definitions. The old flags remain usable, but a deprecation > warning is issued at compilation. > > v2 > * rebase > * remove part about PKT_RX_EIP_CKSUM_BA

[dpdk-dev] [PATCH] net: fix pedantic build for L2TPv2 definitions

2021-10-24 Thread David Marchand
Build is broken on RHEL7 following introduction of this new protocol. Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") Signed-off-by: David Marchand --- lib/net/rte_l2tpv2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/net/rte_l2tpv2.h b/lib/net/rte_l2tpv2.h index 4634

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-24 Thread Ananyev, Konstantin
> > > > When stopping a port, the data path Tx and Rx burst functions > > should > > > > be stopped firstly conventionally. Then the dummy functions are > > used > > > > to replace the callback functions provided by the PMD. > > > > > > > > When the application stops a port without or before stop

Re: [dpdk-dev] [PATCH v2 0/3] Predictable RSS feature

2021-10-24 Thread Vladimir Medvedkin
Hi Thomas, пт, 22 окт. 2021 г. в 22:56, Thomas Monjalon : > 11/04/2021 20:51, Medvedkin, Vladimir: > > On 08/04/2021 18:56, Stephen Hemminger wrote: > > >> app/test/test_thash.c | 468 +++- > > >> lib/librte_hash/meson.build | 3 +- > > >> lib/librte_hash/r

[dpdk-dev] [PATCH] app/testpmd: fix MTU configuration before device start

2021-10-24 Thread Andrew Rybchenko
There is no point to do rte_eth_dev_mtu_set() before configure since set MTU value is overwritten on configure anyway. So, setting of MTU before configure is rejected now on ethdev level. If testpmd is going to do configure (e.g. just after testpmd start with disabled devices start up or any confi

Re: [dpdk-dev] [PATCH] net: fix pedantic build for L2TPv2 definitions

2021-10-24 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of David Marchand > Sent: Sunday, October 24, 2021 2:46 PM > To: dev@dpdk.org > Cc: Olivier Matz ; Ferruh Yigit > ; Ori Kam ; Jie Wang > ; Wenjun Wu ; Andrew > Rybchenko > Subject: [dpdk-dev] [PATCH] net: fix pedantic build for L2TPv2 defini

Re: [dpdk-dev] [PATCH 01/10] common/mlx5: update PRM definitions for regex availability

2021-10-24 Thread Ori Kam
Hi Francis, > -Original Message- > From: Francis Kelly > Sent: Friday, October 22, 2021 6:46 PM > To: Thomas Monjalon ; Matan Azrad ; > Slava Ovsiienko > ; Ori Kam > Cc: JAMES HUNTER ; Ady Agbarih ; > dev@dpdk.org; > Ady Agbarih > Subject: [PATCH 01/10] common/mlx5: update PRM definit

Re: [dpdk-dev] [PATCH 03/10] common/mlx5: update regex DevX commands

2021-10-24 Thread Ori Kam
Hi Francis, > -Original Message- > From: Francis Kelly > Sent: Friday, October 22, 2021 6:46 PM > Subject: [PATCH 03/10] common/mlx5: update regex DevX commands > > From: Ady Agbarih > > This patch modifies the SET_REGEXP_PARAMS devx command as follows: > Remove DB setup devx command

Re: [dpdk-dev] [PATCH 04/10] regex/mlx5: remove regexp register read/write

2021-10-24 Thread Ori Kam
Hi Francis, > -Original Message- > From: Francis Kelly > Sent: Friday, October 22, 2021 6:46 PM > Subject: [PATCH 04/10] regex/mlx5: remove regexp register read/write > > From: Ady Agbarih > > Remove the set/query regexp register commands from devx. > Remove functions that used these c

Re: [dpdk-dev] [PATCH 07/10] regex/mlx5: removed redundant rxp csr file

2021-10-24 Thread Ori Kam
Hi Francis, > -Original Message- > From: Francis Kelly > Sent: Friday, October 22, 2021 6:46 PM > Subject: [PATCH 07/10] regex/mlx5: removed redundant rxp csr file > > The mlx5_rxp_csrs.h file has been deprecated as > its contents has now been moved to FW. > > Signed-off-by: Francis Kel

Re: [dpdk-dev] [PATCH 05/10] regex/mlx5: move RXP to CrSpace

2021-10-24 Thread Ori Kam
Hi Francis, > -Original Message- > From: Francis Kelly > Sent: Friday, October 22, 2021 6:46 PM > Subject: [PATCH 05/10] regex/mlx5: move RXP to CrSpace > > From: Ady Agbarih > > Add patch for programming the regex database through rof file, > using the firmware instead of manually thr

Re: [dpdk-dev] [PATCH 08/10] regex/mlx5: fix uninitialized QP destroy

2021-10-24 Thread Ori Kam
Hi Francis, > -Original Message- > From: Francis Kelly > Sent: Friday, October 22, 2021 6:46 PM > Subject: [PATCH 08/10] regex/mlx5: fix uninitialized QP destroy > > From: Ady Agbarih > > The number of QPs for a device are setup during the > configuration phase, when the user calls >

Re: [dpdk-dev] [PATCH 09/10] regex/mlx5: prevent QP double setup

2021-10-24 Thread Ori Kam
> -Original Message- > From: Francis Kelly > Sent: Friday, October 22, 2021 6:46 PM > Subject: [PATCH 09/10] regex/mlx5: prevent QP double setup > > From: Ady Agbarih > > When mlx5_regex_qp_setup() is called make sure > the provided QP is not already setup. > > Signed-off-by: Ady A

Re: [dpdk-dev] [PATCH 10/10] doc: updated release notes and mlx5 file

2021-10-24 Thread Ori Kam
> -Original Message- > From: Francis Kelly > Sent: Friday, October 22, 2021 6:46 PM > Subject: [PATCH 10/10] doc: updated release notes and mlx5 file > > Provided further description within documentation regarding > the RXP to CRSpace changes. > > Signed-off-by: Francis Kelly > --- >

[dpdk-dev] [PATCH v6 0/9] make rte_intr_handle internal

2021-10-24 Thread David Marchand
Moving struct rte_intr_handle as an internal structure to avoid any ABI breakages in future. Since this structure defines some static arrays and changing respective macros breaks the ABI. Eg: Currently RTE_MAX_RXTX_INTR_VEC_ID imposes a limit of maximum 512 MSI-X interrupts that can be defined for

[dpdk-dev] [PATCH v6 1/9] interrupts: add allocator and accessors

2021-10-24 Thread David Marchand
From: Harman Kalra Prototype/Implement get set APIs for interrupt handle fields. User won't be able to access any of the interrupt handle fields directly while should use these get/set APIs to access/manipulate them. Internal interrupt header i.e. rte_eal_interrupt.h is rearranged, as APIs defin

[dpdk-dev] [PATCH v6 2/9] interrupts: remove direct access to interrupt handle

2021-10-24 Thread David Marchand
From: Harman Kalra Making changes to the interrupt framework to use interrupt handle APIs to get/set any field. Signed-off-by: Harman Kalra Signed-off-by: David Marchand --- Changes since v5: - used new helper rte_intr_instance_dup, --- lib/eal/freebsd/eal_interrupts.c | 85 + lib/e

[dpdk-dev] [PATCH v6 3/9] test/interrupts: remove direct access to interrupt handle

2021-10-24 Thread David Marchand
From: Harman Kalra Updating the interrupt testsuite to make use of interrupt handle get set APIs. Signed-off-by: Harman Kalra Signed-off-by: David Marchand --- Changes since v5: - fixed leak on when some interrupt handle can't be allocated, --- app/test/test_interrupts.c | 164 ++

[dpdk-dev] [PATCH v6 4/9] alarm: remove direct access to interrupt handle

2021-10-24 Thread David Marchand
From: Harman Kalra Removing direct access to interrupt handle structure fields, rather use respective get set APIs for the same. Making changes to all the libraries access the interrupt handle fields. Implementing alarm cleanup routine, where the memory allocated for interrupt instance can be fr

[dpdk-dev] [PATCH v6 5/9] lib: remove direct access to interrupt handle

2021-10-24 Thread David Marchand
From: Harman Kalra Removing direct access to interrupt handle structure fields, rather use respective get set APIs for the same. Making changes to all the libraries access the interrupt handle fields. Signed-off-by: Harman Kalra Signed-off-by: David Marchand --- Changes since v5: - split from

[dpdk-dev] [PATCH v6 7/9] interrupts: make interrupt handle structure opaque

2021-10-24 Thread David Marchand
From: Harman Kalra Moving interrupt handle structure definition inside a EAL private header to make its fields totally opaque to the outside world. Signed-off-by: Harman Kalra Signed-off-by: David Marchand --- Changes since v5: - let rte_intr_handle fields untouched: - split vfio / uio fd re

[dpdk-dev] [PATCH v6 8/9] interrupts: rename device specific file descriptor

2021-10-24 Thread David Marchand
From: Harman Kalra VFIO/UIO are mutually exclusive, storing file descriptor in a single field is enough. Signed-off-by: Harman Kalra Signed-off-by: David Marchand --- Changes since v5: - split from patch5, --- lib/eal/common/eal_common_interrupts.c | 6 +++--- lib/eal/common/eal_interrupts.h

[dpdk-dev] [PATCH v6 9/9] interrupts: extend event list

2021-10-24 Thread David Marchand
From: Harman Kalra Dynamically allocating the efds and elist array os intr_handle structure, based on size provided by user. Eg size can be MSIX interrupts supported by a PCI device. Signed-off-by: Harman Kalra Signed-off-by: David Marchand --- Changes since v5: - split from patch5, --- driv

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header

2021-10-24 Thread Dmitry Kozlyuk
2021-10-11 21:07 (UTC+0200), Thomas Monjalon: > 01/10/2021 18:37, Dmitry Kozlyuk: > > The header was not intended to be a public one. > > DPDK users should use `rte_mem_virt2iova()` to translate addresses. > > Other virt2phys users should use the header from the driver instead. > > > > Fixes: 2a5d

Re: [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer

2021-10-24 Thread Peng, ZhihongX
> -Original Message- > From: Peng, ZhihongX > Sent: Wednesday, October 20, 2021 3:47 PM > To: david.march...@redhat.com; tho...@monjalon.net; Burakov, Anatoly > ; Ananyev, Konstantin > ; step...@networkplumber.org; > Dumitrescu, Cristian ; Mcnamara, John > ; Richardson, Bruce > > Cc: dev@

[dpdk-dev] [PATCH] bonding: show xmit policy for 802.3AD mode

2021-10-24 Thread Min Hu (Connor)
As balance xmit policy is supported in bonding mode 4(802.3AD). This patch adds balance xmit policy show in testpmd commands for mode 4. Like: testpmd> show bonding config 2 Bonding mode: 4 Balance Xmit Policy: BALANCE_XMIT_POLICY_LAYER34 IEEE802.3AD Aggregator Mode: stable

[dpdk-dev] [PATCH v3] net/ice: fix function pointer in multi-process

2021-10-24 Thread dapengx . yu
From: Dapeng Yu This patch uses the index value to call the function, instead of the function pointer assignment to save the selection of Receive Flex Descriptor profile ID. Otherwise the secondary process will run with wrong function address from primary process. Fixes: 7a340b0b4e03 ("net/ice:

[dpdk-dev] [PATCH 1/2] common/octeontx2: sync mbox with AF

2021-10-24 Thread kirankumark
From: Kiran Kumar K Sync mbox with AF, And bump up the version. Signed-off-by: Kiran Kumar K --- drivers/common/octeontx2/otx2_mbox.h | 30 ++-- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common/octeon

[dpdk-dev] [PATCH 2/2] common/cnxk: sync mbox with AF

2021-10-24 Thread kirankumark
From: Kiran Kumar K Sync mbox with AF, And bump up the version. Signed-off-by: Kiran Kumar K --- drivers/common/cnxk/roc_mbox.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_mbox.h b/drivers/common/cnxk/roc_mbox.h index bc40848450..22f

[dpdk-dev] [PATCH] crypto/cnxk: fix bus error on RSA verify

2021-10-24 Thread kirankumark
From: Kiran Kumar K While creating RSA session, private key length is not being calculated properly. This is causing bus error on RSA verify. This patch fix the issue with length calculation. Fixes: 5a3513caeb455 ("crypto/cnxk: add asymmetric session") Signed-off-by: Kiran Kumar K --- drivers

Re: [dpdk-dev] [PATCH] crypto/cnxk: fix bus error on RSA verify

2021-10-24 Thread Anoob Joseph
> From: Kiran Kumar K > > While creating RSA session, private key length is not being calculated > properly. This is causing bus error on RSA verify. > This patch fix the issue with length calculation. > > Fixes: 5a3513caeb455 ("crypto/cnxk: add asymmetric session") > > Signed-off-by: Kiran Kum

Re: [dpdk-dev] [EXT] [PATCH v5] cryptodev: add telemetry callbacks

2021-10-24 Thread Akhil Goyal
> --- > v5: > - Added missing telemetry dependency to meson.build. > v4: > - Corrected doc heading underline and link. > - Replaced remaining -1 return values with -EINVAL. > + > +static int > +cryptodev_handle_dev_list(const char *cmd __rte_unused, > + const char *params __rte_u

[dpdk-dev] [PATCH v3 0/4] Use correct memory ordering in eal functions

2021-10-24 Thread Honnappa Nagarahalli
v3: a) Added Fixes, Cc:stable#dpdk.org in 1/6 b) Merged 3/6 & 4/6 and moved after the first commit in the series c) Merged 2/6 & 5/6 as they need to be in a single commit d) Removed use of volatile in 6/6 (Konstantin) rte_eal_remote_launch and rte_eal_wait_lcore need to provide correct memory orde

[dpdk-dev] [PATCH v3 1/4] eal: reset lcore function pointer and argument

2021-10-24 Thread Honnappa Nagarahalli
In the rte_eal_remote_launch function, the lcore function pointer is checked for NULL. However, the pointer is never reset to NULL. Reset the lcore function pointer and argument after the worker has completed executing the lcore function. Fixes: af75078fece3 ("first public release") Cc: sta...@dpd

[dpdk-dev] [PATCH v3 2/4] eal: lcore state FINISHED is not required

2021-10-24 Thread Honnappa Nagarahalli
FINISHED state seems to be used to indicate that the worker's update of the 'state' is not visible to other threads. There seems to be no requirement to have such a state. Since the FINISHED state is removed, the API rte_eal_wait_lcore is updated to always return the status of the last function th

[dpdk-dev] [PATCH v3 3/4] eal: use correct memory ordering

2021-10-24 Thread Honnappa Nagarahalli
Ensure that the memory operations before the call to rte_eal_remote_launch are visible to the worker thread. Use the function pointer to execute in worker thread as the guard variable. Ensure that the memory operations in worker thread, that happen before it returns the status of the assigned func

[dpdk-dev] [PATCH v3 4/4] test/ring: use relaxed barriers for ring stress test

2021-10-24 Thread Honnappa Nagarahalli
wrk_cmd variable is used to signal the worker thread to start or stop the stress test loop. Relaxed barriers are used to achieve the same. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Reviewed-by: Feifei Wang --- app/test/test_ring_stress_impl.h | 18 +- 1 fil

[dpdk-dev] [PATCH v4] net/ice: fix function pointer in multi-process

2021-10-24 Thread dapengx . yu
From: Dapeng Yu This patch uses the index value to call the function, instead of the function pointer assignment to save the selection of Receive Flex Descriptor profile ID. Otherwise the secondary process will run with wrong function address from primary process. Fixes: 7a340b0b4e03 ("net/ice:

Re: [dpdk-dev] [PATCH v4] net/ice: fix function pointer in multi-process

2021-10-24 Thread Wang, Haiyue
> -Original Message- > From: Yu, DapengX > Sent: Monday, October 25, 2021 13:40 > To: Yang, Qiming ; Zhang, Qi Z > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > ; > sta...@dpdk.org > Subject: [PATCH v4] net/ice: fix function pointer in multi-process > > From: Dapeng Yu > > This patch

Re: [dpdk-dev] [PATCH 02/10] vdpa/sfc: add support for device initialization

2021-10-24 Thread Vijay Kumar Srivastava
Hi Chenbo, >-Original Message- >From: Xia, Chenbo >Sent: Tuesday, October 19, 2021 7:47 AM >To: Vijay Kumar Srivastava ; dev@dpdk.org >Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Harpreet >Singh Anand ; Praveen Kumar Jain >Subject: RE: [PATCH 02/10] vdpa/sfc: add supp

[dpdk-dev] [PATCH 0/3] bugfix for testpmd

2021-10-24 Thread Min Hu (Connor)
This patchset contains three bugfixes for testpmd. Huisong Li (3): app/testpmd: fix port status of active slave device app/testpmd: fix slave device isn't released app/testpmd: remove unused header file app/test-pmd/cmdline.c| 2 + app/test-pmd/parameters.c | 3 - app/test-pmd/test

[dpdk-dev] [PATCH 2/3] app/testpmd: fix slave device isn't released

2021-10-24 Thread Min Hu (Connor)
From: Huisong Li Currently, some eth devices are added to bond device, these devices are not released when the quit command is executed in testpmd. This patch adds the release operation for all active slaves under a bond device. Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in bo

[dpdk-dev] [PATCH 1/3] app/testpmd: fix port status of active slave device

2021-10-24 Thread Min Hu (Connor)
From: Huisong Li Stopping a bond device also stops all active slaves under the bond device. If this port is bond device, we need to modify the port status of all slaves from RTE_PORT_STARTED to RTE_PORT_STOPPED. Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in bonding") Cc: sta..

[dpdk-dev] [PATCH] net/ice: simplify the use of DCF device reset

2021-10-24 Thread dapengx . yu
From: Dapeng Yu After DCF is reset by PF, the DCF device un-initialization cannot function normally since the resource is already invalidated. So reset DCF twice is necessary, the first reset re-initializes the DCF, only then second reset can clean the filters successfully. This patch detects th

[dpdk-dev] [PATCH 3/3] app/testpmd: remove unused header file

2021-10-24 Thread Min Hu (Connor)
From: Huisong Li This patch removes unused "rte_eth_bond.h" header file. Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- app/test-pmd/parameters.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index ab8e8f7e69..1dc8320

[dpdk-dev] [PATCH v8 0/5] Support power monitor in virtio/vhost PMD

2021-10-24 Thread Miao Li
This patchset implements rte_power_monitor API in virtio and vhost PMD to reduce power consumption when no packet come in. This API can be called and tested in l3fwd-power after adding vhost and virtio support in l3fwd-power and ignoring the rx queue information check in queue_stopped(). v8: -reba

[dpdk-dev] [PATCH v8 1/5] net/virtio: support power monitor

2021-10-24 Thread Miao Li
According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and virtio_get_monitor_addr to provide address to monitor. When no packet come in, the value of address will not be changed a

[dpdk-dev] [PATCH v8 2/5] vhost: add power monitor support API

2021-10-24 Thread Miao Li
This commit defines rte_vhost_power_monitor_cond which is used to pass some information to vhost driver. The information is including the address to monitor, the expected value, the mask to extract value read from 'addr', the value size of monitor address, the match flag used to distinguish the val

[dpdk-dev] [PATCH v8 3/5] net/vhost: support power monitor

2021-10-24 Thread Miao Li
According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value against the expected value and vhost_get_monitor_addr to provide address to monitor. When no packet come in, the value of address will not be changed an

[dpdk-dev] [PATCH v8 4/5] power: modify return of queue_stopped

2021-10-24 Thread Miao Li
Since some vdevs like virtio and vhost do not support rxq_info_get and queue state inquiry, the error return value -ENOTSUP need to be ignored when queue_stopped cannot get rx queue information and rx queue state. This patch changes the return value of queue_stopped when rte_eth_rx_queue_info_get r

[dpdk-dev] [PATCH v8 5/5] examples/l3fwd-power: support virtio/vhost

2021-10-24 Thread Miao Li
In l3fwd-power, there is default port configuration which requires RSS and IPV4/UDP/TCP checksum. Once device does not support these, the l3fwd-power will exit and report an error. This patch updates the port configuration based on device capabilities after getting the device information to support

Re: [dpdk-dev] [PATCH v6 2/9] interrupts: remove direct access to interrupt handle

2021-10-24 Thread David Marchand
On Sun, Oct 24, 2021 at 10:05 PM David Marchand wrote: > @@ -556,8 +565,8 @@ eal_intr_process_interrupts(struct kevent *events, int > nfds) > * remove intr file descriptor from wait list. > */ > if (