Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-23 Thread Thomas Monjalon
22/10/2021 23:14, Bing Zhao: > When stopping a port, the data path Tx and Rx burst functions should > be stopped firstly conventionally. Then the dummy functions are used > to replace the callback functions provided by the PMD. > > When the application stops a port without or before stopping the d

Re: [dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-10-23 Thread Thomas Monjalon
22/10/2021 23:14, Bing Zhao: > In the function "eth_dev_fp_ops_reset", a structure assignment > operation is used to reset one queue's callback functions, etc., but > it is not thread safe. > > The structure assignment is not atomic, a lot of instructions will > be generated. Right now, since not

Re: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows

2021-10-23 Thread Dmitry Kozlyuk
2021-10-23 08:55 (UTC+0200), David Marchand: > Windows compilation gives us a splat: > In file included from ../drivers/dma/idxd/idxd_pci.c:10: > In file included from ..\drivers\dma\idxd/idxd_internal.h:11: > ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or > ';' after dec

Re: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows

2021-10-23 Thread David Marchand
On Sat, Oct 23, 2021 at 8:56 AM David Marchand wrote: > > Windows compilation gives us a splat: > In file included from ../drivers/dma/idxd/idxd_pci.c:10: > In file included from ..\drivers\dma\idxd/idxd_internal.h:11: > ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or > '

Re: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows

2021-10-23 Thread David Marchand
On Sat, Oct 23, 2021 at 10:38 AM Dmitry Kozlyuk wrote: > > 2021-10-23 08:55 (UTC+0200), David Marchand: > > Windows compilation gives us a splat: > > In file included from ../drivers/dma/idxd/idxd_pci.c:10: > > In file included from ..\drivers\dma\idxd/idxd_internal.h:11: > > ..\drivers\dma\idxd/i

[dpdk-dev] [PATCH] devtools: forbid additions of __reserved

2021-10-23 Thread David Marchand
__reserved is a reserved keyword in Windows system headers. Signed-off-by: David Marchand --- devtools/checkpatches.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index c314d83a29..25f60a4a27 100755 --- a/devtools/checkpatches.

Re: [dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-10-23 Thread Ananyev, Konstantin
> 22/10/2021 23:14, Bing Zhao: > > In the function "eth_dev_fp_ops_reset", a structure assignment > > operation is used to reset one queue's callback functions, etc., but > > it is not thread safe. > > > > The structure assignment is not atomic, a lot of instructions will > > be generated. Right

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-23 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon > Sent: Saturday, October 23, 2021 9:33 AM > To: Bing Zhao > Cc: Yigit, Ferruh ; andrew.rybche...@oktetlabs.ru; > dev@dpdk.org; Ananyev, Konstantin > > Subject: Re: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions > > 22/10/

Re: [dpdk-dev] [PATCH v1] test: fix devargs test case memory leak

2021-10-23 Thread David Marchand
On Sat, Oct 23, 2021 at 2:18 PM Xueming Li wrote: > > In layer argument test function, kvargs are parsed and checked without > free. This patch calls rte_kvargs_free() function to avoid memory leak. > Coverity issue: 373631 > Fixes: a4975cd20dca ("test: add devargs test cases") > > Signed-off-by:

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-23 Thread Bing Zhao
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Saturday, October 23, 2021 4:33 PM > To: Bing Zhao > Cc: ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; > dev@dpdk.org; konstantin.anan...@intel.com > Subject: Re: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy

Re: [dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops reset

2021-10-23 Thread Stephen Hemminger
On Sat, 23 Oct 2021 00:14:07 +0300 Bing Zhao wrote: > diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c > index fbc3df91ad..cda9a6e228 100644 > --- a/lib/ethdev/ethdev_private.c > +++ b/lib/ethdev/ethdev_private.c > @@ -206,7 +206,7 @@ eth_dev_fp_ops_reset(struct rte_eth_fp_o

[dpdk-dev] [PATCH v1] test: fix devargs test case memory leak

2021-10-23 Thread Xueming Li
In layer argument test function, kvargs are parsed and checked without free. This patch calls rte_kvargs_free() function to avoid memory leak. Fixes: a4975cd20dca ("test: add devargs test cases") Signed-off-by: Xueming Li --- app/test/test_devargs.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [dpdk-dev] [PATCH v5 3/3] test/devargs: add devargs test cases

2021-10-23 Thread Xueming(Steven) Li
On Sat, 2021-10-23 at 08:17 +0200, David Marchand wrote: > On Wed, Oct 20, 2021 at 5:48 PM Xueming Li wrote: > > + kvlist = rte_kvargs_parse(args, NULL); > > + if (kvlist == NULL) { > > + printf("rte_devargs_parse(%s) %s_str: %s not parsed\n", > > + d

Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions

2021-10-23 Thread Bing Zhao
Hi Ananyev, > -Original Message- > From: Ananyev, Konstantin > Sent: Saturday, October 23, 2021 7:47 PM > To: NBU-Contact-Thomas Monjalon ; Bing Zhao > > Cc: Yigit, Ferruh ; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org > Subject: RE: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy