Hi Akhil,
This isn’t what our concern was – our concern was rte_cryptodev_close() may not
remove the memory complete as rte_cryptodev_pmd_destroy() did.
Our research result towards this was if the PMD could act more throughout to
make rte_cryptodev_close() working same as rte_cryptodev_pmd_destr
On Fri, Sep 03, 2021 at 10:30:03AM +0300, getelson wrote:
> From: Gregory Etelson
>
> RTE IPv4 header definition combines the `version' and `ihl' fields
> into a single structure member.
> This patch introduces dedicated structure members for both `version'
> and `ihl' IPv4 fields. Separated hea
Ahh, yes!!!
queue_pair_release is not a public API it was mentioned in the
rte_cryptodev_pmd.h, and it was mentioned on top of the file NOT to use it
directly in the application.
Could you please mention the use case for which this memory need to be cleared
before the stop or close of the devic
On Wed, Sep 29, 2021 at 11:50 PM Olivier Matz wrote:
>
> The flags PKT_TX_VLAN_PKT, PKT_TX_QINQ_PKT, PKT_RX_EIP_CKSUM_BAD are
> marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated
> VLAN flags") (2017). Remove their definitions from rte_mbuf_core.h,
> and replace their usages.
From: Pavan Nikhilesh
The transmit loop incorrectly assumes that nb_mbufs is always
a multiple of 4 when transmitting an event vector. The max
size of the vector might not be reached and pushed out early
due to timeout.
Fixes: 761a321acf91 ("event/cnxk: support vectorized Tx event fast path")
S
From: Pavan Nikhilesh
SSO group base addresses are always are always contiguous we
need not store all the base addresses in workslot memory, instead
just store the base address and compute the group address offset
when required.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/cnxk/cn10k_event
From: Pavan Nikhilesh
Rework SSO enqueue path for CN9K make it similar to CN10K
enqueue interface.
Signed-off-by: Pavan Nikhilesh
---
drivers/event/cnxk/cn9k_eventdev.c| 28 ++-
drivers/event/cnxk/cn9k_worker.c | 21 ++---
drivers/event/cnxk/cn9k_worker.h
On 10/1/2021 6:40 PM, Ananyev, Konstantin wrote:
>
>
>> On 10/1/2021 3:02 PM, Konstantin Ananyev wrote:
>>> Rework 'fast' burst functions to use rte_eth_fp_ops[].
>>> While it is an API/ABI breakage, this change is intended to be
>>> transparent for both users (no changes in user app is required)
Hi David,
Thanks for the review.
Please see my comments inline.
> -Original Message-
> From: David Marchand
> Sent: Tuesday, September 28, 2021 9:17 PM
> To: Harman Kalra
> Cc: dev ; Ray Kinsella
> Subject: [EXT] Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement get
> set APIs
>
On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote:
> From: Pavan Nikhilesh
>
> Due to Linux kernel AF(Admin function) driver dependency, only enable
> build for 64-bit Linux.
>
Hi Pavan,
Isn't it possible to provide a commit log in the kernel side etc, that let
others to verify why only 64
On Fri, Oct 1, 2021 at 8:06 PM Ferruh Yigit wrote:
>
> Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support,
> and application should enable the jumbo frame offload support for it.
>
> When jumbo frame offload is not enabled by application, but MTU bigger
> than RTE_ETHER_MTU is
On Fri, Oct 1, 2021 at 8:07 PM Ferruh Yigit wrote:
>
> Move requested MTU value check to the API to prevent the duplicated
> code.
>
> Signed-off-by: Ferruh Yigit
> Reviewed-by: Andrew Rybchenko
> Reviewed-by: Rosen Xu
> ---
> drivers/net/axgbe/axgbe_ethdev.c| 15 ---
> dri
On 10/1/21 3:10 PM, Thomas Monjalon wrote:
> 01/10/2021 12:15, Andrew Rybchenko:
>> On 10/1/21 12:48 PM, Thomas Monjalon wrote:
>>> 01/10/2021 10:55, Ivan Malov:
On 01/10/2021 11:11, Thomas Monjalon wrote:
> 01/10/2021 08:47, Andrew Rybchenko:
>> On 9/30/21 10:30 PM, Ivan Malov wrote:
> >>
> >>> static inline int
> >>> rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id)
> >>> {
> >>> - struct rte_eth_dev *dev;
> >>> + struct rte_eth_fp_ops *p;
> >>> + void *qd;
> >>> +
> >>> + if (port_id >= RTE_MAX_ETHPORTS ||
> >>> + queue_id >= RTE_MAX_QUEUES_PER_P
These methods were introduced in 20.05.
There has been no changes in their public API since then.
They seem mature enough to remove the experimental tag.
Signed-off-by: Sean Morrissey
Acked-by: Konstantin Ananyev
---
lib/ring/rte_ring_core.h| 2 --
lib/ring/rte_ring_elem.h| 12
Hi David,
Thank you for the review, my comments below.
On Mon, Oct 04, 2021 at 10:29:36AM +0200, David Marchand wrote:
> On Wed, Sep 29, 2021 at 11:50 PM Olivier Matz wrote:
> >
> > The flags PKT_TX_VLAN_PKT, PKT_TX_QINQ_PKT, PKT_RX_EIP_CKSUM_BAD are
> > marked as deprecated since commit 380a7aa
Hi Ivan,
> -Original Message-
> From: Ivan Malov
> Sent: Sunday, October 3, 2021 9:11 PM
> Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API
>
>
>
> On 03/10/2021 15:40, Ori Kam wrote:
> > Hi Andrew and Ivan,
> >
> >> -Original Message-
> >> From: Andrew R
On Mon, Oct 4, 2021 at 10:51 AM Harman Kalra wrote:
> > > +struct rte_intr_handle *rte_intr_handle_instance_alloc(int size,
> > > + bool
> > > +from_hugepage) {
> > > + struct rte_intr_handle *intr_handle;
> > > + int i;
> > > +
> >
>On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote:
>> From: Pavan Nikhilesh
>>
>> Due to Linux kernel AF(Admin function) driver dependency, only
>enable
>> build for 64-bit Linux.
>>
>
>Hi Pavan,
>
>Isn't it possible to provide a commit log in the kernel side etc, that let
>others to verify wh
From: Pavan Nikhilesh
GCC now assigns even register pairs for CASP, the fix has also been
backported to all stable releases of older GCC versions.
Removing the manual register allocation allows GCC to inline the
functions and pick optimal registers for performing CASP.
Signed-off-by: Pavan Nikhi
This patchset introduces the include-what-you-use script which removes
unused header includes. IWYU GitHub:
https://github.com/include-what-you-use/include-what-you-use
Along with the script there are some patches which make a start on
removing unneeded headers.
Sean Morrissey (5):
devtools: s
This script can be used for removing headers flagged for removal by the
include-what-you-use (IWYU) tool. The script has the ability to remove
headers from specified sub-directories or dpdk as a whole.
example usages:
Remove headers flagged by iwyu_tool output file
$ ./devtools/process_iwyu.py iw
These header includes have been flagged by the iwyu_tool
and removed.
Signed-off-by: Sean Morrissey
---
lib/telemetry/telemetry.c | 1 -
lib/telemetry/telemetry_data.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 8665db8d03
These header includes have been flagged by the iwyu_tool
and removed.
Signed-off-by: Sean Morrissey
---
lib/ring/rte_ring.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index f17bd966be..bb95962b0c 100644
--- a/lib/ring/rte_ring.c
+++ b/lib/
These header includes have been flagged by the iwyu_tool
and removed.
Signed-off-by: Sean Morrissey
---
lib/kvargs/rte_kvargs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c
index 38e9d5c1ca..4cce8e953b 100644
--- a/lib/kvargs/rte_kvargs.c
+
These header includes have been flagged by the iwyu_tool
and removed.
Signed-off-by: Sean Morrissey
---
lib/eal/common/eal_common_dev.c| 5 -
lib/eal/common/eal_common_devargs.c| 1 -
lib/eal/common/eal_common_errno.c | 4
lib/eal/common/eal_common_fbarray.c| 3
On 10/4/2021 10:20 AM, Ananyev, Konstantin wrote:
>
> static inline int
> rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id)
> {
> - struct rte_eth_dev *dev;
> + struct rte_eth_fp_ops *p;
> + void *qd;
> +
> + if (port_id >= RTE_MAX_ETHPORTS ||
> -Original Message-
> From: Morrissey, Sean
> Sent: Monday, October 4, 2021 11:11 AM
> To: Burakov, Anatoly ; Jerin Jacob
> ; Sunil Kumar Kori ; mattias.ronnblom
> ; Van Haaren, Harry
> ; Harman Kalra ;
> Richardson, Bruce ; Ananyev, Konstantin
>
> Cc: dev@dpdk.org; Morrissey, Sean
> Su
Hi Dmitry,
Thanks for reviewing the series.
Please find my comments inline.
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Sunday, October 3, 2021 11:35 PM
> To: Harman Kalra
> Cc: dev@dpdk.org; Ray Kinsella
> Subject: [EXT] Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement
As described in [1] and as announced in [2], The field ``dataunit_len``
of the ``struct rte_crypto_cipher_xform`` moved to the end of the
structure and extended to ``uint32_t``.
In this way, sizes bigger than 64K bytes can be supported for data-unit
lengths.
[1] commit d014dddb2d69 ("cryptodev: s
> -Original Message-
> From: Thomas Monjalon
> Sent: Thursday, September 30, 2021 0:58
> To: Matan Azrad ; Slava Ovsiienko
> ; Rongwei Liu
> Cc: Ori Kam ; dev@dpdk.org; Raslan Darawsheh
>
> Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: support socket direct
> mode bonding
>
> 28/09/2
On 10/4/21 3:00 AM, Ivan Malov wrote:
> Hi Ori,
>
> On 04/10/2021 00:09, Ori Kam wrote:
>> Hi Ivan,
>>
>>> -Original Message-
>>> From: Ivan Malov
>>> Subject: Re: [PATCH v1 01/12] ethdev: add ethdev item to flow API
>>>
>>> Hi Ori,
>>>
>>> On 03/10/2021 14:52, Ori Kam wrote:
Hi Andr
Hi Ivan,
> -Original Message-
> From: Ivan Malov
> Sent: Monday, October 4, 2021 2:50 AM
> Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta
> data
>
> Hi Ori,
>
> On 04/10/2021 00:04, Ori Kam wrote:
> > Hi Ivan,
> >
> > Sorry for the long review.
> >
> >> ---
Hi Ori,
On 04/10/2021 08:45, Ori Kam wrote:
Hi Ivan,
-Original Message-
From: Ivan Malov
Sent: Sunday, October 3, 2021 9:11 PM
Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API
On 03/10/2021 15:40, Ori Kam wrote:
Hi Andrew and Ivan,
-Original Message---
Hi Andrew, Ori,
On 04/10/2021 13:47, Andrew Rybchenko wrote:
On 10/4/21 3:00 AM, Ivan Malov wrote:
Hi Ori,
On 04/10/2021 00:09, Ori Kam wrote:
Hi Ivan,
-Original Message-
From: Ivan Malov
Subject: Re: [PATCH v1 01/12] ethdev: add ethdev item to flow API
Hi Ori,
On 03/10/2021 14:5
> -Original Message-
> From: Andrew Rybchenko
> Sent: Friday, October 1, 2021 7:17 PM
> To: Jerin Jacob Kollanukkaran ; Nithin Kumar Dabilpuram
> ; Kiran Kumar Kokkilagadda
>
> Cc: dev@dpdk.org; Ori Kam ; Thomas Monjalon
> ; Ferruh Yigit ; Ivan Malov
>
> Subject: [EXT] [PATCH v1 11/12
2021-10-04 10:37 (UTC+), Harman Kalra:
> [...]
> > > +struct rte_intr_handle *rte_intr_handle_instance_index_get(
> > > + struct rte_intr_handle *intr_handle, int
> > index)
> >
> > If rte_intr_handle_instance_alloc() returns a pointer to an array, this
> > function
On 10/4/2021 3:15 AM, Wu, Jingjing wrote:
-Original Message-
From: Nicolau, Radu
Sent: Friday, October 1, 2021 5:52 PM
To: Wu, Jingjing ; Xing, Beilei
Cc: dev@dpdk.org; Doherty, Declan ; Sinha, Abhijit
; Zhang, Qi Z ; Richardson, Bruce
; Ananyev, Konstantin
;
Nicolau, Radu
Subject
>
> On 10/4/2021 10:20 AM, Ananyev, Konstantin wrote:
> >
>
> > static inline int
> > rte_eth_rx_queue_count(uint16_t port_id, uint16_t queue_id)
> > {
> > - struct rte_eth_dev *dev;
> > + struct rte_eth_fp_ops *p;
> > + void *qd;
> > +
> >>>
On 9/27/2021 8:56 AM, Thomas Monjalon wrote:
> 27/09/2021 09:21, Wang, Jie1X:
>> From: Thomas Monjalon
>>> 26/09/2021 11:20, Jie Wang:
This patch adds a new API "rte_eth_dev_conf_info_get()" to help users
get device configuration info.
>>> [...]
+ * Retrieve the configuration of an
On 9/26/2021 10:20 AM, Jie Wang wrote:
> This patch adds a new API "rte_eth_dev_conf_info_get()" to help users get
> device configuration info.
>
> Cc: sta...@dpdk.org
>
Since this is a new API, I think we can request it to be backported.
> Signed-off-by: Jie Wang
<...>
> @@ -247,6 +247,9 @@
On 9/26/2021 10:20 AM, Jie Wang wrote:
> Add information about new ethdev API.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Jie Wang
> ---
> doc/guides/rel_notes/release_21_11.rst | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_21_11.rst
> b/doc/guides/
04/10/2021 13:20, Ferruh Yigit:
> On 9/27/2021 8:56 AM, Thomas Monjalon wrote:
> > 27/09/2021 09:21, Wang, Jie1X:
> >> From: Thomas Monjalon
> >>> 26/09/2021 11:20, Jie Wang:
> This patch adds a new API "rte_eth_dev_conf_info_get()" to help users
> get device configuration info.
> >>> [.
04/10/2021 13:22, Ferruh Yigit:
> On 9/26/2021 10:20 AM, Jie Wang wrote:
> > This patch adds a new API "rte_eth_dev_conf_info_get()" to help users get
> > device configuration info.
> >
> > Cc: sta...@dpdk.org
> >
>
> Since this is a new API, I think we can request it to be backported.
We canno
04/10/2021 13:22, Ferruh Yigit:
> On 9/26/2021 10:20 AM, Jie Wang wrote:
> > Add information about new ethdev API.
> >
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Jie Wang
> > ---
> > doc/guides/rel_notes/release_21_11.rst | 4
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/d
On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote:
>>> From: Pavan Nikhilesh
>>>
>>> Due to Linux kernel AF(Admin function) driver dependency, only
>> enable
>>> build for 64-bit Linux.
>>>
>>
>> Hi Pavan,
>>
>> Isn't it possible to p
>On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>> On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote:
From: Pavan Nikhilesh
Due to Linux kernel AF(Admin function) driver dependency, only
>>> enable
build for 64-bit Linux.
>>>
>>> Hi Pavan,
>>>
>>> Isn't it p
On 10/4/2021 12:26 PM, Thomas Monjalon wrote:
> 04/10/2021 13:22, Ferruh Yigit:
>> On 9/26/2021 10:20 AM, Jie Wang wrote:
>>> This patch adds a new API "rte_eth_dev_conf_info_get()" to help users get
>>> device configuration info.
>>>
>>> Cc: sta...@dpdk.org
>>>
>>
>> Since this is a new API, I thi
Hi Ori,
On 04/10/2021 09:56, Ori Kam wrote:
Hi Ivan,
-Original Message-
From: Ivan Malov
Sent: Monday, October 4, 2021 2:50 AM
Subject: Re: [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta
data
Hi Ori,
On 04/10/2021 00:04, Ori Kam wrote:
Hi Ivan,
Sorry for the long
On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote:
> From: Pavan Nikhilesh
>
> Due to Linux kernel AF(Admin function) driver dependency, only
enable
>
On Mon, Oct 4, 2021 at 10:42 AM Somnath Kotur
wrote:
>
> On Fri, Oct 1, 2021 at 8:07 PM Ferruh Yigit wrote:
> >
> > Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag.
> >
> > Instead of drivers announce this capability, application can deduct the
> > capability by checking reported 'dev_info.max
Hi Ori,
On 04/10/2021 14:37, Ori Kam wrote:
Hi Ivan,
-Original Message-
From: Ivan Malov
Sent: Monday, October 4, 2021 2:06 PM
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API
Hi Ori,
On 04/10/2021 08:45, Ori Kam wrote:
Hi Ivan,
-Origin
>On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
>>> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
> On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote:
>> From: Pavan Nikhilesh
>>
>> Due to Linux kernel AF(Admin function) driver dependency, only
> enabl
> On 9/28/2021 2:51 PM, Junxiao Shi wrote:
> > Previously, memif socket hash is always allocated on NUMA socket 0.
> > If the application is entirely running on another NUMA socket and EAL
> > --socket-limit prevents memory allocation on NUMA socket 0, memif
> > creation fails with "HASH: memory
On 10/4/21 2:13 PM, Kiran Kumar Kokkilagadda wrote:
>
>
>> -Original Message-
>> From: Andrew Rybchenko
>> Sent: Friday, October 1, 2021 7:17 PM
>> To: Jerin Jacob Kollanukkaran ; Nithin Kumar Dabilpuram
>> ; Kiran Kumar Kokkilagadda
>>
>> Cc: dev@dpdk.org; Ori Kam ; Thomas Monjalon
>>
Hi Ciara,
> -Original Message-
> From: Power, Ciara
> Sent: Wednesday, September 29, 2021 5:31 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan ; Bronowski, PiotrX
> ; gak...@marvell.com; Power, Ciara
> ; Thomas Monjalon ; De Lara
> Guarch, Pablo ; Ray Kinsella
>
> Subject: [PATCH v3 06/10] dr
RTE IPv4 header definition combines the `version' and `ihl' fields
into a single structure member.
This patch introduces dedicated structure members for both `version'
and `ihl' IPv4 fields. Separated header fields definitions allow to
create simplified code to match on the IHL value in a flow rul
On 10/4/2021 1:01 PM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>> On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote:
>>> From: Pavan Nikhilesh
>>>
>>> Due to Lin
>On 10/4/2021 1:01 PM, Pavan Nikhilesh Bhagavatula wrote:
>>> On 10/4/2021 12:34 PM, Pavan Nikhilesh Bhagavatula wrote:
> On 10/4/2021 11:02 AM, Pavan Nikhilesh Bhagavatula wrote:
>>> On 10/4/2021 6:56 AM, pbhagavat...@marvell.com wrote:
From: Pavan Nikhilesh
Due
The way we're building DPDK in CI, with -Dmachine=default, has not been
updated when the option got replaced to preserve a backwards-complatible
build call to facilitate ABI verification between DPDK versions. Update
the call to use -Dplatform=generic, which is the most up to date way to
execute th
Hello Olivier,
[:snip:]
>
> nit: although it's obvious, we may want to add
> /**< IP version */ and
> /**< header length */ for these new fields, for
> consistency with the
> rest of the structure.
I added comments to v3.
Regards,
Gregory
On 9/24/2021 11:54 AM, Elad Nachman wrote:
> Fix lack of multiple KNI requests handling support by introducing a
> request in progress flag which will fail additional requests with
> EAGAIN return code if the original request has not been processed
> by user-space.
>
> Bugzilla ID: 809
Hi Eric,
Hi,
EAGAIN is propogated back to the kernel and to the caller.
We cannot retry from the kni kernel module since we hold the rtnl lock.
FYI,
Elad
בתאריך יום ב׳, 4 באוק׳ 2021, 16:05, מאת Ferruh Yigit <
ferruh.yi...@intel.com>:
> On 9/24/2021 11:54 AM, Elad Nachman wrote:
> > Fix lack of multip
The way we're building DPDK in CI, with -Dmachine=default, has not been
updated when the option got replaced to preserve a backwards-complatible
build call to facilitate ABI verification between DPDK versions. Update
the call to use -Dplatform=generic, which is the most up to date way to
execute th
From: Pavan Nikhilesh
Add reassembly perf autotest for both ipv4 and ipv6 reassembly.
Each test is performed with vairable number of fragments per flow,
either ordered or unorderd fragments and interleaved flows.
Signed-off-by: Pavan Nikhilesh
---
v2 Changes
- Rebase to master, reduce memory
On Thu, Sep 30, 2021 at 10:45 AM David Marchand
wrote:
> On Wed, Sep 29, 2021 at 9:38 AM Xia, Chenbo wrote:
> > @David, could you help me understand what is the compile error in Fedora 31?
> > DPDK_compile_spdk failure is expected as the header name for SPDK is
> > changed,
> > I am not sure if
Hi Slava,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Friday, October 1, 2021 10:52 PM
> Subject: [PATCH 1/3] ethdev: update modify field flow action
>
> The generic modify field flow action introduced in [1] has some issues related
> to the immediate source operand:
>
> - im
On 10/4/21 2:39 PM, Ivan Malov wrote:
> On 04/10/2021 09:56, Ori Kam wrote:
>>> On 04/10/2021 00:04, Ori Kam wrote:
I understand that you are only talking about enabling the action,
meaning to let the PMD know that at some point there will be a rule
that will use the mark action for
Currently majority of 'fast' ethdev ops take pointers to internal
queue data structures as an input parameter.
While eth_rx_queue_count() takes a pointer to rte_eth_dev and queue
index.
For future work to hide rte_eth_devices[] and friends it would be
plausible to unify parameters list of all 'fast
v4 changes:
- Fix secondary process attach (Pavan)
- Fix build failure (Ferruh)
- Update lib/ethdev/verion.map (Ferruh)
Note that moving newly added symbols from EXPERIMENTAL to DPDK_22
section makes checkpatch.sh to complain.
v3 changes:
- Changes in public struct naming (Jerin/Haiyue)
Rework 'fast' burst functions to use rte_eth_fp_ops[].
While it is an API/ABI breakage, this change is intended to be
transparent for both users (no changes in user app is required) and
PMD developers (no changes in PMD is required).
One extra thing to note - RX/TX callback invocation will cause ex
Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related
data into private header (ethdev_driver.h).
Few minor changes to keep DPDK building after that.
Signed-off-by: Konstantin Ananyev
---
doc/guides/rel_notes/release_21_11.rst| 6 +
drivers/common/octeontx2/otx2_sec_ide
Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet
addresses assigned to given port.
Change testpmd to use this new function and avoid referencing directly
rte_eth_devices[].
Signed-off-by: Konstantin Ananyev
---
app/test-pmd/config.c | 23 +++---
rte_eth_rx_descriptor_status() should be used as a replacement.
Signed-off-by: Andrew Rybchenko
Reviewed-by: Ferruh Yigit
Acked-by: Konstantin Ananyev
---
doc/guides/nics/features.rst| 6 +-
doc/guides/rel_notes/deprecation.rst| 5 -
doc/guides/rel_notes/release_21_11
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Monday, October 4, 2021 4:48 PM
> To: Harman Kalra
> Cc: dev@dpdk.org; Ray Kinsella ; David Marchand
>
> Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v1 2/7] eal/interrupts: implement
> get set APIs
>
> 2021-10-04 10:37 (UTC+), Harm
Hi Dmitry,
Please find my comments inline.
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Sunday, October 3, 2021 11:46 PM
> To: Harman Kalra
> Cc: dev@dpdk.org; Anatoly Burakov
> Subject: [EXT] Re: [dpdk-dev] [PATCH v1 6/7] eal/interrupts: make interrupt
> handle structure opaque
On 10/4/2021 2:09 PM, Elad Nachman wrote:
> Hi,
>
> EAGAIN is propogated back to the kernel and to the caller.
>
So will the user get an error, or it will be handled by the kernel and retried?
> We cannot retry from the kni kernel module since we hold the rtnl lock.
>
Why not? We are already
Adding Sahithi.
I believe adding the -EAGAIN method puts the responsibility on the
application/caller. If we take the change MAC address as an example. Most
application code just does this kind of check:
ret = ioctl(sockfd, SIOCSIFHWADDR, &ifr);
if (ret < 0) {
P
At queue configure stage always allocate space for maximum possible
number (RTE_MAX_QUEUES_PER_PORT) of queue pointers.
That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer
pointer to internal queue data without extra checking of current number
of configured queues.
That would help
From: Pavan Nikhilesh
Add reassembly perf autotest for both ipv4 and ipv6 reassembly.
Each test is performed with variable number of fragments per flow,
either ordered or unordered fragments and interleaved flows.
Signed-off-by: Pavan Nikhilesh
---
v3 Changes:
- Fix checkpatch issues.
v2 Cha
1. Userspace will get an error
2. Waiting with rtnl locked causes a deadlock; waiting with rtnl unlocked
for interface down command causes a crash because of a race condition in
the device delete/unregister list in the kernel.
FYI,
Elad.
בתאריך יום ב׳, 4 באוק׳ 2021, 17:13, מאת Ferruh Yigit <
fe
This series is mainly adding support for RSS to Virtio PMD
driver. The two last patches are fixing an issue in testpmd
that could cause out of bounds access, and fix
an issue spotted in the mlx5 driver while looking for
inspiration.
The first motivation for this series is to eventually
support RSS
Provide the capability to update the hash key, hash types
and RETA table on the fly (without needing to stop/start
the device). However, the key length and the number of RETA
entries are fixed to 40B and 128 entries respectively. This
is done in order to simplify the design, but may be
revisited la
port_rss_hash_key_update() initializes rss_conf with the
RSS key configuration provided by the user, but it calls
rte_eth_dev_rss_hash_conf_get() before calling
rte_eth_dev_rss_hash_update(), which overrides the parsed
RSS config.
While the RSS key value is set again after, this is not
the case o
This patch fixes the display of the RSS hash types
configured in the port, which displayed "all" even
if only a single type was configured
Fixes: 3c90743dd3b9 ("app/testpmd: support more types for flow RSS")
Cc: sta...@dpdk.org
Signed-off-by: Maxime Coquelin
Acked-by: Xiaoyun Li
Reviewed-by: Ch
This patch fixes RETA updating for entries above 64.
Without ithat, these entries are never updated as
calculated mask value will always be 0.
Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update")
Cc: sta...@dpdk.org
Cc: nelio.laranje...@6wind.com
Signed-off-by: Maxime Coquelin
Acked-by: V
This patch adds missing IPv6-Ex and GTPU flow types to port
info command. It also add the same definitions to
str2flowtype(), used to configure flow director.
Signed-off-by: Maxime Coquelin
---
app/test-pmd/cmdline.c | 4
app/test-pmd/config.c | 4
2 files changed, 8 insertions(+)
di
Copy public function pointers (rx_pkt_burst(), etc.) and related
pointers to internal data from rte_eth_dev structure into a
separate flat array. That array will remain in a public header.
The intention here is to make rte_eth_dev and related structures internal.
That should allow future possible c
On 2021-10-04 12:23, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Morrissey, Sean
>> Sent: Monday, October 4, 2021 11:11 AM
>> To: Burakov, Anatoly ; Jerin Jacob
>> ; Sunil Kumar Kori ; mattias.ronnblom
>> ; Van Haaren, Harry
>> ; Harman Kalra ;
>> Richardson, Bruce ; Ananyev, K
On 10/4/2021 3:25 PM, Elad Nachman wrote:
Can you please try to not top post, it will make impossible to follow this
discussion later from the mail archives.
> 1. Userspace will get an error
So there is nothing special with returning '-EAGAIN', user will only observe an
error.
Wasn't initial int
On 10/4/2021 12:18 PM, Nicolau, Radu wrote:
On 10/4/2021 3:15 AM, Wu, Jingjing wrote:
-Original Message-
From: Nicolau, Radu
Sent: Friday, October 1, 2021 5:52 PM
To: Wu, Jingjing ; Xing, Beilei
Cc: dev@dpdk.org; Doherty, Declan ; Sinha,
Abhijit
; Zhang, Qi Z ;
Richardson, Bruc
בתאריך יום ב׳, 4 באוק׳ 2021, 17:51, מאת Ferruh Yigit <
ferruh.yi...@intel.com>:
> On 10/4/2021 3:25 PM, Elad Nachman wrote:
>
> Can you please try to not top post, it will make impossible to follow this
> discussion later from the mail archives.
>
> > 1. Userspace will get an error
>
> So there i
On Mon, Oct 04, 2021 at 10:10:54AM +, Sean Morrissey wrote:
> This script can be used for removing headers flagged for removal by the
> include-what-you-use (IWYU) tool. The script has the ability to remove
> headers from specified sub-directories or dpdk as a whole.
>
Since it also is importi
On 10/4/2021 3:14 PM, Eric Christian wrote:
> Adding Sahithi.
>
> I believe adding the -EAGAIN method puts the responsibility on the
> application/caller. If we take the change MAC address as an example. Most
> application code just does this kind of check:
>
> ret = ioctl(sockfd, SIOCS
Hi Ivan,
> -Original Message-
> From: Ivan Malov
> Sent: Monday, October 4, 2021 2:06 PM
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API
>
> Hi Ori,
>
> On 04/10/2021 08:45, Ori Kam wrote:
> > Hi Ivan,
> >
> >> -Original Message-
> >>
On Mon, 4 Oct 2021 01:41:08 +0530
wrote:
> From: Pavan Nikhilesh
>
> Increase the number of routes from 8 to 16 that are statically added for
> lpm and em mode as most of the SoCs support more than 8 interfaces.
> The number of routes added is equal to the number of ethernet devices
> ports ena
On Fri, Sep 17, 2021 at 10:08 AM wrote:
>
> From: Satheesh Paul
>
> Upon MCAM allocation failure, free counters only if counters
> were allocated earlier for the flow rule.
>
> Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
>
> Signed-off-by: Satheesh Paul
Acked-by: Jerin Jacob
Appli
On Mon, 4 Oct 2021 10:10:53 +
Sean Morrissey wrote:
> This patchset introduces the include-what-you-use script which removes
> unused header includes. IWYU GitHub:
>
> https://github.com/include-what-you-use/include-what-you-use
>
> Along with the script there are some patches which make a
On Mon, 4 Oct 2021 15:13:22 +0300
Gregory Etelson wrote:
> diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
> index 951606f248..4f64be5357 100644
> --- a/app/test/test_flow_classify.c
> +++ b/app/test/test_flow_classify.c
> @@ -95,7 +95,7 @@ static struct rte_acl_field_d
On 10/4/2021 3:58 PM, Elad Nachman wrote:
> בתאריך יום ב׳, 4 באוק׳ 2021, 17:51, מאת Ferruh Yigit <
> ferruh.yi...@intel.com>:
>
>> On 10/4/2021 3:25 PM, Elad Nachman wrote:
>>
>> Can you please try to not top post, it will make impossible to follow this
>> discussion later from the mail archives.
1 - 100 of 167 matches
Mail list logo
