Re: [dpdk-dev] [PATCH] mbuf: remove ethdev deprecation note for flag name

2021-10-01 Thread Olivier Matz
Hi Aman, On Thu, Sep 30, 2021 at 09:50:15PM +0530, Aman Singh wrote: > Proposed name change of offload flag PKT_RX_EIP_CKSUM_BAD > to PKT_RX_OUTER_IP_CKSUM_BAD has already been done in the > code as per the deprecation note. > > Signed-off-by: Aman Singh > Acked-by: Ferruh Yigit Almost the sam

Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing

2021-10-01 Thread Dmitry Kozlyuk
2021-09-30 15:07 (UTC-0700), Menon, Ranjit: > [...] > > > Condition="'$(Configuration)|$(Platform)'=='Debug|x64'"> > > > > - false > > + true > > true > > - > Condition="'%(ClCompile.ScanConfigurationData)' == > > ''">trace.h > > + > Condition="'%(ClCompil

Re: [dpdk-dev] [PATCH] app/testpmd: support unequal number of RXQ and TXQ

2021-10-01 Thread Nipun Gupta
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, September 30, 2021 7:16 PM > To: Nipun Gupta ; dev@dpdk.org > Cc: xiaoyun...@intel.com; or...@nvidia.com; tho...@monjalon.net; Hemant > Agrawal ; Jun Yang > Subject: Re: [PATCH] app/testpmd: support unequal number of RXQ and TX

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread David Marchand
Hello William, On Fri, Oct 1, 2021 at 12:17 AM William Tu wrote: > > On Mon, Sep 20, 2021 at 1:11 PM Narcisa Ana Maria Vasile > wrote: > > > > On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > > > Currently there are some public headers that include 'sys/queue.h', which > > > is not

Re: [dpdk-dev] [PATCH v2] mempool/stack: build on Windows

2021-10-01 Thread Dmitry Kozlyuk
2021-09-30 17:50 (UTC-0700), Jie Zhou: > enable build mempool/stack on Windows Nit: in commit body, we use correct capitalization, punctuation, and spelling. > > V2 change: > - enable build lib stack on Windows which mempool/stack depends on > > > Signed-off-by: Jie Zhou Acked-by: Dmitry

Re: [dpdk-dev] [PATCH v3 5/5] app/testpmd: add missing flow types in port info

2021-10-01 Thread Maxime Coquelin
Hi Xiaoyun, On 9/30/21 03:05, Li, Xiaoyun wrote: Hi -Original Message- From: Maxime Coquelin Sent: Wednesday, September 29, 2021 17:17 To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; Yigit, Ferruh ; michae...@nvidia.com; v

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-10-01 Thread Thomas Monjalon
01/10/2021 08:47, Andrew Rybchenko: > On 9/30/21 10:30 PM, Ivan Malov wrote: > > Hi Thomas, > > > > On 30/09/2021 19:18, Thomas Monjalon wrote: > >> 23/09/2021 13:20, Ivan Malov: > >>> In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace > >>> intending to add new flags, RSS_HASH and

[dpdk-dev] [PATCH v5] net/af_packet: reinsert the stripped vlan tag

2021-10-01 Thread Tudor Cornea
The af_packet pmd driver binds to a raw socket and allows sending and receiving of packets through the kernel. Since commit [1], the kernel strips the vlan tags early in __netif_receive_skb_core(), so we receive untagged packets while running with the af_packet pmd. Luckily for us, the skb vlan-r

Re: [dpdk-dev] [PATCH v4] net/af_packet: reinsert the stripped vlan tag

2021-10-01 Thread Tudor Cornea
Hi Ferruh, Also driver was already working with VLAN, the change is VLAN is not > force stripped anymore. Agreed. It makes more sense to inform the users that the default behavior of the PMD has changed w.r.t VLAN stripping. I have updated the patch On Thu, 30 Sept 2021 at 11:14, Ferruh Yigi

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-10-01 Thread Andrew Rybchenko
On 10/1/21 11:11 AM, Thomas Monjalon wrote: > 01/10/2021 08:47, Andrew Rybchenko: >> On 9/30/21 10:30 PM, Ivan Malov wrote: >>> Hi Thomas, >>> >>> On 30/09/2021 19:18, Thomas Monjalon wrote: 23/09/2021 13:20, Ivan Malov: > In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace >

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-10-01 Thread Ivan Malov
Hi Thomas, On 01/10/2021 11:11, Thomas Monjalon wrote: 01/10/2021 08:47, Andrew Rybchenko: On 9/30/21 10:30 PM, Ivan Malov wrote: Hi Thomas, On 30/09/2021 19:18, Thomas Monjalon wrote: 23/09/2021 13:20, Ivan Malov: In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace intending

Re: [dpdk-dev] [PATCH v8 5/5] ethdev: merge driver ops to get all xstats names and by ID

2021-10-01 Thread Andrew Rybchenko
On 9/30/21 7:47 PM, Ferruh Yigit wrote: > On 9/30/2021 5:05 PM, Andrew Rybchenko wrote: >> All xstats names may be retrieved passing NULL ids. >> >> If a driver does not support getting names by IDs, the callback should >> return -ENOTSUP on attempt to use it. If so, the request is handled >> on et

Re: [dpdk-dev] [PATCH v8 3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-10-01 Thread Andrew Rybchenko
On 9/30/21 7:33 PM, Ferruh Yigit wrote: > On 9/30/2021 5:05 PM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Update xstats by IDs callbacks documentation in accordance with >> ethdev usage of these callbacks. Document valid combinations of >> input arguments to make driver implementation s

[dpdk-dev] [PATCH v9 1/5] ethdev: fix docs of functions getting xstats by IDs

2021-10-01 Thread Andrew Rybchenko
From: Ivan Ilchenko Document valid combinations of input arguments in accordance with current implementation in ethdev. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by:

[dpdk-dev] [PATCH v9 2/5] ethdev: do not use get xstats names by IDs to obtain count

2021-10-01 Thread Andrew Rybchenko
Relax requirements on get xstats names by IDs. After the patch corresponding the driver operation is called with non-NULL ids and xstats_names parameters only. Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit --- lib/ethdev/rte_ethdev.c | 6 -- 1 file changed, 6 deletions(-) diff --g

[dpdk-dev] [PATCH v9 3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-10-01 Thread Andrew Rybchenko
From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage of these callbacks. Document valid combinations of input arguments to make driver implementation simpler. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan

[dpdk-dev] [PATCH v9 4/5] ethdev: improve xstats names by IDs get prototype

2021-10-01 Thread Andrew Rybchenko
Adjust parameters order to eth_xstats_get_by_id_t prototype. Make ids the second parameter similar to eth_xstats_get_by_id_t. Signed-off-by: Andrew Rybchenko --- drivers/net/axgbe/axgbe_ethdev.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.h | 3 ++- drivers/net/cnxk/cnxk_stats.c | 3 ++-

[dpdk-dev] [PATCH v9 5/5] ethdev: merge driver ops to get all xstats names and by ID

2021-10-01 Thread Andrew Rybchenko
All xstats names may be retrieved passing NULL ids. If a driver does not support getting names by IDs, the callback should return -ENOTSUP on attempt to use it. If so, the request is handled on ethdev layer by getting all names and filtering out requested only. Signed-off-by: Andrew Rybchenko --

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-10-01 Thread Thomas Monjalon
01/10/2021 10:54, Andrew Rybchenko: > >> Thomas, if I'm not mistaken, net/mlx5 dv_xmeta_en driver option > >> is vendor-specific way to address the same problem. > > > > Not exactly, it is configuring the capabilities: > > +--+---+---+-+-+ > > | Mode

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread Dmitry Kozlyuk
2021-10-01 09:27 (UTC+0200), David Marchand: > [...] > I just have a concern that headers get broken again if we have no check. > Could buildtools/chkincs do the job (if we make this check work on Windows)? It's a valid caoncern and yes, chkincs would be a solution. I discovered that the real iss

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-10-01 Thread Andrew Rybchenko
On 10/1/21 12:32 PM, Thomas Monjalon wrote: > 01/10/2021 10:54, Andrew Rybchenko: Thomas, if I'm not mistaken, net/mlx5 dv_xmeta_en driver option is vendor-specific way to address the same problem. >>> >>> Not exactly, it is configuring the capabilities: >>> +--+---+

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-10-01 Thread Thomas Monjalon
01/10/2021 10:55, Ivan Malov: > On 01/10/2021 11:11, Thomas Monjalon wrote: > > 01/10/2021 08:47, Andrew Rybchenko: > >> On 9/30/21 10:30 PM, Ivan Malov wrote: > >>> On 30/09/2021 19:18, Thomas Monjalon wrote: > 23/09/2021 13:20, Ivan Malov: > > In 2019, commit [1] announced changes in DEV

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread Dmitry Kozlyuk
2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > 2021-10-01 09:27 (UTC+0200), David Marchand: > > [...] > > I just have a concern that headers get broken again if we have no check. > > Could buildtools/chkincs do the job (if we make this check work on > > Windows)? > > It's a valid caoncern and y

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread David Marchand
On Fri, Oct 1, 2021 at 11:51 AM Dmitry Kozlyuk wrote: > > 2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > > 2021-10-01 09:27 (UTC+0200), David Marchand: > > > [...] > > > I just have a concern that headers get broken again if we have no check. > > > Could buildtools/chkincs do the job (if we make t

Re: [dpdk-dev] [dpdk-stable] [PATCH v9 3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-10-01 Thread Ferruh Yigit
On 10/1/2021 10:07 AM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Update xstats by IDs callbacks documentation in accordance with > ethdev usage of these callbacks. Document valid combinations of > input arguments to make driver implementation simpler. > > Fixes: 79c913a42f0 ("ethdev: ret

Re: [dpdk-dev] [PATCH v9 4/5] ethdev: improve xstats names by IDs get prototype

2021-10-01 Thread Ferruh Yigit
On 10/1/2021 10:07 AM, Andrew Rybchenko wrote: > Adjust parameters order to eth_xstats_get_by_id_t prototype. > Make ids the second parameter similar to eth_xstats_get_by_id_t. > > Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH 0/9] fixes and enhancements to Truflow

2021-10-01 Thread Venkat Duvvuru
This patch set adds enhancements and fixes to Truflow feature. Enhancements include: * Scaling numbers on Thor * Inner IP header support for GRE tunnel flows * Enable wildcard match for ingress flows * Add clear on read for flow stats on Thor * Add nat support for dest IP and port combination Far

[dpdk-dev] [PATCH 1/9] net/bnxt: add nat support for dest IP and port combination

2021-10-01 Thread Venkat Duvvuru
From: Kishore Padmanabha * Added support for nat action for the destination ip and port combination for the thor platform. This is not supported for whitney platform. * Consolidated the encapsulation and nat entries for scaling flows with nat actions. Signed-off-by: Kishore Padmanabha Sig

[dpdk-dev] [PATCH 2/9] net/bnxt: support multi root capability flag

2021-10-01 Thread Venkat Duvvuru
From: Kishore Padmanabha Update driver to read the multi root capability and ignore pci address check while creating ulp session when multi root capability is enabled in the hardware. DPDK HSI version updated from 1.10.1.70 to 1.10.2.54. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat D

[dpdk-dev] [PATCH 4/9] net/bnxt: add clear on read stats support for Thor

2021-10-01 Thread Venkat Duvvuru
From: Farah Smith Currently, the flow stats are not cleared after they are read from the fw. This patch adds support for clear on read. Since clear on read support is added for flow stats in Thor, the flow accumulation is enabled on Thor as well. Signed-off-by: Farah Smith Signed-off-by: Kishor

[dpdk-dev] [PATCH 5/9] net/bnxt: add feature capability option for socket direct

2021-10-01 Thread Venkat Duvvuru
From: Kishore Padmanabha Added support for socket direct feature capability so applications can enable or disable this feature. This patch contains the template changes. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Michael Baucom Reviewed-by: Randy Schacher --

[dpdk-dev] [PATCH 6/9] net/bnxt: enable wildcard match for ingress flows

2021-10-01 Thread Venkat Duvvuru
From: Kishore Padmanabha Enabled wildcard match support for ipv4 ingress flows. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Michael Baucom Reviewed-by: Randy Schacher --- .../generic_templates/ulp_template_db_enum.h | 4 +- .../ulp_template_db_thor_class.

[dpdk-dev] [PATCH 3/9] net/bnxt: fix the out of boundary issue in hash list

2021-10-01 Thread Venkat Duvvuru
From: Kishore Padmanabha The number of hash bucket list calculation is fixed and added check to limit the out of boundary condition Fixes: 0001cc58d362 ("net/bnxt: support generic hash table") Cc: sta...@dpdk.org Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Mic

[dpdk-dev] [PATCH 7/9] net/bnxt: support inner IP header for GRE tunnel flows

2021-10-01 Thread Venkat Duvvuru
From: Kishore Padmanabha This change allows adding ip header matches for GRE flows that does not specify outer ip header in the flow match pattern. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Michael Baucom Reviewed-by: Ajit Khaparde Reviewed-by: Randy Schach

[dpdk-dev] [PATCH v7 0/8] new features for ipsec and security libraries

2021-10-01 Thread Radu Nicolau
Add support for: TSO, NAT-T/UDP encapsulation, ESN AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry mbuf offload flags Initial SQN value Radu Nicolau (8): security: add ESN field to ipsec_xform ipsec: add support for AEAD algorithms security: add UDP params for IPsec NAT-T ipsec: add s

[dpdk-dev] [PATCH v7 1/8] security: add ESN field to ipsec_xform

2021-10-01 Thread Radu Nicolau
Update ipsec_xform definition to include ESN field. This allows the application to control the ESN starting value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang Acked-by: Anoob Joseph --- lib/s

[dpdk-dev] [PATCH v7 2/8] ipsec: add support for AEAD algorithms

2021-10-01 Thread Radu Nicolau
Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang Acked-by: Konstantin Ananyev --- lib/ipsec/crypto.h | 137 ++

[dpdk-dev] [PATCH v7 3/8] security: add UDP params for IPsec NAT-T

2021-10-01 Thread Radu Nicolau
Add support for specifying UDP port params for UDP encapsulation option. RFC3948 section-2.1 does not enforce using specific the UDP ports for UDP-Encapsulated ESP Header Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley

[dpdk-dev] [PATCH v7 4/8] ipsec: add support for NAT-T

2021-10-01 Thread Radu Nicolau
Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang --- lib/ipsec/esp_outb.c | 9 + lib/ipsec/rte_ipsec_sa.h | 9

[dpdk-dev] [PATCH 9/9] net/bnxt: increase scaling numbers on Thor

2021-10-01 Thread Venkat Duvvuru
From: Shahaji Bhosle * Updated defines and data types to allow 256 VFRs. * Increased the encap record cache to support 256 to 4K entries. So vxlan connections can be scaled to 4k entries. Signed-off-by: Shahaji Bhosle Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-

[dpdk-dev] [PATCH v7 5/8] mbuf: add IPsec ESP tunnel type

2021-10-01 Thread Radu Nicolau
Add ESP tunnel type to the tunnel types list that can be specified for TSO or checksum on the inner part of tunnel packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang Acked-by: Akhil Goyal Ac

[dpdk-dev] [PATCH 8/9] net/bnxt: get Truflow version

2021-10-01 Thread Venkat Duvvuru
From: Jay Ding Implement TF_GET_VERSION that returns Truflow version numbers and CFA resources capabilities. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by: Farah Smith Reviewed-by: Randy Schacher Reviewed-by: Peter Spreadborough --- drivers/net/bnxt/hsi_struct_def_dpdk.

[dpdk-dev] [PATCH v7 6/8] ipsec: add transmit segmentation offload support

2021-10-01 Thread Radu Nicolau
Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off

[dpdk-dev] [PATCH v7 7/8] ipsec: add support for SA telemetry

2021-10-01 Thread Radu Nicolau
Add telemetry support for ipsec SAs Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang --- lib/ipsec/esp_inb.c | 18 ++- lib/ipsec/esp_outb.c| 12 +- lib/ipsec/ipsec_telemetry.c | 2

[dpdk-dev] [PATCH v7 8/8] ipsec: add support for initial SQN value

2021-10-01 Thread Radu Nicolau
Update IPsec library to support initial SQN value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang --- lib/ipsec/sa.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(

[dpdk-dev] [PATCH v4 0/6] iavf: add iAVF IPsec inline crypto support

2021-10-01 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Radu Nicolau (6): common/iavf: add iAVF IPsec inline crypto support net/iavf: rework tx path net/iav

[dpdk-dev] [PATCH v4 1/6] common/iavf: add iAVF IPsec inline crypto support

2021-10-01 Thread Radu Nicolau
Add support for inline crypto for IPsec. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/common/iavf/iavf_type.h | 215 +++- drivers/common/iavf/virtchnl.h | 17 +- drivers/common/iavf/virtchnl_inline_ipsec.h | 55

[dpdk-dev] [PATCH v4 2/6] net/iavf: rework tx path

2021-10-01 Thread Radu Nicolau
Rework the TX path and TX descriptor usage in order to allow for better use of oflload flags and to facilitate enabling of inline crypto offload feature. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_rxtx.c | 536 ++

[dpdk-dev] [PATCH v4 3/6] net/iavf: add support for asynchronous virt channel messages

2021-10-01 Thread Radu Nicolau
Add support for asynchronous virtual channel messages, specifically for inline IPsec messages. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf.h | 16 drivers/net/iavf/iavf_vchnl.c | 137 +-

[dpdk-dev] [PATCH v4 4/6] net/iavf: add iAVF IPsec inline crypto support

2021-10-01 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Implement support for rte_security packet metadata Add definition for IPsec descriptors, extend support fo

[dpdk-dev] [PATCH v4 5/6] net/iavf: add xstats support for inline IPsec crypto

2021-10-01 Thread Radu Nicolau
Add per queue counters for maintaining statistics for inline IPsec crypto offload, which can be retrieved through the rte_security_session_stats_get() with more detailed errors through the rte_ethdev xstats. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf.h

[dpdk-dev] [PATCH v4 6/6] net/iavf: add watchdog for VFLR

2021-10-01 Thread Radu Nicolau
Add watchdog to iAVF PMD which support monitoring the VFLR register. If the device is not already in reset then if a VF reset in progress is detected then notfiy user through callback and set into reset state. If the device is already in reset then poll for completion of reset. Signed-off-by: Decl

[dpdk-dev] [PATCH v3 0/8] IPsec Sec GW new features

2021-10-01 Thread Radu Nicolau
Update the IPsec sample app with new features and updates: - egress TSO support - telemetry support - add reset callback - stats screen configurable as a command line parameter - UDP encapsulation support for inline crypto - ESN with configurable start value Depends on series 18837 ('new features

[dpdk-dev] [PATCH v3 1/8] examples/ipsec-secgw: add stats interval argument

2021-10-01 Thread Radu Nicolau
Add -t for stats screen update interval, disabled by default. Signed-off-by: Radu Nicolau Acked-by: Hemant Agrawal Acked-by: Anoob Joseph --- doc/guides/sample_app_ug/ipsec_secgw.rst | 5 examples/ipsec-secgw/ipsec-secgw.c | 29 examples/ipsec-secgw/ipsec-s

[dpdk-dev] [PATCH v3 2/8] examples/ipsec-secgw: update create inline session

2021-10-01 Thread Radu Nicolau
Rework create inline session function as to update the session configuration parameters before create session is called. Also updated the rss key array size to prevent buffers overflows with PMDs that copy more than 40 bytes. Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.c | 54

[dpdk-dev] [PATCH v3 3/8] examples/ipsec-secgw: add support for inline crypto UDP encapsulation

2021-10-01 Thread Radu Nicolau
Enable UDP encapsulation for both transport and tunnel modes for the inline crypto offload path. Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.c | 33 + examples/ipsec-secgw/ipsec.h | 7 ++- examples/ipsec-secgw/sa.c| 9 + 3 files ch

[dpdk-dev] [PATCH v3 4/8] examples/ipsec-secgw: add support for TSO

2021-10-01 Thread Radu Nicolau
Add support to allow user to specific MSS for TSO offload on a per SA basis. MSS configuration in the context of IPsec is only supported for outbound SA's in the context of an inline IPsec Crypto offload. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ips

[dpdk-dev] [PATCH v3 5/8] examples/ipsec-secgw: add support for telemetry

2021-10-01 Thread Radu Nicolau
Add telemetry support to the IPsec GW sample app Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 11 + examples/ipsec-secgw/ipsec-secgw.c | 357 ++- examples/ipsec-secgw/ipsec-secgw.h | 31 ++ examples/ip

[dpdk-dev] [PATCH v3 6/8] examples/ipsec-secgw: add support for defining initial sequence number value

2021-10-01 Thread Radu Nicolau
Add esn field to SA definition block to allow initial ESN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- doc/guides/sample_app_ug/ipsec_secgw.rst | 10 ++ examples/ipsec-secgw/ipsec.c | 6 ++ examples/ipsec-secgw/ipsec.h | 1 + examples

[dpdk-dev] [PATCH v3 7/8] examples/ipsec-secgw: add ethdev reset callback

2021-10-01 Thread Radu Nicolau
Add event handler for ethdev reset callback Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c index 4ee5568

[dpdk-dev] [PATCH v3 8/8] examples/ipsec-secgw: add support for additional algorithms

2021-10-01 Thread Radu Nicolau
Add support for AES-GMAC, AES_CTR, AES_XCBC_MAC, AES_CCM, CHACHA20_POLY1305 Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.h | 3 +- examples/ipsec-secgw/sa.c| 133 --- 2 files changed, 126 insertions(+), 10 deletio

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread Bruce Richardson
On Fri, Oct 01, 2021 at 11:55:47AM +0200, David Marchand wrote: > On Fri, Oct 1, 2021 at 11:51 AM Dmitry Kozlyuk > wrote: > > > > 2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > > > 2021-10-01 09:27 (UTC+0200), David Marchand: > > > > [...] > > > > I just have a concern that headers get broken aga

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-10-01 Thread Andrew Rybchenko
On 10/1/21 12:48 PM, Thomas Monjalon wrote: > 01/10/2021 10:55, Ivan Malov: >> On 01/10/2021 11:11, Thomas Monjalon wrote: >>> 01/10/2021 08:47, Andrew Rybchenko: On 9/30/21 10:30 PM, Ivan Malov wrote: > On 30/09/2021 19:18, Thomas Monjalon wrote: >> 23/09/2021 13:20, Ivan Malov: >

Re: [dpdk-dev] [dpdk-stable] [PATCH v9 3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-10-01 Thread Andrew Rybchenko
On 10/1/21 12:42 PM, Ferruh Yigit wrote: > On 10/1/2021 10:07 AM, Andrew Rybchenko wrote: >> From: Ivan Ilchenko >> >> Update xstats by IDs callbacks documentation in accordance with >> ethdev usage of these callbacks. Document valid combinations of >> input arguments to make driver implementation

Re: [dpdk-dev] [EXT] Re: [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-10-01 Thread Apeksha Gupta
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, September 23, 2021 3:40 PM > To: Apeksha Gupta ; > david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@intel.com > Cc: dev@dpdk.org; Sachin Saxena ; Hemant > Agrawal > Subject: [EXT] Re: [dpdk-dev] [PATCH v3

Re: [dpdk-dev] [EXT] Re: [PATCH v3 2/5] net/enetfec: add UIO support

2021-10-01 Thread Apeksha Gupta
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, September 23, 2021 3:43 PM > To: Apeksha Gupta ; > david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@intel.com > Cc: dev@dpdk.org; Sachin Saxena ; Hemant > Agrawal > Subject: [EXT] Re: [dpdk-dev] [PATCH v3

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread Thomas Monjalon
20/09/2021 22:11, Narcisa Ana Maria Vasile: > On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/BSD system library. > > (Not in POSIX.1, POSIX.1-2001, or POSIX

[dpdk-dev] [PATCH v4 0/5] improve telemetry support with in-memory mode

2021-10-01 Thread Bruce Richardson
This patchset cleans up telemetry support for "in-memory" mode, so that multiple independent processes can be run using that mode and still have telemetry support. It also removes problems of one process removing the socket of another - which was the original issue reported. The main changes in thi

[dpdk-dev] [PATCH v4 1/5] eal: limit telemetry to primary processes

2021-10-01 Thread Bruce Richardson
Telemetry interface should be exposed for primary processes only, since secondary processes will conflict on socket creation, and since all data in secondary process is generally available to primary. For example, all device stats for ethdevs, cryptodevs, etc. will all be common across processes.

[dpdk-dev] [PATCH v4 2/5] telemetry: fix deletion of active sockets

2021-10-01 Thread Bruce Richardson
When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process, as it starts up, removing the telemetry socket of another process, giving unexpected behaviour. This patch changes that behaviour to first check if the existing

[dpdk-dev] [PATCH v4 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-01 Thread Bruce Richardson
When DPDK is run using "in-memory" flag, multiple processes can be run using the same file-prefix and hence the same runtime directory. To avoid problems with conflicting telemetry unix socket paths, we can put the pid of the process into the socket name. As with the existing telemetry socket files

[dpdk-dev] [PATCH v4 4/5] usertools/dpdk-telemetry: connect to in-memory processes

2021-10-01 Thread Bruce Richardson
Allow connecting to an in-memory process via "-p " flag, which can be used to identify the in-memory process to which to connect. Signed-off-by: Bruce Richardson --- doc/guides/howto/telemetry.rst | 6 ++ usertools/dpdk-telemetry.py| 7 ++- 2 files changed, 12 insertions(+), 1 deleti

[dpdk-dev] [PATCH v4 5/5] usertools/dpdk-telemetry: provide info on available sockets

2021-10-01 Thread Bruce Richardson
When a user runs the dpdk-telemetry script and fails to connect because the socket path does not exist, run a scan for possible sockets that could be connected to and inform the user of the command needed to connect to those. For example, when running the script without any parameters, but there a

Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name

2021-10-01 Thread Andrew Rybchenko
Hello PMD maintainers, please, review the patch. It is especially important for net/mlx5 since changes there are not trivial. Thanks, Andrew. On 9/13/21 2:26 PM, Andrew Rybchenko wrote: > From: Viacheslav Galaktionov > > Getting a list of representors from a representor does not make sense. >

[dpdk-dev] [PATCH v4 0/5] drivers/net: add NXP ENETFEC driver

2021-10-01 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

[dpdk-dev] [PATCH v4 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-10-01 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- MAINTAINERS| 7 ++ doc/guides/nics/enetfec.rst

[dpdk-dev] [PATCH v4 2/5] net/enetfec: add UIO support

2021-10-01 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v4 3/5] net/enetfec: support queue configuration

2021-10-01 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 230 +-

[dpdk-dev] [PATCH v4 4/5] net/enetfec: add enqueue and dequeue support

2021-10-01 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v4 5/5] net/enetfec: add features

2021-10-01 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 ++ doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 17 - drivers/

Re: [dpdk-dev] [PATCH v1 3/3] test/crypto: add ZUC test cases for 256 bit key

2021-10-01 Thread De Lara Guarch, Pablo
Hi Vidya, > -Original Message- > From: dev On Behalf Of Vidya Sagar Velumuri > Sent: Wednesday, September 15, 2021 7:11 AM > To: adwiv...@marvell.com; ano...@marvell.com; ktejas...@marvell.com; > ndabilpu...@marvell.com; kirankum...@marvell.com; sk...@marvell.com; > skotesh...@marvell.com

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-10-01 Thread Thomas Monjalon
01/10/2021 12:15, Andrew Rybchenko: > On 10/1/21 12:48 PM, Thomas Monjalon wrote: > > 01/10/2021 10:55, Ivan Malov: > >> On 01/10/2021 11:11, Thomas Monjalon wrote: > >>> 01/10/2021 08:47, Andrew Rybchenko: > On 9/30/21 10:30 PM, Ivan Malov wrote: > > On 30/09/2021 19:18, Thomas Monjalon w

Re: [dpdk-dev] [EXT] [PATCH v7 3/8] security: add UDP params for IPsec NAT-T

2021-10-01 Thread Anoob Joseph
> Add support for specifying UDP port params for UDP encapsulation option. > RFC3948 section-2.1 does not enforce using specific the UDP ports for UDP- > Encapsulated ESP Header > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Dan

Re: [dpdk-dev] [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels

2021-10-01 Thread Srikanth K
Sure. I will add the comment in v2. Regards, Srikanth On Fri, Oct 1, 2021 at 4:49 AM Long Li wrote: > > Subject: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels > > > > [You don't often get email from srikant...@oneconvergence.com. Learn > > why this is important at http://aka.ms

Re: [dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-10-01 Thread Jerin Jacob
On Thu, Sep 30, 2021 at 10:57 PM Dharmik Thakkar wrote: > > Current mempool per core cache implementation is based on pointer > For most architectures, each pointer consumes 64b > Replace it with index-based implementation, where in each buffer > is addressed by (pool address + index) > It will re

Re: [dpdk-dev] [dpdk-stable] [PATCH] ring: fix comment for __rte_ring_move_cons_head()

2021-10-01 Thread Thomas Monjalon
> > Change "enqueue" to "dequeue" because the __rte_ring_move_cons_head() > > function is updating the consumer head for dequeue. > > > > Fixes: 0dfc98c507b1 ("ring: separate out head index manipulation") > > Cc: bruce.richard...@intel.com > > Cc: sta...@dpdk.org > > > > Signed-off-by: Cian Ferri

Re: [dpdk-dev] [PATCH] telemetry: detach pthreads

2021-10-01 Thread Thomas Monjalon
> >There are a number telemetry threads which are created and there is nothing > >that does pthread_join() to wait for them. > >Mark these threads as detached, so that the pthread library can cleanup state > >when the thread exits. > > > >Signed-off-by: Stephen Hemminger > >--- > > lib/telemetry/t

Re: [dpdk-dev] [PATCH 1/3] bitrate: change reg implementation to match API description

2021-10-01 Thread Thomas Monjalon
22/07/2021 22:24, Kevin Traynor: > On 22/07/2021 20:46, Thomas Monjalon wrote: > > 09/07/2021 17:19, Kevin Traynor: > >> rte_stats_bitrate_reg() API states it returns 'Zero on success'. > >> > >> However, the implementation directly returns the return of > >> rte_metrics_reg_names() which may be ze

[dpdk-dev] [PATCH v3 00/28] net/cnxk: support for inline ipsec

2021-10-01 Thread Nithin Dabilpuram
Support for inline ipsec in CN9K event mode and in Cn10K event mode and poll mode. Kommula Shiva Shankar (1): common/cnxk: add CQ enable support in NIX Tx path Nithin Dabilpuram (18): common/cnxk: support CPT parse header dump common/cnxk: allow reuse of SSO API for inline dev common/cnxk

[dpdk-dev] [PATCH v3 01/28] common/cnxk: support cn9k fast path security session

2021-10-01 Thread Nithin Dabilpuram
From: Srujana Challa Add security support to init cn9k fast path SA data for AES GCM and AES CBC + HMAC SHA1. Signed-off-by: Srujana Challa Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/cnxk_security.c | 211 drivers/common/cnxk/cnxk_security.h

[dpdk-dev] [PATCH v3 02/28] common/cnxk: support CPT parse header dump

2021-10-01 Thread Nithin Dabilpuram
Add helper API to dump CPT parse header. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_cpt.h | 2 ++ drivers/common/cnxk/roc_cpt_debug.c | 31 +++ drivers/common/cnxk/version.map | 1 + 3 files changed, 34 insertions(+) diff --git a/drivers

[dpdk-dev] [PATCH v3 03/28] common/cnxk: allow reuse of SSO API for inline dev

2021-10-01 Thread Nithin Dabilpuram
Rework interface of SSO internal functions to use for NIX inline dev's SSO LF's. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_sso.c | 52 -- drivers/common/cnxk/roc_sso_priv.h | 9 +++ 2 files changed, 42 insertions(+), 19 deletions(-

[dpdk-dev] [PATCH v3 04/28] common/cnxk: change NIX debug API and queue API interface

2021-10-01 Thread Nithin Dabilpuram
Change NIX debug API and queue API interface for use by internal NIX inline device initialization. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.c | 2 +- drivers/common/cnxk/roc_nix_debug.c | 118 +++- drivers/common/cnxk/roc_nix_priv.h

[dpdk-dev] [PATCH v3 05/28] common/cnxk: support NIX inline device IRQ

2021-10-01 Thread Nithin Dabilpuram
Add API to setup NIX inline device IRQ's. This registers IRQ's for errors in case of NIX, CPT LF, SSOW and get wor interrupt in case of SSO. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/c

[dpdk-dev] [PATCH v3 06/28] common/cnxk: support NIX inline device init and fini

2021-10-01 Thread Nithin Dabilpuram
Add support to init and fini inline device with NIX LF, SSO LF and SSOW LF for inline inbound IPSec in CN10K. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_api.h | 2 + drivers/common/cnxk/roc_cpt.c | 7 +- driv

[dpdk-dev] [PATCH v3 08/28] common/cnxk: disable CQ drop when inline inbound is enabled

2021-10-01 Thread Nithin Dabilpuram
Disable CQ drop when inline inbound is enabled. CQ drop is not supported for second pass IPsec decrypted packets. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_queue.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_q

[dpdk-dev] [PATCH v3 07/28] common/cnxk: support NIX inline inbound and outbound setup

2021-10-01 Thread Nithin Dabilpuram
Add API to support setting up NIX inline inbound and NIX inline outbound. In case of inbound, SA base is setup on NIX PFFUNC and in case of outbound, required number of CPT LF's are attached to NIX PFFUNC. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/cpt.h | 8 + drivers

[dpdk-dev] [PATCH v3 09/28] common/cnxk: dump CPT LF registers on error intr

2021-10-01 Thread Nithin Dabilpuram
Dump CPT LF registers on error interrupt for debugging purpose. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_cpt.c | 5 - drivers/common/cnxk/roc_cpt_debug.c | 32 ++-- drivers/common/cnxk/roc_cpt_priv.h | 1 + 3 files changed, 35 insertio

[dpdk-dev] [PATCH v3 10/28] common/cnxk: align CPT LF enable/disable sequence

2021-10-01 Thread Nithin Dabilpuram
For CPT LF IQ enable, set CPT_LF_CTL[ENA] before setting CPT_LF_INPROG[EENA] to true. For CPT LF IQ disable, align sequence to that of HRM. Also this patch aligns space for instructions in CPT LF to ROC_ALIGN to make complete memory cache aligned and has other minor fixes/additions. Signed-off-b

[dpdk-dev] [PATCH v3 11/28] common/cnxk: restore NIX sqb pool limit before destroy

2021-10-01 Thread Nithin Dabilpuram
Restore SQB AURA/POOL limit before destroying SQB to be able to drain all the buffers from the aura. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_queue.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_ni

  1   2   3   >