[dpdk-dev] [PATCH v6 2/4] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-30 Thread Andrew Rybchenko
From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage of these callbacks. Document valid combinations of input arguments to make driver implementation simpler. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan

[dpdk-dev] [PATCH v6 3/4] ethdev: improve xstats names by IDs get prototype

2021-09-30 Thread Andrew Rybchenko
Adjust parameters order to eth_xstats_get_by_id_t prototype. Make ids the second parameter similar to eth_xstats_get_by_id_t. Signed-off-by: Andrew Rybchenko --- drivers/net/axgbe/axgbe_ethdev.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.h | 3 ++- drivers/net/cnxk/cnxk_stats.c | 3 ++-

[dpdk-dev] [PATCH v6 4/4] ethdev: merge driver ops to get all xstats names and by ID

2021-09-30 Thread Andrew Rybchenko
All xstats names may be retrieved passing NULL ids. If a driver does not support getting names by IDs, it returns -ENOTSUP on attempt to use it. Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features.rst| 2 +- drivers/net/atlantic/atl_ethdev.c | 5 ++ drivers/net/axgb

[dpdk-dev] [PATCH 0/3] crypto/security session framework rework

2021-09-30 Thread Akhil Goyal
As discussed in last release deprecation notice, crypto and security session framework are reworked to reduce the need of two mempool objects and remove the requirement to expose the rte_security_session and rte_cryptodev_sym_session structures. Similar work will need to be done for asymmetric ses

[dpdk-dev] [PATCH 1/3] security: rework session framework

2021-09-30 Thread Akhil Goyal
As per current design, rte_security_session_create() unnecesarily use 2 mempool objects for a single session. And structure rte_security_session is not directly used by the application, it may cause ABI breakage if the structure is modified in future. To address these two issues, the API will now

[dpdk-dev] [PATCH 2/3] drivers/net: temporary disable ixgbe and txgbe

2021-09-30 Thread Akhil Goyal
The PMDs ixgbe and txgbe are currently making rte_security_session private data as constant, but they are getting filled inside the API. This was feasible as the session_private_data and rte_security_session pointers were separate. But now these two will be from same memory chunk. Hence it cannot u

[dpdk-dev] [PATCH 3/3] cryptodev: rework session framework

2021-09-30 Thread Akhil Goyal
As per current design, rte_cryptodev_sym_session_create() and rte_cryptodev_sym_session_init() use separate mempool objects for a single session. And structure rte_cryptodev_sym_session is not directly used by the application, it may cause ABI breakage if the structure is modified in future. To ad

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Andrew Rybchenko
Hi Ori, On 9/30/21 5:59 PM, Ori Kam wrote: > Hi Ivan, > Sorry for jumping in late. > > I have a concern that this patch breaks other PMDs. >>From the rst file " One should negotiate flag delivery beforehand" > since you only added this function for your PMD all other PMD will fail. > I see that y

Re: [dpdk-dev] [PATCH] net/af_xdp: do not attempt probe for secondary processes

2021-09-30 Thread Stephen Hemminger
On Thu, 30 Sep 2021 13:46:04 + Ciara Loftus wrote: > Since the AF_XDP PMD does not work for secondary processes as reported > in Bugzilla 805, check for the process type at the beginning of probe > and return ENOTSUP if the process type is secondary. > > Bugzilla ID: 805 > Fixes: f1debd77efa

Re: [dpdk-dev] [PATCH v2 4/5] kvargs: remove experimental function to compare string

2021-09-30 Thread David Marchand
On Thu, Sep 30, 2021 at 4:00 PM Olivier Matz wrote: > > On Wed, Sep 29, 2021 at 11:39:42PM +0200, Olivier Matz wrote: > > The function was designed to be used as a handler for > > rte_kvargs_process() to compare the value string in a kvlist. For > > readability, its usages in DPDK have been replac

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-30 Thread Ferruh Yigit
On 9/30/2021 3:01 PM, Andrew Rybchenko wrote: > On 9/30/21 3:08 PM, Ferruh Yigit wrote: >> On 9/29/2021 12:54 PM, Andrew Rybchenko wrote: >>> On 9/29/21 11:44 AM, Ferruh Yigit wrote: On 9/28/2021 5:53 PM, Andrew Rybchenko wrote: > On 9/28/21 7:50 PM, Ferruh Yigit wrote: >> On 9/28/2021

Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API

2021-09-30 Thread David Marchand
On Wed, Sep 15, 2021 at 9:33 AM Ferruh Yigit wrote: > > On 9/1/2021 2:48 PM, Kinsella, Ray wrote: > > > > > > On 01/09/2021 13:20, Jasvinder Singh wrote: > >> This API was introduced in 18.08, therefore removing > >> experimental tag to promote it to stable state. > >> > >> Signed-off-by: Jasvinde

Re: [dpdk-dev] [PATCH] net/cxgbe: avoid sending link params change from VF

2021-09-30 Thread Ferruh Yigit
On 9/27/2021 6:56 PM, Rahul Lakkireddy wrote: > From: Nikhil Vasoya > > VFs are not allowed to change physical link params when a port > module change is detected. The firmware already returns appropriate > permission error when VF tries to change physical link params. But, > make sure to avoid s

[dpdk-dev] [PATCH] net/mlx5: optimize the device spawn time with representors

2021-09-30 Thread Jiawei Wang
During the device spawn process, mlx5 PMD queried the available flow priorities by calling mlx5_flow_discover_priorities, queried if the DR drop action was supported on the root table by calling the mlx5_flow_discover_dr_action_support routine, and queried the availability of metadata register C by

Re: [dpdk-dev] [PATCH 1/2] common/cnxk: clear rvum interrupts

2021-09-30 Thread Jerin Jacob
On Tue, Sep 21, 2021 at 4:30 PM Harman Kalra wrote: > > As per an known HW issue RVUM interrupts may get dropped, If an RVUM > interrupt event occurs when PCCPF_XXX_MSIX_CAP_HDR[MSIXEN]=0 then no > interrupt is triggered, which is expected. But after MSIXEN is set to > 1, subsequently if same inte

[dpdk-dev] [PATCH v2] net/mlx5: optimize the device spawn time with representors

2021-09-30 Thread Jiawei Wang
During the device spawn process, mlx5 PMD queried the available flow priorities by calling mlx5_flow_discover_priorities, queried if the DR drop action was supported on the root table by calling the mlx5_flow_discover_dr_action_support routine, and queried the availability of metadata register C by

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-30 Thread Andrew Rybchenko
On 9/30/21 6:30 PM, Ferruh Yigit wrote: > On 9/30/2021 3:01 PM, Andrew Rybchenko wrote: >> On 9/30/21 3:08 PM, Ferruh Yigit wrote: >>> On 9/29/2021 12:54 PM, Andrew Rybchenko wrote: On 9/29/21 11:44 AM, Ferruh Yigit wrote: > On 9/28/2021 5:53 PM, Andrew Rybchenko wrote: >> On 9/28/21 7

[dpdk-dev] [PATCH v7 1/4] ethdev: do not use get xstats names by IDs to obtain count

2021-09-30 Thread Andrew Rybchenko
Relax requirements on get xstats names by IDs. After the patch corresponding the driver operation is called with non-NULL ids and xstats_names parameters only. Signed-off-by: Andrew Rybchenko --- lib/ethdev/rte_ethdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ethdev/rte_ethd

[dpdk-dev] [PATCH v7 1/5] ethdev: fix docs of functions getting xstats by IDs

2021-09-30 Thread Andrew Rybchenko
From: Ivan Ilchenko Document valid combinations of input arguments in accordance with current implementation in ethdev. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by:

[dpdk-dev] [PATCH v7 2/5] ethdev: do not use get xstats names by IDs to obtain count

2021-09-30 Thread Andrew Rybchenko
Relax requirements on get xstats names by IDs. After the patch corresponding the driver operation is called with non-NULL ids and xstats_names parameters only. Signed-off-by: Andrew Rybchenko --- lib/ethdev/rte_ethdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ethdev/rte_ethd

[dpdk-dev] [PATCH v7 2/4] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-30 Thread Andrew Rybchenko
From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage of these callbacks. Document valid combinations of input arguments to make driver implementation simpler. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan

[dpdk-dev] [PATCH v7 3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-30 Thread Andrew Rybchenko
From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage of these callbacks. Document valid combinations of input arguments to make driver implementation simpler. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan

[dpdk-dev] [PATCH v7 4/5] ethdev: improve xstats names by IDs get prototype

2021-09-30 Thread Andrew Rybchenko
Adjust parameters order to eth_xstats_get_by_id_t prototype. Make ids the second parameter similar to eth_xstats_get_by_id_t. Signed-off-by: Andrew Rybchenko --- drivers/net/axgbe/axgbe_ethdev.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.h | 3 ++- drivers/net/cnxk/cnxk_stats.c | 3 ++-

[dpdk-dev] [PATCH v7 3/4] ethdev: improve xstats names by IDs get prototype

2021-09-30 Thread Andrew Rybchenko
Adjust parameters order to eth_xstats_get_by_id_t prototype. Make ids the second parameter similar to eth_xstats_get_by_id_t. Signed-off-by: Andrew Rybchenko --- drivers/net/axgbe/axgbe_ethdev.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.h | 3 ++- drivers/net/cnxk/cnxk_stats.c | 3 ++-

[dpdk-dev] [PATCH v7 5/5] ethdev: merge driver ops to get all xstats names and by ID

2021-09-30 Thread Andrew Rybchenko
All xstats names may be retrieved passing NULL ids. If a driver does not support getting names by IDs, the callback should return -ENOTSUP on attempt to use it. If so, the request is handled on ethdev layer by getting all names and filtering out requested only. Signed-off-by: Andrew Rybchenko --

[dpdk-dev] [PATCH v7 4/4] ethdev: merge driver ops to get all xstats names and by ID

2021-09-30 Thread Andrew Rybchenko
All xstats names may be retrieved passing NULL ids. If a driver does not support getting names by IDs, the callback should return -ENOTSUP on attempt to use it. If so, the request is handled on ethdev layer by getting all names and filtering out requested only. Signed-off-by: Andrew Rybchenko --

[dpdk-dev] [PATCH v8 1/5] ethdev: fix docs of functions getting xstats by IDs

2021-09-30 Thread Andrew Rybchenko
From: Ivan Ilchenko Document valid combinations of input arguments in accordance with current implementation in ethdev. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by:

[dpdk-dev] [PATCH v8 2/5] ethdev: do not use get xstats names by IDs to obtain count

2021-09-30 Thread Andrew Rybchenko
Relax requirements on get xstats names by IDs. After the patch corresponding the driver operation is called with non-NULL ids and xstats_names parameters only. Signed-off-by: Andrew Rybchenko --- lib/ethdev/rte_ethdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/ethdev/rte_ethd

[dpdk-dev] [PATCH v8 3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-30 Thread Andrew Rybchenko
From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage of these callbacks. Document valid combinations of input arguments to make driver implementation simpler. Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") Cc: sta...@dpdk.org Signed-off-by: Ivan

[dpdk-dev] [PATCH v8 4/5] ethdev: improve xstats names by IDs get prototype

2021-09-30 Thread Andrew Rybchenko
Adjust parameters order to eth_xstats_get_by_id_t prototype. Make ids the second parameter similar to eth_xstats_get_by_id_t. Signed-off-by: Andrew Rybchenko --- drivers/net/axgbe/axgbe_ethdev.c| 4 ++-- drivers/net/cnxk/cnxk_ethdev.h | 3 ++- drivers/net/cnxk/cnxk_stats.c | 3 ++-

[dpdk-dev] [PATCH v8 5/5] ethdev: merge driver ops to get all xstats names and by ID

2021-09-30 Thread Andrew Rybchenko
All xstats names may be retrieved passing NULL ids. If a driver does not support getting names by IDs, the callback should return -ENOTSUP on attempt to use it. If so, the request is handled on ethdev layer by getting all names and filtering out requested only. Signed-off-by: Andrew Rybchenko --

Re: [dpdk-dev] [PATCH 1/2] net/cxgbe: add support for xstats API for the VF

2021-09-30 Thread Ferruh Yigit
On 9/27/2021 7:01 PM, Rahul Lakkireddy wrote: > From: Nikhil Vasoya > > Add support to fetch port and queue stats via xstats API. Also remove > queue stats from basic stats because they're now available via xstats > API for the VF. > > Signed-off-by: Nikhil Vasoya > Signed-off-by: Rahul Lakkire

Re: [dpdk-dev] [PATCH 2/2] net/cxgbe: add support to get firmware version

2021-09-30 Thread Ferruh Yigit
On 9/27/2021 7:01 PM, Rahul Lakkireddy wrote: > From: Nikhil Vasoya > > Implement eth_dev_ops callback to get firmware version. > > Signed-off-by: Nikhil Vasoya > Signed-off-by: Rahul Lakkireddy > --- > drivers/net/cxgbe/cxgbe_ethdev.c | 26 ++ > drivers/net/cxgbe/cx

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-09-30 Thread Thomas Monjalon
23/09/2021 13:20, Ivan Malov: > In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace > intending to add new flags, RSS_HASH and FLOW_MARK. Since then, > only the former has been added. The problem hasn't been solved. > Applications still assume that no efforts are needed to enable > fl

Re: [dpdk-dev] [PATCH v2 0/5] kvargs: promote or remove experimental api

2021-09-30 Thread David Marchand
On Thu, Sep 30, 2021 at 11:57 AM Kinsella, Ray wrote: > On 30/09/2021 09:25, David Marchand wrote: > > On Wed, Sep 29, 2021 at 11:40 PM Olivier Matz > > wrote: > >> > >> This patchset promotes 2 functions rte_kvargs_parse_delim() and > >> rte_kvargs_get() as stable. > >> > >> It also replaces rt

Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/pci: fix unknown NUMA node value on Windows

2021-09-30 Thread Thomas Monjalon
27/09/2021 20:34, Menon, Ranjit: > On 9/27/2021 11:43 AM, Pallavi Kadam wrote: > > Based on the rte_eth_dev_socket_id() documentation, > > set the default numa_node to -1. When the API is unsuccessful, > > set numa_node to 0. > > This change more correctly resembles the Linux code. > > > > Fixes: b

Re: [dpdk-dev] [PATCH 0/2] net/cxgbe: fetch VF xstats and firmware version

2021-09-30 Thread Ferruh Yigit
On 9/27/2021 7:01 PM, Rahul Lakkireddy wrote: > This series of patches add following features. > > Patch 1 adds support to fetch port and queue stats via xstats API > for VF. > > Patch 2 adds support to get firmware version. > > Thanks, > Rahul > > Nikhil Vasoya (2): > net/cxgbe: add support

[dpdk-dev] [PATCH] mbuf: remove ethdev deprecation note for flag name

2021-09-30 Thread Aman Singh
Proposed name change of offload flag PKT_RX_EIP_CKSUM_BAD to PKT_RX_OUTER_IP_CKSUM_BAD has already been done in the code as per the deprecation note. Signed-off-by: Aman Singh Acked-by: Ferruh Yigit --- doc/guides/rel_notes/deprecation.rst | 5 - lib/mbuf/rte_mbuf_core.h | 7 ---

Re: [dpdk-dev] [PATCH v8 2/5] ethdev: do not use get xstats names by IDs to obtain count

2021-09-30 Thread Ferruh Yigit
On 9/30/2021 5:05 PM, Andrew Rybchenko wrote: > Relax requirements on get xstats names by IDs. After the patch > corresponding the driver operation is called with non-NULL ids > and xstats_names parameters only. > > Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v8 3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-30 Thread Ferruh Yigit
On 9/30/2021 5:05 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Update xstats by IDs callbacks documentation in accordance with > ethdev usage of these callbacks. Document valid combinations of > input arguments to make driver implementation simpler. > > Fixes: 79c913a42f0 ("ethdev: retr

Re: [dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random

2021-09-30 Thread Thomas Monjalon
10/09/2021 01:23, Pallavi Kadam: > IAVF PMD needs to generate a random MAC address if it is not configured > by host. > 'random' is now supported on Windows. This patch can be the first of this series to respect the dependency order. > Fixes: 16f0d03098cb ("net: build on Windows") > Cc: f...@mell

Re: [dpdk-dev] [PATCH v3 3/3] doc: update iavf PMD and 21.11 release notes

2021-09-30 Thread Thomas Monjalon
10/09/2021 01:23, Pallavi Kadam: > Add documentation to support iavf PMD on Windows. > Update the release notes for the same. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > doc/guides/nics/intel_vf.rst | 18 ++ > doc/guides/rel_notes/release_21_11

Re: [dpdk-dev] [PATCH v8 5/5] ethdev: merge driver ops to get all xstats names and by ID

2021-09-30 Thread Ferruh Yigit
On 9/30/2021 5:05 PM, Andrew Rybchenko wrote: > All xstats names may be retrieved passing NULL ids. > > If a driver does not support getting names by IDs, the callback should > return -ENOTSUP on attempt to use it. If so, the request is handled > on ethdev layer by getting all names and filtering

Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support

2021-09-30 Thread Thomas Monjalon
30/09/2021 18:27, Srikanth K: > Sure, I will follow the Windows support approach. > > Regarding the patches organization, they were arranged logically to the > best of my knowledge. It is not. > The approach followed is to take Linux PMD code and replace the Linux > dependent part with the > Fre

[dpdk-dev] [PATCH v2 03/28] common/cnxk: allow reuse of SSO API for inline dev

2021-09-30 Thread Nithin Dabilpuram
Rework interface of SSO internal functions to use for NIX inline dev's SSO LF's. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_sso.c | 52 -- drivers/common/cnxk/roc_sso_priv.h | 9 +++ 2 files changed, 42 insertions(+), 19 deletions(-

[dpdk-dev] [PATCH v2 00/28] net/cnxk: support for inline ipsec

2021-09-30 Thread Nithin Dabilpuram
Support for inline ipsec in CN9K event mode and in Cn10K event mode and poll mode. Kommula Shiva Shankar (1): common/cnxk: add CQ enable support in NIX Tx path Nithin Dabilpuram (18): common/cnxk: support CPT parse header dump common/cnxk: allow reuse of SSO API for inline dev common/cnxk

[dpdk-dev] [PATCH v2 08/28] common/cnxk: disable CQ drop when inline inbound is enabled

2021-09-30 Thread Nithin Dabilpuram
Disable CQ drop when inline inbound is enabled. CQ drop is not supported for second pass IPsec decrypted packets. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_queue.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_q

[dpdk-dev] [PATCH v2 01/28] common/cnxk: support cn9k fast path security session

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Add security support to init cn9k fast path SA data for AES GCM and AES CBC + HMAC SHA1. Signed-off-by: Srujana Challa Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/cnxk_security.c | 211 drivers/common/cnxk/cnxk_security.h

[dpdk-dev] [PATCH v2 02/28] common/cnxk: support CPT parse header dump

2021-09-30 Thread Nithin Dabilpuram
Add helper API to dump CPT parse header. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_cpt.h | 2 ++ drivers/common/cnxk/roc_cpt_debug.c | 31 +++ drivers/common/cnxk/version.map | 1 + 3 files changed, 34 insertions(+) diff --git a/drivers

[dpdk-dev] [PATCH v2 04/28] common/cnxk: change NIX debug API and queue API interface

2021-09-30 Thread Nithin Dabilpuram
Change NIX debug API and queue API interface for use by internal NIX inline device initialization. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.c | 2 +- drivers/common/cnxk/roc_nix_debug.c | 118 +++- drivers/common/cnxk/roc_nix_priv.h

[dpdk-dev] [PATCH v2 07/28] common/cnxk: support NIX inline inbound and outbound setup

2021-09-30 Thread Nithin Dabilpuram
Add API to support setting up NIX inline inbound and NIX inline outbound. In case of inbound, SA base is setup on NIX PFFUNC and in case of outbound, required number of CPT LF's are attached to NIX PFFUNC. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/cpt.h | 8 + drivers

[dpdk-dev] [PATCH v2 13/28] common/cnxk: setup aura BP conf based on nix

2021-09-30 Thread Nithin Dabilpuram
Currently only NIX0 conf is setup in AURA for backpressure. This patch adds support for NIX1 as well. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_fc.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_fc.

[dpdk-dev] [PATCH v2 05/28] common/cnxk: support NIX inline device IRQ

2021-09-30 Thread Nithin Dabilpuram
Add API to setup NIX inline device IRQ's. This registers IRQ's for errors in case of NIX, CPT LF, SSOW and get wor interrupt in case of SSO. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/c

[dpdk-dev] [PATCH v2 14/28] common/cnxk: support anti-replay check in SW for cn9k

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds anti replay SW implementation for cn9k platform. Signed-off-by: Srujana Challa --- drivers/common/cnxk/cnxk_security_ar.h | 184 + 1 file changed, 184 insertions(+) create mode 100644 drivers/common/cnxk/cnxk_security_ar.h diff --git

[dpdk-dev] [PATCH v2 09/28] common/cnxk: dump CPT LF registers on error intr

2021-09-30 Thread Nithin Dabilpuram
Dump CPT LF registers on error interrupt for debugging purpose. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_cpt.c | 5 - drivers/common/cnxk/roc_cpt_debug.c | 32 ++-- drivers/common/cnxk/roc_cpt_priv.h | 1 + 3 files changed, 35 insertio

[dpdk-dev] [PATCH v2 10/28] common/cnxk: align CPT LF enable/disable sequence

2021-09-30 Thread Nithin Dabilpuram
For CPT LF IQ enable, set CPT_LF_CTL[ENA] before setting CPT_LF_INPROG[EENA] to true. For CPT LF IQ disable, align sequence to that of HRM. Also this patch aligns space for instructions in CPT LF to ROC_ALIGN to make complete memory cache aligned and has other minor fixes/additions. Signed-off-b

[dpdk-dev] [PATCH v2 06/28] common/cnxk: support NIX inline device init and fini

2021-09-30 Thread Nithin Dabilpuram
Add support to init and fini inline device with NIX LF, SSO LF and SSOW LF for inline inbound IPSec in CN10K. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_api.h | 2 + drivers/common/cnxk/roc_cpt.c | 7 +- driv

[dpdk-dev] [PATCH v2 11/28] common/cnxk: restore NIX sqb pool limit before destroy

2021-09-30 Thread Nithin Dabilpuram
Restore SQB AURA/POOL limit before destroying SQB to be able to drain all the buffers from the aura. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_queue.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_ni

[dpdk-dev] [PATCH v2 12/28] common/cnxk: add CQ enable support in NIX Tx path

2021-09-30 Thread Nithin Dabilpuram
From: Kommula Shiva Shankar This patch provides applications to add CQ support in Tx path. This enables packet completion events on CQ for requested packets. Signed-off-by: Kommula Shiva Shankar --- drivers/common/cnxk/roc_nix.h | 2 ++ drivers/common/cnxk/roc_nix_queue.c | 4 2 fil

[dpdk-dev] [PATCH v2 15/28] common/cnxk: support inline IPsec rte flow action

2021-09-30 Thread Nithin Dabilpuram
From: Satheesh Paul Add support to configure flow rules with inline IPsec action. Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_nix_inl.h | 3 +++ drivers/common/cnxk/roc_nix_inl_dev.c | 3 +++ drivers/common/cnxk/roc_nix_inl_priv.h | 3 +++ drivers/common/cnxk/roc_npc_mcam

[dpdk-dev] [PATCH v2 16/28] net/cnxk: support inline security setup for cn9k

2021-09-30 Thread Nithin Dabilpuram
Add support for inline inbound and outbound IPSec for SA create, destroy and other NIX / CPT LF configurations. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn9k_ethdev.c | 23 +++ drivers/net/cnxk/cn9k_ethdev.h | 61 +++ drivers/net/cnxk/cn9k_ethdev_sec.c | 31

[dpdk-dev] [PATCH v2 17/28] net/cnxk: support inline security setup for cn10k

2021-09-30 Thread Nithin Dabilpuram
Add support for inline inbound and outbound IPSec for SA create, destroy and other NIX / CPT LF configurations. This patch also changes dpdk-devbind.py to list new inline device as misc device. Signed-off-by: Nithin Dabilpuram --- doc/guides/nics/cnxk.rst | 102 doc/gui

[dpdk-dev] [PATCH v2 18/28] net/cnxk: support Rx security offload on cn9k

2021-09-30 Thread Nithin Dabilpuram
Add support to receive CPT processed packets on Rx for CN9K. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn9k_eventdev.c | 153 drivers/event/cnxk/cn9k_worker.h| 7 +- drivers/event/cnxk/cn9k_worker_deq.c| 2 +- drivers/event/cnxk

[dpdk-dev] [PATCH v2 19/28] net/cnxk: support Tx security offload on cn9k

2021-09-30 Thread Nithin Dabilpuram
Add support to create and submit CPT instructions on Tx on CN9K SoC. Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_eventdev.c | 29 +- drivers/event/cnxk/cn9k_worker.h | 163 +- drivers/event/cnxk/cn9k_worker_d

[dpdk-dev] [PATCH v2 20/28] net/cnxk: support Rx security offload on cn10k

2021-09-30 Thread Nithin Dabilpuram
Add support to receive CPT processed packets on Rx via second pass on CN10K. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_eventdev.c | 80 ++-- drivers/event/cnxk/cn10k_worker.h | 73 +++- drivers/event/cnxk/cn10k_worker_deq.c | 2 +- drivers/event/cn

[dpdk-dev] [PATCH v2 25/28] net/cnxk: allow zero udp6 checksum for non inline device

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Sets IP6_UDP_OPT in NIX RX config to allow optional UDP checksum for IPv6 in case of security offload. Also disable drop_re when inline inbound is enabled. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn10k_ethdev.c | 5 + drivers/net/cnxk/cnxk_ethdev.c | 9

[dpdk-dev] [PATCH v2 26/28] net/cnxk: add crypto capabilities for AES CBC and HMAC SHA1

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds capabitlities for AES_CBC and HMAC_SHA1 for 9k security offload. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn10k_ethdev_sec.c | 40 + drivers/net/cnxk/cn9k_ethdev_sec.c | 40 + 2 files c

[dpdk-dev] [PATCH v2 27/28] net/cnxk: support configuring channel mask via devargs

2021-09-30 Thread Nithin Dabilpuram
From: Satheesh Paul This patch adds support to configure channel mask which will be used by rte flow when adding flow rules with inline IPsec action. Signed-off-by: Satheesh Paul --- doc/guides/nics/cnxk.rst | 20 +++ drivers/net/cnxk/cnxk_ethdev_sec.c | 39 ++

[dpdk-dev] [PATCH v2 21/28] net/cnxk: support Tx security offload on cn10k

2021-09-30 Thread Nithin Dabilpuram
Add support to create and submit CPT instructions on Tx on CN10K. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_eventdev.c | 15 +- drivers/event/cnxk/cn10k_worker.h| 74 +- drivers/event/cnxk/cn10k_worker_tx_enq.c | 2 +- drivers/event/cnxk/cn10k_wor

[dpdk-dev] [PATCH v2 22/28] net/cnxk: support IPsec anti replay in cn9k

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds anti replay support for cn9k platform using SW anti replay check. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn9k_ethdev.h | 3 +++ drivers/net/cnxk/cn9k_ethdev_sec.c | 29 drivers/net/cnxk/cn9k_rx.h | 54 +

[dpdk-dev] [PATCH v2 23/28] net/cnxk: support IPsec transport mode in cn10k

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds IPsec transport mode capability to rte security capabilities. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn10k_ethdev_sec.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/cn

[dpdk-dev] [PATCH v2 24/28] net/cnxk: update ethertype for mixed IPsec tunnel versions

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds support to update ethertype for mixed IPsec tunnel versions. And also sets et_overwr for inbound IPsec. Signed-off-by: Srujana Challa --- drivers/common/cnxk/cnxk_security.c | 1 + drivers/net/cnxk/cn10k_ethdev.h | 3 ++- drivers/net/cnxk/cn10k_ethdev_sec.c | 2

[dpdk-dev] [PATCH v2 28/28] net/cnxk: reflect globally enabled offloads in queue conf

2021-09-30 Thread Nithin Dabilpuram
Reflect globally enabled Rx and Tx offloads in queue conf. Also fix issue with lmt data prepare for multi seg. Fixes: a24af6361e37 ("net/cnxk: add Tx queue setup and release") Fixes: a86144cd9ded ("net/cnxk: add Rx queue setup and release") Fixes: 305ca2c4c382 ("net/cnxk: support multi-segment vec

[dpdk-dev] [PATCH v2 0/2] net/cxgbe: add VF xstats and firmware version

2021-09-30 Thread Rahul Lakkireddy
This series of patches add following features. Patch 1 adds support to fetch port and queue stats via xstats API for VF. Patch 2 adds support to get firmware version. Thanks, Rahul --- v2: - Update Extended Stats and FW version features in cxgbe.ini and cxgbevf.ini Nikhil Vasoya (2): net/c

[dpdk-dev] [PATCH v2 1/2] net/cxgbe: add support for xstats API for the VF

2021-09-30 Thread Rahul Lakkireddy
From: Nikhil Vasoya Add support to fetch port and queue stats via xstats API. Also remove queue stats from basic stats because they're now available via xstats API for the VF. Signed-off-by: Nikhil Vasoya Signed-off-by: Rahul Lakkireddy --- v2: - Update Extended Stats feature in cxgbe.ini and

[dpdk-dev] [PATCH v2 2/2] net/cxgbe: add support to get firmware version

2021-09-30 Thread Rahul Lakkireddy
From: Nikhil Vasoya Implement eth_dev_ops callback to get firmware version. Signed-off-by: Nikhil Vasoya Signed-off-by: Rahul Lakkireddy --- v2: - Update FW version feature in cxgbe.ini and cxgbevf.ini doc/guides/nics/features/cxgbe.ini | 1 + doc/guides/nics/features/cxgbevf.ini | 1 +

Re: [dpdk-dev] [PATCH] [v3] vdpa/ifc: increase readability in function

2021-09-30 Thread Ferruh Yigit
On 9/28/2021 3:22 AM, Wang, Xiao W wrote: > Hi, > >> -Original Message- >> From: jilei chen >> Sent: Monday, September 27, 2021 6:18 PM >> To: Wang, Xiao W >> Cc: dev@dpdk.org >> Subject: [PATCH] [v3] vdpa/ifc: increase readability in function >> >> Use bool type for function's switch pa

[dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-09-30 Thread Dharmik Thakkar
Current mempool per core cache implementation is based on pointer For most architectures, each pointer consumes 64b Replace it with index-based implementation, where in each buffer is addressed by (pool address + index) It will reduce memory requirements L3Fwd performance testing reveals minor imp

[dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions

2021-09-30 Thread Sean Morrissey
These methods were introduced in 20.05. There has been no changes in their public API since then. They seem mature enough to remove the experimental tag. Signed-off-by: Sean Morrissey --- lib/ring/rte_ring_hts.h | 9 - lib/ring/rte_ring_peek.h| 13 - lib/ring/rte_rin

Re: [dpdk-dev] Questions about vm2vm vhost-user/virtio-net test

2021-09-30 Thread David Christensen
On 9/30/21 2:07 AM, Min Hu (Connor) wrote: Hi, all, I got the answer: testpmd fwd mode should be set "io", then ping OK. IO fwd mode, it will not change packet MAC address info, and ping OK MAC fwd mode, it will change packet MAC address info, like: "rte_ether_addr_copy(&p

Re: [dpdk-dev] [PATCH 3/4] ethdev: support PPPoL2TPv2oUDP RSS Hash

2021-09-30 Thread Ori Kam
Hi Jie, You are missing updating the rte_flow.rst and release notes: Please see more comments below. Thanks, Ori > -Original Message- > From: dev On Behalf Of Jie Wang > Sent: Friday, September 24, 2021 6:17 PM > Subject: [dpdk-dev] [PATCH 3/4] ethdev: support PPPoL2TPv2oUDP RSS > Hash

Re: [dpdk-dev] [dpdk-stable] [DPDK] net/virtio: fix check scatter on all Rx queues

2021-09-30 Thread David Marchand
On Wed, Sep 22, 2021 at 10:13 AM Peng, ZhihongX wrote: > > On 15/09/2021 19:37, David Marchand wrote: > > > On Wed, Aug 4, 2021 at 10:36 AM wrote: > > >> > > >> From: Zhihong Peng > > >> > > >> This patch fixes the wrong way to obtain virtqueue. > > >> The end of virtqueue cannot be judged based

Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK

2021-09-30 Thread David Marchand
On Thu, Sep 30, 2021 at 3:09 PM wrote: > > From: Zhihong Peng > > AddressSanitizer (ASan) is a google memory error detect > standard tool. It could help to detect use-after-free and > {heap,stack,global}-buffer overflow bugs in C/C++ programs, > print detailed error information when error happens

Re: [dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions

2021-09-30 Thread Ananyev, Konstantin
> > These methods were introduced in 20.05. > There has been no changes in their public API since then. > They seem mature enough to remove the experimental tag. > > Signed-off-by: Sean Morrissey > --- Acked-by: Konstantin Ananyev > -- > 2.25.1

[dpdk-dev] [PATCH v4 5/6] app/testpmd: force shared Rx queue polled on same core

2021-09-30 Thread Xueming Li
Shared rxqs shares one set rx queue of groups zero. Shared Rx queue must must be polled from one core. Checks and stops forwarding if shared rxq being scheduled on multiple cores. Signed-off-by: Xueming Li --- app/test-pmd/config.c | 96 ++ app/test-pmd/

[dpdk-dev] [PATCH v4 2/6] ethdev: new API to aggregate shared Rx queue group

2021-09-30 Thread Xueming Li
This patch introduces new api to aggreate ports among same shared Rx queue group. Only queues with specified share group are aggregated. Rx burst and device close are expected to be supported by new device. Signed-off-by: Xueming Li --- lib/ethdev/ethdev_driver.h | 23 ++- li

[dpdk-dev] [PATCH v4 1/6] ethdev: introduce shared Rx queue

2021-09-30 Thread Xueming Li
In current DPDK framework, each RX queue is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Most important, polling all ports leads to high cache miss, high latency and low throughput. This patch intro

[dpdk-dev] [PATCH v4 4/6] app/testpmd: dump port info for shared Rx queue

2021-09-30 Thread Xueming Li
In case of shared Rx queue, polling any member port returns mbufs for all members. This patch dumps mbuf->port for each packet. Signed-off-by: Xueming Li --- app/test-pmd/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 14a9a251fb9..4c

[dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-09-30 Thread Xueming Li
In current DPDK framework, all RX queues is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Further more, polling all ports leads to high cache miss, high latency and low throughputs. This patch introd

[dpdk-dev] [PATCH v4 6/6] app/testpmd: add forwarding engine for shared Rx queue

2021-09-30 Thread Xueming Li
To support shared Rx queue, this patch introduces dedicate forwarding engine. The engine groups received packets by mbuf->port into sub-group, updates stream statistics and simply frees packets. Signed-off-by: Xueming Li --- app/test-pmd/meson.build| 1 + app/test-pmd/share

[dpdk-dev] [PATCH v4 3/6] app/testpmd: new parameter to enable shared Rx queue

2021-09-30 Thread Xueming Li
Adds "--rxq-share" parameter to enable shared rxq for each rxq. Default shared rxq group 0 is used, RX queues in same switch domain shares same rxq according to queue index. Shared Rx queue is enabled only if device support offloading flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ. Signed-off-by: Xueming Li

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ori Kam
Hi Ivan, Sorry for jumping in late. I have a concern that this patch breaks other PMDs. >From the rst file " One should negotiate flag delivery beforehand" since you only added this function for your PMD all other PMD will fail. I see that you added exception in the examples, but it doesn't make

Re: [dpdk-dev] [PATCH v3 3/3] doc: update iavf PMD and 21.11 release notes

2021-09-30 Thread Thomas Monjalon
10/09/2021 01:23, Pallavi Kadam: > Add documentation to support iavf PMD on Windows. > Update the release notes for the same. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > --- a/doc/guides/nics/intel_vf.rst > +++ b/doc/guides/nics/intel_vf.rst > +Windows Support > +---

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
Hi Ori, On 30/09/2021 17:59, Ori Kam wrote: Hi Ivan, Sorry for jumping in late. No worries. That's OK. I have a concern that this patch breaks other PMDs. It does no such thing. From the rst file " One should negotiate flag delivery beforehand" since you only added this function for you

[dpdk-dev] [PATCH v6 0/2] ethdev: change queue release callback

2021-09-30 Thread Xueming Li
This patch is a preparation of shared Rx queue feature[1]. Rxq object could be shared among ports of a share group, a shared rxq object can't tell which port it belongs to. This is the motativation to clean up queue release callback API to use queue ID. v2: included new NFP PMD driver v3: - commit

[dpdk-dev] [PATCH v6 1/2] ethdev: make queue release callback optional

2021-09-30 Thread Xueming Li
Some drivers don't need Rx and Tx queue release callback, make them optional. Clean up empty queue release callbacks for some drivers. Signed-off-by: Xueming Li Reviewed-by: Andrew Rybchenko Acked-by: Ferruh Yigit --- app/test/virtual_pmd.c| 12 drivers/net/af_packet/r

[dpdk-dev] [PATCH v6 2/2] ethdev: change queue release callback

2021-09-30 Thread Xueming Li
Currently, most ethdev callback API use queue ID as parameter, but Rx and Tx queue release callback use queue object which is used by Rx and Tx burst data plane callback. To align with other eth device queue configuration callbacks: - queue release callbacks are changed to use queue ID - all drive

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
Hi Thomas, On 30/09/2021 19:18, Thomas Monjalon wrote: 23/09/2021 13:20, Ivan Malov: In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace intending to add new flags, RSS_HASH and FLOW_MARK. Since then, only the former has been added. The problem hasn't been solved. Applications sti

[dpdk-dev] DPDK Release Status Meeting 2021-09-23

2021-09-30 Thread Mcnamara, John
Release status meeting minutes 2021-09-23 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - * v21.11 dates * Proposal/V1:Friday, 10

[dpdk-dev] DPDK Release Status Meeting 2021-09-30

2021-09-30 Thread Mcnamara, John
Release status meeting minutes 2021-09-30 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * Broadcom * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - * v21.11 dates * Proposal/V1:Friday

<    1   2   3   >