[dpdk-dev] [PATCH v1 4/6] lib/power: reduce memory footprint of cppc lib

2021-09-09 Thread David Hunt
Switch from static memory allocation of core info structs to dynamic allocation. The library used to statically allocate max_lcores number of lcore_power_info structs, so change this to rte_malloc as needed. Reduces static footprint from 192K to 1K. Desirable, especially if we're changing max_lcor

[dpdk-dev] [PATCH v1 5/6] lib/power: reduce memory footprint of channels

2021-09-09 Thread David Hunt
Switch from static memory allocation of channel pkt structs to dynamic allocation. The library used to statically allocate max_lcores number of rte_power_channel_packet structs, so change this to rte_malloc as needed. Reduces static footprint from 236K to 1K. Desirable, especially if we're changin

[dpdk-dev] [PATCH v1 6/6] lib/power: switch empty poll to max cores config

2021-09-09 Thread David Hunt
empty poll algorithm uses NUM_NODES as 256, but should really use RTE_MAX_LCORE, which is configurable. Signed-off-by: David Hunt --- lib/power/rte_power_empty_poll.c | 12 ++-- lib/power/rte_power_empty_poll.h | 4 +--- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/lib

[dpdk-dev] [PATCH v13 0/4] devtools: scripts to count and track symbols

2021-09-09 Thread Ray Kinsella
Scripts to count and track the lifecycle of DPDK symbols. The symbol-tool script reports on the growth of symbols over releases and list expired symbols. The notify-symbol-maintainers script consumes the input from symbol-tool and generates email notifications of expired symbols. v2: reworked to

[dpdk-dev] [PATCH v13 1/4] devtools: script to track symbols over releases

2021-09-09 Thread Ray Kinsella
This script tracks the growth of stable and experimental symbols over releases since v19.11. The script has the ability to count the added symbols between two dpdk releases, and to list experimental symbols present in two dpdk releases (expired symbols). example usages: Count symbols added since

[dpdk-dev] [PATCH v13 2/4] devtools: script to send notifications of expired symbols

2021-09-09 Thread Ray Kinsella
Use this script with the output of the DPDK symbol tool, to notify maintainers of expired symbols by email. You need to define the environment variable DPDK_GETMAINTAINER_PATH for this tool to work. Use terminal output to review the emails before sending. e.g. $ devtools/symbol-tool.py list-expire

[dpdk-dev] [PATCH v13 3/4] maintainers: add new abi scripts

2021-09-09 Thread Ray Kinsella
Add new abi management scripts to the MAINTAINERS file. Signed-off-by: Ray Kinsella --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 266f5ac1da..ae38af1b85 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -127,8 +127,11 @@ F: devtools/check-abi-

[dpdk-dev] [PATCH v13 4/4] devtools: add asym crypto to symbol-tool ignore

2021-09-09 Thread Ray Kinsella
Add asym crypto to the symbol-tool's ignore file. Signed-off-by: Ray Kinsella Acked-by: Akhil Goyal --- devtools/symboltool.abignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 devtools/symboltool.abignore diff --git a/devtools/symboltool.abignore b/devtools/symboltool.abignor

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread fengchengwen
On 2021/9/9 20:45, Bruce Richardson wrote: > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: >> 09/09/2021 13:18, Bruce Richardson: >>> On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: 07/09/2021 14:56, Chengwen Feng: > + * The first three APIs are used to

[dpdk-dev] [PATCH] vhost: merge repeated loop in vhost Tx

2021-09-09 Thread Gaoxiang Liu
To improve performance of vhost Tx, merge repeated loop in eth_vhost_tx. Move "vlan insert" from eth_vhost_tx to virtio_dev_rx_packed and virtio_dev_rx_split to reduce a loop iteration. Fixes: f63d356ee993 ("net/vhost: insert/strip VLAN header in software") Cc: sta...@dpdk.org Signed-off-by: Gaox

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Thomas Monjalon
09/09/2021 15:33, fengchengwen: > On 2021/9/9 18:33, Thomas Monjalon wrote: > > 07/09/2021 14:56, Chengwen Feng: > >> + * The DMA controller could have multiple HW-DMA-channels (aka. > >> HW-DMA-queues), > >> + * each HW-DMA-channel should be represented by a dmadev. > >> + * > >> + * The dmadev c

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Thomas Monjalon
09/09/2021 15:54, fengchengwen: > On 2021/9/9 20:45, Bruce Richardson wrote: > > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: > >> 09/09/2021 13:18, Bruce Richardson: > >>> On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: > 07/09/2021 14:56, Chengwen Feng: >

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Bruce Richardson
On Thu, Sep 09, 2021 at 09:54:27PM +0800, fengchengwen wrote: > On 2021/9/9 20:45, Bruce Richardson wrote: > > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: > >> 09/09/2021 13:18, Bruce Richardson: > >>> On Thu, Sep 09, 2021 at 12:33:00PM +0200, Thomas Monjalon wrote: > 07/0

[dpdk-dev] [PATCH 0/4] iavf: add iAVF IPsec inline crypto support

2021-09-09 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Radu Nicolau (4): common/iavf: add iAVF IPsec inline crypto support net/iavf: add iAVF IPsec inline cr

[dpdk-dev] [PATCH 1/4] common/iavf: add iAVF IPsec inline crypto support

2021-09-09 Thread Radu Nicolau
Add support for inline crypto for IPsec. Signed-off-by: Declan Doherty Signed-off-by: Abhijit Sinha Signed-off-by: Radu Nicolau --- drivers/common/iavf/iavf_type.h | 215 +++- drivers/common/iavf/virtchnl.h | 17 +- drivers/common/iavf/virtchnl_inline_ipsec.h | 55

[dpdk-dev] [PATCH 3/4] net/iavf: Add xstats support for inline IPsec crypto

2021-09-09 Thread Radu Nicolau
Add per queue counters for maintaining statistics for inline IPsec crypto offload, which can be retrieved through the rte_security_session_stats_get() with more detailed errors through the rte_ethdev xstats. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf.h

[dpdk-dev] [PATCH 2/4] net/iavf: add iAVF IPsec inline crypto support

2021-09-09 Thread Radu Nicolau
Add support for inline crypto for IPsec, for ESP transport and tunnel over IPv4 and IPv6, as well as supporting the offload for ESP over UDP, and inconjunction with TSO for UDP and TCP flows. Implement support for rte_security packet metadata Add definition for IPsec descriptors, extend support fo

[dpdk-dev] [PATCH 4/4] net/iavf: add watchdog for VFLR

2021-09-09 Thread Radu Nicolau
Add watchdog to iAVF PMD which support monitoring the VFLR register. If the device is not already in reset then if a VF reset in progress is detected then notfiy user through callback and set into reset state. If the device is already in reset then poll for completion of reset. Signed-off-by: Decl

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Bruce Richardson
On Thu, Sep 09, 2021 at 04:26:40PM +0200, Thomas Monjalon wrote: > 09/09/2021 15:54, fengchengwen: > > On 2021/9/9 20:45, Bruce Richardson wrote: > > > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: > > >> 09/09/2021 13:18, Bruce Richardson: > > >>> On Thu, Sep 09, 2021 at 12:33:0

Re: [dpdk-dev] [PATCH v1 1/6] build: increase default of max lcores to 512

2021-09-09 Thread Bruce Richardson
On Thu, Sep 09, 2021 at 02:45:06PM +0100, David Hunt wrote: > Modern processors are coming with an ever increasing number of cores, > and 128 does not seem like a sensible max limit any more, especially > when you consider multi-socket systems with Hyper-Threading enabled. > > This patch increases

Re: [dpdk-dev] [PATCH v6] net/pcap: improve rx statistics

2021-09-09 Thread Ferruh Yigit
On 9/9/2021 1:28 PM, Qiming Chen wrote: > In the receiving direction, if alloc mbuf or jumbo process failed, there > is no err_pkts count, which makes it difficult to locate the problem. > Because alloc mbuf failed, the rx_nombuf field is counted. > > Signed-off-by: Qiming Chen Acked-by: Ferruh

[dpdk-dev] [PATCH] net/memif: fix chained mbuf determination

2021-09-09 Thread Junxiao Shi
Previously, TX functions call rte_pktmbuf_is_contiguous to determine whether an mbuf is chained. However, rte_pktmbuf_is_contiguous is designed to work on the first mbuf of a packet only. In case a packet contains three or more segment mbufs in a chain, it may cause truncated packets or rte_mbuf_sa

[dpdk-dev] [PATCH] bpf: fix spelling in comments

2021-09-09 Thread Stephen Hemminger
Found by running codespell on the bpf implementation. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_validate.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bpf/bpf_jit_x86.c b/lib/bpf/bpf_jit_x86.c index aa22ea78a01d..518513376a67

Re: [dpdk-dev] [PATCH v21 1/7] dmadev: introduce DMA device library public APIs

2021-09-09 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, 9 September 2021 16.29 > > On Thu, Sep 09, 2021 at 09:54:27PM +0800, fengchengwen wrote: > > On 2021/9/9 20:45, Bruce Richardson wrote: > > > On Thu, Sep 09, 2021 at 01:29:33PM +0200, Thomas Monjalon wrote: >

[dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive mode

2021-09-09 Thread David Hunt
Add non-interactive mode to dpdk-telemetry.py so that a query string can be supplied on the command line, and script dumps out data and exits. Handing for calling from scripts. Signed-off-by: David Hunt --- usertools/dpdk-telemetry.py | 22 ++ 1 file changed, 14 insertions(+)

Re: [dpdk-dev] [PATCH v5] build: optional NUMA and cpu counts detection

2021-09-09 Thread David Christensen
Piotr says lscpu isn't available on ppc FreeBSD. I think this leaves us with two options: 1. either use sysctl with the risk that it may not return an accurate value 2. not support PPC for numa detection What do you think? I think point #2 is more not supporting FreeBSD on PPC for numa dete

Re: [dpdk-dev] [PATCH] ethdev: group constant definitions in Doxygen

2021-09-09 Thread Ferruh Yigit
On 8/30/2021 11:42 AM, Thomas Monjalon wrote: > A lot of flags are parts of a group but are documented alone. > The Doxygen syntax @{ and @} for grouping is used > to make flags appear together and have a common description. > > Some Rx/Tx offload flags and RSS definitions are not grouped > becaus

Re: [dpdk-dev] [PATCH 0/3] bugfixes for hns3 PMD

2021-09-09 Thread Ferruh Yigit
On 8/30/2021 9:26 AM, Min Hu (Connor) wrote: > This patch contains three bugfixes for hns3 PMD. > > Chengchang Tang (2): > net/hns3: fix queue flow action validation > net/hns3: fix new taskqueue pair reset command > > Min Hu (Connor) (1): > net/hns3: fix Tx push capability > Series appli

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: make EF100 native Rx datapath set FDIR bit for MARK

2021-09-09 Thread Ferruh Yigit
On 8/30/2021 3:35 PM, Ivan Malov wrote: > According to flow action MARK definition, PMDs must set both > PKT_RX_FDIR and PKT_RX_FDIR_ID if the packet contains a mark. > > Fixes: 1aacc3d388d3 ("net/sfc: support user mark and flag Rx for EF100") > Cc: sta...@dpdk.org > > Signed-off-by: Ivan Malov

[dpdk-dev] [PATCH 00/18] comment spelling errors

2021-09-09 Thread Stephen Hemminger
After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments. Stephen Hemminger (18): node: fix typos ipsec: fix spelling errors eventdev: fix typo in comment power: fix typo in comment rcu: fix typo in c

[dpdk-dev] [PATCH 01/18] node: fix typos

2021-09-09 Thread Stephen Hemminger
Spelling errors in comments including doxygen Signed-off-by: Stephen Hemminger --- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node/ethdev_rx_priv.h b/lib/node/ethde

[dpdk-dev] [PATCH 02/18] ipsec: fix spelling errors

2021-09-09 Thread Stephen Hemminger
Lots of typos in comments found by codespell Signed-off-by: Stephen Hemminger --- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c| 2 +- lib/ipsec/sa.h| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[dpdk-dev] [PATCH 03/18] eventdev: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Typo in comment found by codespell Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index ee20b39f4b24..b5c2dc1427c6 100

[dpdk-dev] [PATCH 04/18] power: fix typo in comment

2021-09-09 Thread Stephen Hemminger
More spelling errors caught by codespell Signed-off-by: Stephen Hemminger --- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 1e8aeb84037c..402ed8c99b42 100644 --- a/lib/power

[dpdk-dev] [PATCH 05/18] rcu: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Another codespell find. Signed-off-by: Stephen Hemminger --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index 18811c1cc106..62a420a785fc 100644 --- a/lib/rcu/rte_rcu_qsbr.h +++ b/lib/rcu/rte_rcu_qsbr.

[dpdk-dev] [PATCH 06/18] bpf: fix spelling in comments

2021-09-09 Thread Stephen Hemminger
Found by running codespell on the bpf implementation. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_validate.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bpf/bpf_jit_x86.c b/lib/bpf/bpf_jit_x86.c index aa22ea78a01d..518513376a67

[dpdk-dev] [PATCH 07/18] acl: fix spelling errors

2021-09-09 Thread Stephen Hemminger
Lots of little typos in comments Signed-off-by: Stephen Hemminger --- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index 4089ab2a0462..f5739a475cf0 10064

[dpdk-dev] [PATCH 08/18] eal: fix typos in comments

2021-09-09 Thread Stephen Hemminger
Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_function_versioning.h b/lib/eal/include/rte_function

[dpdk-dev] [PATCH 09/18] net: fix spelling error in gtp comment

2021-09-09 Thread Stephen Hemminger
More codespell finds. Signed-off-by: Stephen Hemminger --- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h index 6a6f9b238db9..f22dbce47c65 100644 --- a/lib/net/rte_gtp.h +++ b/lib/net/rte_gtp.h @@ -64,9 +64,9 @@ s

[dpdk-dev] [PATCH 10/18] bbdev: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index fc37236195be..49a0de49d8df 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/lib/bbdev/rte_bbdev.c @@ -138,7 +138,7 @@ rte_bbde

[dpdk-dev] [PATCH 11/18] pipeline: fix spellin error in comment

2021-09-09 Thread Stephen Hemminger
Minor typo Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline.h b/lib/pipeline/rte_swx_pipeline.h index cd395ac39dbb..9bfc69b2bb4f 100644 --- a/lib/pipeline/rte_swx_pipeline.h +++

[dpdk-dev] [PATCH 12/18] hash: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index d5a95a6e009a..f5e9111f0264 100644 --- a/lib/hash/rte_thash.c +++ b/lib/hash/rte_thash.c @@ -26,7 +26,7 @@ EAL_REGISTER_TA

[dpdk-dev] [PATCH 13/18] rib: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index 96424e9c9f4f..4a6f29b0040d 100644 --- a/lib/rib/rte_rib6.c +++ b/lib/rib/rte_rib6.c @@ -199,7 +199,7 @@ rte_rib6_lookup_exact(s

[dpdk-dev] [PATCH 14/18] sched: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index a858f61f9548..329f4b2e7b48 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -579,7 +579,7 @@ rte_sche

[dpdk-dev] [PATCH 15/18] vhost: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index 8d875e932297..c36dfc705b04 100644 --- a/lib/vhost/rte_vhost.h +++ b/lib/vhost/rte_vhost.h @@ -776,7 +776,7 @@ rte_

[dpdk-dev] [PATCH 16/18] ip_frag: fix typos

2021-09-09 Thread Stephen Hemminger
Minor typos in comment. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 69666c8b8271..4a89a5f5365a 100644 --- a/lib/ip_frag/rte_

[dpdk-dev] [PATCH 17/18] test: fix spelling errors in comments

2021-09-09 Thread Stephen Hemminger
Lots of little typos Signed-off-by: Stephen Hemminger --- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_compressdev_test_buffer.h |

[dpdk-dev] [PATCH 18/18] test-pmd: fix spelling errors in comments

2021-09-09 Thread Stephen Hemminger
More typos Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 82253bc75110..2628bd64dae6 100644

[dpdk-dev] [PATCH v2 1/3] net/iavf: build on Windows

2021-09-09 Thread Pallavi Kadam
- Enable IAVF PMD build on Windows - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types - Fix for pointer and integer sign warnings using Clang compiler on Windows - Add extra cflags '-fno-asynchronous-unwind-tables' to avoid MinGW build error: Error: invalid regis

[dpdk-dev] [PATCH v2 0/3] Support iavf PMD on Windows

2021-09-09 Thread Pallavi Kadam
This patch-set enables building the iavf PMD on Windows. Currently, it uses alarm functions so, depends on following series. Depends-on: series-18447 ("net/iavf: enable interrupt polling") v2 changes: - rebase for 21.11 - Fix for 'random' Pallavi Kadam (3): net/iavf: build on W

[dpdk-dev] [PATCH v2 2/3] lib/net: fix support of random

2021-09-09 Thread Pallavi Kadam
IAVF PMD needs to generate a random MAC address if it is not configured by host. 'random' is now supported on Windows. Fixes: 16f0d03098cb ("net: build on Windows") Cc: f...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/net/rte_ether.c | 4

[dpdk-dev] [PATCH v2 3/3] doc: update iavf PMD and 21.11 release notes

2021-09-09 Thread Pallavi Kadam
Add documentation to support iavf PMD on Windows. Update the release notes for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/intel_vf.rst | 17 + doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 21 insertions(+)

[dpdk-dev] [PATCH v2 00/18] Fix spelling errors

2021-09-09 Thread Stephen Hemminger
After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments. v2 - checkpatch wants more than just subject remove autocorrect of historical text Stephen Hemminger (18): node: fix typos ipsec: fix spelling

[dpdk-dev] [PATCH v2 01/18] node: fix typos

2021-09-09 Thread Stephen Hemminger
Spelling errors in comments including doxygen Signed-off-by: Stephen Hemminger --- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node/ethdev_rx_priv.h b/lib/node/ethde

[dpdk-dev] [PATCH v2 02/18] ipsec: fix spelling errors

2021-09-09 Thread Stephen Hemminger
Lots of typos in comments found by codespell Signed-off-by: Stephen Hemminger --- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c| 2 +- lib/ipsec/sa.h| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 03/18] eventdev: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Typo in comment found by codespell Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index ee20b39f4b24..b5c2dc1427c6 100

[dpdk-dev] [PATCH v2 04/18] power: fix typo in comment

2021-09-09 Thread Stephen Hemminger
More spelling errors caught by codespell Signed-off-by: Stephen Hemminger --- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 1e8aeb84037c..402ed8c99b42 100644 --- a/lib/power

[dpdk-dev] [PATCH v2 05/18] rcu: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Another codespell find. Signed-off-by: Stephen Hemminger --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index 18811c1cc106..62a420a785fc 100644 --- a/lib/rcu/rte_rcu_qsbr.h +++ b/lib/rcu/rte_rcu_qsbr.

[dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

2021-09-09 Thread Stephen Hemminger
Found by running codespell on the bpf implementation. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_validate.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bpf/bpf_jit_x86.c b/lib/bpf/bpf_jit_x86.c index aa22ea78a01d..518513376a67

[dpdk-dev] [PATCH v2 07/18] acl: fix spelling errors

2021-09-09 Thread Stephen Hemminger
Lots of little typos in comments Signed-off-by: Stephen Hemminger --- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index 4089ab2a0462..f5739a475cf0 10064

[dpdk-dev] [PATCH v2 08/18] eal: fix typos in comments

2021-09-09 Thread Stephen Hemminger
Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_function_versioning.h b/lib/eal/include/rte_function

[dpdk-dev] [PATCH v2 09/18] net: fix spelling error in gtp comment

2021-09-09 Thread Stephen Hemminger
More codespell finds. Signed-off-by: Stephen Hemminger --- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h index 6a6f9b238db9..f22dbce47c65 100644 --- a/lib/net/rte_gtp.h +++ b/lib/net/rte_gtp.h @@ -64,9 +64,9 @@ s

[dpdk-dev] [PATCH v2 10/18] bbdev: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index fc37236195be..49a0de49d8df 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/li

[dpdk-dev] [PATCH v2 11/18] pipeline: fix spellin error in comment

2021-09-09 Thread Stephen Hemminger
Minor typo Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline.h b/lib/pipeline/rte_swx_pipeline.h index cd395ac39dbb..9bfc69b2bb4f 100644 --- a/lib/pipeline/rte_swx_pipeline.h +++

[dpdk-dev] [PATCH v2 12/18] hash: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index d5a95a6e009a..f5e9111f0264 100644 --- a/lib/hash/rte_thash.c +++ b/lib/ha

[dpdk-dev] [PATCH v2 13/18] rib: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index 96424e9c9f4f..4a6f29b0040d 100644 --- a/lib/rib/rte_rib6.c +++ b/lib/rib/rte_ri

[dpdk-dev] [PATCH v2 14/18] sched: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index a858f61f9548..329f4b2e7b48 100644 --- a/lib/sched/rte_sched.c +++ b/li

[dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment

2021-09-09 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index 8d875e932297..c36dfc705b04 100644 --- a/lib/vhost/rte_vhost.h +++

[dpdk-dev] [PATCH v2 16/18] ip_frag: fix typos

2021-09-09 Thread Stephen Hemminger
Minor typos in comment. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 69666c8b8271..4a89a5f5365a 100644 --- a/lib/ip_frag/rte_

[dpdk-dev] [PATCH v2 17/18] test-pmd: fix spelling errors in comments

2021-09-09 Thread Stephen Hemminger
More typos Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 82253bc75110..2628bd64dae6 100644

[dpdk-dev] [PATCH v2 18/18] test: fix spelling errors in comments

2021-09-09 Thread Stephen Hemminger
Lots of little typos. Signed-off-by: Stephen Hemminger --- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c

Re: [dpdk-dev] [PATCH v2 15/18] vhost: fix typo in comment

2021-09-09 Thread Maxime Coquelin
On 9/9/21 8:10 PM, Stephen Hemminger wrote: > Yet another spelling error found by codespell. > > Signed-off-by: Stephen Hemminger > --- > lib/vhost/rte_vhost.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h > index 8

[dpdk-dev] [PATCH] eal/ppc: replace rte_atomicXX ops with C11 atomic builtins

2021-09-09 Thread David Christensen
Replace existing PPC assembly code for rte_atomicXX ops with compiler atomic builtins as prevously adopted by DPDK (see [1] and [2]). This has the additional benefit of resolving a POWER10 build failure due to an outstanding gcc issue which fails on the existing PPC assembly code [3]. [1] https:/

Re: [dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

2021-09-09 Thread Dmitry Kozlyuk
2021-09-09 11:10 (UTC-0700), Stephen Hemminger: [...] > diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_validate.c > index 7b1291b382e9..3e7d3d730637 100644 > --- a/lib/bpf/bpf_validate.c > +++ b/lib/bpf/bpf_validate.c > @@ -1723,7 +1723,7 @@ static const struct bpf_ins_check ins_chk[UINT8_MAX +

Re: [dpdk-dev] [PATCH] app/test: fix event timer adapter create unit test

2021-09-09 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Monday, August 30, 2021 3:13 PM > To: dev@dpdk.org > Cc: Shijith Thotton ; jer...@marvell.com; > pbhagavat...@marvell.com; Carrillo, Erik G > Subject: [PATCH] app/test: fix event timer adapter create unit test > > Removed freeing of un

[dpdk-dev] [PATCH v3 0/5] drivers/net: add NXP ENETFEC driver

2021-09-09 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

[dpdk-dev] [PATCH v3 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-09-09 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- MAINTAINERS| 7 ++ doc/guides/nics/enetfec.rst

[dpdk-dev] [PATCH v3 2/5] net/enetfec: add UIO support

2021-09-09 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v3 3/5] net/enetfec: support queue configuration

2021-09-09 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 230 +-

[dpdk-dev] [PATCH v3 4/5] net/enetfec: add enqueue and dequeue support

2021-09-09 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v3 5/5] net/enetfec: add features

2021-09-09 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 ++ doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 17 - drivers/

[dpdk-dev] [PATCH v3 0/3] Support iavf PMD on Windows

2021-09-09 Thread Pallavi Kadam
This patch-set enables building the iavf PMD on Windows. Currently, it uses alarm functions so, depends on following series. Depends-on: series-18447 ("net/iavf: enable interrupt polling") v3 changes: - Fix doc build warning v2 changes: - Rebase for 21.11 - Fix for 'random

[dpdk-dev] [PATCH v3 1/3] net/iavf: build on Windows

2021-09-09 Thread Pallavi Kadam
- Enable IAVF PMD build on Windows - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting types - Fix for pointer and integer sign warnings using Clang compiler on Windows - Add extra cflags '-fno-asynchronous-unwind-tables' to avoid MinGW build error: Error: invalid regis

[dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random

2021-09-09 Thread Pallavi Kadam
IAVF PMD needs to generate a random MAC address if it is not configured by host. 'random' is now supported on Windows. Fixes: 16f0d03098cb ("net: build on Windows") Cc: f...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/net/rte_ether.c | 4

[dpdk-dev] [PATCH v3 3/3] doc: update iavf PMD and 21.11 release notes

2021-09-09 Thread Pallavi Kadam
Add documentation to support iavf PMD on Windows. Update the release notes for the same. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- doc/guides/nics/intel_vf.rst | 18 ++ doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 22 insertions(+)

Re: [dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

2021-09-09 Thread Stephen Hemminger
On Thu, 9 Sep 2021 22:49:56 +0300 Dmitry Kozlyuk wrote: > 2021-09-09 11:10 (UTC-0700), Stephen Hemminger: > [...] > > diff --git a/lib/bpf/bpf_validate.c b/lib/bpf/bpf_validate.c > > index 7b1291b382e9..3e7d3d730637 100644 > > --- a/lib/bpf/bpf_validate.c > > +++ b/lib/bpf/bpf_validate.c > > @@ -

[dpdk-dev] [PATCH v2 0/6] Use correct memory ordering in eal functions

2021-09-09 Thread Honnappa Nagarahalli
rte_eal_remote_launch and rte_eal_wait_lcore need to provide correct memory ordering to address the data communication from main core to worker core. There are 2 use cases: 1) All the store operations (meant for worker) by main core should be visible to worker core before the worker core runs the

[dpdk-dev] [PATCH v2 1/6] eal: reset lcore function pointer and argument

2021-09-09 Thread Honnappa Nagarahalli
In the rte_eal_remote_launch function, the lcore function pointer is checked for NULL. However, the pointer is never reset to NULL. Reset the lcore function pointer and argument after the worker has completed executing the lcore function. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng W

[dpdk-dev] [PATCH v2 4/6] eal: update rte_eal_wait_lcore definition

2021-09-09 Thread Honnappa Nagarahalli
Since the FINISHED state is removed, the API rte_eal_wait_lcore is updated to always return the status of the last function that ran in the worker core. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Feifei Wang --- lib/eal/common/eal_common_launch.c | 6 ++ lib/eal/include/rte_launch.h

[dpdk-dev] [PATCH v2 2/6] eal: ensure memory operations are visible to worker

2021-09-09 Thread Honnappa Nagarahalli
Ensure that the memory operations before the call to rte_eal_remote_launch are visible to the worker thread. Use the function pointer to execute in worker thread as the guard variable. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Reviewed-by: Feifei Wang --- lib/eal/freebsd/e

[dpdk-dev] [PATCH v2 3/6] eal: lcore state FINISHED is not required

2021-09-09 Thread Honnappa Nagarahalli
FINISHED state seems to be used to indicate that the worker's update of the 'state' is not visible to other threads. There seems to be no requirement to have such a state. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Reviewed-by: Feifei Wang --- drivers/event/dpaa2/dpaa2_even

[dpdk-dev] [PATCH v2 6/6] test/ring: use relaxed barriers for ring stress test

2021-09-09 Thread Honnappa Nagarahalli
wrk_cmd variable is used to signal the worker thread to start or stop the stress test loop. Relaxed barriers are used to achieve the same. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ola Liljedahl Reviewed-by: Feifei Wang --- app/test/test_ring_stress_impl.h | 18 +- 1 fil

[dpdk-dev] [PATCH v2 5/6] eal: ensure memory operations are visible to main

2021-09-09 Thread Honnappa Nagarahalli
Ensure that the memory operations in worker thread, that happen before it returns the status of the assigned function, are visible to the main thread. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Feifei Wang --- lib/eal/common/eal_common_launch.c | 2 -- lib/eal/freebsd/eal_thread.c

[dpdk-dev] [PATCH v6 00/10] Packet capture framework enhancements

2021-09-09 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

[dpdk-dev] [PATCH v6 01/10] librte_pcapng: add new library for writing pcapng files

2021-09-09 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v6 02/10] bpf: allow self-xor operation

2021-09-09 Thread Stephen Hemminger
When doing BPF filter program conversion, a common way to zero a register in single instruction is: xor r7,r7 The BPF validator would not allow this because the value of r7 was undefined. But after this operation it always zero. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_validate.c |

[dpdk-dev] [PATCH v6 03/10] bpf: add function to convert classic BPF to DPDK BPF

2021-09-09 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v6 04/10] bpf: add function to dump eBPF instructions

2021-09-09 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger --- lib/bpf/bpf_convert.c | 7 ++- lib/bpf/bpf_dump.c| 118 ++ lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 +++

[dpdk-dev] [PATCH v6 05/10] test: add test for bpf_convert

2021-09-09 Thread Stephen Hemminger
Add some functional tests for the Classic BPF to DPDK BPF converter. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 148 1 file changed, 148 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 527c06b80708..68b09067

[dpdk-dev] [PATCH v6 06/10] lib: pdump is not supported on Windows

2021-09-09 Thread Stephen Hemminger
The original version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. For now, just stop trying to build pdump on Windows. E

  1   2   >