Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test

Hi David, Since we have some discussion about the atomic operations now, I changed the commit message from "C11 atomics"(which has been widely used in previous commit) to "GCC atomic built-ins". What's your opinion about whether keeping the previous message for the consistency or using the new

[dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field

The new flow item allows PMD to offload IPv4 IHL field for matching, if hardware supports that operation. Signed-off-by: Gregory Etelson --- v2: replace UNSIGNED with COMMON_UNSIGNED following 21.08 API change. --- app/test-pmd/cmdline_flow.c | 13 - doc/guides/testpm

[dpdk-dev] [PATCH 1/2] common/cnxk: add support for UDP encapsulation

Adds support for UDP encapsulation in crypto_cn10k PMD. Signed-off-by: Srujana Challa --- drivers/common/cnxk/cnxk_security.c | 18 ++ drivers/common/cnxk/meson.build | 1 + 2 files changed, 19 insertions(+) diff --git a/drivers/common/cnxk/cnxk_security.c b/drivers/common

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for inline protocol

Adds support to allow udp-encap option for RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL mode also. Signed-off-by: Srujana Challa --- examples/ipsec-secgw/sa.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/examples/ipsec-secgw/sa.c b/examples/ip

Re: [dpdk-dev] [PATCH 2/3] mbuf: avoid cast-align warning in pktmbuf mtod offset macro

+Cc mbuf maintainers Please use --cc-cmd devtools/get-maintainer.sh to make it automatic. 13/07/2021 08:49, Eli Britstein: > In rte_pktmbuf_mtod_offset macro, there is a casting from char * to type > 't', which may cause cast-align warning when using gcc flags > '-Werror -Wcast-align': > > .../

Re: [dpdk-dev] [PATCH v4] ethdev: add IPv4 and L4 checksum RSS offload types

On 7/13/21 4:13 AM, Alvin Zhang wrote: > This patch defines new RSS offload types for IPv4 and > L4(TCP/UDP/SCTP) checksum, which are required when users want > to distribute packets based on the IPv4 or L4 checksum field. > > For example "flow create 0 ingress pattern eth / ipv4 / end > actions r

Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field

@Ori, could you review it, please. Thanks, Andrew. On 7/13/21 10:29 AM, Gregory Etelson wrote: > The new flow item allows PMD to offload IPv4 IHL field for matching, > if hardware supports that operation. > > Signed-off-by: Gregory Etelson > --- > v2: replace UNSIGNED with COMMON_UNSIGNED follo

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

Dne 2021-07-12 15:07, Ori Kam napsal: Hi Jan, -Original Message- From: Jan Viktorin Sent: Monday, July 12, 2021 12:46 AM On Sun, 11 Jul 2021 08:49:18 + Ori Kam wrote: > Hi Jan, Hi Ori, > > > > -Original Message- > > From: dev On Behalf Of Jan Viktorin > > Sent: Wednes

Re: [dpdk-dev] [PATCH v2] net/bnxt: fix nested lock at bond mode

On Sat, Jul 3, 2021 at 3:21 AM Weifeng Li wrote: > Bnxt register lsc callback (bond_ethdev_lsc_event_callback) when > working at bond mode. This callback will dead lock when lsc > interrupt triggered. > > lsc interrupt -> > bnxt_handle_async_event -> > bnxt_link_update_op -> > bond_ethdev_lsc_eve

[dpdk-dev] [PATCH] net/softnic: fix memory leak as profile is freed

From: Dapeng Yu In function softnic_table_action_profile_free(), the memory referenced by pointer "ap" in the instance of "struct softnic_table_action_profile" is not freed. This patch fixes it. Fixes: a737dd4e5863 ("net/softnic: add table action profile") Cc: sta...@dpdk.org Signed-off-by: Da

Re: [dpdk-dev] [PATCH v4 0/2] support VXLAN header the last 8-bits matching

On 7/7/21 11:09 AM, Rongwei Liu wrote: > This update adds support for the VXLAN the last 8-bits reserved > field matching when creating sw steering rules. > > Add a new testpmd pattern field 'last_rsvd' that supports the last > 8-bits matching of VXLAN header. The version fails to apply, please,

Re: [dpdk-dev] [PATCH] net/softnic: fix memory leak in parsing arguments

@Jasvinder, @Cristian, could you the patch, please. On 7/8/21 11:44 AM, dapengx...@intel.com wrote: > From: Dapeng Yu > > In function pmd_parse_args(), firmware path is duplicated from device > arguments as character string, but is never freed, which cause memory > leak. > > This patch changes

[dpdk-dev] [PATCH v6 00/26] net/mlx5: insertion rate optimization

This patch series optimize the flow insertion rate with adding local cache to index pool and list. For object which wants efficient index allocate and free, local cache will be very helpful. For index pool, two level cache is added, one as local and another as global. The global cache is able to

[dpdk-dev] [PATCH v6 01/26] net/mlx5: allow limiting the index pool maximum index

Some ipool instances in the driver are used as ID\index allocator and added other logic in order to work with limited index values. Add a new configuration for ipool specify the maximum index value. The ipool will ensure that no index bigger than the maximum value is provided. Use this configurat

[dpdk-dev] [PATCH v6 02/26] net/mlx5: add indexed pool local cache

For object which wants efficient index allocate and free, local cache will be very helpful. Two level cache is introduced to allocate and free the index more efficient. One as local and the other as global. The global cache is able to save all the allocated index. That means all the allocated inde

[dpdk-dev] [PATCH v6 03/26] net/mlx5: add index pool foreach define

In some cases, application may want to know all the allocated index in order to apply some operations to the allocated index. This commit adds the indexed pool functions to support foreach operation. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_utils.c | 96 +

[dpdk-dev] [PATCH v6 04/26] net/mlx5: support index pool non-lcore operations

This commit supports the index pool non-lcore operations with an extra cache and lcore lock. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_utils.c | 75 +-- drivers/net/mlx5/mlx5_utils.h | 3 +- 2 files changed, 56 insertions(+), 22

[dpdk-dev] [PATCH v6 05/26] net/mlx5: replace flow list with index pool

The flow list is used to save the create flows and to be used only when port closes all the flows need to be flushed. This commit takes advantage of the index pool foreach operation to flush all the allocated flows. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/linux/m

[dpdk-dev] [PATCH v6 06/26] net/mlx5: optimize modify header action memory

From: Matan Azrad Define the types of the modify header action fields to be with the minimum size needed for the optional values range. Signed-off-by: Matan Azrad Acked-by: Suanming Mou --- drivers/common/mlx5/linux/mlx5_glue.h | 1 + drivers/net/mlx5/linux/mlx5_flow_os.h | 3 ++- drivers/n

[dpdk-dev] [PATCH v6 07/26] net/mlx5: remove cache term from the list utility

From: Matan Azrad The internal mlx5 list tool is used mainly when the list objects need to be synchronized between multiple threads. The "cache" term is used in the internal mlx5 list API. Next enhancements on this tool will use the "cache" term for per thread cache management. To prevent conf

[dpdk-dev] [PATCH v6 08/26] net/mlx5: add per lcore cache to the list utility

From: Matan Azrad When mlx5 list object is accessed by multiple cores, the list lock counter is all the time written by all the cores what increases cache misses in the memory caches. In addition, when one thread accesses the list for add\remove\lookup operation, all the other threads coming to

[dpdk-dev] [PATCH v6 09/26] net/mlx5: minimize list critical sections

From: Matan Azrad The mlx5 internal list utility is thread safe. In order to synchronize list access between the threads, a RW lock is taken for the critical sections. The create\remove\clone\clone_free operations are in the critical sections. These operations are heavy and make the critical s

[dpdk-dev] [PATCH v6 10/26] net/mlx5: manage list cache entries release

From: Matan Azrad When a cache entry is allocated by lcore A and is released by lcore B, the driver should synchronize the cache list access of lcore A. The design decision is to manage a counter per lcore cache that will be increased atomically when the non-original lcore decreases the referenc

[dpdk-dev] [PATCH v6 11/26] net/mlx5: relax the list utility atomic operations

From: Matan Azrad The atomic operation in the list utility no need a barriers because the critical part are managed by RW lock. Relax them. Signed-off-by: Matan Azrad Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_utils.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[dpdk-dev] [PATCH v6 12/26] net/mlx5: allocate list memory by the create API

From: Matan Azrad Currently, the list memory was allocated by the list API caller. Move it to be allocated by the create API in order to save consistence with the hlist utility. Signed-off-by: Matan Azrad Acked-by: Suanming Mou --- drivers/net/mlx5/linux/mlx5_os.c | 105 +++

[dpdk-dev] [PATCH v6 14/26] common/mlx5: add list lcore share

As some actions in SW-steering is only memory and can be allowed to create duplicate objects, for lists which no need to check if there are existing same objects in other sub local lists, search the object only in local list will be more efficient. This commit adds the lcore share mode to list opt

[dpdk-dev] [PATCH v6 13/26] common/mlx5: move list utility to common

Hash list is planned to be implemented with the cache list code. This commit moves the list utility to common directory. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h | 2 + drivers/common/mlx5/mlx5_common_utils.c | 250 +++

[dpdk-dev] [PATCH v6 15/26] common/mlx5: call list callbacks with context

This commit optimizes to call the list callback functions with global context directly. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_utils.c | 24 ++--- drivers/common/mlx5/mlx5_common_utils.h | 36 drivers/net/mlx5/mlx5_flow.h| 9

[dpdk-dev] [PATCH v6 17/26] common/mlx5: allocate cache list memory individually

Currently, the list's local cache instance memory is allocated with the list. As the local cache instance array size is RTE_MAX_LCORE, most of the cases the system will only have very limited cores. allocate the instance memory individually per core will be more economic to the memory. This commit

[dpdk-dev] [PATCH v6 16/26] common/mlx5: add per-lcore cache to hash list utility

From: Matan Azrad Using the mlx5 list utility object in the hlist buckets. This patch moves the list utility object to the common utility, creates all the clone operations for all the hlist instances in the driver. Also adjust all the utility callbacks to be generic for both list and hlist. Si

[dpdk-dev] [PATCH v6 19/26] common/mlx5: support list non-lcore operations

This commit supports the list non-lcore operations with an extra sub-list and lock. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_utils.c | 92 + drivers/common/mlx5/mlx5_common_utils.h | 9 ++- 2 files changed, 71 insertions(+),

[dpdk-dev] [PATCH v6 18/26] common/mlx5: optimize cache list object memory

Currently, hash list uses the cache list as bucket list. The list in the buckets have the same name, ctx and callbacks. This wastes the memory. This commit abstracts all the name, ctx and callback members in the list to a constant struct and others to the inconstant struct, uses the wrapper functi

[dpdk-dev] [PATCH v6 20/26] net/mlx5: move modify header allocator to ipool

From: Matan Azrad Modify header actions are allocated by mlx5_malloc which has a big overhead of memory and allocation time. One of the action types under the modify header object is SET_TAG, The SET_TAG action is commonly not reused by the flows and each flow has its own value. Hence, the mlx

[dpdk-dev] [PATCH v6 21/26] net/mlx5: adjust the hash bucket size

With the new per core optimization to the list, the hash bucket size can be tuned to a more accurate number. This commit adjusts the hash bucket size. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 2 +- drivers/net/mlx5/mlx5.c | 2 +- drivers

[dpdk-dev] [PATCH v6 22/26] net/mlx5: enable index pool per-core cache

This commit enables the tag and header modify action index pool per-core cache in non-reclaim memory mode. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 4 +++- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 3 ++- 3 files chan

[dpdk-dev] [PATCH v6 23/26] net/mlx5: optimize hash list table allocate on demand

Currently, all the hash list tables are allocated during start up. Since different applications may only use dedicated limited actions, optimized the hash list table allocate on demand will save initial memory. This commit optimizes hash list table allocate on demand. Signed-off-by: Suanming Mou

[dpdk-dev] [PATCH v6 24/26] net/mlx5: change memory release configuration

This commit changes the index pool memory release configuration to 0 when memory reclaim mode is not required. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c in

[dpdk-dev] [PATCH v6 25/26] net/mlx5: optimize Rx queue match

As hrxq struct has the indirect table pointer, while matching the hrxq, better to use the hrxq indirect table instead of searching from the list. This commit optimizes the hrxq indirect table matching. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 18 +

[dpdk-dev] [PATCH v6 26/26] doc: add mlx5 multiple-thread flow insertion optimization

This commit adds the multiple-thread flow insertion optimization description. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst | 5 + doc/guides/rel_notes/release_21_08.rst | 1 + 2 files changed, 6 insertions(+) diff --git a/doc/guides/nics/mlx5

Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field

Hello, The patch was reviewed and approved by @Slava Ovsiienko Regards, Gregory > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, July 13, 2021 11:08 > To: Ori Kam > Cc: Slava Ovsiienko ; Xiaoyun Li > ; Gregory Etelson ; > dev@dpdk.org > Subject: Re: [PATCH v2] app/testpmd

Re: [dpdk-dev] [PATCH v2] dmadev: introduce DMA device library

On Mon, Jul 12, 2021 at 10:30 PM Bruce Richardson wrote: > > On Mon, Jul 12, 2021 at 10:04:07PM +0530, Jerin Jacob wrote: > > On Mon, Jul 12, 2021 at 7:02 PM Bruce Richardson > > wrote: > > > > > > On Mon, Jul 12, 2021 at 03:29:27PM +0530, Jerin Jacob wrote: > > > > On Sun, Jul 11, 2021 at 2:59 P

Re: [dpdk-dev] [PATCH v2] dmadev: introduce DMA device library

On Mon, Jul 12, 2021 at 9:21 PM Bruce Richardson wrote: > > On Sun, Jul 11, 2021 at 05:25:56PM +0800, Chengwen Feng wrote: > > This patch introduce 'dmadevice' which is a generic type of DMA > > device. > > > > The APIs of dmadev library exposes some generic operations which can > > enable configu

Re: [dpdk-dev] [EXT] [PATCH] test: fix crypto_op length for sessionless case

Hi Abhinandan, > > > > > Currently, private_data_offset for the sessionless is computed wrongly > > > which includes extra bytes added because of using sizeof(struct > > > rte_crypto_sym_xform) * 2) instead of (sizeof(union > > > rte_event_crypto_metadata)). Due to this buffer overflow, the > > > c

[dpdk-dev] [PATCH v2] app/testpmd: fix testpmd doesn't show RSS hash offload

This patch reapply Rx/Tx offloads configuration for all ports after the program configuring the device port. When the program configures the ports, the default Rx/Tx offloads are modified in dev->data->dev_conf. So it is need to reapply Rx/Tx offloads configuration after dev_configure. Fixes: ce8

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

On 7/13/21 11:18 AM, Havlík Martin wrote: > Dne 2021-07-12 15:07, Ori Kam napsal: >> Hi Jan, >> >>> -Original Message- >>> From: Jan Viktorin >>> Sent: Monday, July 12, 2021 12:46 AM >>> >>> On Sun, 11 Jul 2021 08:49:18 + >>> Ori Kam wrote: >>> >>> > Hi Jan, >>> >>> Hi Ori, >>> >>> >

Re: [dpdk-dev] [PATCH 2/3] net/bonding: fix not checked return value

On 7/9/21 3:09 AM, Min Hu (Connor) wrote: > > > 在 2021/7/8 21:20, Havlík Martin 写道: >> Dne 2021-07-08 14:43, Min Hu (Connor) napsal: >>> 在 2021/6/22 17:25, Martin Havlik 写道: Return value from bond_ethdev_8023ad_flow_set() is now checked and appropriate message is logged on error. >

Re: [dpdk-dev] [PATCH 1/3] net/bonding: fix proper return value check and correct log message

On 7/8/21 3:33 PM, Min Hu (Connor) wrote: > 在 2021/6/22 17:25, Martin Havlik 写道: >> Return value is now saved to errval and log message on error >> reports correct function name, doesn't use q_id which was out of context, >> and uses up-to-date errval. >> >> Fixes: 112891cd27e5 ("net/bonding: add d

Re: [dpdk-dev] [PATCH] net/virtio: fix Rx scatter offload

On 7/6/21 4:14 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF. > > If Rx scatter is not requested, ensure that provided Rx buffers on > each Rx queue are big enough to fit Rx packets up to configured MTU. > > Fix

Re: [dpdk-dev] [PATCH v2] net/vmxnet3: add interrupt support in MSI-X

On 7/8/21 5:02 PM, Jochen Behrens wrote: > Add support for MSI-X interrupt vectors to the vmxnet3 driver. > This will allow more efficient deployments in cloud environments. > > By default it will try to allocate 1 vector (0) for link > event and one MSI-X vector for each Rx queue. To simplify >

Re: [dpdk-dev] [PATCH v2 0/2] MLX5 PMD tuning

Hi, > -Original Message- > From: Ruifeng Wang > Sent: Wednesday, July 7, 2021 12:03 PM > To: Raslan Darawsheh ; Matan Azrad > ; Shahaf Shuler ; Slava > Ovsiienko > Cc: dev@dpdk.org; jer...@marvell.com; n...@arm.com; > honnappa.nagaraha...@arm.com; Ruifeng Wang > Subject: [PATCH v2 0/2]

Re: [dpdk-dev] [PATCH 1/3] net/octeontx2: handle link status when device stopped

On Wed, Jul 7, 2021 at 10:20 PM wrote: > > From: Satha Rao > > Set link status to down and don't fetch link status from kernel > when device in stopped state. > > Signed-off-by: Satha Rao Series Acked-by: Jerin Jacob Series applied to dpdk-next-net-mrvl/for-dpdk-main. Thanks. > --- > driver

Re: [dpdk-dev] [PATCH v5] vhost: check header for legacy dequeue offload

Hi Xiao, On 6/21/21 10:21 AM, Xiao Wang wrote: > When parsing the virtio net header and packet header for dequeue offload, > we need to perform sanity check on the packet header to ensure: > - No out-of-boundary memory access. > - The packet header and virtio_net header are valid and aligned.

Re: [dpdk-dev] [PATCH] net/softnic: fix memory leak in connection init

On 7/9/21 9:00 AM, dapengx...@intel.com wrote: > From: Dapeng Yu > > In function softnic_conn_init(), a block of memory is allocated as > connection buffer, but it is never freed in softnic_conn_free(), > which cause memory leak. > > This patch fixes it. > > Fixes: 7709a63bf178 ("net/softnic: a

Re: [dpdk-dev] [PATCH v4] ethdev: add IPv4 and L4 checksum RSS offload types

> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, July 13, 2021 3:55 PM > To: Zhang, AlvinX ; Zhang, Qi Z > ; ajit.khapa...@broadcom.com > Cc: dev@dpdk.org; Singh, Aman Deep > Subject: Re: [PATCH v4] ethdev: add IPv4 and L4 checksum RSS offload types > > On 7/13/21 4:13 AM,

Re: [dpdk-dev] [PATCH v2 0/3] features for hns3 PMD

On 7/10/21 4:58 AM, Min Hu (Connor) wrote: > This patchset contains 3 features for hns3 PMD: > add query basic info support for VF > support for VF modify VLAN filter state > support multiple TC MAC pause > > Chengchang Tang (2): > net/hns3: add query basic info support for VF > net/hns3: supp

Re: [dpdk-dev] RHEL 7 support

On 12/07/2021 18:34, Honnappa Nagarahalli wrote: > > >> >> Hi, >> >> I would like to open a discussion about RHEL 7 support in DPDK. >> How long do we want to support it in new DPDK versions? >> Can we drop RHEL 7 support starting DPDK 21.11? > I think the concerns were from Redhat and Intel. >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix offloads for the newly attached port

On 7/13/21 8:37 AM, Li, Xiaoyun wrote: > > >> -Original Message- >> From: stable On Behalf Of Viacheslav Ovsiienko >> Sent: Monday, July 12, 2021 20:41 >> To: dev@dpdk.org >> Cc: Singh, Aman Deep ; >> arybche...@solarflare.com; sta...@dpdk.org >> Subject: [dpdk-stable] [PATCH v3] app/tes

[dpdk-dev] [PATCH v5 0/2] support VXLAN header the last 8-bits matching

This update adds support for the VXLAN the last 8-bits reserved field matching when creating sw steering rules. Add a new testpmd pattern field 'last_rsvd' that supports the last 8-bits matching of VXLAN header. Rongwei Liu (2): net/mlx5: add VXLAN header the last 8-bits matching support app/

[dpdk-dev] [PATCH v5 2/2] app/testpmd: support VXLAN the last 8-bits field matching

Add a new testpmd pattern field 'last_rsvd' that supports the last 8-bits matching of VXLAN header. The examples for the "last_rsvd" pattern field are as below: 1. ...pattern eth / ipv4 / udp / vxlan last_rsvd is 0x80 / end ... This flow will exactly match the last 8-bits to be 0x80. 2. ...patt

[dpdk-dev] [PATCH v5 1/2] net/mlx5: add VXLAN header the last 8-bits matching support

This update adds support for the VXLAN header last 8-bits matching when creating steering rules. At the PCIe probe stage, we create a dummy VXLAN matcher using misc5 to check rdma-core library's capability. The logic is, group 0 depends on HCA_CAP to enable misc or misc5 for VXLAN matching while g

Re: [dpdk-dev] [PATCH v4 0/2] support VXLAN header the last 8-bits matching

Hi Andrew: Thanks for the review. V5 has been sent after rebasing. BR Rongwei > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, July 13, 2021 4:33 PM > To: Rongwei Liu ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; > NBU-Contact-Thomas Monjalon > Cc: dev@dpdk

Re: [dpdk-dev] [PATCH v5 2/2] app/testpmd: support VXLAN the last 8-bits field matching

Hi, [...] > diff --git a/doc/guides/rel_notes/release_21_08.rst > b/doc/guides/rel_notes/release_21_08.rst > index 6a902ef9ac..3fb17bbf77 100644 > --- a/doc/guides/rel_notes/release_21_08.rst > +++ b/doc/guides/rel_notes/release_21_08.rst > @@ -117,6 +117,11 @@ New Features >The experimental PM

Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field

On 7/13/21 11:54 AM, Gregory Etelson wrote: > Hello, > > The patch was reviewed and approved by @Slava Ovsiienko I don't see it in patchwork and mailing list. Slava, could you send formal Acked-by or Reviewed-by, please. Thanks, Andrew.

Re: [dpdk-dev] [PATCH v5 2/2] app/testpmd: support VXLAN the last 8-bits field matching

On 7/13/21 1:02 PM, Raslan Darawsheh wrote: > Hi, > [...] >> diff --git a/doc/guides/rel_notes/release_21_08.rst >> b/doc/guides/rel_notes/release_21_08.rst >> index 6a902ef9ac..3fb17bbf77 100644 >> --- a/doc/guides/rel_notes/release_21_08.rst >> +++ b/doc/guides/rel_notes/release_21_08.rst >> @@ -

[dpdk-dev] [PATCH v2] net/softnic: fix memory leak in parsing arguments

From: Dapeng Yu In function pmd_parse_args(), firmware path is duplicated from device arguments as character string, but is never freed, which cause memory leak. This patch changes the type of firmware member of struct pmd_params to character array, to make memory resource release unnecessary, a

Re: [dpdk-dev] [PATCH v2] net/softnic: fix memory leak in parsing arguments

On 7/13/21 1:08 PM, dapengx...@intel.com wrote: > From: Dapeng Yu > > In function pmd_parse_args(), firmware path is duplicated from device > arguments as character string, but is never freed, which cause memory > leak. > > This patch changes the type of firmware member of struct pmd_params to >

[dpdk-dev] [Bug 754] quick question about including netinet/ip.h in rte_ethdev.h

https://bugs.dpdk.org/show_bug.cgi?id=754 Bug ID: 754 Summary: quick question about including netinet/ip.h in rte_ethdev.h Product: DPDK Version: 19.11 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [PATCH v4] ethdev: add IPv4 and L4 checksum RSS offload types

On 7/13/21 12:38 PM, Zhang, AlvinX wrote: >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, July 13, 2021 3:55 PM >> To: Zhang, AlvinX ; Zhang, Qi Z >> ; ajit.khapa...@broadcom.com >> Cc: dev@dpdk.org; Singh, Aman Deep >> Subject: Re: [PATCH v4] ethdev: add IPv4 and L4 che

[dpdk-dev] [PATCH 1/3] crypto/octeontx2: fix member overlap

The member 'dir' should not overlap with 'ip'. Usage of union for all members would mean dir would get corrupt. Fixes: e91b4f45ff54 ("net/octeontx2: support anti-replay for security session") Cc: adwiv...@marvell.com Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_security.h | 10

[dpdk-dev] [PATCH 2/3] net/octeontx2: add locking for inline IPsec tbl updates

Add locking for IPsec table updates. Fixed error handling to clear SA entry if the SA population functions encounters any error. Signed-off-by: Anoob Joseph --- drivers/net/octeontx2/otx2_ethdev.h | 2 + drivers/net/octeontx2/otx2_ethdev_sec.c | 83 + 2 file

[dpdk-dev] [PATCH 3/3] net/octeontx2: clear SA valid during session destroy

SA table entry would be reserved for inline inbound operations. Clear valid bit of the SA so that CPT would treat SA entry as invalid. Also, move setting of valid bit to the end in case of session_create() to eliminate possibility of hardware seeing partial data. Signed-off-by: Anoob Joseph ---

Re: [dpdk-dev] [PATCH v5 1/2] net/mlx5: add VXLAN header the last 8-bits matching support

Hi, > -Original Message- > From: Rongwei Liu > Sent: Tuesday, July 13, 2021 12:55 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Shahaf Shuler > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v5 1/2] net/mlx5: add VXLAN header the last 8-b

Re: [dpdk-dev] [PATCH v2] net/softnic: fix memory leak in parsing arguments

Adding list and maintainers back. On 7/13/21 1:18 PM, Yu, DapengX wrote: >> -Original Message- >> From: Andrew Rybchenko >> Sent: Tuesday, July 13, 2021 6:11 PM >> To: Yu, DapengX ; Singh, Jasvinder >> ; Dumitrescu, Cristian >> >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [dpdk-d

[dpdk-dev] [Bug 755] Build failure in compress_isal on aarch64

https://bugs.dpdk.org/show_bug.cgi?id=755 Bug ID: 755 Summary: Build failure in compress_isal on aarch64 Product: DPDK Version: unspecified Hardware: ARM OS: Linux Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH v6 0/2] support VXLAN header the last 8-bits matching

This update adds support for VXLAN the last 8-bits reserved field matching when creating sw steering rules. Add a new testpmd pattern field 'last_rsvd' that supports the last 8-bits matching of VXLAN header. Rongwei Liu (2): net/mlx5: support matching on the reserved field of VXLAN app/testpm

[dpdk-dev] [PATCH v6 2/2] app/testpmd: support VXLAN header last 8-bits matching

Add a new testpmd pattern field 'last_rsvd' that supports the last 8-bits matching of VXLAN header. The examples for the "last_rsvd" pattern field are as below: 1. ...pattern eth / ipv4 / udp / vxlan last_rsvd is 0x80 / end ... This flow will exactly match the last 8-bits to be 0x80. 2. ...patt

[dpdk-dev] [PATCH v6 1/2] net/mlx5: support matching on the reserved field of VXLAN

This adds matching on the reserved field of VXLAN header (the last 8-bits). The capability from rdma-core is detected by creating a dummy matcher using misc5 when the device is probed. For non-zero groups and FDB domain, the capability is detected from rdma-core, meanwhile for NIC domain group zer

Re: [dpdk-dev] [PATCH v5 1/2] net/mlx5: add VXLAN header the last 8-bits matching support

Hi Raslan: V6 was sent to address the comment. BTW, title " Added support for matching on the reserved filed of VXLAN header (last 8-bits)" is too long to pass the git-log-check. Thanks. BR Rongwei > -Original Message- > From: Raslan Darawsheh > Sent: Tuesday, Ju

Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

On Tue, 13 Jul 2021 12:26:35 +0300 Andrew Rybchenko wrote: > On 7/13/21 11:18 AM, Havlík Martin wrote: > > Dne 2021-07-12 15:07, Ori Kam napsal: > >> Hi Jan, > >> > >>> -Original Message- > >>> From: Jan Viktorin > >>> Sent: Monday, July 12, 2021 12:46 AM > >>> > >>> On Sun, 11 Jul 2

Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field

> -Original Message- > From: Gregory Etelson > Sent: Tuesday, July 13, 2021 10:29 > To: dev@dpdk.org; andrew.rybche...@oktetlabs.ru > Cc: Gregory Etelson ; Slava Ovsiienko > ; Ori Kam ; Xiaoyun Li > > Subject: [PATCH v2] app/testpmd: add flow item to match on IPv4 > version_ihl field > >

Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field

On 7/13/21 2:11 PM, Slava Ovsiienko wrote: >> -Original Message- >> From: Gregory Etelson >> Sent: Tuesday, July 13, 2021 10:29 >> To: dev@dpdk.org; andrew.rybche...@oktetlabs.ru >> Cc: Gregory Etelson ; Slava Ovsiienko >> ; Ori Kam ; Xiaoyun Li >> >> Subject: [PATCH v2] app/testpmd: add

Re: [dpdk-dev] [PATCH 1/2] common/cnxk: add support for rte flow item raw

On Mon, Jul 12, 2021 at 12:19 PM wrote: > > From: Satheesh Paul > > Add roc API for rte_flow_item_raw to parse custom L2 and L3 protocols. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar Kokkilagadda Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk

[dpdk-dev] [pull-request] dpdk-next-net-mrvl for for-next-net v21.08 - RC2

The following changes since commit a95bbb72623c310df4d0c8ad45c2ee06f538e01b:   version: 21.08-rc1 (2021-07-10 12:01:52 +0200) are available in the Git repository at:   http://dpdk.org/git/next/dpdk-next-net-mrvl for you to fetch changes up to 97f8b1e173423ed3b68cbdfe49c18bd83410f610:   net/cnx

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: support VXLAN header last 8-bits matching

Hi, > -Original Message- > From: Rongwei Liu > Sent: Tuesday, July 13, 2021 1:50 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Xiaoyun Li > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v6 2/2] app/testpmd: support VXLAN header last 8-bit

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: support VXLAN header last 8-bits matching

Hi Raslan: Sound good. Thanks 获取 Outlook for iOS 发件人: Raslan Darawsheh 发送时间: Tuesday, July 13, 2021 7:37:52 PM 收件人: Rongwei Liu ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; NBU-Contact-Thomas Monjalon ; Xiaoyun Li 抄送: dev@dpdk.o

Re: [dpdk-dev] [PATCH v6 1/2] net/mlx5: support matching on the reserved field of VXLAN

Hi, > -Original Message- > From: Rongwei Liu > Sent: Tuesday, July 13, 2021 1:50 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Shahaf Shuler > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v6 1/2] net/mlx5: support matching on the reserve

Re: [dpdk-dev] [PATCH v6 1/2] net/mlx5: support matching on the reserved field of VXLAN

Hi Raslan: Starting feom v5, rebase is already done. Do we have new conflicts now? 获取 Outlook for iOS 发件人: Raslan Darawsheh 发送时间: Tuesday, July 13, 2021 7:40:37 PM 收件人: Rongwei Liu ; Matan Azrad ; Slava Ovsiienko ; Ori Kam ; NBU-Co

[dpdk-dev] [PATCH v7 0/2] support VXLAN header the last 8-bits matching

This update adds support for VXLAN the last 8-bits reserved field matching when creating sw steering rules. Rongwei Liu (2): net/mlx5: support matching on the reserved field of VXLAN app/testpmd: support matching the reserved filed for VXLAN app/test-pmd/cmdline_flow.c | 10

[dpdk-dev] [PATCH v7 1/2] net/mlx5: support matching on the reserved field of VXLAN

This adds matching on the reserved field of VXLAN header (the last 8-bits). The capability from rdma-core is detected by creating a dummy matcher using misc5 when the device is probed. For non-zero groups and FDB domain, the capability is detected from rdma-core, meanwhile for NIC domain group zer

[dpdk-dev] [PATCH v7 2/2] app/testpmd: support matching the reserved filed for VXLAN

Add a new testpmd pattern field 'last_rsvd' that supports the last 8-bits matching of VXLAN header. The examples for the "last_rsvd" pattern field are as below: 1. ...pattern eth / ipv4 / udp / vxlan last_rsvd is 0x80 / end ... This flow will exactly match the last 8-bits to be 0x80. 2. ...patt

Re: [dpdk-dev] [PATCH v6 1/2] net/mlx5: support matching on the reserved field of VXLAN

Hi Raslan: V7 was sent: 1. app/testpmd title changed per your comments. 2. UNSIGNED to newest COMMON_UNSIGNED to fix compilation error. Thanks BR Rongwei > -Original Message- > From: Raslan Darawsheh > Sent: Tuesday, July 13, 2021 7:41 PM > To: Rongwei Liu

[dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

This patch introduce 'dmadevice' which is a generic type of DMA device. The APIs of dmadev library exposes some generic operations which can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng --- v3: * rm reset and fill_sg ops. * rm MT-safe capabilities. * add submit

Re: [dpdk-dev] [PATCH 1/2] security: enforce semantics for Tx inline processing

Adding more rte_security and PMD maintainers into the loop. > > > > > > > > > > > For Tx inline processing, when > > > > > > > > > > > RTE_SECURITY_TX_OLOAD_NEED_MDATA is > > > > > > > > > > > set, rte_security_set_pkt_metadata() needs to be called > > > > > > > > > > > for pkts > > > > > > >

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

On 7/9/21 8:29 PM, Ferruh Yigit wrote: > There is a confusion on setting max Rx packet length, this patch aims to > clarify it. > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > 'uint32_t max_rx_pkt_len' filed of the config struct 'struct > rte_eth_conf'. > > Also 'rte_eth_dev_se

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: support matching the reserved filed for VXLAN

> -Original Message- > From: Rongwei Liu > Sent: Tuesday, July 13, 2021 3:09 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Xiaoyun Li > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v7 2/2] app/testpmd: support matching the reserved file

[dpdk-dev] [PATCH v1] net/mlx5: fix RSS selection flags settings

The L3 protocol of the RSS type may be different than the one defined in the flow. If the RSS type also includes L4 protocol type, the selection flags for the RX hash will be set with SPORT/DPORT without setting SRC/DST IP, but this combination is not supported by the rte API. When using indirect

Re: [dpdk-dev] [PATCH v7 1/2] net/mlx5: support matching on the reserved field of VXLAN

> -Original Message- > From: Rongwei Liu > Sent: Tuesday, July 13, 2021 3:09 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon ; Shahaf Shuler > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v7 1/2] net/mlx5: support matching on the reserved f

Re: [dpdk-dev] [PATCH v3] dmadev: introduce DMA device library

Thank you for your valuable comments, and I think we've taken a big step forward. @andrew Could you provide the copyright line so that I can add it to relevant file. @burce, jerin Some unmodified review comments are returned here: 1. COMMENT: We allow up to 100 characters per line for DPDK co

Re: [dpdk-dev] [PATCH v7 0/2] support VXLAN header the last 8-bits matching

On 7/13/21 3:09 PM, Rongwei Liu wrote: > This update adds support for VXLAN the last 8-bits reserved > field matching when creating sw steering rules. > > Rongwei Liu (2): > net/mlx5: support matching on the reserved field of VXLAN > app/testpmd: support matching the reserved filed for VXLAN >

[dpdk-dev] [PATCH] net/bnxt: fix to clear cached value of stats in clear stats

From: Kalesh AP As part of the workaround put in the commit "219842b9990c", driver caches the last read stats values from the hardware. But this is not cleared during the clear stats operation. This results in showing up stale stats values while reading the stats after the clear operation. Fixes

  1   2   3   >