Re: [dpdk-dev] [PATCH v2 5/7] power: support callbacks for multiple Rx queues

2021-06-28 Thread David Marchand
On Fri, Jun 25, 2021 at 4:01 PM Anatoly Burakov wrote: > diff --git a/doc/guides/prog_guide/power_man.rst > b/doc/guides/prog_guide/power_man.rst > index c70ae128ac..38f876466a 100644 > --- a/doc/guides/prog_guide/power_man.rst > +++ b/doc/guides/prog_guide/power_man.rst [snip] > +* Not all Eth

[dpdk-dev] [PATCH v2 0/2] add Rx/Tx offload paths for ICE AVX2

2021-06-28 Thread Wenzhuo Lu
Add specific paths for RX/TX AVX2, called offload paths. In these paths, support the HW offload features, like, checksum, VLAN, RSS offload. These paths are chosen automatically according to the configuration. v2: - fdir should be supported by offload and normal path. Wenzhuo Lu (2): net/ice:

[dpdk-dev] [PATCH v2 1/2] net/ice: add Tx AVX2 offload path

2021-06-28 Thread Wenzhuo Lu
Add a specific path for TX AVX2. In this path, support the HW offload features, like, checksum insertion, VLAN insertion. This path is chosen automatically according to the configuration. 'inline' is used, then the duplicate code is generated by the compiler. Signed-off-by: Wenzhuo Lu --- drive

[dpdk-dev] [PATCH v2 2/2] net/ice: add Rx AVX2 offload path

2021-06-28 Thread Wenzhuo Lu
Add a specific path for RX AVX2. In this path, support the HW offload features, like, checksum, VLAN stripping, RSS hash. This path is chosen automatically according to the configuration. 'inline' is used, then the duplicate code is generated by the compiler. Signed-off-by: Wenzhuo Lu --- doc/g

Re: [dpdk-dev] [PATCH v2 1/2] net/ice: factorize firmware loading

2021-06-28 Thread David Marchand
On Thu, Jun 3, 2021 at 6:55 PM David Marchand wrote: > > Both "normal" and "dcf" inits have their copy of some firmware loading > code. > > The DSN query is moved in specific parts for the "normal" and "dcf" init. > > A common helper ice_load_pkg is then introduced and takes an adapter > pointer a

Re: [dpdk-dev] [PATCH v3] net/mlx5: add TCP and IPv6 to supported flow items list in Windows

2021-06-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Tal Shnaiderman > Sent: Tuesday, June 22, 2021 6:35 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad > ; Raslan Darawsheh ; Asaf Penso > ; Odi Assli > Subject: [PATCH v3] net/mlx5: add TCP and IPv6 to supported flow items list > in Wi

Re: [dpdk-dev] [PATCH] net/mlx5: fix meter policy with RSS action

2021-06-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Li Zhang > Sent: Wednesday, June 23, 2021 10:25 AM > To: Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; Roni > Bar Yanai ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix

Re: [dpdk-dev] [PATCH v2 00/17] Add CPT in Marvell CNXK common driver

2021-06-28 Thread Akhil Goyal
> This patchset adds initial support for CPT in common code for Marvell CN10K > SoC. > > CPT is the hardware cryptographic block available in 'cnxk' family SoC. CPT, > with its microcoded engines can support symmetric, asymmetric and IPsec > operations. CPT can associate with NIX (rte_ethdev) to e

[dpdk-dev] [PATCH] mem: fix mem leak issue when attaching a PCI device without driver to DPDK

2021-06-28 Thread RickZhong
when trying to attach a PCI device without driver to DPDK, the 'dev' is malloced but not freed. Signed-off-by: RickZhong --- drivers/bus/pci/linux/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c index 0dc99e9cb..909502ecc 100644

Re: [dpdk-dev] [PATCH v2 00/17] Add CPT in Marvell CNXK common driver

2021-06-28 Thread Akhil Goyal
> > This patchset adds initial support for CPT in common code for Marvell > CN10K > > SoC. > > > > CPT is the hardware cryptographic block available in 'cnxk' family SoC. CPT, > > with its microcoded engines can support symmetric, asymmetric and IPsec > > operations. CPT can associate with NIX (rte

[dpdk-dev] [PATCH] fix l2fwd --no-mac-updating not working issue

2021-06-28 Thread RickZhong
The original disable mac updating codes were removed by mistake. Signed-off-by: RickZhong --- examples/l2fwd/main.c | 4 1 file changed, 4 insertions(+) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 32d405e65..69d0087dc 100644 --- a/examples/l2fwd/main.c +++ b/examples/l

Re: [dpdk-dev] [PATCH] mem: fix mem leak issue when attaching a PCI device without driver to DPDK

2021-06-28 Thread David Marchand
On Mon, Jun 28, 2021 at 11:03 AM RickZhong wrote: > > when trying to attach a PCI device without driver to DPDK, > the 'dev' is malloced but not freed. > > Signed-off-by: RickZhong Thanks for the patch. I already submitted a similar fix. https://patchwork.dpdk.org/project/dpdk/patch/20210616065

Re: [dpdk-dev] [PATCH] fix l2fwd --no-mac-updating not working issue

2021-06-28 Thread David Marchand
On Mon, Jun 28, 2021 at 11:09 AM RickZhong wrote: > > The original disable mac updating codes were removed by mistake. > > Signed-off-by: RickZhong > --- > examples/l2fwd/main.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c > index 32d

Re: [dpdk-dev] [PATCH v2 5/7] power: support callbacks for multiple Rx queues

2021-06-28 Thread Burakov, Anatoly
On 28-Jun-21 8:10 AM, David Marchand wrote: On Fri, Jun 25, 2021 at 4:01 PM Anatoly Burakov wrote: diff --git a/doc/guides/prog_guide/power_man.rst b/doc/guides/prog_guide/power_man.rst index c70ae128ac..38f876466a 100644 --- a/doc/guides/prog_guide/power_man.rst +++ b/doc/guides/prog_guide/po

Re: [dpdk-dev] dmadev discussion summary

2021-06-28 Thread Bruce Richardson
On Sat, Jun 26, 2021 at 11:59:49AM +0800, fengchengwen wrote: > Hi, all > I analyzed the current DPAM DMA driver and drew this summary in conjunction > with the previous discussion, and this will as a basis for the V2 > implementation. > Feedback is welcome, thanks > Fantastic review and summa

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-28 Thread Andrew Rybchenko
On 6/24/21 1:34 AM, Jie Zhou wrote: Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Why are two a bit difference Signed-off-by used in these patches? Can we drop the first one and keep the second one which matches E-mail From?

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-28 Thread Andrew Rybchenko
On 6/28/21 1:01 PM, Andrew Rybchenko wrote: On 6/24/21 1:34 AM, Jie Zhou wrote: Enable building libraries that testpmd depends on for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou Why are two a bit difference Signed-off-by used in these patches? Can we drop the first one and keep

Re: [dpdk-dev] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return type name

2021-06-28 Thread Andrew Rybchenko
On 6/24/21 1:34 AM, Jie Zhou wrote: Replace parse_fec_mode misleading return type name mode with fec_capa Fixes: b19da32e3151 ("app/testpmd: add FEC command") Cc: sta...@dpdk.org Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou [snip] diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/test

[dpdk-dev] [PATCH] net/mlx5: fix the modify field action flag checking

2021-06-28 Thread Jiawei Wang
The introduced MODIFY_FIELD action was used to manipulate the packet header field through copy or set operations. These modify header actions should be counted as one action in low level, the current code used wrong actions flags checking for modify field action. This patch update the action flag

Re: [dpdk-dev] [PATCH v3] app/testpmd: send failure logs to stderr

2021-06-28 Thread Andrew Rybchenko
On 6/18/21 11:32 AM, Li, Xiaoyun wrote: -Original Message- From: Andrew Rybchenko Sent: Thursday, June 17, 2021 22:20 To: Li, Xiaoyun ; Ori Kam Cc: dev@dpdk.org; Richardson, Bruce ; Yigit, Ferruh ; Singh, Aman Deep Subject: [PATCH v3] app/testpmd: send failure logs to stderr Running w

Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log

2021-06-28 Thread Andrew Rybchenko
Hi Heinrich, could you take a look at the patch? Thanks, Andrew. On 5/18/21 1:41 PM, Ferruh Yigit wrote: Logging should be converted to dynamic log. Signed-off-by: Ferruh Yigit --- drivers/net/nfp/nfp_net_logs.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/nfp/nfp

Re: [dpdk-dev] dmadev discussion summary

2021-06-28 Thread Ananyev, Konstantin
Hi everyone, > On Sat, Jun 26, 2021 at 11:59:49AM +0800, fengchengwen wrote: > > Hi, all > > I analyzed the current DPAM DMA driver and drew this summary in > > conjunction > > with the previous discussion, and this will as a basis for the V2 > > implementation. > > Feedback is welcome, th

[dpdk-dev] double free mbuf causing Data Coverage Problem

2021-06-28 Thread ??????
At dpdk19.08, I executed twice for the same mbuf by rte_pktmbuf_free_seg(), which stores two identical pointers in the cache, causes the device to be overwritten when I apply for mbuf consecutively, because rte_pktbuf_free_seg guarantees refcnt==1 after the mbuf is released. Why do you want to d

Re: [dpdk-dev] [PATCH v2 1/7] power_intrinsics: use callbacks for comparison

2021-06-28 Thread Ananyev, Konstantin
> Previously, the semantics of power monitor were such that we were > checking current value against the expected value, and if they matched, > then the sleep was aborted. This is somewhat inflexible, because it only > allowed us to check for a specific value. > > This commit replaces the comp

Re: [dpdk-dev] Experimental symbols in kni lib

2021-06-28 Thread Ferruh Yigit
On 6/25/2021 2:26 PM, Igor Ryzhov wrote: > Hi Ferruh, all, > > Let's please discuss another approach to setting KNI link status before > making this API stable: > http://patches.dpdk.org/project/dpdk/patch/20190925093623.18419-1-iryz...@nfware.com/ > > I explained the problem with the current imp

Re: [dpdk-dev] [PATCH v2 3/7] eal: add power monitor for multiple events

2021-06-28 Thread Ananyev, Konstantin
> Use RTM and WAITPKG instructions to perform a wait-for-writes similar to > what UMWAIT does, but without the limitation of having to listen for > just one event. This works because the optimized power state used by the > TPAUSE instruction will cause a wake up on RTM transaction abort, so if >

[dpdk-dev] [PATCH v3 0/7] Enhancements for PMD power management

2021-06-28 Thread Anatoly Burakov
This patchset introduces several changes related to PMD power management: - Changed monitoring intrinsics to use callbacks as a comparison function, based on previous patchset [1] but incorporating feedback [2] - this hopefully will make it possible to add support for .get_monitor_addr in virt

[dpdk-dev] [PATCH v3 1/7] power_intrinsics: use callbacks for comparison

2021-06-28 Thread Anatoly Burakov
Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value. This commit replaces the comparison with a us

[dpdk-dev] [PATCH v3 2/7] net/af_xdp: add power monitor support

2021-06-28 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 33 + 1 file changed, 33 insertions(+) diff --git a/drivers/net/af_xdp/rte_e

[dpdk-dev] [PATCH v3 3/7] eal: add power monitor for multiple events

2021-06-28 Thread Anatoly Burakov
Use RTM and WAITPKG instructions to perform a wait-for-writes similar to what UMWAIT does, but without the limitation of having to listen for just one event. This works because the optimized power state used by the TPAUSE instruction will cause a wake up on RTM transaction abort, so if we add the a

[dpdk-dev] [PATCH v3 4/7] power: remove thread safety from PMD power API's

2021-06-28 Thread Anatoly Burakov
Currently, we expect that only one callback can be active at any given moment, for a particular queue configuration, which is relatively easy to implement in a thread-safe way. However, we're about to add support for multiple queues per lcore, which will greatly increase the possibility of various

[dpdk-dev] [PATCH v3 5/7] power: support callbacks for multiple Rx queues

2021-06-28 Thread Anatoly Burakov
Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queues per core. The PMD power management mechanism relies on ethdev Rx callbacks, so it is very difficult

[dpdk-dev] [PATCH v3 6/7] power: support monitoring multiple Rx queues

2021-06-28 Thread Anatoly Burakov
Use the new multi-monitor intrinsic to allow monitoring multiple ethdev Rx queues while entering the energy efficient power state. The multi version will be used unconditionally if supported, and the UMWAIT one will only be used when multi-monitor is not supported by the hardware. Signed-off-by: A

[dpdk-dev] [PATCH v3 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-06-28 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation, and always mark the last queue in qconf as the power save queue. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 39 +++---

Re: [dpdk-dev] [PATCH v2 3/7] eal: add power monitor for multiple events

2021-06-28 Thread Burakov, Anatoly
On 28-Jun-21 1:37 PM, Ananyev, Konstantin wrote: Use RTM and WAITPKG instructions to perform a wait-for-writes similar to what UMWAIT does, but without the limitation of having to listen for just one event. This works because the optimized power state used by the TPAUSE instruction will cause a

Re: [dpdk-dev] dmadev discussion summary

2021-06-28 Thread Bruce Richardson
On Mon, Jun 28, 2021 at 12:14:31PM +0100, Ananyev, Konstantin wrote: > > Hi everyone, > > > On Sat, Jun 26, 2021 at 11:59:49AM +0800, fengchengwen wrote: > > > Hi, all > > > I analyzed the current DPAM DMA driver and drew this summary in > > > conjunction > > > with the previous discussion, an

Re: [dpdk-dev] [PATCH v3] kni: rework rte_kni_update_link using ioctl

2021-06-28 Thread Ferruh Yigit
On 10/27/2019 8:16 PM, Igor Ryzhov wrote: > Hi Ferruh, Dan, > > Sure, I remember last year discussion but now I see the problem in current > implementation. > > Ferruh, here is an example: > > We have a thread in the application that processes KNI commands from the > kernel. > It receives config

Re: [dpdk-dev] [PATCH v2 3/7] eal: add power monitor for multiple events

2021-06-28 Thread Ananyev, Konstantin
> On 28-Jun-21 1:37 PM, Ananyev, Konstantin wrote: > > > >> Use RTM and WAITPKG instructions to perform a wait-for-writes similar to > >> what UMWAIT does, but without the limitation of having to listen for > >> just one event. This works because the optimized power state used by the > >> TPAUSE i

Re: [dpdk-dev] [PATCH v3] kni: rework rte_kni_update_link using ioctl

2021-06-28 Thread Igor Ryzhov
Thanks Ferruh, I'll send an update later this week. I also want to add a "Suggested-by: Dan Gora " as it was his idea. Dan, please let me know if you don't want this tag to be added. Thanks, Igor On Mon, Jun 28, 2021 at 3:55 PM Ferruh Yigit wrote: > On 10/27/2019 8:16 PM, Igor Ryzhov wrote: >

Re: [dpdk-dev] [PATCH v2 3/7] eal: add power monitor for multiple events

2021-06-28 Thread Burakov, Anatoly
On 28-Jun-21 1:58 PM, Ananyev, Konstantin wrote: On 28-Jun-21 1:37 PM, Ananyev, Konstantin wrote: Use RTM and WAITPKG instructions to perform a wait-for-writes similar to what UMWAIT does, but without the limitation of having to listen for just one event. This works because the optimized pow

Re: [dpdk-dev] [PATCH v3 6/7] power: support monitoring multiple Rx queues

2021-06-28 Thread Ananyev, Konstantin
> Use the new multi-monitor intrinsic to allow monitoring multiple ethdev > Rx queues while entering the energy efficient power state. The multi > version will be used unconditionally if supported, and the UMWAIT one > will only be used when multi-monitor is not supported by the hardware. > > S

Re: [dpdk-dev] [PATCH v3 6/7] power: support monitoring multiple Rx queues

2021-06-28 Thread Burakov, Anatoly
On 28-Jun-21 2:29 PM, Ananyev, Konstantin wrote: Use the new multi-monitor intrinsic to allow monitoring multiple ethdev Rx queues while entering the energy efficient power state. The multi version will be used unconditionally if supported, and the UMWAIT one will only be used when multi-monit

Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on

2021-06-28 Thread Tyler Retzlaff
On Mon, Jun 28, 2021 at 01:35:09PM +0300, Andrew Rybchenko wrote: > On 6/28/21 1:01 PM, Andrew Rybchenko wrote: > >On 6/24/21 1:34 AM, Jie Zhou wrote: > >>Enable building libraries that testpmd depends on for Windows > >> > >>Signed-off-by: Jie Zhou > >>Signed-off-by: Jie Zhou > > > >Why are two

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/4] compress/mlx5: fix constant size in QP creation

2021-06-28 Thread Michael Baum
External email: Use caution opening links or attachments > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, June 23, 2021 9:48 AM > To: Michael Baum > Cc: dev@dpdk.org; sta...@dpdk.org; Matan Azrad ; > Raslan Darawsheh ; Slava Ovsiienko > > Subject: Re: [dpdk-stable] [PATCH

Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK

2021-06-28 Thread Burakov, Anatoly
On 18-Jun-21 10:04 AM, David Marchand wrote: On Fri, Jun 18, 2021 at 9:49 AM Lin, Xueqin wrote: Suggest listing demo code and tool capture information for user to try if tool works, also add this part into doc. # Also, Please update the release note for this feature. Sure, we can update t

Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK

2021-06-28 Thread Jerin Jacob
On Mon, Jun 28, 2021 at 7:52 PM Burakov, Anatoly wrote: > > On 18-Jun-21 10:04 AM, David Marchand wrote: > > On Fri, Jun 18, 2021 at 9:49 AM Lin, Xueqin wrote: > Suggest listing demo code and tool capture information for user to try if > >>> tool works, also add this part into doc. > >

Re: [dpdk-dev] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode return type name

2021-06-28 Thread Tyler Retzlaff
On Mon, Jun 28, 2021 at 01:55:02PM +0300, Andrew Rybchenko wrote: > On 6/24/21 1:34 AM, Jie Zhou wrote: > >Replace parse_fec_mode misleading return type name mode with fec_capa > > > >Fixes: b19da32e3151 ("app/testpmd: add FEC command") > >Cc: sta...@dpdk.org > > > >Signed-off-by: Jie Zhou > >Sign

Re: [dpdk-dev] [RFC] toolchain specific macro expansion

2021-06-28 Thread Tyler Retzlaff
On Thu, Jun 24, 2021 at 06:29:20PM +0200, Thomas Monjalon wrote: > 24/06/2021 18:02, Tyler Retzlaff: > > On Thu, Jun 24, 2021 at 08:54:49AM +0200, Thomas Monjalon wrote: > > > 23/06/2021 20:26, Tyler Retzlaff: > > > > // lib/eal/gcc/rte_toolchain_common.h > > > > #define __rte_noreturn __attribute_

[dpdk-dev] [PATCH] common/mlx5: share memory free callback

2021-06-28 Thread Michael Baum
All the mlx5 drivers using MRs for data-path must unregister the mapped memory when it is freed by the dpdk process. Currently, only the net/eth driver unregisters MRs in free event. Move the net callback handler from net driver to common. Cc: sta...@dpdk.org Signed-off-by: Michael Baum Acked-

[dpdk-dev] DPDK Release Status Meeting 24/06/2021

2021-06-28 Thread Mcnamara, John
Release status meeting minutes {Date} = :Date: 24 June 2021 :toc: .Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens .Participants: * Arm * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - * `v21.08` dates

[dpdk-dev] [PATCH v4 0/7] Enhancements for PMD power management

2021-06-28 Thread Anatoly Burakov
This patchset introduces several changes related to PMD power management: - Changed monitoring intrinsics to use callbacks as a comparison function, based on previous patchset [1] but incorporating feedback [2] - this hopefully will make it possible to add support for .get_monitor_addr in virt

[dpdk-dev] [PATCH v4 1/7] power_intrinsics: use callbacks for comparison

2021-06-28 Thread Anatoly Burakov
Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value in a specific way. This commit replaces the co

[dpdk-dev] [PATCH v4 2/7] net/af_xdp: add power monitor support

2021-06-28 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+) diff --git a/drivers/net/af_xdp/rte_e

[dpdk-dev] [PATCH v4 3/7] eal: add power monitor for multiple events

2021-06-28 Thread Anatoly Burakov
Use RTM and WAITPKG instructions to perform a wait-for-writes similar to what UMWAIT does, but without the limitation of having to listen for just one event. This works because the optimized power state used by the TPAUSE instruction will cause a wake up on RTM transaction abort, so if we add the a

[dpdk-dev] [PATCH v4 4/7] power: remove thread safety from PMD power API's

2021-06-28 Thread Anatoly Burakov
Currently, we expect that only one callback can be active at any given moment, for a particular queue configuration, which is relatively easy to implement in a thread-safe way. However, we're about to add support for multiple queues per lcore, which will greatly increase the possibility of various

[dpdk-dev] [PATCH v4 5/7] power: support callbacks for multiple Rx queues

2021-06-28 Thread Anatoly Burakov
Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queues per core. The PMD power management mechanism relies on ethdev Rx callbacks, so it is very difficult

[dpdk-dev] [PATCH v4 6/7] power: support monitoring multiple Rx queues

2021-06-28 Thread Anatoly Burakov
Use the new multi-monitor intrinsic to allow monitoring multiple ethdev Rx queues while entering the energy efficient power state. The multi version will be used unconditionally if supported, and the UMWAIT one will only be used when multi-monitor is not supported by the hardware. Signed-off-by: A

[dpdk-dev] [PATCH v4 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-06-28 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation, and always mark the last queue in qconf as the power save queue. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 39 +++---

[dpdk-dev] [PATCH v2 00/16] Add support for fourth generation of Intel QuickAssist Technology devices

2021-06-28 Thread Arek Kusztal
This patchset adds support for fourth generation (GEN4) of Intel QuickAssist Technology (QAT) devices. Symmetric crypto PMD is enabled with following algorithms: * AES-CBC * AES-CMAC * AES-XCBC MAC * NULL (auth, cipher) * SHA1-HMAC * SHA2-HMAC (224, 256, 384, 512) * Chacha20-Poly1305 * AES-CCM *

[dpdk-dev] [PATCH v2 01/16] common/qat: rework qp per service function

2021-06-28 Thread Arek Kusztal
Different generations of Intel QuickAssist Technology devices may differ in approach to allocate queues. Queue pair number function therefore needs to be more generic. Signed-off-by: Arek Kusztal --- drivers/common/qat/qat_qp.c | 15 ++- drivers/common/qat/qat_qp.h |

[dpdk-dev] [PATCH v2 02/16] crypto/qat: add support for generation 4 devices

2021-06-28 Thread Arek Kusztal
This commit adds support for fourth generation (GEN4) of Intel QuickAssist (QAT) Technology devices. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 10 +- doc/guides/rel_notes/release_21_08.rst| 6 + .../adf_transport_access_macros_gen4.h| 52

[dpdk-dev] [PATCH v2 04/16] crypto/qat: add gen4 ucs slice type, add ctr mode

2021-06-28 Thread Arek Kusztal
This commit adds unified cipher slice to Intel QuickAssist Technology PMD and enables AES-CTR algorithm. Signed-off-by: Arek Kusztal --- drivers/common/qat/qat_adf/icp_qat_fw_la.h | 28 ++ drivers/common/qat/qat_adf/icp_qat_hw.h| 10 drivers/crypto/qat/qat_sym_ca

[dpdk-dev] [PATCH v2 03/16] crypto/qat: enable gen4 legacy algorithms

2021-06-28 Thread Arek Kusztal
This commit enables algorithms labeled as 'legacy' on QAT generation 4 devices. Following algorithms were enabled: * AES-CBC * AES-CMAC * AES-XCBC MAC * NULL (auth, cipher) * SHA1-HMAC * SHA2-HMAC (224, 256, 384, 512) Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym_capabilities.h | 33

[dpdk-dev] [PATCH v2 05/16] crypto/qat: rename content descriptor functions

2021-06-28 Thread Arek Kusztal
Content descriptor functions are incorrectly named, having them with proper name will improve readability and facilitate further work. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym_session.c | 39 ++-- drivers/crypto/qat/qat_sym_session.h | 13 -- 2 f

[dpdk-dev] [PATCH v2 06/16] crypto/qat: add legacy gcm and ccm

2021-06-28 Thread Arek Kusztal
Add AES-GCM, AES-CCM algorithms in legacy mode. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym_capabilities.h | 60 +++ drivers/crypto/qat/qat_sym_session.c | 27 +- drivers/crypto/qat/qat_sym_session.h | 3 +- 3 files changed, 78 insertions(+),

[dpdk-dev] [PATCH v2 07/16] crypto/qat: rework init common header function

2021-06-28 Thread Arek Kusztal
Rework init common header function for request descriptor so it can be called only once. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym.c | 25 +-- drivers/crypto/qat/qat_sym_session.c | 265 ++- drivers/crypto/qat/qat_sym_session.h | 12 ++ 3 files

[dpdk-dev] [PATCH v2 08/16] crypto/qat: add aes gcm in ucs spc mode

2021-06-28 Thread Arek Kusztal
This commit adds AES-GCM algorithm that works in UCS (Unified crypto slice) SPC(Single-Pass) mode. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym.c | 32 drivers/crypto/qat/qat_sym_session.c | 9 2 files changed, 27 insertions(+), 14 del

[dpdk-dev] [PATCH v2 09/16] crypto/qat: add chacha-poly in ucs spc mode

2021-06-28 Thread Arek Kusztal
This commit adds Chacha20-Poly1305 aglorithm that works in UCS (Unified crypto slice) SPC(Single-Pass) mode. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym_capabilities.h | 32 ++- drivers/crypto/qat/qat_sym_session.c | 2 ++ 2 files changed, 33 insertions(+

[dpdk-dev] [PATCH v2 10/16] crypto/qat: add gmac in legacy mode on gen 4

2021-06-28 Thread Arek Kusztal
Add AES-GMAC algorithm in legacy mode to generation 4 devices. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_sym_capabilities.h | 27 ++- drivers/crypto/qat/qat_sym_session.c | 9 +++- drivers/crypto/qat/qat_sym_session.h | 2 ++ 3 files changed, 36 i

[dpdk-dev] [PATCH v2 11/16] common/qat: add pf2vf communication in qat

2021-06-28 Thread Arek Kusztal
Add communication between physical device and virtual function in Intel QucikAssist Technology PMD. Signed-off-by: Arek Kusztal --- drivers/common/qat/meson.build | 1 + drivers/common/qat/qat_adf/adf_pf2vf_msg.h | 154 + drivers/common/qat/qat_device.c

[dpdk-dev] [PATCH v2 12/16] common/qat: reset ring pairs before setting gen4

2021-06-28 Thread Arek Kusztal
This commit resets ring pairs of particular vf before setting PMD. Signed-off-by: Arek Kusztal --- drivers/common/qat/qat_device.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c index 5ee4411

[dpdk-dev] [PATCH v2 13/16] common/qat: add service discovery to qat gen4

2021-06-28 Thread Arek Kusztal
This commit adds service discovery to generation four of Intel QuickAssist Technology devices. Signed-off-by: Arek Kusztal --- drivers/common/qat/qat_common.h | 8 ++ drivers/common/qat/qat_device.c | 20 --- drivers/common/qat/qat_device.h | 3 +++ drivers/common/qat/qat_qp.c

[dpdk-dev] [PATCH v2 14/16] crypto/qat: update raw dp api

2021-06-28 Thread Arek Kusztal
From: Fan Zhang This commit updates the QAT raw data-path API to support the changes made to device and sessions. The QAT RAW data-path API now works on Generation 1-3 devices. Signed-off-by: Fan Zhang --- drivers/crypto/qat/qat_sym_hw_dp.c | 419 +++-- 1 file changed,

[dpdk-dev] [PATCH v2 15/16] crypto/qat: enable RAW API on QAT GEN1-3 only

2021-06-28 Thread Arek Kusztal
From: Adam Dybkowski This patch enables RAW API in feature flags on QAT generations 1 to 3 only. Disables it for later generations. Signed-off-by: Adam Dybkowski --- drivers/crypto/qat/qat_sym_pmd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/qat/qa

[dpdk-dev] [PATCH v2 16/16] test/crypto: check if RAW API is supported

2021-06-28 Thread Arek Kusztal
From: Adam Dybkowski This patch adds checking if RAW API is supported at the start of the test command "cryptodev_qat_raw_api_autotest". Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --

Re: [dpdk-dev] [PATCH v1 2/2] linux/kni: Added support for KNI multiple fifos

2021-06-28 Thread Ferruh Yigit
On 12/10/2020 11:15 PM, dheemanth wrote: > In order to improve performance, the KNI is made to > support multiple fifos, So that multiple threads pinned > to multiple cores can process packets in parallel. > > Signed-off-by: dheemanth Hi Dheemanth, I didn't check the patch yet but as a very hig

Re: [dpdk-dev] [PATCH v2 00/20] Add Marvell CNXK crypto PMDs

2021-06-28 Thread Akhil Goyal
> Add cnxk crypto PMDs supporting Marvell CN106XX SoC, based on > 'common/cnxk'. > > This series utilizes 'common/cnxk' to register cn9k & cn10k crypto PMDs and > add symmetric cryptographic features for the same. > > Depends-on: series-17482 ("Add CPT in Marvell CNXK common driver") > > Changes

[dpdk-dev] [PATCH 1/3] regex/mlx5: fix memory region unregistration

2021-06-28 Thread Michael Baum
The issue can cause illegal physical address access while a huge-page A is released and huge-page B is allocated on the same virtual address. The old MR can be matched using the virtual address of huge-page B but the HW will access the physical address of huge-page A which is no more part of the DP

[dpdk-dev] [PATCH 2/3] regex/mlx5: fix leak in PCI remove function

2021-06-28 Thread Michael Baum
In the PCI removal function, PMD releases all driver resources allocated in the probe function. The MR btree memory is allocated in the probe function, but it is not freed in remove function what caused a memory leak. Release it. Fixes: cda883bbb655 ("regex/mlx5: add dynamic memory registration

[dpdk-dev] [PATCH 3/3] regex/mlx5: fix redundancy in PCI remove function

2021-06-28 Thread Michael Baum
In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: sta...@dpdk.org Signed-off-by: Michael Baum --- dri

[dpdk-dev] [PATCH v4 1/6] net/cnxk: add multi seg Rx vector routine

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add multi-segment Rx vector routine, form the primary mbufs using vector path switch to scalar path when extracting segments. Signed-off-by: Pavan Nikhilesh --- v4 Changes: - Split patches for easier merge. - Rebase on dpdk-next-net-mrvl. v3 Changes: - Spell check.

[dpdk-dev] [PATCH v4 2/6] net/cnxk: enable ptp processing in vector Rx

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Enable PTP offload in vector Rx burst function, use vector path for processing mbufs and finally switch to scalar when extracting timestamp. Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn10k_ethdev.c | 1 - drivers/net/cnxk/cn10k_rx.c | 5 +- drivers/net/c

[dpdk-dev] [PATCH v4 3/6] net/cnxk: enable VLAN processing in vector Tx

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Enable VLAN offload in vector Tx burst function. Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn10k_tx.c | 3 +- drivers/net/cnxk/cn10k_tx.h | 125 +++ drivers/net/cnxk/cn10k_tx_vec.c | 3 +- drivers/net/cnxk/cn9k_tx.c |

[dpdk-dev] [PATCH v4 4/6] net/cnxk: enable ptp processing in vector Tx

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Enable PTP offload in vector Tx burst function. Since, we can no-longer use a single LMT line for burst of 4, split the LMT into two and transmit twice. Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn10k_tx.c | 4 +- drivers/net/cnxk/cn10k_tx.h | 109

[dpdk-dev] [PATCH v4 5/6] net/cnxk: enable TSO processing in vector Tx

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Enable TSO offload in vector Tx burst function. Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn10k_tx.c | 2 +- drivers/net/cnxk/cn10k_tx.h | 97 + drivers/net/cnxk/cn10k_tx_vec.c | 5 +- drivers/net/cnxk/cn9k_tx.c |

[dpdk-dev] [PATCH v4 6/6] net/cnxk: add multi seg Tx vector routine

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add multi segment Tx vector routine. Signed-off-by: Pavan Nikhilesh --- drivers/net/cnxk/cn10k_tx.c | 20 +- drivers/net/cnxk/cn10k_tx.h | 388 +-- drivers/net/cnxk/cn10k_tx_vec_mseg.c | 24 ++ drivers/net/cnxk/cn9k_tx.c

[dpdk-dev] [PATCH v4 1/7] event/cnxk: add Rx adapter support

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter. Resize cn10k workslot fastpath structure to fit in 64B cacheline size. Signed-off-by: Pavan Nikhilesh --- v4 Changes: - Split patches for easier merge. v3 Changes: - Spell check. doc/guides/eventdevs/cnxk.rst| 28 +++

[dpdk-dev] [PATCH v4 2/7] event/cnxk: add Rx adapter fastpath ops

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 136 +++- drivers/event/cnxk/cn10k_worker.c | 54 drivers/event/cnxk/cn10k_worker.h | 97 +-

[dpdk-dev] [PATCH v4 3/7] event/cnxk: add Tx adapter support

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst| 4 +- doc/guides/rel_notes/release_21_08.rst | 6 +- drivers/event/cnxk/cn10k_eventdev.c | 91 ++ drivers/event/cnxk/cn9k_eventd

[dpdk-dev] [PATCH v4 4/7] event/cnxk: add Tx adapter fastpath ops

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 38 drivers/event/cnxk/cn10k_worker.h | 67 ++ drivers/event/cnxk/cn10k_worker_tx_enq.c | 23

[dpdk-dev] [PATCH v4 5/7] event/cnxk: add Rx adapter vector support

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for cnxk event Rx adapter, add control path APIs to get vector limits and ability to configure event vectorization on a given Rx queue. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst| 2 + drivers/event/cnxk/cn10k_e

[dpdk-dev] [PATCH v4 6/7] event/cnxk: add Rx event vector fastpath

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add Rx event vector fastpath to convert HW defined metadata into rte_mbuf and rte_event_vector. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/release_21_08.rst | 1 + drivers/event/cnxk/cn10k_worker.h | 56 +++ drivers/net/cnxk/cn10k_rx.h

[dpdk-dev] [PATCH v4 7/7] event/cnxk: add Tx event vector fastpath

2021-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add Tx event vector fastpath, integrate event vector Tx routine into Tx burst. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst | 1 + doc/guides/rel_notes/release_21_08.rst | 2 +- drivers/common/cnxk/roc_sso.h | 23 ++ drivers/

Re: [dpdk-dev] [PATCH v2 00/20] Add Marvell CNXK crypto PMDs

2021-06-28 Thread Akhil Goyal
> > Add cnxk crypto PMDs supporting Marvell CN106XX SoC, based on > > 'common/cnxk'. > > > > This series utilizes 'common/cnxk' to register cn9k & cn10k crypto PMDs > and > > add symmetric cryptographic features for the same. > > > > Depends-on: series-17482 ("Add CPT in Marvell CNXK common driver"

Re: [dpdk-dev] [PATCH v3 6/7] power: support monitoring multiple Rx queues

2021-06-28 Thread Ananyev, Konstantin
> >> Use the new multi-monitor intrinsic to allow monitoring multiple ethdev > >> Rx queues while entering the energy efficient power state. The multi > >> version will be used unconditionally if supported, and the UMWAIT one > >> will only be used when multi-monitor is not supported by the hardw

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-06-28 Thread Huisong Li
在 2021/6/14 23:37, Andrew Rybchenko 写道: Summary should start from "ethdev: " Don't forget to include all maintainers in Cc the next time. Just use --cc-cmd or --to-cmd options. ok, thanks! Adding Thomas. On 5/8/21 11:00 AM, Huisong Li wrote: Currently, if dev_configure is not invoked or f

[dpdk-dev] [PATCH v3 0/2] add Rx/Tx offload paths for ICE AVX2

2021-06-28 Thread Wenzhuo Lu
Add specific paths for RX/TX AVX2, called offload paths. In these paths, support the HW offload features, like, checksum, VLAN, RSS offload. These paths are chosen automatically according to the configuration. v2: - fdir should be supported by offload and normal path. v3: - rebased on the newe

[dpdk-dev] [PATCH v3 1/2] net/ice: add Tx AVX2 offload path

2021-06-28 Thread Wenzhuo Lu
Add a specific path for TX AVX2. In this path, support the HW offload features, like, checksum insertion, VLAN insertion. This path is chosen automatically according to the configuration. 'inline' is used, then the duplicate code is generated by the compiler. Signed-off-by: Wenzhuo Lu --- drive

[dpdk-dev] [PATCH v3 2/2] net/ice: add Rx AVX2 offload path

2021-06-28 Thread Wenzhuo Lu
Add a specific path for RX AVX2. In this path, support the HW offload features, like, checksum, VLAN stripping, RSS hash. This path is chosen automatically according to the configuration. 'inline' is used, then the duplicate code is generated by the compiler. Signed-off-by: Wenzhuo Lu --- doc/g

Re: [dpdk-dev] [RFC 2/2] app/testpmd: support VXLAN last 8-bits field matching

2021-06-28 Thread Rongwei Liu
Hi Singh: This update only provides the capability to match the last 8-bits reserved field of VXLAN header. No package modification totally. Package content is up to end user' decision. BR Rongwei > -Original Message- > From: dev On Behalf Of Singh, Aman Deep > Sent: Wed

  1   2   >