On Wed, Mar 31, 2021 at 7:31 PM Kalesh A P <
kalesh-anakkur.pura...@broadcom.com> wrote:
> From: Kalesh AP
>
> During port start when bnxt_start_nic() fails, it tries to free
> "intr_handle->intr_vec" but the variable is not set to NULL after that.
> If port start fails, driver invokes bnxt_dev_s
On Thu, Apr 1, 2021 at 8:03 PM Kalesh A P
wrote:
>
> From: Kalesh AP
>
> While configuring LRO, driver should check the return value
> of bnxt_hwrm_vnic_tpa_cfg() HWRM command and return error
> when the FW command fails.
>
> Fixes: 0958d8b6435d ("net/bnxt: support LRO")
> Cc: sta...@dpdk.org
>
>
On Mon, Apr 5, 2021 at 10:42 PM Kalesh A P
wrote:
>
> From: Kalesh AP
>
> The "Unregistered with fw" message was being logged in a wrong function.
> Moved it to the right place.
>
> Fixes: a7dda7e0a00b ("net/bnxt: log port id in async events")
>
> Signed-off-by: Kalesh AP
> Reviewed-by: Somnath
> -Original Message-
> From: Wan Junjie
> Sent: Tuesday, February 2, 2021 4:15 PM
> To: Xia, Chenbo ; Maxime Coquelin
>
> Cc: dev@dpdk.org; Wan Junjie ; Peng He
> ; Zhihong Wang
> Subject: [PATCH v2] vhost: avoid iotlb mempool allocation while IOMMU disabled
>
> If vhost device's IOMMU
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa
> Nagarahalli
> Sent: Wednesday, April 7, 2021 2:48 AM
>
>
> >
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tom Barbette
> > > Sent: Wednesday, March 31, 2021 10:53 AM
> > >
> > > Le 31-03-21 à 02:44, Honnappa Nagarahal
07/04/2021 03:00, Suanming Mou:
> From: Thomas Monjalon
> > 30/03/2021 03:39, Suanming Mou:
> > > From: John Hurley
> > >
> > > A recent change adds support for scattered mbuf and UMR support for regex.
> > > Part of this commit makes the pi and ci counters of the regex_sq a
> > > quarter of the
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, April 7, 2021 3:12 PM
> To: John Hurley ; Suanming Mou
>
> Cc: dev@dpdk.org; Ori Kam ; dev@dpdk.org; Slava
> Ovsiienko ; Matan Azrad ;
> Raslan Darawsheh
> Subject: Re: [dpdk-dev] [PATCH v3 4/4] regex/mlx5: prevent wrong
On Tue, Apr 6, 2021 at 2:48 AM Thomas Monjalon wrote:
>
> 06/04/2021 11:07, Bing Zhao:
> > Hi Thomas and Andrew,
> >
> > From: Andrew Rybchenko
> > > On 3/17/21 11:28 AM, Thomas Monjalon wrote:
> > > > 17/03/2021 08:59, Bing Zhao:
> > > >> The new functions rte_flow_action_ctx* that were added wi
The scattered mbuf was not supported in mlx5 RegEx driver. This
patch set adds the support of scattered mbuf by UMR WQE.
UMR(User-Mode Memory Registration) WQE can present data buffers
scattered within multiple mbufs with single indirect mkey. Take
advantage of the UMR WQE, scattered mbuf in one o
This commit adds the UMR capability bits.
Signed-off-by: Suanming Mou
Acked-by: Ori Kam
---
drivers/common/mlx5/linux/meson.build | 2 ++
drivers/common/mlx5/mlx5_devx_cmds.c | 5 +
drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++
3 files changed, 10 insertions(+)
diff --git a/drivers/commo
This commits adds the scattered mbuf input support.
Signed-off-by: Suanming Mou
Acked-by: Ori Kam
---
app/test-regex/main.c | 134 +++--
doc/guides/tools/testregex.rst | 3 +
2 files changed, 112 insertions(+), 25 deletions(-)
diff --git a/app/test-regex/
UMR(User-Mode Memory Registration) WQE can present data buffers
scattered within multiple mbufs with single indirect mkey. Take
advantage of the UMR WQE, scattered mbuf in one operation can be
presented to an indirect mkey. The RegEx which only accepts one
mkey can now process the whole scattered m
> -Original Message-
> From: Maxime Coquelin
> Sent: Thursday, March 25, 2021 4:32 PM
> To: Ilya Maximets
> Cc: Xia, Chenbo ; dev@dpdk.org; Adrian Moreno
> ; Stefan Hajnoczi ; Julia Suvorova
> ; sta...@dpdk.org; Yang, Zhiyong
> Subject: Re: [PATCH 1/4] net/virtio: fix interrupt unregiste
> -Original Message-
> From: Alexander Kozyrev
> Sent: Wednesday, April 7, 2021 4:14
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko
> Subject: [PATCH] net/mlx5: check extended metadata for meta modification
>
> The MODIFY_FIELD RTE action requires the exte
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dmitry Kozlyuk
> Sent: Wednesday, April 7, 2021 1:30 AM
>
> 2021-04-06 16:34 (UTC+0200), Morten Brørup:
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dmitry Kozlyuk
> > > Sent: Sunday, April 4, 2021 1:41 AM
> > >
> > > POSIX sleep
> -Original Message-
> From: Alexander Kozyrev
> Sent: Wednesday, April 7, 2021 4:14
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko
> Subject: [PATCH] net/mlx5: support 64-bit value for modify field action
>
> Extend the range of immediate value used in th
> -Original Message-
> From: Alexander Kozyrev
> Sent: Wednesday, April 7, 2021 4:15
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko
> Subject: [PATCH] net/mlx5: fix modify field action order for IPv6
>
> Mellanox hardware can only modify any packet field i
Hi Andrew,
Sorry for the late reply.
> -Original Message-
> From: Andrew Rybchenko
> Sent: Monday, March 22, 2021 11:17 PM
> To: Bing Zhao ; Ori Kam ; NBU-
> Contact-Thomas Monjalon ;
> ferruh.yi...@intel.com
> Cc: dev@dpdk.org
> Subject: Re: [RFC] ethdev: introduce conntrack flow action
Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE.
Signed-off-by: Liulingyu
---
app/test-pmd/util.c | 25 -
lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++
lib/librte_mbuf/rte_mbuf_ptype.h | 22 ++
3 files changed, 40 insertions(+), 9 dele
This series fixed some bugs in unit tests for power library.
v3:
Break patch into series for individual bug fixes.
Richael Zhuang (3):
test/power: round cpuinfo cur freq value in cpufreq autotest
test/power: fix a bug in cpufreq autotest
test/power: add delay before checking cpuinfo cur fre
The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the
same as what was set. For example, if "240" is written to
"/sys/.../cpufreq/scaling_setspeed" to set the frequency, then the
value in "/sys/.../cpuinfo_cur_freq" may be "2401222". So need to
round the value.
Fixes: ed7c51a6a680 ("
For platforms that don't support turbo boost,rte_power_turbo_status()
returns "-ENOTSUP" (like power_kvm_vm_turbo_status()). So don't allow
check_power_turbo() to continue if
rte_power_turbo_status(TEST_POWER_LCORE_ID)!=1
Fixes: aeaeaf5f2d62 ("test/power: add cases for turbo feature")
Cc: lukaszx
Sleep for 1s before checking the newly updated value from
"/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because
for some systems it may not be effective immediately.
Fixes: ed7c51a6a680 ("app/test: vm power management")
Cc: alan.ca...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Richa
On 3/17/21 6:40 AM, Cheng Jiang wrote:
> We use ioat ring space for determining if ioat callbacks can enqueue a
> packet to ioat device. But there is one slot can't be used in ioat
> ring due to the ioat driver design, so we need to reduce one slot in
> ioat ring to prevent ring size mismatch in
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, April 7, 2021 3:48 PM
> To: Jiang, Cheng1 ; Xia, Chenbo
> ; Thomas Monjalon
> Cc: dev@dpdk.org; Hu, Jiayu ; Yang, YvonneX
> ; Wang, Yinan ;
> sta...@dpdk.org
> Subject: Re: [PATCH] examples/vhost: fix ioat ring sp
On 4/6/2021 6:25 AM, Michał Krawczyk wrote:
wt., 6 kwi 2021 o 02:27 David Harton napisał(a):
When ena_tx_queue_release_bufs() frees the mbufs it does not clear
the mbuf pointers. So, when the device starts and stops multiple
times it can cause the application to receive duplicate mbufs for
tw
On 4/6/21 4:22 PM, Thomas Monjalon wrote:
> In the unlikely case where something goes wrong
> while registering a log type,
> the fallback is to use the EAL log type.
>
> Signed-off-by: Thomas Monjalon
> Reviewed-by: David Marchand
Reviewed-by: Andrew Rybchenko
On Tue, Apr 6, 2021 at 10:09 PM David Marchand
wrote:
> We have exports missing in EAL for some series posted on the ml
> waiting for merges.
> I suspect some recent merged changes have issues too (but did not check yet).
> This current patch does not address such issues and we need fixes
> afterw
Hi Ferruh,
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, April 6, 2021 5:44 PM
To: Jiawei(Jonny) Wang ; Salem Sol ;
dev@dpdk.org
Cc: Ori Kam ; Xiaoyun Li
Subject: Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap
data globally
External email: Use caution openi
On 4/7/2021 9:19 AM, Salem Sol wrote:
Hi Ferruh,
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, April 6, 2021 5:44 PM
To: Jiawei(Jonny) Wang ; Salem Sol ;
dev@dpdk.org
Cc: Ori Kam ; Xiaoyun Li
Subject: Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap
data glob
07/04/2021 09:47, Maxime Coquelin:
>
> On 3/17/21 6:40 AM, Cheng Jiang wrote:
> > We use ioat ring space for determining if ioat callbacks can enqueue a
> > packet to ioat device. But there is one slot can't be used in ioat
> > ring due to the ioat driver design, so we need to reduce one slot in
>
Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE.
Signed-off-by: Liulingyu
---
app/test-pmd/util.c | 25 -
lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++
lib/librte_mbuf/rte_mbuf_ptype.h | 22 ++
3 files changed, 40 insertions(+), 9 dele
-Original Message-
From: Ferruh Yigit
Sent: Wednesday, April 7, 2021 11:24 AM
To: Salem Sol ; Jiawei(Jonny) Wang ;
dev@dpdk.org
Cc: Ori Kam ; Xiaoyun Li
Subject: Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap
data globally
External email: Use caution opening link
+Cc more people to start a discussion about a potential DMA API.
If you think it is interesting, we can start a fresh discussion thread.
07/04/2021 10:26, Thomas Monjalon:
> 07/04/2021 09:47, Maxime Coquelin:
> >
> > On 3/17/21 6:40 AM, Cheng Jiang wrote:
> > > We use ioat ring space for determin
On 4/7/21 10:26 AM, Thomas Monjalon wrote:
> 07/04/2021 09:47, Maxime Coquelin:
>>
>> On 3/17/21 6:40 AM, Cheng Jiang wrote:
>>> We use ioat ring space for determining if ioat callbacks can enqueue a
>>> packet to ioat device. But there is one slot can't be used in ioat
>>> ring due to the ioat
2021-04-07 10:16 (UTC+0200), David Marchand:
> On Tue, Apr 6, 2021 at 10:09 PM David Marchand
> wrote:
> > We have exports missing in EAL for some series posted on the ml
> > waiting for merges.
> > I suspect some recent merged changes have issues too (but did not check
> > yet).
> > This current
07/04/2021 10:53, Dmitry Kozlyuk:
> 2021-04-07 10:16 (UTC+0200), David Marchand:
> > On Tue, Apr 6, 2021 at 10:09 PM David Marchand
> > wrote:
> > > We have exports missing in EAL for some series posted on the ml
> > > waiting for merges.
> > > I suspect some recent merged changes have issues too
On Tue, Apr 06, 2021 at 03:56:16PM +0200, Thomas Monjalon wrote:
> 03/04/2021 12:35, Liang Ma:
> > I would like to change my email to personal email address.
> >
> > Signed-off-by: Liang Ma
>
> Applied
Hi Thomas,
Many thanks.
Regards
Liang
rte_service_get_id() was removed in v17.11 but the API description
still referenced it and a version node was still present in EAL map.
Fixes: 8edc9aaaf217 ("service: use id in get by name function")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
lib/librte_eal/include/rte_service.h | 5
On Thu, Apr 1, 2021 at 1:07 PM Burakov, Anatoly
wrote:
>
> On 22-Feb-21 10:41 AM, Roy Shterman wrote:
> > When using huge_unlink we unlink the segment right
> > after allocation. Although we unlink the file we keep
> > the fd in fd_list so file still exist just the path deleted.
> > When freeing t
On Tue, Apr 6, 2021 at 4:50 PM Renata Saiakhova
wrote:
>
> Avoid race with unregister interrupt handler if interrupt
> source has some active callbacks at the moment, use wrapper
> around rte_intr_callback_unregister() to check for -EAGAIN
> return value and to loop until rte_intr_callback_unregis
This patch updates copyright date for hns3 PMD files.
Fixes: 565829db8b8f ("net/hns3: add build and doc infrastructure")
Fixes: 952ebacce4f2 ("net/hns3: support SVE Rx")
Fixes: e31f123db06b ("net/hns3: support NEON Tx")
Fixes: c09c7847d892 ("net/hns3: support traffic management")
Signed-off-by: M
Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Monday, April 5, 2021 12:59 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix the drop action for the DR/DV
>
> There are multiple branches in rdma-core l
Instead of calculating the address of a packed descriptor based on the
vq->desc_packed and vq->last_used_idx every time, store that base
address in desc_base. On arm, this saves 176 bytes in code size of
function in which vhost_flush_enqueue_batch_packed gets inlined.
Signed-off-by: Balazs Nemeth
Instead of calculating the address of a packed descriptor based on the
vq->desc_packed and vq->last_used_idx every time, store that base
address in desc_base. On arm, this saves 176 bytes in code size of
function in which vhost_flush_enqueue_batch_packed gets inlined.
Signed-off-by: Balazs Nemeth
On 07-Apr-21 8:46 AM, Richael Zhuang wrote:
For platforms that don't support turbo boost,rte_power_turbo_status()
returns "-ENOTSUP" (like power_kvm_vm_turbo_status()). So don't allow
check_power_turbo() to continue if
rte_power_turbo_status(TEST_POWER_LCORE_ID)!=1
Fixes: aeaeaf5f2d62 ("test/po
On Wed, Apr 07, 2021 at 09:11:23AM +0200, Morten Brørup wrote:
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa
> > Nagarahalli
> > Sent: Wednesday, April 7, 2021 2:48 AM
> >
> >
> > >
> > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tom Barbette
> > > > Sent: Wednesd
On Wed, Apr 07, 2021 at 03:46:36PM +0800, Richael Zhuang wrote:
> Sleep for 1s before checking the newly updated value from
> "/sys/devices/system/cpu/cpu%u/cpufreq/cpuinfo_cur_freq", because
> for some systems it may not be effective immediately.
>
> Fixes: ed7c51a6a680 ("app/test: vm power manag
In preparation for subsequent patches, move mbuf allocation out and
rename virtio_dev_pktmbuf_alloc to virtio_dev_pktmbuf_prep. This
function now receives an already allocated mbuf pointer.
Signed-off-by: Balazs Nemeth
---
lib/librte_vhost/virtio_net.c | 54 ++-
1
Move allocation out further and perform all allocation in one loop. The
same goes for freeing packets. This is to prepare for use of bulk
versions of these functions.
Signed-off-by: Balazs Nemeth
---
lib/librte_vhost/virtio_net.c | 18 ++
1 file changed, 6 insertions(+), 12 delet
Now that all allocation and freeing has been moved together, use the
faster bulk versions instead of handling packets one by one.
Signed-off-by: Balazs Nemeth
---
lib/librte_vhost/virtio_net.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/lib/librte_vhost/virtio
There is no need to pass a pointer to an mbuf pointer.
Signed-off-by: Balazs Nemeth
---
lib/librte_vhost/virtio_net.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 2f0c97b91..1d3ad18fe 100644
---
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Wednesday, April 7, 2021 11:59 AM
>
> On Wed, Apr 07, 2021 at 09:11:23AM +0200, Morten Brørup wrote:
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa
> > > Nagarahalli
> > > Sent: Wednesday, April 7,
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, April 6, 2021 10:40 AM
> To: Ori Kam
> Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
>
> On Mon, Apr 5, 2021 at 11:35 PM Ori Kam wrote:
> >
> > Currently, DPDK application can offload the checksum
Fix logically dead code in ring port.
Coverity issue: 369664
Fixes: 77a413017c2d ("port: add ring SWX port")
Signed-off-by: Cristian Dumitrescu
---
lib/librte_port/rte_swx_port_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_port/rte_swx_port_ring.c
b/lib/
Fix out of bounds write. The allocated string size was incorrect.
Coverity issue: 369670
Fixes: 66440b7b22f2 ("table: add wildcard match table type")
Signed-off-by: Cristian Dumitrescu
---
lib/librte_table/rte_swx_table_wm.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff -
On Wed, Apr 7, 2021 at 4:02 PM Ori Kam wrote:
>
> Hi Jerin,
Hi Ori,
>
> > -Original Message-
> > From: Jerin Jacob
> > Sent: Tuesday, April 6, 2021 10:40 AM
> > To: Ori Kam
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
> >
> > On Mon, Apr 5, 2021 at 11:35 PM
Hi, all,
Many APIs in DPDK does not check if the pointer parameter is
NULL or not. For example, in 'rte_ethdev.c':
int
rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
uint16_t nb_rx_desc, unsigned int socket_id,
const struct rte_
On 4/7/2021 9:35 AM, Salem Sol wrote:
-Original Message-
From: Ferruh Yigit
Sent: Wednesday, April 7, 2021 11:24 AM
To: Salem Sol ; Jiawei(Jonny) Wang ;
dev@dpdk.org
Cc: Ori Kam ; Xiaoyun Li
Subject: Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap
data globally
Ex
Hi Michael,
This patch would cause this compilation failure on aarch64 compilation with gcc
:
aarch64-linux-gnu-gcc (Linaro GCC 7.1-2017.08) 7.1.1 20170707
[615/2518] Compiling C object
drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_txq.c.o
FAILED: drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_t
> Subject: Re: [PATCH v2] build: list symbols exports in a single file
>
> External email: Use caution opening links or attachments
>
>
> 07/04/2021 10:53, Dmitry Kozlyuk:
> > 2021-04-07 10:16 (UTC+0200), David Marchand:
> > > On Tue, Apr 6, 2021 at 10:09 PM David Marchand
> > > wrote:
> > > >
07/04/2021 13:28, Min Hu (Connor):
> Hi, all,
> Many APIs in DPDK does not check if the pointer parameter is
> NULL or not. For example, in 'rte_ethdev.c':
> int
> rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
> uint16_t nb_rx_desc, unsigned int socket_id
From: Jiawei Wang
With the current code the VXLAN/NVGRE parsing routine
stored the configuration of the header on stack, this
might lead to overwriting the data on the stack.
Currently having VXLAN/NVGRE encap as sample actions
is done using RAW_ENCAP, for example:
1. set raw_encap 1 eth src.../
On Wed, Apr 07, 2021 at 01:40:32PM +0200, Thomas Monjalon wrote:
> 07/04/2021 13:28, Min Hu (Connor):
> > Hi, all,
> > Many APIs in DPDK does not check if the pointer parameter is
> > NULL or not. For example, in 'rte_ethdev.c':
> > int
> > rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_q
Add support for VXLAN encap as a sample action
and validate it.
Signed-off-by: Salem Sol
---
doc/guides/nics/mlx5.rst | 4 ++--
doc/guides/rel_notes/release_21_05.rst | 6 ++
drivers/net/mlx5/mlx5_flow_dv.c| 11 +++
3 files changed, 19 insertions(+), 2 deletio
Add support for NVGRE encap as a sample action
and validate it.
Signed-off-by: Salem Sol
---
doc/guides/nics/mlx5.rst | 2 +-
doc/guides/rel_notes/release_21_05.rst | 2 +-
drivers/net/mlx5/mlx5_flow_dv.c| 2 ++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a
Add support for rte_flow_action_vxlan_encap as a sample action.
The example of test-pmd command:
1. set vxlan ip-version ... vni ... udp-src ...
set raw_encap 1 eth src.../ ipv4.../...
set sample_actions 2 vxlan_encap / port_id id 0 / end
flow create 0 ... pattern eth / end actions
Add support for rte_flow_action_nvge_encap as a sample action.
The example of test-pmd command:
1. set nvgre ip-version ... tni ... ip-src ... ip-dst ...
set raw_encap 1 eth src... / ipv4... /...
set sample_actions 2 nvgre / port_id id 0 / end
flow create 0 ... pattern eth / end acti
Update documentation for sample action usage in testpmd utilizing
rte_flow_action_vxlan_encap and rte_flow_action_nvgre_encap and
show the command line example.
Signed-off-by: Salem Sol
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 24 +
1 file changed, 24 insertions(+)
> 07/04/2021 13:28, Min Hu (Connor):
> > Hi, all,
> > Many APIs in DPDK does not check if the pointer parameter is
> > NULL or not. For example, in 'rte_ethdev.c':
> > int
> > rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
> >uint16_t nb_rx_desc, unsigned
On Thu, Feb 25, 2021 at 11:54 AM David Marchand
wrote:
>
> Hello Haiyue,
>
> On Thu, Feb 4, 2021 at 3:56 PM Haiyue Wang wrote:
> >
> > There is an 82599 errata that UDP frames with a zero checksum are
> > incorrectly marked as checksum invalid by the hardware. This was
> > leading to misleading
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
Hi Vladimir,
Few comments below, mostly minor.
One generic one - doc seems missing.
With that in place:
Acked-by: Konstantin Ananyev
>
> This patch implements predictable RSS functionality.
>
> Signed-off-by: Vladimir Medvedkin
> ---
> lib/librte_hash/rte_thash.c | 577
> +++
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
wrote:
>
>
>
> > 07/04/2021 13:28, Min Hu (Connor):
> > > Hi, all,
> > > Many APIs in DPDK does not check if the pointer parameter is
> > > NULL or not. For example, in 'rte_ethdev.c':
> > > int
> > > rte_eth_rx_queue_setup(uint16_t port_id, u
Not directly related to this patch, but can someone please explain why
Patchwork is creating a new series everytime I post a new version of
the patch to this thread? I must be doing something wrong but I don't
know what it is. I have been using --in-reply-to with git send-email
but that's apparentl
Hi Luc,
On Wed, Apr 07, 2021 at 08:53:23AM -0400, Luc Pelletier wrote:
> The creation of control threads uses a pthread barrier for
> synchronization. This patch fixes a race condition where the pthread
> barrier could get destroyed while one of the threads has not yet
> returned from the pthread_
On 3/17/2021 8:21 AM, Wei Huang wrote:
In write_flash_image(), calling function "read" may taints variable
"buf" which turn to an untrusted value as argument of "rte_free".
Coverity issue: 367477
Fixes: 7a4f3993f269 ("raw/ifpga: add FPGA RSU APIs")
Hi Huang, Rosen,
I checked the coverity iss
Hi Joyce,
On Thu, Mar 18, 2021 at 07:20:22PM +0800, Joyce Kong wrote:
> If cache is enabled, objects will be retrieved/put from/to cache,
> subsequently from/to the common pool. Now the debug stats calculate
> the objects retrieved/put from/to cache and pool together, it is
> better to distinguish
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
Hi Luc,
On Wed, Apr 07, 2021 at 10:42:37AM -0400, Luc Pelletier wrote:
> The creation of control threads uses a pthread barrier for
> synchronization. This patch fixes a race condition where the pthread
> barrier could get destroyed while one of the threads has not yet
> returned from the pthread_
On 3/17/2021 8:23 AM, Wei Huang wrote:
In fme_spi_init(), passing tainted expression "fme->max10_dev"
to function "intel_max10_device_remove" has risk. Untainted
variable "max10" should be used.
Coverity issue: 367480
Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Fol
> -Original Message-
> From: Alexander Kozyrev
> Sent: Friday, April 2, 2021 5:08
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko
> Subject: [PATCH] net/mlx5: fix modify field action endianness
>
> Converting modify_field action masks to the big endian form
> -Original Message-
> From: Anoob Joseph
> Sent: Tuesday, April 6, 2021 8:31 PM
> To: Gujjar, Abhinandan S
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> hemant.agra...@nxp.com; nipun.gu...@nxp.com;
> sachin.sax...@oss.nxp.com; ma...@nvidia.com; Zhang, Roy Fan
> ; g.si...@nx
> -Original Message-
> From: dev On Behalf Of Stephen Hemminger
> Sent: Friday, April 2, 2021 2:43 AM
> To: dev@dpdk.org; Honnappa Nagarahalli
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [PATCH v5] pflock: implementation of phase-fair reader
> writer locks
>
> This is a new type o
Hi Alex,
This patch is causing a compilation failure as following:
[1857/3005] Compiling C object
drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_flow_dv.c.o
FAILED: drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_flow_dv.c.o
gcc -Idrivers/libtmp_rte_net_mlx5.a.p -Idrivers -I../../root/dpdk/drivers
>
> Hi Luc,
>
> On Wed, Apr 07, 2021 at 08:53:23AM -0400, Luc Pelletier wrote:
> > The creation of control threads uses a pthread barrier for
> > synchronization. This patch fixes a race condition where the pthread
> > barrier could get destroyed while one of the threads has not yet
> > returne
Extend the range of immediate value used in the MODIFY_FIELD action
from 32 to 64 bits to conform to the rte_flow_action_modify_data spec.
Apply appropriate big endian conversion to the immediate value
according to a destination field bit width.
Fixes: 641dbe4fb053 ("net/mlx5: support modify field
Extend the range of immediate value used in the MODIFY_FIELD action
from 32 to 64 bits to conform to the rte_flow_action_modify_data spec.
Apply appropriate big endian conversion to the immediate value
according to a destination field bit width.
Fixes: 641dbe4fb053 ("net/mlx5: support modify field
looks ok to me.
Acked-by: Hemant Agrawal
On 4/7/2021 8:39 PM, Liulingyu wrote:
Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE.
Signed-off-by: Liulingyu
---
app/test-pmd/util.c | 25 -
lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++
lib/librte_mbu
On 4/7/2021 8:10 PM, Ajit Khaparde wrote:
On Wed, Apr 7, 2021 at 6:20 AM Jerin Jacob wrote:
On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
wrote:
07/04/2021 13:28, Min Hu (Connor):
Hi, all,
Many APIs in DPDK does not check if the pointer parameter is
NULL or not. For example, i
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, April 5, 2021 11:11 PM
> To: Gujjar, Abhinandan S ; Shijith Thotton
> ; dev@dpdk.org
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> hemant.agra...@nxp.com; nipun.gu...@nxp.com;
> sachin.sax...@oss.nxp.com; Anoob Joseph ;
If RSS action contains non zero hash key length and NULL
key buffer pointer the default hash key should be used.
The check for the NULL pointer this was missing in the mlx4
PMD causing crash, for example, in testpmd with command:
flow validate 0 ingress group 0
pattern eth / ipv4 / end
actions
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
Previous fix has addressed the incorrect handling of `base_frequency`
file, but has added a use-after-free error due to the fact that all
further code paths will lead to an `fclose()` call at the end, so the
additional `fclose()` call right after processing the file was
unnecessary.
Coverity issue
On 4/7/2021 4:25 PM, Hemant Agrawal wrote:
On 4/7/2021 8:10 PM, Ajit Khaparde wrote:
On Wed, Apr 7, 2021 at 6:20 AM Jerin Jacob wrote:
On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
wrote:
07/04/2021 13:28, Min Hu (Connor):
Hi, all,
Many APIs in DPDK does not check if the point
Hi Anatoly,
On 7/4/2021 4:56 PM, Anatoly Burakov wrote:
Previous fix has addressed the incorrect handling of `base_frequency`
file, but has added a use-after-free error due to the fact that all
further code paths will lead to an `fclose()` call at the end, so the
additional `fclose()` call right
Reviewed-by: Liang Ma
On Wed, Apr 07, 2021 at 03:56:42PM +, Anatoly Burakov wrote:
> Previous fix has addressed the incorrect handling of `base_frequency`
> file, but has added a use-after-free error due to the fact that all
> further code paths will lead to an `fclose()` call at the end, so
On 07-Apr-21 5:10 PM, Ferruh Yigit wrote:
On 4/7/2021 4:25 PM, Hemant Agrawal wrote:
On 4/7/2021 8:10 PM, Ajit Khaparde wrote:
On Wed, Apr 7, 2021 at 6:20 AM Jerin Jacob
wrote:
On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
wrote:
07/04/2021 13:28, Min Hu (Connor):
Hi, all,
Ma
On 07-Apr-21 4:56 PM, Anatoly Burakov wrote:
Previous fix has addressed the incorrect handling of `base_frequency`
file, but has added a use-after-free error due to the fact that all
further code paths will lead to an `fclose()` call at the end, so the
additional `fclose()` call right after proce
1 - 100 of 151 matches
Mail list logo
