[dpdk-dev] Minutes of Technical Board Meeting, 2021-02-10

Minutes of Technical Board Meeting, 2021-02-10 Members Attending: 12/12 - Aaron Conole - Bruce Richardson - Ferruh Yigit (Chair) - Hemant Agrawal - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Stephen Hemminger

Re: [dpdk-dev] [dpdk-stable] [PATCH v13 0/4] raw/ifpga: add extra OPAE APIs

22/02/2021 02:59, Huang, Wei: > > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, February 10, 2021 17:38 > To: Huang, Wei > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > ; sta...@dpdk.org; Zhang, Tianfei > ; Yigit, Ferruh > Subject: Re: [dpdk-stable] [PATCH v13 0/4] raw/

Re: [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID

On Sun, Feb 21, 2021 at 1:52 AM Dmitry Kozlyuk wrote: > > Add device ID of VMWare Paravirtualized Ethernet v3. > > Signed-off-by: Dmitry Kozlyuk > --- > windows/netuio/netuio.inf | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf > in

Re: [dpdk-dev] [PATCH v8 0/3] fix issue with partial DMA unmap

Ping. Can this be merged for 21.05 ? It is pending since few releases. -- Thanks Nihtin On Tue, Feb 16, 2021 at 01:14:37PM +, Burakov, Anatoly wrote: > On 15-Jan-21 7:32 AM, Nithin Dabilpuram wrote: > > Partial DMA unmap is not supported by VFIO type1 IOMMU > > in Linux. Though the return va

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 2/6] power: make channel msg functions public

On 1/21/2021 5:21 PM, David Hunt wrote: From: Bruce Richardson Move the 2 public functions into rte_power_guest_channel.h Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: sta...@dpdk.org Signed-off-by: B

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 3/6] power: rename public structs

On 1/21/2021 5:21 PM, David Hunt wrote: From: Bruce Richardson rename the public structs to have an rte_power_ prefix and add them to version.map in experimental section. Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels

Re: [dpdk-dev] [PATCH v8 0/3] fix issue with partial DMA unmap

On Mon, Feb 22, 2021 at 10:42 AM Nithin Dabilpuram wrote: > > Can this be merged for 21.05 ? It is pending since few releases. I'll get them this week, hopefully. -- David Marchand

Re: [dpdk-dev] Build errors due to duplicate version.map entries in librte_power

This seems to have gone unnoticed. lib/librte_power/version.map specifies rte_power_guest_channel_send_msg both under DPDK_21 and EXPERIMENTAL. This is causing the clang cross-compile job to always fail with the error Aaron provided: ld.lld: error: duplicate symbol 'rte_power_guest_channel_send

Re: [dpdk-dev] [PATCH] app/testpmd: remove unnecessary tunnel UDP cmd check

On 2/18/2021 3:06 AM, Xiaoyun Li wrote: cmd_tunnel_udp_config checked 'cmd' to set prot_type but this cmd is only for rx_vxlan_port. The unnecessary cmd check will cause uninit coverity issue. So remove it and rename 'cmd' to 'rx_vxlan_port'. Coverity issue: 366155 Fixes: bd948f20d609 ("app/test

Re: [dpdk-dev] [PATCH 21.05 v3] app/testpmd: display rxq desc used count

On 2/22/2021 5:15 AM, Li, Xiaoyun wrote: -Original Message- From: Lance Richardson Sent: Saturday, February 13, 2021 05:25 To: Li, Xiaoyun Cc: dev@dpdk.org; Yigit, Ferruh Subject: [PATCH 21.05 v3] app/testpmd: display rxq desc used count Add support for displaying the count of used (f

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

On Sun, Feb 21, 2021 at 04:28:25AM +0300, Dmitry Kozlyuk wrote: > POSIX strncasecmp(), strdup(), and strtok_r() have different names > on Windows, respectively, strnicmp(), _strdup(), and strtok_s(). > > Add wrappers as inline functions, because they're used from librte_kvargs, > and thus cannot b

Re: [dpdk-dev] [PATCH v2] doc: update stable section

On 19/02/2021 11:17, Kevin Traynor wrote: > Updating the docs to elaborate on the stable release > characteristics and better document the current practice > about new features in stable releases. > > Signed-off-by: Kevin Traynor > > --- Acked-by: Luca Boccassi

Re: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF

> -Original Message- > From: Huang, ZhiminX > Sent: Friday, February 19, 2021 5:06 PM > To: Zhang, AlvinX ; Zhang, Qi Z > > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF > > Tested-by: Huang, ZhiminX > > Regards,

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

Rather than defining "rte_" versions of these functions, is it possible just to provide the unprefixed definitions of them for internal use? While this probably won't work for any functions used in public headers, for any functions only used in C files, we can use meson to detect the presence o

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

On Mon, Feb 22, 2021 at 12:48:39PM +, Nick Connolly wrote: > Rather than defining "rte_" versions of these functions, is it possible > just to provide the unprefixed definitions of them for internal use? > While this probably won't work for any functions used in public headers, > for any functi

Re: [dpdk-dev] [PATCH v2] ci: update arm64 Travis jobs to Graviton2

> -Original Message- > From: Aaron Conole > Sent: Friday, February 19, 2021 2:27 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; david.march...@redhat.com; > maicolgabr...@hotmail.com; dev@dpdk.org; ruifeng.w...@arm.com; > honnappa.nagaraha...@arm.com > Subject: Re: [PATCH v2] ci: upda

[dpdk-dev] 20.11.1 patches review and test

Hi all, Here is a list of patches targeted for stable release 20.11.1. The planned date for the final release is the 8th of March. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported val

Re: [dpdk-dev] [PATCH 0/5] add apistats function

On 12/22/2020 2:22 AM, Hideyuki Yamashita wrote: Hello, Thanks for your comments. Please see my comments inline tagged with [HY]. 04/12/2020 08:51, Hideyuki Yamashita: In general, DPDK application consumes CPU usage because it polls incoming packets using rx_burst API in infinite loop. This m

Re: [dpdk-dev] [PATCH] net/failsafe: fix RSS hash offload reporting

On Fri, Feb 19, 2021, at 08:49, Ferruh Yigit wrote: > On 12/22/2020 8:00 AM, Andrew Rybchenko wrote: > > If sub-devices support RSS hash offload, the offload should be > > reported by the failsafe device since handling is transparent > > from failsafe point of view. > > > > Fixes: 5d308972954c ("e

Re: [dpdk-dev] [RFC] eventdev: introduce event dispatcher

On Thu, 2021-02-18 at 19:30 +0100, Mattias Rönnblom wrote: > The purpose of the event dispatcher is primarily to decouple different > parts of an application (e.g., processing pipeline stages), which > share the same underlying event device. > > The event dispatcher replaces the conditional logic

Re: [dpdk-dev] [PATCH] net/failsafe: report minimum and maximum MTU in device info

On Tue, Dec 22, 2020, at 08:51, Andrew Rybchenko wrote: > Take minimum and maximum MTU values for subdevices and > report maximum of minimums and minimum of maximums. > > Fixes: ad97ceece12c ("ethdev: add min/max MTU to device info") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko > --

[dpdk-dev] [PATCH] net/mlx5: fix UAR allocation diagnostics messages

Depending on kernel capabilities and rdma-core version the mapping of UAR (User Access Region) of desired memory caching type (non-cached or write combining). The PMD implements the flexible strategy of UAR mapping, alternating the type of caching to succeed. During this process the failure diagnos

Re: [dpdk-dev] [PATCH] mem: fix free segment when using huge-unlink option

On 22-Feb-21 10:41 AM, Roy Shterman wrote: When using huge_unlink we unlink the segment right after allocation. Although we unlink the file we keep the fd in fd_list so file still exist just the path deleted. When freeing the hugepage we need to close the fd and assign it with (-1) in fd_list for

Re: [dpdk-dev] dpdk_21.02--kni interface does not work properly

On 2/21/2021 9:45 AM, mirzaei.reza wrote: Hello, I've recently migrated from dpdk-18.05 to dpdk-21.02. I built "kni" example according to this tutorial [1 [1]], every thing is fine except that it has no output packet (no tx). There is a same problem in dpdk-20.11. Have I ignored something? I wou

[dpdk-dev] [PATCH] net/mlx5: fix hashed list size for tunnel flow groups

The hasged list size must be the power of 2, otherwise the adjustment is applied and the warning message is emitted. This patch provides the correct list size to eliminate the warning. Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiien

Re: [dpdk-dev] [PATCH] kni: fix rtnl deadlocks and race conditions

On 2/21/2021 8:03 AM, Elad Nachman wrote: Hi, Regarding the asynchronous call - thought about it, but then the request will always return OK to user-space and I will have no way to return failure error codes back to user-space. Right, let's continue with this patch. Can you please send a new

[dpdk-dev] 19.11.7 patches review and test

Hi all, Here is a list of patches targeted for stable release 19.11.7. The planned date for the final release is 8th March. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validation

Re: [dpdk-dev] [PATCH] net/failsafe: fix RSS hash offload reporting

On 2/22/2021 3:25 PM, Gaëtan Rivet wrote: On Fri, Feb 19, 2021, at 08:49, Ferruh Yigit wrote: On 12/22/2020 8:00 AM, Andrew Rybchenko wrote: If sub-devices support RSS hash offload, the offload should be reported by the failsafe device since handling is transparent from failsafe point of view.

Re: [dpdk-dev] [PATCH] net/failsafe: report minimum and maximum MTU in device info

On 2/22/2021 3:28 PM, Gaëtan Rivet wrote: On Tue, Dec 22, 2020, at 08:51, Andrew Rybchenko wrote: Take minimum and maximum MTU values for subdevices and report maximum of minimums and minimum of maximums. Fixes: ad97ceece12c ("ethdev: add min/max MTU to device info") Cc: sta...@dpdk.org Signed

Re: [dpdk-dev] [PATCH v1 2/2] net/vmxnet3: Provided API to reset vmxnet device

On 2/6/2021 6:05 PM, Yong Wang wrote: -Original Message- From: Dheemanth Mallikarjun Date: Monday, January 4, 2021 at 11:43 AM To: "dev@dpdk.org" Cc: Yong Wang Subject: [PATCH v1 2/2] net/vmxnet3: Provided API to reset vmxnet device The vmxnet3 driver didn't have the dev_reset fu

Re: [dpdk-dev] [PATCH] net: redefine array size macros

On 2/2/2021 12:30 PM, Ferruh Yigit wrote: On 2/1/2021 10:32 PM, Andrew Boyer wrote: On Feb 1, 2021, at 5:28 PM, Thomas Monjalon > wrote: 29/01/2021 23:44, Andrew Boyer: Replace copies of size(arr)/size(arr[0]) with RTE_DIM(). Eventually all of these macro definit

[dpdk-dev] [PATCH v7 0/2] support both PIO and MMIO BAR for legacy device in virtio PMD

From: "huawei.xhw" virtio PMD assumes legacy device only supports PIO BAR resource. This is wrong. As we need to create lots of devices, as PIO resource on x86 is very limited, we expose MMIO(memory IO) BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device, and for all other p

[dpdk-dev] [PATCH v7 1/2] bus/pci: use PCI standard sysfs entry to get PIO address

From: "huawei.xhw" Currently virtio PMD asssumes legacy device uses PIO bar. There are three ways to get PIO(PortIO) address for virtio legacy device. under igb_uio, get pio address from uio/uio# sysfs attribute under uio_pci_generic: for X86, get PIO address from /proc/ioport

[dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does. ioread/write8/16/32 is provided to access PIO/MMIO. By the way, for virtio on arch

Re: [dpdk-dev] [PATCH v7 2/2] bus/pci: support MMIO in PCI ioport accessors

On 2/22/2021 5:15 PM, 谢华伟(此时此刻） wrote: From: "huawei.xhw" With IO BAR, we get PIO(programmed IO) address. With MMIO BAR, we get mapped virtual address. We distinguish PIO(Programmed IO) and MMIO(memory mapped IO) by their address like how kernel does. ioread/write8/16/32 is provided to access

Re: [dpdk-dev] [kmods PATCH] windows/netuio: add vmxnet3 device ID

On Mon, Feb 22, 2021 at 10:20:41AM +0100, David Marchand wrote: > > diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf > > index 666a69c..db97366 100644 > > --- a/windows/netuio/netuio.inf > > +++ b/windows/netuio/netuio.inf > > @@ -42,6 +42,7 @@ HKR,,Icon,,-5 > > %Intel.F101F.Des

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

On Mon, Feb 22, 2021 at 12:48:39PM +, Nick Connolly wrote: > > There seem to be two viable approaches to handling this: > > 1. Expect the platform to provide POSIX semantic (through an external >library >such as Cygwin). That way it becomes "an 'external' problem" and the >DPDK >

Re: [dpdk-dev] [PATCH v4 1/1] net/pcap: imissed stats support

On Thu, Feb 04, 2021 at 06:31:45PM +, Ferruh Yigit wrote: > On 2/4/2021 10:33 AM, Ido Goshen wrote: > > get value from pcap_stats.ps_drop (see man pcap_stats) > > the value is adjusted in this cases: > > - port stop - pcap is closed and will lose count > > - stats reset - pcap doesn't provi

Re: [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member

On 2/9/2021 3:40 PM, Kathleen Capella wrote: The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream structure. Deleting helps improve code readability. Signed-off-by: Kathleen Capella Reviewed-by: Honnappa Nagarahalli Acked-by: Thomas Monjalon Applied

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

For any functions, such as strdup, which are not in a public header I would suggest the following as a possible start point, based off what was done for strlcpy. * In DPDK (probably EAL), define an rte_strdup function for use as a fallback. * Inside the meson build scripts, use "cc.has_func

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

There seem to be two viable approaches to handling this: 1. Expect the platform to provide POSIX semantic (through an external ... I'd prefer not to see this be a requirement of the platform. There have been multiple attempts over the years to provide a POSIX surfaces on Windows which arg

Re: [dpdk-dev] [PATCH v2] ci: update arm64 Travis jobs to Graviton2

Juraj Linkeš writes: >> -Original Message- >> From: Aaron Conole >> Sent: Friday, February 19, 2021 2:27 PM >> To: Juraj Linkeš >> Cc: tho...@monjalon.net; david.march...@redhat.com; >> maicolgabr...@hotmail.com; dev@dpdk.org; ruifeng.w...@arm.com; >> honnappa.nagaraha...@arm.com >> Sub

[dpdk-dev] [PATCH] event/dlb: fix accessing uninitialized variables

This patch updates the PMD to initialize response fields prior to calling into the PF layer. Coverity issue: 366187, 366186, 366184, 366166, 366159, 366158, 366153, 366145, 366127, 366125, 366120 Fixes: 8bb077f44ef2 ("event/dlb: add port unlink and unlinks in progress") Fixes: 6a89

Re: [dpdk-dev] Build errors due to duplicate version.map entries in librte_power

Juraj Linkeš writes: > This seems to have gone unnoticed. > > lib/librte_power/version.map specifies > rte_power_guest_channel_send_msg both under DPDK_21 and EXPERIMENTAL. > > This is causing the clang cross-compile job to always fail with the error > Aaron provided: > ld.lld: error: duplicate

[dpdk-dev] [PATCH] rte_metrics: unconditionally export rte_metrics_tel_xxx functions

From: Jie Zhou This patch allows the same set of rte_metrics_tel_* functions to be exported no matter JANSSON is available or not, by doing following: 1. Leverage dpdk_conf to set configuration flag RTE_HAVE_JANSSON when Jansson dependency is found. 2. In rte_metrics_telemetry.c, levera

Re: [dpdk-dev] [RFC PATCH v2] build: add platform meson option

On 2/19/21 1:11 AM, Juraj Linkeš wrote: -Original Message- From: Bruce Richardson Sent: Wednesday, January 6, 2021 3:43 PM To: David Christensen Cc: Juraj Linkeš ; tho...@monjalon.net; honnappa.nagaraha...@arm.com; dev@dpdk.org Subject: Re: [RFC PATCH v2] build: add platform meson

Re: [dpdk-dev] [PATCH] rte_metrics: unconditionally export rte_metrics_tel_xxx functions

+ Bruce On Mon, 22 Feb 2021 13:25:02 -0800, Jie wrote: [...] > diff --git a/config/meson.build b/config/meson.build > index 3cf560b8a..892bd9677 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -292,6 +292,11 @@ if is_freebsd > add_project_arguments('-D__BSD_VISIBLE', langua

Re: [dpdk-dev] [PATCH v7 06/10] eventdev: make driver-only headers private

There are many vendors (including some internal Microsoft projects) with drivers that are not in the DPDK tree. Breaking them is not something that should be done, and certainly not in a release that claims API/ABI compatibility. Although these fields should not have been exposed to user in normal

Re: [dpdk-dev] [PATCH v2 1/7] eal: add wrappers for POSIX string functions

2021-02-22 14:26, Bruce Richardson: > As you say, though, the main issue will be whether we have instances in > public header files or not. I would hope that no static inline functions in > DPDK use any of the functions in question, but I'm not sure. Perhaps if > there are instances in public heade

[dpdk-dev] [PATCH] app/testpmd: add support for forced ethernet speed

Add support for forced ethernet speed setting. Currently testpmd tries to configure the Ethernet port in autoneg mode. It is not possible to set the Ethernet port to a specific speed while starting testpmd. In some cases capability to configure a forced speed for the Ethernet port during initializa

Re: [dpdk-dev] [PATCH v6 0/9] ethdev: support SubFunction representor

On Sun, 14 Feb 2021 03:21:30 + Xueming Li wrote: > SubFunction [1] is a portion of the PCI device, a SF netdev has its own > dedicated queues(txq, rxq). A SF netdev supports E-Switch representation > offload similar to existing PF and VF representors. A SF shares PCI > level resources with ot

Re: [dpdk-dev] [PATCH] [RFC, v2]: adds support PPS(packet per second) on meter

Thanks for your comments. We changed the struct as below: struct rte_mtr_meter_profile { .. /** Items only valid when alg is set to sprTCM. */ struct { /** Committed Information Packet Rate (CIPR). */ uint64_t cipr

Re: [dpdk-dev] [PATCH] [RFC]: adds support PPS(packet per second) on meter

Yes, RFC2697 is using BPS only. We change srTCM_PPS mode name to sprTCM. Single Packet Rate Three Color Marker (sprTCM) - - similar to IETF RFC 2697 but rate is packet per second. There is no draft or link to this new mode (sprTCM) Regards, Li Zhang > -Original Message- > From: dev On Be

[dpdk-dev] [PATCH] net/iavf: fix the VLAN tag extraction handling

From: Haiyue Wang The new VIRTCHNL_VF_OFFLOAD_VLAN_V2 capability added support that allows the PF to set the location of the RX VLAN tag for stripping offloads. So the VF needs to extract the VLAN tag according to the location flags. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities

[dpdk-dev] [PATCH] l2fwd-crypto: remove padding after decrypting

From: Rohit Raj There were some padding left when a packet gets decrypted. This patch removes those padding. This patch also removes the padding left after verifying auth of the packet. Signed-off-by: Rohit Raj --- examples/l2fwd-crypto/main.c | 14 ++ 1 file changed, 14 insertions

[dpdk-dev] [PATCH] l2fwd-crypto: skip dev configure for masked devices

From: Apeksha Gupta The devices which are masked by cryptodev mask should not be initialized and skipped while traversing the device list. Signed-off-by: Apeksha Gupta --- examples/l2fwd-crypto/main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/l2fwd-crypto/main.c b/exam

[dpdk-dev] [PATCH] l2fwd-crypto: align private data size to cache size

From: Gagandeep Singh L2fwd-crypto is passing 24b private data size while packet pool creation. This patch aligns that private data size to cache line size for better performance results. Signed-off-by: Gagandeep Singh --- app/proc-info/main.c | 2 +- examples/l2fwd-crypto/main.c | 3 +

[dpdk-dev] [PATCH] ptpclient: enable timestamp offload support

This patch add support to enabled rx offload for timestamp. It is required to be enabled for some pmds e.g. dpaa2 Signed-off-by: Gagandeep Singh Signed-off-by: Hemant Agrawal --- examples/ptpclient/ptpclient.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/ptpclient/ptpclient.c

Re: [dpdk-dev] [PATCH v3 1/7] eal: add wrappers for POSIX string functions

On 2/21/21 5:28 PM, Dmitry Kozlyuk wrote: > POSIX strncasecmp(), strdup(), and strtok_r() have different names > on Windows, respectively, strnicmp(), _strdup(), and strtok_s(). > > Add wrappers as inline functions, because they're used from librte_kvargs, > and thus cannot be in librte_eal; besid

Re: [dpdk-dev] [PATCH] net/iavf: fix the VLAN tag extraction handling

Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Leyi Rong > Sent: Tuesday, February 23, 2021 11:11 AM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; Xing, Beilei > Cc: dev@dpdk.org; Wang, Haiyue ; Rong, Leyi >