Do some work for ring refactoring, which includes:
1. add rte prefix before update tail API
2. Move all private APIs into new header files
v2:
1. add rte_ prefixes for private files (Konstantin)
Feifei Wang (3):
test/ring: reduce iteration numbers to make test duration shorter
ring: add rte p
When testing ring performance in the case that multiple lcores are mapped to
the same physical core, e.g. --lcores '(0-3)@10', it takes a very long time
to wait for the "enqueue_dequeue_bulk_helper" to finish. This is because
too much iteration numbers and extremely low efficiency for enqueue and
d
Add __rte prefix before update_tail API because it is a internal
function.
Signed-off-by: Feifei Wang
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Ruifeng Wang
Acked-by: Konstantin Ananyev
---
lib/librte_ring/rte_ring_c11_mem.h | 4 ++--
lib/librte_ring/rte_ring_elem.h| 4 ++--
lib/libr
For legacy modes, rename ring_generic/c11 to ring_generic/c11_pvt.
Furthermore, add new file ring_elem_pvt.h which includes ring_do_eq/deq
and ring element copy/delete APIs.
For other modes, rename xx_c11_mem to xx_elem_pvt. Move all private APIs
into these new header files.
Finally, the external
Acked-by: Xiaoyun Li
> -Original Message-
> From: Yu, DapengX
> Sent: Tuesday, January 26, 2021 15:44
> To: Li, Xiaoyun ; Xing, Beilei ;
> Lu,
> Wenzhuo ; Iremonger, Bernard
> ; step...@networkplumber.org
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH v2] app/testpmd: avoid e
26/01/2021 05:40, Alexander Kozyrev:
> Support IPv6 DSCP modification via the modify_field action.
> Add the ipv6_dscp option for the corresponding header field.
>
> Fixes: 24e1a5e39df ("app/testpmd: support modify field flow action")
>
> Signed-off-by: Alexander Kozyrev
> ---
> app/test-pmd/cm
From: Sunil Kumar Kori
Maximum Rx packet length is getting updated twice which
corrupts actual value.
Fixes: 3151e6a687a3 ("net/octeontx: support MTU")
Cc: sta...@dpdk.org
Signed-off-by: Sunil Kumar Kori
---
drivers/net/octeontx/octeontx_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --g
Hi,
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, January 25, 2021 8:16 PM
> To: Wenzhuo Lu ; Xiaoyun Li
> ; Bernard Iremonger
> ; Steve Yang
> Cc: Ferruh Yigit ; dev@dpdk.org; sta...@dpdk.org;
> lance.richard...@broadcom.com; ouli...@huawei.com; Wisam Monther
> ; lihuis...@h
On 1/21/2021 12:04 PM, Ferruh Yigit wrote:
Meeting minutes of 21 January 2021
--
<...>
Release Dates
-
* v21.02 dates
* -rc1 is released on Tuesday, 19 January 2021
* http://inbox.dpdk.org/dev/4846307.Pfn0FrbqUJ@thomas/
* -rc2
On 1/26/21 7:36 AM, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Tuesday, January 26, 2021 1:15 AM
>> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com;
>> amore...@redhat.com; david.march...@redhat.com
>> Cc: Maxime Coquelin
>> Subjec
In file included from ../drivers/net/virtio/virtio_rxtx_packed.c:22:0:
../drivers/net/virtio/virtio_rxtx_packed_neon.h: In function
‘virtqueue_enqueue_batch_packed_vec’:
../drivers/net/virtio/virtio_rxtx_packed_neon.h:74:2: warning:
implicit declaration of function ‘vreinterpretq_p128_u32’
[-Wimpli
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, January 26, 2021 1:14 AM
> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com;
> amore...@redhat.com; david.march...@redhat.com
> Cc: Maxime Coquelin
> Subject: [PATCH v3 02/44] bus/vdev: add driver IOVA VA mode
On 1/26/21 10:23 AM, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Tuesday, January 26, 2021 1:14 AM
>> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com;
>> amore...@redhat.com; david.march...@redhat.com
>> Cc: Maxime Coquelin
>> Subje
On Tue, Jan 26, 2021 at 10:20 AM Joyce Kong wrote:
>
> In file included from ../drivers/net/virtio/virtio_rxtx_packed.c:22:0:
> ../drivers/net/virtio/virtio_rxtx_packed_neon.h: In function
> ‘virtqueue_enqueue_batch_packed_vec’:
> ../drivers/net/virtio/virtio_rxtx_packed_neon.h:74:2: warning:
> im
On Mon, Jan 25, 2021 at 9:21 PM Alexander Kozyrev wrote:
>
> > From: Stephen Hemminger on Monday, January 25,
> > 2021 22:44
> >
> > On Tue, 26 Jan 2021 03:38:24 +
> > Alexander Kozyrev wrote:
> >
> > > IPv6 DSCP field ID is missing from the original list of Field IDs
> > > for MODIFY_FIELD
On Mon, Jan 25, 2021 at 7:38 PM Alexander Kozyrev wrote:
>
> IPv6 DSCP field ID is missing from the original list of Field IDs
> for MODIFY_FIELD action. Add it to support IPv6 header fully.
>
> Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
>
> Signed-off-by: Alexander Kozyre
From: Dapeng Yu
The original code causes wrong value to be set into PFQF_HENA
register because unnecessary calling to get translated pctype
value for X722 NIC. The result is RSS cannot work.
So remove the unnecessary translation.
Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
Cc: sta...@dp
On Mon, Nov 23, 2020 at 2:48 AM wrote:
>
> From: Pavan Nikhilesh
>
> Enhance Tx path cache locality, remove current tag type and group
> stores from datapath to conserve store buffers.
>
> Signed-off-by: Pavan Nikhilesh
Applied to dpdk-next-net-eventdev/for-main. Thanks
> drivers/event/oc
In file included from ../drivers/net/virtio/virtio_rxtx_packed.c:22:0:
../drivers/net/virtio/virtio_rxtx_packed_neon.h: In function
‘virtqueue_enqueue_batch_packed_vec’:
../drivers/net/virtio/virtio_rxtx_packed_neon.h:74:2: warning:
implicit declaration of function ‘vreinterpretq_p128_u32’
[-Wimpli
This V3 fixes comments from Chenbo on patch 44 and
implements the ABI exception in patch 2.
This series significantly rework Virtio PMD to improve
the Virtio-user PMD and its backends integration.
First part of the series removes the dependency of
Virtio-user ethdev on Virtio PCI, by creating gen
This patch adds an helper macro to get the rte_vdev_device
pointer from a rte_eth_dev pointer.
This is similar to RTE_ETH_DEV_TO_PCI().
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/bus/vdev/rte_bus_vdev.h | 2 ++
1 file changed, 2 insertions(+
This patch adds driver flag in vdev bus driver so that
vdev drivers can require VA IOVA mode to be used, which
for example the case of Virtio-user PMD.
The patch implements the .get_iommu_class() callback, that
is called before devices probing to determine the IOVA mode
to be used, and adds a chec
This patch fixes getting reset status from the restarted
vhost-user backend in case of reconnection, instead of the
status at the time of the disconnection.
This issue was not spotted earlier because Vhost-user
protocol status feature was disabled in server mode.
Fixes: 47235f16505f ("net/virtio-
This patch moves the virtio_hw structure into the virtio_user_dev
structure, with the goal of making virtio_hw bus-agnostic.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_ethdev.c| 2 +-
drivers/net/virtio/virtio_pci.h | 1 -
..
This patch is preliminary work for introducing a bus layer
in Virtio PMD, in order to improve Virtio-user integration.
A new bus type is added to provide a unified way to distinguish
which bus type is used (PCI modern, PCI legacy or Virtio-user).
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenb
This patch initiate refactoring of Virtio PCI, by introducing
a new device structure for PCI-specific metadata.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_ethdev.c | 2 +-
drivers/net/virtio/virtio_pci.c| 2 ++
drivers/net/virtio/virtio_pci.h| 5
This patch moves the PCI Ethernet device registration bits
in a dedicated patch. In following patches, more code will
be moved there, with the goal of making virtio_ethdev.c
truly bus-agnostic.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/meson.build |
This patch moves the PCI specific initialization from
eth_virtio_dev_init() to eth_virtio_pci_init().
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio_ethdev.c | 63 +--
drivers/net/virtio/virtio_pci_ethdev
This patch introduces a new callback to notify the bus
driver some interrupt related operation was done.
This is used by Virtio PCI driver to check msix status.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_ethdev.c | 12 +--
drivers/net/virtio/virti
At least Vhost-user backend of Virtio-user PMD requires
IOVA as VA mode. Until now, it was implemented as a hack
by forcing to use mbuf's buf_addr field instead of buf_iova.
This patch removes all this logic and just fails probing
if IOVA as VA mode is not selected. It simplifies the
code overall,
Going further in making the Virtio ethdev layer bus agnostic,
this patch adds a boolean in the Virtio PCI device metadata.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio_pci.c| 18 +++---
drivers/net/virtio/v
This patch introduces a new callback for device closing,
making virtio_dev_close() bus-agnostic.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/net/virtio/meson.build | 2 --
drivers/net/virtio/virtio_ethdev.c | 13 +
d
This patch provides a new callback for the bus type
to validate negotiated features are compatible with it.
Only user for now is PCI modern bus type, which implies
that the device supports Virtio 1.0+.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_ethdev.
Bus type awareness at the generic ethdev level is no
more needed as previous patches have made it bus-agnostic.
This patch removes it from struct virtio_hw.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio_ethdev.c | 18
This patch moves the fields from virtio_hw structure that
are PCI-specific to virtio_pci_dev_struct.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio_pci.c | 139 ++--
drivers/net/virtio/virtio_pci.h |
This patch improves the virtio_hw struct packing,
going from 88 down to 80 bytes with a 6 bytes hole in
the end of the first cacheline. Fields only used in the
slow path are placed in the end, so that hot path only
uses the first cacheline.
The patch also changes booleans fields to uint8_t type, a
This patch moves Virtio PCI legacy IO handling to
virtio_pci.c. Two functions are created so that
virtio_pci_ethdev does not have to care about it.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio_pci.c| 28 +++
This patch moves virtio_hw and virtio callbacks into
a generic virtio header, now that they have been
curated from PCI references.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio.h | 74 ++
drivers/net/virtio/virtio_ethdev.c
This patch moves all the Virtio definition to the generic
header. It also renames some helpers to no more reference
PCI.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/meson.build| 3 +-
drivers/net/virtio/virtio.c | 22
d
This patch moves the virtqueues defines from PCI header
to the generic one.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio.h| 18 ++
drivers/net/virtio/virtio_ethdev.h | 4 +++-
drivers/net/virtio/virtio_pci.
This patch moves config and status definitions from the PCI
header to the generic one.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio.c | 43 +++
drivers/net/virtio/virtio.h | 50 ++
drivers/net/vi
This patch aims at isolating MSIX notion into PCI
layer.
Signed-off-by: Maxime Coquelin
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio.c | 6
drivers/net/virtio/virtio.h | 11 +--
drivers/net/virtio/virtio_ethdev.c | 7 ++---
drivers/net/virtio
This patch moves vring alignment define to the generic
Virtio header.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio.h | 3 +++
drivers/net/virtio/virtio_ethdev.c | 10 +-
drivers/net/virtio/virtio_pci.
This patch finalizes the bus isolation part of this
refactoring.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
Reviewed-by: David Marchand
---
drivers/net/virtio/virtio_ethdev.c | 21 +---
drivers/net/virtio/virtio_rxtx.c | 18 -
d
This patch implements a dedicated callback for
sending owner request. All the requests will be
converted that way so that backends other than
Vhost-user don't have to work around being it.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h|
This patch makes vhost_user_write() consistent with
vhost_user_read(), by passing a Vhost-user message
pointer instead of a buffer pointer and its length, which
is now calculated in the function.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost_use
This patch introduces new callbacks for getting
and setting Virtio features, and implements them
for the different backend types.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 2 +
drivers/net/virtio/virtio_user/vhost_kernel.c | 150
This patch implements a dedicated callback for
preparing and sending memory table to the backends.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 1 +
drivers/net/virtio/virtio_user/vhost_kernel.c | 60 ++---
drivers/net/virti
This patch introduces new callbacks for getting
and setting Vhost-user protocol features.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 2 +
drivers/net/virtio/virtio_user/vhost_user.c | 64 +--
drivers/net/virtio/v
This patch introduces new callbacks for setting
and getting vring state.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 3 +
drivers/net/virtio/virtio_user/vhost_kernel.c | 49 +++-
drivers/net/virtio/virtio_user/vhost_user.c
This patch introduces new callbacks for setting
vring files (kick and call).
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 2 +
drivers/net/virtio/virtio_user/vhost_kernel.c | 41 +++--
drivers/net/virtio/virtio_user/vhos
This patch introduces a new callback for setting
vrings addresses.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 1 +
drivers/net/virtio/virtio_user/vhost_kernel.c | 32 +--
drivers/net/virtio/virtio_user/vhost_user.c
This patch introduces new callbacks to
get and set the device status.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 2 +
drivers/net/virtio/virtio_user/vhost_kernel.c | 14 ++
drivers/net/virtio/virtio_user/vhost_user.c | 121 +++
This patch adds error logs and propagates errors reported
by the backend. It also adds the device path in error logs
to make it easier to distinguish which device is facing the
issue.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
.../net/virtio/virtio_user/virtio_user_dev.c | 154
Now that we have a proper isolation of the backends,
we can move Vhost-user requests declaration to the
Vhost-user backend file.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h | 25 -
drivers/net/virtio/virtio_user/vhos
Now that all the ops have been implemented, we
can remove the send_request ops for all backends.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 15 +--
drivers/net/virtio/virtio_user/vhost_kernel.c | 43
drivers/net/virtio/v
This patch makes the Vhost-user backend server mode
blocking at init, waiting for the client connection.
The goal is to make the driver more reliable, as without
waiting for client connection, the Virtio driver has to
assume the Vhost-user backend will support all the
features it has advertized, w
The goal of this patch is to introduce backend-specific
data in order to better isolate what is backend-specific
from what is generic to Virtio-user.
For now, only Vhost-user protocol features are moved to
Vhost-user backend data.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
driv
Since only protocol features are specific to Vhost-user
backend, this patch moves all related code to Vhost-user
file.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost.h| 20 +
drivers/net/virtio/virtio_user/vhost_kernel.c | 9 ++
driv
As done earlier for Vhost-user, this patch moves the
Vhost-Kernel specific data to its backend file.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost_kernel.c | 106 +++---
.../net/virtio/virtio_user/virtio_user_dev.c | 43 ++-
..
This patch moves all the Vhost-user backend specific
logic like Vhost FD, listen FD and interrupt handling
to the vhost-user backend implementation.
In order to achieve that, new ops are created to update
the link status, disconnect and reconnect the server,
and fetch the link state interrupt FD.
As done earlier for Vhost-user and Vhost-kernel, this
patch moves the Vhost-vDPA specific data to its backend
file.
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost_vdpa.c | 120 +-
.../net/virtio/virtio_user/virtio_user_dev.h |
This patch improves error logging in vhost_user_read,
especially printing errno when recv() fails.
Suggested-by: Adrian Moreno
Signed-off-by: Maxime Coquelin
Reviewed-by: Chenbo Xia
---
drivers/net/virtio/virtio_user/vhost_user.c | 31 -
1 file changed, 18 insertions(+), 13
This patch fixes virtio_user_dev_setup() error path,
by cleaning all resources it allocates. It introduces
virtio_user_dev_uninit_notify() that cleans all open
FDs. It implies assigning all FDs to -1 at init time.
With these changes done, virtio_user_dev_init_notify()
can be simplified.
Suggested
On 1/21/21 9:13 PM, Matan Azrad wrote:
>
>
> From: Maxime Coquelin
>> On 1/14/21 4:23 PM, Matan Azrad wrote:
>>>
>>>
>>> From: Maxime Coquelin
On 1/14/21 2:09 PM, Matan Azrad wrote:
>
>
> From: Maxime Coquelin
>> Hi Matan,
>>
>> On 1/14/21 12:49 PM, Matan Azrad wro
21/01/2021 16:51, Juraj Linkeš:
> Reorganize and update the aarch64 cross guide with clang cross
> compilation. Update the GNU toolchain version which clang also uses.
> Reorganize into common part, GNU part and clang part.
>
> Signed-off-by: Juraj Linkeš
> Acked-by: Ruifeng Wang
I fix some spa
From: Viacheslav Ovsiienko
> This patch adds support of the mbuf fast free offload to the transmit
> datapath.
> This offload allows to free the mbufs on transmit completion in the most
> efficient way. It requires the all mbufs were allocated from the same pool,
> have the reference counter v
On 1/22/21 8:25 AM, 谢华伟(此时此刻） wrote:
>
> On 2021/1/21 23:38, Maxime Coquelin wrote:
>>> Do you mean we apply or abandon patch 3? I am both OK. The first
>>> priority to me is to enable MMIO bar support.
>> OK, so yes, I think we should abandon patch 2 and patch 3.
>> For patch 1, it looks valid
From: Maxime Coquelin
> > From: Maxime Coquelin
> >> On 1/14/21 4:23 PM, Matan Azrad wrote:
> >>>
> >>>
> >>> From: Maxime Coquelin
> On 1/14/21 2:09 PM, Matan Azrad wrote:
> >
> >
> > From: Maxime Coquelin
> >> Hi Matan,
> >>
> >> On 1/14/21 12:49 PM, Matan Azrad wro
On Fri, Jan 22, 2021 at 10:49 AM Feifei Wang wrote:
>
> Fix bugs of app eventdev
>
> Feifei Wang (2):
> app/eventdev: adjust event count order for pipeline test
> app/eventdev: remove redundant enqueue in burst Tx
Acked-by: Jerin Jacob
Applied to dpdk-next-net-eventdev/for-main. Thanks
>
>
On 1/26/2021 3:45 AM, Lance Richardson wrote:
On Mon, Jan 25, 2021 at 7:44 PM Ferruh Yigit wrote:
+ if (rx_offloads != port->dev_conf.rxmode.offloads) {
+ uint16_t qid;
+
+ port->dev_conf.rxmode.offloads = rx_offloads;
+
+ /* Apply JUMBO_FRAME o
On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote:
> On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson
> wrote:
> >
> > As a general principle, each header file should include any other
> > headers it needs to provide data type definitions or macros. For
> > example, any header using t
> For legacy modes, rename ring_generic/c11 to ring_generic/c11_pvt.
> Furthermore, add new file ring_elem_pvt.h which includes ring_do_eq/deq
> and ring element copy/delete APIs.
>
> For other modes, rename xx_c11_mem to xx_elem_pvt. Move all private APIs
> into these new header files.
>
> Fin
> Juraj Linkeš (3):
> build: add aarch64 clang to meson cross-compile
> ci: add aarch64 clang cross-compilation builds
> doc: add clang to aarch64 cross build guide
Applied with doc fixups, thanks
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, January 26, 2021 6:16 PM
> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com;
> amore...@redhat.com; david.march...@redhat.com
> Cc: Maxime Coquelin
> Subject: [PATCH v4 02/44] bus/vdev: add driver IOVA VA mode requirement
20/01/2021 15:25, Ray Kinsella:
> Update the ignore entry for crytodev to use named fields instead of
> bit positions.
>
> Fixes: 1c3ffb9559
>
> Signed-off-by: Ray Kinsella
> ---
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -15,4 +15,4 @@
> ; Ignore fields inse
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Tuesday, January 26, 2021 6:17 PM
> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com;
> amore...@redhat.com; david.march...@redhat.com
> Cc: Maxime Coquelin
> Subject: [PATCH v4 44/44] net/virtio: handle Virtio-user se
On 2021/1/22 15:25, chris wrote:
On 2021/1/21 23:38, Maxime Coquelin wrote:
Do you mean we apply or abandon patch 3? I am both OK. The first
priority to me is to enable MMIO bar support.
OK, so yes, I think we should abandon patch 2 and patch 3.
For patch 1, it looks valid to me, but I'll le
On 1/26/21 1:30 PM, 谢华伟(此时此刻） wrote:
>
> On 2021/1/22 15:25, chris wrote:
>>
>> On 2021/1/21 23:38, Maxime Coquelin wrote:
Do you mean we apply or abandon patch 3? I am both OK. The first
priority to me is to enable MMIO bar support.
>>> OK, so yes, I think we should abandon patch 2 a
On Tue, Jan 26, 2021 at 11:16 AM Maxime Coquelin
wrote:
>
> This patch adds driver flag in vdev bus driver so that
> vdev drivers can require VA IOVA mode to be used, which
> for example the case of Virtio-user PMD.
>
> The patch implements the .get_iommu_class() callback, that
> is called before
In E-Switch steering domain there was dedicated default miss action
created for every sampling flow.
The patch replaces this one with the global default miss action.
Cc: sta...@dpdk.org
Signed-off-by: Jiawei Wang
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow.h| 1 -
driver
This patchset fixes the E-Switch sampling flow creation issue, and also uses
the global
default miss for each E-Switch sampling flow.
Jiawei Wang (2):
net/mlx5: fix the E-Switch sample action creation failure
net/mlx5: use global default miss for E-Switch sampling
drivers/net/mlx5/mlx5_flow
This patch fixes the incorrect checking for the return value
of default miss action creation.
Fixes: 14020ad53d4e ("net/mlx5: wrap default miss flow action per OS")
Cc: sta...@dpdk.org
Signed-off-by: Jiawei Wang
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
1 file
On 1/26/21 1:02 PM, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Tuesday, January 26, 2021 6:17 PM
>> To: dev@dpdk.org; Xia, Chenbo ; olivier.m...@6wind.com;
>> amore...@redhat.com; david.march...@redhat.com
>> Cc: Maxime Coquelin
>> Subjec
On 1/26/21 11:45 AM, Matan Azrad wrote:
>
>
> From: Maxime Coquelin
>>> From: Maxime Coquelin
On 1/14/21 4:23 PM, Matan Azrad wrote:
>
>
> From: Maxime Coquelin
>> On 1/14/21 2:09 PM, Matan Azrad wrote:
>>>
>>>
>>> From: Maxime Coquelin
Hi Matan,
>
From: Hemant Agrawal
We need to differentiate between crypto and ethernet security
context as they belong to different devices.
Fixes: d82d6ac64338 ("app/procinfo: add crypto security context info")
Cc: sta...@dpdk.org
Signed-off-by: Hemant Agrawal
Signed-off-by: Thomas Monjalon
---
v3: inclu
26/01/2021 14:06, Thomas Monjalon:
> From: Hemant Agrawal
>
> We need to differentiate between crypto and ethernet security
> context as they belong to different devices.
>
> Fixes: d82d6ac64338 ("app/procinfo: add crypto security context info")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Hemant A
On 26/01/2021 12:50, David Marchand wrote:
> On Tue, Jan 26, 2021 at 11:16 AM Maxime Coquelin
> wrote:
>>
>> This patch adds driver flag in vdev bus driver so that
>> vdev drivers can require VA IOVA mode to be used, which
>> for example the case of Virtio-user PMD.
>>
>> The patch implements t
On Mon, Jan 25, 2021 at 11:22 PM Pavan Nikhilesh Bhagavatula
wrote:
>
> >Move eth stop code from "signal_handler" function to the end of
> >"main"
> >function. There are two reasons for this:
> >
> >First, this improves code maintenance and makes code look simple and
> >clear. Based on this change
On Tue, Jan 26, 2021 at 12:15 PM Bruce Richardson
wrote:
>
> On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote:
> > On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson
> > wrote:
> > >
> > > As a general principle, each header file should include any other
> > > headers it needs to prov
As a general principle, each header file should include any other
headers it needs to provide data type definitions or macros. For
example, any header using the uintX_t types in structures or function
prototypes should include "stdint.h" to provide those type definitions.
In practice, while many,
Include 'rte_branch_prediction.h' to get the likely/unlikely macro
definitions.
Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
lib/librte_eal/include/generic/rte_mcslock.h | 1 +
1 file changed, 1 insertion(+)
diff --
Clang does not have an "error" attribute for functions, so for marking
internal functions we need to check for the error attribute, and provide
a fallback if it is not present. For clang, we can use "diagnose_if"
attribute, similarly checking for its presence before use.
Fixes: fba5af82adc8 ("eal:
The rte_rib6 header was using RTE_MIN macro from rte_common.h but not
including the header file.
Fixes: f7e861e21c46 ("rib: support IPv6")
Cc: vladimir.medved...@intel.com
Signed-off-by: Bruce Richardson
---
lib/librte_rib/rte_rib6.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librt
For some libraries, there may be some header files which are not for direct
inclusion, but rather are to be included via other header files. To allow
later checking of these files for missing includes, we separate out the
indirect include files from the direct ones.
Signed-off-by: Bruce Richardson
To verify that all DPDK headers are ok for inclusion directly in a C file,
and are not missing any other pre-requisite headers, we can auto-generate
for each header an empty C file that includes that header. Compiling these
files will throw errors if any header has unmet dependencies.
To ensure on
The check-includes script allowed checking header files in a given
directory to ensure that each header compiled alone without requiring
any other header inclusions.
With header checking now being done by the chkincs app in the build
system this script can be removed.
Signed-off-by: Bruce Richard
For CI builds, turn on the checking of includes.
Signed-off-by: Bruce Richardson
---
For simplicity, this patch just enables the header includes checks globally,
rather than just limiting it to certain builds. Since the C files generated are
all just a single #include line , the extra compilatio
On 26/01/2021 14:18, Bruce Richardson wrote:
The rte_rib6 header was using RTE_MIN macro from rte_common.h but not
including the header file.
Fixes: f7e861e21c46 ("rib: support IPv6")
Cc: vladimir.medved...@intel.com
Signed-off-by: Bruce Richardson
---
lib/librte_rib/rte_rib6.h | 1 +
1
On Tue, Jan 26, 2021 at 03:04:25PM +0100, David Marchand wrote:
> On Tue, Jan 26, 2021 at 12:15 PM Bruce Richardson
> wrote:
> >
> > On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote:
> > > On Mon, Jan 25, 2021 at 3:11 PM Bruce Richardson
> > > wrote:
> > > >
> > > > As a general pri
1 - 100 of 212 matches
Mail list logo
