[dpdk-dev] [PATCH] net/failsafe: fix RSS hash offload reporting

If sub-devices support RSS hash offload, the offload should be reported by the failsafe device since handling is transparent from failsafe point of view. Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/failsaf

[dpdk-dev] [PATCH] net/i40e: refactor of hash flow

From: Alvin Zhang 1. Delete original code. 2. Add 2 tables(One maps flow pattern and RSS type to PCTYPE, another maps RSS type to input set). 3. Parse RSS pattern and RSS type to get PCTYPE. 4. Parse RSS action to get queues, RSS function and hash field. 5. Create and destroy RSS filters. 6. C

Re: [dpdk-dev] [PATCH v1 2/2] net/iavf: introduce iavf driver on vfio-user client

Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Saturday, December 19, 2020 10:38 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Xing, Beilei > ; > Xia, Chenbo ; Lu, Xiuchun > Subject: [PATCH v1 2/2] net/iavf: introduce iavf driver on vfio-user client > > This patch add a ne

[dpdk-dev] [PATCH v1] app/testpmd: fix dynamic config error for max-pkt-len

When 'max-pkt-len' value caused the 'rx_offloads' flag change, the all offloads of rx queues ('rx_conf[qid].offloads') weren't synchronized, that will cause the offloads check failed with 'rx_queue_offload_capa' within 'rte_eth_rx_queue_setup'. Apply rx offloads configuration once it changed when

[dpdk-dev] [PATCH v2 0/2] examples/vhost: sample code refactor

Refactor the vhost sample code. Add ioat ring space count and check in ioat callback, optimize vhost data path for batch enqueue, replase rte_atomicNN_xxx to atomic_XXX and refactor vhost async data path. --- v2: * optimized patch structure * optimized git log * replased rte_atomicNN_xxx to atom

[dpdk-dev] [PATCH v2 1/2] examples/vhost: add ioat ring space count and check

Add ioat ring space count and check, if ioat ring space is not enough for the next async vhost packet enqueue, then just return to prevent enqueue failure. Signed-off-by: Cheng Jiang --- examples/vhost/ioat.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/exa

[dpdk-dev] [PATCH v2 2/2] examples/vhost: refactor vhost data path

Change the vm2vm data path to batch enqueue for better performance. Support latest async vhost API, refactor vhost async data path, replase rte_atomicNN_xxx to atomic_XXX and clean some codes. Signed-off-by: Cheng Jiang --- examples/vhost/main.c | 163 +-

Re: [dpdk-dev] [PATCH 0/8] Introduce emudev library and iavf emudev driver

Hi Chenbo, Thanks for the detailed reply. On 12/22/20 4:09 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, December 21, 2020 8:02 PM >> To: Xia, Chenbo ; Thomas Monjalon >> ; >> David Marchand >> Cc: dev ; Stephen Hemminger ; >> L

[dpdk-dev] [PATCH] net/failsafe: report minimum and maximum MTU in device info

Take minimum and maximum MTU values for subdevices and report maximum of minimums and minimum of maximums. Fixes: ad97ceece12c ("ethdev: add min/max MTU to device info") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/failsafe/failsafe_ops.c | 4 1 file changed, 4 inser

Re: [dpdk-dev] [PATCH 5/5] librte_ethdev: add to use apistats

> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hideyuki Yamashita > Sent: Tuesday, December 22, 2020 3:50 AM > > Hello, > > Thanks for your comments. > Please see my comments inline tagged with [HY]. > > > > diff --git a/lib/librte_ethdev/rte_ethdev.h > b/lib/librte_ethdev/rte_ethdev.h >

[dpdk-dev] net/ena: traffic lock

Dpdk: 19.11 Driver: ena During longevity(after 24+ hrs) testing at 10Gbps, one of tx-queue is getting into unrecoverable state ( its not able to find enough tx-descriptor nor its freeing up). So for every tx-burst, eth_ena_xmit_pkts() neither finds free tx-descriptor nor able to free txd (en

Re: [dpdk-dev] [PATCH v3 1/3] build: add aarch64 clang to meson cross-compile

> -Original Message- > From: dev On Behalf Of Juraj Linke? > Sent: Friday, October 2, 2020 5:38 PM > To: tho...@monjalon.net; david.march...@redhat.com; > acon...@redhat.com; maicolgabr...@hotmail.com > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [dpdk-dev] [PATCH v3 1/3] build: add aarch6

Re: [dpdk-dev] [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

>Add release barriers before updating the processed packets for worker >lcores to ensure the worker lcore has really finished data processing >and then it can update the processed packets number. > I believe we can live with minor inaccuracies in stats being presented as atomics are pretty heavy

Re: [dpdk-dev] [PATCH v2] net/virtio-user: fix advertising of protocol features

On 12/18/20 2:23 PM, Olivier Matz wrote: > When connected to a vhost-user backend, the flag > VHOST_USER_F_PROTOCOL_FEATURES is not advertised, preventing to do > multiqueue (the VHOST_USER_PROTOCOL_F_MQ protocol feature is ignored by > some backends if the VHOST_USER_F_PROTOCOL_FEATURES feature

Re: [dpdk-dev] [PATCH 21.02 1/3] vhost: refactor postcopy region registration

Hi Chenbo, On 12/9/20 3:16 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, November 16, 2020 7:36 PM >> To: dev@dpdk.org; Xia, Chenbo ; Ding, Xuan >> >> Cc: Maxime Coquelin >> Subject: [PATCH 21.02 1/3] vhost: refactor postcopy regi

Re: [dpdk-dev] [PATCH 21.02 v2 1/2] net/virtio: fix missing backend features negotiation

On 12/21/20 7:23 AM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, November 25, 2020 11:21 PM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; >> jasow...@redhat.com; david.march...@redhat.com >> Cc: Maxime Coquelin ; sta...

Re: [dpdk-dev] [PATCH v1 1/2] app/test: remove unnecessary barriers for ring stress test

Hi Feifei, > > The variable "wrk_cmd" is a signal to control threads from running and > stopping. When worker lcores load "wrk_cmd == WRK_CMD_RUN", they start > running and when worker lcores load "wrk_cmd == WRK_CMD_STOP", they > stop. > > For the wmb in test_mt1, no storing operations must kee

Re: [dpdk-dev] [PATCH 5/5] librte_ethdev: add to use apistats

> Hello, > > Thanks for your comments. > Please see my comments inline tagged with [HY]. > > > Hi, > > > > > > > > This patch modifies to use apistats by librte_ethdev. > > > > > > Signed-off-by: Hideyuki Yamashita > > > --- > > > lib/librte_ethdev/meson.build| 6 ++- > > > lib/librte_ethd

[dpdk-dev] [PATCH 0/3] vhost: make virtqueue cache-friendly

As done for Virtio PMD, this series improves cache utilization of the vhost_virtqueue struct by removing unused field, make the live-migration cache dynamically allocated at live-migration setup time and by moving fields around so that hot fields are on the first cachelines. With this series, The

[dpdk-dev] [PATCH 1/3] vhost: remove unused Vhost virtqueue field

This patch removes the "backend" field of the vhost_virtqueue struct, which is not used by the library. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 2 -- lib/librte_vhost/vhost.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/v

[dpdk-dev] [PATCH 3/3] vhost: optimize vhost virtqueue struct

This patch moves vhost_virtuqueue struct fields in order to both optimize packing and move hot fields on the first cachelines. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 52 +--- 1 file changed, 27 insertions(+), 25 deletions(-) diff --git

[dpdk-dev] [PATCH 2/3] vhost: move dirty logging cache out of the virtqueue

This patch moves the per-virtqueue's dirty logging cache out of the virtqueue struct, by allocating it dynamically only when live-migration is enabled. It saves 8 cachelines in vhost_virtqueue struct. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 12 lib/librte

[dpdk-dev] [PATCH v7 0/2] support enqueue & dequeue callbacks on cryptodev

In an eventdev world, multiple workers (with ordered queue) will be working on IPsec ESP processing. The ESP header's sequence number is unique and has to be sequentially incremented in an orderly manner. This rises a need for incrementing sequence number in crypto stage especially in event crypto

[dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions

This patch adds APIs to add/remove callback functions on crypto enqueue/dequeue burst. The callback function will be called for each burst of crypto ops received/sent on a given crypto device queue pair. Signed-off-by: Abhinandan Gujjar Acked-by: Konstantin Ananyev --- config/rte_config.h

[dpdk-dev] [PATCH v7 2/2] test: add testcase for crypto enqueue and dequeue callback

This patch adds test cases for testing functionality of enqueue and dequeue callback mechanism. Signed-off-by: Abhinandan Gujjar Acked-by: Konstantin Ananyev --- app/test/test_cryptodev.c | 244 +- 1 file changed, 242 insertions(+), 2 deletions(-) diff --git

Re: [dpdk-dev] [PATCH 40/40] net/virtio: move Vhost-vDPA data to its backend

On 12/20/20 10:14 PM, Maxime Coquelin wrote: > As done earlier for Vhost-user and Vhost-kernel, this > patch moves the Vhost-vDPA specific data to its backend > file. > > Signed-off-by: Maxime Coquelin > --- > drivers/net/virtio/virtio_user/vhost_vdpa.c | 77 ++- > .../net/v

[dpdk-dev] [dpdk-announce] DPDK Summit APAC - CFP is NOW OPEN!

DPDK Community, We are pleased to announce that the Call for Proposals (CFP) and Registration for the upcoming DPDK Summit APAC , which takes place virtually March 22-23, are now open. The DPDK Summit APAC is a community event focused on softw

[dpdk-dev] net/ena: traffic lock

Dpdk: 19.11 Driver: ena During longevity(after 24+ hrs) testing at 10Gbps, one of tx-queue is getting into unrecoverable state ( its not able to find enough tx-descriptor nor its freeing up). So for every tx-burst, eth_ena_xmit_pkts() neither finds free tx-descriptor nor able to free txd (ena_

Re: [dpdk-dev] [PATCH 0/9] Introduce vfio-user library

> Hello, > > On Fri, Dec 18, 2020 at 8:54 AM Chenbo Xia wrote: > > *librte_vfio_user* library is an implementation of VFIO-over-socket[1] > (also > > known as vfio-user) which is a protocol that allows a device to be > > virtualized > > in a separate process outside of QEMU. > > What is the sta

Re: [dpdk-dev] DPDK ENA PMD spurious ierrors

Hi Roger, Thanks for reporting this. Your suggestion seems like a valid workaround, we’ll work on preparing it. Regards, Igor From: Roger Melton (rmelton) Sent: Thursday, December 17, 2020 01:57 To: dev@dpdk.org; m...@semihalf.com; m...@semihalf.com; Tzalik, Guy ; Chauskin, Igor S

Re: [dpdk-dev] DPDK ENA PMD spurious ierrors

Hi Roger, We plan to address both issues. Thanks, Igor From: Roger Melton (rmelton) Sent: Friday, December 18, 2020 20:37 To: Chauskin, Igor ; dev@dpdk.org; m...@semihalf.com; m...@semihalf.com; Tzalik, Guy Subject: RE: [EXTERNAL] DPDK ENA PMD spurious ierrors CAUTION: This em

Re: [dpdk-dev] net/ena: traffic lock

Hi Rajesh, For the tx queue getting into unrecoverable state - can you please share the details of your usecase? (instance types, traffic type, number of queues in use, etc.). Also, please share your instances ids, if possible. Regarding prepare_ctx_err counter - under certain circumstances

Re: [dpdk-dev] [PATCH v4] eal: add generic thread-local-storage functions

> [...] > +int > +rte_thread_tls_set_value(rte_tls_key key, const void *value) > +{ > + int err; > + > + if (!key) { > + RTE_LOG(DEBUG, EAL, "invalid tls key passed to function.\n"); > + return -1; > + } > + err = pthread_setspecific(key->thread_index, value)

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix dynamic config error for max-pkt-len

Hi Comments inline > -Original Message- > From: dev On Behalf Of Steve Yang > Sent: Tuesday, December 22, 2020 16:14 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei ; > Iremonger, Bernard ; Yang, SteveX > > Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix dynamic config error for max-

Re: [dpdk-dev] [PATCH v2] net/iavf: fix negative GTP-U flow rules create successfully

Hi, murphy > -Original Message- > From: Murphy Yang > Sent: Friday, December 18, 2020 2:19 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Yang, SteveX > ; Guo, Jia ; Wu, Jingjing > ; Xing, Beilei ; Yang, > MurphyX > Subject: [PATCH v2] net/iavf: fix negative GTP-U flow rules create > success

Re: [dpdk-dev] [PATCH v6 0/4] fix issue with partial DMA unmap

Ping. On Fri, Dec 18, 2020 at 12:36:00AM +0530, Nithin Dabilpuram wrote: > Partial DMA unmap is not supported by VFIO type1 IOMMU > in Linux. Though the return value is zero, the returned > DMA unmap size is not same as expected size. > So add test case and fix to both heap triggered DMA > mapping

Re: [dpdk-dev] [PATCH 0/8] Introduce emudev library and iavf emudev driver

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, December 22, 2020 4:49 PM > To: Xia, Chenbo ; Thomas Monjalon ; > David Marchand > Cc: dev ; Stephen Hemminger ; Liang, > Cunming ; Lu, Xiuchun ; Li, > Miao ; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH 0/8] Intr

[dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration

From: Alvin Zhang Check if there are enough queue pairs currently allocated, and if not, request PF to allocate them. Fixes: e436cd43835b ("net/iavf: negotiate large VF and request more queues") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/iavf/iavf_ethdev.c | 4 +++- 1 file

[dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init

From: YU DAPENG When RSS is initialized, rx queues number is used as denominator to set default value into the RSS lookup table. If it is zero, there will be error of being divided by 0. So add value check to avoid the error. Fixes: 50370662b727 ("net/ice: support device and queue ops") Cc: sta.

Re: [dpdk-dev] [PATCH 21.02 v2 1/2] net/virtio: fix missing backend features negotiation

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, December 22, 2020 6:56 PM > To: Xia, Chenbo ; dev@dpdk.org; amore...@redhat.com; > jasow...@redhat.com; david.march...@redhat.com > Cc: sta...@dpdk.org > Subject: Re: [PATCH 21.02 v2 1/2] net/virtio: fix missing back

Re: [dpdk-dev] [PATCH] app/testpmd: increase array for fetching supported FEC caps

Hi > -Original Message- > From: dev On Behalf Of Rahul Lakkireddy > Sent: Monday, December 21, 2020 06:47 > To: dev@dpdk.org > Cc: kaara.sat...@chelsio.com > Subject: [dpdk-dev] [PATCH] app/testpmd: increase array for fetching supported > FEC caps > > From: Karra Satwik > > Request the

Re: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration

Hi, Alvin, > -Original Message- > From: Zhang,Alvin > Sent: Wednesday, December 23, 2020 1:30 PM > To: Xing, Beilei ; Xu, Ting > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH] net/iavf: fix queue pairs configuration > > From: Alvin Zhang > > Check if there are en

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC array

Acked-by: Xiaoyun Li > -Original Message- > From: stable On Behalf Of Rahul Lakkireddy > Sent: Monday, December 21, 2020 06:47 > To: dev@dpdk.org > Cc: kaara.sat...@chelsio.com; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH] app/testpmd: fix start index for showing FEC > array > > Fro

Re: [dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init

Hi, Dapeng Regards, Chen Bo > -Original Message- > From: dev On Behalf Of dapengx...@intel.com > Sent: December 23, 2020 13:30 > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init >

[dpdk-dev] [PATCH v3] net/iavf: fix invalid RSS combinations rule can be created

Currently, when use 'flow' command to create a rule that combine with several RSS types, even the RSS type combination is invalid, it also be created successfully. Here list some invalid RSS combinations: - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP - ETH_

Re: [dpdk-dev] [PATCH] net/iavf: fix queue pairs configuration

Hi Xuting, Thanks for your reply. It's very efficient for CVL. But the FVL PF provides default 4 queue pairs to VF, if every VF request 16 queue pairs, there may be not enough queues pairs for all VFs. BR, Alvin > -Original Message- > From: Xu, Ting > Sent: Wednesday, December 23, 202

Re: [dpdk-dev] [PATCH] net/ice: check Rx queue number on RSS init

Hi Chen Bo, Without this patch, I have reproduced your unexpected test result on XXV710(with i40e pmd driver). That means the unexpected situation as the below is a new issue different from the original one that this patch try to resolve. The unexpected is not caused by the patch. The unexpected