[dpdk-dev] [RFC] net/ionic: update MTU calculations

This RFC is in response to the threads about testpmd mtu settings and the deprecation of max-rx-pkt-len. It took us a while to figure out what we were supposed to be doing in this part of the API. It is not clear if max_rx_pkt_len should be an input to or an output from the PMD. The code below re

[dpdk-dev] [PATCH v5 0/9] net/ionic: minor updates and documentation

These patches make some minor changes to the ionic PMD. Signed-off-by: Andrew Boyer --- v5: * Fix syntax error in .rst file v4: * Address additional reviewer comments v3: * Fixed up false-positives from codespell and gcc 8.3/9.3 v2: * Address Ferruh's comments (thank you!) * Switch to net/ion

[dpdk-dev] [PATCH v5 1/9] net/ionic: connect ionic to the build system

Otherwise the ionic PMD is never built. Signed-off-by: Andrew Boyer --- drivers/net/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/meson.build b/drivers/net/meson.build index 29f477750..6e4aa6bf3 100644 --- a/drivers/net/meson.build +++ b/drivers/net/meson.build @@ -

[dpdk-dev] [PATCH v5 2/9] net/ionic: update interface file to the latest version

The ionic_if.h file contains the firmware interface definitions. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_if.h | 1343 ++-- drivers/net/ionic/ionic_regs.h |3 - 2 files changed, 930 insertions(+), 416 deletions(-) diff --git a/drivers/net/ionic/i

[dpdk-dev] [PATCH v5 3/9] net/ionic: update documentation and MAINTAINERS

The UNMAINTAINED flag will be removed in a future patch. Signed-off-by: Andrew Boyer --- MAINTAINERS| 2 +- doc/guides/nics/features/ionic.ini | 1 + doc/guides/nics/ionic.rst | 13 +++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/MA

[dpdk-dev] [PATCH v5 4/9] net/ionic: check for cmd completion more frequently

This reduces the startup time a bit. Signed-off-by: Neel Patel Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.h | 4 +++- drivers/net/ionic/ionic_main.c | 36 - drivers/net/ionic/ionic_osdep.h | 10 - 3 files changed, 21 insertions(+), 29

[dpdk-dev] [PATCH v5 5/9] net/ionic: remove some unused fields

This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h| 1 - drivers/net/ionic/ionic_dev.c| 5 + drivers/net/ionic/ionic_dev.h| 7 +-- drivers/net/ionic/ionic_ethdev.c | 2 -- drivers/net/ionic/ionic_lif.c| 22 ++ d

[dpdk-dev] [PATCH v5 6/9] net/ionic: convert 'deferred' boolean to a flag bit

This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 10 ++ 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/i

[dpdk-dev] [PATCH v5 7/9] net/ionic: warn if loopback mode is requested

The ionic FW does not support loopback mode at this time. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c index cd79f250e..ce6ca9671 100644 --- a/drivers/ne

[dpdk-dev] [PATCH v5 8/9] net/ionic: minor refactorings and helper variables

This makes the code clearer and conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 15 ++- drivers/net/ionic/ionic_main.c | 18 +++--- 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drive

[dpdk-dev] [PATCH v5 9/9] net/ionic: minor logging fixups

Expose ionic_opcode_to_str() so it can be used for dev cmds, too. Store the device name in struct adapter. Switch to memcpy() to work around gcc false positives. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic.h| 1 + drivers/net/ionic/ionic_dev.c| 5 drivers/net/ioni

Re: [dpdk-dev] [PATCH] Remove printf from signal handler.

Hi I don't have a good solution here. Removing doesn't seem a good idea because there are many important alerts or reminders in all of those function calls and they may be called in other places too. I think replacing with "write" can't solve the problem too. Because behavior like stopping port

<    1   2