Re: [dpdk-dev] [RFC] net: make eCPRI header host network order

2020-11-28 Thread Bing Zhao
Hi Haiyue & Ferruh, PSB > -Original Message- > From: Wang, Haiyue > Sent: Saturday, November 28, 2020 1:31 PM > To: Bing Zhao ; Yigit, Ferruh > ; Olivier Matz > Cc: dev@dpdk.org; Stephen Hemminger > Subject: RE: [RFC] net: make eCPRI header host network order > > External email: Use c

[dpdk-dev] [PATCH] net/virtio-user: fix error run close(0)

2020-11-28 Thread Jiawei Zhu
From: Jiawei Zhu When i < VIRTIO_MAX_VIRTQUEUES and j == i, dev->callfds[i] and dev->kickfds[i] are default 0. So it will close(0), close the standard input (stdin). Fixes: e6e7ad8b3024 ("net/virtio-user: move eventfd open/close into init/uninit") Cc: sta...@dpdk.org Signed-off-by: Jiawei Zhu

Re: [dpdk-dev] [PATCH 1/3] MAINTAINERS remove experimental tag from vdev_netvsc

2020-11-28 Thread Stephen Hemminger
On Tue, 06 Oct 2020 00:41:55 +0200 Thomas Monjalon wrote: > 15/09/2020 16:47, Stephen Hemminger: > > Ferruh Yigit wrote: > > > On 9/15/2020 3:03 AM, Stephen Hemminger wrote: > > > > Vdev_netvsc has been around for several years. It no longer needs > > > > to be marked experimental. > > > >

Re: [dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang

2020-11-28 Thread Dmitry Kozlyuk
On Fri, 27 Nov 2020 12:07:11 +, Nick Connolly wrote: > [...] > +#ifdef __clang__ > +#pragma clang diagnostic push > +#pragma clang diagnostic ignored "-Wformat-nonliteral" > +#endif > [...] How about a more safe approach? diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windo

Re: [dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang

2020-11-28 Thread Nick Connolly
Looks good to me! On 28/11/2020 21:11, Dmitry Kozlyuk wrote: On Fri, 27 Nov 2020 12:07:11 +, Nick Connolly wrote: [...] +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wformat-nonliteral" +#endif [...] How about a more safe approach? diff --git a/lib/l

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd flows left before port stop.

2020-11-28 Thread Gregory Etelson
Hello Andrew, > On 11/26/20 7:43 PM, Gregory Etelson wrote: > > According to RTE flow user guide, PMD will not keep flow rules after > > port stop. Application resources that refer to flow rules become > > obsolete after port stop and must not be used. > > Testpmd maintains linked list of active f