Re: [dpdk-dev] mbuf->packet_type

2020-11-03 Thread Juhamatti Kuusisaari
Hello Levend, The packet type is indeed filled by hw in case there is a support for it. I think your application may be missing a ptype handling function which checks the supported ptype handling of the hw and registers a callback handling in case the hw does not support it. Please see more detai

Re: [dpdk-dev] [PATCH v3 07/16] net/mlx5: switch Rx timestamp to dynamic mbuf field

2020-11-03 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 3, 2020 2:14 > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com; david.march...@redhat.com; > bruce.richard...@intel.com; olivier.m...@6wind.com; > andrew.rybche...@oktetlabs.ru; jer...@marvell.com; Slava Ovsiienko > ; Rui

Re: [dpdk-dev] [PATCH v3 06/16] net/mlx5: fix dynamic mbuf offset lookup check

2020-11-03 Thread Slava Ovsiienko
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 3, 2020 2:14 > To: dev@dpdk.org > Cc: ferruh.yi...@intel.com; david.march...@redhat.com; > bruce.richard...@intel.com; olivier.m...@6wind.com; > andrew.rybche...@oktetlabs.ru; jer...@marvell.com; Slava Ovsiienko > ; sta

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread David Marchand
On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > -name = 'octeontx2_regex' > > But it is not the same? > > The name will default to "octeontx2", which is fine. > But the fmt_name should not take this default. > I believe fmt_name should be "octeontx2_regex" as I did in my patch. fmt_na

[dpdk-dev] [PATCH] net/mlx5: fix meter packet missing

2020-11-03 Thread Xueming Li
For transfer flow with meter, packet was passed without applying flow action. The group level was multipled by 10 for group level 65531. This patch fixes this issue by correcting suffix table group level calculation. Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter table definitions") Cc: suanmi...@nvid

[dpdk-dev] [PATCH] net/mlx5: fix unix socket server file name

2020-11-03 Thread Xueming Li
mlx_steering_dump_parser.py tool failed to dump flow due to socket file name changed. Change socket file name back to make it consistent. Fixes: b1e15224849b ("common/mlx5: fix PCI driver name") Cc: bi...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Xueming Li --- drivers/net/mlx5/linux/mlx5_

[dpdk-dev] [RFC v2 3/6] net/i40e: use generic flow command to re-realize mirror rule

2020-11-03 Thread Steve Yang
When set follow sample rule's ratio equal to one, its behavior is same as mirror-rule, so we can use "flow create * pattern * actions sample *" to replace old "set port * mirror-rule *" command now. The example of mirror rule command mapping to flow management command: (in below command, port 0 is

[dpdk-dev] [RFC v2 2/6] net/i40e: define the mirror filter parser

2020-11-03 Thread Steve Yang
Define the sample filter parser for mirror, it will divide to two phases, the one is sample attributions pattern parsing, and the mirror config will be filled in according to pattern type VF/PF/VLAN when sample ratio is 1. The another is sample action parsing that the port id of mirror config will

[dpdk-dev] [RFC v2 1/6] net/i40e: add mirror rule config and add/del rule APIs

2020-11-03 Thread Steve Yang
Define i40e_mirror_rule_conf structure that is used for set mirror flow rule to i40e register, and relocate the mirror related MACORs to header file. Signed-off-by: Steve Yang --- drivers/net/i40e/i40e_ethdev.c | 13 + drivers/net/i40e/i40e_ethdev.h | 34 +

[dpdk-dev] [RFC v2 5/6] net/ixgbe: define the mirror filter parser

2020-11-03 Thread Steve Yang
Define the sample filter parser for mirror, it will divide to two phases, the one is sample attributions pattern parsing, and the mirror config will be filled in according to pattern type VF/PF/VLAN when sample ratio is 1. The another is sample action parsing that the port id of mirror config will

[dpdk-dev] [RFC v2 6/6] net/ixgbe: use flow sample to re-realize mirror rule

2020-11-03 Thread Steve Yang
When set follow sample rule's ratio equal to one, its behavior is same as mirror-rule, so we can use "flow create * pattern * actions sample *" to replace old "set port * mirror-rule *" command now. The example of mirror rule command mapping to flow management command: (in below command, port 0 is

[dpdk-dev] [RFC v2 4/6] net/ixgbe: add mirror rule config and add/del rule APIs

2020-11-03 Thread Steve Yang
Define ixgbe_flow_mirror_conf structure that is used for set mirror flow rule to ixgbe register, and relocate the mirror related MACORs to header file. Signed-off-by: Steve Yang --- drivers/net/ixgbe/ixgbe_ethdev.c | 8 - drivers/net/ixgbe/ixgbe_ethdev.h | 54 ++-

Re: [dpdk-dev] [PATCH v2] net/iavf: fix PROT filed for rss hash

2020-11-03 Thread Huang, ZhiminX
Tested-by: Huang, ZhiminX Regards, HuangZhiMin > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo > Sent: Tuesday, November 3, 2020 3:35 PM > To: Wu, Jingjing ; Zhang, Qi Z > ; Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia > Subject: [dpdk-dev] [PATCH v2]

[dpdk-dev] [PATCH 0/4] code cleanup and improvements

2020-11-03 Thread Archana Muniganti
This series has code cleanup and improvements for OCTEON TX and OCTEON TX2 crypto PMDs Archana Muniganti (4): common/cpt: prepopulate word7 in sess common/cpt: remove temporary variable common/cpt: use predefined macros common/cpt: remove redundant structure drivers/common/cpt/cpt_common

[dpdk-dev] [PATCH 2/4] common/cpt: remove temporary variable

2020-11-03 Thread Archana Muniganti
Remove temporary variable used in datapath. Signed-off-by: Archana Muniganti --- drivers/common/cpt/cpt_hw_types.h | 10 ++- drivers/common/cpt/cpt_mcode_defines.h| 8 -- drivers/common/cpt/cpt_ucode.h| 79 ++- drivers/common/cpt/cpt_ucode_asy

[dpdk-dev] [PATCH 1/4] common/cpt: prepopulate word7 in sess

2020-11-03 Thread Archana Muniganti
CPT inst word7 is an immutable data for a session. This data can be populated in a session. Signed-off-by: Archana Muniganti --- drivers/common/cpt/cpt_common.h | 1 - drivers/common/cpt/cpt_mcode_defines.h| 13 ++- drivers/common/cpt/cpt_ucode.h| 109 +++

[dpdk-dev] [PATCH 3/4] common/cpt: use predefined macros

2020-11-03 Thread Archana Muniganti
Replace redundant macro ROUNDUP* with predefined macros. Signed-off-by: Archana Muniganti --- drivers/common/cpt/cpt_common.h | 12 drivers/common/cpt/cpt_pmd_ops_helper.c | 5 +++-- drivers/common/cpt/cpt_ucode.h| 11 +++ drivers/common/

[dpdk-dev] [PATCH 4/4] common/cpt: remove redundant structure

2020-11-03 Thread Archana Muniganti
Replaced structure 'rid' which has single field with its field itself. Signed-off-by: Archana Muniganti --- drivers/common/cpt/cpt_common.h | 7 +-- drivers/crypto/octeontx/otx_cryptodev_hw_access.c | 10 +- drivers/crypto/octeontx/otx_cryptodev_ops.c | 13 ++

Re: [dpdk-dev] [PATCH 0/4] code cleanup and improvements

2020-11-03 Thread Anoob Joseph
> > This series has code cleanup and improvements for OCTEON TX and OCTEON > TX2 crypto PMDs > > Archana Muniganti (4): > common/cpt: prepopulate word7 in sess > common/cpt: remove temporary variable > common/cpt: use predefined macros > common/cpt: remove redundant structure > > driver

[dpdk-dev] [PATCH v2] common/mlx5: split relaxed ordering set for read and write

2020-11-03 Thread Tal Shnaiderman
The current DevX implementation of the relaxed ordering feature is enabling relaxed ordering usage only if both relaxed ordering read AND write are supported. In that case both relaxed ordering read and write are activated. This commit will optimize the usage of relaxed ordering by enabling it wh

Re: [dpdk-dev] [PATCH v3 00/16] remove mbuf timestamp

2020-11-03 Thread David Marchand
On Tue, Nov 3, 2020 at 1:14 AM Thomas Monjalon wrote: > > The mbuf field timestamp was announced to be removed for three reasons: > - a dynamic field already exist, used for Tx only > - this field always used 8 bytes even if unneeded > - this field is in the first half (cacheline) of mbuf >

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread Thomas Monjalon
03/11/2020 09:19, David Marchand: > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > > -name = 'octeontx2_regex' > > > > But it is not the same? > > > > The name will default to "octeontx2", which is fine. > > But the fmt_name should not take this default. > > I believe fmt_name should

Re: [dpdk-dev] [PATCH v2] common/mlx5: split relaxed ordering set for read and write

2020-11-03 Thread Matan Azrad
From: Tal Shnaiderman > The current DevX implementation of the relaxed ordering feature is enabling > relaxed ordering usage only if both relaxed ordering read AND write are > supported. In that case both relaxed ordering read and write are activated. > > This commit will optimize the usage of

Re: [dpdk-dev] [PATCH v3 05/16] net/dpaa2: switch Rx timestamp to dynamic mbuf field

2020-11-03 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread David Marchand
On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > 03/11/2020 09:19, David Marchand: > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon wrote: > > > > > -name = 'octeontx2_regex' > > > > > > But it is not the same? > > > > > > The name will default to "octeontx2", which is fine. > > > But

Re: [dpdk-dev] [PATCH v3 02/16] mbuf: add Rx timestamp flag and helpers

2020-11-03 Thread Olivier Matz
Hi Thomas, On Tue, Nov 03, 2020 at 01:13:53AM +0100, Thomas Monjalon wrote: > There is already a dynamic field for timestamp, > used only for Tx scheduling with the dedicated Tx offload flag. > The same field can be used for Rx timestamp filled by drivers. > > A new dynamic flag is defined for Rx

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-11-03 Thread Bruce Richardson
On Mon, Nov 02, 2020 at 07:01:44PM +, Honnappa Nagarahalli wrote: > > > > > > > Part of the confusion arises from the fact that originally that was the only > > parameter set by this - and on x86 it still is. Perhaps this parameter > > needs to > Just wondering, for x86, what does it mean if

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread David Marchand
On Tue, Nov 3, 2020 at 10:19 AM David Marchand wrote: > > On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > > > 03/11/2020 09:19, David Marchand: > > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon > > > wrote: > > > > > > -name = 'octeontx2_regex' > > > > > > > > But it is not the sa

[dpdk-dev] [PATCH v3] net/iavf: fix PROT filed for rss hash

2020-11-03 Thread Jeff Guo
Add PROT field into IPv4 and IPv6 protocol headers for rss hash. Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") Signed-off-by: Jeff Guo --- v3: handle unexpected PROT clearing when refine l2 hdrs v2: add prot into the new hdr replace of function modify --- drivers/net/iavf/iavf_hash.c | 56

Re: [dpdk-dev] [PATCH v3 02/16] mbuf: add Rx timestamp flag and helpers

2020-11-03 Thread Thomas Monjalon
03/11/2020 10:33, Olivier Matz: > On Tue, Nov 03, 2020 at 01:13:53AM +0100, Thomas Monjalon wrote: > > +static int > > +rte_mbuf_dyn_timestamp_register(int *field_offset, uint64_t *flag, > > + const char *direction, const char *flag_name) > > +{ > > + static const struct rte_mbuf_dynfie

Re: [dpdk-dev] [PATCH] eal: fix incorrect API doc for power intrinsics

2020-11-03 Thread Liang, Ma
On 02 Nov 12:57, Anatoly Burakov wrote: > Currently, the intrinsics documentation refers to `rte_cpu_get_features` > as a check for whether these intrinsics are supported at runtime. This > is incorrect, because actually the user should use the > `rte_cpu_get_intrinsics_support` API to do said chec

Re: [dpdk-dev] [pull-request] next-eventdev 20.11 RC2

2020-11-03 Thread Thomas Monjalon
02/11/2020 16:57, McDaniel, Timothy: > From: David Marchand > > On Mon, Nov 2, 2020 at 3:31 PM Jerin Jacob Kollanukkaran > > wrote: > > > > > > The following changes since commit > > 79d69c6dcf0debea38ac258d230e2f8c93e5ad12: > > > > > > mbuf: remove seqn field (2020-10-31 22:14:44 +0100) > > >

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-03 Thread Luca Boccassi
On Tue, 2020-11-03 at 10:42 +0300, Dmitry Kozlyuk wrote: > Hi Naty, > > > Doesn't the 'input' option gets you original (unmodified) line endings on > > checkout? > > If a file in the repo has CRLF endings, Unix devs will get it as-is (with > > CRLF), right? > > The "input" option is for Unix de

[dpdk-dev] [PATCH 01/37] net/txgbe: add ntuple filter init and uninit

2020-11-03 Thread Jiawen Wu
Add ntuple filter init and uninit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 1 + drivers/net/txgbe/txgbe_ethdev.c| 28 drivers/net/txgbe/txgbe_ethdev.h| 33 + 3 files changed, 62 insertions(+) diff --git a/d

[dpdk-dev] [PATCH 00/37] net: add txgbe PMD part 2

2020-11-03 Thread Jiawen Wu
Add the remaining part of txgbe PMD. Support include flow API, traffic manager, macsec and ipsec. Jiawen Wu (37): net/txgbe: add ntuple filter init and uninit net/txgbe: support ntuple filter add and delete net/txgbe: add ntuple parse rule net/txgbe: support ntuple filter remove operaion

[dpdk-dev] [PATCH 02/37] net/txgbe: support ntuple filter add and delete

2020-11-03 Thread Jiawen Wu
Support add and delete operations on ntuple filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 310 +++ drivers/net/txgbe/txgbe_ethdev.h | 6 + 2 files changed, 316 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe

[dpdk-dev] [PATCH 05/37] net/txgbe: support ethertype filter add and delete

2020-11-03 Thread Jiawen Wu
Support add and delete operaions on ethertype filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 111 +++ drivers/net/txgbe/txgbe_ethdev.h | 19 ++ 2 files changed, 130 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/ne

[dpdk-dev] [PATCH 04/37] net/txgbe: support ntuple filter remove operaion

2020-11-03 Thread Jiawen Wu
Support remove operation on ntuple filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 11 +++ drivers/net/txgbe/txgbe_ethdev.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index fe32194a7

[dpdk-dev] [PATCH 03/37] net/txgbe: add ntuple parse rule

2020-11-03 Thread Jiawen Wu
Add support to parse flow for ntuple filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_flow.c | 536 + 2 files changed, 537 insertions(+) create mode 100644 drivers/net/txgbe/txgbe_flow.c diff --git a/drivers/ne

[dpdk-dev] [PATCH 08/37] net/txgbe: add syn filter parse rule

2020-11-03 Thread Jiawen Wu
Add support to parse flow for syn filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 256 + 1 file changed, 256 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index fc2505ddc..7110e594b 100644 --- a/d

[dpdk-dev] [PATCH 07/37] net/txgbe: support syn filter add and delete

2020-11-03 Thread Jiawen Wu
Support add and delete operations on syn filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 70 drivers/net/txgbe/txgbe_ethdev.h | 6 +++ 2 files changed, 76 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/tx

[dpdk-dev] [PATCH 10/37] net/txgbe: config L2 tunnel filter with e-tag

2020-11-03 Thread Jiawen Wu
Config L2 tunnel filter with e-tag. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 63 1 file changed, 63 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 79f1f9535..0be894b7b 100644 --- a/driv

[dpdk-dev] [PATCH 13/37] net/txgbe: add FDIR filter init and uninit.

2020-11-03 Thread Jiawen Wu
Add flow director filter init and uninit operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 29 + drivers/net/txgbe/txgbe_ethdev.c| 63 + drivers/net/txgbe/txgbe_ethdev.h| 51 +++ 3 files changed, 143

[dpdk-dev] [PATCH 12/37] net/txgbe: add L2 tunnel filter parse rule

2020-11-03 Thread Jiawen Wu
Add support to parse flow for L2 tunnel filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 202 + 1 file changed, 202 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 7110e594b..8589e3328 100644 -

Re: [dpdk-dev] [PATCH v7 0/4] devtools: abi breakage checks

2020-11-03 Thread Kinsella, Ray
Hi David, Came across an issue with this. Essentially what is happening is that an ABI dump file generated with a newer versions of libabigail is not guaranteed to be 100% compatible with a older versions. That then adds a wrinkle that we need may need to look at maintaining abi dump archives

[dpdk-dev] [PATCH 11/37] net/txgbe: support L2 tunnel filter add and delete

2020-11-03 Thread Jiawen Wu
Support L2 tunnel filter add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 230 +++ drivers/net/txgbe/txgbe_ethdev.h | 18 +++ 2 files changed, 248 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txg

[dpdk-dev] [PATCH 06/37] net/txgbe: add ethertype parse rule

2020-11-03 Thread Jiawen Wu
Add support to parse flow for ethertype filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 250 + 1 file changed, 250 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 6f8be3b7f..fc2505ddc 100644 -

[dpdk-dev] [PATCH 15/37] net/txgbe: support FDIR add and delete operations

2020-11-03 Thread Jiawen Wu
Support add and delete operations on flow director. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 11 + drivers/net/txgbe/txgbe_ethdev.h| 16 + drivers/net/txgbe/txgbe_fdir.c | 472 +++- 3 files changed, 498 insertions(+), 1 deletion(-) di

[dpdk-dev] [PATCH 14/37] net/txgbe: configure FDIR filter

2020-11-03 Thread Jiawen Wu
Configure flow director filter with it enabled. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 6 + drivers/net/txgbe/meson.build | 1 + drivers/net/txgbe/txgbe_ethdev.c| 6 + drivers/net/txgbe/txgbe_ethdev.h| 6 + drivers/net/txgbe/txgbe_fdir.c | 4

[dpdk-dev] [PATCH 17/37] net/txgbe: add FDIR parse tunnel rule

2020-11-03 Thread Jiawen Wu
Add support to parse tunnel flow for fdir filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 8 + drivers/net/txgbe/txgbe_flow.c | 290 2 files changed, 298 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_type.h b/drivers/net/

[dpdk-dev] [PATCH 09/37] net/txgbe: add L2 tunnel filter init and uninit

2020-11-03 Thread Jiawen Wu
Add L2 tunnel filter init and uninit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 65 drivers/net/txgbe/txgbe_ethdev.h | 32 2 files changed, 97 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/

[dpdk-dev] [PATCH 18/37] net/txgbe: add FDIR restore operation

2020-11-03 Thread Jiawen Wu
Add restore operation on FDIR filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 1 + drivers/net/txgbe/txgbe_ethdev.h | 2 ++ drivers/net/txgbe/txgbe_fdir.c | 34 3 files changed, 37 insertions(+) diff --git a/drivers/net/txgbe/txgbe_et

[dpdk-dev] [PATCH 20/37] net/txgbe: add RSS filter restore operation

2020-11-03 Thread Jiawen Wu
Add restore operation on RSS filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 12 + drivers/net/txgbe/txgbe_ethdev.h | 7 +++ drivers/net/txgbe/txgbe_rxtx.c | 76 3 files changed, 95 insertions(+) diff --git a/drivers/net/txgbe/txgb

[dpdk-dev] [PATCH 16/37] net/txgbe: add FDIR parse normal rule

2020-11-03 Thread Jiawen Wu
Add support to parse flow for fdir filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_type.h | 10 + drivers/net/txgbe/txgbe_flow.c | 856 2 files changed, 866 insertions(+) diff --git a/drivers/net/txgbe/base/txgbe_type.h b/drivers/net/txgbe/b

[dpdk-dev] [PATCH 19/37] net/txgbe: add RSS filter parse rule

2020-11-03 Thread Jiawen Wu
Add support to parse flow for RSS filter. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 8 +++ drivers/net/txgbe/txgbe_flow.c | 114 +++ drivers/net/txgbe/txgbe_rxtx.c | 20 ++ 3 files changed, 142 insertions(+) diff --git a/drivers/net/t

[dpdk-dev] [PATCH 22/37] net/txgbe: add flow API

2020-11-03 Thread Jiawen Wu
Add flow API with generic flow operaions, validate first. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + doc/guides/nics/txgbe.rst | 1 + drivers/net/txgbe/txgbe_ethdev.c | 25 drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe/txgbe_fl

[dpdk-dev] [PATCH 21/37] net/txgbe: add filter list init and uninit

2020-11-03 Thread Jiawen Wu
Add filter list init and uninit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 6 ++ drivers/net/txgbe/txgbe_ethdev.h | 8 ++ drivers/net/txgbe/txgbe_flow.c | 127 +++ 3 files changed, 141 insertions(+) diff --git a/drivers/net/txgbe/txgbe_eth

[dpdk-dev] [PATCH 24/37] net/txgbe: add flow API destroy function

2020-11-03 Thread Jiawen Wu
Add support to destroy operation for flow API. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 128 + 1 file changed, 128 insertions(+) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 4141352bf..8d5362175 100644 --

[dpdk-dev] [PATCH 25/37] net/txgbe: add flow API flush function

2020-11-03 Thread Jiawen Wu
Add support to flush operation for flow API. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 87 +++ drivers/net/txgbe/base/txgbe_hw.h | 1 + drivers/net/txgbe/txgbe_ethdev.c | 21 drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe

[dpdk-dev] [PATCH 23/37] net/txgbe: add flow API create function

2020-11-03 Thread Jiawen Wu
Add support to create operation for flow API. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 2 + drivers/net/txgbe/txgbe_fdir.c | 27 drivers/net/txgbe/txgbe_flow.c | 257 +++ 3 files changed, 286 insertions(+) diff --git a/drivers/net/t

[dpdk-dev] [PATCH 27/37] net/txgbe: add TM configuration init and uninit

2020-11-03 Thread Jiawen Wu
Add traffic manager configuration init and uninit operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/meson.build| 1 + drivers/net/txgbe/txgbe_ethdev.c | 16 + drivers/net/txgbe/txgbe_ethdev.h | 60 drivers/net/txgbe/txgbe_tm.c | 57 +

[dpdk-dev] [PATCH 26/37] net/txgbe: support UDP tunnel port add and delete

2020-11-03 Thread Jiawen Wu
Support UDP tunnel port add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 105 +++ 1 file changed, 105 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 83c078a2a..337ebf2e0 1

[dpdk-dev] [PATCH 28/37] net/txgbe: add TM capabilities get operation

2020-11-03 Thread Jiawen Wu
Add support to get traffic manager capabilities. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 1 + drivers/net/txgbe/txgbe_ethdev.h | 9 + drivers/net/txgbe/txgbe_tm.c | 278 +++ 3 files changed, 288 insertions(+) diff --git a/drivers/net/t

[dpdk-dev] [PATCH 31/37] net/txgbe: add TM hierarchy commit

2020-11-03 Thread Jiawen Wu
Add traffic manager hierarchy commit. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_tm.c | 70 1 file changed, 70 insertions(+) diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c index 6dd593e54..b8edd78bf 100644 --- a/drivers/ne

[dpdk-dev] [PATCH 30/37] net/txgbe: support TM node add and delete

2020-11-03 Thread Jiawen Wu
Support traffic manager node add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 1 + drivers/net/txgbe/txgbe_tm.c | 488 +++ 2 files changed, 489 insertions(+) diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/t

[dpdk-dev] [PATCH 29/37] net/txgbe: support TM shaper profile add and delete

2020-11-03 Thread Jiawen Wu
Support traffic manager profile add and delete operations. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_tm.c | 129 +++ 1 file changed, 129 insertions(+) diff --git a/drivers/net/txgbe/txgbe_tm.c b/drivers/net/txgbe/txgbe_tm.c index 545590ba2..8adb03825 1

[dpdk-dev] [PATCH 34/37] net/txgbe: add security session create operation

2020-11-03 Thread Jiawen Wu
Add support to configure a security session. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.h | 6 + drivers/net/txgbe/txgbe_ipsec.c | 250 +++ drivers/net/txgbe/txgbe_ipsec.h | 66 3 files changed, 322 insertions(+) diff --git a/drivers/ne

[dpdk-dev] [PATCH 32/37] net/txgbe: add macsec setting

2020-11-03 Thread Jiawen Wu
Add macsec register enable and setting reset operations. Add macsec offload suuport. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/txgbe_ethdev.c | 87 ++ drivers/net/txgbe/txgbe_ethdev.h | 17 ++ drivers/net/txgbe/t

[dpdk-dev] [PATCH 33/37] net/txgbe: add IPsec context creation

2020-11-03 Thread Jiawen Wu
Initialize securiry context, and add support to get security capabilities. Signed-off-by: Jiawen Wu --- doc/guides/nics/features/txgbe.ini | 1 + drivers/net/txgbe/meson.build | 3 +- drivers/net/txgbe/txgbe_ethdev.c | 13 +++ drivers/net/txgbe/txgbe_ethdev.h | 3 + drivers/net/t

[dpdk-dev] [PATCH 37/37] net/txgbe: add security type in flow action

2020-11-03 Thread Jiawen Wu
Add security type in flow action. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_flow.c | 52 + drivers/net/txgbe/txgbe_ipsec.c | 30 +++ drivers/net/txgbe/txgbe_ipsec.h | 3 ++ 3 files changed, 85 insertions(+) diff --git a/drivers/net/tx

[dpdk-dev] [PATCH 36/37] net/txgbe: add security offload in Rx and Tx process

2020-11-03 Thread Jiawen Wu
Add security offload in Rx and Tx process. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ipsec.c | 106 drivers/net/txgbe/txgbe_ipsec.h | 1 + drivers/net/txgbe/txgbe_rxtx.c | 93 +++- drivers/net/txgbe/txgbe_rxtx.h | 13

[dpdk-dev] [PATCH 35/37] net/txgbe: support security session destroy

2020-11-03 Thread Jiawen Wu
Add support to clear a security session's private data, get the size of a security session, add update the mbuf with provided metadata. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ipsec.c | 167 drivers/net/txgbe/txgbe_ipsec.h | 15 +++ 2 files changed,

Re: [dpdk-dev] [PATCH v3] build: add pkg-config validation

2020-11-03 Thread Bruce Richardson
On Mon, Nov 02, 2020 at 09:34:26PM +0200, Gregory Etelson wrote: > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. > Inaccurate build parameters, produced by pkg-config from DPDK .pc > files could fail application build or cause unpred

Re: [dpdk-dev] [PATCH v3 08/16] net/nfb: switch Rx timestamp to dynamic mbuf field

2020-11-03 Thread Olivier Matz
On Tue, Nov 03, 2020 at 01:13:59AM +0100, Thomas Monjalon wrote: > The mbuf timestamp is moved to a dynamic field > in order to allow removal of the deprecated static field. > The related mbuf flag is also replaced. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/nfb/nfb_rx.c | 15 +++

Re: [dpdk-dev] performance degradation with fpic

2020-11-03 Thread Thomas Monjalon
02/11/2020 16:00, Bruce Richardson: > On Mon, Nov 02, 2020 at 10:40:54AM +, Ali Alnubani wrote: > > Hi Bruce, > > > > I was able to pin this down on drivers/net/mlx5/mlx5_rxtx.c. Removing -fPIC > > from its ninja recipe in build.ninja resolves the issue (had to prevent > > creating shared li

Re: [dpdk-dev] [PATCH v3 11/16] app/testpmd: switch Rx timestamp to dynamic mbuf field

2020-11-03 Thread Olivier Matz
On Tue, Nov 03, 2020 at 01:14:02AM +0100, Thomas Monjalon wrote: > The mbuf timestamp is moved to a dynamic field > in order to allow removal of the deprecated static field. > The related mbuf flag is also replaced. > > Signed-off-by: Thomas Monjalon > --- > app/test-pmd/util.c | 39

Re: [dpdk-dev] [PATCH 3/8] doc: fix driver names in crypto devices guide

2020-11-03 Thread Bruce Richardson
On Mon, Nov 02, 2020 at 09:02:26PM +0100, David Marchand wrote: > On Mon, Nov 2, 2020 at 9:00 PM David Marchand > wrote: > > We still have: > > doc/guides/cryptodevs/mvsam.rst:The MVSAM CRYPTO PMD > > (**librte_crypto_mvsam_pmd**) provides poll mode crypto driver > > Ah.. and: > doc/guides/crypt

Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override

2020-11-03 Thread Bruce Richardson
On Tue, Nov 03, 2020 at 10:45:37AM +0100, David Marchand wrote: > On Tue, Nov 3, 2020 at 10:19 AM David Marchand > wrote: > > > > On Tue, Nov 3, 2020 at 10:06 AM Thomas Monjalon wrote: > > > > > > 03/11/2020 09:19, David Marchand: > > > > On Tue, Nov 3, 2020 at 1:30 AM Thomas Monjalon > > > > w

[dpdk-dev] [PATCH] net/mlx5: fix aging queue doorbell ringing

2020-11-03 Thread Dekel Peled
Recent patch introduced a new SQ for ASO flow hit management. This SQ uses two WQEBB's for each WQE. The SQ producer index is 16 bits wide. The enqueue loop posts new WQEs to the ASO SQ, using WQE index for the SQ management. This 16 bits index multiplied by 2 was wrongly used also for SQ doorbell

Re: [dpdk-dev] [pull-request] next-eventdev 20.11 RC2

2020-11-03 Thread Thomas Monjalon
02/11/2020 15:30, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled with discussed change, thanks

Re: [dpdk-dev] performance degradation with fpic

2020-11-03 Thread Luca Boccassi
On Tue, 2020-11-03 at 11:18 +0100, Thomas Monjalon wrote: > 02/11/2020 16:00, Bruce Richardson: > > On Mon, Nov 02, 2020 at 10:40:54AM +, Ali Alnubani wrote: > > > Hi Bruce, > > > > > > I was able to pin this down on drivers/net/mlx5/mlx5_rxtx.c. Removing > > > -fPIC from its ninja recipe in

Re: [dpdk-dev] [PATCH] doc: announce end of support for some Broadcom devices

2020-11-03 Thread Kevin Traynor
Hi Ajit, On 26/10/2020 21:46, Ajit Khaparde wrote: > Devices belonging to BCM573xx and BCM5740x family will not be supported > from the 21.02 release. > > Signed-off-by: Ajit Khaparde > --- > doc/guides/rel_notes/deprecation.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/do

Re: [dpdk-dev] [PATCH] regex/octeontx2: fix driver name

2020-11-03 Thread Thomas Monjalon
23/10/2020 19:41, Thomas Monjalon: > Following the recent alignment of all driver names, > this new driver get unaligned: > librte_regex_octeontx2_regex.so > > The 'fmt_name' must be "octeontx2_regex", and if not provided, > is taken from the 'name' variable. > But the variable 'name' should

Re: [dpdk-dev] [PATCH v3 09/16] net/octeontx2: switch Rx timestamp to dynamic mbuf field

2020-11-03 Thread Harman Kalra
On Tue, Nov 03, 2020 at 01:14:00AM +0100, Thomas Monjalon wrote: > The mbuf timestamp is moved to a dynamic field > in order to allow removal of the deprecated static field. > The related mbuf flag is also replaced. > > The dynamic offset and flag are stored in struct otx2_timesync_info > to favor

Re: [dpdk-dev] [PATCH v4 2/6] build: refactor Arm build

2020-11-03 Thread Juraj Linkeš
> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, November 2, 2020 8:32 PM > To: Juraj Linkeš ; bruce.richard...@intel.com; > Ruifeng Wang ; Phil Yang ; > vcchu...@amazon.com; Dharmik Thakkar ; > jerinjac...@gmail.com; hemant.agra...@nxp.com > Cc: dev@dpdk.org; nd ; Honna

[dpdk-dev] [PATCH v1] net/mlx5: fix meter packet missing

2020-11-03 Thread Xueming Li
For transfer flow with meter, packet was passed without applying flow action. The group level was multiplied by 10 for group level 65531. This patch fixes this issue by correcting suffix table group level calculation. Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter table definitions") Cc: suanmi...@nvi

Re: [dpdk-dev] 【meson build fail for octeontx2】

2020-11-03 Thread oulijun
在 2020/10/27 16:31, David Marchand 写道: On Tue, Oct 27, 2020 at 8:43 AM oulijun wrote: Hi I am trying to build dpdk-next-net code based Kunpeng920(ARM64) platform used meson build. However, it is build fail. The libtmp_rte_event_octeontx2 build error happened. The output as follows: [

Re: [dpdk-dev] performance degradation with fpic

2020-11-03 Thread Bruce Richardson
On Tue, Nov 03, 2020 at 11:18:57AM +0100, Thomas Monjalon wrote: > 02/11/2020 16:00, Bruce Richardson: > > On Mon, Nov 02, 2020 at 10:40:54AM +, Ali Alnubani wrote: > > > Hi Bruce, > > > > > > I was able to pin this down on drivers/net/mlx5/mlx5_rxtx.c. Removing > > > -fPIC from its ninja rec

Re: [dpdk-dev] [PATCH v3 09/16] net/octeontx2: switch Rx timestamp to dynamic mbuf field

2020-11-03 Thread Thomas Monjalon
03/11/2020 11:52, Harman Kalra: >With the following changes, ptpclient and testpmd(ieee1588 mode) is >crashing for us. I am debugging the issue and will update soon. > -- >Steps to reproduce: >1. Testpmd: > ./dpdk-testpmd -c 0x01 -n 4 -w 0002:05:00.0 -- -

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

2020-11-03 Thread Georgios Katsikas
Hi, Any news on this patch? Is there anything else I could do? Thanks, Georgios On Sun, Oct 11, 2020 at 1:03 PM Georgios Katsikas wrote: > Currently, flow-perf measures the performance of > rule installation/deletion operations by breaking > down the entire number of operations into windows >

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix cpu crypto cipher auth

2020-11-03 Thread Zhang, Roy Fan
Hi Akhil, Thanks. Will do. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Monday, November 2, 2020 7:57 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Subject: RE: [PATCH] crypto/aesni_mb: fix cpu crypto cipher auth > > Hi Fan, > > Subject: [PATCH] crypto/aesni_mb: fix cpu cry

Re: [dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity

2020-11-03 Thread Ferruh Yigit
On 11/2/2020 2:38 PM, Lijun Ou wrote: From: Hongbo Zheng This patch fixes some warnings. coverity:function format symbol does not match I think we are not getting these warnings in the public coverity, is there a specific configuration for it? coverity:not_unsigned: Violation: Operand "h

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

2020-11-03 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, November 2, 2020 4:58 PM > > +Cc techboard > > We need benchmark numbers in order to take a decision. > Please all, prepare some arguments and numbers so we can discuss > the mbuf layout in the next techboard meeting. I propose

Re: [dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity

2020-11-03 Thread oulijun
在 2020/11/3 19:41, Ferruh Yigit 写道: On 11/2/2020 2:38 PM, Lijun Ou wrote: From: Hongbo Zheng This patch fixes some warnings. coverity:function format symbol does not match I think we are not getting these warnings in the public coverity, is there a specific configuration for it? Yes, t

Re: [dpdk-dev] [PATCH 0/8] misc fixes for hns3

2020-11-03 Thread Ferruh Yigit
On 11/2/2020 2:38 PM, Lijun Ou wrote: This patch series includes three Tx checksum bugs and two static check warnings fixes. The remaining includes two features fixes. Chengchang Tang (4): net/hns3: add limit promisc mode to VF net/hns3: fix Tx cksum outer header prepare net/hns3: fix T

Re: [dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity

2020-11-03 Thread Ferruh Yigit
On 11/3/2020 12:11 PM, oulijun wrote: 在 2020/11/3 19:41, Ferruh Yigit 写道: On 11/2/2020 2:38 PM, Lijun Ou wrote: From: Hongbo Zheng This patch fixes some warnings. coverity:function format symbol does not match I think we are not getting these warnings in the public coverity, is there a s

Re: [dpdk-dev] [PATCH v3 09/16] net/octeontx2: switch Rx timestamp to dynamic mbuf field

2020-11-03 Thread Thomas Monjalon
03/11/2020 12:22, Thomas Monjalon: > 03/11/2020 11:52, Harman Kalra: > >With the following changes, ptpclient and testpmd(ieee1588 mode) is > >crashing for us. I am debugging the issue and will update soon. > > -- > >Steps to reproduce: > >1. Testpmd: > > ./d

[dpdk-dev] [PATCH v4 00/16] remove mbuf timestamp

2020-11-03 Thread Thomas Monjalon
The mbuf field timestamp was announced to be removed for three reasons: - a dynamic field already exist, used for Tx only - this field always used 8 bytes even if unneeded - this field is in the first half (cacheline) of mbuf After this series, the dynamic field timestamp is used for both Rx

[dpdk-dev] [PATCH v4 01/16] eventdev: remove software Rx timestamp

2020-11-03 Thread Thomas Monjalon
This a revert of the commit 569758758dcd ("eventdev: add Rx timestamp"). If the Rx timestamp is not configured on the ethdev port, there is no reason to set one. Also the accuracy of the timestamp was bad because set at a late stage. Anyway there is no trace of the usage of this timestamp. Signed

[dpdk-dev] [PATCH v4 03/16] latency: switch Rx timestamp to dynamic mbuf field

2020-11-03 Thread Thomas Monjalon
The mbuf timestamp is moved to a dynamic field in order to allow removal of the deprecated static field. The related mbuf flag is also replaced with the dynamic one. Signed-off-by: Thomas Monjalon Acked-by: David Marchand --- lib/librte_latencystats/rte_latencystats.c | 30 ++---

  1   2   3   >