[dpdk-dev] [PATCH 2/3] trace: remove size limit on CTF event description

2020-10-23 Thread David Marchand
Rework registration so that it uses dynamic allocations and has no size limit. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_trace.c | 39 +--- lib/librte_eal/common/eal_common_trace_ctf.c | 3 +- lib/librte_eal/common/eal_trace.h| 3 +- 3 f

[dpdk-dev] [PATCH 3/3] trace: make CTF metadata prettier

2020-10-23 Thread David Marchand
This is simply a cosmetic change. Before: event { id = 17; name = "lib.eal.alarm.set"; fields := struct { uint64_t us;uintptr_t cb_fn;uintptr_t cb_arg;int32_t rc; }; }; After: event { id = 17; name = "lib.eal.alarm.set"; fields := struct { uint64_t us;

Re: [dpdk-dev] [PATCH] net/ice: fix SCTP RSS configuration

2020-10-23 Thread Xie, WeiX
Tested-by: Xie,WeiX < weix@intel.com> Regards, Xie Wei > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Junyu Jiang > Sent: Tuesday, October 20, 2020 4:51 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Su, Simei ; > Jiang, JunyuX ; sta...@dpdk.org > Subject: [d

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove dead code

2020-10-23 Thread Akhil Goyal
> RTE_LIBRTE_SECURITY_TEST never existed, the variable under this check is > never used. > > Fixes: e117c18a1dbe ("crypto/dpaa2_sec: restructure session management") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- This test is part of our internal tree in NXP. I think it got accide

Re: [dpdk-dev] [RFC] net/i40e: refactor of hash flow

2020-10-23 Thread Wang, ShougangX
Hi, Alvin > -Original Message- > From: dev On Behalf Of Zhang,Alvin > Sent: Friday, October 23, 2020 2:56 PM > To: dev@dpdk.org > Cc: Zhang, AlvinX > Subject: [dpdk-dev] [RFC] net/i40e: refactor of hash flow > > From: Alvin Zhang > > 1. Delete original code. > 2. Add 2 tables(pattern

[dpdk-dev] [PATCH] net/ena: remove unused macro

2020-10-23 Thread David Marchand
This assert macro is not called anymore. This also fixes an invalid reference to RTE_LOGTYPE_ERR that does not exist. Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version") Fixes: 6f1c9df9e9cc ("net/ena: use dynamic log type for debug logging") Cc: sta...@dpdk.org Signed-off-by: David M

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: Remove the re-implementation of inet_pton

2020-10-23 Thread David Marchand
On Mon, Jul 13, 2020 at 11:59 AM Ibtisam Tariq wrote: > > inet_pton4 and inet_pton6 was reimplemented. Replace implementation of > inet_pton4 and inet_pton6 with libc inet_pton function > > Bugzilla ID: 365 > Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") > Cc: roy.fan.zh

Re: [dpdk-dev] [PATCH v5 2/3] eal: return error code when failure

2020-10-23 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, October 22, 2020 8:52 PM > To: wangyunjian > Cc: dev ; Jeff Guo ; Jerin Jacob > Kollanukkaran ; Lilijun (Jerry) > ; > xudingke ; dpdk stable ; Kevin > Traynor ; Luca Boccassi > Subject: Re: [

Re: [dpdk-dev] [PATCH v5 3/3] eal: fix a wrong returned value when callback exists

2020-10-23 Thread wangyunjian
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, October 22, 2020 8:55 PM > To: wangyunjian > Cc: dev ; Jeff Guo ; Jerin Jacob > Kollanukkaran ; Lilijun (Jerry) > ; > xudingke ; dpdk stable ; Kevin > Traynor ; Luca Boccassi > Subject: Re: [

Re: [dpdk-dev] [PATCH v3 00/11] bnxt fixes and enhancements to TRUFLOW support

2020-10-23 Thread Ajit Khaparde
On Thu, Oct 22, 2020 at 3:06 PM Ajit Khaparde wrote: > > This patchset has support for VXLAN decap full offload, > SR device support in tf_core and a few bug fixes. > > v1->v2: > - Squashed some patches. > - Updated commit logs. > - Fixed a compilation issue reported during clang builds. > > v2

Re: [dpdk-dev] [PATCH v2 01/11] net/bnxt: add stingray support to core layer

2020-10-23 Thread Ajit Khaparde
On Thu, Oct 22, 2020 at 2:11 AM Ferruh Yigit wrote: > > On 10/21/2020 7:11 PM, Ajit Khaparde wrote: > > On Wed, Oct 21, 2020 at 11:07 AM Ferruh Yigit > > wrote: > >> > >> On 10/20/2020 10:55 PM, Ajit Khaparde wrote: > >>> From: Peter Spreadborough > >>> > >>> - Moved P4 specific code under the

Re: [dpdk-dev] [PATCH] net/bnxt: fix a potential resource leak

2020-10-23 Thread Ajit Khaparde
On Thu, Oct 22, 2020 at 4:47 AM Ferruh Yigit wrote: > > On 10/21/2020 7:00 AM, Ajit Khaparde wrote: > > Fix a potential resource leak in case of errors during dev args > > parsing during device probe. > > > > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") > > > > Signed-off-b

[dpdk-dev] [Bug 565] [dpdk-20.11]metering_and_policing/test_ipv4_HASH_table_RFC2698: create rule failed

2020-10-23 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=565 Bug ID: 565 Summary: [dpdk-20.11]metering_and_policing/test_ipv4_HASH_table _RFC2698: create rule failed Product: DPDK Version: 20.11 Hardware: All OS: Linux

[dpdk-dev] [PATCH v2] net/bnxt: fix a potential resource leak

2020-10-23 Thread Ajit Khaparde
Fix a potential resource leak in case of errors during dev args parsing during device probe. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- v1->v2: addressed the review comment. --- drivers/net/bnxt/bnxt_ethdev.c | 6

Re: [dpdk-dev] [PATCH v2] net/bnxt: fix a potential resource leak

2020-10-23 Thread Ajit Khaparde
On Thu, Oct 22, 2020 at 10:12 PM Ajit Khaparde wrote: > > Fix a potential resource leak in case of errors during dev args > parsing during device probe. > > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") > > Signed-off-by: Ajit Khaparde > Reviewed-by: Kalesh AP > --- > v1->

Re: [dpdk-dev] Fwd: [PATCH] maintainers: update hns3 pmd maintainers

2020-10-23 Thread Wei Hu (Xavier)
Hi, Thomas hns3 driver will be sent or acked by Lijun Ou,  Thanks. Acked-by: Wei Hu (Xavier) Regards Xavier On 2020/10/20 9:11, oulijun wrote: 转发的消息 From: 15 2020 <> X-Account-Key: account1 X-UIDL: 199657 X-Mozilla-Status: 0001 X-Mozilla-Status2: X-Mozilla-Key

[dpdk-dev] [PATCH v3 0/2] LPM changes

2020-10-23 Thread David Marchand
>From Ruifeng Wang: The rte_lpm structure is exported because lookup API is inlined. But most of the structure can be hidden. Discussion at: http://patches.dpdk.org/patch/72403/ This patch set aimed to hide the rte_lpm structure as much as possible. A data free issue was identified and fixed. Ch

[dpdk-dev] [PATCH v3 1/2] lpm: fix free of data structure

2020-10-23 Thread David Marchand
From: Ruifeng Wang The container structure should be freed instead of rte_lpm structure after wrapping rte_lpm into internal structure __rte_lpm. Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation") Signed-off-by: Ruifeng Wang Reviewed-by: Phil Yang Acked-by: Bruce Richardson Acked-by

[dpdk-dev] [PATCH v3 2/2] lpm: hide internal data

2020-10-23 Thread David Marchand
From: Ruifeng Wang Fields except tbl24 and tbl8 in rte_lpm structure have no need to be exposed to the user. Hide the unneeded exposure of structure fields for better ABI maintainability. Suggested-by: David Marchand Signed-off-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Kevi

Re: [dpdk-dev] [PATCH v4 0/3] AVX512 vPMD on ice

2020-10-23 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Friday, October 23, 2020 12:14 PM > To: Zhang, Qi Z ; Lu, Wenzhuo > ; burce.richard...@intel.com > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH v4 0/3] AVX512 vPMD on ice > > This patchset aims to support AVX512 vPMD on ice. > > --- >

[dpdk-dev] [PATCH] net/ice: fix a error in ACL parser

2020-10-23 Thread Simei Su
A ACL rule with only mask not spec is invalid. This patch corrects incomplete implementation in parsing ACL pattern. Fixes: d623d798c7e6 ("net/ice: support ACL filter in DCF") Signed-off-by: Simei Su --- drivers/net/ice/ice_acl_filter.c | 12 ++-- 1 file changed, 10 insertions(+), 2 del

[dpdk-dev] [PATCH v2 2/5] net/mlx5: register multiple pool for Rx queue

2020-10-23 Thread Viacheslav Ovsiienko
The split feature for receiving packets was added to the mlx5 PMD, now Rx queue can receive the data to the buffers belonging to the different pools and the memory of all the involved pool must be registered for DMA operations in order to allow hardware to store the data. Signed-off-by: Viacheslav

[dpdk-dev] [PATCH v2 0/5] net/mlx5: add Rx buffer split support

2020-10-23 Thread Viacheslav Ovsiienko
This patch adds to PMD the functionality for the receiving buffer split feasture [1] [1] http://patches.dpdk.org/patch/81154/ Signed-off-by: Viacheslav Ovsiienko --- v1: http://patches.dpdk.org/patch/81808/ v2: - typos - documentation is updated Viacheslav Ovsiienko (5): net/mlx5: config

[dpdk-dev] [PATCH v2 1/5] net/mlx5: configure Rx queue to support split

2020-10-23 Thread Viacheslav Ovsiienko
The scatter-gather elements should be configured accordingly to support the buffer split feature. The application provides the desired settings for the segments at the beginning of the packets and PMD pads the buffer chain (if needed) with attributes of last specified segment to accommodate the pac

[dpdk-dev] [PATCH v2 3/5] net/mlx5: update Rx datapath to support split

2020-10-23 Thread Viacheslav Ovsiienko
Only the regular rx_burst routine is updated to support split, because the vectorized ones does not support scatter and MPRQ does not support split at all. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 11 +-- drivers/net/mlx5/mlx5_rxtx.c | 3 ++- 2 files change

[dpdk-dev] [PATCH v2 5/5] doc: add buffer split feature limitation to mlx5 guide

2020-10-23 Thread Viacheslav Ovsiienko
The buffer split feature is mentioned in the mlx5 PMD documentation, the limitation is description is added as well. Signed-off-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nic

[dpdk-dev] [PATCH v2 4/5] net/mlx5: report Rx segmentation capabilities

2020-10-23 Thread Viacheslav Ovsiienko
Add rte_eth_dev_info->rx_seg_capa parameters: - receiving to multiple pools is supported - buffer offsets are supported - no offset alignment requirement - reports the maximal number of segments - reports the buffer split offload flag Signed-off-by: Viacheslav Ovsiienko --- drivers/net

[dpdk-dev] [PATCH v3 1/5] raw/ifpga/base: fix interrupt handler instance usage

2020-10-23 Thread Tianfei zhang
From: Wei Huang Interrupt handler copied to the local 'intr_handle' variable by value before passing it to IRQ functions. This leads IRQ functions update the local variable instead of 'ifpga_irq_handle'. Instead, using 'intr_handle' local variable as pointer to 'ifpga_irq_handle' as intended. F

[dpdk-dev] [PATCH v3 3/5] raw/ifpga/base: fix return of IRQ unregister properly

2020-10-23 Thread Tianfei zhang
From: Wei Huang Since 'rte_intr_callback_unregister()' can return positive value as success, but 'ifpga_rawdev_destroy()' handle it as an error. Instead, only negative return is treated as failure. Fixes: e0a1aafe ("raw/ifpga: introduce IRQ functions") Cc: sta...@dpdk.org Signed-off-by: Wei Hu

[dpdk-dev] [PATCH v3 0/5] raw/ifpga/base: An improvement for multi-process

2020-10-23 Thread Tianfei zhang
This patches set will improve the ifpga base driver reliability in multi-process environment. Main changes from v2: - Fix typo in some commit log. Patch #1: Fix a bug for register and unregister interrupt functions. Patch #2: Fix the return value of unsupported interrupt type. Patch #3: Fix the r

[dpdk-dev] [PATCH v3 2/5] raw/ifpga/base: handle unsupported interrupt type

2020-10-23 Thread Tianfei zhang
From: Wei Huang Handle unsupported interrupt type requests properly, on unsupported interrupt case: 'ifpga_unregister_msix_irq()' returns success, 'ifpga_register_msix_irq()' return failure. Fixes: e0a1aafe ("raw/ifpga: introduce IRQ functions") Cc: sta...@dpdk.org Signed-off-by: Wei Huang Sig

[dpdk-dev] [PATCH v3 5/5] raw/ifpga/base: enhance driver reliablity in multi-process

2020-10-23 Thread Tianfei zhang
From: Wei Huang Current hardware protection is based on pthread mutex which work just for situation of multi-thread in one process. In multi-process environment, hardware state machine would be corrupted by concurrent access, that means original pthread mutex mechanism need be enhanced. The majo

[dpdk-dev] [PATCH v3 4/5] raw/ifpga/base: free resources when destroying ifpga device

2020-10-23 Thread Tianfei zhang
From: Wei Huang Add two functions to complete the resource free work, one is 'ifpga_adapter_destroy()', the other is 'ifpga_bus_uinit()'. Then call 'opae_adapter_destroy()' and 'opae_adapter_data_free()' in 'ifpga_rawdev_close()' to free resources. Also 'opae_adapter_free()' is removed from 'if

Re: [dpdk-dev] [PATCH v3] net/i40e: fix qinq flow pattern to allow non full mask

2020-10-23 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Padraig Connolly > Sent: Thursday, October 15, 2020 5:29 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Connolly, Padraig J ; > Iremonger, Bernard ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix qinq flow pattern to allow non >

[dpdk-dev] [PATCH v3 0/5] raw/ifpga/base: An improvement for multi-process

2020-10-23 Thread Tianfei zhang
This patches set will improve the ifpga base driver reliability in multi-process environment. Main changes from v2: - Fix typo in some commit log. Main changes from v3: - Split into 2 small patches, one is fix the pointer variable, other is fix the return value. - Free the driver's resource in ra

Re: [dpdk-dev] [PATCH v8 2/6] net/iavf: add IAVF request queues function

2020-10-23 Thread Ferruh Yigit
On 10/22/2020 7:48 AM, Ting Xu wrote: Add a new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs per VF, enable this request queues function. When requesting queues succeeds, PF will ret

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-10-23 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, October 21, 2020 4:28 PM > To: Juraj Linkeš > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@

[dpdk-dev] [20.11 RC1]test status update for Intel side(10/23)

2020-10-23 Thread Yu, PingX
All, Update the test status for Intel part. Till now 60% is executed, except performance drop on CVL 100G, no critical issue is found. # Basic Intel(R) NIC testing * PF/VF(i40e,ixgbe and igb): 60% is tested. 5 meson build issue are found. Some are actually bugs and some need to change the

Re: [dpdk-dev] [PATCH v5 0/5] fix vector rx burst for PMDs

2020-10-23 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Friday, October 16, 2020 5:44 PM > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei ; Wang, Haiyue ; > Yang, Qiming > Cc: dev@dpdk.org; Yigit, Ferruh ; > m...@smartsharesystems.com; step...@networkplumber.org; > barbe...@kth.se; feifei.wa...

Re: [dpdk-dev] [PATCH v8 2/6] net/iavf: add IAVF request queues function

2020-10-23 Thread Ferruh Yigit
On 10/22/2020 7:48 AM, Ting Xu wrote: Add a new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs per VF, enable this request queues function. If there is a "256" queue pair limit, shou

Re: [dpdk-dev] [PATCH v8 2/6] net/iavf: add IAVF request queues function

2020-10-23 Thread Ferruh Yigit
On 10/23/2020 11:11 AM, Ferruh Yigit wrote: On 10/22/2020 7:48 AM, Ting Xu wrote: Add a new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs per VF, enable this request queues function.

[dpdk-dev] [PATCH v2 0/4] Shared action RSS PMD impl

2020-10-23 Thread Andrey Vesnovaty
This patchset introduces Mellanox PMD implementation for shared RSS action. It was part of the 'RTE flow shared action API' patchset [1]. After v3 the ptchset was split to RTE flow layer [2] and PMD implementation (this patchset). PMD implementation of this patchset is based on RTE flow API [3].

[dpdk-dev] [PATCH v2 3/4] net/mlx5: shared action PMD

2020-10-23 Thread Andrey Vesnovaty
Handle shared action on flow validation/creation/destruction. mlx5 PMD translates shared action into a regular one before handling flow validation/creation. The shared action translation applied to utilize the same execution path for both shared and regular actions. The current implementation suppo

[dpdk-dev] [PATCH v2 1/4] common/mlx5: modify advanced Rx object via DevX

2020-10-23 Thread Andrey Vesnovaty
Implement TIR modification (see mlx5_devx_cmd_modify_tir()) using DevX API. TIR is the object containing the hashed table of Rx queue. The functionality to configure/modify this HW-related object is prerequisite to implement rete_flow_shared_action_update() for shared RSS action in mlx5 PMD. HW-rel

[dpdk-dev] [PATCH v2 2/4] net/mlx5: modify hash Rx queue objects

2020-10-23 Thread Andrey Vesnovaty
Implement modification for hashed table of Rx queue object (see mlx5_hrxq_modify()). This implementation relies on the capability to modify TIR object via DevX API, i.e. current implementation doesn't support verbs HW object operations. The functionality to modify hashed table of Rx queue object is

[dpdk-dev] [PATCH v2 4/4] net/mlx5: driver support for shared action

2020-10-23 Thread Andrey Vesnovaty
Implement shared action create/destroy/update/query. The current implementation support is limited to shared RSS action only. The shared RSS action create operation prepares hash RX queue objects for all supported permutations of the hash. The shared RSS action update operation relies on functiona

Re: [dpdk-dev] [PATCH v13 1/7] fib: make lookup function type configurable

2020-10-23 Thread David Marchand
On Thu, Oct 22, 2020 at 5:12 PM Medvedkin, Vladimir wrote: > > Hi David, > > On 22/10/2020 12:52, David Marchand wrote: > > On Mon, Oct 19, 2020 at 5:05 PM Vladimir Medvedkin > > wrote: > >> > >> Add type argument to dir24_8_get_lookup_fn() > >> Now it supports 3 different lookup implementations:

Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction issue

2020-10-23 Thread Ferruh Yigit
On 10/19/2020 3:20 AM, Yuying Zhang wrote: i40evf_execute_vf_cmd() uses _atomic_set_cmd() to execute virtual channel commands safely in multi-process mode and multi-thread mode. However, it returns -1 when one process or thread is pending. Add rte_spinlock_trylock() to handle this issue in concur

Re: [dpdk-dev] [PATCH v3] net/vhost: fix xstats wrong after clearing stats

2020-10-23 Thread Maxime Coquelin
On 10/15/20 7:49 PM, David Christensen wrote: > The PMD API allows stats and xstats values to be cleared separately. > This is a problem for the vhost PMD since some of the xstats values are > derived from existing stats values. For example: > > testpmd> show port xstats all > ... > tx_unicast

Re: [dpdk-dev] [PATCH v3 01/11] net/bnxt: add stingray support to core layer

2020-10-23 Thread Ferruh Yigit
On 10/22/2020 11:05 PM, Ajit Khaparde wrote: diff --git a/drivers/net/bnxt/tf_core/cfa_resource_types.h b/drivers/net/bnxt/tf_core/cfa_resource_types.h index 19838c393d..412204f7ed 100644 --- a/drivers/net/bnxt/tf_core/cfa_resource_types.h +++ b/drivers/net/bnxt/tf_core/cfa_resource_types.h @@ -

Re: [dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API

2020-10-23 Thread Maxime Coquelin
On 10/21/20 7:44 AM, Patrick Fu wrote: > By design, async enqueue API should return directly if async device > is not registered. This patch removes the corrupted implementation of > the enqueue fallback from async mode to sync mode. > > Fixes: cd6760da1076 ("vhost: introduce async enqueue for

Re: [dpdk-dev] [PATCH v10 1/4] example/vhost: add async vhost args parsing function

2020-10-23 Thread Maxime Coquelin
On 10/22/20 10:59 AM, Cheng Jiang wrote: > This patch is to add async vhost driver arguments parsing function > for CBDMA channel, DMA initiation function and args description. > The meson build file is changed to fix dependency problem. With > these arguments vhost device can be set to use CBDM

Re: [dpdk-dev] [PATCH v10 2/4] example/vhost: add support for vhost async data path

2020-10-23 Thread Maxime Coquelin
On 10/22/20 10:59 AM, Cheng Jiang wrote: > This patch is to implement vhost DMA operation callbacks for CBDMA > PMD and add vhost async data-path in vhost sample. With providing > callback implementation for CBDMA, vswitch can leverage IOAT to > accelerate vhost async data-path. > > Signed-off-

Re: [dpdk-dev] [PATCH v10 3/4] doc: update vhost sample doc for vhost async data path

2020-10-23 Thread Maxime Coquelin
On 10/22/20 10:59 AM, Cheng Jiang wrote: > Add vhost async driver arguments information for vhost async data > path in vhost sample application. > > Signed-off-by: Cheng Jiang > --- > doc/guides/sample_app_ug/vhost.rst | 11 +++ > 1 file changed, 11 insertions(+) > Reviewed-by: Maxim

Re: [dpdk-dev] [PATCH v10 4/4] doc: update release notes for vhost sample

2020-10-23 Thread Maxime Coquelin
On 10/22/20 10:59 AM, Cheng Jiang wrote: > Add release notes for vhost async data path support in vhost sample. > > Signed-off-by: Cheng Jiang > --- > doc/guides/rel_notes/release_20_11.rst | 6 ++ > 1 file changed, 6 insertions(+) > Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [dpdk-dev] [PATCH 0/7] vhost: make VQ metadata dereferencing robust

2020-10-23 Thread Maxime Coquelin
On 10/19/20 7:34 PM, Maxime Coquelin wrote: > The series aims at improving virtqueue metadata pointers > dereferencing robust. > > First patch fixes a real issue reported by our QE. > > Five next patches validates queue index passed as input > of the Vhost API. They are split in 5 patches to e

Re: [dpdk-dev] [PATCH v3] net/vhost: fix xstats wrong after clearing stats

2020-10-23 Thread Maxime Coquelin
On 10/15/20 7:49 PM, David Christensen wrote: > The PMD API allows stats and xstats values to be cleared separately. > This is a problem for the vhost PMD since some of the xstats values are > derived from existing stats values. For example: > > testpmd> show port xstats all > ... > tx_unicast

Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-10-23 Thread Maxime Coquelin
On 10/22/20 10:59 AM, Cheng Jiang wrote: > This patch set makes vhost-vswitch be able to use vhost async APIs > for enqueue operations. Demonstrated how the application > leverage IOAT DMA channel with vhost async APIs. > > We introduce two parameters to enable DMA acceleration for Tx > operati

Re: [dpdk-dev] [PATCH v1] vhost: remove fallback in async enqueue API

2020-10-23 Thread Maxime Coquelin
On 10/21/20 7:44 AM, Patrick Fu wrote: > By design, async enqueue API should return directly if async device > is not registered. This patch removes the corrupted implementation of > the enqueue fallback from async mode to sync mode. > > Fixes: cd6760da1076 ("vhost: introduce async enqueue for

Re: [dpdk-dev] [PATCH v5 0/3] fixes for device event

2020-10-23 Thread David Marchand
On Wed, Oct 21, 2020 at 1:18 PM wangyunjian wrote: > > From: Yunjian Wang > > This series include three fixes patches for device event. For the series, Acked-by: David Marchand Applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v1] examples/pipeline: fix help command

2020-10-23 Thread David Marchand
On Thu, Oct 22, 2020 at 1:03 PM Yogesh Jangra wrote: > > This patch has the changes to list all supported commands and fix > supported commands help details. > > Fixes: 5074e1d55107 ("examples/pipeline: add configuration commands") > > Signed-off-by: Yogesh Jangra > Acked-by: Cristian Dumitrescu

Re: [dpdk-dev] [v3 1/2] cryptodev: support enqueue callback functions

2020-10-23 Thread Gujjar, Abhinandan S
Hi Honnappa, I will take care of this in next patch set. > -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, October 21, 2020 12:58 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; akhil.go...@nxp.com; Ananyev, > Konstantin > Cc: Vangati, Narender ; jer

Re: [dpdk-dev] [v3 1/2] cryptodev: support enqueue callback functions

2020-10-23 Thread Gujjar, Abhinandan S
Hi Konstantin, Thanks. I will generate a new patch with suggested changes. > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 22, 2020 1:04 AM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; akhil.go...@nxp.com; > honnappa.nagaraha...@arm.com > Cc:

Re: [dpdk-dev] [PATCH] net/ena: remove unused macro

2020-10-23 Thread Michał Krawczyk
pt., 23 paź 2020 o 10:44 David Marchand napisał(a): > > This assert macro is not called anymore. > This also fixes an invalid reference to RTE_LOGTYPE_ERR that does not > exist. > > Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version") > Fixes: 6f1c9df9e9cc ("net/ena: use dynamic log ty

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-23 Thread yang_y_yi
Konstantin, thank you so much for comments, my replies inline, please check them. At 2020-10-22 21:16:43, "Ananyev, Konstantin" wrote: > >> >> rte_gso_segment decreased refcnt of pkt by one, but >> it is wrong if pkt is external mbuf, pkt won't be >> freed because of incorrect refcnt, the resul

Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-10-23 Thread Ferruh Yigit
On 10/23/2020 12:23 PM, Maxime Coquelin wrote: On 10/22/20 10:59 AM, Cheng Jiang wrote: This patch set makes vhost-vswitch be able to use vhost async APIs for enqueue operations. Demonstrated how the application leverage IOAT DMA channel with vhost async APIs. We introduce two parameters to e

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-23 Thread yang_y_yi
At 2020-10-22 23:33:42, "Ananyev, Konstantin" wrote: > >> > >> > rte_gso_segment decreased refcnt of pkt by one, but >> > it is wrong if pkt is external mbuf, pkt won't be >> > freed because of incorrect refcnt, the result is >> > application can't allocate mbuf from mempool because >> > mbufs in

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-23 Thread yang_y_yi
At 2020-10-23 08:57:15, "Hu, Jiayu" wrote: > > >> -Original Message- >> From: Ananyev, Konstantin >> Sent: Thursday, October 22, 2020 11:34 PM >> To: yang_y...@163.com; dev@dpdk.org >> Cc: Hu, Jiayu ; techbo...@dpdk.org; >> tho...@monjalon.net; yangy...@inspur.com >> Subject: RE: [PATCH v

Re: [dpdk-dev] [PATCH v3 1/5] test/ring: fix the memory dump size

2020-10-23 Thread Ananyev, Konstantin
> Pass the correct number of bytes to dump the memory. > > Fixes: bf28df24e915 ("test/ring: add contention stress test" > Cc: konstantin.anan...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > --- > app/test/test_ring_stress_impl.h | 2

[dpdk-dev] [PATCH v3] net/mlx5: implement tunnel offload API

2020-10-23 Thread Gregory Etelson
Tunnel Offload API provides hardware independent, unified model to offload tunneled traffic. Key model elements are: - apply matches to both outer and inner packet headers during entire offload procedure; - restore outer header of partially offloaded packet; - model is implemented as a set of

[dpdk-dev] [PATCH v4] net/mlx5: implement tunnel offload API

2020-10-23 Thread Gregory Etelson
Tunnel Offload API provides hardware independent, unified model to offload tunneled traffic. Key model elements are: - apply matches to both outer and inner packet headers during entire offload procedure; - restore outer header of partially offloaded packet; - model is implemented as a set of

Re: [dpdk-dev] [PATCH v3 2/5] lib/ring: add zero copy APIs

2020-10-23 Thread Ananyev, Konstantin
> > Add zero-copy APIs. These APIs provide the capability to > copy the data to/from the ring memory directly, without > having a temporary copy (for ex: an array of mbufs on > the stack). Use cases that involve copying large amount > of data to/from the ring can benefit from these APIs. LGTM i

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ena: remove unused macro

2020-10-23 Thread Ferruh Yigit
On 10/23/2020 1:56 PM, Michał Krawczyk wrote: pt., 23 paź 2020 o 10:44 David Marchand napisał(a): This assert macro is not called anymore. This also fixes an invalid reference to RTE_LOGTYPE_ERR that does not exist. Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version") Fixes: 6f1c9

Re: [dpdk-dev] [PATCH v3 5/5] test/ring: add stress tests for zero copy APIs

2020-10-23 Thread Ananyev, Konstantin
> > Add stress tests for zero copy API. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > --- > app/test/meson.build | 2 + > app/test/test_ring_mt_peek_stress_zc.c | 56 ++ > app/test/test_ring_st_peek_stress_zc.c | 65 +

Re: [dpdk-dev] [PATCH v2 2/3] examples/l3fwd: use IP reserved addresses for EM mode

2020-10-23 Thread David Marchand
On Sun, Aug 2, 2020 at 8:17 PM wrote: > > From: Pavan Nikhilesh > > The l3fwd example should use the reserved IPv4/v6 reserved address > ranges defined in RFC5735 and RFC5180 and RFC863 discard protocol for > the port number in the exact match mode of L3 forwarding. > > Signed-off-by: Pavan Nikhi

Re: [dpdk-dev] [PATCH v2 1/4] common/mlx5: modify advanced Rx object via DevX

2020-10-23 Thread Slava Ovsiienko
> -Original Message- > From: Andrey Vesnovaty > Sent: Friday, October 23, 2020 13:24 > To: dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > step...@networkplumber.org; bruce.richard...@intel.com; Ori Kam > ; Slava Ovsiien

Re: [dpdk-dev] [PATCH v2 2/4] net/mlx5: modify hash Rx queue objects

2020-10-23 Thread Slava Ovsiienko
> -Original Message- > From: Andrey Vesnovaty > Sent: Friday, October 23, 2020 13:24 > To: dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > step...@networkplumber.org; bruce.richard...@intel.com; Ori Kam > ; Slava Ovsiien

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: shared action PMD

2020-10-23 Thread Slava Ovsiienko
> -Original Message- > From: Andrey Vesnovaty > Sent: Friday, October 23, 2020 13:24 > To: dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > step...@networkplumber.org; bruce.richard...@intel.com; Ori Kam > ; Slava Ovsiien

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: driver support for shared action

2020-10-23 Thread Slava Ovsiienko
> -Original Message- > From: Andrey Vesnovaty > Sent: Friday, October 23, 2020 13:24 > To: dev@dpdk.org > Cc: j...@marvell.com; jerinjac...@gmail.com; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > step...@networkplumber.org; bruce.richard...@intel.com; Ori Kam > ; Slava Ovsiien

Re: [dpdk-dev] [PATCH v3 4/5] test/ring: add functional tests for zero copy APIs

2020-10-23 Thread Ananyev, Konstantin
> > Add functional tests for zero copy APIs. Test enqueue/dequeue > functions are created using the zero copy APIs to fit into > the existing testing method. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > --- > app/test/test_ring.c | 196

Re: [dpdk-dev] [PATCH v3 3/5] test/ring: move common function to header file

2020-10-23 Thread Ananyev, Konstantin
> Move test_ring_inc_ptr to header file so that it can be used by > functions in other files. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > --- > app/test/test_ring.c | 11 --- > app/test/test_ring.h | 11 +++ > 2 files changed, 11 insertions(+), 11 de

Re: [dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-23 Thread Ananyev, Konstantin
> From: yang_y_yi > Sent: Friday, October 23, 2020 2:18 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Hu, Jiayu ; techbo...@dpdk.org; > tho...@monjalon.net; yangy...@inspur.com > Subject: Re:RE: [PATCH v2] gso: fix free issue of mbuf gso segments attach to > > Konstantin, thank you so much f

[dpdk-dev] [PATCH v4 0/6] Arm build options rework

2020-10-23 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds.

[dpdk-dev] [PATCH v4 1/6] build: alias default build as generic

2020-10-23 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

[dpdk-dev] [PATCH v4 2/6] build: refactor Arm build

2020-10-23 Thread Juraj Linkeš
* Rename variables to have names that better describe what the variables store * Remove unused or superfluous variables * Change a list to dictionary where key lookup is needed * Add informatory comments in the code * Minor code restructure and reformatting Signed-off-by: Juraj Linkeš --- config

[dpdk-dev] [PATCH v4 3/6] build: optional NUMA and cpu counts detection

2020-10-23 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

[dpdk-dev] [PATCH v4 4/6] build: add core and NUMA counts to cross files

2020-10-23 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc| 2 ++ config/arm/arm64_armv8_linux_gcc | 6 ++

[dpdk-dev] [PATCH v4 5/6] build: disable Arm drivers

2020-10-23 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works. Signed-off-by: Juraj Linkeš Acked-by: Bruce Richardson --- config/arm/meson.build | 9 +++

[dpdk-dev] [PATCH v4 6/6] build: update Arm builds with makefile flags

2020-10-23 Thread Juraj Linkeš
Not all flags were moved properly from the old Makefile build system. Disable corresponding drivers and libnuma in cross files and remove deprecated config. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc| 2 ++ config/arm/arm64_armv8_linux_gcc | 8 ++-- config/arm/

[dpdk-dev] [PATCH] common/qat: add missing kmod dependency

2020-10-23 Thread Didier Pallard
Dependency on kmod needed to manage crypto devices is missing in qat crypto pmd. Cc: sta...@dpdk.org Fixes: 0880c40113ef ("drivers: advertise kmod dependencies in pmdinfo") Signed-off-by: Didier Pallard --- drivers/common/qat/qat_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

[dpdk-dev] [PATCH] crypto/octeontx: fix crypto OOP support

2020-10-23 Thread Didier Pallard
Out of place with linear buffers is supported by octeontx while not advertised. Cc: sta...@dpdk.org Fixes: 0dc1cffa4d33 ("crypto/octeontx: add hardware init routine") Signed-off-by: Didier Pallard --- drivers/crypto/octeontx/otx_cryptodev_ops.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[dpdk-dev] [PATCH] crypto/octeontx2: fix crypto OOP support

2020-10-23 Thread Didier Pallard
Out of place with linear buffers is supported by octeontx2 while not advertised. Cc: sta...@dpdk.org Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities") Signed-off-by: Didier Pallard --- drivers/crypto/octeontx2/otx2_cryptodev.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [dpdk-dev] [PATCH v2 00/14] ethdev: remove legacy filter API

2020-10-23 Thread Ferruh Yigit
On 10/22/2020 10:42 AM, Andrew Rybchenko wrote: Removal is aggressive and tries to cleanup all dead code from drivers. tep_termination example still uses TUNNEL filters. Functionality is broken when TUNNEL filter is removed and finally even build of the example is broken when API is removed. It

Re: [dpdk-dev] [PATCH v13 1/7] fib: make lookup function type configurable

2020-10-23 Thread Medvedkin, Vladimir
Hello, On 23/10/2020 11:29, David Marchand wrote: On Thu, Oct 22, 2020 at 5:12 PM Medvedkin, Vladimir wrote: Hi David, On 22/10/2020 12:52, David Marchand wrote: On Mon, Oct 19, 2020 at 5:05 PM Vladimir Medvedkin wrote: Add type argument to dir24_8_get_lookup_fn() Now it supports 3 diffe

Re: [dpdk-dev] [PATCH v2 2/2] lpm: hide internal data

2020-10-23 Thread Medvedkin, Vladimir
Hello, On 23/10/2020 07:13, Ruifeng Wang wrote: -Original Message- From: David Marchand Sent: Thursday, October 22, 2020 11:14 PM To: Ruifeng Wang Cc: Bruce Richardson ; Vladimir Medvedkin ; dev ; Honnappa Nagarahalli ; nd ; Kevin Traynor ; tho...@monjalon.net Subject: Re: [PATCH v2

[dpdk-dev] [PATCH v1] doc: update abi version references

2020-10-23 Thread Ray Kinsella
Updated references to abi versions in the contributors guide. Signed-off-by: Ray Kinsella --- doc/guides/contributing/abi_policy.rst | 52 - doc/guides/contributing/abi_versioning.rst | 120 ++--- 2 files changed, 86 insertions(+), 86 deletions(-) diff --git a/doc/g

[dpdk-dev] [PATCH v1] doc: add recommendation to update to latest openssl version

2020-10-23 Thread John McNamara
Add recommendation to update to latest OpenSSL version when using the OpenSSL PMD and to at least version 1.1.1g to avoid known CVEs. Signed-off-by: John McNamara --- doc/guides/cryptodevs/openssl.rst | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/d

Re: [dpdk-dev] [PATCH 1/2] net/netvsc: allow setting rx and tx copy break

2020-10-23 Thread Ferruh Yigit
On 10/22/2020 8:46 PM, Long Li wrote: From: Stephen Hemminger The values for Rx and Tx copy break should be tunable rather than hard coded constants. The rx_copybreak sets the threshold where the driver uses an external mbuf to avoid having to copy data. Setting 0 for copybreak will cause driv

Re: [dpdk-dev] [PATCH 2/2] net/netvsc: introduce driver parameter to control the use of external mbuf on receiving data

2020-10-23 Thread Ferruh Yigit
On 10/22/2020 8:46 PM, Long Li wrote: From: Long Li When receiving packets, netvsp puts data in a buffer mapped through UIO. Depending on packet size, netvsc may attach the buffer as an external mbuf. This is not a problem if this mbuf is consumed in the application, and the application can cor

Re: [dpdk-dev] [EXT] [PATCH] net/mvpp2: fix memory leak in error path

2020-10-23 Thread Ferruh Yigit
On 10/22/2020 7:40 AM, Liron Himi wrote: <...> Subject: [EXT] [dpdk-dev] [PATCH] net/mvpp2: fix memory leak in error path External Email -- From: Yunjian Wang In mrvl_create() allocated memory for 'mtr', we don't free it wh

<    1   2   3   >