Re: [dpdk-dev] [PATCH v1] regexdev: add OOS capability definition

2020-10-20 Thread Ori Kam
Hi Guy > -Original Message- > From: g...@marvell.com > Sent: Tuesday, October 20, 2020 11:16 AM > dev@dpdk.org; jer...@marvell.com > Subject: [PATCH v1] regexdev: add OOS capability definition > > From: Guy Kaneti > > Add out of order scan capability to check PMD > support for OOS. >

[dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities

2020-10-20 Thread guyk
From: Guy Kaneti configure qp with OOS according to device capabilities returned from rte_regexdev_info_get. Signed-off-by: Guy Kaneti --- app/test-regex/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-regex/main.c b/app/test-regex/main.c index e6080b44b.

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: handle removal of associated pci device

2020-10-20 Thread Gaëtan Rivet
Hi Thomas, This issue has already been fixed, see: http://mails.dpdk.org/archives/dev/2020-October/185921.html It has been integrated, Long was able to test it and confirm it fixed this issue. On 20/10/20 00:36 +0200, Thomas Monjalon wrote: > Fixing Gaetan's address > > 20/10/2020 00:33, Thomas

[dpdk-dev] [PATCH v2 04/62] common/sfc_efx/base: add MAE init/fini APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The patch adds APIs for client drivers to initialise / finalise MAE-specific context in NIC control structure. The context itself will be used by the follow-up patches to store supportive data for library-internal consumers. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybch

[dpdk-dev] [PATCH v2 05/62] drivers: init/fini MAE on attach/detach

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov These actions affect MAE supplementary resources which are libefx-internal. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/efsys.h | 2 +- drivers/net/sfc/sfc_mae.c | 17 + 2 files changed,

[dpdk-dev] [PATCH v2 00/62] net/sfc: support flow API transfer rules

2020-10-20 Thread Andrew Rybchenko
Transfer rules for Alveo SN1000 SmartNICs support matching on various inner and outer packet headers, traffic source items like PORT_ID, PHY_PORT, PF and VF and actions to route traffic to destination (PORT_ID, PHY_PORT, PF, VF or DROP), MARK, FLAG and apply VLAN push/pop transformations. Andrew

[dpdk-dev] [PATCH v2 06/62] common/sfc_efx/base: add an MAE limit query API

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add an API for client drivers to query the engine limits. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 10 +++ drivers/common/sfc_efx/base/efx_impl.h| 1 + drivers/common/sfc_

[dpdk-dev] [PATCH v2 03/62] net/sfc: add a stub for attaching to MAE

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add a stub for MAE attach / detach path and introduce MAE-specific context. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/meson.build | 1 + drivers/net/sfc/sfc.c | 8 ++ drivers/net/sfc/sfc.h | 2 +

[dpdk-dev] [PATCH v2 02/62] common/sfc_efx/base: indicate support for MAE

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Riverhead boards maintain support for MAE, a low-level Match-Action Engine. The feature is documented in SF-122526-TC. The new field will help client drivers to test NIC support for MAE status. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreto

[dpdk-dev] [PATCH v2 07/62] net/sfc: add the concept of MAE (transfer) rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Define the corresponding specification structure and make the code identify MAE rules by testing transfer attribute presence. Also, add a priority level check. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst

Re: [dpdk-dev] [PATCH v1] app/regex: configure qp according to device capabilities

2020-10-20 Thread Ori Kam
Hi Guy, > -Original Message- > From: g...@marvell.com > Sent: Tuesday, October 20, 2020 12:10 PM > Subject: [PATCH v1] app/regex: configure qp according to device capabilities > > From: Guy Kaneti > > configure qp with OOS according to device capabilities > returned from rte_regexdev

[dpdk-dev] [PATCH v2 10/62] common/sfc_efx/base: add a match spec validate API

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov MAE has restrictions on what kind of mask a particular field can have in a match specification. Add an API for client drivers to check specifications. The patch defines a field description list, whilst the list itself is left empty. This is to provide a general idea of how field

[dpdk-dev] [PATCH v2 09/62] net/sfc: add pattern parsing stub to MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add pattern parsing stub, define and implement flow cleanup method. The latter is needed to free any dynamic structures allocated during flow parsing. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_flow.c | 41

[dpdk-dev] [PATCH v2 13/62] net/sfc: add verify method to flow validate path

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The new method is needed to make sure that a flow being validated will have a chance to be accepted by the FW. MAE-specific implementation of the method should compare the class of a rule being validated with the corresponding classes of active rules, and, if no matches found, ma

[dpdk-dev] [PATCH v2 08/62] common/sfc_efx/base: add match spec init/fini APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov An MAE rule is a function of match criteria and a priority. The said match criteria have to be provided using "mask-value pairs" packing format which on its own should not be exposed to client drivers. The latter have to use a functional interface of sorts in order to generate a

[dpdk-dev] [PATCH v2 18/62] common/sfc_efx/base: add MAE match fields for Ethernet

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 3 ++

[dpdk-dev] [PATCH v2 17/62] net/sfc: support flow item PHY PORT in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 +++ drivers/net/sfc/sfc_mae.c | 69 + drive

[dpdk-dev] [PATCH v2 21/62] net/sfc: support flow action PHY PORT in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action DELIVER with MPORT of a given physical port. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 drivers/net/sfc/sfc_mae.c | 40 +++

[dpdk-dev] [PATCH v2 11/62] net/sfc: validate match spec in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Validate the match specification resulting from pattern parsing within MAE backend in RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 8 1 file changed, 8 insertions(+) dif

[dpdk-dev] [PATCH v2 01/62] common/sfc_efx/base: add MAE definitions to MCDI

2020-10-20 Thread Andrew Rybchenko
MAE stands for Match-Action-Engine and will be used to support rte_flow API transfer rules. Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2232 +++ 1 file changed, 2232 insertions(+) diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/

[dpdk-dev] [PATCH v2 12/62] common/sfc_efx/base: add a match specs class comparison API

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov >From MAE standpoint, a flow rule belongs to some class. Field capabilities advertised by the FW provide a hint on whether changing a particular match field value or its mask will affect the class of the rule. A client driver can make use of the concept of a class by comparing a

[dpdk-dev] [PATCH v2 22/62] common/sfc_efx/base: add MAE action set provisioning APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The patch adds APIs for action set allocation / release. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 20 +++ drivers/common/sfc_efx/base/efx_mae.c | 128 ++ .

[dpdk-dev] [PATCH v2 24/62] net/sfc: implement flow insert/remove in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Exercise action set allocation / release and action rule insertion / removal in order to let flow API callers actually get created flows functioning. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_flow.c | 5 +-

[dpdk-dev] [PATCH v2 19/62] net/sfc: support flow item ETH in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/sfc_mae.c | 106 2 file

[dpdk-dev] [PATCH v2 25/62] common/sfc_efx/base: support adding VLAN POP action to a set

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov MAE supports stripping two tags, so this action can be requested once or twice. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 5 ++ drivers/common/sfc_efx/base/efx_impl.h| 7 +

[dpdk-dev] [PATCH v2 27/62] common/sfc_efx/base: support adding VLAN PUSH action

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov MAE supports pushing two tags, so this action can be requested once or twice. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 7 ++ drivers/common/sfc_efx/base/efx_impl.h| 12 +++

[dpdk-dev] [PATCH v2 14/62] common/sfc_efx/base: add action set spec init/fini APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The engine is only able to carry out chosen actions on matching packets in a strict order. No MCDI exists to identify supported actions and the order. Still, the definition of the latter is available from the FW documentation. The general idea is to define an action specificatio

[dpdk-dev] [PATCH v2 15/62] net/sfc: add actions parsing stub to MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov If parsing a flow results in an action set specification identical to an already existing one, duplication will be avoided by reusing the list entry of the latter. Using an attach helper and a reference counter is meant to serve the said purpose. Signed-off-by: Ivan Malov Signe

[dpdk-dev] [PATCH v2 16/62] common/sfc_efx/base: support setting a PPORT in a match spec

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add an API for setting mask-value pairs in a match specification structure and add support for MAE field INGRESS_PORT of type PPORT. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 48 ++

[dpdk-dev] [PATCH v2 29/62] net/sfc: support VLAN PUSH actions in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov A group of actions (OF_PUSH_VLAN, OF_VLAN_SET_VID and OF_VLAN_SET_PCP) maps to MAE action VLAN_PUSH. This action group is supported only for rules which have transfer attribute, and can be requested once or twice per a rule. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybc

[dpdk-dev] [PATCH v2 20/62] common/sfc_efx/base: support adding DELIVER action to a set

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Introduce a mechanism for adding actions to an action set and add support for DELIVER action. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 11 +- drivers/common/sfc_efx/base/efx_impl.

[dpdk-dev] [PATCH v2 31/62] net/sfc: support flow action FLAG in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action FLAG. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_mae.c | 5 + 2 files changed, 7 insertions(+) diff --git a/doc/guides/nics/sfc_

[dpdk-dev] [PATCH v2 23/62] common/sfc_efx/base: add MAE action rule provisioning APIs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add APIs for action rule insert / remove operations. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 29 drivers/common/sfc_efx/base/efx_mae.c | 150 ++ .../

[dpdk-dev] [PATCH v2 28/62] net/sfc: add facilities to handle bundles of actions

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov There are MAE actions which do not have uniform counterparts in terms of RTE flow. However, there are bundles of RTE flow actions which can be considered as such counterparts. Implement facilities to handle related RTE flow actions as parts of a whole. These facilities will be u

[dpdk-dev] [PATCH v2 34/62] common/sfc_efx/base: add named constant for invalid VF

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov This makes existing code clearer. Also, it will be used by a later patch. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/

[dpdk-dev] [PATCH v2 39/62] net/sfc: support flow action DROP in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Effectively, the resulting action will be of type DELIVER, and destination MPORT will be a properly constructed NULL value. This will achieve the requested behaviour (no delivery). Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/gu

[dpdk-dev] [PATCH v2 26/62] net/sfc: support flow action OF POP VLAN in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov This action is supported only for rules which have transfer attribute, and can be requested once or twice per a rule. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_mae.c | 3 +

[dpdk-dev] [PATCH v2 33/62] net/sfc: support flow action MARK in MAE backend

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action MARK. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_mae.c | 12 2 files changed, 14 insertions(+) diff --git a/doc/guides

[dpdk-dev] [PATCH v2 30/62] common/sfc_efx/base: support adding FLAG action to a set

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov This action can be added at any point before DELIVER. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 5 ++ drivers/common/sfc_efx/base/efx_impl.h| 8 +++ drivers/common/sfc_efx

[dpdk-dev] [PATCH v2 37/62] net/sfc: support flow actions PF and VF in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action DELIVER with MPORT of the PF/VF. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 drivers/net/sfc/sfc_mae.c | 34 ++ 2 files

[dpdk-dev] [PATCH v2 36/62] net/sfc: support flow items PF and VF in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for these flow items to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 4 ++ drivers/net/sfc/sfc_mae.c | 126 dri

[dpdk-dev] [PATCH v2 32/62] common/sfc_efx/base: support adding MARK action to a set

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov This action can be added at any point before DELIVER. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 6 ++ drivers/common/sfc_efx/base/efx_impl.h| 2 + drivers/common/sfc_efx/b

[dpdk-dev] [PATCH v2 44/62] net/sfc: support flow action PORT ID in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The action handler will use MAE action DELIVER with MPORT of the PCIe function associated with a given DPDK port ID. The DPDK port must not relate to a different physical device. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guid

[dpdk-dev] [PATCH v2 49/62] net/sfc: support flow item IPV4 in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 3 + drivers/net/sfc/sfc_mae.c | 121 driver

[dpdk-dev] [PATCH v2 42/62] net/sfc: add HW switch ID helpers

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov The driver will need a means to figure out relationship between RTE ethdev instances and underlying HW switch entities. For now, use board serial number string as a unique HW switch identifier. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton

[dpdk-dev] [PATCH v2 38/62] common/sfc_efx/base: add an API for adding action DROP

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Client drivers may need to request that matching traffic be dropped. Add a dedicated API to support this. The API relies on action DELIVER with properly constructed NULL MPORT argument. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- d

[dpdk-dev] [PATCH v2 48/62] common/sfc_efx/base: add MAE match fields for IPv4

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 5 +

[dpdk-dev] [PATCH v2 41/62] common/sfc_efx/base: add an API for querying board info

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Riverhead boards can provide extended version information. Implement facilities necessary to obtain it. Add an API for querying board information. A client driver may use this to discover which of its instances relate to which physical boards, based on board serial number persis

[dpdk-dev] [PATCH v2 45/62] net/sfc: support flow item PORT ID in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. The DPDK port must not relate to a different physical device. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/

[dpdk-dev] [PATCH v2 35/62] common/sfc_efx/base: add an API to get MPORT of a PF/VF

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov PCIe functions have static MPORTs which can be utilised by MAE rules as delivery destinations for matching traffic. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 14 +++ drivers/com

[dpdk-dev] [PATCH v2 53/62] net/sfc: support flow item TCP in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 + drivers/net/sfc/sfc_mae.c | 77 + drivers

[dpdk-dev] [PATCH v2 40/62] common/sfc_efx/base: refactor version / boot info get helper

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Refactor MCDI helper for version information and boot status retrieval; it should comprise two dedicated helper functions. A later patch will extend and reuse version retrieval helper. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/

[dpdk-dev] [PATCH v2 58/62] common/sfc_efx/base: add an API to compare match specs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Match specification format and its size are not exposed to clients. Provide an API to compare two match specifications. A client would typically use this API to compare a match specification of an outer rule being validated with match specifications of already active outer rules

[dpdk-dev] [PATCH v2 60/62] common/sfc_efx/base: support outer rule provisioning

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Let the client insert / remove outer rules. Let the client refer to an inserted outer rule in a match specification of type ACTION. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 21 ++

[dpdk-dev] [PATCH v2 59/62] common/sfc_efx/base: validate and compare outer match specs

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Let the client validate an outer match specification. Let the client comprare classes of two outer match specifications. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx_impl.h | 3 + drivers/common/sfc

[dpdk-dev] [PATCH v2 46/62] common/sfc_efx/base: add MAE match fields for VLAN

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 4 ++

[dpdk-dev] [PATCH v2 57/62] common/sfc_efx/base: add MAE match field VNET ID for tunnels

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for this field and provide necessary mappings for it to be inserted directly into mask-value pairs buffer. VNET_ID can be used to serve the following match fields: rte_flow_item_vxlan.vni, rte_flow_item_geneve.vni, rte_flow_item_nvgre.tni Signed-

[dpdk-dev] [PATCH v2 47/62] net/sfc: support flow item VLAN in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. In a pattern, a L2 item preceding an item VLAN must have correct "type" ("inner_type") set depending on the total number of VLAN tags (double-tagging is supported): "pattern eth type is X / vlan / end", X =

[dpdk-dev] [PATCH v2 51/62] net/sfc: support flow item IPV6 in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 3 + drivers/net/sfc/sfc_mae.c | 106 driver

[dpdk-dev] [PATCH v2 54/62] net/sfc: support flow item UDP in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for this flow item to MAE-specific RTE flow implementation. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- doc/guides/nics/sfc_efx.rst | 2 ++ drivers/net/sfc/sfc_mae.c | 53 + driver

[dpdk-dev] [PATCH v2 62/62] doc: advertise flow API transfer rules support in net/sfc

2020-10-20 Thread Andrew Rybchenko
Transfer rules support matching on various inner and outer packet headers, traffic source items like PORT_ID, PHY_PORT, PF and VF and actions to route traffic to destination (PORT_ID, PHY_PORT, PF, VF or DROP), MARK, FLAG and apply VLAN push/pop transformations. Signed-off-by: Andrew Rybchenko --

[dpdk-dev] [PATCH v2 61/62] net/sfc: support encap. flow items in transfer rules

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add support for flow items VXLAN, Geneve and NVGRE to MAE-specific RTE flow implementation. Having support for these items implies the ability to insert so-called outer MAE rules and refer to them in MAE action rules. The patch takes care of all necessary facilities to do that.

[dpdk-dev] [PATCH v2 50/62] common/sfc_efx/base: add MAE match fields for IPv6

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 2 ++

[dpdk-dev] [PATCH v2 43/62] net/sfc: support the concept of RTE switch domains/ports

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov A later patch will add support for RTE flow action PORT_ID to MAE backend. The driver has to ensure that such actions refer to RTE ethdev instances deployed on top of the same physical device. Also, the driver needs a means to find sibling RTE ethdev instances when parsing such a

[dpdk-dev] [PATCH v2 56/62] common/sfc_efx/base: add MAE encap. match fields

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. These fields are meant to comprise a so-called outer match specification; provide necessary definitions. Signed-off-by: Ivan Malov Sig

[dpdk-dev] [PATCH v2 52/62] common/sfc_efx/base: add MAE match fields for TCP and UDP

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov Add MCDI-compatible enumeration for these fields and provide necessary mappings for them to be inserted directly into mask-value pairs buffer. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/efx.h | 3 ++

[dpdk-dev] [PATCH v2 55/62] common/sfc_efx/base: indicate MAE support for encapsulation

2020-10-20 Thread Andrew Rybchenko
From: Ivan Malov MAE provides support for encapsulation. One needs to insert a so-called outer rule, which can match outer packet fields, to require that matching packets be parsed as tunnel frames of a given type (VXLAN, Geneve, NVGRE). Then it is possible to chain this rule with an action rule

[dpdk-dev] [PATCH] config: fix kni build

2020-10-20 Thread Bruce Richardson
When building kernel modules such as kni, the "config" directory is not passed as a standard path in the EXTRA_CFLAGS value, meaning that the rte_compatibility_defines.h is not found from rte_config.h. However, since both headers are in the same directory, we can just use quotes rather than angle-b

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-10-20 Thread Gujjar, Abhinandan S
Hi Honnappa, I will send out the next version of the patch soon. Regards Abhinandan > -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, October 20, 2020 3:34 AM > To: Ananyev, Konstantin ; Gujjar, Abhinandan S > ; dev@dpdk.org; Doherty, Declan > > Cc: jer...@marvell.com;

Re: [dpdk-dev] [PATCH] eal/windows: fix missing header inclusion

2020-10-20 Thread Dmitry Kozlyuk
On Tue, 20 Oct 2020 11:48:15 +0300, Tal Shnaiderman wrote: > Following the addition of the in_addr/in6_addr structs > to in.h the header file must have stdint.h included > for the definitions of the uint8_t/uint32_t types used > within the new structs. > > Not having it could results in the follow

Re: [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Kevin Traynor
On 20/10/2020 10:11, Maxime Coquelin wrote: > > > On 10/20/20 11:01 AM, Kevin Traynor wrote: >> On 20/10/2020 08:16, Adrian Moreno wrote: >>> If stat fails it means the backend must be vhost-user in server mode >>> >>> Bugzilla ID: 559 >>> Fixes: f908b22ea47a ("net/virtio: move backend type selec

[dpdk-dev] [Bug 559] [dpdk-20.11]loopback_virtio_user_server_mode: failed to start virtio-user with Virtio user server mode

2020-10-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=559 xizhan4x (xix.zh...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Maxime Coquelin
On 10/20/20 11:38 AM, Kevin Traynor wrote: > On 20/10/2020 10:11, Maxime Coquelin wrote: >> >> >> On 10/20/20 11:01 AM, Kevin Traynor wrote: >>> On 20/10/2020 08:16, Adrian Moreno wrote: If stat fails it means the backend must be vhost-user in server mode Bugzilla ID: 559 Fix

Re: [dpdk-dev] [PATCH v5 6/8] devtools/test-null: load all drivers from directory

2020-10-20 Thread Thomas Monjalon
20/10/2020 10:37, Bruce Richardson: > On Mon, Oct 19, 2020 at 06:58:32PM +0200, Thomas Monjalon wrote: > > 15/10/2020 17:05, Bruce Richardson: > > > Rather than specifying specific drivers in the driver directory to load, > > > we > > > can just pass in the whole driver directory to the "-d" EAL f

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-20 Thread Ferruh Yigit
On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd dri

[dpdk-dev] [PATCH v2 0/2] net/ixgbe fix unchecked return value and rte_panic

2020-10-20 Thread Conor Walsh
This patchset resolves a coverity issue where the return value of rte_eth_switch_domain_alloc() was not being checked and also removes a use of rte_panic within ixgbe_pf_host_init(). --- v2: eth_dev->data->mac_addrs and eth_dev->data->hash_mac_addrs will now be free'd if ixgbe_pf_host_init() fail

[dpdk-dev] [PATCH v2 2/2] net/ixgbe: remove rte_panic

2020-10-20 Thread Conor Walsh
Remove the usage of rte_panic() within ixgbe_pf_host_init() Signed-off-by: Conor Walsh --- drivers/net/ixgbe/ixgbe_pf.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index 4e25b1e72e..833863af5a 100644 --- a

[dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value

2020-10-20 Thread Conor Walsh
The return value of rte_eth_switch_domain_alloc() was not being checked within ixgbe_pf_host_init() which caused a coverity issue. If the call fails a warning is logged using PMD_INIT_LOG() and *vfinfo is free'd. ixgbe_pf_host_init() now has a return value which is checked in eth_ixgbe_dev_init()

Re: [dpdk-dev] [PATCH] config: fix kni build

2020-10-20 Thread David Marchand
On Tue, Oct 20, 2020 at 11:19 AM Bruce Richardson wrote: > > When building kernel modules such as kni, the "config" directory is not > passed as a standard path in the EXTRA_CFLAGS value, meaning that the > rte_compatibility_defines.h is not found from rte_config.h. However, since > both headers a

Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants

2020-10-20 Thread Thomas Monjalon
20/10/2020 10:34, Bruce Richardson: > On Mon, Oct 19, 2020 at 11:04:54PM +0200, Thomas Monjalon wrote: > > 19/10/2020 12:21, Bruce Richardson: > > > On Fri, Oct 16, 2020 at 06:46:12PM +0200, David Marchand wrote: > > > > On Fri, Oct 16, 2020 at 5:56 PM Bruce Richardson > > > > wrote: > > > > > > l

Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants

2020-10-20 Thread Bruce Richardson
On Tue, Oct 20, 2020 at 12:04:56PM +0200, Thomas Monjalon wrote: > 20/10/2020 10:34, Bruce Richardson: > > On Mon, Oct 19, 2020 at 11:04:54PM +0200, Thomas Monjalon wrote: > > > 19/10/2020 12:21, Bruce Richardson: > > > > On Fri, Oct 16, 2020 at 06:46:12PM +0200, David Marchand wrote: > > > > > On

Re: [dpdk-dev] [PATCH] net/ice/base: fix a refactor error

2020-10-20 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Tuesday, October 20, 2020 4:47 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Allan, Bruce W ; Su, Simei > > Subject: [PATCH] net/ice/base: fix a refactor error > > This patch corrects an upper limit value in for loop. > > Fixe

Re: [dpdk-dev] [PATCH v7 03/20] eal: rename lcore word choices

2020-10-20 Thread Thomas Monjalon
16/10/2020 00:57, Stephen Hemminger: > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > - rte_get_master_lcore; > + rte_get_main_lcore; The .def must be updated as well. I will fix while merging.

Re: [dpdk-dev] [PATCH v7 00/20] Replace terms master/slave

2020-10-20 Thread Thomas Monjalon
16/10/2020 00:57, Stephen Hemminger: > As announced in 20.08 release notes, the terms for lcore role > will change in 20.11 release. > > This is a project wide patchset to terminolgy used for DPDK lcore. > The term "master" referring to lcore is replaced with "main" and > "slave" lcore is replaced

Re: [dpdk-dev] [PATCH] net/ice: fix SCTP RSS configuration

2020-10-20 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Junyu Jiang > Sent: Tuesday, October 20, 2020 4:51 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Su, Simei ; > Jiang, JunyuX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ice: fix SCTP RSS configuration > > This patch configured RSS for

Re: [dpdk-dev] [PATCH v2] net/iavf: fix unchecked Tx cleanup error

2020-10-20 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Monday, October 19, 2020 1:43 PM > To: Zhang, Qi Z ; Yigit, Ferruh > Cc: dev@dpdk.org; Rong, Leyi ; sta...@dpdk.org > Subject: [PATCH v2] net/iavf: fix unchecked Tx cleanup error > > Coverity complains of unchecked return value warning o

Re: [dpdk-dev] [PATCH] config: fix kni build

2020-10-20 Thread David Marchand
On Tue, Oct 20, 2020 at 12:03 PM David Marchand wrote: > > On Tue, Oct 20, 2020 at 11:19 AM Bruce Richardson > wrote: > > > > When building kernel modules such as kni, the "config" directory is not > > passed as a standard path in the EXTRA_CFLAGS value, meaning that the > > rte_compatibility_def

Re: [dpdk-dev] [PATCH] virtio-user: fix backend selection if stat fails

2020-10-20 Thread Adrian Moreno
On 10/20/20 11:55 AM, Maxime Coquelin wrote: > > > On 10/20/20 11:38 AM, Kevin Traynor wrote: >> On 20/10/2020 10:11, Maxime Coquelin wrote: >>> >>> >>> On 10/20/20 11:01 AM, Kevin Traynor wrote: On 20/10/2020 08:16, Adrian Moreno wrote: > If stat fails it means the backend must be vh

Re: [dpdk-dev] [PATCH 14/14] ethdev: remove legacy filter API functions

2020-10-20 Thread David Marchand
On Sun, Oct 18, 2020 at 4:14 PM Andrew Rybchenko wrote: > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index 18a748bc88..42eafb97af 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -106,12 +106,6

Re: [dpdk-dev] [PATCH 13/14] app/testpmd: remove flow_director_flex_mask command

2020-10-20 Thread David Marchand
On Sun, Oct 18, 2020 at 4:14 PM Andrew Rybchenko wrote: > > The command uses FDIR filter information get API which > is not supported any more. > > Signed-off-by: Andrew Rybchenko Build error on parse_flexbytes(): FAILED: app/a172ced@@dpdk-testpmd@exe/test-pmd_cmdline.c.o ccache clang -Iapp/a17

Re: [dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-20 Thread David Marchand
On Sun, Oct 18, 2020 at 4:10 PM Andrew Rybchenko wrote: > > RTE flow API should be used for filtering. - We still have some trace in testpmd documentation. $ git grep set.port.*vf.*mac doc/guides/testpmd_app_ug/testpmd_funcs.rst: testpmd> set port (port_id) vf (vf_id) (mac_addr) \ - Do we hav

[dpdk-dev] [PATCH v3 1/3] net/ice: add AVX512 vector path

2020-10-20 Thread Leyi Rong
Add AVX512 support for ice PMD. This patch adds ice_rxtx_vec_avx512.c to support ice AVX512 vPMD. This patch aims to enable AVX512 on ice vPMD. Main changes are focus on Rx path compared with AVX2 vPMD. Signed-off-by: Leyi Rong Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_rxtx.c

[dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on ice

2020-10-20 Thread Leyi Rong
This patchset aims to support AVX512 vPMD on ice. --- v3: - Code rebased. v2: - No internal judgement when RTE_MACHINE_CPUFLAG_AVX512F is set in meson.build. - Add RSS hash parsing as default RXDID is set to #22. - Use buf_iova instead of buf_physaddr, as buf_physaddr will be removed. Leyi Ron

[dpdk-dev] [PATCH v3 2/3] net/ice: add RSS hash parsing in AVX512 path

2020-10-20 Thread Leyi Rong
Support RSS hash parsing in AVX512 data path as the default RXDID is set to #22, that means the RSS hash field locates in the 2nd 16B of each Flex Rx descriptor. Signed-off-by: Leyi Rong --- drivers/net/ice/ice_rxtx_vec_avx512.c | 105 -- 1 file changed, 98 insertions(+),

[dpdk-dev] [PATCH v3 3/3] net/ice: optimize Tx path on AVX512 vPMD

2020-10-20 Thread Leyi Rong
Optimize Tx path by using AVX512 instructions and vectorize the tx free bufs process. Signed-off-by: Leyi Rong Signed-off-by: Bruce Richardson --- drivers/net/ice/ice_rxtx.h| 4 + drivers/net/ice/ice_rxtx_vec_avx512.c | 155 +- drivers/net/ice/ice_rxtx_vec_

Re: [dpdk-dev] [PATCH v2] examples/tep_term: deprecate this example

2020-10-20 Thread Ferruh Yigit
On 10/20/2020 7:11 AM, Xiaoyun Li wrote: This example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets. Usually, OVS is used to do the software encap/decap for VXLAN

[dpdk-dev] [PATCH v7 0/4] add async data path in vhost sample

2020-10-20 Thread Cheng Jiang
This patch set makes vhost-vswitch be able to use vhost async APIs for enqueue operations. Demonstrated how the application leverage IOAT DMA channel with vhost async APIs. We introduce two parameters to enable DMA acceleration for Tx operations of queues: -dma_type This parameter is used to speci

[dpdk-dev] [PATCH v7 1/4] example/vhost: add async vhost args parsing function

2020-10-20 Thread Cheng Jiang
This patch is to add async vhost driver arguments parsing function for CBDMA channel, DMA initiation function and args description. The meson build file is changed to fix dependency problem. With these arguments vhost device can be set to use CBDMA or CPU for enqueue operation and bind vhost device

[dpdk-dev] [PATCH v7 2/4] example/vhost: add support for vhost async data path

2020-10-20 Thread Cheng Jiang
This patch is to implement vhost DMA operation callbacks for CBDMA PMD and add vhost async data-path in vhost sample. With providing callback implementation for CBDMA, vswitch can leverage IOAT to accelerate vhost async data-path. Signed-off-by: Cheng Jiang --- examples/vhost/ioat.c | 100 ++

[dpdk-dev] [PATCH v7 4/4] doc: update release notes for vhost sample

2020-10-20 Thread Cheng Jiang
Add release notes for vhost async data path support in vhost sample. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_20_11.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst index f8686a50d..8

<    1   2   3   4   >