[dpdk-dev] [PATCH] baseband/acc100: remove logically dead code

2020-10-19 Thread Nicolas Chautru
Removing a few lines of dead code reported recently by coverity. The related code was not released yet hence does not required to be fixed on stable branch. Coverity issues: 363451, 363454, 363455 Nicolas Chautru (1): baseband/acc100: remove logically dead code drivers/baseband/acc100/rte_ac

Re: [dpdk-dev] [PATCH] eal: spelling fixes

2020-10-19 Thread Thomas Monjalon
16/10/2020 02:26, Stephen Hemminger: > Fixes spelling in comment and message about thread error. > Found while looking at checkpatch complaints about "thead" > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH] ethdev: rename tunnel offload callbacks

2020-10-19 Thread Thomas Monjalon
19/10/2020 11:56, Kinsella, Ray: > On 19/10/2020 09:31, Ferruh Yigit wrote: > > On 10/18/2020 1:15 PM, Gregory Etelson wrote: > >> rename new rte_flow ops callbacks to emphasize relation to tunnel > >> offload API. > >> > >> Signed-off-by: Gregory Etelson > >> Acked-by: Ori Kam > > > > +1 to ren

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-10-19 Thread Honnappa Nagarahalli
> > > > > Hi Abhinandan, > > > > > > > > > > > > > > > > > Hi Konstantin & Honnappa, > > > > > > > > > > > > Thanks for all the inputs and feedback. > > > > > > > > > > > > @Ananyev, Konstantin, > > > > > > I have measured the perf with and without callback on xeon. > > > > > > Here are the > > >

Re: [dpdk-dev] [PATCH v1] app/regex: fix segfault in getopt_long call

2020-10-19 Thread Thomas Monjalon
19/10/2020 10:39, Ophir Munk: > Adding Thomas Monjalon > Thomas - when merging can you please remove the line: Cc: sta...@dpdk.org ? No it should be kept because the bug is in a previous release.

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] app/regex: fix segfault in getopt_long call

2020-10-19 Thread Thomas Monjalon
> >> getopt_long() parses command-line arguments. One of its arguments > >> 'longopts' is a pointer to the first element of an array of struct > >> option. The last element of the array has to be filled with zeros > >> to mark the end of options. For example: > >> > >> struct option longopts[] = {

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

2020-10-19 Thread Ajit Khaparde
On Thu, Oct 8, 2020 at 2:43 AM Burakov, Anatoly wrote: > > On 08-Oct-20 10:40 AM, Hariprasad Govindharajan wrote: > > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > > There are use cases where this module is required, for example while > > testing the virtual ports in OvS,

Re: [dpdk-dev] [PATCH v3 0/8] eal: cleanup resources on shutdown

2020-10-19 Thread Thomas Monjalon
That's a pity this patchset is not concluded. Please Stephen, could you respin with a fix? 03/05/2020 19:21, David Marchand: > On Wed, Apr 29, 2020 at 1:58 AM Stephen Hemminger > wrote: > > > > Started using valgrind with DPDK, and there are lots of leftover > > memory and file descriptors. This

Re: [dpdk-dev] [PATCH 0/6] net/bnxt: bounds checking patches

2020-10-19 Thread Thomas Monjalon
Why there was no progress on this during 6 months? Ajit, it was out of my radar because delegated to you. Please restart fresh with a separate patch for EAL, addressing comments. Thanks 31/03/2020 20:04, Stephen Hemminger: > On Tue, 31 Mar 2020 10:52:47 -0700 > Ajit Khaparde wrote: > > > On T

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: handle removal of associated pci device

2020-10-19 Thread Thomas Monjalon
Gaetan, Matan, Please could you check? 25/09/2020 22:30, Long Li: > HI Matan, > > While troubleshooting a failure in DPDK on device removal when VF device > briefly disappears and comes back, I notice the failsafe driver is trying > repeatedly to start a sub device (after this sub device has b

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: handle removal of associated pci device

2020-10-19 Thread Thomas Monjalon
Fixing Gaetan's address 20/10/2020 00:33, Thomas Monjalon: > Gaetan, Matan, > Please could you check? > > > 25/09/2020 22:30, Long Li: > > HI Matan, > > > > While troubleshooting a failure in DPDK on device removal when VF device > > briefly disappears and comes back, I notice the failsafe dri

Re: [dpdk-dev] [PATCH v6 0/7] app/proc-info: enhancements

2020-10-19 Thread Thomas Monjalon
24/09/2020 07:34, Stephen Hemminger: > The current proc-info command is useful for diagnosing issues > with external DPDK applications, but the display is limited > and somewhat ugly. This patchset adds some enhancements which > show more info and suppress unnecessary stuff. > > Hemant Agrawal (1)

[dpdk-dev] [RFC] rcu: build on Windows

2020-10-19 Thread Dharmik Thakkar
Build the lib for Windows. Change-Id: Ib83431a9ee56a7b38445f0474cb9a12b17cf18f9 Signed-off-by: Dharmik Thakkar --- lib/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/meson.build b/lib/meson.build index dd55b5cb53e4..1bb019720c6a 100644 --- a/lib/meson.build +++ b/lib/meson.b

Re: [dpdk-dev] [PATCH 1/2] test/rcu: fix array subscript is above array bounds

2020-10-19 Thread Lukasz Wojciechowski
Hi Honnappa, I verified building and testing and all the warnings/errors disappear for RTE_MAX_LCORE >= 2 and tests pass. I wonder, if it is possible to set RTE_MAX_LCORE = 1 ? In such case there are still few places with array bounds exceedings: Compiling C object 'app/test/3062f5d@@dpdk-test@e

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: Prevent alarm lost on failed device probe

2020-10-19 Thread Long Li
> Subject: RE: [PATCH] net/vdev_netvsc: Prevent alarm lost on failed device > probe > > > > From: Long Li > > If a device probe fails, the alarm is canceled and will no longer work > > for previously probed devices. > > > > Fix this by introducing a flag to track if alarm has been set. Because >

Re: [dpdk-dev] [PATCH] gso: fix free issue of mbuf gso segments attach to

2020-10-19 Thread yang_y_yi
At 2020-10-19 16:47:55, "Ananyev, Konstantin" wrote: > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 19, 2020 9:44 AM > To: Ananyev, Konstantin > Subject: FW: Re:RE: Re:RE: [PATCH] gso: fix free issue of mbuf gso segments > attach to > > > > From: yang

Re: [dpdk-dev] [PATCH v3 3/8] net/virtio: move backend type selection to ethdev

2020-10-19 Thread Wang, Yinan
Hi Adrian/Maxime, Could you help to take a look at this issue? Most of automated regression cases will be blocked due to this issue in 20.11 RC1 test. Thanks in advance! BR, Yinan > -Original Message- > From: Wang, Yinan > Sent: 2020?10?16? 13:42 > To: Maxime Coquelin ; dev@dpdk.org; Xi

Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics

2020-10-19 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 20, 2020 5:13 AM > To: Ruifeng Wang ; Honnappa Nagarahalli > > Cc: dev@dpdk.org; Liang Ma ; Jan Viktorin > ; David Christensen ; > Bruce Richardson ; Konstantin Ananyev > ; david.h...@intel.com; > jerinjac...@gmail.co

[dpdk-dev] [PATCH] bonding: fix xmit balance policy name

2020-10-19 Thread Min Hu (Connor)
Currently there exits inconsistence about name of transmission policy for a Link Bonding device. "xmit_balance_policy" is not corrent, which should be modified to "balance_xmit_policy". Fixes: 2950a769315e ("bond: testpmd support") Fixes: ac718398f477 ("doc: testpmd application user guide") Cc: st

[dpdk-dev] [PATCH v2 0/8] net/mlx5: make counter thread safe

2020-10-19 Thread Suanming Mou
The mlx5 PMD is going to support multiple-thread flow operations. This patchset makes the counter action to be thread safe. Suanming Mou (8): net/mlx5: locate aging pools in the general container net/mlx5: optimize shared counter memory net/mlx5: remove single counter container net/mlx5: s

[dpdk-dev] [PATCH v2 5/8] net/mlx5: make three level table thread safe

2020-10-19 Thread Suanming Mou
This commit adds thread safety support in three level table using spinlock and reference counter for each table entry. An new mlx5_l3t_prepare_entry() function is added in order to support multiple-thread operation. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_ut

[dpdk-dev] [PATCH v2 2/8] net/mlx5: optimize shared counter memory

2020-10-19 Thread Suanming Mou
Instead of using special memory to indicate shared counter, this patch does the optimization to use the counter handler reserved memory to indicate it. The counter index with MLX5_CNT_SHARED_OFFSET means the shared counter. This patch is also an arrangement for a new adjustment to use batch counte

[dpdk-dev] [PATCH v2 1/8] net/mlx5: locate aging pools in the general container

2020-10-19 Thread Suanming Mou
Commit [1] introduced different container for the aging counter pools. In order to save container memory the aging counter pools can be located in the general pool container. This patch locates the aging counter pools in the general pool container. Remove the aging container management. [1] commi

[dpdk-dev] [PATCH v2 3/8] net/mlx5: remove single counter container

2020-10-19 Thread Suanming Mou
A flow counter which was allocated by a batch API couldn't be assigned to a flow in the root table (group 0) in old rdma-core version. Hence, a root table flow counter required PMD mechanism to manage counters which were allocated singly. Currently, the batch counters have already been supported i

[dpdk-dev] [PATCH v2 4/8] net/mlx5: synchronize flow counter pool creation

2020-10-19 Thread Suanming Mou
Currently, counter operations are not thread safe as the counter pools' array resize is not protected. This commit protects the container pools' array resize using a spinlock. The original counter pool statistic memory allocate is moved to the host thread in order to minimize the critical section.

[dpdk-dev] [PATCH v2 6/8] net/mlx5: make shared counters thread safe

2020-10-19 Thread Suanming Mou
The shared counters save the counter index to three level table. As three level table supports multiple-thread opertations now, the shared counters can take advantage of the table to support multiple-thread. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v2 8/8] net/mlx5: optimize counter extend memory

2020-10-19 Thread Suanming Mou
Counter extend memory was allocated for non-batch counter to save the extra DevX object. Currently, for non-batch counter which does not support aging, entry in the generic counter struct is used only when counter is free in free list, and bytes in the struct is used only when counter is allocated

[dpdk-dev] [PATCH v2 7/8] net/mlx5: rename flow counter macro

2020-10-19 Thread Suanming Mou
Add the MLX5_ prefix to the defined counter macro names. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h| 22 +++--- drivers/net/mlx5/mlx5_flow_dv.c| 10 +- drivers/net/mlx5/mlx5_flow_verbs.c | 2 +- 3 files changed, 17 inse

[dpdk-dev] [PATCH V2] bonding: fix xmit balance policy name

2020-10-19 Thread Min Hu (Connor)
Currently there exits inconsistence about name of transmission policy for a Link Bonding device. "xmit_balance_policy" is not correct, which should be modified to "balance_xmit_policy". Fixes: 2950a769315e ("bond: testpmd support") Fixes: ac718398f477 ("doc: testpmd application user guide") Cc: st

Re: [dpdk-dev] [PATCH v4 0/3] hash: integrate RCU QSBR

2020-10-19 Thread Dharmik Thakkar
> On Oct 19, 2020, at 4:05 PM, David Marchand wrote: > > On Mon, Oct 19, 2020 at 6:37 PM Dharmik Thakkar > wrote: >> >> Integrate RCU QSBR to make it easier for the applications to use lock >> free algorithm. >> >> Resource reclamation implementation was split from the original >> series, a

Re: [dpdk-dev] [PATCH] examples/tep_term: deprecate this example

2020-10-19 Thread Li, Xiaoyun
Hi > -Original Message- > From: Ferruh Yigit > Sent: Monday, October 19, 2020 17:14 > To: Li, Xiaoyun ; dev@dpdk.org > Cc: arybche...@solarflare.com; techbo...@dpdk.org > Subject: Re: [PATCH] examples/tep_term: deprecate this example > > On 10/19/2020 9:27 AM, Xiaoyun Li wrote: > > The t

Re: [dpdk-dev] [PATCH] net/vdev_netvsc: Prevent alarm lost on failed device probe

2020-10-19 Thread Matan Azrad
From: Long Li > > Subject: RE: [PATCH] net/vdev_netvsc: Prevent alarm lost on failed > > device probe > > > > > > > > From: Long Li > > > If a device probe fails, the alarm is canceled and will no longer > > > work for previously probed devices. > > > > > > Fix this by introducing a flag to trac

Re: [dpdk-dev] [PATCH v1] app/regex: change default qp configuration flags

2020-10-19 Thread Ori Kam
> -Original Message- > From: Guy Kaneti > Sent: Monday, October 19, 2020 8:12 PM > Subject: RE: [PATCH v1] app/regex: change default qp configuration flags > > Hi Ori, > > > > -Original Message- > > From: Ori Kam > > Sent: Monday, October 19, 2020 6:03 PM > > Subject: [EXT]

[dpdk-dev] [PATCH v2] examples/tep_term: deprecate this example

2020-10-19 Thread Xiaoyun Li
This example sets up a scenario that VXLAN packets can be received by different PF queues based on VNID and each queue is bound to a VM with a VNID so that the VM can receive its inner packets. Usually, OVS is used to do the software encap/decap for VXLAN packets. And the VXLAN packets offloading

<    1   2   3