Re: [dpdk-dev] [PATCH] net/bnxt: add support for 200G PAM4 link

2020-09-25 Thread Ajit Khaparde
On Thu, Sep 24, 2020 at 4:53 PM Ajit Khaparde wrote: > > Thor based NICs can support PAM4 as wells as NRZ link negotiation. > With this patch we are adding support for 200G link speeds based on > PAM4 signaling. While PAM4 can negotiate speeds for 50G and 100G as > well, the PMD will use NRZ signa

Re: [dpdk-dev] [PATCH] net/bnx2x: enhance old ethdev close behavior

2020-09-25 Thread Thomas Monjalon
25/09/2020 06:17, Rasesh Mody: > Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources > for the port can be freed by rte_eth_dev_close(). With this change the > private port resources are released in the .dev_close callback. > > Signed-off-by: Rasesh Mody > --- > static int eth_b

[dpdk-dev] [PATCH v2 3/3] test/event_crypto_adapter: free resources during exit

2020-09-25 Thread Ankur Dwivedi
The resources held by crypto adapter should be freed when the test suite exits. Signed-off-by: Ankur Dwivedi --- app/test/test_event_crypto_adapter.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c

[dpdk-dev] [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments

2020-09-25 Thread Ankur Dwivedi
The arguments passed to rte_event_crypto_adapter_caps_get() and rte_event_crypto_adapter_create() are incorrect. In the rte_event_crypto_adapter_caps_get(), event device id should be the first argument and cryptodev id should be the second argument. In the rte_event_crypto_adapter_create(), the ev

[dpdk-dev] [PATCH v2 0/3] Bug fixes in event crypto adapter test application

2020-09-25 Thread Ankur Dwivedi
This patch series resolves bugs in the event crypto adapter test application. v2: * In the "test/event_crypto_adapter: return error with unsupported mode" patch the following changes were done: - Skip mismatch of mode and capability for software eventdev. - In test_crypto_adapter_conf_op_new

[dpdk-dev] [PATCH v2 1/3] test/event_crypto_adapter: return error with unsupported mode

2020-09-25 Thread Ankur Dwivedi
The capability of a hardware event device should be checked before creating a event crypto adapter in a particular mode. The test case returns error if the mode is not supported. Signed-off-by: Ankur Dwivedi --- app/test/test_event_crypto_adapter.c | 33 +++- 1 file chang

Re: [dpdk-dev] Meson Minimum Version

2020-09-25 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, September 24, 2020 5:43 PM > > On Thu, Sep 24, 2020 at 03:32:41PM +, John Alexander wrote: > >Hi, > >Regarding the subproject local patch support, yes, it's only > supported > >since Meson 0.5

Re: [dpdk-dev] [dpdk-dev v10 2/4] cryptodev: add raw crypto data-path APIs

2020-09-25 Thread Dybkowski, AdamX
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, 24 September, 2020 18:34 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Dybkowski, AdamX > ; ano...@marvell.com; Ananyev, Konstantin > ; Zhang, Roy Fan > ; Bronowski, PiotrX > > Subject: [d

Re: [dpdk-dev] [dpdk-dev v10 1/4] cryptodev: change crypto symmetric vector structure

2020-09-25 Thread Dybkowski, AdamX
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, 24 September, 2020 18:34 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Dybkowski, AdamX > ; ano...@marvell.com; Ananyev, Konstantin > ; Zhang, Roy Fan > > Subject: [dpdk-dev v10 1/4] crypt

Re: [dpdk-dev] [dpdk-dev v10 4/4] test/crypto: add unit-test for cryptodev raw API test

2020-09-25 Thread Dybkowski, AdamX
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, 24 September, 2020 18:34 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Dybkowski, AdamX > ; ano...@marvell.com; Ananyev, Konstantin > ; Zhang, Roy Fan > > Subject: [dpdk-dev v10 4/4] test/

Re: [dpdk-dev] [dpdk-dev v10 3/4] crypto/qat: add raw crypto data-path API support

2020-09-25 Thread Dybkowski, AdamX
> -Original Message- > From: Zhang, Roy Fan > Sent: Thursday, 24 September, 2020 18:34 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; Dybkowski, AdamX > ; ano...@marvell.com; Ananyev, Konstantin > ; Zhang, Roy Fan > > Subject: [dpdk-dev v10 3/4] crypt

Re: [dpdk-dev] Meson Minimum Version

2020-09-25 Thread Bruce Richardson
On Fri, Sep 25, 2020 at 09:31:53AM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, September 24, 2020 5:43 PM > > > > On Thu, Sep 24, 2020 at 03:32:41PM +, John Alexander wrote: > > >Hi, > > >Regarding the subpro

[dpdk-dev] [PATCH V13 0/3] add FEC support

2020-09-25 Thread Min Hu (Connor)
This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c | 223 +++ app/test-pmd/config.c| 91 app/test-pmd/testpmd.h

[dpdk-dev] [PATCH V13 1/3] ethdev: introduce FEC API

2020-09-25 Thread Min Hu (Connor)
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang --- v12->v13: change fec get capa API

[dpdk-dev] [PATCH V13 3/3] app/testpmd: add FEC command

2020-09-25 Thread Min Hu (Connor)
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port 0

[dpdk-dev] [PATCH V13 2/3] net/hns3: support FEC

2020-09-25 Thread Min Hu (Connor)
Forward error correction (FEC) is a bit error correction mode. It adds error correction information to data packets at the transmit end, and uses the error correction information to correct the bit errors generated during data packet transmission at the receive end. This improves signal quality but

Re: [dpdk-dev] [PATCH 5/8] net/bnxt: add a null ptr check in bnxt PCI probe

2020-09-25 Thread Ferruh Yigit
On 9/25/2020 3:04 AM, Somnath Kotur wrote: On Thu, Sep 24, 2020 at 8:17 PM Ferruh Yigit wrote: On 9/22/2020 8:06 AM, Somnath Kotur wrote: Check for devargs before invoking rep port probe. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Somnath Kotur Revi

Re: [dpdk-dev] [EXT] Re: [RFC PATCH] app/testpmd: tx pkt clones parameter in flowgen

2020-09-25 Thread Igor Russkikh
>> +} else { >> +nb_clones--; >> +} >> +pkts_burst[nb_pkt] = pkt; >> >> next_flow = (next_flow + 1) % cfg_n_flows; >> } > > > This doesn't look safe. You can't just send same mbuf N times without > incrementing > the re

Re: [dpdk-dev] [PATCH V12 1/4] ethdev: introduce FEC API

2020-09-25 Thread Min Hu (Connor)
HI,Andrew, I fix it in V13 according to your advice. Thanks for your patient review. Please check it out again. By the way, there is always a coding check warning, like this: WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment #264: FILE: drivers/net/hns3/

Re: [dpdk-dev] [PATCH 10/20] net/null: release port upon close

2020-09-25 Thread Ferruh Yigit
On 9/24/2020 10:58 PM, Thomas Monjalon wrote: 23/09/2020 22:47, Thomas Monjalon: 23/09/2020 18:44, Ferruh Yigit: On 9/13/2020 11:07 PM, Thomas Monjalon wrote: The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources can be freed by rte_eth_dev_close(). Signed-off-by: Thomas Monjalon --

Re: [dpdk-dev] Meson Minimum Version

2020-09-25 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, September 25, 2020 10:41 AM > To: Morten Brørup > > On Fri, Sep 25, 2020 at 09:31:53AM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > Richardson > > > Sent: Thurs

Re: [dpdk-dev] [PATCH V2 1/4] ethdev: fix compiling errors for per-queue statistics

2020-09-25 Thread Min Hu (Connor)
Hi, Ferruh Yigit, Your method is very practical. Thanks! But we found that testpmd fails to start with "--rx-queue-stats-mapping" and "--tx-queue-stats-mapping". We've found the cause and modified it. These modifications are being tested. Currently, the following modifications are related to

[dpdk-dev] [RFC PATCH v2] app/testpmd: tx pkt clones parameter in flowgen

2020-09-25 Thread Igor Russkikh
When testing high performance numbers, it is often that CPU performance limits the max values device can reach (both in pps and in gbps) Here instead of recreating each packet separately, we use clones counter to resend the same mbuf to the line multiple times. PMDs handle that transparently due

Re: [dpdk-dev] [PATCH] build: support i686 target on x86 64-bit hosts

2020-09-25 Thread Bruce Richardson
On Thu, Sep 24, 2020 at 12:37:42PM -0400, Lance Richardson wrote: > Add meson cross files for building i686 targets using gcc on x86_64 > linux hosts. > > Uusage example: > > meson --cross-file config/x86/cross-i686-linux-gcc build-i686 > ninja -C build-i686 > > Signed-off-by: Lance Rich

Re: [dpdk-dev] [PATCH v1 1/3] lib/mirror: introduce traffic mirror API

2020-09-25 Thread MEHAN, MUNISH
Acked-by: MEHAN, MUNISH On 9/8/20, 8:28 PM, "Patrick Fu" wrote: Network Test Access Point (TAP) is the network monitoring service commonly adotpted in SDN-based network infrastructures. When VMs are inter-connected over virtual switches, TAP requires vSwitch to mirror out netw

Re: [dpdk-dev] [PATCH] app/test-flow-perf: configurable rule batches

2020-09-25 Thread Wisam Monther
Hi Georgios, >-Original Message- >From: george@gmail.com On Behalf Of Georgios >Katsikas >Sent: Tuesday, September 8, 2020 9:13 AM >To: wis...@mellanox.com >Cc: dev@dpdk.org; Georgios Katsikas >Subject: [PATCH] app/test-flow-perf: configurable rule batches Please use 'app/flow-perf'

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

2020-09-25 Thread Wisam Monther
Hi, >-Original Message- >From: george@gmail.com On Behalf Of Georgios >Katsikas >Sent: Thursday, September 24, 2020 12:11 PM >To: wis...@mellanox.com >Cc: dev@dpdk.org; Georgios Katsikas >Subject: [PATCH] app/flow-perf: configurable rule batches > >* One can now configure the number

Re: [dpdk-dev] [PATCH v3 0/4] Remove RTE_MACHINE_CPUFLAG_ macros

2020-09-25 Thread David Marchand
On Thu, Sep 24, 2020 at 10:19 AM Radu Nicolau wrote: > > Remove RTE_MACHINE_CPUFLAG_ macros from the build. > Deprecation notice sent, pasted here for reference: > > * build macros: The macros defining RTE_MACHINE_CPUFLAG_* will be removed > from the build. The information provided by these macr

Re: [dpdk-dev] Meson Minimum Version

2020-09-25 Thread Dmitry Kozlyuk
On Fri, 25 Sep 2020 09:41:22 +0100, Bruce Richardson wrote: > On Fri, Sep 25, 2020 at 09:31:53AM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson [snip] > > In short, my primary concern is: What could realistically go wrong if the > > required

Re: [dpdk-dev] Meson Minimum Version

2020-09-25 Thread Bruce Richardson
On Fri, Sep 25, 2020 at 12:19:33PM +0300, Dmitry Kozlyuk wrote: > On Fri, 25 Sep 2020 09:41:22 +0100, Bruce Richardson wrote: > > On Fri, Sep 25, 2020 at 09:31:53AM +0200, Morten Brørup wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > [snip] > > > In short, my

Re: [dpdk-dev] [PATCH V2 1/4] ethdev: fix compiling errors for per-queue statistics

2020-09-25 Thread Ferruh Yigit
On 9/25/2020 9:58 AM, Min Hu (Connor) wrote: Hi, Ferruh Yigit, Your method is very practical. Thanks! But we found that testpmd fails to start with "--rx-queue-stats-mapping" and "--tx-queue-stats-mapping". We've found the cause and modified it. These modifications are being tested. Currentl

Re: [dpdk-dev] [PATCH V3 0/4] change data type in TC queue

2020-09-25 Thread Ferruh Yigit
On 9/23/2020 1:59 PM, Min Hu (Connor) wrote: From: Huisong Li This series change data type in TC rxq and TC txq, fix compiling errors for per-queue statistics. Huisong Li (4): dpdk: fix compiling errors for per-queue statistics ethdev: change data type in TC rxq and TC txq doc:

[dpdk-dev] [PATCH v3] net/af_xdp: custom XDP program loading

2020-09-25 Thread Ciara Loftus
The new 'xdp_prog=' vdev arg allows the user to specify the path to a custom XDP program to be set on the device, instead of the default libbpf one. The program must have an XSK_MAP of name 'xsks_map' which will allow for the redirection of some packets to userspace and thus the PMD, using some cri

Re: [dpdk-dev] [PATCH v1] event/sw: performance improvements

2020-09-25 Thread Bruce Richardson
On Thu, Sep 24, 2020 at 06:02:48PM +, Ananyev, Konstantin wrote: > > > > > > Add minimum burst throughout the scheduler pipeline and a flush counter. > Replace ring API calls with local single threaded implementation where > possible. > > Signed-off-by: Radu Nicolau mailto:radu.nico...@in

Re: [dpdk-dev] [PATCH 1/7] raw/dpaa2_qdma: change DPAA2 QDMA APIs to rawdev ops

2020-09-25 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH 0/7] raw/dpaa2_qdma: driver enhancement

2020-09-25 Thread Hemant Agrawal
Series- Acked-by: Hemant Agrawal On 9/7/2020 2:55 PM, Gagandeep Singh wrote: In this patchset, we have done some changes in dpaa2_qdma driver related to rawdev APIs, optimizations, scatter-gather support on TX, enqueue without wait. Gagandeep Singh (2): raw/dpaa2_qdma: change DPAA2 QDMA AP

[dpdk-dev] [PATCH v3 02/25] raw/ioat: fix missing close function

2020-09-25 Thread Bruce Richardson
From: Kevin Laatz When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a dev_close function for the device causing a segmentation fault when no close() function is implemented for a driver. This patch resolves the issue by adding a stub function ioat_dev_close(). Fixes: f687e84

[dpdk-dev] [PATCH v3 00/25] raw/ioat: enhancements and new hardware support

2020-09-25 Thread Bruce Richardson
This patchset adds some small enhancements, some rework and also support for new hardware to the ioat rawdev driver. Most rework and enhancements are largely self-explanatory from the individual patches. The new hardware support is for the Intel(R) DSA accelerator which will be present in future I

[dpdk-dev] [PATCH v3 01/25] doc/api: add ioat driver to index

2020-09-25 Thread Bruce Richardson
Add the ioat driver to the doxygen documentation. Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index

[dpdk-dev] [PATCH v3 03/25] raw/ioat: enable use from C++ code

2020-09-25 Thread Bruce Richardson
To allow the header file to be used from C++ code we need to ensure all typecasts are explicit, and include an 'extern "C"' guard. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/raw/ioat/rte_ioat_rawdev.h | 23 +-- 1 file changed, 17 insertions(+), 6 de

[dpdk-dev] [PATCH v3 04/25] raw/ioat: include extra info in error messages

2020-09-25 Thread Bruce Richardson
In case of any failures, include the function name and the line number of the error message in the message, to make tracking down the failure easier. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/raw/ioat/ioat_rawdev_test.c | 53 +++-- 1 file chang

[dpdk-dev] [PATCH v3 07/25] raw/ioat: rename functions to be operation-agnostic

2020-09-25 Thread Bruce Richardson
Since the hardware supported by the ioat driver is capable of operations other than just copies, we can rename the doorbell and completion-return functions to not have "copies" in their names. These functions are not copy-specific, and so would apply for other operations which may be added later to

[dpdk-dev] [PATCH v3 05/25] raw/ioat: add a flag to control copying handle parameters

2020-09-25 Thread Bruce Richardson
From: Cheng Jiang Add a flag which controls whether rte_ioat_enqueue_copy and rte_ioat_completed_copies function should process handle parameters. Not doing so can improve the performance when handle parameters are not necessary. Signed-off-by: Cheng Jiang Signed-off-by: Bruce Richardson Revie

[dpdk-dev] [PATCH v3 06/25] raw/ioat: split header for readability

2020-09-25 Thread Bruce Richardson
Rather than having a single long complicated header file for general use we can split things so that there is one header with all the publicly needed information - data structs and function prototypes - while the rest of the internal details are put separately. This makes it easier to read, underst

[dpdk-dev] [PATCH v3 10/25] usertools/dpdk-devbind.py: add support for DSA HW

2020-09-25 Thread Bruce Richardson
From: Kevin Laatz Intel Data Streaming Accelerator (Intel DSA) is a high-performance data copy and transformation accelerator which will be integrated in future Intel processors [1]. Add DSA device support to dpdk-devbind.py script. [1] https://01.org/blogs/2019/introducing-intel-data-streaming

[dpdk-dev] [PATCH v3 12/25] raw/ioat: add vdev probe for DSA/idxd devices

2020-09-25 Thread Bruce Richardson
From: Kevin Laatz The Intel DSA devices can be exposed to userspace via kernel driver, so can be used without having to bind them to vfio/uio. Therefore we add support for using those kernel-configured devices as vdevs, taking as parameter the individual HW work queue to be used by the vdev. Sig

[dpdk-dev] [PATCH v3 09/25] raw/ioat: make the HW register spec private

2020-09-25 Thread Bruce Richardson
Only a few definitions from the hardware spec are actually used in the driver runtime, so we can copy over those few and make the rest of the spec a private header in the driver. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/raw/ioat/ioat_rawdev.c| 3 ++

[dpdk-dev] [PATCH v3 08/25] raw/ioat: add separate API for fence call

2020-09-25 Thread Bruce Richardson
Rather than having the fence signalled via a flag on a descriptor - which requires reading the docs to find out whether the flag needs to go on the last descriptor before, or the first descriptor after the fence - we can instead add a separate fence API call. This becomes unambiguous to use, since

[dpdk-dev] [PATCH v3 11/25] raw/ioat: add skeleton for VFIO/UIO based DSA device

2020-09-25 Thread Bruce Richardson
Add in the basic probe/remove skeleton code for DSA devices which are bound directly to vfio or uio driver. The kernel module for supporting these uses the "idxd" name, so that name is used as function and file prefix to avoid conflict with existing "ioat" prefixed functions. Since we are adding n

[dpdk-dev] [PATCH v3 13/25] raw/ioat: include example configuration script

2020-09-25 Thread Bruce Richardson
Devices managed by the idxd kernel driver must be configured for DPDK use before it can be used by the ioat driver. This example script serves both as a quick way to get the driver set up with a simple configuration, and as the basis for users to modify it and create their own configuration scripts

[dpdk-dev] [PATCH v3 17/25] raw/ioat: add configure function for idxd devices

2020-09-25 Thread Bruce Richardson
Add configure function for idxd devices, taking the same parameters as the existing configure function for ioat. The ring_size parameter is used to compute the maximum number of bursts to be supported by the driver, given that the hardware works on individual bursts of descriptors at a time. Signe

[dpdk-dev] [PATCH v3 14/25] raw/ioat: create rawdev instances on idxd PCI probe

2020-09-25 Thread Bruce Richardson
When a matching device is found via PCI probe create a rawdev instance for each queue on the hardware. Use empty self-test function for these devices so that the overall rawdev_autotest does not report failures. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/raw/ioat/idxd_

[dpdk-dev] [PATCH v3 15/25] raw/ioat: create rawdev instances for idxd vdevs

2020-09-25 Thread Bruce Richardson
From: Kevin Laatz For each vdev (DSA work queue) instance, create a rawdev instance. Signed-off-by: Kevin Laatz Signed-off-by: Bruce Richardson --- drivers/raw/ioat/idxd_vdev.c| 106 +++- drivers/raw/ioat/ioat_private.h | 4 ++ 2 files changed, 109 insertions

[dpdk-dev] [PATCH v3 16/25] raw/ioat: add datapath data structures for idxd devices

2020-09-25 Thread Bruce Richardson
Add in the relevant data structures for the data path for DSA devices. Also include a device dump function to output the status of each device. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/raw/ioat/idxd_pci.c| 1 + drivers/raw/ioat/idxd_vdev.c | 1

[dpdk-dev] [PATCH v3 18/25] raw/ioat: add start and stop functions for idxd devices

2020-09-25 Thread Bruce Richardson
Add the start and stop functions for DSA hardware devices using the vfio/uio kernel drivers. For vdevs using the idxd kernel driver, the device must be started using sysfs before the device node appears for vdev use - making start/stop functions in the driver unnecessary. Signed-off-by: Bruce Rich

[dpdk-dev] [PATCH v3 20/25] raw/ioat: add info function for idxd devices

2020-09-25 Thread Bruce Richardson
Add the info get function for DSA devices, returning just the ring size info about the device, same as is returned for existing IOAT/CBDMA devices. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/raw/ioat/idxd_pci.c | 1 + drivers/raw/ioat/idxd_vdev.c| 1 + driver

[dpdk-dev] [PATCH v3 21/25] raw/ioat: create separate statistics structure

2020-09-25 Thread Bruce Richardson
Rather than having the xstats as fields inside the main driver structure, create a separate structure type for them. As part of the change, when updating the stats functions referring to the stats by the old path, we can simplify them to use the id to directly index into the stats structure, makin

[dpdk-dev] [PATCH v3 22/25] raw/ioat: move xstats functions to common file

2020-09-25 Thread Bruce Richardson
The xstats functions can be used by all ioat devices so move them from the ioat_rawdev.c file to ioat_common.c, and add the function prototypes to the internal header file. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/raw/ioat/ioat_common.c | 59

[dpdk-dev] [PATCH v3 19/25] raw/ioat: add data path for idxd devices

2020-09-25 Thread Bruce Richardson
Add support for doing copies using DSA hardware. This is implemented by just switching on the device type field at the start of the inline functions. Since there is no hardware which will have both device types present this branch will always be predictable after the first call, meaning it has litt

[dpdk-dev] [PATCH v3 23/25] raw/ioat: add xstats tracking for idxd devices

2020-09-25 Thread Bruce Richardson
Add update of the relevant stats for the data path functions and point the overall device struct xstats function pointers to the existing ioat functions. At this point, all necessary hooks for supporting the existing unit tests are in place so call them for each device. Signed-off-by: Bruce Richa

[dpdk-dev] [PATCH v3 25/25] raw/ioat: add fill operation

2020-09-25 Thread Bruce Richardson
From: Kevin Laatz Add fill operation enqueue support for IOAT and IDXD. The fill enqueue is similar to the copy enqueue, but takes a 'pattern' rather than a source address to transfer to the destination address. This patch also includes an additional test case for the new operation type. Signed-

[dpdk-dev] [PATCH v3 24/25] raw/ioat: clean up use of common test function

2020-09-25 Thread Bruce Richardson
Now that all devices can pass the same set of unit tests, eliminate the temporary idxd_rawdev_test function and move the prototype for ioat_rawdev_test to the proper internal header file, to be used by all device instances. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/ra

Re: [dpdk-dev] [PATCH v3 02/25] raw/ioat: fix missing close function

2020-09-25 Thread Bruce Richardson
On Fri, Sep 25, 2020 at 12:08:47PM +0100, Bruce Richardson wrote: > From: Kevin Laatz > > When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a > dev_close function for the device causing a segmentation fault when no > close() function is implemented for a driver. > > This patc

Re: [dpdk-dev] [PATCH v3 02/25] raw/ioat: fix missing close function

2020-09-25 Thread Pai G, Sunil
> -Original Message- > From: Richardson, Bruce > Sent: Friday, September 25, 2020 4:39 PM > To: dev@dpdk.org > Cc: Fu, Patrick ; Laatz, Kevin ; > sta...@dpdk.org; Pai G, Sunil > Subject: [PATCH v3 02/25] raw/ioat: fix missing close function > > From: Kevin Laatz > > When rte_rawdev_pmd

[dpdk-dev] [PATCH] examples/vhost_blk: fix unchecked return value

2020-09-25 Thread wangyunjian
From: Yunjian Wang This checks the return value from the function rte_vhost_driver_start. Coverity issue: 362027 Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- examples/vhost_blk/vhost_blk.c | 6 +- 1 file cha

Re: [dpdk-dev] [PATCH] bus/pci: fix mapping BAR containing MSI-X table

2020-09-25 Thread Burakov, Anatoly
On 25-Sep-20 3:14 AM, Hyong Youb Kim wrote: When the BAR contains MSI-X table, pci_vfio_mmap_bar() tries to skip the table and map the rest. "map around it" is the phrase used in the source. The function splits the BAR into two regions: the region before the table (first part or memreg[0]) and th

[dpdk-dev] [PATCH v6 0/6] qede: SR-IOV PF driver support

2020-09-25 Thread Manish Chopra
Hi, This series adds SR-IOV PF pmd driver support to have VF pmd driver work over PF pmd driver instances in order to run the adapter completely under DPDK environment for one of the use cases like ovs-dpdk. This is very initial bring-up with following testing covered - * Enable/Disable SR-IOV V

[dpdk-dev] [PATCH v6 3/6] net/qede: configure VFs on hardware

2020-09-25 Thread Manish Chopra
Based on number of VFs enabled at PCI, PF-PMD driver instance enables/configures those VFs from hardware perspective, such that in later patches they could get required HW access to communicate with PFs for slowpath configuration and run the fastpath themsleves. This patch also add two new qede IO

[dpdk-dev] [PATCH v6 2/6] net/qede: define PCI config space specific osals

2020-09-25 Thread Manish Chopra
This patch defines various PCI config space access APIs in order to read and find IOV specific PCI capabilities. With these definitions implemented, it enables the base driver to do SR-IOV specific initialization and HW specific configuration required from PF-PMD driver instance. Signed-off-by: M

Re: [dpdk-dev] [PATCH v2] net/bnxt: add a check in bnxt PCI probe

2020-09-25 Thread Ferruh Yigit
On 9/25/2020 11:40 AM, Somnath Kotur wrote: Check for num_rep before invoking rep port probe. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Somnath Kotur Reviewed-by: Venkat Duvvuru Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

[dpdk-dev] [PATCH v6 1/6] drivers: add generic API to find PCI extended cap

2020-09-25 Thread Manish Chopra
By adding generic API, this patch removes individual functions/defines implemented by drivers to find extended PCI capabilities. Signed-off-by: Manish Chopra Signed-off-by: Igor Russkikh Reviewed-by: Gaetan Rivet --- drivers/bus/pci/pci_common.c | 43 ++ drivers/b

[dpdk-dev] [PATCH v6 4/6] net/qede: add infrastructure support for VF load

2020-09-25 Thread Manish Chopra
This patch adds necessary infrastructure support (required to handle messages from VF and sending ramrod on behalf of VF's configuration request from alarm handler context) to start/load the VF-PMD driver instance on top of PF-PMD driver instance. Signed-off-by: Manish Chopra Signed-off-by: Igor

[dpdk-dev] [PATCH v6 5/6] net/qede: initialize VF MAC and link

2020-09-25 Thread Manish Chopra
This patch configures VFs with random mac if no MAC is provided by the PF/bulletin. This also adds required bulletin APIs by PF-PMD driver to communicate LINK properties/changes to the VFs through bulletin update mechanism. With these changes, VF-PMD instance is able to run fastpath over PF-PMD dr

[dpdk-dev] [PATCH v6 6/6] net/qede: add VF FLR support

2020-09-25 Thread Manish Chopra
This patch adds required bit to handle VF FLR indication from Management FW (MFW) of the device With that VFs were able to load in VM (VF attached as PCI passthrough to the guest VM) followed by FLR successfully Updated the docs/guides with the feature support Signed-off-by: Manish Chopra Signe

[dpdk-dev] IPSEC-SECGW application

2020-09-25 Thread Rohit kamble
HI Guys , I am trying to use a DPDK based *ipsec-secgw application*. Can anyone please provide me with all the configurations, setup/topology and about the NIC drivers. I already went through the documentation of dpdk, but I am seeing several issues regarding ipsec-secgw applications. Thanks, Ro

[dpdk-dev] [PATCH v2 3/8] net/virtio: move backend type selection to ethdev

2020-09-25 Thread Maxime Coquelin
From: Adrian Moreno This is a preparation patch with no functional change. Use an enum instead of a boolean for the backend type. Move the detection logic to the ethdev layer (where it is needed for the first time). The virtio_user_dev stores the backend type in the virtio_user_dev struct so the

[dpdk-dev] [PATCH v2 2/8] net/virtio: introduce DMA ops

2020-09-25 Thread Maxime Coquelin
Add DMA map/unmap callbacks to the virtio_user pmd, which could be leveraged by vdev bus driver to map memory for backend devices with DMA capability. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost.h | 4 ++ drivers/net/virtio/virtio_user_ethdev.c | 54

[dpdk-dev] [PATCH v2 1/8] bus/vdev: add DMA mapping ops

2020-09-25 Thread Maxime Coquelin
Add DMA map/unmap operation callbacks to the vdev bus, which could be used by DMA capable vdev drivers. Signed-off-by: Maxime Coquelin --- drivers/bus/vdev/rte_bus_vdev.h | 46 +++-- drivers/bus/vdev/vdev.c | 52 + 2 files changed,

[dpdk-dev] [PATCH v2 0/8] virtio-user: introduce vhost-vdpa backend

2020-09-25 Thread Maxime Coquelin
vhost-vDPA is a new vhost backend type introduced by vDPA kernel framework, which provides abstruction to the vDPA devices and exposes to userspace a unified control interface through char devs. This patch set adds vhost-vdpa backend type to the virtio_user. A set of vhost-vdpa specific ops callba

[dpdk-dev] [PATCH v2 4/8] net/virtio: introduce Vhost-vDPA backend type

2020-09-25 Thread Maxime Coquelin
Backend type is determined by checking char-device major numbers Signed-off-by: Maxime Coquelin Signed-off-by: Adrian Moreno --- .../net/virtio/virtio_user/virtio_user_dev.h | 1 + drivers/net/virtio/virtio_user_ethdev.c | 48 +-- 2 files changed, 45 insertions(+), 4 del

Re: [dpdk-dev] [PATCH v3 0/8] fix distributor synchronization issues

2020-09-25 Thread David Marchand
Hello Lukasz, On Wed, Sep 23, 2020 at 3:25 PM Lukasz Wojciechowski wrote: > > During review and verification of the patch created by Sarosh Arif: > "test_distributor: prevent memory leakages from the pool" I found out > that running distributor unit tests multiple times in a row causes fails. > S

[dpdk-dev] [PATCH v2 5/8] net/virtio: check protocol feature in user backend

2020-09-25 Thread Maxime Coquelin
When sending set status message, move protocol feature check to vhost_user to be compatible with different backend types. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_user/vhost_user.c | 6 +- drivers/net/virtio/virtio_user/virtio_user_dev.c | 6 -- 2 files changed,

[dpdk-dev] [PATCH v2 8/8] net/virtio: introduce Vhost-vDPA backend

2020-09-25 Thread Maxime Coquelin
vhost-vDPA is a new virtio backend type introduced by vDPA kernel framework, which provides abstruction to the vDPA devices and exposes an unified control interface through a char dev. This patch adds support to the vhost-vDPA backend. As similar to the existing vhost kernel backend, a set of virt

[dpdk-dev] [PATCH v2 7/8] net/virtio: split virtio-user start

2020-09-25 Thread Maxime Coquelin
Move feature bit settings in device start out as an standalone function, so that feature bit could be negotiated at device feature_ok status. Signed-off-by: Maxime Coquelin --- .../net/virtio/virtio_user/virtio_user_dev.c | 50 --- .../net/virtio/virtio_user/virtio_user_dev.h |

[dpdk-dev] [PATCH v2 6/8] net/virtio: adapt Virtio-user status size

2020-09-25 Thread Maxime Coquelin
Set proper payload size for set/get status message. The payload size varies according to backend types. Signed-off-by: Maxime Coquelin Signed-off-by: Patrick Fu --- .../net/virtio/virtio_user/virtio_user_dev.c | 34 +-- 1 file changed, 23 insertions(+), 11 deletions(-) diff --

Re: [dpdk-dev] [PATCH] net/ring: fix unchecked return value

2020-09-25 Thread Ferruh Yigit
On 9/22/2020 6:20 PM, Kevin Laatz wrote: Add a check for the return value of the sscanf call in parse_internal_args(), returning an error if we don't get the expected result. Coverity issue: 362049 Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") Cc: sta...@dpdk.org Signed-off

[dpdk-dev] [PATCH v4 2/6] app/testpmd: fix VLAN offload configuration when config fail

2020-09-25 Thread Wei Hu (Xavier)
From: Chengchang Tang When failing to configure VLAN offloads after the port was started, there is no need to update the port configuration. Currently, when user configure an unsupported VLAN offloads and fails, and then restart the port, it will fails since the configuration has been refreshed.

[dpdk-dev] [PATCH v4 0/6] minor fixes for testpmd

2020-09-25 Thread Wei Hu (Xavier)
This series are minor fixes for testpmd application. Chengchang Tang (5): app/testpmd: fix missing verification of port id app/testpmd: fix VLAN offload configuration when config fail app/testpmd: remove restriction on txpkts set app/testpmd: fix packet header in txonly mode app/testpmd:

[dpdk-dev] [PATCH v4 1/6] app/testpmd: fix missing verification of port id

2020-09-25 Thread Wei Hu (Xavier)
From: Chengchang Tang To set Tx vlan offloads, it is required to stop port firstly. But before checking whether the port is stopped, the port id entered by the user is not checked for validity. When the port id is illegal, it would lead to a segmentation fault since it attempts to access a member

[dpdk-dev] [PATCH v4 4/6] app/testpmd: fix packet header in txonly mode

2020-09-25 Thread Wei Hu (Xavier)
From: Chengchang Tang In txonly forward mode, the packet header is fixed by the initial setting, including the packet length and checksum. So when the packets varies, this may cause a packet header error. Currently, there are two methods in txonly mode to randomly change the packets. 1. Set txspl

[dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on txpkts set

2020-09-25 Thread Wei Hu (Xavier)
From: Chengchang Tang Currently, if nb_txd is not set, the txpkts is not allowed to be set because the nb_txd is used to avoid the numer of segments exceed the Tx ring size and the default value of nb_txd is 0. And there is a bug that nb_txd is the global configuration for Tx ring size and the ri

[dpdk-dev] [PATCH v4 5/6] app/testpmd: fix valid desc id check

2020-09-25 Thread Wei Hu (Xavier)
From: Chengchang Tang The number of desc is a per queue configuration. But in the check function, nb_txd & nb_rxd are used to check whether the desc_id is valid. nb_txd & nb_rxd are the global configuration of number of desc. If the queue configuration is changed by cmdline liks: "port config xx

[dpdk-dev] [PATCH v4 6/6] app/testpmd: fix displaying Rx Tx queues information

2020-09-25 Thread Wei Hu (Xavier)
From: Huisong Li Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" and "ports[pid].tx_conf" maintained in testpmd application may be not the value actually used by PMD driver. For instance, user do

[dpdk-dev] [PATCH V4 1/2] dpdk: resolve compiling errors for per-queue stats

2020-09-25 Thread Min Hu (Connor)
From: Huisong Li Currently, only statistics of rx/tx queues with queue_id less than RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain application scenario that it needs to use 256 or more than 256 queues and display all statistics of rx/tx queue. At this moment, we have to chang

[dpdk-dev] [PATCH V4 2/2] ethdev: change data type in TC rxq and TC txq

2020-09-25 Thread Min Hu (Connor)
From: Huisong Li Currently, base and nb_queue in the tc_rxq and tc_txq information of queue and TC mapping on both TX and RX paths are uint8_t. However, these data will be truncated when queue number under a TC is greater than 256. So it is necessary for base and nb_queue to change from uint8_t t

[dpdk-dev] [PATCH V4 0/2] change data type in TC queue

2020-09-25 Thread Min Hu (Connor)
From: Huisong Li This series change data type in TC rxq and TC txq, fix compiling errors for per-queue statistics. Huisong Li (2): dpdk: resolve compiling errors for per-queue stats ethdev: change data type in TC rxq and TC txq app/proc-info/main.c | 2 +- app/test-pmd/cm

Re: [dpdk-dev] [PATCH 10/20] net/null: release port upon close

2020-09-25 Thread Thomas Monjalon
25/09/2020 10:52, Ferruh Yigit: > On 9/24/2020 10:58 PM, Thomas Monjalon wrote: > > 23/09/2020 22:47, Thomas Monjalon: > >> 23/09/2020 18:44, Ferruh Yigit: > >>> On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > can be freed b

Re: [dpdk-dev] [PATCH V4 0/2] change data type in TC queue

2020-09-25 Thread Ferruh Yigit
On 9/25/2020 1:51 PM, Min Hu (Connor) wrote: From: Huisong Li This series change data type in TC rxq and TC txq, fix compiling errors for per-queue statistics. Huisong Li (2): dpdk: resolve compiling errors for per-queue stats ethdev: change data type in TC rxq and TC txq app/proc-inf

Re: [dpdk-dev] [PATCH] build: support i686 target on x86 64-bit hosts

2020-09-25 Thread Bruce Richardson
On Fri, Sep 25, 2020 at 09:27:25AM -0400, Lance Richardson wrote: > On Fri, Sep 25, 2020 at 5:13 AM Bruce Richardson > wrote: > > > > On Thu, Sep 24, 2020 at 12:37:42PM -0400, Lance Richardson wrote: > > > Add meson cross files for building i686 targets using gcc on x86_64 > > > linux hosts. > > >

Re: [dpdk-dev] [PATCH v3 0/4] use C11 atomic builtins for libs

2020-09-25 Thread David Marchand
On Thu, Sep 24, 2020 at 7:40 AM Phil Yang wrote: > > Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic > builtins instead in eal, bbdev, power, and ethdev libs. > > [1] > http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst#L87 > [2] http://code.dpdk

  1   2   >