Re: [dpdk-dev] [V5 1/3] ethdev: introduce FEC API

2020-09-19 Thread Andrew Rybchenko
On 9/18/20 12:28 PM, Min Hu (Connor) wrote: 在 2020/9/17 17:58, Andrew Rybchenko 写道: On 9/17/20 11:52 AM, Min Hu (Connor) wrote: This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (

Re: [dpdk-dev] [PATCH V7 1/3] ethdev: introduce FEC API

2020-09-19 Thread Andrew Rybchenko
On 9/18/20 9:10 PM, Ajit Khaparde wrote: On Fri, Sep 18, 2020 at 5:13 AM Ananyev, Konstantin wrote: This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu

[dpdk-dev] [PATCH] eal: fix dereference before null check

2020-09-19 Thread wangyunjian
From: Yunjian Wang This patch fixes (dereference after null check) coverity issue. The intr_handle may be a null pointer which led to this issue. Coverity issue: 357695, 357751 Fixes: 05c4105738d8 ("trace: add interrupt tracepoints") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/lib

Re: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

2020-09-19 Thread wangyunjian
Friendly ping. > -Original Message- > From: wangyunjian > Sent: Wednesday, August 26, 2020 6:56 PM > To: dev@dpdk.org; hka...@marvell.com; david.march...@redhat.com > Cc: 'ferruh.yi...@intel.com' ; 'Thomas Monjalon' > ; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: RE: [dpdk-de

[dpdk-dev] [PATCH v3 2/6] app/testpmd: fix VLAN offload configuration when config fail

2020-09-19 Thread Wei Hu (Xavier)
From: Chengchang Tang When failing to configure VLAN offloads after the port was started, there is no need to update the port configuration. Currently, when user configure an unsupported VLAN offloads and fails, and then restart the port, it will fails since the configuration has been refreshed.

[dpdk-dev] [PATCH v3 0/6] minor fixes for testpmd

2020-09-19 Thread Wei Hu (Xavier)
This series are minor fixes for testpmd application. Chengchang Tang (5): app/testpmd: fix missing verification of port id app/testpmd: fix VLAN offload configuration when config fail app/testpmd: remove restriction on txpkts set app/testpmd: fix packet header in txonly mode app/testpmd:

[dpdk-dev] [PATCH v3 1/6] app/testpmd: fix missing verification of port id

2020-09-19 Thread Wei Hu (Xavier)
From: Chengchang Tang To set Tx vlan offloads, it is required to stop port firstly. But before checking whether the port is stopped, the port id entered by the user is not checked for validity. When the port id is illegal, it would lead to a segmentation fault since it attempts to access a member

[dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set

2020-09-19 Thread Wei Hu (Xavier)
From: Chengchang Tang Currently, if nb_txd is not set, the txpkts is not allowed to be set because the nb_txd is used to avoid the numer of segments exceed the Tx ring size and the default value of nb_txd is 0. And there is a bug that nb_txd is the global configuration for Tx ring size and the ri

[dpdk-dev] [PATCH v3 6/6] app/testpmd: fix displaying Rx Tx queues information

2020-09-19 Thread Wei Hu (Xavier)
From: Huisong Li Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" and "ports[pid].tx_conf" maintained in testpmd application may be not the value actually used by PMD driver. For instance, user do

[dpdk-dev] [PATCH v3 4/6] app/testpmd: fix packet header in txonly mode

2020-09-19 Thread Wei Hu (Xavier)
From: Chengchang Tang In txonly forward mode, the packet header is fixed by the initial setting, including the packet length and checksum. So when the packets varies, this may cause a packet header error. Currently, there are two methods in txonly mode to randomly change the packets. 1. Set txspl

[dpdk-dev] [PATCH v3 5/6] app/testpmd: fix valid desc id check

2020-09-19 Thread Wei Hu (Xavier)
From: Chengchang Tang The number of desc is a per queue configuration. But in the check function, nb_txd & nb_rxd are used to check whether the desc_id is valid. nb_txd & nb_rxd are the global configuration of number of desc. If the queue configuration is changed by cmdline liks: "port config xx

Re: [dpdk-dev] [V5 1/3] ethdev: introduce FEC API

2020-09-19 Thread Min Hu (Connor)
在 2020/9/19 16:42, Andrew Rybchenko 写道: On 9/18/20 12:28 PM, Min Hu (Connor) wrote: 在 2020/9/17 17:58, Andrew Rybchenko 写道: On 9/17/20 11:52 AM, Min Hu (Connor) wrote: This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC infor

Re: [dpdk-dev] [PATCH 1/2] config: add Graviton2(arm64) meson configuration

2020-09-19 Thread Ali Saidi
On 9/17/20 9:02 PM, Jerin Jacob wrote: > > On Thu, Sep 17, 2020 at 10:41 PM Honnappa Nagarahalli > wrote: >> >> >> > > On 9/11/20 8:23 PM, Honnappa Nagarahalli wrote: >> >> +Jerin, Hemant, Dharmik >> >> >> Hi Vimal, >> Few comments inline. >> >>>

Re: [dpdk-dev] [PATCH 1/2] config: add Graviton2(arm64) meson configuration

2020-09-19 Thread Honnappa Nagarahalli
> On 9/18/20, 12:42 PM, "Vimal Chungath" wrote: > > On 9/17/20 9:02 PM, Jerin Jacob wrote: > > > > On Thu, Sep 17, 2020 at 10:41 PM Honnappa Nagarahalli > > wrote: > >> > >> > >> > > > > On 9/11/20 8:23 PM, Honnappa Nagarahalli wrote: > >>

Re: [dpdk-dev] [PATCH 2/2] af_xdp: avoid to unnecessary allocation and free mbuf

2020-09-19 Thread Li,Rongqing
> -Original Message- > From: Loftus, Ciara [mailto:ciara.lof...@intel.com] > Sent: Friday, September 18, 2020 5:39 PM > To: Li,Rongqing > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/2] af_xdp: avoid to unnecessary allocation > and > free mbuf > > > > > optimize rx performance,