Re: [dpdk-dev] [PATCH] net/tap: release port upon close

2020-09-16 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, September 15, 2020 10:53 PM > To: wangyunjian ; dev@dpdk.org > Cc: tho...@monjalon.net; Lilijun (Jerry) ; xudingke > > Subject: Re: [dpdk-dev] [PATCH] net/tap: release port upon close > > On 8/28/20

Re: [dpdk-dev] 18.11.10 (LTS) patches review and test

2020-09-16 Thread Chen, BoX C
Hi Kevin, Update DPDK LTS 18.11.10 test result for Intel part. virtio test found a new bug. * Intel(R) Testing # Basic Intel(R) NIC testing * PF(i40e):Passed - Known issue: Exception message when starting testpmd with the '--mp-alloc=xmem' parameter. Patchset is provided by Burakov,

Re: [dpdk-dev] [PATCH 0/4] use C11 atomic builtins for libs

2020-09-16 Thread Phil Yang
David Marchand writes: > Subject: Re: [dpdk-dev] [PATCH 0/4] use C11 atomic builtins for libs > > On Fri, Sep 11, 2020 at 5:29 AM Phil Yang wrote: > > > > Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic > > builtins instead in eal, bbdev, power, and ethdev libs. > > > >

Re: [dpdk-dev] [PATCH v2] ci: add vm jobs for aarch64 builds with tests

2020-09-16 Thread Juraj Linkeš
> -Original Message- > From: Aaron Conole > Sent: Friday, September 11, 2020 3:25 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; david.march...@redhat.com; > maicolgabr...@hotmail.com; dev@dpdk.org > Subject: Re: [PATCH v2] ci: add vm jobs for aarch64 builds with tests > > Juraj Link

Re: [dpdk-dev] [PATCH v9 5/5] doc: add aarch32 build guidance

2020-09-16 Thread Juraj Linkeš
> -Original Message- > From: Aaron Conole > Sent: Friday, September 11, 2020 3:20 PM > To: Juraj Linkeš > Cc: tho...@monjalon.net; david.march...@redhat.com; > maicolgabr...@hotmail.com; dev@dpdk.org; Phil Yang > Subject: Re: [PATCH v9 5/5] doc: add aarch32 build guidance > > Juraj Li

[dpdk-dev] [PATCH 0/1] mbuf: minor cleanup

2020-09-16 Thread Morten Brørup
The mbuf header files had some commenting style errors that affected the API documentation. Also, the RTE_ prefix was missing on a macro and a definition. This cleanup was also discussed here: http://inbox.dpdk.org/dev/98cbd80474fa8b44bf855df32c47dc35c61...@smartserver.smartshare.dk/ Please note:

[dpdk-dev] [PATCH 1/1] mbuf: minor cleanup

2020-09-16 Thread Morten Brørup
The mbuf header files had some commenting style errors that affected the API documentation. Also, the RTE_ prefix was missing on a macro and a definition. Note: This patch does not touch the offload and attachment flags that are also missing the RTE_ prefix. Changes only affecting documentation:

[dpdk-dev] [PATCH v10 1/5] net/bnxt: add support for aarch32

2020-09-16 Thread Juraj Linkeš
From: Ruifeng Wang Expand vector PMD support to aarch32. Signed-off-by: Ruifeng Wang Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.h | 2 +- drivers/net/bnxt/bnxt_rxr.h | 2 +- drivers/net/bnxt/bnxt_txr.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/n

[dpdk-dev] [PATCH v10 0/5] aarch64 -> aarch32 cross compilation support

2020-09-16 Thread Juraj Linkeš
Add support for aarch32 cross build in meson and add aarch64 -> aarch32 cross build to Travis. Aarch32 is an execution state that allows execution of 32-bit code on armv8 machines. This execution state contains a superset of previous armv7 32-bit instructions and features. Thus the aarch32 build i

[dpdk-dev] [PATCH v10 2/5] build: add aarch32 meson build flags

2020-09-16 Thread Juraj Linkeš
Add aarch32 extra build flags and aarch32 machine flags to generic machine args. Also modify how arm flags are updated in meson build - for 32-bit build, update only if cross-compiling. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 20 ++-- 1 file changed, 18 insertion

[dpdk-dev] [PATCH v10 5/5] doc: add aarch32 build guidance

2020-09-16 Thread Juraj Linkeš
From: Phil Yang Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. Signed-off-by: Phil Yang --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 34 +-- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_a

[dpdk-dev] [PATCH v10 3/5] build: add aarch32 to meson cross-compilation

2020-09-16 Thread Juraj Linkeš
Create meson cross file arm32_armv8a_linux_gcc. Use arm-linux-gnueabihf- toolset which comes with standard packages on most used systems, such as Ubuntu and CentOS. Signed-off-by: Juraj Linkeš --- config/arm/arm32_armv8a_linux_gcc | 17 + 1 file changed, 17 insertions(+) create

[dpdk-dev] [PATCH v10 4/5] ci: add aarch64 -> aarch32 cross compiling jobs

2020-09-16 Thread Juraj Linkeš
Add two jobs (static and shared libs), both building on aarch64 and producing 32-bit arm binaries executable on armv8-a, but not armv7. Do not run tests in these jobs. Signed-off-by: Juraj Linkeš --- .ci/linux-build.sh | 7 ++- .travis.yml| 19 +++ 2 files changed, 2

[dpdk-dev] [PATCH v2 3/4] power: use C11 atomic builtins for power in use state update

2020-09-16 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins for power in use state update. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/librte_power/power_acpi_cpufreq.c | 45 + lib/librte_power/p

[dpdk-dev] [PATCH v2 2/4] bbdev: use C11 atomic builtins for device processing counter

2020-09-16 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins for device processing counter. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/librte_bbdev/rte_bbdev.c | 5 +++-- lib/librte_bbdev/rte_bbdev.h | 4 +--- 2 files changed, 4

[dpdk-dev] [PATCH v2 1/4] eal: use C11 atomic builtins for already initialized check

2020-09-16 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used, use C11 builtins to check if EAL is already initialized. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- lib/librte_eal/freebsd/eal.c | 18 ++ lib/librte_eal/linux/eal.c | 20

[dpdk-dev] [PATCH v2 0/4] use C11 atomic builtins for libs

2020-09-16 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic builtins instead in eal, bbdev, power, and ethdev libs. [1] http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst#L87 [2] http://code.dpdk.org/dpdk/latest/source/devtools/checkpatches.sh#L80 v2: Fix C

[dpdk-dev] [PATCH v2 4/4] ethdev: use C11 atomic builtins for link status update

2020-09-16 Thread Phil Yang
Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins for link status update. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- lib/librte_ethdev/rte_ethdev_driver.h | 19 +-- 1 file changed, 5 insertions(+), 14 delet

[dpdk-dev] [PATCH v2 02/25] net/bnxt: fix the drop action flow to support count

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Changed the action template to support count action in addition to a flow that does drop action. Fixes: fe82f3e02701 ("net/bnxt: support exact match templates") Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde Reviewed-by: Mike Baucom --- drivers/net/bnx

[dpdk-dev] [PATCH v2 03/25] net/bnxt: reject flow offload with invalid MAC

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Reject offload flows that have broadcast or multicast ethernet addresses. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 21 + 1 file changed, 21 insertions(+)

[dpdk-dev] [PATCH v2 01/25] net/bnxt: fix resource cleanup in port stop

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha The port deinitialization now cleans up all the resources properly. If all the ports are stopped then ULP context is freed. Added fix to update the correct tfp pointer in the ULP context with the changes to support multi control channels. Fixes: 70e64b27af5b42 ("net/bnxt

[dpdk-dev] [PATCH v2 00/25] patchset for bnxt

2020-09-16 Thread Ajit Khaparde
Some fixes and enhancements in the PMD and TruFlow layers. v1->v2: - rebased to latest - updated commit messages Kishore Padmanabha (14): net/bnxt: fix port stop process and cleanup resources net/bnxt: fix the drop action flow to support count net/bnxt: reject flow offload with invalid MA

[dpdk-dev] [PATCH v2 07/25] net/bnxt: add null pointer check for resource manager

2020-09-16 Thread Ajit Khaparde
From: Shahaji Bhosle Verify the resource manager has been allocated prior to using it. This can avoid potential segmentation faults. Signed-off-by: Shahaji Bhosle Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_rm.c | 14 ++ 1 file changed, 14

[dpdk-dev] [PATCH v2 06/25] net/bnxt: free the EM index on failure

2020-09-16 Thread Ajit Khaparde
From: Mike Baucom When a Exact Match entry fails insertion, the allocated index needs to be pushed back to the allocation stack. This patch takes care of that. Signed-off-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_em_internal.c | 5 - 1 file changed, 4 inse

[dpdk-dev] [PATCH v2 04/25] net/bnxt: reduce debug log messages

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Removed the mark id log message since it is in the data path. Also optimized the link status debug message. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 13 - drivers/ne

[dpdk-dev] [PATCH v2 10/25] net/bnxt: refactor VFR port clean up

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha When parent VF or PF ports are cleaned up, the child VF representor ports also need to be cleaned up. If not cleaned up, then deleting the parent VF shall result in not cleaning up the hardware rules and updating the firmware of VFR removal. The issue can occur even when

[dpdk-dev] [PATCH v2 08/25] net/bnxt: modify default flow rule creation

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Change default flow rule to use 8-byte encap. The VFR conduit uses VLAN encap to send packets. So the encap record is changed from 16B to 8B. That frees up 8B of encap records. Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --

[dpdk-dev] [PATCH v2 14/25] net/bnxt: use direct HWRM message for interface table

2020-09-16 Thread Ajit Khaparde
From: Randy Schacher Change interface tables to use direct or non-tunneled HWRM messaging instead of tunneled messaging. Update HWRM API to a new version to allow this change. Signed-off-by: Randy Schacher Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hsi_struct

[dpdk-dev] [PATCH v2 12/25] net/bnxt: fix VFR cleanup during init failure

2020-09-16 Thread Ajit Khaparde
From: Somnath Kotur If VF-rep port add fails for some reason, code was rolling back all ports added so far. With some applications, there is no need to do that. Just log failure message for the VF rep port add and continue. Also include RTE_MAX_ETH_PORTS value in the bounds check as one port will

[dpdk-dev] [PATCH v2 09/25] net/bnxt: fix the function id used in flow flush

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha The function id being used in the flush is incorrect, fixed the flush of the flows. Fixes: 74bcfc062489 ("net/bnxt: add session and function flow flush") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v2 13/25] net/bnxt: update resource settings

2020-09-16 Thread Ajit Khaparde
From: Shahaji Bhosle Update default resource configuration. Resources include ENCAP records, TCAM, wild card, source property functions and such. Signed-off-by: Shahaji Bhosle Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 29 +

[dpdk-dev] [PATCH v2 11/25] net/bnxt: fix crash in VFR queue select

2020-09-16 Thread Ajit Khaparde
From: Somnath Kotur Instead of bounds checking against max possible rings while selecting queue index for the VF representor, do it against the number of rings configured. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Somnath Kotur Reviewed-by: Venkat Duvv

[dpdk-dev] [PATCH v2 16/25] net/bnxt: increase counter support from 8K to 16K

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha The number of internal stats counter is increased to 16k in both egress and ingress direction. Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v2 19/25] net/bnxt: enable NAT action with tagged traffic

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for performing L3 or L4 rewrite for VLAN tagged flows. The outer most DMAC, SMAC and VLAN are used to overwrite when NAT operations are performed. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt

[dpdk-dev] [PATCH v2 17/25] net/bnxt: check and set initial counter ID

2020-09-16 Thread Ajit Khaparde
From: Somnath Kotur Instead of relying on value of Flow counter ID to determine validity have an explicit boolean flag for the same to check and set. Fixes: 306c2d28e247 ("net/bnxt: support count action in flow query") Fixes: 9cf9c8385df7 ("net/bnxt: add ULP flow counter manager") Signed-off-by

[dpdk-dev] [PATCH v2 20/25] net/bnxt: fix out of bound access in bit handling

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Fix out of bounds access in action bit handling. The act_val is changed to be array to resolve out of bound access issue. Fixes: 52799debdf1c ("net/bnxt: support action bitmap opcode") Signed-off-by: Kishore Padmanabha Reviewed-by: Shahaji Bhosle Reviewed-by: Mike Bau

[dpdk-dev] [PATCH v2 18/25] net/bnxt: enable VXLAN ipv6 encapsulation

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Add code to support vxlan ipv6 tunnel encapsulation. The ipv6 flow traffic class and flow label wild card match can be ignored to support offload on some applications. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/n

[dpdk-dev] [PATCH v2 15/25] net/bnxt: remove VLAN pop action for egress flows

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Whitney platform does not support VLAN pop action in the egress direction. Hence the VLAN pop action is removed from the egress action templates. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_tem

[dpdk-dev] [PATCH v2 24/25] net/bnxt: fix to check VNIC in shutdown path

2020-09-16 Thread Ajit Khaparde
From: Somnath Kotur Add a couple of NULL pointer checks in bnxt_free_all_filters() and bnxt_free_vnics() respectively to guard against certain error injection/recovery scenarios where it was found that the application was crashing with the bp->vnic_info pointer being NULL. Fixes: 51fafb89a9a0 ("

[dpdk-dev] [PATCH v2 21/25] net/bnxt: provide switch info if VFR are configured

2020-09-16 Thread Ajit Khaparde
From: Sriharsha Basavapatna Some applications need switch_info of the device to be returned as a part of eth_dev_info_get(). The offload logic in such applications could use this info. Pass this info to the when VF representors are configured. Fixes: 322bd6e70272 ("net/bnxt: add port representor

[dpdk-dev] [PATCH v2 23/25] net/bnxt: add locks in flow database

2020-09-16 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for mutex protection for the flow database to prevent simultaneous access to flow database and protect flow creation and deletion. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- dri

[dpdk-dev] [PATCH v2 25/25] net/bnxt: add separate mutex for FW health check

2020-09-16 Thread Ajit Khaparde
From: Somnath Kotur def_cp_lock was added to sync race between dev_configure and int_handler. It should not be used to synchronize scheduling of FW health check between dev_start and async event handler as well, use a separate mutex for the same. Fixes: a73b8e939f10 ("net/bnxt: fix race between

[dpdk-dev] [PATCH v2 22/25] net/bnxt: fix bugs in representor data path

2020-09-16 Thread Ajit Khaparde
From: Somnath Kotur 1.Representor Rx ring producer index was not getting reset in the ring full case. Fix it by incrementing only in success case. 2.Instead of calling the mbuf specific routine to free the mbuf when representor ring is full rte_free was being called leading to 'invalid memory' er

[dpdk-dev] [PATCH v2 2/2] mbuf: minor cleanup

2020-09-16 Thread Morten Brørup
The mbuf header files had some commenting style errors that affected the API documentation. Also, the RTE_ prefix was missing on a macro and a definition. Note: This patch does not touch the offload and attachment flags that are also missing the RTE_ prefix. Changes only affecting documentation:

[dpdk-dev] [PATCH v2 1/2] mbuf: minor cleanup

2020-09-16 Thread Morten Brørup
The mbuf header files had some commenting style errors that affected the API documentation. Also, the RTE_ prefix was missing on a macro and a definition. Note: This patch does not touch the offload and attachment flags that are also missing the RTE_ prefix. Changes only affecting documentation:

[dpdk-dev] [PATCH v2 0/2] mbuf: minor cleanup

2020-09-16 Thread Morten Brørup
The mbuf header files had some commenting style errors that affected the API documentation. Also, the RTE_ prefix was missing on a macro and a definition. This cleanup was also discussed here: http://inbox.dpdk.org/dev/98cbd80474fa8b44bf855df32c47dc35c61...@smartserver.smartshare.dk/ Please note:

Re: [dpdk-dev] [PATCH v2 07/12] acl: add infrastructure to support AVX512 classify

2020-09-16 Thread Bruce Richardson
On Tue, Sep 15, 2020 at 05:50:20PM +0100, Konstantin Ananyev wrote: > Add necessary changes to support new AVX512 specific ACL classify > algorithm: > - changes in meson.build to check that build tools >(compiler, assembler, etc.) do properly support AVX512. > - run-time checks to make sure t

Re: [dpdk-dev] 18.11.10 (LTS) patches review and test

2020-09-16 Thread Kevin Traynor
On 16/09/2020 08:27, Chen, BoX C wrote: > Hi Kevin, > > Update DPDK LTS 18.11.10 test result for Intel part. virtio test found a new > bug. > > > > * Intel(R) Testing > > > > # Basic Intel(R) NIC testing > > * PF(i40e):Passed > > - Known issue: Exception message when starting testpmd

Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information

2020-09-16 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/9/15 0:31, Ferruh Yigit wrote: On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: From: Huisong Li Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because "ports[pid].rx_conf" and "ports[pid].tx_conf"

Re: [dpdk-dev] [PATCH v3 00/17] Replace terms master/slave

2020-09-16 Thread Burakov, Anatoly
On 15-Sep-20 4:10 PM, Stephen Hemminger wrote: As announced in 20.08 release notes, the terms for lcore role will change in 20.11 release. This is a project wide patchset to terminolgy used for DPDK lcore. The term "master" referring to lcore is replaced with "main" and "slave" lcore is replaced

Re: [dpdk-dev] [PATCH v2 07/12] acl: add infrastructure to support AVX512 classify

2020-09-16 Thread Medvedkin, Vladimir
Hi Bruce, On 16/09/2020 10:11, Bruce Richardson wrote: On Tue, Sep 15, 2020 at 05:50:20PM +0100, Konstantin Ananyev wrote: Add necessary changes to support new AVX512 specific ACL classify algorithm: - changes in meson.build to check that build tools (compiler, assembler, etc.) do properl

Re: [dpdk-dev] [PATCH v2 07/12] acl: add infrastructure to support AVX512 classify

2020-09-16 Thread Bruce Richardson
On Wed, Sep 16, 2020 at 10:36:32AM +0100, Medvedkin, Vladimir wrote: > Hi Bruce, > > On 16/09/2020 10:11, Bruce Richardson wrote: > > On Tue, Sep 15, 2020 at 05:50:20PM +0100, Konstantin Ananyev wrote: > > > Add necessary changes to support new AVX512 specific ACL classify > > > algorithm: > > >

Re: [dpdk-dev] [PATCH v2 07/12] acl: add infrastructure to support AVX512 classify

2020-09-16 Thread Ananyev, Konstantin
> On Wed, Sep 16, 2020 at 10:36:32AM +0100, Medvedkin, Vladimir wrote: > > Hi Bruce, > > > > On 16/09/2020 10:11, Bruce Richardson wrote: > > > On Tue, Sep 15, 2020 at 05:50:20PM +0100, Konstantin Ananyev wrote: > > > > Add necessary changes to support new AVX512 specific ACL classify > > > > alg

Re: [dpdk-dev] 18.11.10 (LTS) patches review and test

2020-09-16 Thread Kevin Traynor
On 16/09/2020 10:25, Kevin Traynor wrote: > On 16/09/2020 08:27, Chen, BoX C wrote: >> Hi Kevin, >> >> Update DPDK LTS 18.11.10 test result for Intel part. virtio test found a new >> bug. >> >> >> >> * Intel(R) Testing >> >> >> >> # Basic Intel(R) NIC testing >> >> * PF(i40e):Passed >> >> - Kn

[dpdk-dev] [PATCH] net/mlx5: manage header reformat actions with hashed list

2020-09-16 Thread Suanming Mou
To manage encap decap header format actions mlx5 PMD used the single linked list and lookup and insertion operations took too long times if there were millions of objects and this impacted the flow insertion/deletion rate. In order to optimize the performance the hashed list is engaged. The list i

[dpdk-dev] [PATCH 1/2] common/cpt: remove redundant CPT_BYTE_* macros

2020-09-16 Thread Archana Muniganti
The macros can be replaced with actual constants. Signed-off-by: Archana Muniganti --- drivers/common/cpt/cpt_mcode_defines.h | 3 --- drivers/common/cpt/cpt_ucode.h | 14 +++--- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/common/cpt/cpt_mcode_defines

[dpdk-dev] [PATCH 2/2] common/cpt: add check for mac_len

2020-09-16 Thread Archana Muniganti
HMAC/HASH opcode algorithms supports fixed mac length. Allowed session creation to fail when requested for unsupported MAC length for HMAC/HASH-only use cases. Signed-off-by: Archana Muniganti --- drivers/common/cpt/cpt_mcode_defines.h| 3 ++ drivers/common/cpt/cpt_ucode.h

[dpdk-dev] [PATCH v3] mbuf: minor cleanup

2020-09-16 Thread Morten Brørup
The mbuf header files had some commenting style errors that affected the API documentation. Also, the RTE_ prefix was missing on a macro and a definition. Note: This patch does not touch the offload and attachment flags that are also missing the RTE_ prefix. Changes only affecting documentation:

[dpdk-dev] [PATCH] examples/fips_validation: bypass the unsupported test vectors

2020-09-16 Thread Archana Muniganti
Bypass the test vectors of unsupported crypto transform for SHA. Signed-off-by: Archana Muniganti --- examples/fips_validation/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index efd32a8..bde779c 1

[dpdk-dev] [PATCH] mempool/ring: build on Windows

2020-09-16 Thread Tal Shnaiderman
Build the ring mempool handler for Windows OS. Signed-off-by: Tal Shnaiderman --- drivers/mempool/bucket/meson.build| 5 + drivers/mempool/meson.build | 4 drivers/mempool/octeontx/meson.build | 5 + drivers/mempool/octeontx2/meson.build | 5 + drivers/mempool/sta

[dpdk-dev] [PATCH v3] mbuf: minor cleanup

2020-09-16 Thread Morten Brørup
The mbuf header files had some commenting style errors that affected the API documentation. Also, the RTE_ prefix was missing on a macro and a definition. Note: This patch does not touch the offload and attachment flags that are also missing the RTE_ prefix. Changes only affecting documentation:

Re: [dpdk-dev] [PATCH] net/i40e: fix recreate a flexible FDIR rule failed

2020-09-16 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Tuesday, September 15, 2020 2:52 PM > To: dev@dpdk.org > Cc: Guo, Jia ; Xing, Beilei ; Sun, > GuinanX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix recreate a flexible FDIR rule failed > > This patch fixes

[dpdk-dev] [PATCH v2] doc: fix grammatical error

2020-09-16 Thread Sarosh Arif
This patch corrects a grammatical error by changing 'an DPDK' to 'a DPDK', so that the sentences can become grammatically accurate. Signed-off-by: Sarosh Arif --- doc/guides/linux_gsg/build_sample_apps.rst| 4 ++-- doc/guides/linux_gsg/enable_func.rst | 2 +- doc/guides/lin

Re: [dpdk-dev] DPDK hugepage memory fragmentation

2020-09-16 Thread Burakov, Anatoly
On 16-Sep-20 5:32 AM, Kamaraj P wrote: Hi Anatoly, We just dump the memory contents when it fails to allocate the memory. Hi Kamaraj, Yes, i can see that the memory is fragmented. That's not what i was asking though, because memory fragmentation is *expected* if you're using igb_uio. You'r

Re: [dpdk-dev] [PATCH v1] net/ice: fix incorrect ptype parsing

2020-09-16 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Wednesday, September 16, 2020 11:02 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Zhang, Qi Z ; Xu, Ting > ; sta...@dpdk.org > Subject: [PATCH v1] net/ice: fix incorrect ptype parsing > > The ptype mask for flexible descriptor

[dpdk-dev] [PATCH] doc: flow rule removal on port stop

2020-09-16 Thread Gregory Etelson
There is a discrepancy between RTE ETHDEV API and flow rules guide regarding flow rules maintenance after port stop. RTE ETHDEV API in librte_ethdev.h declares that flow rules will not be stored in PMD after port stop: > Quite start Please note that some configuration is not stored between c

Re: [dpdk-dev] [PATCH v3] bpf: remove experimental tag

2020-09-16 Thread Ananyev, Konstantin
> > The BPF lib was introduced in 18.05. > There were no changes in it's public API since 19.11. > It should be mature enough to remove it's 'experimental' tag. > RTE_BPF_XTYPE_NUM is also being dropped from rte_bpf_xtype to > avoid possible ABI problems in the future. > > --- > v2: RTE_BPF_XTYPE

Re: [dpdk-dev] [PATCH v3] ipsec: remove experimental tag

2020-09-16 Thread Ananyev, Konstantin
> Since librte_ipsec was first introduced in 19.02 and there were no changes > in it's public API since 19.11, it should be considered mature enough to > remove the 'experimental' tag from it. > The RTE_SATP_LOG2_NUM enum is also being dropped from rte_ipsec_sa.h to > avoid possible ABI problems

[dpdk-dev] [PATCH 18.11] vfio: map contiguous areas in one go

2020-09-16 Thread Anatoly Burakov
Currently, when we are creating DMA mappings for memory that's either external or is backed by hugepages in IOVA as PA mode, we assume that each page is necessarily discontiguous. This may not actually be the case, especially for external memory, where the user is able to create their own IOVA tabl

Re: [dpdk-dev] 18.11.10 (LTS) patches review and test

2020-09-16 Thread Burakov, Anatoly
On 07-Sep-20 11:12 AM, Kevin Traynor wrote: Hi all, Here is a list of patches targeted for LTS release 18.11.10. The planned date for the final release is 21 September. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the

Re: [dpdk-dev] DPDK hugepage memory fragmentation

2020-09-16 Thread Burakov, Anatoly
On 16-Sep-20 12:19 PM, Burakov, Anatoly wrote: On 16-Sep-20 5:32 AM, Kamaraj P wrote: Hi Anatoly, We just dump the memory contents when it fails to allocate the memory. Hi Kamaraj, Yes, i can see that the memory is fragmented. That's not what i was asking though, because memory fragmentati

[dpdk-dev] Issue with net/netvsc pmd in 18.11.9

2020-09-16 Thread Dey, Souvik
Hi All, I updated from dpdk 18.11.6 to 18.11.9 and my netvsc pmd stopped working as expected. Firstly, I saw a crash in tx packets as soon as the dpdk app comes up. In doing some googling found a bug that was fixed after 18.11.9 https://patches.dpdk.org/patch/75001/ . Ported this fix and w

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/i40e: fix incorrect byte counters

2020-09-16 Thread Ferruh Yigit
On 9/16/2020 2:51 AM, Junyu Jiang wrote: This patch fixed the issue that rx/tx bytes overflowed "Rx/Tx statistics counters overflowed"? on 48 bit limitation by enlarging the limitation. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang ---

Re: [dpdk-dev] [PATCH v3 1/1] doc: document vfio-pci usage with QAT PMD

2020-09-16 Thread Burakov, Anatoly
On 15-Sep-20 12:14 PM, Adam Dybkowski wrote: This patch marks the old igb_uio driver as unsecure when used with the QAT PMD and updates all examples to recommend using vfio-pci instead. It also mentions security issues with the QAT CPM and provides information about the new vfio-pci parameter 'di

Re: [dpdk-dev] [PATCH V4 0/3] add FEC support

2020-09-16 Thread humin (Connor)
Hi, all Are there any comment? Thanks Connor 在 2020/9/10 15:24, Min Hu (Connor) 写道: This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c | 219 +

[dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting

2020-09-16 Thread wangyunjian
From: Yunjian Wang The variables 'vfio_res->nb_maps' and 'i' are of type int. The type casting of 'vfio_res->nb_maps' is redundant and not required. Signed-off-by: Yunjian Wang --- drivers/bus/pci/linux/pci_vfio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/driver

Re: [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting

2020-09-16 Thread Burakov, Anatoly
On 16-Sep-20 1:41 PM, wangyunjian wrote: From: Yunjian Wang The variables 'vfio_res->nb_maps' and 'i' are of type int. The type casting of 'vfio_res->nb_maps' is redundant and not required. Signed-off-by: Yunjian Wang --- I wonder if we should make vfio_res->nb_maps to be an unsigned int i

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-16 Thread Ananyev, Konstantin
Hi Guijjar, > > In an eventdev world, multiple workers (with ordered queue) will be > working on IPsec ESP processing. The ESP header's sequence number is > unique and has to be sequentially incremented in an orderly manner. > This rises a need for incrementing sequence number in crypto stage > e

Re: [dpdk-dev] [PATCH V4 1/3] ethdev: introduce FEC API

2020-09-16 Thread Ananyev, Konstantin
Seems ok in general, few nits below. > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by:

Re: [dpdk-dev] [PATCH] vfio: remove unnecessary explicit type casting

2020-09-16 Thread Burakov, Anatoly
On 16-Sep-20 2:38 PM, Burakov, Anatoly wrote: On 16-Sep-20 1:41 PM, wangyunjian wrote: From: Yunjian Wang The variables 'vfio_res->nb_maps' and 'i' are of type int. The type casting of 'vfio_res->nb_maps' is redundant and not required. Signed-off-by: Yunjian Wang --- I wonder if we should

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

2020-09-16 Thread Kevin Traynor
On 16/09/2020 13:00, Dey, Souvik wrote: > Hi All, > I updated from dpdk 18.11.6 to 18.11.9 and my netvsc pmd stopped > working as expected. Firstly, I saw a crash in tx packets as soon as the dpdk > app comes up. In doing some googling found a bug that was fixed after 18.11.9 > https://pat

Re: [dpdk-dev] [PATCH v1 5/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default

2020-09-16 Thread Ananyev, Konstantin
> testpmd will initialize default max packet length to 1518 which does't > include vlan tag size in ether overheader. Once, send the max mtu length > packet with vlan tag, the max packet length will exceed 1518 that will > cause packets dropped directly from NIC hw side. But for i40e/i40evf, > they

Re: [dpdk-dev] Issue with net/netvsc pmd in 18.11.9

2020-09-16 Thread Dey, Souvik
Yes the patch solves the seg fault issue, but even after backporting the patch we are not able to send packets with size higher than 512. The packets not being transmitted is the real problem here. I have also tried to take the 18.11.10rc1 build but faced similar issues in transmitting the packe

Re: [dpdk-dev] [PATCH v2] bus/dpaa: fix fd check before close

2020-09-16 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-16 Thread Ananyev, Konstantin
> > > > > + > > > +switch (dev->cb_mode) { > > > +case RTE_ETH_DEV_POWER_MGMT_CB_WAIT: > > > +case RTE_ETH_DEV_POWER_MGMT_CB_PAUSE: > > > +rte_eth_remove_rx_callback(port_id, 0, > > > + dev->cur_pwr_cb); > > > +break; > > > +case RTE_ETH_DEV_POWER_MGMT_CB_SCALE: > > > +rte_power_freq_max(lcore

Re: [dpdk-dev] [PATCH v4 00/31] remove make support in DPDK

2020-09-16 Thread David Marchand
On Tue, Sep 15, 2020 at 5:08 PM Power, Ciara wrote: > >I could not find a patch in patchwork for app/test-bbdev/test-bbdev.py which > >still references RTE_SDK and RTE_TARGET. > Changes to test-bbdev.py were made in patch 15: > https://patchwork.dpdk.org/patch/76796/ to remove the references to R

Re: [dpdk-dev] [PATCH 04/20] net/atlantic: release port upon close

2020-09-16 Thread Igor Russkikh
On 14/09/2020 1:06 am, Thomas Monjalon wrote: > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > can be freed by rte_eth_dev_close(). > > Freeing of private port resources is moved > from the ".remove(device)" to the ".dev_close(port)" operation. > > Signed-off-by: Thomas Monja

Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions

2020-09-16 Thread Gujjar, Abhinandan S
Hi Konstantin, Please find some comments inline. > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 16, 2020 7:10 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org > Cc: Doherty, Declan ; jer...@marvell.com; > akhil.go...@nxp.com; Vangati, Narender ; > Gujjar, Abhin

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/dpaa2: fix build error about timesync functions

2020-09-16 Thread Ferruh Yigit
On 9/15/2020 3:40 AM, Chenxu Di wrote: When the build option has '-DRTE_LIBRTE_IEEE1588=1', the announce of timesync functions will be build. However the dpdk_conf doesn't hav RTE_LIBRTE_IEEE1588 so that the file dpaa2_ptp.c will not be build. It cause the build error. This patch fixes it by addi

Re: [dpdk-dev] [RFC 1/3] ethdev: add item/action for SFT

2020-09-16 Thread Ori Kam
Hi Andrey, PSB > -Original Message- > From: Andrey Vesnovaty > Sent: Wednesday, September 9, 2020 11:30 PM > > Attach SFT flow context to packet with SFT action. > Match on SFT flow context (attached to packet), > with SFT item. > > Signed-off-by: Andrey Vesnovaty > --- > lib/librte_

Re: [dpdk-dev] [PATCH] net/tap: release port upon close

2020-09-16 Thread Ferruh Yigit
On 9/16/2020 8:20 AM, wangyunjian wrote: -Original Message- From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Tuesday, September 15, 2020 10:53 PM To: wangyunjian ; dev@dpdk.org Cc: tho...@monjalon.net; Lilijun (Jerry) ; xudingke Subject: Re: [dpdk-dev] [PATCH] net/tap: release po

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API

2020-09-16 Thread Andrey Vesnovaty
Hi Ajit For shared action configuration I have following suggestion: struct rte_flow_shared_action_conf { uint32_t no_ingress: 1; uint32_t no_egress: 1; }; /*...*/ rte_flow_shared_action_create(..., const struct rte_flow_shared_action_conf *conf, ...); What do you think? Thank

Re: [dpdk-dev] [PATCH 2/2] common/cpt: add check for mac_len

2020-09-16 Thread Anoob Joseph
> > HMAC/HASH opcode algorithms supports fixed mac length. > Allowed session creation to fail when requested for unsupported MAC > length for HMAC/HASH-only use cases. > > Signed-off-by: Archana Muniganti Series Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH v2 4/4] app/testpmd: fix displaying Rx Tx queues information

2020-09-16 Thread Ferruh Yigit
On 9/16/2020 10:23 AM, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/9/15 0:31, Ferruh Yigit wrote: On 8/20/2020 2:42 AM, Wei Hu (Xavier) wrote: From: Huisong Li Currently, the information of Rx/Tx queues from PMD driver is not displayed exactly in the rxtx_config_display function. Because

Re: [dpdk-dev] [PATCH v2 0/2] remove RTE CIO barriers

2020-09-16 Thread David Marchand
On Fri, Sep 11, 2020 at 7:26 AM Phil Yang wrote: > > Since rte_cio_*mb APIs have been deprecated[1], remove them and use > rte_io_*mb APIs instead. > > [1] > http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst#L100 > > v2: > Update 20.11 release note by adding these API c

Re: [dpdk-dev] [PATCH] avoid libfdt checks adding full paths to pkg-config

2020-09-16 Thread David Marchand
On Wed, Sep 2, 2020 at 1:10 PM Christian Ehrhardt wrote: > > The checks for libfdt try dependency() first which would only work if > a pkg-config would be present but libfdt has none. > Then it probes for the lib path itself via cc.find_library. > > But later it adds the result of either probe to

Re: [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler

2020-09-16 Thread David Marchand
On Fri, Aug 14, 2020 at 7:45 PM Stephen Hemminger wrote: > > The debug message was poorly worded and did not include the > part that would be useful. I.e it never said what was being ignored. > Change it to print the message so that if udev changes format or > other subsystems need to be added the

Re: [dpdk-dev] [PATCH v3 1/6] eal: add power management intrinsics

2020-09-16 Thread Liang, Ma
On 04 Sep 11:42, Stephen Hemminger wrote: we have discussed with arm developer in the past. Please ref https://patches.dpdk.org/patch/70662/ There was no objection, in my opinoin. Also the API we proposed has experimental tag, other vendor still can change it. For the ethdev internal ops we int

Re: [dpdk-dev] [PATCH v2 2/2] rte_log: make rte_logs private

2020-09-16 Thread David Marchand
On Fri, Sep 4, 2020 at 1:05 AM Stephen Hemminger wrote: > > As announced in earlier releases, rte_logs can now be made > internal to eal_common_log. > > Acked-by: Andrew Rybchenko > Signed-off-by: Stephen Hemminger Series applied with the two changes mentioned in the thread, thanks. -- David

Re: [dpdk-dev] [PATCH v3 3/6] power: add simple power management API and callback

2020-09-16 Thread Liang, Ma
On 16 Sep 07:53, Ananyev, Konstantin wrote: Yes. we only has two gear. min or max. However, user still can customize their system max with power mgmt python script on Intel platform. > So rte_power_init(lcore) always raises lcore frequency to > max possible value? > > > > > > > > +rte_eth_remove

  1   2   3   >