[dpdk-dev] [PATCH v4 4/5] net/hns3: add Rx buffer size to Rx qinfo query

2020-09-05 Thread Chengchang Tang
Report hns3 PMD configured Rx buffer size in Rx queue information query. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index fc1a256..

[dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port

2020-09-05 Thread Chengchang Tang
Add Rx buffer size to show_port function to display it in the port PMD information so that the user can get the buffer length used by HW queue of receiving packets. Signed-off-by: Chengchang Tang --- app/proc-info/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/proc-info/main.c

[dpdk-dev] [PATCH v4 0/5] add Rx buffer size for rxq info structure

2020-09-05 Thread Chengchang Tang
In common practice, PMD configure the Rx buffer size which indicate the buffer length could be used for HW in receiving packets according to the data room size of the object in mempool. But in fact, the final value is related to the specifications of HW, and its values will affect the number of fra

[dpdk-dev] [PATCH v4 5/5] doc: remove rxq info structure deprecation notice

2020-09-05 Thread Chengchang Tang
The change has been applied, so remove the notice. Signed-off-by: Chengchang Tang --- doc/guides/rel_notes/deprecation.rst | 5 - 1 file changed, 5 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 345c38d..b6d57b9 100644 --- a/doc/

[dpdk-dev] [PATCH v4 1/5] ethdev: add a field for rxq info structure

2020-09-05 Thread Chengchang Tang
Add a field named rx_buf_size in rte_eth_rxq_info to indicate the buffer size used in receiving packets for HW. In this way, upper-layer users can get this information by calling rte_eth_rx_queue_info_get. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) Acked-by: Andrew Rybchenko -

[dpdk-dev] [PATCH v4 2/5] app/testpmd: add Rx buffer size display in queue info query

2020-09-05 Thread Chengchang Tang
Add Rx buffer size to queue info querry cmd so that the user can get the buffer length used by HW queue for receiving packets. Signed-off-by: Chengchang Tang Reviewed-by: Wei Hu (Xavier) --- app/test-pmd/config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/config.c b/app/te

[dpdk-dev] [PATCH 1/2] net/bnxt: remove logically dead code

2020-09-05 Thread wangyunjian
From: Yunjian Wang This patch removes logically dead code reported by coverity. Coverity issue: 360824 Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/bnxt/bnxt_reps.c | 2 -- 1 file changed, 2 deletions(-)

[dpdk-dev] [PATCH 0/2] fixes for bnxt driver

2020-09-05 Thread wangyunjian
From: Yunjian Wang This series include two fixes patches for bnxt driver. Yunjian Wang (2): net/bnxt: remove logically dead code net/bnxt: fix a wrong use of rte_free when freeing mbuf drivers/net/bnxt/bnxt_reps.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.18.1

[dpdk-dev] [PATCH 2/2] net/bnxt: fix a wrong use of rte_free when freeing mbuf

2020-09-05 Thread wangyunjian
From: Yunjian Wang We should use rte_pktmbuf_free() instead of rte_free() to free the mbuf. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/bnxt/bnxt_reps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[dpdk-dev] [PATCH] crypto/dpaax_sec: fix a null pointer dereference after null check

2020-09-05 Thread wangyunjian
From: Yunjian Wang This patch fixes a null pointer dereference after null check detected by coverity scan. Coverity issue: 349904 Fixes: 6a0c9d364afc ("crypto/dpaax_sec: support HFN override") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/crypto/dpaa_sec/dpaa_sec.c | 3 ++- 1 fi

Re: [dpdk-dev] [PATCH v4 5/5] doc: remove rxq info structure deprecation notice

2020-09-05 Thread Thomas Monjalon
05/09/2020 11:07, Chengchang Tang: > The change has been applied, so remove the notice. It should be atomic with the patch doing the change, i.e. you can squash. I think the oneline patches in testpmd and procinfo can probably be squashed with the ethdev patch as well. Thanks

Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add a field for rxq info structure

2020-09-05 Thread Stephen Hemminger
On Sat, 5 Sep 2020 17:07:30 +0800 Chengchang Tang wrote: > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 70295d7..859111a 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1420,6 +1420,8 @@ struct rte_eth_rxq_info { >

Re: [dpdk-dev] [PATCH V2 1/4] ethdev: fix compiling errors for per-queue statistics

2020-09-05 Thread Thomas Monjalon
04/09/2020 20:31, Ferruh Yigit: > On 9/4/2020 12:32 PM, Min Hu (Connor) wrote: > > From: Huisong Li > > > > Currently, only statistics of rx/tx queues with queue_id less than > > RTE_ETHDEV_QUEUE_STAT_CNTRS can be displayed. If there is a certain > > application scenario that it needs to use 256

Re: [dpdk-dev] [PATCH v2] net: adjust the header length parse size

2020-09-05 Thread Stephen Hemminger
On Sat, 5 Sep 2020 11:06:46 +0800 Haiyue Wang wrote: > Align to the rte_mbuf's design about Tx header length data size for the > header length parse result. > struct { > uint64_t l2_len:7; /*88: 0 8 */ > uint64_t l3_len:9; /*

Re: [dpdk-dev] [PATCH v4 3/5] app/procinfo: add Rx buffer size to --show-port

2020-09-05 Thread Stephen Hemminger
On Sat, 5 Sep 2020 17:07:32 +0800 Chengchang Tang wrote: > printf("\t -- queue %d rx scatter %d" > " descriptors %d" > + " rx buffer size %d" >

[dpdk-dev] [PATCH 01/11] cpu_layout: refactor to meet python standards

2020-09-05 Thread Stephen Hemminger
Rearrange code to make it pass python lint. This includes add a main function, docstring, and some variable name changes. Signed-off-by: Stephen Hemminger --- usertools/cpu_layout.py | 145 +++- 1 file changed, 85 insertions(+), 60 deletions(-) diff --git a/u

[dpdk-dev] [PATCH 02/11] dpdk-pmdinfo: replace string.split with split

2020-09-05 Thread Stephen Hemminger
In python3 the standard way to split strings is to use the split() on the string object itself. The old way is broken and would cause a traceback. Signed-off-by: Stephen Hemminger --- usertools/dpdk-pmdinfo.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/usertools/dpdk-p

[dpdk-dev] [PATCH 00/11] Python script updates

2020-09-05 Thread Stephen Hemminger
After writing the hugepages script, decided that the other python scripts need a cleanup and refresh. These changes apply after Louise Kilheeney's patch to change to full Python 3 only. Stephen Hemminger (11): cpu_layout: refactor to meet python standards dpdk-pmdinfo: replace string.split wi

[dpdk-dev] [PATCH 04/11] dpdk-pmdinfo: remove dead code

2020-09-05 Thread Stephen Hemminger
The method loadLocal() is never called, and if it was it would throw an exception because it calling readLocal() without a filename. Pylint spotted this. Signed-off-by: Stephen Hemminger --- usertools/dpdk-pmdinfo.py | 8 1 file changed, 8 deletions(-) diff --git a/usertools/dpdk-pmdi

[dpdk-dev] [PATCH 06/11] dpdk-pmdinfo: replace is False and is True

2020-09-05 Thread Stephen Hemminger
Code reads better if unnecessary comparison with False and True is not used. Signed-off-by: Stephen Hemminger --- usertools/dpdk-pmdinfo.py | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py index 3

[dpdk-dev] [PATCH 08/11] dpdk-pmdinfo: replace deprecated optparse with argparse

2020-09-05 Thread Stephen Hemminger
The optparse module is deprecated and replaced with new argparse. The code now enforces the rule that only one of the output formats can be specified: raw or json. Signed-off-by: Stephen Hemminger --- usertools/dpdk-pmdinfo.py | 70 ++- 1 file changed, 32 inse

[dpdk-dev] [PATCH 03/11] dpdk-pmdinfo: replace io.open with open

2020-09-05 Thread Stephen Hemminger
The builtin open() is the recommended approach in python3. io.open was for compatiablity with older versions. Signed-off-by: Stephen Hemminger --- usertools/dpdk-pmdinfo.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpd

[dpdk-dev] [PATCH 09/11] dpdk-pmdinfo: do not use len(x) to test for empty

2020-09-05 Thread Stephen Hemminger
This fixes the following python lint warnings. usertools/dpdk-pmdinfo.py:188:11: C1801: Do not use `len(SEQUENCE)` to determine if a sequence is empty (len-as-condition) usertools/dpdk-pmdinfo.py:196:21: C1801: Do not use `len(SEQUENCE)` to determine if a sequence is empty (len-as-condition) user

[dpdk-dev] [PATCH 07/11] dpdk-pmdinfo: fix indentation

2020-09-05 Thread Stephen Hemminger
This fixes indentation warnings from pylint. Signed-off-by: Stephen Hemminger --- usertools/dpdk-pmdinfo.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py index 7c27a91182e4..d72feb308a6c 100755 --- a/usertools/dpdk-p

[dpdk-dev] [PATCH 05/11] dpdk-pmdinfo: remove unnecessary paren and else

2020-09-05 Thread Stephen Hemminger
Python lint complains: usertools/dpdk-pmdinfo.py:303:0: C0325: Unnecessary parens after 'if' keyword (superfluous-parens) usertools/dpdk-pmdinfo.py:328:0: C0325: Unnecessary parens after 'not' keyword (superfluous-parens) usertools/dpdk-pmdinfo.py:341:0: C0325: Unnecessary parens after 'if' keywo

[dpdk-dev] [PATCH 10/11] dpdk-telemetry-client: fix some pylint warnings

2020-09-05 Thread Stephen Hemminger
Convert comments to docstrings as appropriate. Remove unnecessary paren in if statement. Remove extra whitespace after print. Signed-off-by: Stephen Hemminger --- usertools/dpdk-telemetry-client.py | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a

[dpdk-dev] [PATCH 11/11] dpdk-devbind: use argparse instead of getopt

2020-09-05 Thread Stephen Hemminger
Using the python standard argument parser instead of C library style getopt gives a number of advantages such as checking for conflicting arguments, restricting choices, and automatically generating help messages. The result is similar to the original the only visible change is that some of the he

[dpdk-dev] [PATCH] doc/devbind: remove references to igb_uio

2020-09-05 Thread Stephen Hemminger
We should be encouraging the use of vfio_pci for developers, not telling them to use igb_uio. Also fix typo where .py suffix is visible in document. Signed-off-by: Stephen Hemminger --- doc/guides/tools/devbind.rst | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) di

[dpdk-dev] [PATCH] doc/flow-perf: fix section headings

2020-09-05 Thread Stephen Hemminger
The flow-perf documentation was using multiple section headings in one document. This caused the documentation tree display in index to make it appear as multiple pages rather than sub-sections in one page. Change to use subsections and subsubsections. Fixes: bf3688f1e816 ("app/flow-perf: add ins

[dpdk-dev] [PATCH v5] usertools: add huge page setup script

2020-09-05 Thread Stephen Hemminger
This is an improved version of the setup of huge pages bases on earlier DPDK setup. Differences are: * it autodetects NUMA vs non NUMA * it allows setting different page sizes recent kernels support multiple sizes. * it accepts a parameter in bytes (not pages). If necessary the steps