[dpdk-dev] [PATCH v10 06/10] common/mlx5: avoid using class constructor priority

2020-07-24 Thread Parav Pandit
mlx5_common is shared library between mlx5 net, VDPA and regex PMD. It is better to use common initialization helper instead of using RTE_PRIORITY_CLASS priority. Reviewed-by: David Marchand Suggested-by: David Marchand Signed-off-by: Parav Pandit --- Changelog: v7->v8: - new patch --- driver

[dpdk-dev] [PATCH v10 09/10] common/mlx5: register class drivers through common layer

2020-07-24 Thread Parav Pandit
Migrate mlx5 net, vdpa and regex PMD to start using mlx5 common class driver. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- Changelog: v8->v9: - Removed leftover inclusion of mlx5_pci bus include directory --- drivers/common/mlx5/mlx5_common_pci.c | 6 ++ drivers/net/mlx5/Makefile

Re: [dpdk-dev] [PATCH v8 08/10] common/mlx5: introduce layer to support multiple class drivers

2020-07-24 Thread David Marchand
This is not a thorough review, just caught one issue for makefile and some nits. On Thu, Jul 23, 2020 at 10:11 PM Parav Pandit wrote: > > From: Thomas Monjalon > > Add generic mlx5 PCI PMD layer as part of existing common_mlx5 > module. This enables multiple classes (net, regex, vdpa) PMDs > to

[dpdk-dev] [PATCH v10 10/10] common/mlx5: remove class check from class drivers

2020-07-24 Thread Parav Pandit
Now that mlx5_pci PMD checks for enabled classes and performs probe(), remove() of associated classes, individual class driver does not need to check if other driver is enabled. Signed-off-by: Parav Pandit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 37

[dpdk-dev] [PATCH v2] net/ice: fix GTPU down/uplink and extension conflict

2020-07-24 Thread Simei Su
When adding a RSS rule with GTPU_DWN/UP, it will write from top to bottom for profile due to firmware limitation. If a RSS rule with GTPU_EH already exists, then GTPU_DWN/UP packet will match GTPU_EH profile. This patch solves this issue by remembering a gtpu_eh RSS configure and removing it before

Re: [dpdk-dev] [PATCH] net/kni: set packet input port in eth_kni_rx()

2020-07-24 Thread Ferruh Yigit
On 7/1/2020 8:49 AM, Ferruh Yigit wrote: > From: jiancheng pei > > Store port_id in pmd_internals when eth kni device is created. > Then set packet port of rte_mbuf in function eth_kni_rx. Overall looks good, except minor issues commented below. Since I have sent on behalf of the Jecky, I will s

Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order

2020-07-24 Thread Bruce Richardson
On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote: > 24/07/2020 15:48, Parav Pandit: > > Hi Bruce, > > > > > From: Bruce Richardson > > > Sent: Friday, July 24, 2020 4:37 PM > > > > > > On Thu, Jul 23, 2020 at 11:09:03PM +0300, Parav Pandit wrote: > > > > From: Thomas Monjalon > >

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-24 Thread David Marchand
On Sun, Jul 19, 2020 at 12:09 PM Thomas Monjalon wrote: > > The detection of the CPU was done in a constructor and shared > in a global variable. > > This variable may not be visible in the net PMD > because it was not exported as part of the .map file. > It is fixed by exporting a function, which

[dpdk-dev] [PATCH v2] net/kni: set packet input port in Rx

2020-07-24 Thread Ferruh Yigit
From: jiancheng pei Store port_id in pmd_internals when eth kni device is created. Then set packet port of rte_mbuf in function eth_kni_rx. Signed-off-by: Jecky Pei Reviewed-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net

Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order

2020-07-24 Thread Parav Pandit
> From: Bruce Richardson > Sent: Friday, July 24, 2020 8:20 PM > > On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote: > > 24/07/2020 15:48, Parav Pandit: > > > Hi Bruce, > > > > > > > From: Bruce Richardson > > > > Sent: Friday, July 24, 2020 4:37 PM > > > > > > > > On Thu, Jul

Re: [dpdk-dev] [PATCH v8 03/10] drivers: relax dependency order

2020-07-24 Thread Bruce Richardson
On Fri, Jul 24, 2020 at 03:17:38PM +, Parav Pandit wrote: > > > > From: Bruce Richardson > > Sent: Friday, July 24, 2020 8:20 PM > > > > On Fri, Jul 24, 2020 at 03:54:33PM +0200, Thomas Monjalon wrote: > > > 24/07/2020 15:48, Parav Pandit: > > > > Hi Bruce, > > > > > > > > > From: Bruce Ric

Re: [dpdk-dev] [PATCH 0/2] Fix vhost performance regression

2020-07-24 Thread Maxime Coquelin
On 7/24/20 10:54 AM, Maxime Coquelin wrote: > > > On 7/24/20 9:06 AM, Maxime Coquelin wrote: >> Hi Yinan, >> >> On 7/24/20 6:55 AM, Wang, Yinan wrote: >>> Hi Maxime, >>> >>> The performance drop issue can be fixed, thanks! >>> The multi-queues interrupt issue still exist w/ this patch set. >>

Re: [dpdk-dev] [PATCH] common/mlx5: fix CPU detection for PCI relaxed ordering

2020-07-24 Thread Matan Azrad
Hi Thomas From: Thomas Monjalon: > 19/07/2020 13:41, Matan Azrad: > > > > From: Thomas Monjalon: > > > 19/07/2020 12:56, Matan Azrad: > > > > > > > > From: Thomas Monjalon > > > > > The detection of the CPU was done in a constructor and shared in > > > > > a global variable. > > > > > > > > > > Th

Re: [dpdk-dev] [PATCH v4 0/3] compile librte_net for windows

2020-07-24 Thread Kadam, Pallavi
On 7/23/2020 12:08 AM, Fady Bader wrote: v2: * fixed style issue. v3: * replaced htons with rte_cpu_to_be_16. * rebased to current master. v4: * removed the use of rte_random in librte_net. * replaced htons with RTE_BE16. Fady Bader (3): net: fix s_addr redefinition in Windows

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/af_xdp: don't free the mempool on umem destruction

2020-07-24 Thread Ferruh Yigit
On 7/24/2020 2:20 PM, Ciara Loftus wrote: > Other PMDs may be using the mempool, so don't free it when destroying the > UMEM. > > Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") > Cc: sta...@dpdk.org > > Signed-off-by: Ciara Loftus Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3 01/22] net/bnxt: add shadow and search capability to tcam

2020-07-24 Thread Stephen Hemminger
On Thu, 23 Jul 2020 22:32:14 -0700 Ajit Khaparde wrote: > +int > +tf_search_tcam_entry(struct tf *tfp, > + struct tf_search_tcam_entry_parms *parms) > +{ > + int rc; > + struct tf_session *tfs; > + struct tf_dev_info *dev; > + struct tf_tcam_alloc_search_parms spa

Re: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit definition

2020-07-24 Thread Honnappa Nagarahalli
> Subject: [dpdk-dev] [PATCH v10 01/10] eal: introduce macro for bit definition > > There are several drivers which duplicate bit generation macro. > Introduce a generic bit macros so that such drivers avoid redefining same in > multiple drivers. > > Signed-off-by: Parav Pandit > Acked-by: Mat

[dpdk-dev] [[PATCH v3 1/4] net/mlx5: query device frequency

2020-07-24 Thread Patrick Keroulas
Get clock frequency (constant) from HCA attributes and add an accessor. Signed-off-by: Patrick Keroulas --- drivers/common/mlx5/mlx5_devx_cmds.c| 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h| 1 + drivers/net/mlx5/linux/mlx5_ethdev_os.c | 22 ++ drivers/net/mlx5/linux

[dpdk-dev] [[PATCH v3 2/4] ethdev: add API to query device frequency

2020-07-24 Thread Patrick Keroulas
Signed-off-by: Patrick Keroulas --- lib/librte_ethdev/rte_ethdev.c | 12 lib/librte_ethdev/rte_ethdev.h | 17 + lib/librte_ethdev/rte_ethdev_core.h | 5 + lib/librte_ethdev/rte_ethdev_version.map | 2 ++ 4 files changed, 36 insertions(+)

[dpdk-dev] [[PATCH v3 3/4] pdump: convert timestamp to nanoseconds on Rx path

2020-07-24 Thread Patrick Keroulas
Use start time and device frequency to translate raw Rx hardware timestamps into nanoseconds. Signed-off-by: Patrick Keroulas --- lib/librte_pdump/rte_pdump.c | 25 + 1 file changed, 25 insertions(+) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.

[dpdk-dev] [[PATCH v3 0/4] pdump HW Rx timestamps for mlx5

2020-07-24 Thread Patrick Keroulas
The intention is to produce a pcap with nanosecond precision when Rx timestamp offloading is activated on mlx5 NIC. The packets forwarded by testpmd hold the raw counter but a pcap requires a time unit. Assuming that the NIC clock is already synced with external master clock, this patchset simply

[dpdk-dev] [[PATCH v3 4/4] net/pcap: support hardware Tx timestamps

2020-07-24 Thread Patrick Keroulas
From: Vivien Didelot When hardware timestamping is enabled on Rx path, system time should no longer be used to calculate the timestamps when dumping packets. Instead, use the value stored by the driver in mbuf->timestamp and assume it is already converted to nanoseconds (otherwise the applicatio

Re: [dpdk-dev] [PATCH v3 00/22] bnxt patches

2020-07-24 Thread Ajit Khaparde
On Thu, Jul 23, 2020 at 10:32 PM Ajit Khaparde wrote: > Some fixes, cleanups and changes to augment pre-existing > support in infrastructure > > Please apply > > v1->v2: > - Fixed some typos in patch [9/20]. > v2->v3: > - Fixed coding style issues in patch [15/20] to use __rte_attribute. > - U

Re: [dpdk-dev] [PATCH] net/i40e: enable i40e outer VLAN strip in QinQ

2020-07-24 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Friday, July 24, 2020 4:38 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: RE: [dpdk-dev] [PATCH] net/i40e: enable i40e outer VLAN strip in QinQ > > > > > -Original Message- > >

[dpdk-dev] [PATCH] doc: add NIC supported by MLX5 vDPA driver

2020-07-24 Thread Sergey Madaminov
Update the docs, adding MCX621102AN-ADAT to the list of NICs supported by MLX5 vDPA driver. Signed-off-by: Sergey Madaminov Suggested-by: William Tu --- doc/guides/vdpadevs/mlx5.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/vdpadevs/mlx5.rst b/doc/guides/vdpadevs/mlx5.rst i

[dpdk-dev] [PATCH v1 0/4] some bugs fixes

2020-07-24 Thread Xiaoyun wang
This patch modifies csum offload process, optimize Rx performance for x86, set vhd type with 2 for no offset in ovs offload scenario, make timeout not affected by system time jump. -- v1: - modify csum offload process - optimize Rx performance for x86 - modify vhd type for SDI - make tim

[dpdk-dev] [PATCH v1 2/4] net/hinic: optimize Rx performance for x86

2020-07-24 Thread Xiaoyun wang
For x86 platform, the rq cqe without cache aligned, which can improve performace for some gateway scenarios. Fixes: 361a9ccf81d6 ("net/hinic: optimize Rx performance") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_rx.h | 4 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH v1 1/4] net/hinic: modify csum offload process

2020-07-24 Thread Xiaoyun wang
Encapsulate different types of packet checksum preprocessing into functions. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_tx.c | 371 +-- 1 file changed, 202 insertions(+), 169 deletions(-) diff --git a/drivers/net/hinic/hinic_pmd_tx.c b/driver

[dpdk-dev] [PATCH v1 4/4] net/hinic/base: make timeout not affected by system time jump

2020-07-24 Thread Xiaoyun wang
Replace gettimeofday() with clock_gettime(CLOCK_MONOTONIC_RAW, &now), the reason is same with this patch "make alarm not affected by system time jump". Fixes: 81d53291a466 ("net/hinic/base: add various headers") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_co

[dpdk-dev] [PATCH v1 3/4] net/hinic/base: modify vhd type for SDI

2020-07-24 Thread Xiaoyun wang
For ovs offload scenario, when fw processes the virtio header, there is no need to offset; and for standard card scenarios, fw does not care about the vhd_type parameter, so in order to be compatible with the two scenarios, use 0 offset instead. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/

Re: [dpdk-dev] [PATCH v2 2/2] doc: update release notes for vhost async APIs

2020-07-24 Thread Xia, Chenbo
> -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 22, 2020 11:02 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick > Subject: [PATCH v2 2/2] doc: update release notes for vhost async APIs > > From: Patrick Fu > > Update 20.08 release n

Re: [dpdk-dev] [PATCH v2 1/2] doc: update guides for vhost async APIs

2020-07-24 Thread Xia, Chenbo
> -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 22, 2020 11:02 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick > Subject: [PATCH v2 1/2] doc: update guides for vhost async APIs > > From: Patrick Fu > > Update vhost guides to docume

<    1   2