Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 16:59:11 + Honnappa Nagarahalli wrote: > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte > > > > atomic APIs in future patches > > > > > > > > 16/07/2020 12:48, David Marchand: > > > > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang w

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 14:41:41 +0100 "Burakov, Anatoly" wrote: > On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: > > On Wed, 15 Jul 2020 14:28:17 +0100 > > "Burakov, Anatoly" wrote: > > > >>> -#define SKIP_MASTER SKIP_INITIAL > >>> -#define CALL_MASTER CALL_INITIAL > >>> +#define SKIP_

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 14:41:41 +0100 "Burakov, Anatoly" wrote: > On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: > > On Wed, 15 Jul 2020 14:28:17 +0100 > > "Burakov, Anatoly" wrote: > > > >>> -#define SKIP_MASTER SKIP_INITIAL > >>> -#define CALL_MASTER CALL_INITIAL > >>> +#define SKIP_

Re: [dpdk-dev] [PATCH] lib/librte_eal/common/rte_malloc: remove redundant check for size and alignment

2020-07-16 Thread Lukasz Wojciechowski
W dniu 15.07.2020 o 15:31, Sarosh Arif pisze: > Since mallock_socket() always calls malloc_heap_alloc() and > this check is present inside malloc_heap_alloc() so there is > no need to place it in mallock_socket(). > > Signed-off-by: Sarosh Arif > --- > lib/librte_eal/common/rte_malloc.c | 4

Re: [dpdk-dev] [PATCH v3 0/6] vhost: improve ready state

2020-07-16 Thread Wang, Yinan
Hi Matan, In our daily regression test, we found this patch set will decrease virtio performance and causes virtio interrupt not working properly in multi queue scenarios. Could you help to take a look? Details in Bugzilla https://bugs.dpdk.org/show_bug.cgi?id=507, btw, pls use low qemu vers

[dpdk-dev] [PATCH v2] net/ice: fix incorrect Rx/Tx bytes statistics

2020-07-16 Thread Junyu Jiang
This patch fixed the issue that rx/tx bytes overflowed on 40 bit limitation by enlarging the limitation. Fixes: a37bde56314d ("net/ice: support statistics") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c | 36 drivers/net/ice

Re: [dpdk-dev] [PATCH] net/bnxt: remove unneeded experimental build flag

2020-07-16 Thread Ajit Khaparde
On Thu, Jul 16, 2020 at 12:26 AM David Marchand wrote: > -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation. > See https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5 > > Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") > > Signed-off-by: David Marchand > Acked-by:

Re: [dpdk-dev] [PATCH v4 00/10] bnxt patches

2020-07-16 Thread Ajit Khaparde
On Wed, Jul 15, 2020 at 6:55 AM Somnath Kotur wrote: > Minor enhancments added to the TF-ULP/Core layers > > Farah Smith (1): > net/bnxt: add changes to support 2 table scopes > > Jay Ding (2): > net/bnxt: implement TF Identifier search > net/bnxt: check index range in bulk get > > Kishore

Re: [dpdk-dev] [PATCH] net/bnxt: remove unneeded experimental build flag

2020-07-16 Thread Ajit Khaparde
On Thu, Jul 16, 2020 at 3:50 PM Ajit Khaparde wrote: > > On Thu, Jul 16, 2020 at 12:26 AM David Marchand > wrote: > >> -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation. >> See https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5 >> >> Fixes: 322bd6e70272 ("net/bnxt: add port represent

Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-16 Thread Xia, Chenbo
> -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 15, 2020 7:15 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick ; Wang, Yinan > Subject: [PATCH v2] vhost: support async copy free segmentations > > From: Patrick Fu > > Vhost async enq

Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-16 Thread Xia, Chenbo
> -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 15, 2020 11:59 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Wang, Yinan ; Fu, Patrick > Subject: [PATCH v1] vhost: set zmbufs to NULL when freed > > From: Patrick Fu > > zmbufs should be set t

[dpdk-dev] [PATCH] net/ice: fix issue for GTPU and GTPU extension packet

2020-07-16 Thread Simei Su
Because of incomplete protocol header fields, GTPU_INNER_IPV4_UDP and GTPU_INNER_IPV4_TCP profile aren't included in inner ipv4 group. This patch complements header fields for GTPU/GTPU_EH ipv4 rss config. Besides, after configuring L4 port, GTPU and GTPU_EH packets don't do hash for UDP/TCP/SCTP.

[dpdk-dev] [dpdk-dev v1] net/iavf: fix simple xor hash

2020-07-16 Thread Jeff Guo
Simple xor hash should be global congfigured in VFs. Fixes: 215a247b5f33 (net/iavf: refactor hash flow) Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_hash.c | 46 +++- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.

[dpdk-dev] [PATCH v5 2/2] doc: announce deprecation of refcnt atomic member

2020-07-16 Thread Phil Yang
refcnt_atomic member in structures rte_mbuf and rte_mbuf_ext_shared_info will be deprecated in 20.11 release. Suggested-by: Honnappa Nagarahalli Signed-off-by: Phil Yang Acked-by: Konstantin Ananyev --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --gi

[dpdk-dev] [PATCH v5 1/2] mbuf: use C11 atomic builtins for refcnt operations

2020-07-16 Thread Phil Yang
Use C11 atomic builtins with explicit ordering instead of rte_atomic ops which enforce unnecessary barriers on aarch64. Suggested-by: Olivier Matz Suggested-by: Dodji Seketeli Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Acked-by: Olivier Matz --- v5: 1. Change built-ins to builtins. 2.

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-16 Thread Phil Yang
> On Thu, Jul 16, 2020 at 3:21 PM Dodji Seketeli wrote: > > Just for the sake of precision, I'd like to say that in the coming 1.8 > > version of libabigail, this change won't be reported by the tooling as a > > problem anymore. This is thanks to David filing the feature request > > https://sou

Re: [dpdk-dev] [PATCH v8 1/3] doc: add optimizations using C11 atomic built-ins

2020-07-16 Thread Phil Yang
Honnappa Nagarahalli writes: > > > Subject: [PATCH v8 1/3] doc: add optimizations using C11 atomic built-ins > > > > Add information about possible optimizations using C11 atomic built-ins. > > > > Signed-off-by: Phil Yang > > Signed-off-by: Honnappa Nagarahalli > > Thanks for the changes, t

Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Phil Yang
Honnappa Nagarahalli writes: > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte > > > > atomic APIs in future patches > > > > > > > > 16/07/2020 12:48, David Marchand: > > > > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wrote: > > > > > > check_forbidden_addit

[dpdk-dev] [PATCH v9 0/3] generic rte atomic APIs deprecate proposal

2020-07-16 Thread Phil Yang
DPDK provides generic rte_atomic APIs to do several atomic operations. These APIs are using the deprecated __sync builtins and enforce full memory barriers on aarch64. However, full barriers are not necessary in many use cases. In order to address such use cases, C language offers C11 atomic APIs.

[dpdk-dev] [PATCH v9 1/3] doc: add optimizations using C11 atomic builtins

2020-07-16 Thread Phil Yang
Add information about possible optimizations using C11 atomic builtins. Signed-off-by: Phil Yang Signed-off-by: Honnappa Nagarahalli Reviewed-by: Honnappa Nagarahalli --- doc/guides/prog_guide/writing_efficient_code.rst | 59 +++- 1 file changed, 58 insertions(+), 1 deletio

[dpdk-dev] [PATCH v9 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Phil Yang
In order to deprecate the rte_atomic and rte_smp barrier APIs, prevent the patches from using these APIs and __sync builtins in new code. On x86 the __atomic_thread_fence(__ATOMIC_SEQ_CST) is quite expensive for SMP case. Flag the new code which use __atomic_thread_fence API. Signed-off-by: Phil

[dpdk-dev] [PATCH v9 3/3] eal/atomic: add wrapper for C11 atomic thread fence

2020-07-16 Thread Phil Yang
Provide a wrapper for __atomic_thread_fence builtins to support optimized code for __ATOMIC_SEQ_CST memory order for x86 platforms. Suggested-by: Honnappa Nagarahalli Signed-off-by: Phil Yang Reviewed-by: Ola Liljedahl Acked-by: Konstantin Ananyev --- lib/librte_eal/arm/include/rte_atomic_32.

[dpdk-dev] [dpdk-dev v1] net/iavf: fix simple xor hash

2020-07-16 Thread Jeff Guo
Simple xor hash should be global congfigured in VFs. Fixes: 215a247b5f33 ("net/iavf: refactor hash flow") Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_hash.c | 46 +++- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_has

[dpdk-dev] [PATCH v3] net/i40e: fix fdir cannot receive rx writeback issue

2020-07-16 Thread chenmin . sun
From: Chenmin Sun This patch fixes the fdir cannot receive rx writeback packet issue. The root cause is FDIR interrupt is not correctly enabled. Beside this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown. F

<    1   2   3