Re: [dpdk-dev] [PATCH 2/2] ethdev: tunnel offload model

2020-07-01 Thread Gregory Etelson
> -Original Message- > From: Kinsella, Ray > Sent: Tuesday, June 30, 2020 14:30 > To: Gregory Etelson > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; John McNamara > ; Marko Kovacevic > ; Neil Horman ; > Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > ; Ajit Khaparde > ; srihar

[dpdk-dev] 答复: [PATCH] app/testpmd: update uninitialized member when set fwd mode

2020-07-01 Thread oulijun
Thanks. I will send the V2. -邮件原件- 发件人: Wisam Monther [mailto:wis...@mellanox.com] 发送时间: 2020年6月30日 22:10 收件人: oulijun ; dev@dpdk.org; ferruh.yi...@intel.com 抄送: Linuxarm 主题: RE: [dpdk-dev] [PATCH] app/testpmd: update uninitialized member when set fwd mode Hi Lijun, >-Original Me

Re: [dpdk-dev] [PATCH v4 6/9] eal: register non-EAL threads as lcores

2020-07-01 Thread David Marchand
On Tue, Jun 30, 2020 at 12:07 PM Olivier Matz wrote: > > On Fri, Jun 26, 2020 at 04:47:33PM +0200, David Marchand wrote: > > DPDK allows calling some part of its API from a non-EAL thread but this > > has some limitations. > > OVS (and other applications) has its own thread management but still >

Re: [dpdk-dev] [PATCH 05/37] bus/fslmc: rework portal allocation to a per thread basis

2020-07-01 Thread Ferruh Yigit
On 5/27/2020 2:22 PM, Hemant Agrawal wrote: > From: Nipun Gupta > > The patch reworks the portal allocation which was previously > being done on per lcore basis to a per thread basis. > Now user can also create its own threads and use DPAA2 portals > for packet I/O. > > Signed-off-by: Nipun Gupt

Re: [dpdk-dev] [RFC] ring: make ring implementation non-inlined

2020-07-01 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa > Nagarahalli > Sent: Wednesday, July 1, 2020 1:16 AM > > > > > Subject: Re: [dpdk-dev] [RFC] ring: make ring implementation non- > inlined > > > > 26/03/2020 09:04, Morten Brørup: > > > From: Jerin Jacob > > > > On Fri, Mar 20, 202

Re: [dpdk-dev] [PATCH 15/37] net/dpaa: add support for fmlib in dpdk

2020-07-01 Thread Ferruh Yigit
On 7/1/2020 5:18 AM, Hemant Agrawal wrote: > > On 30-Jun-20 10:30 PM, Ferruh Yigit wrote: >> On 5/27/2020 2:23 PM, Hemant Agrawal wrote: >>> This library is required for configuring FMAN for >>> various flow configurations. >> >> This is a big patch with new files, looks like a new base code dro

Re: [dpdk-dev] [PATCH 17/37] net/dpaa: add support for fmcless mode

2020-07-01 Thread Ferruh Yigit
On 7/1/2020 5:04 AM, Hemant Agrawal wrote: > Hi Ferruh, > > -Original Message- > On 5/27/2020 2:23 PM, Hemant Agrawal wrote: >> From: Sachin Saxena >> >> This patch uses fmlib to configure the FMAN HW for flow and >> distribution configuration, thus avoiding the need for static FMC tool

[dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine

2020-07-01 Thread Lijun Ou
When set the forwarding mode of the pkt, it needs to update the fwd_eng that it is the member of cur_fwd_config. Otherwise, an error will occur when executing the set command and show confg fwd. the flows as follows: 1. ./tespmd -w xxx -l xx -n 4 -- i 2. set fwd mac testpmd> set fwd mac

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-07-01 Thread David Marchand
On Tue, Jun 30, 2020 at 8:57 PM Ananyev, Konstantin wrote: > Imagine the situation - there is a primary proc (supposed to run forever) > that does rte_thread_register/rte_thread_unregister during its lifetime. > Plus from time to time user runs some secondary process to collect stats/debug > the

[dpdk-dev] [PATCH] net/kni: set packet input port in eth_kni_rx()

2020-07-01 Thread Ferruh Yigit
From: jiancheng pei Store port_id in pmd_internals when eth kni device is created. Then set packet port of rte_mbuf in function eth_kni_rx. Signed-off-by: Jecky Pei --- Sending patch to the email list on behalf of the Jecky, initially he sent as github pull request. --- drivers/net/kni/rte_eth

Re: [dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd

2020-07-01 Thread David Marchand
On Mon, Jun 29, 2020 at 3:05 PM Bruce Richardson wrote: > > Just a note. > > Looking at the makefile counterpart, I can see that if we disable the > > null driver, we would have an issue too. > > > I'm not actually seeing an error with it in meson builds. Running a quick > test using build paramet

Re: [dpdk-dev] [PATCH v3 5/7] build/pkg-config: output driver libs first for static build

2020-07-01 Thread Thomas Monjalon
30/06/2020 16:14, Bruce Richardson: > When calling pkg-config --static --libs, pkg-config will always output the > regular libs first, and then the extra libs from libraries.private field, > since the assumption is that those are additional dependencies for building > statically that the .a files d

Re: [dpdk-dev] [PATCH v3 7/7] build/pkg-config: prevent overlinking

2020-07-01 Thread Thomas Monjalon
30/06/2020 16:14, Bruce Richardson: > Add the --as-needed linker flag to the DPDK library list in the pkg-config > file so as to prevent overlinking. Without this flag, when linking > statically using flags from $(pkg-config --static --libs libdpdk), all DPDK > drivers and libs were statically link

Re: [dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper

2020-07-01 Thread David Marchand
On Tue, Jun 30, 2020 at 11:42 AM Olivier Matz wrote: > > diff --git a/lib/librte_eal/include/rte_trace_point.h > > b/lib/librte_eal/include/rte_trace_point.h > > index 377c2414aa..686b86fdb1 100644 > > --- a/lib/librte_eal/include/rte_trace_point.h > > +++ b/lib/librte_eal/include/rte_trace_point

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/ring_perf: fix error statistics in bulk enq/dequeue

2020-07-01 Thread David Marchand
On Tue, Jun 9, 2020 at 1:25 PM Ananyev, Konstantin wrote: > > In size 32 bulk ring enq/dequeue performance test, the "Total count" > > statistics is incorrect. For example, running the test on lcore 25 and > > lcore 26, the output is as follows: > > > > The test command: > > $sudo ./arm64-armv8a-l

Re: [dpdk-dev] [PATCH v3 5/7] build/pkg-config: output driver libs first for static build

2020-07-01 Thread Bruce Richardson
On Wed, Jul 01, 2020 at 09:50:20AM +0200, Thomas Monjalon wrote: > 30/06/2020 16:14, Bruce Richardson: > > When calling pkg-config --static --libs, pkg-config will always output the > > regular libs first, and then the extra libs from libraries.private field, > > since the assumption is that those

Re: [dpdk-dev] [PATCH v2] lib/ring: fix bulk enqueue API to allow HTS/RTS modes

2020-07-01 Thread David Marchand
On Wed, Jun 10, 2020 at 7:57 AM Feifei Wang wrote: > > Remove the unwanted call to "_rte_ring_do_enqueue_elem" to allow for > correct handling of RTS/HTS modes. > > Fixes: e6ba4731c0f3 ("ring: introduce RTS ring mode") > Cc: sta...@dpdk.org > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wa

Re: [dpdk-dev] [PATCH] ring: fix error vlaue of tail in the peek API for ST mode

2020-07-01 Thread David Marchand
On Sun, Jun 28, 2020 at 3:05 PM Ananyev, Konstantin wrote: > > -Original Message- > > From: Feifei Wang > > Sent: Sunday, June 28, 2020 7:24 AM > > To: Honnappa Nagarahalli ; Ananyev, > > Konstantin > > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang ; > > sta...@dpdk.org > > Subject: [PAT

[dpdk-dev] [PATCH v3 0/5] re-implement legacy filter functions by private API

2020-07-01 Thread Chenxu Di
The legacy filter API will be superseded by rte_flow. There are also several small features which can not be implemented in rte_flow. This patch re-implemented features get_fdir_info, get_fdir_stat and set_gre_key_len as private API. This patch also enable RSS action in flow query. v3: -updated th

[dpdk-dev] [PATCH v3 2/5] net/ixgbe: add private APIs

2020-07-01 Thread Chenxu Di
The legacy filter API will be superseded by rte_flow. There are also several small features which can not be implemented in rte_flow. This patch re-implemented these features as private API. Two APIs are added: rte_pmd_ixgbe_get_fdir_info. rte_pmd_ixgbe_get_fdir_stats. Signed-off-by: Chenxu Di --

[dpdk-dev] [PATCH v3 1/5] net/i40e: add private APIs

2020-07-01 Thread Chenxu Di
The legacy filter API will be superseded by rte_flow. There are also several small features which can not be implemented in rte_flow. This patch re-implemented these features as private API. Three APIs are added: rte_pmd_i40e_get_fdir_info. rte_pmd_i40e_get_fdir_stats. rte_pmd_i40e_set_gre_key_len.

[dpdk-dev] [PATCH v3 3/5] app/testpmd: re-implement commands by using private API

2020-07-01 Thread Chenxu Di
The legacy filter API will be superseded. This patch use private api to change the implementation of commands global_config gre-key-len and show port fdir Signed-off-by: Chenxu Di --- app/test-pmd/cmdline.c | 6 app/test-pmd/config.c | 65 +++--- 2 f

[dpdk-dev] [PATCH v3 5/5] app/testpmd: support query RSS config in flow query

2020-07-01 Thread Chenxu Di
This patch support RSS action in flow query. It can display the RSS configuration of the specified rule. For example: we can create an RSS rule by command "flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss types ipv4-tcp l3-src-only l4-dst-only end queues end func symmetric_toeplitz

[dpdk-dev] [PATCH v3 4/5] net/i40e: enable flow query RSS

2020-07-01 Thread Chenxu Di
This patch enables flow query function to get the configuration of the specified rule. Signed-off-by: Chenxu Di --- doc/guides/rel_notes/release_20_08.rst | 1 + drivers/net/i40e/i40e_flow.c | 49 ++ 2 files changed, 50 insertions(+) diff --git a/doc/guides/re

Re: [dpdk-dev] [PATCH v2 2/2] vhost: introduce async enqueue for split ring

2020-07-01 Thread Liu, Yong
> > +#define VHOST_ASYNC_BATCH_THRESHOLD 8 > + Not very clear about why batch number is 8. It is better to save it in rte_vhost_async_features if the value come from hardware requirement. > + > +static __rte_noinline uint32_t > +virtio_dev_rx_async_submit_split(struct virtio_net *dev, > +

Re: [dpdk-dev] [PATCH v3 7/7] build/pkg-config: prevent overlinking

2020-07-01 Thread Bruce Richardson
On Wed, Jul 01, 2020 at 09:56:13AM +0200, Thomas Monjalon wrote: > 30/06/2020 16:14, Bruce Richardson: > > Add the --as-needed linker flag to the DPDK library list in the pkg-config > > file so as to prevent overlinking. Without this flag, when linking > > statically using flags from $(pkg-config -

Re: [dpdk-dev] [PATCH v4 6/9] eal: register non-EAL threads as lcores

2020-07-01 Thread Olivier Matz
On Wed, Jul 01, 2020 at 09:13:36AM +0200, David Marchand wrote: > On Tue, Jun 30, 2020 at 12:07 PM Olivier Matz wrote: > > > > On Fri, Jun 26, 2020 at 04:47:33PM +0200, David Marchand wrote: > > > DPDK allows calling some part of its API from a non-EAL thread but this > > > has some limitations. >

Re: [dpdk-dev] [PATCH] app/test: fix build with ring pmd but no bond pmd

2020-07-01 Thread David Marchand
On Mon, Jun 29, 2020 at 12:09 PM David Marchand wrote: > On Wed, May 27, 2020 at 4:58 PM Bruce Richardson > wrote: > > > > If the bonding pmd is disabled, all autotest associated with it should be > > disabled. However, some of those tests also depended upon the ring PMD so > > were placed in a b

Re: [dpdk-dev] [PATCH 2/2] ring: empty optimization

2020-07-01 Thread David Marchand
On Tue, May 19, 2020 at 6:02 PM Morten Brørup wrote: > > Blank line after declarations? > > > > Are the temporary variable even needed? > > Personally, I agree with you, but I was trying to match the existing coding > style of the closely related rte_ring_count() function - only to avoid this >

Re: [dpdk-dev] [PATCH 0/2] ring: empty optimization

2020-07-01 Thread David Marchand
On Tue, May 19, 2020 at 5:27 PM Morten Brørup wrote: > > Testing if the ring is empty is as simple as comparing the producer and > consumer pointers. > > Checkpatch complains about existing coding style violations, so the first > part of the patch fixes those, and contains no functional changes.

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-07-01 Thread Andrey Vesnovaty
On Tue, Jun 30, 2020 at 12:52 PM Jerin Jacob wrote: > On Mon, Jun 29, 2020 at 3:52 PM Andrey Vesnovaty > wrote: > > > > > > > > On Sun, Jun 28, 2020 at 4:42 PM Jerin Jacob > wrote: > >> > >> On Sun, Jun 28, 2020 at 2:14 PM Andrey Vesnovaty > >> wrote: > >> > > >> > Hi > >> > > >> > On Fri, Jun

Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-07-01 Thread Ori Kam
Hi Jiawei, Please note that you are missing the doc changes. Please update them. Best, Ori > -Original Message- > From: Jiawei Wang > Sent: Thursday, June 25, 2020 7:26 PM > To: Ori Kam ; Slava Ovsiienko > ; Matan Azrad > Cc: dev@dpdk.org; Thomas Monjalon ; Raslan > Darawsheh ; ian.st

Re: [dpdk-dev] [PATCH] test/ring: add stress test for ST peek API

2020-07-01 Thread Ananyev, Konstantin
Hi Honnappa, > > Hi Konstantin, > It looks fine overall, few comments inline. > > > > > Subject: [PATCH] test/ring: add stress test for ST peek API > > > > Introduce new test case to test ST peek API. > > > > Signed-off-by: Konstantin Ananyev > > --- > > > > This patch depends on the

Re: [dpdk-dev] [RFC v2 0/1] add flow action context API

2020-07-01 Thread Jerin Jacob
On Wed, Jul 1, 2020 at 2:54 PM Andrey Vesnovaty wrote: > > > On Tue, Jun 30, 2020 at 12:52 PM Jerin Jacob wrote: >> >> On Mon, Jun 29, 2020 at 3:52 PM Andrey Vesnovaty >> wrote: >> > >> > >> > >> > On Sun, Jun 28, 2020 at 4:42 PM Jerin Jacob wrote: >> >> >> >> On Sun, Jun 28, 2020 at 2:14 PM An

[dpdk-dev] [PATCH v4 04/13] drivers/raw: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 11 +-- drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 11 +-- drivers/raw/ifpga/i

[dpdk-dev] [PATCH v4 01/13] eal/log: introduce log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Introducing the RTE_LOG_REGISTER macro to avoid the code duplication in the log registration process. It is a wrapper macro for declaring the logtype, register the log and sets it's level in the constructor context. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- li

[dpdk-dev] [PATCH v4 03/13] drivers/vdpa: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- drivers/vdpa/ifc/ifcvf_vdpa.c | 10 +- drivers/vdpa/mlx5/mlx5_vdpa.c | 7 +++ 2 files changed, 4 insertions(+), 13 delet

[dpdk-dev] [PATCH v4 00/13] rte_log registration usage improvement

2020-07-01 Thread jerinj
From: Jerin Jacob This patch series improves the rte_log registration code snippet by avoiding duplication of the code around registration by introducing RTE_LOG_REGISTER macro. v4: - Fix the build issue reported at https://travis-ci.com/github/ovsrobot/dpdk/builds/173792541 v3: - Fix the bui

[dpdk-dev] [PATCH v4 02/13] lib: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- lib/librte_bbdev/rte_bbdev.c | 8 +-- lib/librte_bpf/bpf.c | 9 +--- lib/librte_c

[dpdk-dev] [PATCH v4 07/13] drivers/event: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- drivers/event/dpaa/dpaa_eventdev.c | 8 +--- drivers/event/dpaa2/dpaa2_eventdev.c | 10 +- drivers/event/octeontx/ssov

[dpdk-dev] [PATCH v4 08/13] drivers/crypto: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 8 +--- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c| 8 +--- drivers/crypto/caam

[dpdk-dev] [PATCH v4 05/13] drivers/net: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- drivers/net/af_packet/rte_eth_af_packet.c | 8 +--- drivers/net/af_xdp/rte_eth_af_xdp.c | 8 +--- drivers/net/ark/ark_ethdev.

[dpdk-dev] [PATCH v4 06/13] drivers/mempool: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Sachin Saxena Acked-by: Adam Dybkowski --- drivers/mempool/dpaa/dpaa_mempool.c | 10 ++ drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 10 +-

[dpdk-dev] [PATCH v4 09/13] drivers/compress: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- drivers/compress/isal/isal_compress_pmd.c | 10 +- drivers/compress/octeontx/otx_zip_pmd.c | 10 +- drivers/compres

[dpdk-dev] [PATCH v4 12/13] drivers/baseband: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- .../baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 17 + drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 18 +-

[dpdk-dev] [PATCH v4 11/13] drivers/bus: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Sachin Saxena Acked-by: Adam Dybkowski --- drivers/bus/dpaa/dpaa_bus.c | 10 +- drivers/bus/fslmc/fslmc_bus.c| 11 +-- drivers

[dpdk-dev] [PATCH v4 13/13] app/test: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Adam Dybkowski --- app/test/test_efd.c| 6 +- app/test/test_hash.c | 7 +-- app/test/test_timer_racecond.c | 7 +-- 3

[dpdk-dev] [PATCH v4 10/13] drivers/common: use log register macro

2020-07-01 Thread jerinj
From: Jerin Jacob Use log register macro to avoid the code duplication in the log registration process. Signed-off-by: Jerin Jacob Acked-by: Sachin Saxena Acked-by: Adam Dybkowski --- drivers/common/dpaax/dpaax_iova_table.c | 10 +-- drivers/common/iavf/iavf_impl.c | 9 +-- drivers/

[dpdk-dev] [PATCH v2 01/51] net/bnxt: add basic infrastructure for VF representors

2020-07-01 Thread Ajit Khaparde
From: Somnath Kotur Defines data structures and code to init/uninit VF representors during pci_probe and pci_remove respectively. Most of the dev_ops for the VF representor are just stubs for now and will be will be filled out in next patch. To create a representor using testpmd: testpmd -c 0xff

[dpdk-dev] [PATCH v2 03/51] net/bnxt: get IDs for VF-Rep endpoint

2020-07-01 Thread Ajit Khaparde
From: Somnath Kotur Use 'first_vf_id' and the 'vf_id' that is input as part of adding a representor to obtain the PCI function ID(FID) of the VF(VFR endpoint). Use the FID as an input to FUNC_QCFG HWRM cmd to obtain the default vnic ID of the VF. Along with getting the default vNIC ID by supplyin

[dpdk-dev] [PATCH v2 00/51] add features for host-based flow management

2020-07-01 Thread Ajit Khaparde
This patchset introduces support for VF representors, flow counters and on-chip exact match flows. Also implements the driver hook for the rte_flow_query API. v1->v2: - update commit message - rebase patches against latest changes in the tree - fix signed-off-by tags - update release notes Aj

[dpdk-dev] [PATCH v2 04/51] net/bnxt: initialize parent PF information

2020-07-01 Thread Ajit Khaparde
From: Lance Richardson Add support to query parent PF information (MAC address, function ID, port ID and default VNIC) from firmware. Current firmware returns zero for parent default vnic, a temporary Wh+-specific workaround is included until that can be fixed. Signed-off-by: Lance Richardson

[dpdk-dev] [PATCH v2 05/51] net/bnxt: modify port db dev interface

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru Modify ulp_port_db_dev_port_intf_update prototype to take "struct rte_eth_dev *" as the second parameter. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c| 4

[dpdk-dev] [PATCH v2 02/51] net/bnxt: add support for VF-reps data path

2020-07-01 Thread Ajit Khaparde
From: Somnath Kotur Added code to support Tx/Rx from a VF representor port. The VF-reps use the RX/TX rings of the Trusted VF/PF. For each VF-rep, the Trusted VF/PF driver issues a VFR_ALLOC FW cmd that returns "cfa_code" and "cfa_action" values. The FW sets up the filter tables in such a way tha

[dpdk-dev] [PATCH v2 1/2] net/virtio: add vhost-user protocol features support

2020-07-01 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support for Vhost-user protocol features. It is required to support protocol features that were not in initial Vhost-user specification, such as reply-ack, MTU... Also, this patch prevents Virtio multiqueue feature negotiation if the slave does not support M

[dpdk-dev] [PATCH v2 07/51] net/bnxt: add support for hwrm port phy qcaps

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru Issue HWRM_PORT_PHY_QCAPS to the firmware to get the physical port count of the device. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 +

[dpdk-dev] [PATCH v2 0/2] net/virtio: add vhost-user protocol features support

2020-07-01 Thread Adrian Moreno
This series adds Vhost-user protocol features support to Virtio-user PMD's Vhost-user backend. The first patch introduces protocol features negotiation, and the second one reply-ack feature. Changes since v1: - Rebased on top of virtio-next - Dropped patch 3 as it depends on a new SET_STATUS requ

[dpdk-dev] [PATCH v2 06/51] net/bnxt: get port and function info

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru add helper functions to get port & function related information like parif, physical port id & vport id. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v2 2/2] net/virtio: add reply-ack support to Virtio-user

2020-07-01 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support reply-ack vhost-user protocol feature, which is for now only used to ensure VHOST_USER_SET_MEM_TABLE requests are handled by the slave, but later will be used for VHOST_USER_SET_STATUS. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_u

[dpdk-dev] [PATCH v2 08/51] net/bnxt: modify port db to handle more info

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru Apart from func_svif, func_id & vnic, port_db now stores and retrieves func_spif, func_parif, phy_port_id, port_svif, port_spif, port_parif, port_vport. New helper functions have been added to support the same. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Revie

[dpdk-dev] [PATCH v2 11/51] net/bnxt: add multi device support

2020-07-01 Thread Ajit Khaparde
From: Michael Wildt Introduce new modules for Device, Resource Manager, Identifier, Table Types, and TCAM for multi device support. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/meson.build

[dpdk-dev] [PATCH v2 12/51] net/bnxt: support bulk table get and mirror

2020-07-01 Thread Ajit Khaparde
From: Shahaji Bhosle - Add new bulk table type get using FW to DMA the data back to host. - Add flag to allow records to be cleared if possible - Set mirror using tf_alloc_tbl_entry Signed-off-by: Shahaji Bhosle Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[dpdk-dev] [PATCH v2 10/51] net/bnxt: modify EM insert and delete to use HWRM direct

2020-07-01 Thread Ajit Khaparde
From: Peter Spreadborough Modify Exact Match insert and delete to use the HWRM messages directly. Remove tunneled EM insert and delete message types. Signed-off-by: Peter Spreadborough Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[dpdk-dev] [PATCH v2 13/51] net/bnxt: update multi device design support

2020-07-01 Thread Ajit Khaparde
From: Michael Wildt - Implement the modules RM, Device (WH+), Identifier. - Update Session module. - Implement new HWRMs for RM direct messaging. - Add new parameter check macro's and clean up the header includes for i.e. tfp such that bnxt.h is not directly included in the new modules. - Add c

[dpdk-dev] [PATCH v2 14/51] net/bnxt: support two-level priority for TCAMs

2020-07-01 Thread Ajit Khaparde
From: Shahaji Bhosle Allow TCAM indexes to be allocated from top or bottom. If the priority is set to 0, allocate from the lowest tcam indexes i.e. from top. Any other value, allocate it from the highest tcam indexes i.e. from bottom. Signed-off-by: Shahaji Bhosle Signed-off-by: Venkat Duvvuru

[dpdk-dev] [PATCH v2 17/51] net/bnxt: implement support for TCAM access

2020-07-01 Thread Ajit Khaparde
From: Jay Ding Implement TCAM alloc, free, bind, and unbind functions Update tf_core, tf_msg, etc. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 258 ++--- drivers/ne

[dpdk-dev] [PATCH v2 19/51] net/bnxt: update identifier with remap support

2020-07-01 Thread Ajit Khaparde
From: Michael Wildt - Add Identifier L2 CTXT Remap to the P4 device and updated the cfa_resource_types.h to get the type support. Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_resource_typ

[dpdk-dev] [PATCH v2 16/51] net/bnxt: add core changes for EM and EEM lookups

2020-07-01 Thread Ajit Khaparde
From: Randy Schacher - Move External Exact and Exact Match to device module using HCAPI to add and delete entries - Make EM active through the device interface. Signed-off-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/n

[dpdk-dev] [PATCH v2 15/51] net/bnxt: add HCAPI interface support

2020-07-01 Thread Ajit Khaparde
From: Peter Spreadborough Add new hardware shim APIs to support multiple device generations Signed-off-by: Peter Spreadborough Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hcapi/Makefile | 10 + drivers/net/bnxt/hcapi/h

[dpdk-dev] [PATCH v2 21/51] net/bnxt: support two level priority for TCAMs

2020-07-01 Thread Ajit Khaparde
From: Jay Ding Allow TCAM indexes to be allocated from top or bottom. If the priority is set to 0, allocate from the lowest tcam indexes i.e. from top. Any other value, allocate it from the highest tcam indexes i.e. from bottom. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by

[dpdk-dev] [PATCH v2 18/51] net/bnxt: multiple device implementation

2020-07-01 Thread Ajit Khaparde
From: Michael Wildt Implement the Identifier, Table Type and the Resource Manager modules. Integrate Resource Manager with HCAPI. Update open/close session. Move to direct msgs for qcaps and resv messages. Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher

[dpdk-dev] [PATCH v2 20/51] net/bnxt: update RM with residual checker

2020-07-01 Thread Ajit Khaparde
From: Michael Wildt - Add residual checker to the TF Host RM as well as new RM APIs. On close it will scan the DB and check of any remaining elements. If found they will be logged and FW msg sent for FW to scrub that specific type of resources. - Update the module bind to be aware of the mo

[dpdk-dev] [PATCH v2 26/51] net/bnxt: add external action alloc and free

2020-07-01 Thread Ajit Khaparde
From: Jay Ding - Link external action alloc and free to new hcapi interface - Add parameter range checking - Fix issues with index allocation check Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_co

[dpdk-dev] [PATCH v2 24/51] net/bnxt: update RM to support HCAPI only

2020-07-01 Thread Ajit Khaparde
From: Peter Spreadborough - For the EM Module there is a need to only allocate the EM Records in HCAPI RM but the storage control is requested to be outside of the RM DB. - Add TF_RM_ELEM_CFG_HCAPI_BA. - Return error when the number of reserved entries for wc tcam is odd number in tf_tcam_bin

[dpdk-dev] [PATCH v2 25/51] net/bnxt: remove table scope from session

2020-07-01 Thread Ajit Khaparde
From: Peter Spreadborough - Remove table scope data from session. Added to EEM. - Complete move to RM of table scope base and range. - Fix some err messaging strings. - Fix the tcam logging message. Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru R

[dpdk-dev] [PATCH v2 28/51] net/bnxt: implement IF tables set and get

2020-07-01 Thread Ajit Khaparde
From: Jay Ding - Implement set/get for PROF_SPIF_CTXT, LKUP_PF_DFLT_ARP, PROF_PF_ERR_ARP with tunneled HWRM messages - Add IF table for PROF_PARIF_DFLT_ARP - Fix page size offset in the HCAPI code - Fix Entry offset calculation Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-b

[dpdk-dev] [PATCH v2 32/51] net/bnxt: integrate with the latest tf core changes

2020-07-01 Thread Ajit Khaparde
From: Kishore Padmanabha ULP changes to integrate with the latest session open interface in tf_core Signed-off-by: Kishore Padmanabha Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 46 +++

[dpdk-dev] [PATCH v2 30/51] net/bnxt: add global config set and get APIs

2020-07-01 Thread Ajit Khaparde
From: Jay Ding - Add support to update global configuration for ACT_TECT and ACT_ABCR. - Add support to allow Tunnel and Action global configuration. - Remove register read and write operations. - Remove the register read and write support. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvur

[dpdk-dev] [PATCH v2 29/51] net/bnxt: add TF register and unregister

2020-07-01 Thread Ajit Khaparde
From: Michael Wildt - Add TF register/unregister support. Session got session clients to keep track of the ctrl-channels/function. - Add support code to tfp layer Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/

[dpdk-dev] [PATCH v2 36/51] net/bnxt: add index opcode and operand to mapper table

2020-07-01 Thread Ajit Khaparde
From: Kishore Padmanabha Extended the regfile and computed field operations to a common index opcode operation and added globlal resource operations are also part of the index opcode operation. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed

[dpdk-dev] [PATCH v2 34/51] net/bnxt: add support for if table processing

2020-07-01 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for if table processing in the ulp mapper layer. This enables support for the default partition action record pointer interface table. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde

[dpdk-dev] [PATCH v2 31/51] net/bnxt: add support for EEM System memory

2020-07-01 Thread Ajit Khaparde
From: Peter Spreadborough - Select EEM Host or System memory via config parameter - Add EEM system memory support for kernel memory - Dependent on DPDK changes that add support for the HWRM_OEM_CMD. Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru -

[dpdk-dev] [PATCH v2 33/51] net/bnxt: add support for internal encap records

2020-07-01 Thread Ajit Khaparde
From: Mike Baucom Modifications to allow internal encap records to be supported: - Modified the mapper index table processing to handle encap without an action record - Modified the session open code to reserve some 64 Byte internal encap records on tx - Modified the blob encap swap to suppor

[dpdk-dev] [PATCH v2 35/51] net/bnxt: disable Tx vector mode if truflow is enabled

2020-07-01 Thread Ajit Khaparde
From: Kishore Padmanabha The vector mode in the tx handler is disabled when truflow is enabled since truflow now requires bd action record support. Signed-off-by: Kishore Padmanabha Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v2 37/51] net/bnxt: add support for global resource templates

2020-07-01 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for the global resource templates, so that they can be reused by the other regular templates. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c

[dpdk-dev] [PATCH v2 40/51] net/bnxt: enable port MAC qcfg command for trusted VF

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru Issue HWRM_PORT_MAC_QCFG command on trusted vf to fetch the port count. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v2 39/51] net/bnxt: add support for conditional execution of mapper tables

2020-07-01 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for conditional execution of the mapper tables so that actions like count will have table processed only if action count is configured. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde

[dpdk-dev] [PATCH v2 38/51] net/bnxt: add support for internal exact match entries

2020-07-01 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for the internal exact match entries. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c| 38 +++ drivers/net/bnxt/tf_

[dpdk-dev] [PATCH v2 44/51] net/bnxt: fill mapper parameters with default rules info

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru Default rules are needed for the packets to be punted between the following entities in the non-offloaded path 1. Device PORT to DPDK App 2. DPDK App to Device PORT 3. VF Representor to VF 4. VF to VF Representor This patch fills all the relevant information in the computed

[dpdk-dev] [PATCH v2 42/51] net/bnxt: manage VF to VFR conduit

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru When VF-VFR conduits are created, a mark is added to the mark database. mark_flag indicates whether the mark is valid and has VFR information (VFR_ID bit in mark_flag). Rx path was checking for this VFR_ID bit. However, while adding the mark to the mark database, VFR_ID bit i

[dpdk-dev] [PATCH v2 43/51] net/bnxt: parse representor along with other dev-args

2020-07-01 Thread Ajit Khaparde
From: Somnath Kotur Representor dev-args need to be parsed during pci probe as they determine subsequent probe of VF representor ports as well. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 i

[dpdk-dev] [PATCH v2 41/51] net/bnxt: enhancements for port db

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru 1. Add "enum bnxt_ulp_intf_type” as the second parameter for the port & func helper functions 2. Return vfrep related port & func information in the helper functions 3. Allocate phy_port_list dynamically based on port count 4. Introduce ulp_func_id_tbl array for book keepi

[dpdk-dev] [PATCH v2 46/51] net/bnxt: create default flow rules for the VF-rep conduit

2020-07-01 Thread Ajit Khaparde
From: Somnath Kotur Invoked 3 new APIs for the default flow create/destroy and to get the action ptr for a default flow. Changed ulp_intf_update() to accept rte_eth_dev as input and invoke the same from the VF rep start function. ULP Mark Manager will indicate if the cfa_code returned in the Rx c

[dpdk-dev] [PATCH v2 47/51] net/bnxt: add port default rules for ingress and egress

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru ingress & egress port default rules are needed to send the packet from port_to_dpdk & dpdk_to_port respectively. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 76 +-

[dpdk-dev] [PATCH v2 48/51] net/bnxt: fill cfa action in the Tx descriptor

2020-07-01 Thread Ajit Khaparde
From: Venkat Duvvuru Currently, only vfrep transmit requires cfa_action to be filled in the tx buffer descriptor. However with truflow, dpdk(non vfrep) to port also requires cfa_action to be filled in the tx buffer descriptor. This patch uses the correct cfa_action pointer while transmitting the

[dpdk-dev] [PATCH v2 49/51] net/bnxt: add ULP Flow counter Manager

2020-07-01 Thread Ajit Khaparde
From: Somnath Kotur The Flow counter manager allocates memory to hold the software view of the counters where the on-chip counter data will be accumulated along with another memory block that will be shadowing the on-chip counter data i.e where the raw counter data will be DMAed into from the chi

[dpdk-dev] [PATCH v2 51/51] doc: update release notes

2020-07-01 Thread Ajit Khaparde
Update release notes with enhancements in Broadcom PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_20_08.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index 5cb

[dpdk-dev] [PATCH v2 50/51] net/bnxt: add support for count action in flow query

2020-07-01 Thread Ajit Khaparde
From: Somnath Kotur Use the flow counter manager to fetch the accumulated stats for a flow. Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c | 45 +++- drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c| 141

[dpdk-dev] [PATCH v2 27/51] net/bnxt: align CFA resources with RM

2020-07-01 Thread Ajit Khaparde
From: Randy Schacher - HCAPI resources need to align for Resource Manager - Clean up unnecessary debug messages Signed-off-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_resource_types.h | 250 +- drivers/net/bnxt/

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-07-01 Thread Jerin Jacob
On Mon, Jun 22, 2020 at 3:18 PM Phil Yang wrote: > > > -Original Message- > > From: Honnappa Nagarahalli > > Sent: Friday, June 19, 2020 2:26 AM > > To: Carrillo, Erik G ; Phil Yang > > ; dev@dpdk.org > > Cc: d...@linux.vnet.ibm.com; Ruifeng Wang ; > > Dharmik Thakkar ; nd ; > > sta...@dp

  1   2   3   4   >