Re: [dpdk-dev] [PATCH 3/5] app/testpmd: enable burst stats for noisy vnf mode

2020-06-18 Thread Jens Freimann
On Wed, Jun 17, 2020 at 09:43:05AM -0500, Honnappa Nagarahalli wrote: From: Phil Yang Add burst stats for noisy vnf mode. Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") Cc: sta...@dpdk.org Cc: jfreim...@redhat.com Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagar

[dpdk-dev] [PATCH 0/3] net/mlx5: optimize single counter allocate

2020-06-18 Thread Suanming Mou
This patch set optimizes the DevX single counter allocate from two sides: 1. Add the multiple level table to have a quick look up while allocate/search the single shared counter. 2. Optimize the pool look up for the new allocated single counter. Suanming Mou (3): net/mlx5: add Three-Level tabl

[dpdk-dev] [PATCH 1/3] net/mlx5: add Three-Level table utility

2020-06-18 Thread Suanming Mou
For the case which data is linked with sequence increased index, the array table will be more efficient than hash table once need to search one data entry in large numbers of entries. Since the traditional hash tables has fixed table size, when huge numbers of data saved to the hash table, it also

[dpdk-dev] [PATCH 3/3] net/mlx5: optimize single counter pool search

2020-06-18 Thread Suanming Mou
For single counter, when allocate a new counter, it needs to find the pool it belongs in order to do the query together. Once there are millions of counters allocated, the pool array in the counter container will become very large. In this case, the pool search from the pool array will become extr

[dpdk-dev] [PATCH 2/3] net/mlx5: manage shared counters in Three-Level table

2020-06-18 Thread Suanming Mou
Currently, to check if any shared counter with same ID existing, it will have to loop the counter pools to search for the counter. Even add the counter to the list will also not so helpful while there are thousands of shared counters in the list. Change Three-Level table to look up the counter ind

Re: [dpdk-dev] [PATCH 9/9] vhost: only use vDPA config workaround if needed

2020-06-18 Thread Maxime Coquelin
On 6/18/20 8:39 AM, Matan Azrad wrote: > HI Maxime > > From: Maxime Coquelin: >> On 6/17/20 1:04 PM, Matan Azrad wrote: >> > Don’t you think that only enabled queues must be fully initialized > when their status is changed from disabled to enabled? > So, you can assume that dis

[dpdk-dev] [PATCH] net/mlx5: optimize the counter allocate loop

2020-06-18 Thread Suanming Mou
Currently, when allocate a new counter, it needs loop the whole container pool list to get a free counter. In the case with millions of counters allocated, and all the pools are empty, allocate the new counter will still need to loop the whole container pool list first, then allocate a new pool to

Re: [dpdk-dev] [PATCH v9 2/2] timer: support EAL functions on Windows

2020-06-18 Thread Fady Bader
> -Original Message- > From: Ranjit Menon > Sent: Thursday, June 18, 2020 1:16 AM > To: Fady Bader ; dev@dpdk.org > Cc: Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@microsoft.com; > pallavi.ka.

Re: [dpdk-dev] [PATCH 2/4] doc: remove build instructions where unneeded

2020-06-18 Thread Thomas Monjalon
18/06/2020 04:02, Chautru, Nicolas: > From: Thomas Monjalon > > The build should be described only in few places, in order to maintain > > up-to- > > date, accurate and detailed instructions. > > This change is removing some of the unneeded repetitions. > > > > Signed-off-by: Thomas Monjalon > >

[dpdk-dev] [PATCH] net/qede: fix multicast pkts drop in promisc mode

2020-06-18 Thread Devendra Singh Rawat
After enabling promiscuous mode all packets whose destination MAC address is a multicast address were being dropped. This fix configures H/W to receive all traffic in promiscuous mode. Promiscuous mode also overrides allmulticast mode on/off status. Fixes: 40e9f6fc1558 ("net/qede: enable VF-VF tra

[dpdk-dev] [PATCH v2] net/mlx5: optimize free counter lookup

2020-06-18 Thread Suanming Mou
Currently, when allocate a new counter, it needs loop the whole container pool list to get a free counter. In the case with millions of counters allocated, and all the pools are empty, allocate the new counter will still need to loop the whole container pool list first, then allocate a new pool to

Re: [dpdk-dev] [PATCH v1 1/2] vhost: introduce async data path registration API

2020-06-18 Thread Fu, Patrick
> -Original Message- > From: Liu, Yong > Sent: Thursday, June 18, 2020 1:51 PM > To: Fu, Patrick > Cc: Fu, Patrick ; Jiang, Cheng1 > ; Liang, Cunming ; > dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Subject: RE: [dpdk-dev] [PATCH v1 1/2] v

Re: [dpdk-dev] [RFC PATCH 1/6] eal: introduce macros for getting value for bit

2020-06-18 Thread Parav Pandit
> From: Thomas Monjalon > Sent: Wednesday, June 17, 2020 1:35 PM > > 15/06/2020 21:33, Gaëtan Rivet: > > On 10/06/20 17:17 +, Parav Pandit wrote: > > > There are several drivers which duplicate bit generation macro. > > > Introduce a generic bit macros so that such drivers avoid redefining

Re: [dpdk-dev] [RFC PATCH 3/6] common/mlx5: change mlx5 class enum values as bits

2020-06-18 Thread Parav Pandit
> From: Gaëtan Rivet > Sent: Tuesday, June 16, 2020 1:25 AM > > On 10/06/20 17:17 +, Parav Pandit wrote: > > mlx5 PCI Device supports multiple classes of devices such as net, > > vdpa, and/or regex. > > To support these multiple classes, change mlx5_class to a bitmap > > values so that if us

Re: [dpdk-dev] [RFC PATCH 4/6] bus/mlx5_pci: add mlx5 PCI bus

2020-06-18 Thread Parav Pandit
> From: Thomas Monjalon > Sent: Wednesday, June 17, 2020 1:44 PM > To: Parav Pandit ; Gaëtan Rivet > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Ori Kam ; > Matan Azrad > Subject: Re: [dpdk-dev] [RFC PATCH 4/6] bus/mlx5_pci: add mlx5 PCI bus > > 15/06/2020 23:00, Gaëtan Rivet: > > On 10/06/20 1

Re: [dpdk-dev] [RFC PATCH 4/6] bus/mlx5_pci: add mlx5 PCI bus

2020-06-18 Thread Parav Pandit
> From: Gaëtan Rivet > Sent: Tuesday, June 16, 2020 2:31 AM > > On 10/06/20 17:17 +, Parav Pandit wrote: > > Add mlx5 PCI bus which enables multiple mlx5 drivers to bind to single > > pci device. > > > > This is a little quick to explain the architecture here. > First it should be clear th

Re: [dpdk-dev] [PATCH 1/4] doc: remove outdated guidelines for library addition

2020-06-18 Thread Bruce Richardson
On Thu, Jun 18, 2020 at 02:42:15AM +0200, Thomas Monjalon wrote: > There was a doc about how to extend DPDK by adding a library. > It could have been useful but was never updated, > so it is lacking a lot of explanations about doxygen, > meson, versioning, maintainership, etc. > > Anyway such guid

Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver

2020-06-18 Thread Parav Pandit
> From: Thomas Monjalon > Sent: Wednesday, June 17, 2020 1:49 PM > To: Parav Pandit ; Gaëtan Rivet > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Ori Kam ; > Matan Azrad > Subject: Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver > > 15/06/2020 23:46, Gaëtan Rivet: > > On 10/0

Re: [dpdk-dev] [PATCH 2/4] doc: remove build instructions where unneeded

2020-06-18 Thread Bruce Richardson
On Thu, Jun 18, 2020 at 02:42:16AM +0200, Thomas Monjalon wrote: > The build should be described only in few places, > in order to maintain up-to-date, accurate and detailed instructions. > This change is removing some of the unneeded repetitions. > > Signed-off-by: Thomas Monjalon > --- Good cl

Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver

2020-06-18 Thread Parav Pandit
> From: Gaëtan Rivet > Sent: Tuesday, June 16, 2020 3:17 AM > > On 10/06/20 17:17 +, Parav Pandit wrote: > > Create a mlx5 bus driver framework for invoking drivers of multiple > > classes who have registered with the mlx5_pci bus driver. > > > > Validate user class arguments for supported c

Re: [dpdk-dev] [PATCH 4/4] mk: add a paused deprecation warning before each build

2020-06-18 Thread Bruce Richardson
On Thu, Jun 18, 2020 at 02:42:18AM +0200, Thomas Monjalon wrote: > DPDK 20.05 had some deprecation notes after "make config" > and after the build. > For DPDK 20.08, the config note is replaced with a warning > before the config and before the build. > After the warning, there is a pause which can

Re: [dpdk-dev] [RFC PATCH 6/6] bus/mlx5_pci: enable net and vDPA to use mlx5 PCI bus driver

2020-06-18 Thread Parav Pandit
> From: Gaëtan Rivet > Sent: Tuesday, June 16, 2020 3:26 AM > > On 10/06/20 17:17 +, Parav Pandit wrote: > > Enable class driver to match with the mlx5 pci devices. > > Migrate mlx5 net PMD and vdpa PMD to start using mlx5 common class > > driver. > > > > Signed-off-by: Parav Pandit > > --

Re: [dpdk-dev] [PATCH v3 2/7] ethdev: add a link status text representation

2020-06-18 Thread Ivan Dyukov
Hi Ferruh, Thank you for the comments. My answers are inlined. Best regards, Ivan 17.06.2020 19:45, Ferruh Yigit пишет: > On 6/15/2020 10:01 AM, Ivan Dyukov wrote: >> This commit add function which treat link status structure >> and format it to text representation. > If I am following correctly

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-18 Thread Jerin Jacob
On Thu, Jun 18, 2020 at 9:33 AM Honnappa Nagarahalli wrote: > > Thanks Jerin for the feedback > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, June 17, 2020 10:16 AM > > To: Honnappa Nagarahalli > > Cc: dpdk-dev ; Ali Alnubani ; > > orgerl...@mellanox.com; Wenzhuo Lu ;

[dpdk-dev] DPDK Release Status Meeting 18/06/2020

2020-06-18 Thread Ferruh Yigit
Minutes 18 June 2020 Agenda: * Release Dates * Subtrees * LTS * Opens Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v20.08 dates: * Proposal/V1 deadline passed, it was on Friday 12 June 2020 * -rc1:

Re: [dpdk-dev] [PATCH v3 2/4] common/mlx5: support DevX virtq stats operations

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:47 PM, Matan Azrad wrote: > Add DevX API to create and query virtio queue statistics from the HW. > The next counters are supported by the HW per virtio queue: > received_desc. > completed_desc. > error_cqes. > bad_desc_errors. > exceed_max_chain. >

Re: [dpdk-dev] [PATCH v3 3/4] vdpa/mlx5: support virtio queue statistics get

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:47 PM, Matan Azrad wrote: > Add support for statistics operations. > > A DevX counter object is allocated per virtq in order to manage the > virtq statistics. > > The counter object is allocated before the virtq creation and destroyed > after it, so the statistics are valid only in

Re: [dpdk-dev] [PATCH v3 5/7] net/ixgbe: return unknown speed in status

2020-06-18 Thread Ferruh Yigit
On 6/18/2020 2:23 AM, Zhao1, Wei wrote: > Hi, ferruh > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, June 18, 2020 12:51 AM >> To: i.dyu...@samsung.com; dev@dpdk.org; v.kurams...@samsung.com; >> tho...@monjalon.net; david.march...@redhat.com; >> arybche...@solarflare.com

Re: [dpdk-dev] [PATCH v1 2/2] vhost: introduce async enqueue for split ring

2020-06-18 Thread Fu, Patrick
Hi, > -Original Message- > From: Liu, Yong > Sent: Thursday, June 18, 2020 2:57 PM > To: Fu, Patrick > Cc: Fu, Patrick ; Jiang, Cheng1 > ; Liang, Cunming ; > dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > ; Wang, Zhihong ; Ye, > Xiaolong > Subject: RE: [dpdk-dev] [PATCH v1 2/2]

[dpdk-dev] [PATCH v2] build: check functionality rather than binutils version

2020-06-18 Thread Bruce Richardson
Rather than checking the binutils version number, which can lead to unnecessary disabling of AVX512 if fixes have been backported to distro versions, we can instead check the output of "as" from binutils to see if it is correct. The check in the script uses the minimal assembly reproduction code p

Re: [dpdk-dev] [PATCH v3 2/7] ethdev: add a link status text representation

2020-06-18 Thread Ferruh Yigit
On 6/18/2020 11:08 AM, Ivan Dyukov wrote: > Hi Ferruh, > > Thank you for the comments. > > My answers are inlined. > > Best regards, > Ivan > 17.06.2020 19:45, Ferruh Yigit пишет: >> On 6/15/2020 10:01 AM, Ivan Dyukov wrote: >>> This commit add function which treat link status structure >>> and

Re: [dpdk-dev] [PATCH v2] build: check functionality rather than binutils version

2020-06-18 Thread Van Haaren, Harry
> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Thursday, June 18, 2020 12:57 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; tho...@monjalon.net; Richardson, > Bruce > Subject: [dpdk-dev] [PATCH v2] build: check functionality rather than binutils > version > > Rather

Re: [dpdk-dev] [PATCH v3 4/4] examples/vdpa: add statistics show command

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:47 PM, Matan Azrad wrote: > A new vDPA driver feature was added to query the virtq statistics from > the HW. > > Use this feature to show the HW queues statistics for the virtqs. > > Command description: stats X Y. > X is the device ID. > Y is the queue ID, Y=0x to show all the

Re: [dpdk-dev] [RFC PATCH 1/6] eal: introduce macros for getting value for bit

2020-06-18 Thread Parav Pandit
Hi Thomas, > From: dev On Behalf Of Parav Pandit > Sent: Thursday, June 18, 2020 2:55 PM > > > From: Thomas Monjalon > > Sent: Wednesday, June 17, 2020 1:35 PM > > > > 15/06/2020 21:33, Gaëtan Rivet: > > > On 10/06/20 17:17 +, Parav Pandit wrote: > > > > There are several drivers which dupl

Re: [dpdk-dev] [RFC PATCH 1/6] eal: introduce macros for getting value for bit

2020-06-18 Thread Thomas Monjalon
18/06/2020 14:16, Parav Pandit: > From: Parav Pandit > > From: Thomas Monjalon > > > 15/06/2020 21:33, Gaëtan Rivet: > > > > On 10/06/20 17:17 +, Parav Pandit wrote: > > > > > There are several drivers which duplicate bit generation macro. > > > > > Introduce a generic bit macros so that such

Re: [dpdk-dev] [PATCH v3 2/7] ethdev: add a link status textrepresentation

2020-06-18 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, June 18, 2020 2:03 PM > > On 6/18/2020 11:08 AM, Ivan Dyukov wrote: > > Hi Ferruh, > > > > Thank you for the comments. > > > > My answers are inlined. > > > > Best regards, > > Ivan > > 17.06.2020 19:45, Ferruh Y

Re: [dpdk-dev] [RFC PATCH 1/6] eal: introduce macros for getting value for bit

2020-06-18 Thread Parav Pandit
> From: Thomas Monjalon > Sent: Thursday, June 18, 2020 5:52 PM > > 18/06/2020 14:16, Parav Pandit: > > From: Parav Pandit > > > From: Thomas Monjalon > > > > 15/06/2020 21:33, Gaëtan Rivet: > > > > > On 10/06/20 17:17 +, Parav Pandit wrote: > > > > > > There are several drivers which dup

[dpdk-dev] [PATCH 1/4] eal: remove unnecessary null-termination

2020-06-18 Thread Bruce Richardson
Since strlcpy always null-terminates, and the buffer is zeroed before copy anyway, there is no need to explicitly zero the end of the character array, or to limit the bytes that strlcpy can write. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/eal_common_options.c | 3 +-- 1 file chan

[dpdk-dev] [PATCH 0/4] improve runtime loading of shared drivers

2020-06-18 Thread Bruce Richardson
This set includes a number of small improvements for handling the loading of drivers at runtime using the EAL -d flag. It limits the loading of files to only those files which end in .so, which means that one can pass in the whole "drivers/" subfolder from a meson build and not get an error when D

[dpdk-dev] [PATCH 3/4] eal: don't load drivers from insecure paths

2020-06-18 Thread Bruce Richardson
Any paths on the system which are world-writable are insecure and should not be used for loading drivers. Therefore check each driver path before loading it and error out on insecure ones. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/eal_common_options.c | 75 --

[dpdk-dev] [PATCH 2/4] eal: only load shared libs from driver plugin directory

2020-06-18 Thread Bruce Richardson
When we pass a "-d" flag to EAL pointing to a directory, we attempt to load all files in that directory as driver plugins, irrespective of file type. This procludes using e.g. the build/drivers directory, as a driver source since it contains static libs and other files as well as the shared objects

[dpdk-dev] [PATCH 4/4] eal: cache last directory permissions checked

2020-06-18 Thread Bruce Richardson
When loading a directory of drivers, we check the same hierarchy multiple times. If we just cache the last directory checked, this avoids repeated checks of the same path, since all drivers in that path have been added to the list consecutively. Signed-off-by: Bruce Richardson --- lib/librte_eal

[dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-18 Thread Chengchang Tang
In common practice, PMD configure the rx_buf_size according to the data room size of the object in mempool. But in fact the final value is related to the specifications of hw, and its values will affect the number of fragments in recieving pkts. At present, we seem to have no way to espose relevan

Re: [dpdk-dev] DPDK Release Status Meeting 18/06/2020

2020-06-18 Thread Trahe, Fiona
Hi all, If there's a cryptodev API change planned for 20.11 (an ABI breakage), is it necessary to send a deprecation notice in 20.08? Or can this just be worked during the normal 20.11 patch review cycle? Regards, Fiona > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sen

[dpdk-dev] [PATCH] maintainers: resign from next-net-intel/virtio/vhost/af_xdp

2020-06-18 Thread Xiaolong Ye
I will leave Intel soon and likely won't have dedicated time for maintainership, so removing my name from all related maintainer roles. Signed-off-by: Xiaolong Ye --- MAINTAINERS | 5 - 1 file changed, 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 816696caf2..32da70fae9 100644

Re: [dpdk-dev] [PATCH] maintainers: update for netcope sze/nfb

2020-06-18 Thread Martin Špinler
Acked-by: Martin Spinler > Setting Martin Spinler as new and only maintainer for Netcope > libsze2/nfb drivers > > Signed-off-by: Jakub Neruda

Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver

2020-06-18 Thread Gaëtan Rivet
On 18/06/20 10:03 +, Parav Pandit wrote: > > > From: Gaëtan Rivet > > Sent: Tuesday, June 16, 2020 3:17 AM > > > > On 10/06/20 17:17 +, Parav Pandit wrote: > > > Create a mlx5 bus driver framework for invoking drivers of multiple > > > classes who have registered with the mlx5_pci bus dr

[dpdk-dev] [PATCH] app/testpmd: fix CPU cycles per pkt stats on transmit modes

2020-06-18 Thread Phil Yang
In txonly and flowgen forwarding mode, calculating CPU per packets with total received packets is not accurate. Use total transmitted packets for these cases. The error output under txonly mode: testpmd> show fwd stats all -- Forward statistics for port 0 ---

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: add virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > Starting from FW version 22.27.4002, it is required to configure > protection domain (PD) for each virtq created by DevX. > > Add PD requirement in virtq DevX APIs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > -

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: enable burst stats for flowgen mode rx path

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 10:43 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; alia...@mellanox.com; > orgerl...@mellanox.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: adjust virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > In other to fill the new requirement for virtq configuration, > set the single PD managed by the driver for all the virtqs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > --- > drivers/vdpa/mlx5/mlx5_vdpa.c

Re: [dpdk-dev] [PATCH 4/5] app/testpmd: fix burst percentage calculation

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 10:43 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; alia...@mellanox.com; > orgerl...@mellanox.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH 5/5] app/testpmd: enable empty polls in burst stats

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 10:43 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; alia...@mellanox.com; > orgerl...@mellanox.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com;

Re: [dpdk-dev] [PATCH 3/3] net/bnxt: add ARM64 vector support

2020-06-18 Thread Lance Richardson
On Tue, Jun 16, 2020 at 1:18 AM Ruifeng Wang wrote: > > > +#if defined(RTE_ARCH_ARM64) > > +#include > > rte_vect.h includes compatibility improvement. It can replace arm_neon.h here. > > > +#else > > +#error "bnxt vector pmd: unsupported target." > > +#endif > > + Thanks, Ruifeng, I've address

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: clock gettime call in throughput calculation

2020-06-18 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, June 17, 2020 10:43 PM > To: dev@dpdk.org; Honnappa Nagarahalli > ; alia...@mellanox.com; > orgerl...@mellanox.com; wenzhuo...@intel.com; beilei.x...@intel.com; > bernard.iremon...@intel.com > Cc: hemant.agra...@nxp.com;

Re: [dpdk-dev] [RFC PATCH 6/6] bus/mlx5_pci: enable net and vDPA to use mlx5 PCI bus driver

2020-06-18 Thread Gaëtan Rivet
On 18/06/20 10:06 +, Parav Pandit wrote: > > > > From: Gaëtan Rivet > > Sent: Tuesday, June 16, 2020 3:26 AM > > > > On 10/06/20 17:17 +, Parav Pandit wrote: > > > Enable class driver to match with the mlx5 pci devices. > > > Migrate mlx5 net PMD and vdpa PMD to start using mlx5 common

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: adjust virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > In other to fill the new requirement for virtq configuration, > set the single PD managed by the driver for all the virtqs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > --- > drivers/vdpa/mlx5/mlx5_vdpa.c

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-06-18 Thread Carrillo, Erik G
Hi Phil, Good catch - thanks for the fix. I've commented in-line: > -Original Message- > From: Phil Yang > Sent: Friday, June 12, 2020 6:20 AM > To: dev@dpdk.org; Carrillo, Erik G > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com; dharmik.thak...@arm.

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: share kernel interface name getter

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:53 PM, Matan Azrad wrote: > Some configuration of the mlx5 port are done by the kernel net device > associated to the IB device represents the PCI device. > > The DPDK mlx5 driver uses linux system calls, for example ioctl, in > order to configure per port configurations requested b

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: support MTU feature

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:53 PM, Matan Azrad wrote: > The guest virtio device may request MTU updating when the vhost backend > device exposes a capability to support it. > > Exspose the MTU feature capability. s/Expose/Exspose/ > > In configuration time, check the requested MTU and update it in the HW s

Re: [dpdk-dev] DPDK Release Status Meeting 18/06/2020

2020-06-18 Thread Ferruh Yigit
On 6/18/2020 3:09 PM, Trahe, Fiona wrote: > Hi all, > > If there's a cryptodev API change planned for 20.11 (an ABI breakage), is it > necessary > to send a deprecation notice in 20.08? > Or can this just be worked during the normal 20.11 patch review cycle? As far as I got it, it needs to follo

Re: [dpdk-dev] DPDK Release Status Meeting 18/06/2020

2020-06-18 Thread Thomas Monjalon
18/06/2020 17:26, Ferruh Yigit: > On 6/18/2020 3:09 PM, Trahe, Fiona wrote: > > Hi all, > > > > If there's a cryptodev API change planned for 20.11 (an ABI breakage), is > > it necessary > > to send a deprecation notice in 20.08? > > Or can this just be worked during the normal 20.11 patch review

Re: [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-06-18 Thread McDaniel, Timothy
Hello Jerin, I am working on V2 of the patchset, and the ABI breakage will be corrected in that version. Thanks, Tim -Original Message- From: Jerin Jacob Sent: Friday, June 12, 2020 10:59 PM To: McDaniel, Timothy Cc: Jerin Jacob ; dpdk-dev ; Eads, Gage ; Van Haaren, Harry ; Ray Kin

Re: [dpdk-dev] [PATCH 01/27] eventdev: dlb upstream prerequisites

2020-06-18 Thread McDaniel, Timothy
Hello Mattias, Thank you for your review comments. I will incorporate the changes you have suggested in V2 of the patchset, which I am currently working on. Thanks, Tim -Original Message- From: Mattias Rönnblom Sent: Saturday, June 13, 2020 5:44 AM To: Jerin Jacob ; McDaniel, Timothy

Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver

2020-06-18 Thread Parav Pandit
> From: Gaëtan Rivet > Sent: Thursday, June 18, 2020 8:05 PM > To: Parav Pandit > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Ori Kam ; > Matan Azrad > Subject: Re: [dpdk-dev] [RFC PATCH 5/6] bus/mlx5_pci: register a PCI driver > > On 18/06/20 10:03 +, Parav Pandit wrote: > > > > > From: Ga

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: share kernel interface name getter

2020-06-18 Thread Maxime Coquelin
Your series does not apply, there are no common ancestor so I can't do 3-way merge. Could you please rebase it on top of next-virtio's master branch? Thanks, Maxime On 6/2/20 5:53 PM, Matan Azrad wrote: > Some configuration of the mlx5 port are done by the kernel net device > associated to the I

[dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-18 Thread Matan Azrad
Some guest drivers may not configure disabled virtio queues. In this case, the vhost management never triggers the vDPA device configuration because it waits to the device to be ready. The current ready state means that all the virtio queues should be configured regardless the enablement status.

[dpdk-dev] [PATCH v1 4/4] vdpa/mlx5: support queue update

2020-06-18 Thread Matan Azrad
Last changes in vDPA device management by vhost library may cause queue ready state update after the device configuration. So, there is chance that some queue configuration information will be known only after the device was configured. Add support to reconfigure a queue after the device configur

[dpdk-dev] [PATCH v1 0/4] vhost: improve ready state

2020-06-18 Thread Matan Azrad
Dou to the issue described in "vhost: improve device ready definition" patch here, we need to change the ready state definition in vhost device. To support the suggestion improvment there is update for the host notifier control API. Also need to skip access lock when vDPA device is configured.

Re: [dpdk-dev] [PATCH v2] vhost: enable reply-ack systematically

2020-06-18 Thread Maxime Coquelin
On 5/28/20 11:03 AM, Maxime Coquelin wrote: > As announced during v20.05 release cycle, this > patch makes reply-ack protocol feature to be enabled > unconditionally. > > This protocol feature makes the communication between the > master and the slave more robust, avoiding for example > possibl

[dpdk-dev] [PATCH v1 1/4] vhost: support host notifier queue configuration

2020-06-18 Thread Matan Azrad
As an arrangement to per queue operations in the vDPA device it is needed to change the next experimental API: The API ``rte_vhost_host_notifier_ctrl`` was changed to be per queue instead of per device. A `qid` parameter was added to the API arguments list. Setting the parameter to the value VHO

[dpdk-dev] [PATCH v1 2/4] vhost: skip access lock when vDPA is configured

2020-06-18 Thread Matan Azrad
No need to take access lock in the vhost-user massage handler when vDPA driver controls all the data-path of the vhost device. It allows the vDPA set_vring_state operation callback to configure guest notifications. Signed-off-by: Matan Azrad --- lib/librte_vhost/vhost_user.c | 6 -- 1 file

Re: [dpdk-dev] [PATCH v3 0/4] vhost: support vDPA virtio queue statistics

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:47 PM, Matan Azrad wrote: > The vDPA device offloads all the datapath of the vhost device to the HW > device. > > In order to expose to the user traffic information this series introduces new > APIs to get traffic statistics and to reset them per virtio queue. > > Since there is

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: add virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > Starting from FW version 22.27.4002, it is required to configure > protection domain (PD) for each virtq created by DevX. > > Add PD requirement in virtq DevX APIs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > -

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: adjust virtio queue protection domain

2020-06-18 Thread Maxime Coquelin
On 6/2/20 5:51 PM, Matan Azrad wrote: > In other to fill the new requirement for virtq configuration, > set the single PD managed by the driver for all the virtqs. > > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad > Signed-off-by: Xueming Li > --- > drivers/vdpa/mlx5/mlx5_vdpa.c

[dpdk-dev] [PATCH v2 2/7] l3fwd-power: only allow supported power library envs

2020-06-18 Thread Anatoly Burakov
Currently, l3fwd-power will attempt to run even if the power env is set to KVM, which is not supported. Fix this by preventing the app from initializing unless the env is set to one of the supported modes. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 9 + 1 file chang

[dpdk-dev] [PATCH v2 0/7] Add interrupt-only mode to l3fwd-power

2020-06-18 Thread Anatoly Burakov
Since 20.05, l3fwd-power has become much more stringent about whether it allows initialization without initializing the librte_power library with it. This means that while previously the app could have been used to test RX interrupts functionality even if the app itself was in a half-working state,

[dpdk-dev] [PATCH v2 3/7] l3fwd-power: code style and flow fixes

2020-06-18 Thread Anatoly Burakov
Make the coding style more consistent, and the init logic control flow more explicit. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c i

[dpdk-dev] [PATCH v2 1/7] l3fwd-power: disable interrupts by default

2020-06-18 Thread Anatoly Burakov
Currently, interrupts are enabled in telemetry and empty poll modes, but they are not used. Switch to disabling interrupts by default, and only enable interrupts for modes that require them. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 12 +++- 1 file changed, 7 inser

[dpdk-dev] [PATCH v2 5/7] l3fwd-power: add interrupt-only mode

2020-06-18 Thread Anatoly Burakov
In addition to existing modes, add a mode which is very similar to legacy mode, but does not do frequency scaling, and thus does not depend on the power library. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 188 +++- 1 file changed, 185 inserti

[dpdk-dev] [PATCH v2 7/7] l3fwd-power: add auto-selection of default mode

2020-06-18 Thread Anatoly Burakov
Currently, the application does support running without the power library being initialized, but it has to be specifically requested. On platforms without support for frequency scaling using the power library, we can just enable interrupt-only mode by default. Signed-off-by: Anatoly Burakov Sugge

[dpdk-dev] [PATCH v2 4/7] l3fwd-power: add support for requesting legacy mode

2020-06-18 Thread Anatoly Burakov
Currently, legacy mode is the implicit default, but it is not possible to directly request using legacy mode. Add the argument to enable requesting legacy mode, and also make it the default. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 28 +++- 1 file

[dpdk-dev] [PATCH v2 6/7] power: add API to probe support for a specific env

2020-06-18 Thread Anatoly Burakov
Currently, there is no way to know if the power management env is supported without trying to initialize it. The init API also does not distinguish between failure due to some error and failure due to power management not being available on the platform in the first place. Thus, add an API that pr

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: integrate RCU QSBR

2020-06-18 Thread Medvedkin, Vladimir
Hi Ruifeng, Thanks for patches, see comments below On 08/06/2020 06:16, Ruifeng Wang wrote: Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect lookup results. RCU QSBR pro

Re: [dpdk-dev] [PATCH v4 1/3] lib/lpm: integrate RCU QSBR

2020-06-18 Thread Medvedkin, Vladimir
Hi Honnappa, On 08/06/2020 19:46, Honnappa Nagarahalli wrote: Subject: [PATCH v4 1/3] lib/lpm: integrate RCU QSBR Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect looku

Re: [dpdk-dev] [PATCH] crypto/qat: add data-path APIs

2020-06-18 Thread Trahe, Fiona
> -Original Message- > From: Zhang, Roy Fan > Sent: Friday, June 12, 2020 3:40 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Zhang, Roy Fan > ; Bronowski, PiotrX > Subject: [PATCH] crypto/qat: add data-path APIs > > This patch adds data-path APIs to QAT symmetric dir

Re: [dpdk-dev] [EXTERNAL] 19.11.3 patches review and test

2020-06-18 Thread Luca Boccassi
Thank you! On Thu, 2020-06-18 at 18:11 +, Abhishek Marathe wrote: > Hi Luca, > > All testcases pass for DPDK LTS 19.11.3. Failed testcases below were double > checked and No issues found. > > Test Report: > > DPDK > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpd

Re: [dpdk-dev] [PATCH 1/3] eventdev: fix race condition on timer list counter

2020-06-18 Thread Honnappa Nagarahalli
> > Hi Phil, > > Good catch - thanks for the fix. I've commented in-line: > > > -Original Message- > > From: Phil Yang > > Sent: Friday, June 12, 2020 6:20 AM > > To: dev@dpdk.org; Carrillo, Erik G > > Cc: d...@linux.vnet.ibm.com; honnappa.nagaraha...@arm.com; > > ruifeng.w...@arm.

Re: [dpdk-dev] [PATCH 1/2] common/mlx5: share kernel interface name getter

2020-06-18 Thread Matan Azrad
Yes, more conflict are exists with current master-net-mlx. I have newest version rebased on master-net-mlx. I will send new version, for all the old versions... > -Original Message- > From: Maxime Coquelin > Sent: Thursday, June 18, 2020 7:07 PM > To: Matan Azrad ; Slava Ovsiienko > > C

[dpdk-dev] [PATCH v2 0/3] net/bnxt: vector mode enhancements

2020-06-18 Thread Lance Richardson
- Switch to non-vector receive function when "mark" action is requested. - Add support for rx_burst_mode_get()/tx_burst_mode_get() to return currently active receive/transmit mode. - Add vector mode support for ARM64. Lance Richardson (3): net/bnxt: disable vector receive for mark action n

[dpdk-dev] [PATCH 1/3] net/bnxt: disable vector receive for mark action

2020-06-18 Thread Lance Richardson
The bnxt vector mode receive handler does not support the rte_flow 'mark' action. Since we cannot know in advance whether this action will be required, add support for dynamically switching from vector to non-vector receive when the first flow create request with a mark action is processed. Fixes:

[dpdk-dev] [PATCH 2/3] net/bnxt: support Rx/Tx burst mode info

2020-06-18 Thread Lance Richardson
Retrieve burst mode options according to the selected Rx/Tx burst function name. Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- v2: no change doc/guides/nics/features/bnxt.ini | 1 + drivers/net/bnxt/bnxt_ethdev.c| 46 ++

[dpdk-dev] [PATCH 3/3] net/bnxt: add ARM64 vector support

2020-06-18 Thread Lance Richardson
Add bnxt vector PMD support using NEON SIMD instructions. Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- v2: - Use rte_vect.h instead of including arm_neon.h directly in bnxt_rxtx_vec_neon.c. drivers/net/bnxt/Makefile | 3 + drivers/net/bnxt/bnxt_eth

[dpdk-dev] [PATCH v4 2/4] common/mlx5: support DevX virtq stats operations

2020-06-18 Thread Matan Azrad
Add DevX API to create and query virtio queue statistics from the HW. The next counters are supported by the HW per virtio queue: received_desc. completed_desc. error_cqes. bad_desc_errors. exceed_max_chain. invalid_buffer. Signed-off-by: Matan Azrad

[dpdk-dev] [PATCH v4 0/4] vhost: support vDPA virtio queue statistics

2020-06-18 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this series introduces new APIs to get traffic statistics and to reset them per virtio queue. Since there is no any formal statistics suggested by the virtio specs,

[dpdk-dev] [PATCH v4 1/4] vhost: inroduce operation to get vDPA queue stats

2020-06-18 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this patch introduces new 3 APIs to get traffic statistics, the device statistics name and to reset the statistics per virtio queue. The statistics are taken directly

[dpdk-dev] [PATCH v4 3/4] vdpa/mlx5: support virtio queue statistics get

2020-06-18 Thread Matan Azrad
Add support for statistics operations. A DevX counter object is allocated per virtq in order to manage the virtq statistics. The counter object is allocated before the virtq creation and destroyed after it, so the statistics are valid only in the life time of the virtq. Signed-off-by: Matan Azra

[dpdk-dev] [PATCH v4 4/4] examples/vdpa: add statistics show command

2020-06-18 Thread Matan Azrad
A new vDPA driver feature was added to query the virtq statistics from the HW. Use this feature to show the HW queues statistics for the virtqs. Command description: stats X Y. X is the device ID. Y is the queue ID, Y=0x to show all the virtio queues statistics of the device X. Signed-off-by

[dpdk-dev] [PATCH v2 1/2] common/mlx5: share kernel interface name getter

2020-06-18 Thread Matan Azrad
Some configuration of the mlx5 port are done by the kernel net device associated to the IB device represents the PCI device. The DPDK mlx5 driver uses linux system calls, for example ioctl, in order to configure per port configurations requested by the DPDK user. One of the basic knowledges requi

[dpdk-dev] [PATCH v2 0/2] vdpa/mlx5: support MTU feature

2020-06-18 Thread Matan Azrad
v2: rebase. Matan Azrad (2): common/mlx5: share kernel interface name getter vdpa/mlx5: support MTU feature doc/guides/rel_notes/release_20_08.rst | 1 + doc/guides/vdpadevs/features/mlx5.ini | 1 + drivers/common/mlx5/linux/mlx5_common_os.c | 89 +++

  1   2   >