Hi Xialong,
On Tue, Jun 09, 2020 at 01:29:55PM +0800, Xiaolong Ye wrote:
> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and
> mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's
> next field when calling TAILQ_INSERT_TAIL(mbuf_dynfield/dynflag_list, te,
> next).
>
On 06/09, Olivier Matz wrote:
>Hi Xialong,
>
>On Tue, Jun 09, 2020 at 01:29:55PM +0800, Xiaolong Ye wrote:
>> TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and
>> mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's
>> next field when calling TAILQ_INSERT_TAIL(mbuf_dy
TAILQ_ENTRY next is not needed in struct mbuf_dynfield_elt and
mbuf_dynflag_elt, since they are actually chained by rte_tailq_entry's
next field when calling TAILQ_INSERT_TAIL(mbuf_dynfield/dynflag_list, te,
next).
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: sta...@dpdk.org
Hi, Qiming,
> -Original Message-
> From: Yang, Qiming
> Sent: Monday, June 8, 2020 3:36 PM
> To: Xu, Ting ; dev@dpdk.org
> Cc: Zhang, Qi Z ; Mcnamara, John
> ; Kovacevic, Marko
> Subject: RE: [PATCH v1 09/12] net/ice: add queue start and stop for DCF
>
>
>
> > -Original Message---
Hi, Xiaolong
> -Original Message-
> From: Ye, Xiaolong
> Sent: Friday, June 5, 2020 10:42 PM
> To: Xu, Ting
> Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming
> ; Mcnamara, John ;
> Kovacevic, Marko
> Subject: Re: [dpdk-dev] [PATCH v1 12/12] doc: enable DCF datapath
> configuration
>
> Hi,
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
app/test/test_mbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 71bdab691..06e44f0a7 100644
--- a/app/test/
Hi Ferruh,
Please see inline
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, June 8, 2020 2:20 PM
> To: Ophir Munk ; dev@dpdk.org; Matan Azrad
> ; Raslan Darawsheh
> Subject: Re: [dpdk-dev] [PATCH v1 2/8] net/mlx5: add mlx5 Linux specific file
> with getter functions
>
> On 6/
On 6/9/2020 9:40 AM, Ophir Munk wrote:
> Hi Ferruh,
> Please see inline
>
>> -Original Message-
>> From: Ferruh Yigit
>> Sent: Monday, June 8, 2020 2:20 PM
>> To: Ophir Munk ; dev@dpdk.org; Matan Azrad
>> ; Raslan Darawsheh
>> Subject: Re: [dpdk-dev] [PATCH v1 2/8] net/mlx5: add mlx5 Lin
Hi,
Please find comments inline.
> -Original Message-
> From: Ferruh Yigit
> Sent: Monday, June 8, 2020 2:32 PM
> To: Ophir Munk ; dev@dpdk.org; Matan Azrad
> ; Raslan Darawsheh
> Subject: Re: [dpdk-dev] [PATCH v1 7/8] net/mlx5: add mlx5 header file
> specific to Linux
>
> On 6/3/2020 4
This series are bugfixes of coverity defects warning for hns3 PMD driver.
Hongbo Zheng (2):
net/hns3: avoid unchecked return value in reset err process
net/hns3: fix unintended sign extension in dump operation
Wei Hu (Xavier) (2):
net/hns3: fix passing negative parameter to strerror
net/h
From: Hongbo Zheng
There is a coverity defect related "Unchecked return value".
The internal static hns3_reset_err_handle function is reset error process
of hns3 PMD driver. If failure in reset process, it does not mean that the
network port is completely unavailable. so the command interface be
From: Hongbo Zheng
There are coverity defects related "Unintended sign extension" in the
internal static function named hns3_get_regs_length used for dumping reg
operation.
This patch fixes them by replacing the data type of cmdq_lines,
common_lines, ring_lines and tqp_intr_lines with uint32_t i
There is a coverity defect related "Argument cannot be negative".
This patch fixes it by passing '-ret' to the function strerror() when ret
is negative.
Coverity issue: 349933
Fixes: fcba820d9b9e ("net/hns3: support flow director")
Cc: sta...@dpdk.org
Signed-off-by: Wei Hu (Xavier)
---
drivers
Currently, there are coverity defects warning as below:
CID 349937 (#1 of 1): Unintended sign extension (SIGN_EXTENSION)
sign_extension: Suspicious implicit sign extension: port_number with type
uint16_t (16 bits, unsigned) is promoted in port_number << cur_pos to type
int (32 bits, signed), then
Hi Matan,
On 6/8/20 11:19 AM, Matan Azrad wrote:
> Hi Maxime
>
> From: Maxime Coquelin:
>> Hi Matan,
>>
>> On 6/7/20 12:38 PM, Matan Azrad wrote:
>>> Hi Maxime
>>>
>>> Thanks for the huge work.
>>> Please see a suggestion inline.
>>>
>>> From: Maxime Coquelin:
Sent: Thursday, May 14, 2020 11
On 6/4/20 12:36 PM, Wang, Xiao W wrote:
> Hi,
>
>> -Original Message-
>> From: Maxime Coquelin
>> Sent: Wednesday, June 3, 2020 4:58 PM
>> To: Matan Azrad ; Viacheslav Ovsiienko
>>
>> Cc: dev@dpdk.org; Shahaf Shuler ; Wang, Xiao W
>>
>> Subject: Re: [PATCH v3 1/4] vhost: inroduce ope
On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote:
> On Mon, 8 Jun 2020 17:46:40 +0100
> Bruce Richardson wrote:
>
> > Rather than continuing to recommend an 80-char line limit, let's take a hint
> > from the Linux kernel[1] and aim for an 100-char recommended limit instead.
> >
On Mon, 2020-06-08 at 12:25 -0700, Stephen Hemminger wrote:
> The terms blacklist and whitelist are often seen as reminders
> of the divisions in society. Instead, use more exact terms for
> handling of which devices are used in DPDK.
>
> This is a proposed change for DPDK 20.08 to replace the nam
>
> On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote:
> > On Mon, 8 Jun 2020 17:46:40 +0100
> > Bruce Richardson wrote:
> >
> > > Rather than continuing to recommend an 80-char line limit, let's take a
> > > hint
> > > from the Linux kernel[1] and aim for an 100-char recommen
From: Tal Shnaiderman
the struct rte_pci_addr defines domain as uint32_t variable however
the PCI_PRI_FMT macro used for logging the struct sets the format
of domain to uint16_t.
The mismatch causes the following warning messages
in Windows clang build:
format specifies type 'unsigned short' bu
From: Tal Shnaiderman
This patchset implements the EAL and PCI functions needed for probing PMDs
using RTE_KDRV_NONE on Windows.
---
Depends-on: series-10336 ("Windows basic memory management")
v5:
* Adjust mem-mapping functions to changes in latest memory management
patchset.
From: Tal Shnaiderman
Changing all of PCIs Unix memory mapping to the
new memory allocation API wrapper.
Change all of PCI mapping function usage in
bus/pci to support the new API.
Signed-off-by: Tal Shnaiderman
---
drivers/bus/pci/bsd/pci.c| 2 +-
drivers/bus/pci/linux/pci_uio.c |
From: Tal Shnaiderman
Move common functions between Unix and Windows to eal_common_config.c.
Those simple functions are getter functions for IOVA,
configuration, Multi-process.
Move rte_config and runtime_dir to be defined in a common file.
Signed-off-by: Tal Shnaiderman
---
lib/librte_eal/c
From: Tal Shnaiderman
import library (/IMPLIB) in meson.build should use
the 'drivers' and not 'libs' folder.
The error is: fatal error LNK1149: output filename matches input filename.
The fix uses the correct folder.
Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs")
From: Tal Shnaiderman
pmdinfogen generation is currently unsupported for Windows.
The relevant part in meson.build is skipped.
Signed-off-by: Tal Shnaiderman
---
drivers/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/meson.build b/drivers/meson.build
From: Tal Shnaiderman
Added in Windows header file includes
to include off_t type since it is needed by PCI.
export per_lcore__rte_errno from eal since it is needed by PCI.
Signed-off-by: Tal Shnaiderman
---
lib/librte_eal/rte_eal_exports.def | 1 +
lib/librte_eal/rte_eal_version.map
From: Tal Shnaiderman
Uses SetupAPI.h functions to scan PCI tree.
Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node.
Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the BDF.
scanning currently supports types RTE_KDRV_NONE.
Signed-off-by: Tal Shnaiderman
---
drivers/bus/pci/windows/pci.c
From: Tal Shnaiderman
Addition of stub eal and bus/pci functions to compile
bus/pci for Windows.
Signed-off-by: Tal Shnaiderman
---
drivers/baseband/meson.build | 4 +
drivers/bus/ifpga/meson.build | 6 ++
drivers/bus/pci/meson.build| 14 ++-
drivers/bus/pci/pci_common.
Hi Maxime
From: Maxime Coquelin
> Hi Matan,
>
> On 6/8/20 11:19 AM, Matan Azrad wrote:
> > Hi Maxime
> >
> > From: Maxime Coquelin:
> >> Hi Matan,
> >>
> >> On 6/7/20 12:38 PM, Matan Azrad wrote:
> >>> Hi Maxime
> >>>
> >>> Thanks for the huge work.
> >>> Please see a suggestion inline.
> >>>
>
> Subject: [PATCH v7 04/11] eal/mem: extract common code for memseg list
> initialization
>
> All supported OS create memory segment lists (MSL) and reserve VA space
> for them in a nearly identical way. Move common code into EAL private
> functions to reduce duplication.
>
> Signed-off-by: Dmitr
The vhost virtio standard has multi-queue feature.
The master side defines the meximum supported queues number and the
slave can choose to work with all the queues or only with part of them.
The vhost library, which manages the host side, expects to see
configuration of all the queues before the d
>
> In size 32 bulk ring enq/dequeue performance test, the "Total count"
> statistics is incorrect. For example, running the test on lcore 25 and
> lcore 26, the output is as follows:
>
> The test command:
> $sudo ./arm64-armv8a-linuxapp-gcc/app/test -l 25-26
> RTE>>ring_perf_autotest
>
> Bulk e
On 6/9/20 1:09 PM, Matan Azrad wrote:
>
> Hi Maxime
>
> From: Maxime Coquelin
>> Hi Matan,
>>
>> On 6/8/20 11:19 AM, Matan Azrad wrote:
>>> Hi Maxime
>>>
>>> From: Maxime Coquelin:
Hi Matan,
On 6/7/20 12:38 PM, Matan Azrad wrote:
> Hi Maxime
>
> Thanks for the huge w
On 6/9/2020 9:44 AM, Ophir Munk wrote:
> Hi,
> Please find comments inline.
>
>> -Original Message-
>> From: Ferruh Yigit
>> Sent: Monday, June 8, 2020 2:32 PM
>> To: Ophir Munk ; dev@dpdk.org; Matan Azrad
>> ; Raslan Darawsheh
>> Subject: Re: [dpdk-dev] [PATCH v1 7/8] net/mlx5: add mlx5
Upgrade base with below main changes
1. add more protocol support - L2TPv3/ESP/AH/PFCP.
2. Add IPv6 prefix RSS support.
3. support GENEVE and VXLAN rules with VLAN.
4. Add E823L device IDs
5. couple bug fixes and code clean.
v2:
- fix a bug in patch that cause RSS fail in patch 52/52
- fix minor
Add descriptor field offset and mask definition. It is used to parse
FDIR rx descriptor field value.
Signed-off-by: Yahui Cao
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_lan_tx_rx.h | 44
1 file changed, 44 inser
Report AOC types as fiber instead of unknown
Signed-off-by: Doug Dziggel
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/net/ice/base/ice_common.c
b/drivers/net/ice/base
For Flow Director, we don't want to re-use an existed profile with the
same field vector and mask. Merging two different flow_type’s field
vector will also make them sharing trained rule and cause rule
interference.
For example:
issue rule A: IPV4_TCP matching tcp src&dst port 80 to queue 8
issue
When writing the driver's struct ice_tlan_ctx structure, do not write the
8-bit element int_q_state with the associated internal-to-hardware field
which is 122-bits, otherwise the helper function ice_write_byte() will use
undefined behavior when setting the mask used for that write. This should
no
Consolidate implementation of ice_aq_set_mac_cfg for switch mode
and NIC mode. As per the specification, the driver needs to call
set_mac_cfg (opcode 0x0603) to be able to exercise jumbo frames.
Signed-off-by: Anirudh Venkataramanan
Signed-off-by: Jeb Cramer
Signed-off-by: Paul M. Stillwell Jr
FDIR can forward Ethernet packets with non-IP ethertype.
Signed-off-by: Yahui Cao
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.c | 15 +++
drivers/net/ice/base/ice_fdir.h | 2 ++
drivers/net/ice/base/ice_flow.c | 29
Consolidate the Promiscuous rule for SMBM on the chosen logical port.
Signed-off-by: Shibin Koikkara Reeny
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 145 ++
1 file changed, 115 insertions(+), 30 delet
The commit ef92cee94cdb ("ice-shared: Fix remaining minor casting
issues") changed the idx variable within ice_acl_add_entry() from
a u16 to a u8. This causes the code to truncate the values greater
than 255 to 255 or less when calling ice_aq_program_acl_entry()
resulting in the wrong TCAM index be
Currently, the FW link override feature is only permitted for E810
devices. However, the ice_fw_supports_link_override() guards against FW
versions irrespective of the device. This assumes FW versions between
the families are aligned, which is not the case.
Signed-off-by: Jeb Cramer
Signed-off-b
As currently, we are supporting only 5 PHY_SPEEDs for phy_type_high.
Thus, we should adjust the value of ICE_PHY_TYPE_HIGH_MAX_INDEX to 5.
Signed-off-by: Chinh T Cao
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h | 2 +-
1 file changed, 1
This change improve VSI filter configuration rebuild for
multiport configuration, ie. where 1 PF includes more than
one logical port. For some functions, association between
port and corresponding switch_info or port_info structure
has been lost because by default the pointer to the first
element o
Add and report AUI PHY types as an AUI media type
Signed-off-by: Doug Dziggel
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c | 5 +++--
drivers/net/ice/base/ice_type.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/dri
Add additional UDP payload to allow for additional headers such as ESP.
Signed-off-by: Dan Nowlin
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/base/ic
There are some function prototypes at the beginning of the file and
some at the end, group them all together so that they are in one
consistent location.
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.h | 83
Add missing space between end of comment text and comment terminator,
and remove unnecessary punctuation.
Signed-off-by: Bruce Allan
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_acl.c| 25 +-
drivers/net/ice/base/ice_acl_ctrl.
Currently the caller needs to initialize the ice_cfg_phy_fec() parameter
ice_aqc_set_phy_cfg_data FEC fields before calling. However, this is not
necessary since ice_cfg_phy_fec() calls Get PHY Capabilities.
Initialize ice_aqc_set_phy_cfg_data FEC capabilities and FEC option fields
from Get PHY Ca
FDIR can forward:
- L2TPV3 packets with session id.
- IPSEC ESP packets with security parameter index.
- IPSEC AH packets with security parameter index.
- NAT_T ESP packets with security parameter index.
- PFCP packets with s field value.
Signed-off-by: Yahui Cao
Signed-off-by: Paul M. Stillwell
This patch introduces comp_report variable so that the called can
determine whether to report completion on error or on all cases.
Signed-off-by: Yahui Cao
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.c | 2 +-
drivers/net/ice/base/ice_fdir.h
Move the swap of flow director addresses and ports into training packet
generation. This reduces the code written for ACL.
Signed-off-by: Henry Tieman
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.c | 59 ---
To allow for resets during package download, increase the timeout period
after performing a PFR. The time waited is the global config lock
timeout plus the normal PFSWR timeout.
Signed-off-by: Dan Nowlin
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_c
This patch mainly does cleanups related to unnecessary braces.
A few other minor fixes are included which include fixing a typo,
pulling up some lines, and fixing RCT.
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flex_pipe
When programming GENEVE and VXLAN switch rules, there are some instances
where both VLAN tagged packets plus non-VLAN tagged packets are needed
to match the rule.
In order to perform this action in one rule, the switch code needs
to setup the packet flag mask to ignore the VLAN packet flag. This
w
Where possible, cuddle multiple lines of function signatures to be
consistent throughout the code.
Signed-off-by: Bruce Allan
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c | 3 +--
drivers/net/ice/base/ice_controlq.c | 9 +++--
driver
Add couple functions that DPDK would like to use for accessing the
NVM.
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.h | 1 -
drivers/net/ice/base/ice_nvm.c| 67 +--
drivers/net/ice/base/ice_nvm.h| 10
Return ICE_ERR_DOES_NOT_EXIST return code if admin command error code is
ICE_AQ_RC_ENOENT (not exist). ice_aq_sw_rules is used when switch
rule is getting added/deleted/updated. In case of delete/update
switch rule, admin command can return ICE_AQ_RC_ENOENT error code
if such rule does not exist, h
Add debug logs for ice_aq_get_phy_caps(), and format
ice_aq_set_phy_cfg() and ice_aq_get_link_info() debug logs to make them
more readable.
Signed-off-by: Paul Greenwalt
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c | 69 +
The definition of ICE_SW_RULE_RX_TX_ETH_HDR_SIZE open codes the size of
a structure field. Replace this with the use of FIELD_SIZEOF.
Signed-off-by: Jacob Keller
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.h | 17 -
1 file cha
Remove unncessary case branch.
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flow.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c
index 030a55ba7..53ff5f4be 100644
--- a/drivers/net/ice/base/ice_flow.c
+++ b/drivers
Some IPv6 prefix related fields are defined in this patch, so that we
can use prefixes instead of full IPv6 address for RSS. These prefixes
include the first 32, 48, 64 bits of both SRC and DST IPV6 address.
Signed-off-by: Junfeng Guo
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
To avoid having stale information about "adv_rule" per recipe, when all
rules associated to a given recipe are deleted, reset the "adv_rule"
flag otherwise it causes problem later on when decisions about filter
rules being present or not are made based on "adv_rule" flag.
Removed setting "adv_rule
Mask bits before accessing the profile type field.
Signed-off-by: Tarun Singh
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_sched.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ice/base/ice_sched.c b/driv
Needs to update the VSI handle to the last remaining VSI using the
rule for ICE_FWD_TO_VSI. Otherwise it may have error for deleting the
rule.
Signed-off-by: Haiyue Wang
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 1 +
1 file changed, 1 i
This patch add more dummy packet type for pppoe packet,
it enable tcp/udp layer of ipv4/ipv6 for pppoe payload,
so we can use L4 dst/src port as input set for switch
filter.
Signed-off-by: Wei Zhao
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_protoco
The capability flags used to report whether an NVM component has
a pending update are stored as simple booleans. If ice_parse_caps finds
the relevant capability then the boolean is set to true.
If the capability is not provided by firmware, then the boolean value
will be left alone. This works dur
Handles memory leaks during control queue initialization and
buffer allocation failures. The MACRO - ICE_FREE_CQ_BUFS is modified to
re-use for this fix.
Fixes: 6c1f26be50a2 ("net/ice/base: add control queue information")
Cc: sta...@dpdk.org
Signed-off-by: Surabhi Boob
Signed-off-by: Paul M. Sti
The variable 'adj' is initialized to 0 and later used in an addition, but
the value is never changed from 0. Remove the variable since it's doing
nothing.
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flow.c | 3 +--
1 file
Function ice_rem_adv_rule_id return incorrect error code (ICE_ERR_PARAM)
whereas it should have returned ICE_ERR_DOES_NOT_EXIST return code
if filter list is empty or unable to find "rule" in list
Signed-off-by: Kiran Patil
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
driver
The profile TCAM tables are implemented such that entries with a smaller
index in the table have a higher priority. When records to be added to the
table have flags to differentiate between standard PTG and VSIG records,
then these entries need to have higher priority in order to be found and
proce
ice_set_fc takes a u8 pointer 'aq_failures' as an input parameter. If
this function encounters an error, in addition to returning an appropriate
ice_status enum code, it also populates aq_failures with a link specific
error value.
If the caller does not initialize this variable to 0 before calling
There are no implementations for these two functions so remove the
prototypes.
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/ice/base/ice_fdir.h b/dr
When PPPOE header is not selected, pppoe should not be included in
ipv4 ptype bitmaps.
Signed-off-by: Yahui Cao
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flow.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/ne
By default the queues are configured in legacy mode. The default
BW settings for legacy/advanced modes are different. The existing
code was using the advanced mode default value of 1 which was
incorrect. This caused the unbalanced BW sharing among siblings.
The recommneded default value is applied.
Distribute the tx queues evenly across all queue groups. This will
help the queues to get more equal sharing among the queues when all
are in use.
In the previous algorithm, the next queue group node will be picked up
only after the previous one filled with max children.
For example: if VSI is con
struct ice_aqc_get_phy_caps_data has multiple autoneg enable bits.
ice_is_phy_caps_an_enabled checks all bits and returns true if any
autoneg enable bits are set.
Signed-off-by: Paul Greenwalt
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c | 1
The parameter ref_cnt is used for tracking how many
rules are reusing this VSI list, so it can only be
updated when a rule which using this list be deleted.
Fixes: f89aa3affa9e ("net/ice/base: support removing advanced rule")
Cc: sta...@dpdk.org
Signed-off-by: Wei Zhao
Signed-off-by: Paul M. Sti
Add support for LLDP forwarding to SW programming in FW
LLDP Filter Control is 0x0A0A.
Signed-off-by: Sharon Haroni
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/
When free vsi list resource after vsi list update to empty, some
useless code in function ice_remove_vsi_list_rule() should be deleted.
Signed-off-by: Wei Zhao
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 17 +
1 file chang
This patch add more tunnel type defination ipv4/ipv6 packet,
it enable tcp/udp layer of ipv4/ipv6 as L4 payload but without
L4 dst/src port number as input set for switch filter rule.
For example:
we can download a switch rule to direct ipv4 packet with specific
source and destination ip address t
This patch add initialization for prof_res_bm_init flag
to zero in order that the possible resource for field vector
in the files can be initialized.
Fixes: 453d087ccaff ("net/ice/base: add common functions")
Cc: sta...@dpdk.org
Signed-off-by: Wei Zhao
Signed-off-by: Paul M. Stillwell Jr
Signed
Add support for E823L devices.
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c | 5 +
drivers/net/ice/base/ice_devids.h | 10 ++
drivers/net/ice/base/ice_nvm.c| 5 +
drivers/net/ice/ice_ethdev.c | 5 +
4 files changed, 25 insertions(+)
diff --git a/
In the flow API, add ability to add IPV4/IPV6 rules that match on
packets with or without inner L4 protocols.
Also, remove PPPOD packet from PPPOE bitmap.
Signed-off-by: Dan Nowlin
Signed-off-by: Paul M. Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flow.c | 168
There isn't a case for 1G SGMII in ice_get_media_type() so add
the handling for it.
Also handle the special case where some direct attach
cables may report that they support 1G SGMII, but
that is erroneous since SGMII is supposed to be a
backplane media type (between a MAC and a PHY). If
the drive
This adds pci detection and documentation for Intel GEN2
QuickAssist device C34xx (PF Did 0x18ee, VF Did 0x18ef).
Signed-off-by: Adam Dybkowski
---
doc/guides/compressdevs/qat_comp.rst | 3 ++-
doc/guides/cryptodevs/qat.rst | 8 ++--
doc/guides/rel_notes/release_20_08.rst | 5
On 08-Jun-20 12:03 PM, Francesco wrote:
Hi all,
I upgraded an old DPDK-based app which was using DPDK 17.11 to latest DPDK
20.05 and I noticed that if I look at "top" I see that the VIRT memory
taken by my application is now 256.1GB while before it was <1GB.
I've seen this same behavior with al
On 6/9/2020 1:46 PM, Burakov, Anatoly wrote:
> On 08-Jun-20 12:03 PM, Francesco wrote:
>> Hi all,
>> I upgraded an old DPDK-based app which was using DPDK 17.11 to latest DPDK
>> 20.05 and I noticed that if I look at "top" I see that the VIRT memory
>> taken by my application is now 256.1GB while
>
> Add a new security operation structure to the crypto operation to allow
> protocol specific parameters defined in rte_security be defined for a
> crypto operation.
>
> Please note this is API changes only. Implementation will follow in
> next version.
>
> Signed-off-by: David Coyle
> Sign
On 03-Jun-20 12:03 AM, Dmitry Kozlyuk wrote:
All supported OS create memory segment lists (MSL) and reserve VA space
for them in a nearly identical way. Move common code into EAL private
functions to reduce duplication.
Signed-off-by: Dmitry Kozlyuk
---
+int
+eal_memseg_list_alloc(struct r
On 09-Jun-20 2:13 PM, Ferruh Yigit wrote:
On 6/9/2020 1:46 PM, Burakov, Anatoly wrote:
On 08-Jun-20 12:03 PM, Francesco wrote:
Hi all,
I upgraded an old DPDK-based app which was using DPDK 17.11 to latest DPDK
20.05 and I noticed that if I look at "top" I see that the VIRT memory
taken by my a
On 6/9/20 1:00 PM, Ananyev, Konstantin wrote:
>
>>
>> On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote:
>>> On Mon, 8 Jun 2020 17:46:40 +0100
>>> Bruce Richardson wrote:
>>>
Rather than continuing to recommend an 80-char line limit, let's take a
hint
from the Lin
On 09-Jun-20 12:14 PM, Tal Shnaiderman wrote:
Subject: [PATCH v7 04/11] eal/mem: extract common code for memseg list
initialization
All supported OS create memory segment lists (MSL) and reserve VA space
for them in a nearly identical way. Move common code into EAL private
functions to reduce du
Hi Konstantin, see below
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, June 9, 2020 2:23 PM
>
>
> >
> > /** Status of crypto operation */
> > @@ -121,6 +123,13 @@ struct rte_crypto_op {
> > struct rte_crypto_asym_op asym[0];
> > /**< Asymmetr
On Tue, Jun 09, 2020 at 04:40:28PM +0300, Andrew Rybchenko wrote:
> On 6/9/20 1:00 PM, Ananyev, Konstantin wrote:
> >
> >>
> >> On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote:
> >>> On Mon, 8 Jun 2020 17:46:40 +0100 Bruce Richardson
> >>> wrote:
> >>>
> Rather than contin
The intention is to produce a pcap with nanosecond precision when
timestamp offloading is activated on mlx5 NIC.
The packets forwarded by testpmd hold the raw counter but a pcap
requires a time unit. Assuming that the NIC clock is already synced
with external master clock, this patchset simply int
On Tue, 9 Jun 2020 14:36:10 +0100
"Burakov, Anatoly" wrote:
> On 03-Jun-20 12:03 AM, Dmitry Kozlyuk wrote:
> > All supported OS create memory segment lists (MSL) and reserve VA space
> > for them in a nearly identical way. Move common code into EAL private
> > functions to reduce duplication.
> >
Existing ethdev functions can read/write time from/to device but
they're all related to timesync and none of them can translate a raw
counter in real time unit which is usefull in a pdump application.
A new API is required because the conversion is derived from dev clock
info.
Signed-off-by: Pat
1 - 100 of 140 matches
Mail list logo
