Re: [dpdk-dev] [EXT] [PATCH v3 4/4] regexdev: implement regex rte level functions

2020-06-03 Thread Guy Kaneti
> -Original Message- > From: Ori Kam > Sent: Thursday, May 07, 2020 12:46 PM > To: Jerin Jacob Kollanukkaran ; > xiang.w.w...@intel.com > Cc: Guy Kaneti ; dev@dpdk.org; Pavan Nikhilesh > Bhagavatula ; shah...@mellanox.com; > hemant.agra...@nxp.com; op...@mellanox.com; al...@mellanox.com

Re: [dpdk-dev] [PATCH v1 2/3] common/mlx5: move netlink files under Linux directory

2020-06-03 Thread Ophir Munk
The suggested API rte_ether_format_addr() was added to v2 > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, May 27, 2020 7:41 PM > To: Ophir Munk > Cc: dev@dpdk.org; Matan Azrad > Subject: Re: [dpdk-dev] [PATCH v1 2/3] common/mlx5: move netlink files > under Linux direct

[dpdk-dev] net/iavf: add inner L4 hash for GTPU

2020-06-03 Thread Jeff Guo
Previous iavf only support inner ipv4 hash, this patch aims to enable inner tcp and udp hash for GTPU. Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_hash.c | 813 --- 1 file changed, 571 insertions(+), 242 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.

Re: [dpdk-dev] mlx5 & pdump: convert HW timestamps to nanoseconds

2020-06-03 Thread Slava Ovsiienko
> -Original Message- > From: PATRICK KEROULAS > Sent: Tuesday, June 2, 2020 22:18 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Vivien Didelot ; Shahaf > Shuler ; Raslan Darawsheh > ; Matan Azrad > Subject: Re: [dpdk-dev] mlx5 & pdump: convert HW timestamps to > nanoseconds > > On Tue, May

Re: [dpdk-dev] Questions Questions about hash function enum

2020-06-03 Thread oulijun
在 2020/6/3 1:13, Ferruh Yigit 写道: On 6/1/2020 2:31 AM, oulijun wrote: Hi Ferruh Yigit and others I am learning data structure defined by dpdk framework and I noticed a data structure definition below: enum rte_eth_hash_function { RTE_ETH_HASH_FUNCTION_DEFAULT = 0, RTE_ETH_H

Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item

2020-06-03 Thread Ori Kam
Hi Adrien, Great to hear from you again. > -Original Message- > From: Adrien Mazarguil > Sent: Tuesday, June 2, 2020 10:04 PM > To: Ori Kam > Cc: Andrew Rybchenko ; Dekel Peled > ; ferruh.yi...@intel.com; john.mcnam...@intel.com; > marko.kovace...@intel.com; Asaf Penso ; Matan Azrad > ;

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Olivier Matz
Hi, On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wrote: > On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev, Konstantin wrote: > > Hi Jerin, > > > > > > > > I also share Olivier's concern about consuming 3 bits in ol_flags > > > > > > for that feature. > > > > > > Can it probably

Re: [dpdk-dev] [PATCH v3 1/4] vhost: inroduce operation to get vDPA queue stats

2020-06-03 Thread Maxime Coquelin
Hi Matan, On 6/2/20 5:47 PM, Matan Azrad wrote: > The vDPA device offloads all the datapath of the vhost device to the HW > device. > > In order to expose to the user traffic information this patch > introduces new 3 APIs to get traffic statistics, the device statistics > name and to reset the st

[dpdk-dev] [PATCH v 2/4] net/hns3: fix VLAN strip configuration when setting a PVID

2020-06-03 Thread Wei Hu (Xavier)
From: Chengchang Tang Currently, based on hns3 PF device, hardware will strip 2 vlan tags when ULP calls rte_eth_dev_set_vlan_pvid API function to set a PVID whether vlan strip related offload is turned on by calling rte_eth_dev_configure or rte_eth_dev_set_vlan_offload API function. When reciev

[dpdk-dev] [PATCH v 1/4] net/hns3: remove unsupported VLAN capabilities

2020-06-03 Thread Wei Hu (Xavier)
From: Chengchang Tang This patch removes unsupported vlan capabilities to avoid misleading users. Fixes: a5475d61fa34 ("net/hns3: support VF") Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") Cc: sta...@dpdk.org Signed-off-by: Chengchang Tang Signed-off-by: Wei Hu (Xavier) ---

[dpdk-dev] [PATCH v 4/4] net/hns3: add checking tso segsz when sending TSO packets

2020-06-03 Thread Wei Hu (Xavier)
From: Hongbo Zheng Base on hns3 network engine, when the rte_eth_tx_burst API is called by Upper Level Process, if PKT_TX_TCP_SEG flag is set and tso_segsz is 0 in the input parameter structure rte_mbuf, hns3 PMD driver will process this packet as an non-TSO packet, otherwise hardware will enter

[dpdk-dev] [PATCH v 0/4] bugfixes for hns3 PMD driver

2020-06-03 Thread Wei Hu (Xavier)
This series are bugfixes for hns3 PMD driver. Chengchang Tang (2): net/hns3: remove unsupported VLAN capabilities net/hns3: fix VLAN strip configuration when setting a PVID Hongbo Zheng (1): net/hns3: add checking tso segsz when sending TSO packets Wei Hu (Xavier) (1): net/hns3: fix VLAN

[dpdk-dev] [PATCH v 3/4] net/hns3: fix VLAN tags report in Rx

2020-06-03 Thread Wei Hu (Xavier)
Currently, based on hns3 network engine, driver always reports the incoming packet's VLAN tags to the structure rte_mbuf those are the output parameter pointers in '.rx_pkt_burst' ops implementation function, and never reports PKT_RX_VLAN_STRIPPED flag to the structure rte_mbuf even if Upper Level

[dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-03 Thread Juraj Linkeš
Directive #include in gcc implementation searches for files in a standard list of system directories, which leads to a sporadici build error on Taishan arm machines: /tmp/openvpp-testing/dpdk/lib/librte_ethdev/rte_ethdev.h:4287:10: fatal error: rte_ethdev_core.h: No such file or directory #include

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-03 Thread Thomas Monjalon
20/05/2020 11:18, Andrey Vesnovaty: > This commit introduces extension of DPDK flow action API enabling > modification of single rte_flow_action. > > Motivation and example > === > Adding or removing one or more queues to RSS actions cloned in multiple > flow rules imposes per rule toll for curren

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-03 Thread Thomas Monjalon
03/06/2020 11:48, Juraj Linkeš: > Directive #include in gcc implementation searches for files > in a standard list of system directories, which leads to a sporadici > build error on Taishan arm machines: > /tmp/openvpp-testing/dpdk/lib/librte_ethdev/rte_ethdev.h:4287:10: > fatal error: rte_ethdev_

Re: [dpdk-dev] [PATCH v2 0/3] Linux specific files moved & split

2020-06-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Ophir Munk > Sent: Monday, June 1, 2020 8:51 AM > To: dev@dpdk.org; Matan Azrad > Cc: Ophir Munk > Subject: [dpdk-dev] [PATCH v2 0/3] Linux specific files moved & split > > v1: > Initial release > v2: > Following review comments. > > O

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-03 Thread Ananyev, Konstantin
> > Directive #include in gcc implementation searches for files > > in a standard list of system directories, which leads to a sporadici > > build error on Taishan arm machines: > > /tmp/openvpp-testing/dpdk/lib/librte_ethdev/rte_ethdev.h:4287:10: > > fatal error: rte_ethdev_core.h: > > No such f

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Ananyev, Konstantin
> > > > > > I also share Olivier's concern about consuming 3 bits in ol_flags > > > > > > for that feature. > > > > > > Can it probably be squeezed somehow? > > > > > > Let say we reserve one flag that this information is present or > > > > > > not, and > > > > > > re-use one of rx-only fields fo

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Nithin Dabilpuram
On Wed, Jun 03, 2020 at 10:28:44AM +0200, Olivier Matz wrote: > Hi, > > On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wrote: > > On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev, Konstantin wrote: > > > Hi Jerin, > > > > > > > > > > I also share Olivier's concern about consuming 3

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-03 Thread Juraj Linkeš
-Original Message- From: Thomas Monjalon Sent: Wednesday, June 3, 2020 12:17 PM To: Juraj Linkeš Cc: ferruh.yi...@intel.com; arybche...@solarflare.com; dev@dpdk.org Subject: Re: [PATCH] ethdev: fix dpdk gcc build on Arm 03/06/2020 11:48, Juraj Linkeš: > Directive #include in gcc impl

Re: [dpdk-dev] [RFC] add flow action context API

2020-06-03 Thread Jerin Jacob
On Wed, May 20, 2020 at 2:48 PM Andrey Vesnovaty wrote: > > This commit introduces extension of DPDK flow action API enabling > modification of single rte_flow_action. > > Motivation and example > === > Adding or removing one or more queues to RSS actions cloned in multiple > flow rules imposes pe

Re: [dpdk-dev] [PATCH 0/2] net/mlx5: add reclaim memory mode devarg

2020-06-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Monday, June 1, 2020 9:10 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: [PATCH 0/2] net/mlx5: add reclaim memory mode devarg > > Currently, when flow destroyed, some memory resources may sti

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Olivier Matz
Hi Nithin, On Wed, Jun 03, 2020 at 04:14:14PM +0530, Nithin Dabilpuram wrote: > On Wed, Jun 03, 2020 at 10:28:44AM +0200, Olivier Matz wrote: > > Hi, > > > > On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wrote: > > > On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev, Konstantin wrot

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-03 Thread Ferruh Yigit
On 6/3/2020 11:16 AM, Thomas Monjalon wrote: > 03/06/2020 11:48, Juraj Linkeš: >> Directive #include in gcc implementation searches for files >> in a standard list of system directories, which leads to a sporadici >> build error on Taishan arm machines: >> /tmp/openvpp-testing/dpdk/lib/librte_ethd

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-03 Thread Thomas Monjalon
03/06/2020 12:47, Juraj Linkeš: > From: Thomas Monjalon > What about #include ? > > I only changed the .h files since that was enough to fix the issue, but I'll > add that include as well. [...] > It needs to be backported, so these lines are required: > Fixes: 7f0a669e7b04 ("ethdev: add

Re: [dpdk-dev] [PATCH v6 02/11] eal: introduce internal wrappers for file operations

2020-06-03 Thread Neil Horman
On Wed, Jun 03, 2020 at 02:03:20AM +0300, Dmitry Kozlyuk wrote: > Introduce OS-independent wrappers in order to support common EAL code > on Unix and Windows: > > * eal_file_create: open an existing file. > * eal_file_open: create a file or open it if exists. > * eal_file_lock: lock or unlock an o

Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item

2020-06-03 Thread Dekel Peled
Hi, PSB. > -Original Message- > From: Ori Kam > Sent: Wednesday, June 3, 2020 11:16 AM > To: Adrien Mazarguil > Cc: Andrew Rybchenko ; Dekel Peled > ; ferruh.yi...@intel.com; > john.mcnam...@intel.com; marko.kovace...@intel.com; Asaf Penso > ; Matan Azrad ; Eli Britstein > ; dev@dpdk.org

Re: [dpdk-dev] [PATCH] net/mlx5: fix vectorized Rx burst termination

2020-06-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, June 2, 2020 6:51 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko > Subject: [PATCH] net/mlx5: fix vectorized Rx burst termination > > Maximum burst size of Vectorized Rx burst routine

Re: [dpdk-dev] [PATCH v6 02/11] eal: introduce internal wrappers for file operations

2020-06-03 Thread Dmitry Kozlyuk
On Wed, 3 Jun 2020 08:07:59 -0400 Neil Horman wrote: [snip] > > +int > > +eal_file_create(const char *path) > > +{ > > + int ret; > > + > > + ret = open(path, O_CREAT | O_RDWR, 0600); > > + if (ret < 0) > > + rte_errno = errno; > > + > > + return ret; > > +} > > + > You don't

[dpdk-dev] [PATCH 0/3] fixes for device event

2020-06-03 Thread wangyunjian
From: Yunjian Wang This series include three fixes patches for device event. Yunjian Wang (3): eal: fix memory leak when removing event_cb eal: fix remove incorrect event_cb eal: return error code when failure lib/librte_eal/common/eal_common_dev.c | 16 ++-- 1 file changed,

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Nithin Dabilpuram
On Wed, Jun 03, 2020 at 01:38:22PM +0200, Olivier Matz wrote: > Hi Nithin, > > On Wed, Jun 03, 2020 at 04:14:14PM +0530, Nithin Dabilpuram wrote: > > On Wed, Jun 03, 2020 at 10:28:44AM +0200, Olivier Matz wrote: > > > Hi, > > > > > > On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wro

[dpdk-dev] [PATCH 2/3] eal: fix remove incorrect event_cb

2020-06-03 Thread wangyunjian
From: Yunjian Wang When the device_name is NULL, it will remove the event_cb directly. We need to compare the 'cb_fn' and 'cb_arg' at the same time. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_eal/common/eal_co

[dpdk-dev] [PATCH 3/3] eal: return error code when failure

2020-06-03 Thread wangyunjian
From: Yunjian Wang Fix return value, using -EAGAIN instead of 0 when the callback is busy and using -ENOENT instead of 0 when the callback is not found. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_eal/common/ea

[dpdk-dev] [PATCH 1/3] eal: fix memory leak when removing event_cb

2020-06-03 Thread wangyunjian
From: Yunjian Wang The event_cb->dev_name is not freed when freeing event_cb, and this causes a memory leak. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_eal/common/eal_common_dev.c | 2 ++ 1 file changed, 2 ins

[dpdk-dev] [PATCH v3] test: test patch for checking patchwork auto delegation feature

2020-06-03 Thread Ferruh Yigit
From: Jerin Jacob This is a test patch to test patchwork auto delegation feature from git send email. Signed-off-by: Jerin Jacob --- README | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README b/README index 55df158642..adf7a7c314 100644 --- a/README +++ b/README @@ -9,3 +9,6 @@ API d

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-03 Thread Ferruh Yigit
On 6/2/2020 5:23 PM, Jerin Jacob wrote: > On Tue, Jun 2, 2020 at 8:27 PM Ferruh Yigit wrote: >> >> On 6/2/2020 1:27 PM, Jerin Jacob wrote: >>> On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: > I think, original discussion[1] on

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-03 Thread Jerin Jacob
On Wed, Jun 3, 2020 at 6:39 PM Ferruh Yigit wrote: > > On 6/2/2020 5:23 PM, Jerin Jacob wrote: > > On Tue, Jun 2, 2020 at 8:27 PM Ferruh Yigit wrote: > >> > >> On 6/2/2020 1:27 PM, Jerin Jacob wrote: > >>> On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: > > On 27/05/20 09:28 +,

Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm

2020-06-03 Thread Honnappa Nagarahalli
> > 03/06/2020 11:48, Juraj Linkeš: > > Directive #include in gcc implementation searches for files in > > a standard list of system directories, which leads to a sporadici > > build error on Taishan arm machines: > > /tmp/openvpp-testing/dpdk/lib/librte_ethdev/rte_ethdev.h:4287:10: > > fatal e

[dpdk-dev] [PATCH 0/8] add flow action map

2020-06-03 Thread Bernard Iremonger
Add map action to rte_flow API to map a Packet Classification type (pctype) to a flowtype for the i40e PMD. This feature requires changes to be made to the rte_flow code in librte_ethdev, testpmd and the i40e PMD. Bernard Iremonger (8): librte_ethdev: add new flow types and action librte_eth

[dpdk-dev] [PATCH 3/8] librte_ethdev: add map action

2020-06-03 Thread Bernard Iremonger
add MK_FLOW_ACTION(MAP, sizeof(struct rte_flow_action_map)) add case RTE_FLOW_ACTION_TYPE_MAP Signed-off-by: Bernard Iremonger --- lib/librte_ethdev/rte_flow.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c index 16

[dpdk-dev] [PATCH 2/8] librte_ethdev: add map filter type

2020-06-03 Thread Bernard Iremonger
add RTE_ETH_FILTER_MAP in rte_eth_ctrl.h Signed-off-by: Bernard Iremonger --- lib/librte_ethdev/rte_eth_ctrl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_eth_ctrl.h b/lib/librte_ethdev/rte_eth_ctrl.h index 1416c37..c9c0ea4 100644 --- a/lib/librte_ethdev/rte_eth_ctr

[dpdk-dev] [PATCH 1/8] librte_ethdev: add new flow types and action

2020-06-03 Thread Bernard Iremonger
In rte_flow.h: add RTE_FLOW_ITEM_TYPE_PCTYPE add RTE_FLOW_ITEM_TYPE_FLOWTYPE add RTE_FLOW_ACTION_TYPE_MAP add structs and masks for new flow types In rte_flow.rst: add items for pctype and flowtype add action for map Signed-off-by: Bernard Iremonger --- doc/guides/prog_guide/rte_flow.rst | 55 +

[dpdk-dev] [PATCH 6/8] net/i40e: add map functions

2020-06-03 Thread Bernard Iremonger
add i40e_map_conf_init() add i40e_config_map_filter() initialize map_config_list in pf call rte_pmd_i40e_flow_type_mapping_update() Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a

[dpdk-dev] [PATCH 4/8] app/testpmd: parse map actions

2020-06-03 Thread Bernard Iremonger
Parse map, pctype and flowtype on testpmd command line. In cmdline_flow.c add the following: ACTION_MAP ACTION_MAP_PCTYPE ACTION_MAP_FLOWTYPE add parse_vc_action_map() Update testpmd user guide with map action and sample map action rules. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdl

[dpdk-dev] [PATCH 5/8] net/i40e: add map filter

2020-06-03 Thread Bernard Iremonger
In i40e_ethdev.h add the following: struct i40e_map_filter struct i40e_rte_flow_map_conf Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.h | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethde

[dpdk-dev] [PATCH 7/8] net/i40e: parse map pattern and action

2020-06-03 Thread Bernard Iremonger
Parse the map pattern and action in i40e_flow.c Add the following functions: i40e_flow_parse_map_pattern() i40e_flow_parse_map_action() i40e_parse_map_filter() i40e_config_map_filter_set() i40e_config_map_filter_del() Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_flow.c | 196 +

[dpdk-dev] [PATCH 8/8] doc: release note

2020-06-03 Thread Bernard Iremonger
Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_20_08.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index 39064af..55eb32b 100644 --- a/doc/guides/rel_notes/release_20_

[dpdk-dev] [PATCH] net/octeontx2: fix dmac filtering

2020-06-03 Thread Harman Kalra
Issue has been observed where packets are getting dropped at DMAC filtering if a new dmac address is added before starting of port. Fixes: c43adf61682f ("net/octeontx2: add unicast MAC filter") Cc: sta...@dpdk.org Signed-off-by: Harman Kalra --- drivers/net/octeontx2/otx2_ethdev.h | 1 + dr

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Thomas Monjalon
03/06/2020 13:38, Olivier Matz: > On Wed, Jun 03, 2020 at 04:14:14PM +0530, Nithin Dabilpuram wrote: > > On Wed, Jun 03, 2020 at 10:28:44AM +0200, Olivier Matz wrote: > > > On Tue, Jun 02, 2020 at 07:55:37PM +0530, Nithin Dabilpuram wrote: > > > > On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev,

[dpdk-dev] [PATCH v1 0/8] mlx5 PMD multi OS support

2020-06-03 Thread Ophir Munk
This patch series is part of preparing mlx5 PMD to compile and run under multiple OSs. v1: Initial release Ophir Munk (8): net/mlx5: rename mlx5 ibv shared struct net/mlx5: add mlx5 Linux specific file with getter functions drivers: remove mlx5 protection domain dependency on ibv net/mlx5

[dpdk-dev] [PATCH v1 1/8] net/mlx5: rename mlx5 ibv shared struct

2020-06-03 Thread Ophir Munk
Replace all 'mlx5_ibv_shared' appearances with 'mlx5_dev_ctx_shared'. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 58 - drivers/net/mlx5/mlx5.h | 14 +- drivers/net/mlx5/mlx5_ethdev.c | 6 ++---

[dpdk-dev] [PATCH v1 2/8] net/mlx5: add mlx5 Linux specific file with getter functions

2020-06-03 Thread Ophir Munk
'ctx' type (field in 'struct mlx5_ctx_shared') is changed from 'struct ibv_context *' to 'void *'. 'ctx' members which are verbs dependent (e.g. device_name) will be accessed through getter functions which are added to a new file under Linux directory: linux/mlx5_os.c. Signed-off-by: Ophir Munk

[dpdk-dev] [PATCH v1 3/8] drivers: remove mlx5 protection domain dependency on ibv

2020-06-03 Thread Ophir Munk
Replace 'struct ibv_pd *' with 'void *' in struct mlx5_ctx_shared and all function calls in mlx5 PMD. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_mr.c | 24 drivers/common/mlx5/mlx5_common_mr.h | 6 +++--- drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v1 4/8] net/mlx5: remove attributes dependency on ibv and dv

2020-06-03 Thread Ophir Munk
Define 'struct mlx5_dev_attr' which is ibv and dv independent. It contains attribute that were originally contained in 'struct ibv_device_attr_ex' and 'struct mlx5dv_context dv_attr'. Add a new API mlx5_os_get_dev_attr() which fills in the new defined struct. Signed-off-by: Ophir Munk Acked-by: M

[dpdk-dev] [PATCH v1 5/8] net/mlx5: remove umem field dependency on dv

2020-06-03 Thread Ophir Munk
umem field is used in several structs. Its type 'struct mlx5dv_devx_umem *' is changed to 'void *'. This change will allow non-Linux OS compilations. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 18 ++ drivers/net/mlx5/mlx5.c |

[dpdk-dev] [PATCH v1 7/8] net/mlx5: add mlx5 header file specific to Linux

2020-06-03 Thread Ophir Munk
File drivers/net/linux/mlx5_os.h is added. It includes specific Linux definitions such as PCI driver flags, link state changes interrupts, link removal interrupts, etc. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/linux/mlx5_os.h

[dpdk-dev] [PATCH v1 8/8] net/mlx5: remove ibv dependency in spawn struct

2020-06-03 Thread Ophir Munk
1. Replace 'struct ibv_device *' with 'void *' in 'struct mlx5_dev_spawn_data'. Define a getter function to retrieve the device name. 2. Rename ibv_dev and ibv_port as phys_dev and phys_port respectively. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 64

[dpdk-dev] [PATCH v1 6/8] net/mlx5: refactor PCI probing under Linux

2020-06-03 Thread Ophir Munk
Refactor PCI probing related code. Move Linux specific functions (as well as verbs and dv related code) from mlx5.c file to linux/mlx5_os.c file. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 1794 + drivers/net/mlx5/m

[dpdk-dev] [PATCH] maintainers: update for interrupt subsystem

2020-06-03 Thread Harman Kalra
updating MAINTAINERS file for interrupt subsytem. Signed-off-by: Harman Kalra --- MAINTAINERS | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d2b286701..2f93e4aec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -181,7 +181,6 @@ F: app/tes

Re: [dpdk-dev] [PATCH v3 3/3] doc/guides: updated script usage for checking patches

2020-06-03 Thread Ferruh Yigit
On 6/2/2020 2:53 PM, Ciara Power wrote: > The contributor's guide includes the usage of both the checkpatches and > check-git-log scripts, which needed to be updated to reflect the now > standardised format. > > Signed-off-by: Ciara Power Acked-by: Ferruh Yigit

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-03 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Nithin Dabilpuram > Sent: Wednesday, June 3, 2020 15:52 > To: Olivier Matz > Cc: Ananyev, Konstantin ; Jerin Jacob > ; Dumitrescu, Cristian > ; Nithin Dabilpuram > ; Thomas Monjalon ; > Yigit, Ferruh ; Andrew Rybchenko > ; Ori Kam ; Burakov, >

Re: [dpdk-dev] [PATCH v3] test: test patch for checking patchwork auto delegation feature

2020-06-03 Thread Ali Alnubani
Hi Ferruh and Jerin, > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday, June 3, 2020 4:00 PM > To: ferruh.yi...@intel.com > Cc: dev@dpdk.org; Jerin Jacob > Subject: [dpdk-dev] [PATCH v3] test: test patch for checking patchwork auto > delegation feature > > Fro

Re: [dpdk-dev] [PATCH 2/2] net/pcap: add TODO for writing Tx HW timestamp

2020-06-03 Thread Ferruh Yigit
On 5/24/2020 2:38 AM, Stephen Hemminger wrote: > On Sat, 23 May 2020 13:21:30 -0400 > Vivien Didelot wrote: > >> In order to write a packet with hardware timestamp enabled into a >> PCAP file, we need to convert its device specific raw timestamp first. >> >> This might not be trivial since queryi

Re: [dpdk-dev] [PATCH 1/2] net/pcap: support software Tx nanosecond timestamp

2020-06-03 Thread Ferruh Yigit
On 5/23/2020 6:21 PM, Vivien Didelot wrote: > When capturing packets into a PCAP file, DPDK currently uses > microseconds for the timestamp. But libpcap supports interpreting > tv_usec as nanoseconds depending on the file timestamp precision. > > To support this, use PCAP_TSTAMP_PRECISION_NANO whe

Re: [dpdk-dev] [PATCH v3] test: test patch for checking patchwork auto delegation feature

2020-06-03 Thread Ferruh Yigit
On 6/3/2020 5:39 PM, Ali Alnubani wrote: > Hi Ferruh and Jerin, > >> -Original Message- >> From: dev On Behalf Of Ferruh Yigit >> Sent: Wednesday, June 3, 2020 4:00 PM >> To: ferruh.yi...@intel.com >> Cc: dev@dpdk.org; Jerin Jacob >> Subject: [dpdk-dev] [PATCH v3] test: test patch for ch

[dpdk-dev] 19.11.3 patches review and test

2020-06-03 Thread luca . boccassi
Hi all, Here is a list of patches targeted for stable release 19.11.3. The planned date for the final release is the 17th of June. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported val

Re: [dpdk-dev] [PATCH 1/2] net/pcap: support software Tx nanosecond timestamp

2020-06-03 Thread Stephen Hemminger
On Wed, 3 Jun 2020 18:50:51 +0100 Ferruh Yigit wrote: > On 5/23/2020 6:21 PM, Vivien Didelot wrote: > > When capturing packets into a PCAP file, DPDK currently uses > > microseconds for the timestamp. But libpcap supports interpreting > > tv_usec as nanoseconds depending on the file timestamp pre

[dpdk-dev] [RFC] app/test-regex: add RegEx test application.

2020-06-03 Thread Ori Kam
Following the new RegEx class [1]. There is a need to create a dedecated test application in order to validate this class and PMD. Unlike net device this application loads data from a file. This commit introduce the new RegEx test app. The basic app flow: 1. query probed RegEx device. 2. configu

Re: [dpdk-dev] [PATCH 1/2] net/pcap: support software Tx nanosecond timestamp

2020-06-03 Thread Stephen Hemminger
On Wed, 3 Jun 2020 16:26:52 -0400 Vivien Didelot wrote: > On Wed, 3 Jun 2020 13:11:39 -0700, Stephen Hemminger > wrote: > > On Wed, 3 Jun 2020 18:50:51 +0100 > > Ferruh Yigit wrote: > > > > > On 5/23/2020 6:21 PM, Vivien Didelot wrote: > > > > When capturing packets into a PCAP file, DPDK

Re: [dpdk-dev] [PATCH v1] net/axgbe: enable IEEE 1588 PTP support for axgbe

2020-06-03 Thread Somalapuram, Amaranath
[AMD Public Use] Acked-by: Somalapuram Amaranath -Original Message- From: Sebastian, Selwin Sent: Monday, June 1, 2020 6:28 PM To: dev@dpdk.org Cc: Somalapuram, Amaranath Subject: [PATCH v1] net/axgbe: enable IEEE 1588 PTP support for axgbe From: Selwin Sebastian Add ethdev APIs to

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for utility APIs

2020-06-03 Thread Somalapuram, Amaranath
[AMD Public Use] Acked-by: Somalapuram Amaranath -Original Message- From: Sebastian, Selwin Sent: Monday, June 1, 2020 7:27 PM To: dev@dpdk.org Cc: Somalapuram, Amaranath Subject: [PATCH v1] net/axgbe: add support for utility APIs From: Selwin Sebastian Add support for rx, tx queue

Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application.

2020-06-03 Thread Jerin Jacob
On Thu, Jun 4, 2020 at 2:59 AM Ori Kam wrote: > > Following the new RegEx class [1]. > There is a need to create a dedecated test application in order to > validate this class and PMD. > > Unlike net device this application loads data from a file. > > This commit introduce the new RegEx test app.

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for set MTU API

2020-06-03 Thread Somalapuram, Amaranath
[AMD Public Use] Acked-by: Somalapuram Amaranath -Original Message- From: Nandibasappa, Girish Sent: Monday, June 1, 2020 8:19 PM To: dev@dpdk.org Cc: Somalapuram, Amaranath Subject: [PATCH v1] net/axgbe: add support for set MTU API From: gnandiba This patch adds support for set_mtu

Re: [dpdk-dev] [PATCH v2] net/axgbe: add RSS reta/hash query and update

2020-06-03 Thread Somalapuram, Amaranath
[AMD Official Use Only - Internal Distribution Only] For series, Acked-by: Somalapuram Amaranath -Original Message- From: Namburu, Chandu-babu Sent: Friday, May 29, 2020 5:19 PM To: dev@dpdk.org Cc: Somalapuram, Amaranath Subject: [PATCH v2] net/axgbe: add RSS reta/hash query and updat

Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application.

2020-06-03 Thread Ori Kam
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Thursday, June 4, 2020 7:56 AM > Subject: Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application. > > On Thu, Jun 4, 2020 at 2:59 AM Ori Kam wrote: > > > > Following the new RegEx class [1]. > > There is a need to creat

Re: [dpdk-dev] [PATCH] net/octeontx2: fix dmac filtering

2020-06-03 Thread Sunil Kumar Kori
>-Original Message- >From: dev On Behalf Of Harman Kalra >Sent: Wednesday, June 3, 2020 8:22 PM >To: Jerin Kollanukkaran ; Nithin Kumar Dabilpuram >; Kiran Kumar Kokkilagadda > >Cc: dev@dpdk.org; Harman Kalra ; sta...@dpdk.org >Subject: [dpdk-dev] [PATCH] net/octeontx2: fix dmac filtering

Re: [dpdk-dev] [PATCH 0/8] add flow action map

2020-06-03 Thread Ori Kam
Hi Bernard, Can you please explain more what is the pctype, the flow type, What is the general idea beyond this patch set? How will the application uses it? is it only for i40? Thanks, Ori > -Original Message- > From: Bernard Iremonger > Sent: Wednesday, June 3, 2020 5:20 PM > To: dev@

[dpdk-dev] [PATCH] app/testpmd: fix passing negative parameter to strerror

2020-06-03 Thread Wei Hu (Xavier)
Currently, there are coverity defect warnings as blow: Coverity issue: In nic_stats_clear function: CID 290021 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) 5. negative_returns: ret is passed to a parameter that cannot be negative. CID 289974 (#1 of 1): Argument ca

Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application.

2020-06-03 Thread Jerin Jacob
On Thu, Jun 4, 2020 at 11:21 AM Ori Kam wrote: > > Hi Jerin, HI Ori, > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, June 4, 2020 7:56 AM > > Subject: Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application. > > > > On Thu, Jun 4, 2020 at 2:59 AM Ori Kam wrot