"No telemetry legacy support " prints pops up on all the default dpdk
applications now.
Is it worth to print? Since it using direct 'printf', we cannot even disable
through dynamic logging.
Is possible to remove that print at least, if non legacy telemetry init is
successful.
Thoughts?
On Thu, May 21, 2020 at 2:54 PM Burakov, Anatoly
wrote:
>
> On 19-May-20 8:43 AM, David Marchand wrote:
> > On Tue, May 19, 2020 at 5:42 AM wangyunjian wrote:
> >>
> >> From: Yunjian Wang
> >>
> >> The issue is that a file descriptor at 0 is a valid one. Currently
> >> the file not found, the re
> -Original Message-
> From: Peng, Yuan
> Sent: Friday, May 22, 2020 11:44 AM
> To: Guo, Jia ; Xing, Beilei ; Zhang,
> Qi Z ; Wu, Jingjing ; Yang,
> Qiming
> Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia
>
> Subject: RE: [dpdk-dev] net/iavf: fix invalid flow access
>
> Test-by Peng, Yuan
Hi, Guinan
I don't make sense for this commit log. Don't write like a test case. Please
use technical expression.
Qiming
> -Original Message-
> From: dev On Behalf Of Guinan Sun
> Sent: Friday, May 22, 2020 14:12
> To: dev@dpdk.org
> Cc: Zhao1, Wei ; Sun, GuinanX
> ; sta...@dpdk.org
> Su
On Fri, May 22, 2020 at 9:15 AM Jerin Kollanukkaran wrote:
>
> "No telemetry legacy support " prints pops up on all the default dpdk
> applications now.
> Is it worth to print? Since it using direct 'printf', we cannot even disable
> through dynamic logging.
> Is possible to remove that print at
Hi,
Do you copy the commit log of the other patch? I think this patch don't touch
any private API.
Qiming
> -Original Message-
> From: dev On Behalf Of Guinan Sun
> Sent: Friday, May 22, 2020 12:40
> To: dev@dpdk.org
> Cc: Zhao1, Wei ; Sun, GuinanX
> ; sta...@dpdk.org
> Subject: [dpdk-
22/05/2020 09:47, David Marchand:
> On Fri, May 22, 2020 at 9:15 AM Jerin Kollanukkaran
> wrote:
> >
> > "No telemetry legacy support " prints pops up on all the default dpdk
> > applications now.
> > Is it worth to print? Since it using direct 'printf', we cannot even
> > disable through dynam
在 2020/5/20 15:22, David Marchand 写道:
Hello,
On Wed, May 20, 2020 at 5:18 AM oulijun wrote:
I am using 20.05-rc2 version to test based on HNS3 NIC hardware, and
found that after starting l3fwd-power,
using ctrl+c cannot force quit. But I revert the patch(33666b4 service:
fix crash on
>
> As agreed in the DPDK tech board [1], after 20.05 release, patches must
> use C11 atomic operations semantics with the help of wrappers.
>
> [1] http://mails.dpdk.org/archives/dev/2020-April/165143.html
>
> Signed-off-by: Honnappa Nagarahalli
> Reviewed-by: Phil Yang
> Reviewed-by: Ruife
On 22-May-20 9:17 AM, oulijun wrote:
在 2020/5/20 15:22, David Marchand 写道:
Hello,
On Wed, May 20, 2020 at 5:18 AM oulijun wrote:
I am using 20.05-rc2 version to test based on HNS3 NIC hardware,
and
found that after starting l3fwd-power,
using ctrl+c cannot force quit. But I revert th
On 22/5/2020 9:17 AM, oulijun wrote:
在 2020/5/20 15:22, David Marchand 写道:
Hello,
On Wed, May 20, 2020 at 5:18 AM oulijun wrote:
I am using 20.05-rc2 version to test based on HNS3 NIC
hardware, and
found that after starting l3fwd-power,
using ctrl+c cannot force quit. But I revert
On 22/05/2020 06:59, Guinan Sun wrote:
> The driver type need to be checked in private API.
> The patch fixes the issue.
>
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Guinan Sun
> ---
> drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++
> 1 file c
On 05/22, Guinan Sun wrote:
>The driver type need to be checked in private API.
>The patch fixes the issue.
>
>Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Guinan Sun
>---
> drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++
> 1 file changed, 6 insertions(
On 05/21, Jeff Guo wrote:
>When hash init, the default rss rules would be added, while hash uninit,
>the default rss rules should be deleted. Add the missing part in the hash
>uninit process. Also add invalid flow checking func in iavf generic flow
>to avoid the error of "Cannot access memory at ad
From: Lijun Ou
When users set the length of rss hash key greater than the supported
length by hardware, the pmd driver should intercept and can not
configure the wrong key into the hardware.
Fixes: c37ca66f2b27 ("net/hns3: support RSS")
Cc: sta...@dpdk.org
Signed-off-by: Lijun Ou
Signed-off-by
From: Chengchang Tang
Currently, promiscuous mode configuration are not cleared during
unintialziation based on hns3 PF device. The residual entries may cause
unnecessary bandwidth usage.
So, we need clear the PF's promisc mode status during the uninit.
Fixes: a45fd0aa0ea1 ("net/hns3: fix Rx qu
From: Lijun Ou
Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to
enable/disable PMDs write to `rte_mbuf::hash::rss`. The hns3 PMD driver
already can notify the validity of `rte_mbuf::hash:rss` to the application
by enabling `PKT_RX_RSS_HASH` flag in `rte_mbuf::ol_flags`.
Fixes: 19a3
From: Chengchang Tang
In hns3 PMD driver, the vport id 0 denote PF, and the vport id 1 denote
the first VF device of the port.
This patch adds two macros named HNS3_PF_FUNC_ID and HNS3_1ST_VF_FUNC_ID,
and replaces this two numbers to improve code readability.
Signed-off-by: Chengchang Tang
Sig
Currently, when running testpmd application based on hns3 network engine
with csum fwd mode by "set fwd csum" command in the prompt line, sending
42 consecutive bytes of arp packets to network port with packets generator,
But in fact hardware can't send the arp packets and the related logs as
below
This series are improvement and bugfixes for hns3 PMD driver.
Chengchang Tang (2):
net/hns3: replace PF vport id zero with private macro
net/hns3: fix promiscuous config not clear for PF on uninit
Lijun Ou (2):
net/hns3: add RSS hash offload to port Rx configuration
net/hns3: fix key leng
On 05/21, Wei Zhao wrote:
>When we flush flow FDIR, all queues are disabled for FDIR.
>If FDIR rule is created again, then the flow list is empty,
>as it is the first time to create rule after flush fdir filter,
>so we need to enable FDIR for all queues. And also, disable FDIR
>for queues should be
Hi,
Now there is an official package manager in Windows:
https://devblogs.microsoft.com/commandline/windows-package-manager-preview/
Who wants to build a DPDK package?
Where the manifest should be hosted? We used to have a directory pkg/...
Hi, Guinan
> -Original Message-
> From: Sun, GuinanX
> Sent: Friday, May 22, 2020 2:12 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei ; Sun, GuinanX
> ; sta...@dpdk.org
> Subject: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter
>
> If some user set mac_ctrl_frame_fwd to 1 fr
Hi,
> -Original Message-
> From: Sun, GuinanX
> Sent: Friday, May 22, 2020 2:12 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei ; Sun, GuinanX
> ; sta...@dpdk.org
> Subject: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter
>
> If some user set mac_ctrl_frame_fwd to 1 from fc ops,
>-Original Message-
>From: David Marchand
>Sent: Friday 22 May 2020 08:47
>To: Jerin Kollanukkaran ; Richardson, Bruce
>; Power, Ciara
>Cc: Wiles, Keith ; Thomas Monjalon
>; dpdk-dev
>Subject: Re: No telemetry legacy support print
>
>On Fri, May 22, 2020 at 9:15 AM Jerin Kollanukkaran
On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:
> This series are improvement and bugfixes for hns3 PMD driver.
Hi Xavier,
We are planning to have the -rc4 this weekend and the release on Tuesday. So we
are literally a few days away from the release.
It is definitely not good idea to change the co
scheduler PMD uses its own hand-made peek functions
that directly access rte_ring internals.
As now rte_ring has an API for that type of functionality -
change scheduler PMD to use API provided by rte_ring.
Signed-off-by: Konstantin Ananyev
---
.../crypto/scheduler/scheduler_multicore.c| 28
>
> Testing if the ring is empty is as simple as comparing the producer and
> consumer pointers.
>
> In theory, this optimization reduces the number of potential cache misses
> from 3 to 2 by not having to read r->mask in rte_ring_count().
>
> The modification of this function were also discusse
>
> Fix coding style violations that checkpatch will complain about.
>
> Add missing "int" after "unsigned".
> Add missing spaces around "+=" and "+".
> Remove superfluous type cast of numerical constant.
>
> Suggested-by: Konstantin Ananyev
> Signed-off-by: Morten Brørup
> ---
Acked-by: Kons
This patch set converts all python scripts in the project to use
python3 only. This is due to python2 being EOL in January 2020.
One script not tested: ./config/arm/armv8_machine.py
Louise Kilheeney (9):
app/test-bbdev: support python3 only
usertools/dpdk-devbind: support python3 only
usert
Changed script to explicitly use python3 only.
Cc: Nicolas Chautru
Signed-off-by: Louise Kilheeney
---
app/test-bbdev/test-bbdev.py | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py
index 0194be046..50add4580
Changed script to explicitly use python3 only.
Cc: Kevin Laatz
Signed-off-by: Louise Kilheeney
---
usertools/dpdk-telemetry-client.py | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/usertools/dpdk-telemetry-client.py
b/usertools/dpdk-telemetry-client.py
i
Changed script to explicitly use python3 only.
Cc: Olivier Matz
Signed-off-by: Louise Kilheeney
---
app/test-cmdline/cmdline_test.py | 3 +--
app/test-cmdline/cmdline_test_data.py | 1 +
mk/rte.sdktest.mk | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff -
Changed script to explicitly use python3 only.
Signed-off-by: Louise Kilheeney
---
usertools/dpdk-devbind.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 40b4beea4..441301f2d 100755
--- a/usertools/dpdk-devbind.
Changed script to explicitly use python3 only.
Signed-off-by: Louise Kilheeney
---
app/test/autotest.py| 3 +--
app/test/autotest_data.py | 1 +
app/test/autotest_runner.py | 14 +++---
app/test/autotest_test_funcs.py | 1 +
mk/rte.sdktest.mk | 4 +
Changed script to explicitly use python3 only.
Signed-off-by: Louise Kilheeney
---
usertools/cpu_layout.py | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py
index 6f129b1db..89a48cec4 100755
--- a/usertools/cpu_layout.p
Changed script to explicitly use python3 only.
Cc: Neil Horman
Signed-off-by: Louise Kilheeney
---
usertools/dpdk-pmdinfo.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/usertools/dpdk-pmdinfo.py b/usertools/dpdk-pmdinfo.py
index 12f20735e..f5cd077f5 100755
--- a/user
Changed script to explicitly use python3 only.
Cc: Thomas Monjalon
Signed-off-by: Louise Kilheeney
---
config/arm/armv8_machine.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/config/arm/armv8_machine.py b/config/arm/armv8_machine.py
index 404866d2f..a0e6a8769 100755
---
Changed script to explicitly use python3 only.
Cc: Neil Horman
Cc: Ray Kinsella
Signed-off-by: Louise Kilheeney
---
devtools/update_version_map_abi.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/devtools/update_version_map_abi.py
b/devtools/update_version_map_abi.py
https://bugs.dpdk.org/show_bug.cgi?id=484
Bug ID: 484
Summary: rte_sched_subport_free function does not free subport
memory
Product: DPDK
Version: 19.11
Hardware: All
OS: All
Status: UNCONFIRMED
22/05/2020 15:23, Louise Kilheeney:
> Changed script to explicitly use python3 only.
What is the reason of this change?
> Cc: Thomas Monjalon
>
> Signed-off-by: Louise Kilheeney
> ---
> config/arm/armv8_machine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/conf
Initially, printf was used to indicate and error/warning resulting from
telemetry initialisation. This is now fixed to use EAL logs for
warnings, and the unnecessary printf for an error is removed.
Fixes: eeb486f3ba65 ("eal: add telemetry as dependency")
Fixes: dd6275a424ac ("telemetry: fix error
Fix grammar, spelling and formatting of DPDK 20.05 release notes.
Signed-off-by: John McNamara
---
doc/guides/rel_notes/release_20_05.rst | 264 +++--
1 file changed, 116 insertions(+), 148 deletions(-)
diff --git a/doc/guides/rel_notes/release_20_05.rst
b/doc/guide
since python 2 is EOL, Making these scripts to use python3-only,
it's part of a general update to have everything use python3.
This is already using python 3 and this makes it explicit.
Best Regards
Louise Kilheeney
-Original Message-
From: Thomas Monjalon
Sent: Friday 22 May 2020 14:
> Subject: [PATCH 3/3] lib: remind experimental status in library headers
>
> The following libraries are experimental, all of their functions can change or
> disappear:
>
> - librte_bbdev
> - librte_bpf
> - librte_compressdev
> - librte_fib
> - librte_flow_classify
> - librte_ipsec
> - librte_
On Fri, May 22, 2020 at 02:48:39PM +0100, Ciara Power wrote:
> Initially, printf was used to indicate and error/warning resulting from
> telemetry initialisation. This is now fixed to use EAL logs for
> warnings, and the unnecessary printf for an error is removed.
>
> Fixes: eeb486f3ba65 ("eal: ad
On 5/22/2020 6:59 AM, Guinan Sun wrote:
> The driver type need to be checked in private API.
> The patch fixes the issue.
>
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Guinan Sun
Reviewed-by: Ferruh Yigit
Note support for gcc 10 in the DPDK 20.05 release notes.
Signed-off-by: Kevin Traynor
---
Note: Reduced context so can apply before/after John's cleanup patch
---
doc/guides/rel_notes/release_20_05.rst | 3 +++
1 file changed, 3 insertions(+)
diff --git a/doc/guides/rel_notes/release_20_05.rst
On 22/05/2020 15:06, John McNamara wrote:
> Fix grammar, spelling and formatting of DPDK 20.05 release notes.
>
> Signed-off-by: John McNamara
> ---
> doc/guides/rel_notes/release_20_05.rst | 264
> +++--
> 1 file changed, 116 insertions(+), 148 deletions(-)
>
> dif
On 5/22/2020 3:20 AM, Xing, Beilei wrote:
>
>
>> -Original Message-
>> From: dev On Behalf Of Chen, Zhaoyan
>> Sent: Thursday, May 21, 2020 3:45 PM
>> To: dev@dpdk.org
>> Cc: Chen, Zhaoyan
>> Subject: [dpdk-dev] [PATCH v1]doc:Update i40e PMD firmware/driver
>> mapping table.
>
> Minor
Hi John,
>-Original Message-
>From: dev On Behalf Of John McNamara
>Sent: Friday 22 May 2020 15:06
>To: dev@dpdk.org
>Cc: tho...@monjalon.net; Mcnamara, John
>Subject: [dpdk-dev] [PATCH v1] doc: update release notes for 20.05
>
>Fix grammar, spelling and formatting of DPDK 20.05 release
The example shown for registering telemetry commands was previously
missing the help text parameter.
Fixes: 24cd1b529f35 ("doc: update telemetry guides")
Signed-off-by: Ciara Power
---
doc/guides/prog_guide/telemetry_lib.rst | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
On Fri, May 22, 2020 at 7:21 PM Ciara Power wrote:
>
> Initially, printf was used to indicate and error/warning resulting from
> telemetry initialisation. This is now fixed to use EAL logs for
> warnings, and the unnecessary printf for an error is removed.
>
> Fixes: eeb486f3ba65 ("eal: add teleme
On 22/05/2020 17:27, Ciara Power wrote:
The example shown for registering telemetry commands was previously
missing the help text parameter.
Fixes: 24cd1b529f35 ("doc: update telemetry guides")
Signed-off-by: Ciara Power
---
doc/guides/prog_guide/telemetry_lib.rst | 14 +-
1 fil
On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote:
> On Fri, May 22, 2020 at 7:21 PM Ciara Power wrote:
> >
> > Initially, printf was used to indicate and error/warning resulting from
> > telemetry initialisation. This is now fixed to use EAL logs for
> > warnings, and the unnecessary pr
On Fri, May 22, 2020 at 10:18 PM Bruce Richardson
wrote:
>
> On Fri, May 22, 2020 at 10:04:44PM +0530, Jerin Jacob wrote:
> > On Fri, May 22, 2020 at 7:21 PM Ciara Power wrote:
> > >
> > > Initially, printf was used to indicate and error/warning resulting from
> > > telemetry initialisation. This
From: Kalesh AP
These are two bug fixes observed during regression testing
with DPDK 20.05-rc3.
Please apply.
Kalesh AP (1):
net/bnxt: fix the check for validating??link speed
Rahul Gupta (1):
net/bnxt: performance fix for Arm
drivers/net/bnxt/bnxt.h| 1 +
drivers/net/bnxt/bnxt_
From: Rahul Gupta
Eliminate unnecessary rte_smp_wmb() before writing to request/completion
doorbells. Use rte_cio_wmb() memory barrier instead of rte_io_wmb() before
writing to tx/rx request queue doorbells and use rte_compiler_barrier()
before writing to tx/rx completion queue doorbells.
Fixes:
Hi, Tonghao
Thank you for the patch.
I suppose, the patch should be extended to encompass the routines:
- flow_dv_convert_action_mark
- flow_dv_convert_action_set_meta (done in the patch)
- flow_dv_validate_item_mark
- flow_dv_validate_item_mark
- flow_dv_validate_action_flag
- flow_dv_validate_ac
From: Kalesh AP
These are two bug fixes observed during regression testing
with DPDK 20.05-rc3.
Please apply.
V2: fixed commit message and added Reviewed-by tag.
Kalesh AP (1):
net/bnxt: fix the check for validating??link speed
Rahul Gupta (1):
net/bnxt: performance fix for Arm
drivers/
From: Rahul Gupta
Eliminate unnecessary rte_smp_wmb() before writing to request/completion
doorbells. Use rte_cio_wmb() memory barrier instead of rte_io_wmb() before
writing to tx/rx request queue doorbells and use rte_compiler_barrier()
before writing to tx/rx completion queue doorbells.
Fixes:
> > > > mlx5 part of libibverbs includes a ts-to-ns converter which takes the
> > > > instantaneous clock info. It's unused in dpdk so far. I've tested it in
> > > > the
> > > > device/port init routine and the result looks reliable. Since this
> > > > approach
> > > > looks very simple, compared
From: Jerin Jacob
Add tested Marvell integrated NIC platforms to v20.05 release notes.
Signed-off-by: Jerin Jacob
---
doc/guides/rel_notes/release_20_05.rst | 15 +++
1 file changed, 15 insertions(+)
diff --git a/doc/guides/rel_notes/release_20_05.rst
b/doc/guides/rel_notes/relea
https://bugs.dpdk.org/show_bug.cgi?id=485
Bug ID: 485
Summary: pipe_profile_check function have wrong argument size
Product: DPDK
Version: 19.11
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: major
From: Kalesh AP
bnxt PMD uses the macro BNXT_SUPPORTED_SPEEDS to validate
the user requested speed. But this has all the speed values
supported by the PMD and is not chip specific.
The check against this macro returns success when the user
tries set the speed to 100G on a port even if the chip d
From: Kalesh AP
bnxt PMD uses the macro BNXT_SUPPORTED_SPEEDS to validate
the user requested speed. But this has all the speed values
supported by the PMD and is not chip specific.
The check against this macro returns success when the user
tries set the speed to 100G on a port even if the chip d
When VFs configure the rss rule by virtchnl, it need to set bit mask into
the field selector for the protocol, then PF got the configure massage and
parse the field selector to the corresponding protocol field.
Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")
Signed-off-by: Jeff Guo
When VFs configure the rss rule by virtchnl, it need to set bit mask into
the field selector for the protocol, then PF got the configure massage and
parse the field selector to the corresponding protocol field.
Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")
Signed-off-by: Jeff Guo
On Fri, 22 May 2020 11:32:05 +0200
Thomas Monjalon wrote:
> Hi,
>
> Now there is an official package manager in Windows:
> https://devblogs.microsoft.com/commandline/windows-package-manager-preview/
>
> Who wants to build a DPDK package?
>
> Where the manifest should be hosted? We used to have
On Fri, May 22, 2020 at 10:26 AM Kalesh A P <
kalesh-anakkur.pura...@broadcom.com> wrote:
> From: Kalesh AP
>
> These are two bug fixes observed during regression testing
> with DPDK 20.05-rc3.
>
> Please apply.
>
Patches applied to dpdk-next-net-brcm. Thanks
>
> V2: fixed commit message and ad
We are freeing flow_stats a little early. This results in a
segfault when the driver accesses the members during cleanup.
Move the call to bnxt_free_flow_stats_info() to prevent this.
Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats")
Signed-off-by: Ajit Khaparde
---
drivers/net/
On 2020/5/22 19:20, Ferruh Yigit wrote:
On 5/22/2020 10:21 AM, Wei Hu (Xavier) wrote:
This series are improvement and bugfixes for hns3 PMD driver.
Hi Xavier,
We are planning to have the -rc4 this weekend and the release on Tuesday. So we
are literally a few days away from the release.
It
> -Original Message-
> From: Guo, Jia
> Sent: Saturday, May 23, 2020 7:18 AM
> To: Xing, Beilei ; Zhang, Qi Z ;
> Wu, Jingjing
> Cc: Ye, Xiaolong ; dev@dpdk.org; Guo, Jia
>
> Subject: [dpdk-dev] net/iavf: fix protocol field selector configure
>
> When VFs configure the rss rule by vi
Hi
> -Original Message-
> From: Zhao1, Wei
> Sent: Friday, May 22, 2020 5:47 PM
> To: Sun, GuinanX ; dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming ; Ye, Xiaolong
>
> Subject: RE: [PATCH] net/ixgbe: delete MAC control frame fwd in struct adapter
>
> Hi,
>
> > -Original Message
The mark code was too restrictive by disallowing a cfa_code of zero.
This code loosens the requirement and allows zero.
Fixes: b87abb2e55cb ("net/bnxt: support marking packet")
Signed-off-by: Mike Baucom
Reviewed-by: Kishore Padmanabha
---
drivers/net/bnxt/bnxt_rxr.c | 20 +---
On Fri, May 22, 2020 at 2:27 PM Ajit Khaparde
wrote:
> We are freeing flow_stats a little early. This results in a
> segfault when the driver accesses the members during cleanup.
> Move the call to bnxt_free_flow_stats_info() to prevent this.
>
> Fixes: 02a95625fe9c ("net/bnxt: add flow stats in
Fix incorrect MAC control frame forward.
Fix flow control status get.
---
v2 changes:
* Rebase.
* Split into two patches.
* Set fc mac_ctrl_frame_fwd by bit operation.
* Modify commit messge.
Guinan Sun (2):
net/ixgbe: fix incorrect MAC control frame forward
net/ixgbe: fix flow control status
mac_ctrl_frame_fwd shouldn't be cleared when port stop,
otherwise it will be inconsistent with the actual status.
This patch fixes the issue.
Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
Cc: sta...@dpdk.org
Signed-off-by: Guinan Sun
---
v2 changes:
* Modified commit messge.
-
mac_ctrl_frame_fwd assignment is missing, so
setting mac_ctrl_frame_fwd should be added in
ixgbe_flow_ctrl_get().
The patch fixes the issue.
Fixes: 56ea46a997b7 ("ethdev: retrieve flow control configuration")
Cc: sta...@dpdk.org
Signed-off-by: Guinan Sun
---
v2 changes:
* Set fc mac_ctrl_frame_f
https://bugs.dpdk.org/show_bug.cgi?id=477
Ajit Khaparde (ajit.khapa...@broadcom.com) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
80 matches
Mail list logo
