fix i40e bug for flow filter and add comment in doc.
Wei Zhao (3):
net/i40e: remove ARP type check for FDIR filter
doc: input set requirement of each pctype for FDIR
net/i40e: remove teardown when flush FDIR filter
doc/guides/nics/i40e.rst | 7 +++
drivers/net/i40e/i40e_flow.c | 5
I have try to enable ARP ethertype for FDIR filter,
it work well for ARP for FDIR filter, so delete it.
Bugzilla ID: 402
Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR")
Cc: sta...@dpdk.org
Signed-off-by: Wei Zhao
---
drivers/net/i40e/i40e_flow.c | 2 --
1 file changed, 2
Add input set requirement info to i40e doc.
Bugzilla ID: 403
Signed-off-by: Wei Zhao
---
doc/guides/nics/i40e.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 416b3904e..ad5f51c38 100644
--- a/doc/guides/nics/i40e.rst
+++ b/
When we flush FDIR filter, we can not call i40e_fdir_teardown()
function as it will free vsi used for FDIR, then the vsi->base_queue
will be freed from pf->qp_pool, but vsi->base_queue can only get
once when do dev init in i40e_pf_setup(). If we free it, it will
never be alloc again.
Bugzilla ID:
On 4/26/20 9:06 AM, Matan Azrad wrote:
>
>
> From: Maxime Coquelin
>> On 4/15/20 11:47 AM, Maxime Coquelin wrote:
>>>
>>>
>>> On 3/24/20 3:24 PM, Asaf Penso wrote:
From: Matan Azrad
Add support for the next 2 callbacks:
get_vfio_device_fd and get_notify_area.
Th
On 4/26/20 2:07 PM, Matan Azrad wrote:
> As a preparation to listen the virtqs status before the device is
> configured, manage the virtqs structures in array instead of list.
>
> Signed-off-by: Matan Azrad
> Acked-by: Viacheslav Ovsiienko
> ---
> drivers/vdpa/mlx5/mlx5_vdpa.c | 43 +++
Updating ARM v7 and v8 maintainer. Gavin is leaving Arm.
Signed-off-by: Ruifeng Wang
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4800f6884..1a8e39a25 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -259,12 +259,12 @@ F: ap
v10:
Rename the APIs of '_relaxed' suffix to 'rte_bit_relaxed_xx'.
v9:
1. Change '*addr = (*addr) | mask' to '*addr = val | mask'.
2. Move 'rte_bitops.h' from 'device' section to 'basic'
section in 'doxy-api-index.md'.
v8:
1. Change 'rte_pmd_bitops.h' to 'rte_bitops.h' allo
Bitwise operation APIs are defined and used in a lot of PMDs,
which caused a huge code duplication. To reduce duplication,
this patch consolidates them into a common API family.
Signed-off-by: Joyce Kong
Reviewed-by: Gavin Hu
Reviewed-by: Phil Yang
Acked-by: Morten Brørup
---
MAINTAINERS
Add test cases for setting bit, clearing bit, testing
and setting bit, testing and clearing bit operation.
Signed-off-by: Joyce Kong
Reviewed-by: Gavin Hu
Reviewed-by: Phil Yang
---
MAINTAINERS | 1 +
app/test/Makefile | 1 +
app/test/autotest_data.py | 6 ++
app/te
Remove its own bit operation APIs and use the common one,
this can reduce the code duplication largely.
Signed-off-by: Joyce Kong
Reviewed-by: Gavin Hu
---
drivers/net/hinic/Makefile| 1 +
drivers/net/hinic/base/hinic_compat.h | 33 +--
drivers/net/hinic/hin
Remove its own bit operation APIs and use the common one,
this can reduce the code duplication largely.
Signed-off-by: Joyce Kong
Reviewed-by: Gavin Hu
---
drivers/net/axgbe/axgbe_common.h | 29 +
drivers/net/axgbe/axgbe_ethdev.c | 14 +++---
drivers/net/axgb
From: Vamsi Attunuru
Current l2fwd application statically configures adjacent ports as
destination ports for forwarding the traffic.
Add a portmap option to pass the forwarding port pair mapping which allows
the user to configure forwarding port mapping.
If no portmap argument is specified, des
Remove its own bit operation APIs and use the common one,
this can reduce the code duplication largely.
Signed-off-by: Joyce Kong
Reviewed-by: Gavin Hu
---
drivers/net/bnx2x/bnx2x.c| 271 +--
drivers/net/bnx2x/bnx2x.h| 10 +-
drivers/net/bnx2x/ecore_sp.c
Remove its own bit operation APIs and use the common one,
this can reduce the code duplication largely.
Signed-off-by: Joyce Kong
Reviewed-by: Gavin Hu
---
drivers/net/qede/base/bcm_osal.c | 22 +
drivers/net/qede/base/bcm_osal.h | 14 -
drivers/net/qede/ba
On 2/28/20 4:32 PM, Jin Yu wrote:
> Decrease the code and make it easier to read. It's
> useful for understanding the inflight APIs and how
> packed ring works. Update the RST because the packed
> ring patch has been merged to QEMU master and ring_packed
> parameter changes to packed.
>
> Fixes
On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon wrote:
>
> 13/04/2020 16:21, xiangxia.m@gmail.com:
> > The order of mempool initiation affects mempool index in the
> > rte_mempool_ops_table. For example, when building APPs with:
> >
> > $ gcc -lrte_mempool_bucket -lrte_mempool_ring ...
> >
> >
On 3/18/20 4:31 AM, 王志克 wrote:
> Involve openvswitch group since this fix is highly coupled with OVS.
> welcome comment.
> At 2020-03-12 17:57:19, "Zhike Wang" wrote:
>> The vhost_user_read_cb() and rte_vhost_driver_unregister()
>> can be called at the same time by 2 threads, and may lead to de
Hi Marvin,
On 4/1/20 4:50 PM, Marvin Liu wrote:
> If Tx zero copy enabled, gpa to hpa mapping table is updated one by
> one. This will harm performance when guest memory backend using 2M
> hugepages. Now add cached mapping table which will sorted by using
> sequence. Address translation will first
On 4/21/20 10:59 AM, Roland Qi wrote:
> In process_slave_message_reply(), there is a
> possibility that receiving a peer close
> message instead of a real message response.
>
> this patch targeting to handle the peer close
> scenario and report the correct error message.
>
> Signed-off-by: Rol
On 4/23/20 6:54 PM, Phil Yang wrote:
> The rarp packet broadcast flag is synchronized with rte_atomic_XX APIs
> which is a full barrier, DMB, on aarch64. This patch optimized it with
> c11 atomic one-way barrier.
>
> Signed-off-by: Phil Yang
> Reviewed-by: Gavin Hu
> Reviewed-by: Honnappa Nag
On 4/24/20 5:39 AM, Joyce Kong wrote:
> In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend
> and backend are assumed to be implemented in software, that is they can
> run on identical CPUs in an SMP configuration.
> Thus a weak form of memory barriers like rte_smp_r/wmb, ot
On 4/24/20 5:39 AM, Joyce Kong wrote:
> In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend
> and backend are assumed to be implemented in software, that is they can
> run on identical CPUs in an SMP configuration.
> Thus a weak form of memory barriers like rte_smp_r/wmb, ot
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines.
"Major ABI versions are declared no more frequently than yearly.
Compatibility with the major ABI version is mandatory in subsequent
releases until a new major ABI versi
v3:
* Removed libabigail supressions in previous version.
* Clarified abi policy for only major abi versions in git commit.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 2 ++
drivers/common/iavf/rte_common_ia
>-Original Message-
>From: pbhagavat...@marvell.com
>Sent: Monday, April 27, 2020 1:30 PM
>To: Jerin Jacob Kollanukkaran ; tho...@monjalon.net;
>John McNamara ; Marko Kovacevic
>; Ori Kam ; Bruce
>Richardson ; Radu Nicolau
>; Akhil Goyal ; Tomasz
>Kantecki ; Sunil Kumar Kori
>; Pavan Nikhi
> -Original Message-
> From: Yigit, Ferruh
> Sent: Saturday, April 25, 2020 9:09 PM
> To: Dumitrescu, Cristian ; Nithin Dabilpuram
> ; Singh, Jasvinder ;
> Thomas Monjalon ; Andrew Rybchenko
>
> Cc: dev@dpdk.org; jer...@marvell.com; kka...@marvell.com; Nithin
> Dabilpuram
> Subject: Re
(replying this time to the list)
On 25/04/2020 17:04, Thomas Monjalon wrote:
> 16/04/2020 13:00, Kevin Laatz:
>> This patch adds CPU flags which will enable the detection of ISA
>> features available on more recent x86 based CPUs.
> [...]
>> --- a/devtools/libabigail.abignore
>> +++ b/devtools/lib
> (replying this time to the list)
>
> On 25/04/2020 17:04, Thomas Monjalon wrote:
> > 16/04/2020 13:00, Kevin Laatz:
> >> This patch adds CPU flags which will enable the detection of ISA
> >> features available on more recent x86 based CPUs.
> > [...]
> >> --- a/devtools/libabigail.abignore
> >
https://bugs.dpdk.org/show_bug.cgi?id=463
Bug ID: 463
Summary: In Mellanox MLX5 driver, NULL pointer access in
mlx5_ipool_malloc()
Product: DPDK
Version: unspecified
Hardware: ARM
OS: Linux
Statu
On 27/04/2020 10:31, Laatz, Kevin wrote:
>
>> (replying this time to the list)
>>
>> On 25/04/2020 17:04, Thomas Monjalon wrote:
>>> 16/04/2020 13:00, Kevin Laatz:
This patch adds CPU flags which will enable the detection of ISA
features available on more recent x86 based CPUs.
>>> [
On 27/04/2020 11:19, Sunil Kumar Kori wrote:
>> -Original Message-
>> From: pbhagavat...@marvell.com
[...]
>> @@ -67,6 +68,15 @@ static uint32_t l2fwd_enabled_port_mask = 0;
>> /* list of enabled ports */
>> static uint32_t l2fwd_dst_ports[RTE_MAX_ETHPORTS];
>>
>> +struct port_pair_params
Hi Stephen,
Some of your comments are addressed in the next patch, which reduces this code
copied from the existing telemetry library.
Some others I will fix for v5.
>From: Stephen Hemminger
>Sent: Friday 24 April 2020 16:30
>To: Power, Ciara
>Cc: dev@dpdk.org; Laatz, Kevin ; Pattan, Reshma
Signed-off-by: Ivan Dyukov
---
app/proc-info/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index abeca4aab..b1a025a36 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -685,7 +685,7 @@ show_port(void)
From: Thomas Monjalon
When querying the link informations, the link status is
a mandatory major information.
Other boolean values are supposed to be accurate:
- duplex mode (half/full)
- negotiation (auto/fixed)
This API update is making explicit that the link speed information
i
Signed-off-by: Ivan Dyukov
---
app/test-pmd/testpmd.c | 2 +-
app/test/test_pmd_perf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 99bacddbf..d4df23a93 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd
link_speed is uint32_t. There are no needs to convert it.
Signed-off-by: Ivan Dyukov
---
app/test-pmd/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 72f25d152..661297ddd 100644
--- a/app/test-pmd/config.c
+++ b
This is initial patchset which introduces UNKNOWN speed to dpdk
applications. Also it contains changes related to printf formating.
Patchset contains changes for app/ and doc/ folders.
examples/ folder will be provided later.
Signed-off-by: Ivan Dyukov
---
doc/guides/sample_app_ug/link_status_intr.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/guides/sample_app_ug/link_status_intr.rst
b/doc/guides/sample_app_ug/link_status_intr.rst
index 5283be8b7..6ebc707b7 100644
--- a/doc/guides/samp
Signed-off-by: Ivan Dyukov
---
app/proc-info/main.c | 7 ++-
app/test-pipeline/init.c | 14 --
app/test-pmd/config.c| 10 ++
app/test-pmd/testpmd.c | 4 +++-
app/test/test_pmd_perf.c | 4 +++-
5 files changed, 26 insertions(+), 13 deletions(-)
diff --git a/ap
https://bugs.dpdk.org/show_bug.cgi?id=464
Bug ID: 464
Summary: In test app running mbuf_autotest after running
service_autotest causes terminal to get stuck
Product: DPDK
Version: unspecified
Hardware: All
O
> On 27/04/2020 10:31, Laatz, Kevin wrote:
> >
> >> (replying this time to the list)
> >>
> >> On 25/04/2020 17:04, Thomas Monjalon wrote:
> >>> 16/04/2020 13:00, Kevin Laatz:
> This patch adds CPU flags which will enable the detection of ISA
> features available on more recent x86 based
>-Original Message-
>From: Andrzej Ostruszka [C]
>Sent: Monday, April 27, 2020 3:06 PM
>To: Sunil Kumar Kori ; Pavan Nikhilesh Bhagavatula
>; Jerin Jacob Kollanukkaran
>; tho...@monjalon.net; John McNamara
>; Marko Kovacevic
>; Ori Kam ; Bruce
>Richardson ; Radu Nicolau
>; Akhil Goyal ; To
From: Yunjian Wang
Zero is a valid fd. The fd won't be closed thus leading fd leak,
when it is zero.
Fixes: f234e5bd996d ("net/failsafe: register slaves Rx interrupts")
Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode")
Cc: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
driv
On 4/27/2020 7:14 AM, Kumar, Ravi1 wrote:
> [AMD Public Use]
>
> Acked-by: Ravi Kumar
>> -Original Message-
>> From: Somalapuram, Amaranath
>> Sent: Monday, April 27, 2020 11:42 AM
>> To: dev@dpdk.org
>> Cc: Kumar, Ravi1
>> Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp c
On 4/26/20 4:19 AM, Marvin Liu wrote:
> Add new devarg for virtio user device vectorized path selection. By
> default vectorized path is disabled.
>
> Signed-off-by: Marvin Liu
>
> diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
> index 902a1f0cf..d59add23e 100644
> --- a
On Wed, Apr 15, 2020 at 5:27 AM Ravi Kerur wrote:
>
> Hi Tonghao, Thanks, your patch works fine with HPET initialization. I will
> look into DPDK discussion which got started with your patch.
[update] patch applied:
http://git.dpdk.org/next/dpdk-next-net/commit/?id=9b41c276fd35fe3c0ed3fb0d9cf98a8
On 4/26/20 4:19 AM, Marvin Liu wrote:
> Move offload, xmit cleanup and packed xmit enqueue function to header
> file. These functions will be reused by packed ring vectorized path.
>
> Signed-off-by: Marvin Liu
>
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
On 27/04/20 18:44 +0800, wangyunjian wrote:
> From: Yunjian Wang
>
> Zero is a valid fd. The fd won't be closed thus leading fd leak,
> when it is zero.
>
> Fixes: f234e5bd996d ("net/failsafe: register slaves Rx interrupts")
> Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode")
>
On 4/26/20 4:19 AM, Marvin Liu wrote:
> Previously, virtio split ring vectorized path was enabled by default.
> This is not suitable for everyone because that path dose not follow
> virtio spec. Add new devarg for virtio vectorized path selection. By
> default vectorized path is disabled.
>
> S
On 26-Apr-20 2:55 AM, Haiyue Wang wrote:
The kernel module vfio-pci introduces the VF token to enable SR-IOV
support since 5.7.
The VF token can be set by a vfio-pci based PF driver and must be known
by the vfio-pci based VF driver in order to gain access to the device.
Signed-off-by: Haiyue Wa
On 4/26/20 4:19 AM, Marvin Liu wrote:
> Optimize packed ring Rx path with SIMD instructions. Solution of
> optimization is pretty like vhost, is that split path into batch and
> single functions. Batch function is further optimized by AVX512
> instructions. Also pad desc extra structure to 16 by
Hi Ferruh,
Do you want me to resubmit.
I see this below errors email:
From: ro...@bytheb.org
Test-Label: travis-robot
Test-Status:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fpatch%2F69359&data=02%7C01%7CAmaranath.Somalapuram%40amd.com%7C3c14b94fb68e492d035608d7
On 25/04/2020 01:36, Stephen Hemminger wrote:
> In recent Linux kernels, there is support for extended acknowledgement
> to netlink messages. This is quite useful for diagnosing errors
> in configuration in the kernel with TAP.
>
> Signed-off-by: Stephen Hemminger
> ---
[...]
> +#else
> +/*
> + *
>
> Replace Wenzhuo Lu, Alvin Zhang and Konstantin Ananyev
> with Wei Zhao and Jeff Guo.
>
> Signed-off-by: Wei Zhao
> ---
> MAINTAINERS | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d31a80929..7a57535ee 100644
> --- a/MAI
27/04/2020 10:03, Tonghao Zhang:
> On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon wrote:
> >
> > 13/04/2020 16:21, xiangxia.m@gmail.com:
> > > The order of mempool initiation affects mempool index in the
> > > rte_mempool_ops_table. For example, when building APPs with:
> > >
> > > $ gcc -lrt
On 25/04/2020 21:24, Stephen Hemminger wrote:
> While adding error handling to tap device, I noticed we already have two
> places rolling their own netlink message handling (tap and mlx5) and now
> with proposed IF proxy there is a third.
>
> Netlink is non-trivial and easy to get wrong and doing
On 25/04/2020 23:23, Thomas Monjalon wrote:
> From: Olivier Matz
>
> Change rte_mempool_populate_iova() and rte_mempool_populate_iova() to
> return 0 instead of -EINVAL when there is not enough room to store one
> object, as it can be helpful for applications to distinguish this
> specific cas
On 4/27/2020 2:28 AM, Wei Zhao wrote:
> Replace Wenzhuo Lu, Alvin Zhang and Konstantin Ananyev
> with Wei Zhao and Jeff Guo.
>
> Signed-off-by: Wei Zhao
Acked-by: Ferruh Yigit
On 4/26/20 4:19 AM, Marvin Liu wrote:
> Optimize packed ring Tx path like Rx path. Split Tx path into batch and
> single Tx functions. Batch function is further optimized by AVX512
> instructions.
>
> Signed-off-by: Marvin Liu
>
Reviewed-by: Maxime Coquelin
Thanks,
Maxime
Pointer was being dereferenced without NULL checking.
Coverity issue: 357768
Fixes: 8c8066ea6a7b ("trace: add trace mode configuration parameter")
Signed-off-by: Sunil Kumar Kori
---
lib/librte_eal/common/eal_common_trace_utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
On 4/27/2020 12:24 PM, Somalapuram, Amaranath wrote:
> Hi Ferruh,
>
> Do you want me to resubmit.
Hi Amaranath,
No need to send a new version.
>
> I see this below errors email:
>
> From: ro...@bytheb.org
>
> Test-Label: travis-robot
> Test-Status:
> https://nam11.safelinks.protection.outlo
On 04-Jan-20 1:33 AM, Stephen Hemminger wrote:
The mp action resources in malloc should be cleaned up via
rte_eal_cleanup.
Signed-off-by: Stephen Hemminger
---
Acked-by: Anatoly Burakov
--
Thanks,
Anatoly
On 04-Jan-20 1:33 AM, Stephen Hemminger wrote:
Resolves file descriptor left open after rte_eal_cleanup.
Signed-off-by: Stephen Hemminger
---
lib/librte_eal/linux/eal/eal.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal
On 04-Jan-20 1:33 AM, Stephen Hemminger wrote:
When rte_eal_cleanup is called the rte_mp_action for VFIO
should be freed.
Fixes: edf73dd33072 ("ipc: handle unsupported IPC in action register")
Cc: anatoly.bura...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
---
Acked-by: Ana
Eal common timer doesn't compile under Windows.
Compilation log:
error LNK2019:
unresolved external symbol nanosleep referenced in function
rte_delay_us_sleep
error LNK2019:
unresolved external symbol get_tsc_freq referenced in function set_tsc_freq
error LNK2019:
unresolved external symbol sleep
Implemented the needed Windows eal timer functions.
Signed-off-by: Fady Bader
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/windows/eal.c| 6 +++
lib/librte_eal/windows/eal_timer.c | 68 +
lib/librte_eal/windows/include/rte_o
This patchset splits OS dependent EAL timer functions and implements them for
windows.
v2:
* fixing styles and correctness errors
Depends-on: series-9374 ("Windows basic memory management")
Fady Bader (2):
timer: move from common to Unix directory
timer: support EAL functions on Windows
On Mon, Apr 27, 2020 at 2:04 PM Sunil Kumar Kori wrote:
>
> Pointer was being dereferenced without NULL checking.
>
> Coverity issue: 357768
>
> Fixes: 8c8066ea6a7b ("trace: add trace mode configuration parameter")
>
> Signed-off-by: Sunil Kumar Kori
> ---
> lib/librte_eal/common/eal_common_trac
27/04/2020 11:27, Ray Kinsella:
> On 25/04/2020 17:04, Thomas Monjalon wrote:
> > PS: Who is REALLY maintaining the ABI?
> > We really miss someone who carefully check all these things,
> > and take care of the doc and tooling.
>
> I would say that I am missing these changes to libabigail.ignore,
When rte api checks the Rx RSS distribution is enable but the RSS
hash is disabled, it will return an error.
Signed-off-by: Lijun Ou
---
lib/librte_ethdev/rte_ethdev.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
On Thu, 2020-04-23 at 14:38 -0300, Dan Gora wrote:
> On Thu, Apr 23, 2020 at 12:59 PM Luca Boccassi wrote:
> > > > /dev/urandom is basically only a different interface to the same
> > > > underlying mechanism.
> >
> > This is not the whole story though - while the end result when all
> > works is
On 4/27/20 3:34 PM, Lijun Ou wrote:
> When rte api checks the Rx RSS distribution is enable but the RSS
> hash is disabled, it will return an error.
>
> Signed-off-by: Lijun Ou
> ---
> lib/librte_ethdev/rte_ethdev.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/lib/librte_
On Mon, Apr 27, 2020 at 7:40 PM Thomas Monjalon wrote:
>
> 27/04/2020 10:03, Tonghao Zhang:
> > On Fri, Apr 17, 2020 at 6:27 AM Thomas Monjalon wrote:
> > >
> > > 13/04/2020 16:21, xiangxia.m@gmail.com:
> > > > The order of mempool initiation affects mempool index in the
> > > > rte_mempool_o
Ferruh Yigit writes:
> On 4/27/2020 12:24 PM, Somalapuram, Amaranath wrote:
>> Hi Ferruh,
>>
>> Do you want me to resubmit.
>
> Hi Amaranath,
>
> No need to send a new version.
>
>>
>> I see this below errors email:
>>
>> From: ro...@bytheb.org
>>
>> Test-Label: travis-robot
>> Test-Status:
Couple of fixes caught while checking OVS integration.
Extra bonus points for reviewers that will review the OVS series :-)
https://patchwork.ozlabs.org/project/openvswitch/list/?series=172917
--
David Marchand
David Marchand (3):
ring: fix build with -Wswitch-enum
eal: fix typo in endian c
Some popular vswitch implementation might use a gcc option that
complains about missing enums in switch statements.
Fix this by listing all possible values.
Fixes: 664ff4b1729b ("ring: introduce peek style API")
Signed-off-by: David Marchand
---
lib/librte_ring/rte_ring_peek.h | 8
1 f
Caught by code inspection, for little endian, RTE_LEXX macros should
provide rte_leXX_t type values.
Fixes: b75667ef9f7e ("eal: add static endianness conversion macros")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
---
lib/librte_eal/include/generic/rte_byteorder.h | 6 +++---
1 file chang
Building OVS with dpdk, sparse complains about 64-bit constant being
passed as a normal integer that can't fit it:
error: constant 0x is so big it is unsigned long
Fixes: ecbc8570131d ("ethdev: add PFCP header to flow API")
Signed-off-by: David Marchand
---
lib/librte_ethdev/rte
On 4/27/2020 1:49 PM, Andrew Rybchenko wrote:
> On 4/27/20 3:34 PM, Lijun Ou wrote:
>> When rte api checks the Rx RSS distribution is enable but the RSS
>> hash is disabled, it will return an error.
>>
>> Signed-off-by: Lijun Ou
>> ---
>> lib/librte_ethdev/rte_ethdev.c | 11 +++
>> 1 file
On 4/27/20 4:23 PM, David Marchand wrote:
> Building OVS with dpdk, sparse complains about 64-bit constant being
> passed as a normal integer that can't fit it:
> error: constant 0x is so big it is unsigned long
>
> Fixes: ecbc8570131d ("ethdev: add PFCP header to flow API")
>
> S
Hi,
We noticed that the implementation of rte_epoll_wait doesn't stopped on signal
such as SIGINT.
Is anyone know why?
If that on purpose and cannot be changed, how application can exit gracefully
when using rx interrupts for example.
Regards,
Liron
On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote:
> Building OVS with dpdk, sparse complains about 64-bit constant being
> passed as a normal integer that can't fit it:
> error: constant 0x is so big it is unsigned long
>
> Fixes: ecbc8570131d ("ethdev: add PFCP heade
On Mon, Apr 27, 2020 at 03:23:40PM +0200, David Marchand wrote:
> Caught by code inspection, for little endian, RTE_LEXX macros should
> provide rte_leXX_t type values.
>
> Fixes: b75667ef9f7e ("eal: add static endianness conversion macros")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand
On Mon, Apr 27, 2020 at 3:34 PM Bruce Richardson
wrote:
>
> On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote:
> > Building OVS with dpdk, sparse complains about 64-bit constant being
> > passed as a normal integer that can't fit it:
> > error: constant 0x is so big it
On 4/27/20 4:34 PM, Bruce Richardson wrote:
> On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote:
>> Building OVS with dpdk, sparse complains about 64-bit constant being
>> passed as a normal integer that can't fit it:
>> error: constant 0x is so big it is unsigned long
On Mon, Apr 27, 2020 at 3:39 PM Andrew Rybchenko
wrote:
>
> On 4/27/20 4:34 PM, Bruce Richardson wrote:
> > On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote:
> >> Building OVS with dpdk, sparse complains about 64-bit constant being
> >> passed as a normal integer that can't fit it:
>
On Mon, Apr 27, 2020 at 03:40:30PM +0200, David Marchand wrote:
> On Mon, Apr 27, 2020 at 3:39 PM Andrew Rybchenko
> wrote:
> >
> > On 4/27/20 4:34 PM, Bruce Richardson wrote:
> > > On Mon, Apr 27, 2020 at 03:23:41PM +0200, David Marchand wrote:
> > >> Building OVS with dpdk, sparse complains abou
Change references to abi 20.0.1 to use abi v21, see
https://doc.dpdk.org/guides/contributing/abi_policy.html#general-guidelines.
"Major ABI versions are declared no more frequently than yearly.
Compatibility with the major ABI version is mandatory in subsequent
releases until a new major ABI versi
v4:
* restored suppressions for v20.0.1 incorrectly removed in v3.
Ray Kinsella (1):
abi: change references to abi 20.0.1 to abi v21
MAINTAINERS | 2 ++
devtools/libabigail.abignore | 5 +
drivers/common/iavf
>-Original Message-
>From: David Marchand
>Sent: Monday, April 27, 2020 5:56 PM
>To: Sunil Kumar Kori
>Cc: Jerin Jacob Kollanukkaran ; dev
>Subject: [EXT] Re: [dpdk-dev] [PATCH] eal/trace: fix coverity issues
>
>External Email
>
>--
> -Original Message-
> From: dev On Behalf Of David Marchand
> Sent: Monday, April 27, 2020 2:37 PM
> To: Richardson, Bruce
> Cc: dev ; Ori Kam ; Thomas Monjalon
> ; Yigit, Ferruh
> ; Andrew Rybchenko ;
> Zhang, Xiao
> Subject: Re: [dpdk-dev] [PATCH 3/3] ethdev: fix build warning on
On Mon, Apr 27, 2020 at 3:46 PM Sunil Kumar Kori wrote:
>
> >-Original Message-
> >From: David Marchand
> >Sent: Monday, April 27, 2020 5:56 PM
> >To: Sunil Kumar Kori
> >Cc: Jerin Jacob Kollanukkaran ; dev
> >Subject: [EXT] Re: [dpdk-dev] [PATCH] eal/trace: fix coverity issues
> >
> >E
On 27/04/2020 13:31, Thomas Monjalon wrote:
> 27/04/2020 11:27, Ray Kinsella:
>> On 25/04/2020 17:04, Thomas Monjalon wrote:
>>> PS: Who is REALLY maintaining the ABI?
>>> We really miss someone who carefully check all these things,
>>> and take care of the doc and tooling.
>>
>> I would say tha
On 4/26/2020 10:22 AM, Wei Hu (Xavier) wrote:
> Hi, Ferruh Yigit
>
> On 2020/4/25 0:12, Ferruh Yigit wrote:
>> On 4/24/2020 12:07 PM, Wei Hu (Xavier) wrote:
>>> From: Chengwen Feng
>>>
>>> Currently, when running start/clear stats&xstats/stop command many times
>>> based on testpmd application, t
On Mon, Apr 27, 2020 at 3:47 PM Ananyev, Konstantin
wrote:
>
>
>
> > -Original Message-
> > From: dev On Behalf Of David Marchand
> > Sent: Monday, April 27, 2020 2:37 PM
> > To: Richardson, Bruce
> > Cc: dev ; Ori Kam ; Thomas Monjalon
> > ; Yigit, Ferruh
> > ; Andrew Rybchenko ;
> >
>-Original Message-
>From: David Marchand
>Sent: Monday, April 27, 2020 7:22 PM
>To: Sunil Kumar Kori
>Cc: Jerin Jacob Kollanukkaran ; dev
>Subject: Re: [EXT] Re: [dpdk-dev] [PATCH] eal/trace: fix coverity issues
>
>On Mon, Apr 27, 2020 at 3:46 PM Sunil Kumar Kori
>wrote:
>>
>> >-Or
When sending request messages to data plane pipelines, the
caller must free the memory allocated to request message on
receiving error response.
Coverity Issues: 357676, 357680, 357681, 357682, 357690, 357693, 357711,
357722, 357725, 357734, 357739, 357743, 357747,357762, 357766, 357787
Fixes: 6d
When sending request messages to data plane thread, the
caller must free the memory allocated to request message
on receiving error response.
Coverity Issue: 357717, 357772
Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline")
Signed-off-by: Jasvinder Singh
---
drivers/net
On 4/27/2020 3:00 PM, David Marchand wrote:
> On Mon, Apr 27, 2020 at 3:47 PM Ananyev, Konstantin
> wrote:
>>
>>
>>
>>> -Original Message-
>>> From: dev On Behalf Of David Marchand
>>> Sent: Monday, April 27, 2020 2:37 PM
>>> To: Richardson, Bruce
>>> Cc: dev ; Ori Kam ; Thomas Monjalon
1 - 100 of 183 matches
Mail list logo