Re: [dpdk-dev] [PATCH v2] app/test/test_distributor.c: prevent memory leakages from the pool

2020-04-15 Thread Sarosh Arif
Yes, I plan to work on them when I get time. On Wed, Apr 15, 2020 at 11:52 AM Lukasz Wojciechowski < l.wojciec...@partner.samsung.com> wrote: > > W dniu 15.04.2020 o 08:42, Sarosh Arif pisze: > > v2: > > remove double freeing of mbufs > > > > Signed-off-by: Sarosh Arif > > --- > > app/test/tes

Re: [dpdk-dev] [PATCH v2] app/test/test_distributor.c: prevent memory leakages from the pool

2020-04-15 Thread Lukasz Wojciechowski
W dniu 15.04.2020 o 09:06, Sarosh Arif pisze: > Yes, I plan to work on them when I get time. Great, please add me to CC. I would be glad to review it. > > On Wed, Apr 15, 2020 at 11:52 AM Lukasz Wojciechowski > > wrote: > > > W dniu 15.04.2020 o 08:4

Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-15 Thread Ye Xiaolong
Hi, Marvin On 04/14, Marvin Liu wrote: >When doing virtio device initialization, virtqueues will be reset in >server mode if ring type is packed. This will cause issue because queues >have been freed in the beginning of device initialization. > >Fix this issue by splitting device initial process a

Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-15 Thread Liu, Yong
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, April 15, 2020 3:24 PM > To: Liu, Yong > Cc: maxime.coque...@redhat.com; Wang, Zhihong > ; dev@dpdk.org; Ding, Xuan > > Subject: Re: [PATCH] net/virtio: fix crash when device reconnecting > > Hi, Marvin > > On 04/14, Marvi

Re: [dpdk-dev] [PATCH] vdpa/mlx5: set default queue indices

2020-04-15 Thread Maxime Coquelin
Hi Asaf, On 3/23/20 6:50 PM, Asaf Penso wrote: > The rte_vhost_get_vring_base function is being called to get the values > of last_avail_idx and last_used_idx. > These fields will not have the correct values in case the function > returns an error. > > Adding a check for the function return value

Re: [dpdk-dev] [PATCH 0/3] update ice switch base code

2020-04-15 Thread Ye Xiaolong
On 04/10, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Zhao1, Wei >> Sent: Friday, April 10, 2020 8:42 AM >> To: dev@dpdk.org >> Cc: Zhang, Qi Z ; Lu, Nannan ; >> Peng, Yuan >> Subject: [PATCH 0/3] update ice switch base code >> >> This patch set fix some ice base code bug of sw

Re: [dpdk-dev] [dpdk-dev v4 3/3] app/testpmd: add new types to RSS hash commands

2020-04-15 Thread Jeff Guo
hi, Ori On 4/14/2020 5:48 PM, Ori Kam wrote: Hi Jeff, PSB, Thanks, Ori -Original Message- From: Jeff Guo Sent: Tuesday, April 14, 2020 8:42 PM To: Ori Kam ; bernard.iremon...@intel.com; xiaolong...@intel.com; qi.z.zh...@intel.com Cc: dev@dpdk.org; jingjing...@intel.com; yahui@in

Re: [dpdk-dev] [PATCH dpdk-dev] rte_random: fix crash when random init

2020-04-15 Thread David Marchand
On Wed, Apr 15, 2020 at 8:01 AM Mattias Rönnblom wrote: > > On 2020-04-15 01:42, Tonghao Zhang wrote: > > On Tue, Apr 14, 2020 at 11:37 PM Mattias Rönnblom > > wrote: > >> On 2020-04-14 15:35, David Marchand wrote: > >>> On Tue, Apr 14, 2020 at 3:20 PM Mattias Rönnblom > >>> wrote: > On 202

[dpdk-dev] [dpdk-dev v5 3/3] app/testpmd: add new types to RSS hash commands

2020-04-15 Thread Jeff Guo
Add some new types, such as eth/l2-src-only/l2-dst-only/svlan/cvlan/ l2tpv3/esp/ah/pfcp types into RSS hash commands, it could be used to configure these rss input set by cmdline. Example testpmd commands are: Eth: testpmd>flow create 0 ingress pattern eth / ipv4 / end actions rss \ types

[dpdk-dev] [dpdk-dev v5 1/3] ethdev: add new RSS offload types

2020-04-15 Thread Jeff Guo
Defines some new RSS offload types for ETH/S_VLAN/C_VLAN/L2TPV3/ ESP/AH/PFCP/L2_SRC_ONLY/L2_DST_ONLY. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang --- v5->v4: rename ETH_RSS_ETH_XXX to ETH_RSS_L2_XXX. --- lib/librte_ethdev/rte_ethdev.h | 11 ++- 1 file changed, 10 insertions(+), 1 dele

[dpdk-dev] [dpdk-dev v5 2/3] net/iavf: add RSS configuration for VFs

2020-04-15 Thread Jeff Guo
The VF must be capable of configuring RSS. Add a virtchnl handler to parse a specific RSS configuration, and process the configuration for VFs, such as add or delete a RSS rule. Signed-off-by: Jeff Guo Reviewed-by: Qi Zhang --- v5->v4: rename eth to l2 and add a NUll pointer checking. --- doc/g

[dpdk-dev] [dpdk-dev v5 0/3] add RSS configuration for iavf

2020-04-15 Thread Jeff Guo
Because the VF must be capable of configuring RSS, so add RSS configuration for iavf, VFs could add or delete a RSS rule base on the PF's capability. The supported protocol rss input set as below. l2-src-only/ l2-dst-only/ svlan/ cvlan/ ipv4/ ipv6/ l3_src_only/ l3_dst_only/ l2tpv3/ esp/ ah/ pfcp/

[dpdk-dev] [PATCH v4 02/34] net/bnxt: update hwrm prep to use ptr

2020-04-15 Thread Venkat Duvvuru
From: Randy Schacher - Change HWRM_PREP to use pointer and use the full HWRM enum Signed-off-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 2 +- drivers/net/bnxt/bnxt_hwrm.c | 202 ++- 2 files changed, 103 insertio

[dpdk-dev] [PATCH v4 00/34] add support for host based flow table management

2020-04-15 Thread Venkat Duvvuru
This patchset introduces a new mechanism to allow host-memory based flow table management. This should allow higher flow scalability than what is currently supported. This new approach also defines a new rte_flow parser, and mapper which currently supports basic packet classification in receive pat

[dpdk-dev] [PATCH v4 04/34] net/bnxt: add initial tf core session open

2020-04-15 Thread Venkat Duvvuru
From: Michael Wildt - Add infrastructure support - Add tf_core open session support Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Venkat Duvvuru --- drivers/net/bnxt/Makefile| 8 + drivers/net/bnxt/bnxt.h

[dpdk-dev] [PATCH v4 03/34] net/bnxt: add truflow message handlers

2020-04-15 Thread Venkat Duvvuru
From: Pete Spreadborough - Add bnxt message functions for truflow APIs Signed-off-by: Pete Spreadborough Signed-off-by: Randy Schacher Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 83 drivers/n

[dpdk-dev] [PATCH v4 06/34] net/bnxt: add tf core session sram functions

2020-04-15 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow session resource support functionality - Add TruFlow session hw flush capability as well as sram support functions. - Add resource definitions for session pools. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde ---

[dpdk-dev] [PATCH v4 08/34] net/bnxt: add resource manager functionality

2020-04-15 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow RM functionality for resource handling - Update the TruFlow Resource Manager (RM) with resource support functions for debugging as well as resource cleanup. - Add support for Internal and external pools. Signed-off-by: Michael Wildt Reviewed-by: Randy Schache

[dpdk-dev] [PATCH v4 07/34] net/bnxt: add initial tf core resource mgmt support

2020-04-15 Thread Venkat Duvvuru
From: Shahaji Bhosle - Add TruFlow public API definitions for resources as well as RM infrastructure Signed-off-by: Shahaji Bhosle Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/Makefile |1 + drivers/net/bnxt/tf_core/tf_core.c| 40 + driv

[dpdk-dev] [PATCH v4 05/34] net/bnxt: add initial tf core session close support

2020-04-15 Thread Venkat Duvvuru
From: Michael Wildt - Add TruFlow session and resource support functions - Add Truflow session close API and related message support functions for both session and hw resources Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/Ma

[dpdk-dev] [PATCH v4 11/34] net/bnxt: add tf core table scope support

2020-04-15 Thread Venkat Duvvuru
From: Farah Smith - Added TruFlow Table public API - Added Table Scope capability including Table Type support code for setting and getting Table Types. Signed-off-by: Farah Smith Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnx

[dpdk-dev] [PATCH v4 13/34] net/bnxt: fetch SVIF information from the firmware

2020-04-15 Thread Venkat Duvvuru
SVIF (source virtual interface) is used to represent a physical port, physical function, or a virtual function. SVIF is compared during L2 context and exact match lookups in TX direction. SVIF is masked for port information during L2 context and exact match lookup in RX direction. Hence, driver nee

[dpdk-dev] [PATCH v4 09/34] net/bnxt: add tf core identifier support

2020-04-15 Thread Venkat Duvvuru
From: Farah Smith - Add TruFlow Identifier resource support - Add TruFlow public API for Identifier resources. - Add support code and stack for Identifier resource allocation control. Signed-off-by: Farah Smith Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt

[dpdk-dev] [PATCH v4 10/34] net/bnxt: add tf core TCAM support

2020-04-15 Thread Venkat Duvvuru
From: Shahaji Bhosle - Add TruFlow TCAM public API functions - Add TCAM support functions as well as public APIs. Signed-off-by: Shahaji Bhosle Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 163 +

[dpdk-dev] [PATCH v4 14/34] net/bnxt: fetch vnic info from DPDK port

2020-04-15 Thread Venkat Duvvuru
VNIC is needed for the driver to program the action record for rx flows. VNIC determines what receive rings to use to place the received packets. This patch introduces a routine that will convert a given dpdk port to VNIC. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by:

[dpdk-dev] [PATCH v4 15/34] net/bnxt: add devargs parameter for host memory based TRUFLOW feature

2020-04-15 Thread Venkat Duvvuru
This feature can be enabled by passing "-w :0d:00.0,host-based-truflow=1” to the DPDK application. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h| 4 ++- drivers/net/bnxt/bnxt_ethdev.c | 73 ++ 2 files ch

[dpdk-dev] [PATCH v4 12/34] net/bnxt: add EM/EEM functionality

2020-04-15 Thread Venkat Duvvuru
From: Pete Spreadborough - Add TruFlow flow memory support - Exact Match (EM) adds the capability to manage and manipulate data flows using on chip memory. - Extended Exact Match (EEM) behaves similarly to EM, but at a vastly increased scale by using host DDR, with performance tradeoff due

[dpdk-dev] [PATCH v4 16/34] net/bnxt: add support for ULP session manager init

2020-04-15 Thread Venkat Duvvuru
A ULP session will contain all the resources needed to support rte flow offloads. A session is initialized as part of rte_eth_device start. A DPDK application can have multiple interfaces which means rte_eth_device start will be called for each of these devices. ULP session manager will make sure t

[dpdk-dev] [PATCH v4 17/34] net/bnxt: add support for ULP session manager cleanup

2020-04-15 Thread Venkat Duvvuru
A ULP session will contain all the resources needed to support rte flow offloads. A session is initialized as part of rte_eth_device start. A DPDK application can have multiple interfaces which means rte_eth_device start will be called for each of these devices. ULP session manager will make sure t

[dpdk-dev] [PATCH v4 18/34] net/bnxt: add helper functions for blob/regfile ops

2020-04-15 Thread Venkat Duvvuru
From: Mike Baucom 1. blob routines for managing key/mask/result data 2. regfile routines for managing temporal data during flow construction Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Kha

[dpdk-dev] [PATCH v4 19/34] net/bnxt: add support to process action tables

2020-04-15 Thread Venkat Duvvuru
From: Mike Baucom This patch processes the action template. Iterates through the list of action info templates and processes it. Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson --- drivers/net/bnxt/Makefile

[dpdk-dev] [PATCH v4 20/34] net/bnxt: add support to process key tables

2020-04-15 Thread Venkat Duvvuru
From: Mike Baucom This patch creates the classifier table entries for a flow. Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c| 784

[dpdk-dev] [PATCH v4 24/34] net/bnxt: match rte flow actions with flow template actions

2020-04-15 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Takes act_bitmap generated from the rte_flow_actions 2. Iterates through the static act_bitmap list 3. Returns success if a match is found, otherwise an error Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by:

[dpdk-dev] [PATCH v4 25/34] net/bnxt: add support for rte flow item parsing

2020-04-15 Thread Venkat Duvvuru
From: Kishore Padmanabha 1. Registers a callback handler for each rte_flow_item type, if it is supported 2. Iterates through each rte_flow_item till RTE_FLOW_ITEM_TYPE_END 3. Invokes the header call back handler 4. Each header call back handler will populate the respective fields in hdr_fie

[dpdk-dev] [PATCH v4 23/34] net/bnxt: match rte flow items with flow template patterns

2020-04-15 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Takes hdr_bitmap generated from the rte_flow_items 2. Iterates through the static hdr_bitmap list 3. Returns success if a match is found, otherwise an error Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: La

[dpdk-dev] [PATCH v4 22/34] net/bnxt: add support to alloc and program key and act tbls

2020-04-15 Thread Venkat Duvvuru
From: Mike Baucom This patch does the following 1. Gets the action tables information from the action template id 2. Gets the class tables information from the class template id 3. Initializes the registry file 4. Allocates a flow id from the flow table 5. Process the class & action tables Signe

[dpdk-dev] [PATCH v4 21/34] net/bnxt: add support to free key and action tables

2020-04-15 Thread Venkat Duvvuru
From: Mike Baucom This patch does the following 1. Gets all the flow resources from the flow id 2. Frees all the table resources 3. Frees the flow in the flow table Signed-off-by: Mike Baucom Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Review

[dpdk-dev] [PATCH v4 28/34] net/bnxt: add support for rte flow validate driver hook

2020-04-15 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Validates rte_flow_create arguments 2. Parses rte_flow_item types 3. Parses rte_flow_action types 4. Calls ulp_matcher_pattern_match to see if the flow is supported 5. If there is a match, returns success otherwise failure Signed-off-by:

[dpdk-dev] [PATCH v4 30/34] net/bnxt: add support for rte flow flush driver hook

2020-04-15 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Gets the ulp session information from eth_dev 2. Fetches the rte_flow table associated with this session 3. Iterates through all the flows in the flow table 4. Calls ulp_mapper_resources_free which releases the key & action tables assoc

[dpdk-dev] [PATCH v4 29/34] net/bnxt: add support for rte flow destroy driver hook

2020-04-15 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Gets the ulp session information from eth_dev 2. Fetches the flow associated with the flow id from the flow table 3. Calls ulp_mapper_resources_free which releases the key & action tables associated with that flow Signed-off-by: Kishor

[dpdk-dev] [PATCH v4 26/34] net/bnxt: add support for rte flow action parsing

2020-04-15 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Registers a callback handler for each rte_flow_action type, if it is supported 2. Iterates through each rte_flow_action till RTE_FLOW_ACTION_TYPE_END 3. Invokes the action call back handler 4. Each action call back handler will populate

[dpdk-dev] [PATCH v4 27/34] net/bnxt: add support for rte flow create driver hook

2020-04-15 Thread Venkat Duvvuru
From: Kishore Padmanabha This patch does the following 1. Validates rte_flow_create arguments 2. Parses rte_flow_item types 3. Parses rte_flow_action types 4. Calls ulp_matcher_pattern_match to see if the flow is supported 5. If there is a match, calls ulp_mapper_flow_create to program key & a

[dpdk-dev] [PATCH v4 32/34] net/bnxt: disable vector mode when host based TRUFLOW is enabled

2020-04-15 Thread Venkat Duvvuru
If bp->truflow is not set then don't enable vector mode. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/driver

[dpdk-dev] [PATCH v4 34/34] net/bnxt: enable meson build on truflow code

2020-04-15 Thread Venkat Duvvuru
Include tf_ulp & tf_core directories and the files inside them. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/meson.build | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/net/bnxt/meson.buil

[dpdk-dev] [PATCH v4 33/34] net/bnxt: add support for injecting mark into packet’s mbuf

2020-04-15 Thread Venkat Duvvuru
When a flow is offloaded with MARK action (RTE_FLOW_ACTION_TYPE_MARK), each packet of that flow will have metadata set in its completion. This metadata will be used to fetch an index into a mark table where the actual MARK for that flow is stored. Fetch the MARK from the mark table and inject it in

[dpdk-dev] [PATCH v4 31/34] net/bnxt: register tf rte flow ops

2020-04-15 Thread Venkat Duvvuru
Register bnxt_ulp_rte_flow_ops when host based TRUFLOW is enabled. Signed-off-by: Venkat Duvvuru Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_ethdev.c | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v4 00/11] igc PMD

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang New PMD for Intel I225 NICs. Alvin Zhang (11): net/igc: add igc PMD net/igc: support device initialization net/igc: implement device base ops net/igc: support reception and transmission of packets net/igc: enable statistics net/igc: enable Rx queue interrupts net/

[dpdk-dev] [PATCH v4 04/11] net/igc: support reception and transmission of packets

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Below ops are added too: mac_addr_add mac_addr_remove mac_addr_set set_mc_addr_list mtu_set promiscuous_enable promiscuous_disable allmulticast_enable allmulticast_disable rx_queue_setup rx_queue_release rx_queue_count rx_descriptor_done rx_descriptor_status tx_descriptor_status

[dpdk-dev] [PATCH v4 03/11] net/igc: implement device base ops

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Bellow ops are implemented: dev_configure dev_start dev_stop dev_close dev_reset dev_set_link_up dev_set_link_down link_update fw_version_get dev_led_on dev_led_off Signed-off-by: Alvin Zhang V2: Modify codes according to comments. V3: Modify codes according to comments. V4:

[dpdk-dev] [PATCH v4 01/11] net/igc: add igc PMD

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Implement device detection and loading. Add igc driver guid docs. Signed-off-by: Alvin Zhang V2: 1) Update release note; 2) Modify codes according to comments. V3: 1) Fix secondary process hotplug fault; 2) Modify codes according to comments. V4: Modify codes accord

[dpdk-dev] [PATCH v4 08/11] net/igc: implement RSS API

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Below ops are added: reta_update reta_query rss_hash_update rss_hash_conf_get Signed-off-by: Alvin Zhang V4: Modify codes according to comments. --- doc/guides/nics/features/igc.ini | 2 + drivers/net/igc/igc_ethdev.c | 171 +++ driv

[dpdk-dev] [PATCH v4 05/11] net/igc: enable statistics

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Enable base statistics, extend statistics and per-queue statistics. Below ops are added: stats_get xstats_get xstats_get_by_id xstats_get_names_by_id xstats_get_names stats_reset xstats_reset queue_stats_mapping_set Signed-off-by: Alvin Zhang V2: Fix xstats_get_names_by_id i

[dpdk-dev] [PATCH v4 06/11] net/igc: enable Rx queue interrupts

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Setup NIC to generate MSI-X interrupts. Set the IVAR register to map interrupt causes to vectors. Implement interrupt enable/disable functions. Signed-off-by: Alvin Zhang V4: Modify codes according to comments. --- doc/guides/nics/features/igc.ini | 1 + drivers/net/igc/ig

[dpdk-dev] [PATCH v4 09/11] net/igc: implement feature of VLAN

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Below ops ware added: vlan_filter_set vlan_offload_set vlan_tpid_set vlan_strip_queue_set Signed-off-by: Alvin Zhang V2: Fix max packet length fault when extend vlan is enabled or disabled. V3: Fix queue vlan offload fault, update docs. V4: Modify codes according to comments.

[dpdk-dev] [PATCH v4 07/11] net/igc: implement flow control ops

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Update feature list too. Signed-off-by: Alvin Zhang V4: Modify codes according to comments. --- doc/guides/nics/features/igc.ini | 1 + drivers/net/igc/igc_ethdev.c | 121 +++ 2 files changed, 122 insertions(+) diff --git a/doc/guid

[dpdk-dev] [PATCH v4 11/11] net/igc: implement flow API

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang Below type of flows are supported: ether-type filter, 2-tuple filter, SYN filter, RSS. Update docs too. Signed-off-by: Alvin Zhang V2: Modify codes according to comments. V3: Remove legacy ether-type, 2-tuple and tcp SYN filters API, add some examples of creating flow. V4

[dpdk-dev] [PATCH v4 10/11] net/igc: implement MAC-loopback mode

2020-04-15 Thread alvinx . zhang
From: Alvin Zhang enable mac-loopback mode. Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.c | 23 +++ drivers/net/igc/igc_txrx.c | 3 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c index e2e427c

Re: [dpdk-dev] [PATCH v2 00/34] add support for host based flow table management

2020-04-15 Thread Venkat Duvvuru
On Tue, Apr 14, 2020 at 3:06 AM Thomas Monjalon wrote: > > 13/04/2020 21:39, Venkat Duvvuru: > > This patchset introduces a new mechanism to allow host-memory based > > flow table management. This should allow higher flow scalability > > than what is currently supported. This new approach also def

Re: [dpdk-dev] [PATCH] crypto/qat: support plain SHA1..SHA512 hashes

2020-04-15 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, April 14, 2020 1:24 PM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH] crypto/qat: support plain SHA1..SHA512 hashes > > This patch adds support for plain SHA-1, SHA-224, SH

[dpdk-dev] [PATCH v9] net/i40e: enable hash configuration in RSS flow

2020-04-15 Thread Chenxu Di
This patch supports: - Symmetric hash configuration - Hash input set configuration Signed-off-by: Chenxu Di --- v9: -Updated code about enable hash. --- doc/guides/nics/i40e.rst | 37 ++ doc/guides/rel_notes/release_20_05.rst | 2 + drivers/net/i40e/i40e_ethdev.c | 528

[dpdk-dev] [PATCH v3 0/4] aarch64 -> arm32 cross compilation support

2020-04-15 Thread Juraj Linkeš
Add support for arm32 cross build in meson and add aarch64 -> arm32 cross build to Travis. The patchset makes use of existing options in config/defconfig_arm-armv7a-linux-gcc a ports those to the meson build system. Tested here: https://travis-ci.com/github/jlinkes/dpdk/builds/160337737 The aa

[dpdk-dev] [PATCH v3 3/4] build: add arm32 meson cross file

2020-04-15 Thread Juraj Linkeš
Signed-off-by: Juraj Linkeš --- config/arm/arm_armv7a_linux_gcc | 17 + 1 file changed, 17 insertions(+) create mode 100644 config/arm/arm_armv7a_linux_gcc diff --git a/config/arm/arm_armv7a_linux_gcc b/config/arm/arm_armv7a_linux_gcc new file mode 100644 index 0..39566d

[dpdk-dev] [PATCH v3 4/4] ci: add aarch64 -> arm32 cross compiling jobs

2020-04-15 Thread Juraj Linkeš
Signed-off-by: Juraj Linkeš --- .ci/linux-build.sh | 7 ++- .travis.yml| 19 +++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index d500c4c00..991e61d08 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh

[dpdk-dev] [PATCH v3 1/4] build: port arm32 options from make to meson

2020-04-15 Thread Juraj Linkeš
config/defconfig_arm-armv7a-linux-gcc contains a number of CONFIG_RTE_LIBRTE_ options. Implement those in applicable meson.build files. Signed-off-by: Juraj Linkeš --- drivers/net/ark/meson.build | 6 ++ drivers/net/avp/meson.build | 5 + drivers/net/cxgbe/meson.build | 6 +

[dpdk-dev] [PATCH v3 2/4] build: add arm32 meson build flags

2020-04-15 Thread Juraj Linkeš
Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 135 +++-- 1 file changed, 74 insertions(+), 61 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 6e75e6d97..746113849 100644 --- a/config/arm/meson.build +++ b/conf

[dpdk-dev] [PATCH v5] crypto/aesni_mb: support DOCSIS AES-256

2020-04-15 Thread Mairtin o Loingsigh
This patch adds support for DOCSIS AES-256 when using AESNI-MB Signed-off-by: Mairtin o Loingsigh Acked-by: Pablo de Lara --- v2: Added IPSec MB version check v3: Added doc update v4: Added missing patch v5: Dropping test vector due to refactoring --- doc/guides/rel_notes/release_20_05.rst

Re: [dpdk-dev] 18.11.7 (LTS) patches review and test

2020-04-15 Thread Kevin Traynor
On 14/04/2020 12:40, Stokes, Ian wrote: > > >> -Original Message- >> From: Kevin Traynor >> Sent: Friday, March 20, 2020 7:34 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Akhil Goyal ; Ali Alnubani ; >> Walker, Benjamin ; David Christensen >> ; Hemant Agrawal ; >>

Re: [dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto

2020-04-15 Thread De Lara Guarch, Pablo
Hi Konstantin, Just a small comment. > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, April 3, 2020 4:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Ananyev, Konstantin > > Subject: [PATCH v2 1/2] crypto/aesni_mb: suppor

[dpdk-dev] [PATCH v4 0/8] add packed ring vectorized datapath

2020-04-15 Thread Marvin Liu
This patch set introduced vectorized datapath for packed ring. The size of packed ring descriptor is 16Bytes. Four batched descriptors are just placed into one cacheline. AVX512 instructions can well handle this kind of data. Packed ring TX datapath can fully transformed into vectorized datapath.

[dpdk-dev] [PATCH v4 4/8] net/virtio: reuse packed ring xmit functions

2020-04-15 Thread Marvin Liu
Move xmit offload and packed ring xmit enqueue function to header file. These functions will be reused by packed ring vectorized Tx function. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 965ce3dab..1d8135f4f 100644 --- a/drivers

[dpdk-dev] [PATCH v4 1/8] net/virtio: enable vectorized datapath

2020-04-15 Thread Marvin Liu
Previously, virtio split ring vectorized datapath is enabled as default. This is not suitable for everyone as that datapath not follow virtio spec. Add specific config for virtio vectorized datapath selection. This config will be also used for virtio packed ring. Signed-off-by: Marvin Liu diff -

[dpdk-dev] [PATCH v4 2/8] net/virtio-user: add vectorized datapath parameter

2020-04-15 Thread Marvin Liu
Add new parameter "vectorized" which can enable vectorized datapath explicitly. This parameter will work for both split ring and packed ring. When "vectorized" option is on, driver will check both compiling environment and running enviornment. Signed-off-by: Marvin Liu diff --git a/drivers/net/v

[dpdk-dev] [PATCH v4 3/8] net/virtio: add vectorized packed ring Rx function

2020-04-15 Thread Marvin Liu
Optimize packed ring Rx datapath when AVX512 enabled and mergeable buffer/Rx LRO offloading are not required. Solution of optimization is pretty like vhost, is that split datapath into batch and single functions. Batch function is further optimized by vector instructions. Also pad desc extra struct

Re: [dpdk-dev] [PATCH v2 2/2] test/crypto: add CPU crypto mode for AESNI MB

2020-04-15 Thread De Lara Guarch, Pablo
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, April 3, 2020 4:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Ananyev, Konstantin > > Subject: [PATCH v2 2/2] test/crypto: add CPU crypto mode for AESNI MB > > This pat

[dpdk-dev] [PATCH v4 6/8] eal/x86: identify AVX512 extensions flag

2020-04-15 Thread Marvin Liu
Read CPUID to check if AVX512 extensions are supported. Signed-off-by: Marvin Liu diff --git a/lib/librte_eal/common/arch/x86/rte_cpuflags.c b/lib/librte_eal/common/arch/x86/rte_cpuflags.c index 6492df556..54e9f6185 100644 --- a/lib/librte_eal/common/arch/x86/rte_cpuflags.c +++ b/lib/librte_eal

[dpdk-dev] [PATCH v4 5/8] net/virtio: add vectorized packed ring Tx datapath

2020-04-15 Thread Marvin Liu
Optimize packed ring Tx datapath alike Rx datapath. Split Tx datapath into batch and single Tx functions. Batch function further optimized by vector instructions. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 10e39670e..c9aa

[dpdk-dev] [PATCH v4 7/8] net/virtio: add election for vectorized datapath

2020-04-15 Thread Marvin Liu
Packed ring vectorized datapath will be selected when criterian matched. 1. vectorized option is enabled 2. AVX512F and required extensions are supported by compiler and host 3. virtio VERSION_1 and IN_ORDER features are negotiated 4. virtio mergeable feature is not negotiated 5. LRO offloading is

[dpdk-dev] [PATCH v4 8/8] doc: add packed vectorized datapath

2020-04-15 Thread Marvin Liu
Document packed virtqueue vectorized datapath selection logic in virtio net PMD. Add packed virtqueue vectorized datapath features to new ini file. Signed-off-by: Marvin Liu diff --git a/doc/guides/nics/features/virtio-packed_vec.ini b/doc/guides/nics/features/virtio-packed_vec.ini new file mod

Re: [dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto

2020-04-15 Thread De Lara Guarch, Pablo
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, April 3, 2020 4:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; De Lara Guarch, Pablo > ; Doherty, Declan > ; Ananyev, Konstantin > > Subject: [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto > > Add support for CP

Re: [dpdk-dev] [PATCH 1/2] test/crypto: add capability check

2020-04-15 Thread Dybkowski, AdamX
Hi Pablo, > -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, 14 April, 2020 12:23 > To: Doherty, Declan ; akhil.go...@nxp.com; > Zhang, Roy Fan ; tho...@monjalon.net > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH 1/2] test/crypto: add cap

Re: [dpdk-dev] [PATCH 1/2] test/crypto: add capability check

2020-04-15 Thread Dybkowski, AdamX
One more thing: > -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, 14 April, 2020 12:23 > To: Doherty, Declan ; akhil.go...@nxp.com; > Zhang, Roy Fan ; tho...@monjalon.net > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH 1/2] test/crypto: a

Re: [dpdk-dev] [PATCH v4 0/2] refactor multi-process IPC and memory management codes to common driver

2020-04-15 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Vu Pham > Sent: Tuesday, April 14, 2020 12:18 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Ori Kam > ; Matan Azrad ; Raslan > Darawsheh ; Vu Pham > Subject: [PATCH v4 0/2] refactor multi-process IPC and memory > management codes to common driver > > Cur

Re: [dpdk-dev] [PATCH] drivers: fix gcc 10 errors due to logtype var in header

2020-04-15 Thread Bruce Richardson
On Wed, Apr 15, 2020 at 08:29:16AM +0200, Lukasz Wojciechowski wrote: > > W dniu 10.04.2020 o 19:27, Bruce Richardson pisze: > > The zlib compression driver, as well as the aesni-gcm, aesni-mb and openssl > > crypto drivers all defined the logtype variable in the header file > > directly. This giv

Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-15 Thread Jerin Jacob
On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk wrote: > > Clang on Windows follows MS ABI where enum values are limited to 2^31-1. > Enum rte_page_size has members valued above this limit, which get > wrapped to zero, resulting in compilation error (duplicate values in > enum). Using MS ABI is man

Re: [dpdk-dev] [PATCH v3 10/10] eal/windows: implement basic memory management

2020-04-15 Thread Jerin Jacob
On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk wrote: > > Basic memory management supports core libraries and PMDs operating in > IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain > IOVAs of hugepages allocated from user-mode. > > Signed-off-by: Dmitry Kozlyuk > --- > config/me

Re: [dpdk-dev] [PATCH 1/4] vdpa/mlx5: move virtual doorbell alloc to probe

2020-04-15 Thread Maxime Coquelin
On 3/24/20 3:24 PM, Asaf Penso wrote: > From: Matan Azrad > > The configure and close operations may be called a lot of time by vhost > library according to the virtio connections in the guest. > > VAR is the device memory space for the virtio queues doorbells. > Each VAR page can be shared f

Re: [dpdk-dev] [PATCH 2/4] vdpa/mlx5: support direct HW notifications

2020-04-15 Thread Maxime Coquelin
On 3/24/20 3:24 PM, Asaf Penso wrote: > From: Matan Azrad > > Add support for the next 2 callbacks: > get_vfio_device_fd and get_notify_area. > > This will allow direct HW doorbell ringing from guest and will save CPU > usage in host. > > By this patch, the QEMU will map the physical address

Re: [dpdk-dev] [PATCH v2 04/16] telemetry: invert dependency on metrics

2020-04-15 Thread Power, Ciara
Hi Reshma, >> -Original Message- >> From: Power, Ciara >> +DEPDIRS-librte_metrics += librte_telemetry endif >> > > >> index 0f9f2e0e6f..d116857e2d 100644 >> --- a/lib/librte_metrics/meson.build >> +deps += ['ethdev', 'telemetry'] > >The telemetry dependency should be added under >CONF

Re: [dpdk-dev] [PATCH v9] net/i40e: enable hash configuration in RSS flow

2020-04-15 Thread Xing, Beilei
> -Original Message- > From: Di, ChenxuX > Sent: Wednesday, April 15, 2020 4:46 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Xing, Beilei > ; Di, ChenxuX > Subject: [PATCH v9] net/i40e: enable hash configuration in RSS flow > > This patch supports: > > - Symmetric hash configuration >

Re: [dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto

2020-04-15 Thread Ananyev, Konstantin
Hi Pablo, > > > > Add support for CPU crypto mode by introducing required handler. > > > > Signed-off-by: Konstantin Ananyev > > --- > > doc/guides/cryptodevs/aesni_mb.rst| 3 + > > doc/guides/cryptodevs/features/aesni_mb.ini | 1 + > > .../crypto/aesni_mb/aesni_mb_pmd_private.

Re: [dpdk-dev] [PATCH 3/4] vdpa/mlx5: validate notifier configuration

2020-04-15 Thread Maxime Coquelin
On 3/24/20 3:24 PM, Asaf Penso wrote: > From: Matan Azrad > > When both, direct and indirect notifier management cannot be > configured, return an error. > > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsiienko > --- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 30 ---

Re: [dpdk-dev] [PATCH v9] net/i40e: enable hash configuration in RSS flow

2020-04-15 Thread Ye Xiaolong
On 04/15, Xing, Beilei wrote: > > >> -Original Message- >> From: Di, ChenxuX >> Sent: Wednesday, April 15, 2020 4:46 PM >> To: dev@dpdk.org >> Cc: Yang, Qiming ; Xing, Beilei >> ; Di, ChenxuX >> Subject: [PATCH v9] net/i40e: enable hash configuration in RSS flow >> >> This patch supports

[dpdk-dev] eal: can not run secondary process on openstack environment

2020-04-15 Thread 陈亚辉-云杉研发部
dpdk version: 18.11 Ovs-dpdk runs as openvswitch account on the openstack environment. Use the root account to run another --proc-type=secondary program, such as dpdk-pdump or helloword with parameter --proc-type=secondary , and it will report an Err: Cannot open '/var/run/dpdk/rte/config' for rte

Re: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM

2020-04-15 Thread Dybkowski, AdamX
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, 14 April, 2020 12:23 > To: Doherty, Declan ; akhil.go...@nxp.com; > Zhang, Roy Fan ; tho...@monjalon.net > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for >

Re: [dpdk-dev] [PATCH 1/2] test/crypto: add capability check

2020-04-15 Thread Dybkowski, AdamX
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, 14 April, 2020 12:23 > To: Doherty, Declan ; akhil.go...@nxp.com; > Zhang, Roy Fan ; tho...@monjalon.net > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH 1/2] test/crypto: add capability che

Re: [dpdk-dev] [PATCH v2 1/2] test/crypto: add capability check

2020-04-15 Thread Dybkowski, AdamX
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, 14 April, 2020 12:36 > To: Doherty, Declan ; akhil.go...@nxp.com; > Zhang, Roy Fan ; tho...@monjalon.net > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH v2 1/2] test/crypto: add capability

Re: [dpdk-dev] [PATCH v2 2/2] test/crypto: do not check for IMB_VERSION_NUM

2020-04-15 Thread Dybkowski, AdamX
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, 14 April, 2020 12:36 > To: Doherty, Declan ; akhil.go...@nxp.com; > Zhang, Roy Fan ; tho...@monjalon.net > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH v2 2/2] test/crypto: do not check fo

Re: [dpdk-dev] [PATCH v3 2/2] test/crypto: do not check for internal PMD information

2020-04-15 Thread Dybkowski, AdamX
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, 14 April, 2020 19:41 > To: Doherty, Declan > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v3 2/2] test/crypto: do not check for internal > PMD information > > Now

Re: [dpdk-dev] [PATCH v3 1/2] test/crypto: add capability check

2020-04-15 Thread Dybkowski, AdamX
> -Original Message- > From: dev On Behalf Of Pablo de Lara > Sent: Tuesday, 14 April, 2020 19:41 > To: Doherty, Declan > Cc: dev@dpdk.org; akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v3 1/2] test/crypto: add capability check > > Check if test case is suppo

Re: [dpdk-dev] [PATCH v3 08/10] eal/windows: fix rte_page_sizes with Clang on Windows

2020-04-15 Thread Dmitry Kozlyuk
> On Wed, Apr 15, 2020 at 1:16 AM Dmitry Kozlyuk > wrote: > > > > Clang on Windows follows MS ABI where enum values are limited to 2^31-1. > > Enum rte_page_size has members valued above this limit, which get > > wrapped to zero, resulting in compilation error (duplicate values in > > enum). Usin

  1   2   3   >