From: Yunjian Wang
For the tap PMD, we should release mbufs and iovecs from the Rx queue when
closing device. In order to remove duplicated code, rte_pmd_tap_remove()
calls tap_dev_close().
Fixes: 0781f5762cfe ("net/tap: support segmented mbufs")
CC: sta...@dpdk.org
Signed-off-by: Yunjian Wang
From: Yunjian Wang
When the tap_write_mbufs() function return with break, mbuf was freed
without increasing num_packets, which could cause applications to free
the mbuf again. And the pmd_tx_burst() function should returns the
number of original packets it actually sent excluding tso mbufs.
Fixe
From: Yunjian Wang
This series include five fixes patches for tap PMD driver.
--
v4:
* Update some code suggested by Ferruh Yigit and Stephen Hemminger
* Update commit log
* Add fix leak of fds on failure
v3:
* Add fix close a vaild fd and netlink socket file descriptor check
before close
v2:
From: Yunjian Wang
Now the rxq->pool is mbuf concatenation, but its nb_segs is 1. When
conducting some sanity checks on the mbuf with debug enabled, it fails.
Fixes: 0781f5762cfe ("net/tap: support segmented mbufs")
CC: sta...@dpdk.org
Signed-off-by: Yunjian Wang
---
drivers/net/tap/rte_eth_t
From: Yunjian Wang
When eth_dev_tap_create() is failed, nlsk_fd and ka_fd won't be closed
thus leading fds leak. Zero is a valid fd. Ultimately leads to a valid
fd was closed by mistake.
Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing")
Fixes: cb7e68da630a ("net/tap: fix cleanup o
From: Yunjian Wang
The internal structure is freed and set to NULL in the
rte_eth_dev_release_port() and zero is a valid fd. Ultimately
leads to a valid fd was closed by mistake.
Fixes: 3101191c63ab ("net/tap: fix device removal when no queue exist")
CC: sta...@dpdk.org
Signed-off-by: Yunjian W
From: Nithin Dabilpuram
Some NIC hardware support shaper to work in packet mode i.e
shaping or ratelimiting traffic is in packets per second (PPS) as
opposed to default bytes per second (BPS). Hence this patch
adds support to configure shared or private shaper in packet mode,
provide rate in PPS
From: Nithin Dabilpuram
Since existing PMD's support shaper byte mode and scheduler
wfq byte mode, update the same in their port/level/node capabilities
that are added.
Signed-off-by: Nithin Dabilpuram
---
v1..v2:
- Newly included patch to change exiting pmd's with tm support of byte mode
to s
From: Nithin Dabilpuram
Add TM command to enable packet mode for all SP children
in non leaf node. This is a new command as
"add tm nonleaf node pktmode".
Also add support to shaper profile add command to take
packet mode parameter used to setup shaper in packet mode.
This adds an extra argument
From: Nithin Dabilpuram
This patch adds support to packet length adjust TM feature
for private shaper. It also adds support to packet mode
feature that applies both to private shaper and node DWRR
scheduling of SP children.
Signed-off-by: Nithin Dabilpuram
---
v1..v2:
- Newly included patch.
From: Jerin Jacob
Using graph traversal for packet processing is a proven architecture
that has been implemented in various open source libraries.
Graph architecture for packet processing enables abstracting the data
processing functions as “nodes” and “links” them together to create a
complex “
From: Jerin Jacob
Adding rte_node_register() API implementation includes allocating
memory for node object, check for duplicate node name and
add the allocated node to STAILQ node_list for future use.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signe
From: Jerin Jacob
Graph architecture abstracts the data processing functions as
"node" and "link" them together to create a complex "graph" to enable
reusable/modular data processing functions.
These APIs enables graph framework operations such as create, lookup,
dump and destroy on graph and no
From: Jerin Jacob
Adding node-specific API implementation like cloning node, updating
edges for the node, shrinking edges of a node, retrieving edges of a
node.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
lib/li
From: Jerin Jacob
Adding node debug API implementation support to dump
single or all the node objects to the given file.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
lib/librte_graph/Makefile | 1 +
From: Jerin Jacob
Adding support to create and populate the memory for graph reel.
This includes reserving the memory in the memzone, populating the nodes,
Allocating memory for node-specific streams to hold objects.
Once it is populated the reel memory contains the following sections.
+---
From: Jerin Jacob
Adding implementation for graph stats collection API. This API will
create a cluster for a specified node pattern and aggregate the node
runtime stats.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
--
From: Jerin Jacob
Adding graph specific API implementations like graph create
and graph destroy. This detect loops in the graph,
check for isolated nodes and operation to verify the validity of
graph.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signe
From: Jerin Jacob
Adding support for graph specific API implementation like
Graph lookup to get graph object, retrieving graph ID
>From name and graph name from ID.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
li
From: Jerin Jacob
Adding internal graph API helpers support to check whether a graph has
isolated nodes and any node have a loop to itself and BFS
algorithm implementation etc.
Signed-off-by: Jerin Jacob
Signed-off-by: Nithin Dabilpuram
---
lib/librte_graph/Makefile| 1 +
lib/librte
From: Jerin Jacob
Adding API implementation support exporting the graph object to file.
This will export the graph to a file in Graphviz format.
It can be viewed in many viewers such as
https://dreampuf.github.io/GraphvizOnline/
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-of
From: Jerin Jacob
Adding implementation for rte_graph_walk() API. This will perform a walk
on the circular buffer and call the process function of each node
and collect the stats if stats collection is enabled.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhil
From: Kiran Kumar K
Adding the unit test to test the functionality of node and graph APIs.
Testing includes registering a node, cloning a node, creating a graph,
perform graph walk, collecting stats and all node and graph debug APIs.
example command to test:
echo "graph_autotest" | sudo ./build/
From: Jerin Jacob
Adding implementation for graph specific API to dump the
Graph information to a file. This API will dump detailed internal
info about node objects and graph objects.
Signed-off-by: Jerin Jacob
Signed-off-by: Kiran Kumar K
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin
From: Pavan Nikhilesh
Add unit test framework to create and test performance of various graph
models.
example command to test:
echo "graph_perf_autotest" | sudo ./build/app/test/dpdk-test -c 0x30
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
app/test/Makefile
From: Nithin Dabilpuram
Add source rte_node ethdev_rx process function and register
it. This node is a source node that will be called periodically
and when called, performs rte_eth_rx_burst() on a specific
(port, queue) pair and enqueue them as stream of objects to
next node.
Signed-off-by: Nit
From: Nithin Dabilpuram
Add log infra for node specific logging.
Also, add null rte_node that just ignores all the objects
directed to it.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Kiran Kumar K
---
MAINTAINERS | 5 +
app/tes
From: Nithin Dabilpuram
Add ctrl api to setup ethdev_rx and ethdev_tx node.
This ctrl api clones 'N' number of ethdev_rx and ethdev_tx
nodes with specific (port, queue) pairs updated in their context.
All the ethdev ports and queues are setup before this api
is called.
Signed-off-by: Nithin Dabi
From: Nithin Dabilpuram
Add rte_node ethdev_tx process function and register it to
graph infra. This node has a specific (port, tx-queue) as context
and it enqueue's all the packets received to that specific queue pair.
When rte_eth_tx_burst() i.e enqueue to queue pair fails, packets
are forwarde
From: Nithin Dabilpuram
Add arm64 specific IPv4 lookup process function
for ip4_lookup node. This node performs LPM lookup
on every packet received and forwards it to a next
node that is identified by lookup result.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Kiran Kumar K
Signed-off-by: P
From: Kiran Kumar K
Add ip4 rewrite process function for ip4_rewrite
rte_node. On every packet received by this node,
header is overwritten with new data before forwarding
it to next node. Header data to overwrite with is
identified by next hop id passed in mbuf priv data
by previous node.
Signe
From: Pavan Nikhilesh
Add IPv4 lookup process function for ip4_lookup node.
This node performs LPM lookup using simple RTE_LPM API on every packet
received and forwards it to a next node that is identified by lookup
result.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nithin Dabilpuram
---
d
From: Pavan Nikhilesh
Add IPv4 lookup process function for ip4_lookup
rte_node. This node performs LPM lookup using x86_64
vector supported RTE_LPM API on every packet received
and forwards it to a next node that is identified by
lookup result.
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Nith
From: Nithin Dabilpuram
Add packet drop node process function for pkt_drop
rte_node. This node simply free's every object received as
an rte_mbuf to its rte_pktmbuf pool.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Pavan Nikhilesh
Signed-off-by: Kiran Kumar K
---
lib/librte_node/Makefile
From: Nithin Dabilpuram
Add ip4_rewrite and ip4_lookup ctrl API. ip4_lookup ctrl
API is used to add route entries for LPM lookup with
result data containing next hop id and next proto.
ip4_rewrite ctrl API is used to add rewrite data for
every next hop.
Signed-off-by: Nithin Dabilpuram
Signed-o
From: Nithin Dabilpuram
Adding the user guide for l3fwd graph application.
Signed-off-by: Nithin Dabilpuram
---
MAINTAINERS | 1 +
doc/guides/rel_notes/release_20_05.rst| 8 +
doc/guides/sample_app_ug/index.rst| 1 +
doc/guides/sample
From: Nithin Dabilpuram
Add graph creation, configuration logic and graph main loop.
This graph main loop is run on every slave lcore and calls
rte_graph_walk() to walk over lcore specific rte_graph.
Master core accumulates and prints graph walk stats of all the
lcore's graph's.
Signed-off-by: N
From: Nithin Dabilpuram
Add graph based l3fwd application skeleton with cmdline
parsing support inline with normal l3fwd.
Signed-off-by: Nithin Dabilpuram
---
MAINTAINERS | 3 +
examples/Makefile| 3 +
examples/l3fwd-graph/Makefile| 58
exampl
From: Nithin Dabilpuram
Add changes to ethdev port and queue configuration based
on command line parameters for l3fwd graph application.
Signed-off-by: Nithin Dabilpuram
---
examples/l3fwd-graph/main.c | 350 +++-
1 file changed, 349 insertions(+), 1 deletion(-)
On Fri, Apr 10, 2020 at 9:11 PM Jerin Jacob wrote:
>
> On Fri, Apr 10, 2020 at 11:48 AM Jerin Jacob wrote:
> >
>
> Three more items are missing in this patch
>
> 1) Unit test case for new API
> 2) Make the new API __rte_experimal
Hi Jerin
This API will be invoked in mempool, if use that prefix, t
On Sun, Apr 12, 2020 at 11:20 AM Tonghao Zhang wrote:
>
> On Fri, Apr 10, 2020 at 9:11 PM Jerin Jacob wrote:
> >
> > On Fri, Apr 10, 2020 at 11:48 AM Jerin Jacob wrote:
> > >
> >
> > Three more items are missing in this patch
Can I add "Co-authored-by" for you ?
> > 1) Unit test case for new AP
41 matches
Mail list logo
