Re: [dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-02-22 Thread Jerin Jacob
On Fri, Feb 21, 2020 at 9:44 PM Thomas Monjalon wrote: > > 21/02/2020 16:56, Jerin Jacob: > > On Fri, Feb 21, 2020 at 4:40 PM Thomas Monjalon wrote: > > > 21/02/2020 11:30, Jerin Jacob: > > > > On Mon, Feb 17, 2020 at 4:28 PM Jerin Jacob > > > > wrote: > > > > > On Mon, Feb 17, 2020 at 2:08 PM

Re: [dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-02-22 Thread Thomas Monjalon
22/02/2020 10:05, Jerin Jacob: > On Fri, Feb 21, 2020 at 9:44 PM Thomas Monjalon wrote: > > 21/02/2020 16:56, Jerin Jacob: > > > On Fri, Feb 21, 2020 at 4:40 PM Thomas Monjalon > > > wrote: > > > > 21/02/2020 11:30, Jerin Jacob: > > > > > On Mon, Feb 17, 2020 at 4:28 PM Jerin Jacob > > > > > w

Re: [dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-02-22 Thread Jerin Jacob
On Sat, Feb 22, 2020 at 3:23 PM Thomas Monjalon wrote: > > 22/02/2020 10:05, Jerin Jacob: > > On Fri, Feb 21, 2020 at 9:44 PM Thomas Monjalon wrote: > > > 21/02/2020 16:56, Jerin Jacob: > > > > On Fri, Feb 21, 2020 at 4:40 PM Thomas Monjalon > > > > wrote: > > > > > 21/02/2020 11:30, Jerin Jaco

Re: [dpdk-dev] [PATCH v2] pmdinfogen: add SPDX license tag

2020-02-22 Thread Thomas Monjalon
27/09/2019 10:39, Hemant Agrawal: > This patch adds SPDX license tag to pmdinfogen files. > > These files are originally drived from kernel. > They are being used as binary tool to support internal > build. > > This patch requires license exception approval from > DPDK Technical Board and Governi

Re: [dpdk-dev] [PATCH 3/5] devtools: add SPDX tag to load-devel-config

2020-02-22 Thread Thomas Monjalon
04/12/2019 16:55, Stephen Hemminger: > Trivial file was missing any license. > > Signed-off-by: Stephen Hemminger Acked-by: Thomas Monjalon Applied, thanks

Re: [dpdk-dev] [PATCH v2] add top level SPDX license identifier.

2020-02-22 Thread Thomas Monjalon
28/11/2019 08:05, Hemant Agrawal: > This patch adds top level SPDX license identifiers for some of the dpdk > source and scripts, where the copyright owners have not yet agreed to > replace the full BSD-3 license plate. > > This patch also add SPDX license tag for some of files with no > previous

Re: [dpdk-dev] [PATCH v3] cmdline: increase maximum line length

2020-02-22 Thread David Marchand
This patch is flagged as an ABI breakage: https://travis-ci.com/ovsrobot/dpdk/jobs/289313318#L2273 On Thu, Feb 20, 2020 at 3:53 PM Wisam Jaddo wrote: > > This increase due to the usage of cmdline in dpdk applications > as config commands such as testpmd do for rte_flow rules creation. > > The cu

Re: [dpdk-dev] [PATCH v3] devtools: add new SPDX license compliance checker

2020-02-22 Thread Thomas Monjalon
07/02/2020 18:52, Stephen Hemminger: > Simple script to look for drivers and scripts that > are missing requires SPDX header. > > Signed-off-by: Stephen Hemminger > --- > devtools/spdx-check.sh | 24 For consistency with other scripts, it should be named check-spdx.sh P

Re: [dpdk-dev] [PATCH v3] devtools: add new SPDX license compliance checker

2020-02-22 Thread Thomas Monjalon
07/02/2020 18:52, Stephen Hemminger: > Simple script to look for drivers and scripts that > are missing requires SPDX header. > > Signed-off-by: Stephen Hemminger [...] > +git grep -L SPDX-License-Identifier -- \ > +':^.git*' ':^.ci/*' ':^.travis.yml' \ > +':^README' ':^MAINTAINERS' ':^VE

Re: [dpdk-dev] [PATCH v3] regexdev: introduce regexdev subsystem

2020-02-22 Thread Jerin Jacob
> diff --git a/lib/librte_regexdev/rte_regexdev.h > b/lib/librte_regexdev/rte_regexdev.h > new file mode 100644 > index 000..c42128b > --- /dev/null > +++ b/lib/librte_regexdev/rte_regexdev.h > @@ -0,0 +1,1411 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C) 2019 Marvell Inter

Re: [dpdk-dev] [PATCH v2] devtools: check c99 comment use in checkpatches.sh

2020-02-22 Thread Thomas Monjalon
15/02/2020 18:09, Lance Richardson: > C99-style comments are not permitted according to DPDK coding > style guidelines, enable checking for these by checkpatch.pl. > > Signed-off-by: Lance Richardson Applied, thanks

Re: [dpdk-dev] [PATCH v2] devtools: add EditorConfig file

2020-02-22 Thread Thomas Monjalon
25/10/2019 16:04, Robin Jarry: > EditorConfig is a file format and collection of text editor plugins for > maintaining consistent coding styles between different editors and IDEs. > > Initialize the file following the coding rules in > doc/guides/contributing/coding_style.rst, > doc/guides/contrib

Re: [dpdk-dev] [PATCH] devtools: export title syntax for check-git-log

2020-02-22 Thread Thomas Monjalon
Hi, Sorry for not looking at this patch before. 25/10/2019 11:59, Sean Morrissey: > Moved title syntax to a separate file so that it improves code readability > and allows for easy addition of new correct title syntax in future cases. I think it is a good idea for a reason which is not said here

Re: [dpdk-dev] [PATCH 1/2] devtools: standardize script arguments

2020-02-22 Thread Thomas Monjalon
Hi, Thanks for improving tooling. 28/01/2020 16:02, Ciara Power: > range=${1:-origin/master..} If doing a real option management, range should be the remaining argument after option parsing. > +if [ "$range" = '--help' ] ; then > + print_usage Missing "exit 0" after usage. > # convert -N

Re: [dpdk-dev] [PATCH 2/2] devtools: added stats print

2020-02-22 Thread Thomas Monjalon
28/01/2020 16:02, Ciara Power: > When all checks are completed on the specified commit logs, the script > indicates if all are valid, or if there were some failures. I think the most important would be to have an error code. Please could you exit with 0 only if no issue is found? [...] > +total=$(

[dpdk-dev] [dpdk-announce] release candidate 20.02-rc4

2020-02-22 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v20.02-rc4 76 patches were integrated. This is small enough to be confident about closing 20.02 soon. The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_20_02.html Please add yo

[dpdk-dev] Question about vhost user interrupt mode

2020-02-22 Thread Yifeng Sun
Hi all, Right now on OVS, dpdkvhostuser can only run in polling mode (please correct me if I am wrong). We are trying to enable interrupt mode of dpdkvhostuser type port on OVS. We found that, with changes below, OVS can poll&block on exposed kickfd and vhostuser is working under interrupt mode wi