Re: [dpdk-dev] [PATCH 1/2] common/mlx5: fix ABI version

2020-02-12 Thread David Marchand
On Tue, Feb 11, 2020 at 8:48 PM Matan Azrad wrote: > > Changed the ABI version to 20.0.1. > > Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") > > Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko Series applied, thanks. -- David Marchand

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix txonly flow generation entropy

2020-02-12 Thread Ferruh Yigit
On 2/11/2020 7:57 PM, Slava Ovsiienko wrote: > Hi, Ferruh > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, February 10, 2020 16:02 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Thomas Monjalon ; >> bernard.iremon...@intel.com; sta...@dpdk.org >> Subject: Re: [dpdk-stable] [PA

Re: [dpdk-dev] [PATCH v3 1/2] net/virtio: refactor devargs parsing

2020-02-12 Thread Maxime Coquelin
On 2/7/20 12:25 PM, Ivan Dyukov wrote: > refactor vdpa specific devargs parsing to more generic way > > Signed-off-by: Ivan Dyukov > --- > drivers/net/virtio/virtio_ethdev.c | 35 +- > 1 file changed, 25 insertions(+), 10 deletions(-) > Reviewed-by: Maxime Coquel

[dpdk-dev] [PATCH v1 0/2] one way barrier for split vring idx

2020-02-12 Thread Joyce Kong
The similar changes for the packed ring were measured 10% performance lift and were merged. [1] In principle, less restrictive barriers generate better performance. However, no real performance lift was measured with the split ring on the limited number of existing HW implementations, the reason ma

[dpdk-dev] [PATCH v1 1/2] virtio: one way barrier for split vring used idx

2020-02-12 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

[dpdk-dev] [PATCH v1 2/2] virtio: one way barrier for split vring avail idx

2020-02-12 Thread Joyce Kong
In case VIRTIO_F_ORDER_PLATFORM(36) is not negotiated, then the frontend and backend are assumed to be implemented in software, that is they can run on identical CPUs in an SMP configuration. Thus a weak form of memory barriers like rte_smp_r/wmb, other than rte_cio_r/wmb, is sufficient for this ca

Re: [dpdk-dev] [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Xu, Rosen
Hi, I find some build error in patchwork. > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, February 12, 2020 10:00 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Matan Azrad > ; Shahaf Shuler ; > Viacheslav Ovsiienko ; Xu, Rosen > ; Zhang, Tianfei > Subject: [PATCH v4 1/6]

Re: [dpdk-dev] [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Thomas Monjalon
12/02/2020 10:26, Xu, Rosen: > I find some build error in patchwork. This is a failure in the unit tests, probably unrelated: https://lab.dpdk.org/results/dashboard/patchsets/9573/ This is the error message: buildtools/meson.build:6:0: ERROR: Program(s) ['pkg-config', 'pkg

Re: [dpdk-dev] [PATCH 1/2] config: deduplicate options

2020-02-12 Thread David Marchand
On Wed, Feb 12, 2020 at 12:57 AM Thomas Monjalon wrote: > > Some config options are overwritten with the same value > as the one inherited from its template parent. > Such duplicates which have no meaningful comments are removed. > > Signed-off-by: Thomas Monjalon > --- > config/common_armv8a_li

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg

2020-02-12 Thread Maxime Coquelin
On 2/7/20 12:25 PM, Ivan Dyukov wrote: > Some applications like pktgen use link_speed to calculate > transmit rate. It limits outcome traffic to hardcoded 10G. > > This patch adds link_speed devarg which allows to configure > link_speed of virtio device. > > Signed-off-by: Ivan Dyukov > --- >

Re: [dpdk-dev] [PATCH 2/2] devtools: enable more config options in build test

2020-02-12 Thread David Marchand
On Wed, Feb 12, 2020 at 12:57 AM Thomas Monjalon wrote: > > The Linux kernel modules kni and igb_uio were disabled by default > so they need a new option (+kmods) for testing compilation. > > Some recent features were not enabled in compilation testing: > - mlx5 vDPA (depends on libibverbs

Re: [dpdk-dev] [PATCH v2] crypto/ccp: enable IOMMU for CCP

2020-02-12 Thread Akhil Goyal
> > Is it a fix or a new feature? > It’s a new feature > If it is a fix then only it should be sent to stable and the patch title > should include > "crypto/ccp: fix ...". > Ok got it.. next time will keep in mind. > If it is a feature(which is more likely the case IMO), the title is fine or I

Re: [dpdk-dev] [PATCH] vhost: fix the inflight resubmit check

2020-02-12 Thread Maxime Coquelin
On 12/25/19 3:18 PM, Jin Yu wrote: > The frontend may not send the get_inflight_fd and > set_inflight_fd although we negotiate the protocol > feature. When we meet this situation just return OK. > > Fixes: ad0a4ae491fe ("vhost: checkout resubmit inflight information") > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list

2020-02-12 Thread Akhil Goyal
Hi Anoob, > > >> > > >> Hi Anoob, > > >> > > >> What is the difference between "Inline crypto" in that document and > > >> this "Inline protocol"? Both seems providing same outpout. > > > > > > [Anoob] Yes. It is partly because the description of "inline crypto" is > > > not > > accurate. The feat

Re: [dpdk-dev] [PATCH v8] app/testpmd: add portlist option

2020-02-12 Thread Govindharajan, Hariprasad
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, February 11, 2020 4:52 PM > To: Govindharajan, Hariprasad ; Lu, > Wenzhuo ; Wu, Jingjing ; > Iremonger, Bernard ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; Yigit, Ferruh ; > step...@networkplumber.org; david.

Re: [dpdk-dev] [PATCH] crypto/octeontx2: enable unbinding

2020-02-12 Thread Akhil Goyal
> > > > Like for OCTEON TX, the OCTEON TX2 crypto engines must first be unbound > > from their kernel module, then rebound to vfio-pci, before being used in > > DPDK. > > > > As this capability is detected at runtime by dpdk-pmdinfo, add the info in > > the > > PMD registering directives. > > > >

[dpdk-dev] [PATCH v9] app/testpmd: add portlist option

2020-02-12 Thread Hariprasad Govindharajan
In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p [0x]nnn): mask must be in hex format - Using portlist i

Re: [dpdk-dev] [PATCH v2] crypto/ccp: enable IOMMU for CCP

2020-02-12 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ravi Kumar > >-Original Message- >From: dev On Behalf Of asoma...@amd.com >Sent: Tuesday, January 28, 2020 2:08 PM >To: dev@dpdk.org >Cc: sta...@dpdk.org >Subject: [dpdk-dev] [PATCH v2] crypto/ccp: enable IOMMU for CCP > >[C

Re: [dpdk-dev] [PATCH 0/2] cleanup makefile config and testing

2020-02-12 Thread David Marchand
On Wed, Feb 12, 2020 at 12:57 AM Thomas Monjalon wrote: > > Thomas Monjalon (2): > config: deduplicate options > devtools: enable more config options in build test > > config/common_armv8a_linux| 2 -- > config/common_linux | 6 -- > config/

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg

2020-02-12 Thread Tiwei Bie
On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: > Some applications like pktgen use link_speed to calculate > transmit rate. It limits outcome traffic to hardcoded 10G. > > This patch adds link_speed devarg which allows to configure > link_speed of virtio device. > > Signed-off-by: I

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg

2020-02-12 Thread Maxime Coquelin
On 2/12/20 11:35 AM, Tiwei Bie wrote: > On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: >> Some applications like pktgen use link_speed to calculate >> transmit rate. It limits outcome traffic to hardcoded 10G. >> >> This patch adds link_speed devarg which allows to configure >> lin

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg

2020-02-12 Thread Tiwei Bie
On Wed, Feb 12, 2020 at 11:40:40AM +0100, Maxime Coquelin wrote: > On 2/12/20 11:35 AM, Tiwei Bie wrote: > > On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: > >> Some applications like pktgen use link_speed to calculate > >> transmit rate. It limits outcome traffic to hardcoded 10G. >

[dpdk-dev] [PATCH] doc: updates for cycle-count mode in compression perf tool

2020-02-12 Thread Artur Trybula
This commit adds release notes and updates documentation for the cycle-count mode added to the compression performance tool. Fixes: 2695db95a147 ("test/compress: add cycle-count mode to perf tool") Signed-off-by: Artur Trybula --- doc/guides/rel_notes/release_20_02.rst | 5 + doc/guides/to

Re: [dpdk-dev] [PATCH] doc: updates for cycle-count mode in compression perf tool

2020-02-12 Thread Dybkowski, AdamX
> -Original Message- > From: Trybula, ArturX > Sent: Wednesday, 12 February, 2020 13:07 > To: dev@dpdk.org; Trahe, Fiona ; > shal...@marvell.com; Dybkowski, AdamX ; > Trybula, ArturX ; akhil.go...@nxp.com > Subject: [PATCH] doc: updates for cycle-count mode in compression perf tool > > Thi

[dpdk-dev] [PATCH] usertools: fix syntax warning in python 3.8

2020-02-12 Thread Thomas Faivre
Silent the following warning when running script with python 3.8: > /usr/bin/dpdk-pmdinfo:542: SyntaxWarning: "is" with a literal. > Did you mean "=="? > if (autoload_path is None or autoload_path is ""): As autoload_path can only be None or a string, directly check its bool value. Fixes: c67c

Re: [dpdk-dev] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path

2020-02-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Wisam Monther > Sent: Tuesday, February 11, 2020 3:20 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; Dekel Peled > Subject: [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path > > The blocker should take FDB into

Re: [dpdk-dev] [PATCH v9] app/testpmd: add portlist option

2020-02-12 Thread Burakov, Anatoly
On 12-Feb-20 10:29 AM, Hariprasad Govindharajan wrote: In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix VLAN item match for DV mode

2020-02-12 Thread Matan Azrad
From: Dekel Peled > Currently MLX5 PMD can't match on untagged packets specifically. > Tagged traffic still hits the flows intended for untagged packets. > If the flow has ETH, it will catch all matching packets, tagged and untagged. > The solution is to use cvlan_tag bit. > If mask=1 and value=

Re: [dpdk-dev] [PATCH] crypto/ccp: fix queue alignment

2020-02-12 Thread Akhil Goyal
> > Caught by compiling with -fno-common. > A cacheline_aligned symbol can be found in the crypto/ccp driver > object files. > > Looking at this driver source, the cacheline_aligned (kernel?) > alignment macro is undefined. > The compiler treats this as a symbol definition and generates a

Re: [dpdk-dev] [PATCH] cryptodev: fix missing doxygen comment

2020-02-12 Thread Akhil Goyal
> > Acked-by: Konstantin Ananyev > Applied to dpdk-next-crypto Added Fixes line. Thanks.

Re: [dpdk-dev] [PATCH] crypto/qat: fix missing release note for dual thread feature

2020-02-12 Thread Akhil Goyal
> > > > This commit fixes missing release notes for dual thread feature. > > > > Fixes: 026f21c0b951 ("common/qat: support dual threads for > enqueue/dequeue") > > > > Signed-off-by: Arek Kusztal > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Squashed with http://patches.dpdk.org/patch/

Re: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test vectors

2020-02-12 Thread Akhil Goyal
Hi Adam/Fiona, > > This patch replaces all KASUMI, SNOW3G, ZUC and all mixed > crypto unit test vectors with randomly generated input arrays. > All outputs were calculated and verified on both QAT PMD > and appropriate software-only PMDs wherever possible. > > Signed-off-by: Adam Dybkowski > ---

Re: [dpdk-dev] [PATCH v2] test/compress: replace test vector

2020-02-12 Thread Akhil Goyal
Hi Thomas, > > This patch replaces an existing test vector with a new one containing > public domain text only. This is to avoid any potential issues > re-licensing content as BSD-3 which has no clear original license. > > Fixes: b06aa643cac4 ("test/compress: add initial unit tests") > > Signed

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list

2020-02-12 Thread Ferruh Yigit
On 2/12/2020 10:25 AM, Akhil Goyal wrote: > Hi Anoob, > > Hi Anoob, > > What is the difference between "Inline crypto" in that document and > this "Inline protocol"? Both seems providing same outpout. [Anoob] Yes. It is partly because the description of "inline crypto"

Re: [dpdk-dev] [PATCH v2] test/compress: replace test vector

2020-02-12 Thread Thomas Monjalon
12/02/2020 14:25, Akhil Goyal: > Hi Thomas, > > > > > This patch replaces an existing test vector with a new one containing > > public domain text only. This is to avoid any potential issues > > re-licensing content as BSD-3 which has no clear original license. > > > > Fixes: b06aa643cac4 ("test

[dpdk-dev] Dropping python 2 support

2020-02-12 Thread Robin Jarry
Hi all, As you may have noticed, Python 2 is officially end-of-life since January 1st 2020. https://www.python.org/doc/sunset-python-2/ Some projects have already decided to drop python 2 support: https://github.com/openvswitch/ovs/commit/1ca0323e7c29 https://wiki.debian.org/Python/2Removal htt

[dpdk-dev] [PATCH 0/2] acl: fix 32-bit range field doesn't work properly

2020-02-12 Thread Konstantin Ananyev
Fix problem with ACL library for 32-bit range fields, and extend UT to cover such cases in future. Konstantin Ananyev (2): acl: fix 32-bit range field doesn't work properly test/acl: add 32-bit range test-case app/test/test_acl.c | 164 +-- app/test/t

[dpdk-dev] [PATCH 1/2] acl: fix 32-bit range field doesn't work properly

2020-02-12 Thread Konstantin Ananyev
ACL build phase for range fields that are bigger then 16 bits might generate wrong trie. For more details please refer to: https://bugs.dpdk.org/show_bug.cgi?id=307 Fixes: dc276b5780c2 ("acl: new library") Cc: sta...@dpdk.org Reported-by: Ido Goshen Signed-off-by: Konstantin Ananyev --- lib/li

[dpdk-dev] [PATCH 2/2] test/acl: add 32-bit range test-case

2020-02-12 Thread Konstantin Ananyev
Add new test-case to improve test coverage for 32-bit range fields. Suggested-by: Ido Goshen Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 164 +--- app/test/test_acl.h | 43 2 files changed, 184 insertions(+), 23 deletions(-)

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list

2020-02-12 Thread Akhil Goyal
Hi Ferruh, > > > Since both using the rte_security, for a PMD isn't there a way to say if it is > supporting any one of them or both? If so what do you think documenting it > too? > I think that is mentioned in the rte_security capabilities about the action types Which are supported by the dri

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching

2020-02-12 Thread Ferruh Yigit
On 2/3/2020 5:10 PM, Matan Azrad wrote: > > Hi > > From: Ferruh Yigit >> On 1/25/2020 6:56 PM, Matan Azrad wrote: >>> Hi Ferruh >>> >>> From: Ferruh Yigit On 1/23/2020 7:25 PM, Matan Azrad wrote: > Hi > > From: Ferruh Yigit >> On 1/23/2020 3:29 PM, Matan Azrad wrote: >>>

Re: [dpdk-dev] [PATCH v2] crypto/ccp: enable IOMMU for CCP

2020-02-12 Thread Akhil Goyal
> Acked-by: Ravi Kumar > Applied to dpdk-next-crypto Removed stable tag as it is a feature not a fix. Thanks.

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list

2020-02-12 Thread Ferruh Yigit
On 2/12/2020 1:48 PM, Akhil Goyal wrote: > Hi Ferruh, >> >> >> Since both using the rte_security, for a PMD isn't there a way to say if it >> is >> supporting any one of them or both? If so what do you think documenting it >> too? >> > I think that is mentioned in the rte_security capabilities ab

Re: [dpdk-dev] [PATCH v9] app/testpmd: add portlist option

2020-02-12 Thread Ferruh Yigit
On 2/12/2020 1:03 PM, Burakov, Anatoly wrote: > On 12-Feb-20 10:29 AM, Hariprasad Govindharajan wrote: >> In current version, we are setting the ports >> using portmask. With portmask, we can use only >> upto 64 ports. This portlist option enables the user >> to use more than 64 ports. >> Now we ca

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list

2020-02-12 Thread Akhil Goyal
> On 2/12/2020 1:48 PM, Akhil Goyal wrote: > > Hi Ferruh, > >> > >> > >> Since both using the rte_security, for a PMD isn't there a way to say if > >> it is > >> supporting any one of them or both? If so what do you think documenting it > too? > >> > > I think that is mentioned in the rte_securit

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix VLAN item match for DV mode

2020-02-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Tuesday, February 11, 2020 1:05 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix VLAN item match for DV mode > > Currently MLX5 PMD can't match on unta

Re: [dpdk-dev] [PATCH v2] test/compress: replace test vector

2020-02-12 Thread Akhil Goyal
Hi Artur, > > 12/02/2020 14:25, Akhil Goyal: > > Hi Thomas, > > > > > > > > This patch replaces an existing test vector with a new one containing > > > public domain text only. This is to avoid any potential issues > > > re-licensing content as BSD-3 which has no clear original license. > > > > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix meter header modify before decap issue

2020-02-12 Thread Matan Azrad
From: Suanming Mou > The meter flows are split into three subflows each, the prefix subflow with > meter action color the packet, the meter subflow filters out the colored > packets, the suffix subflow applies all the remaining actions to the passed > packets. The tag header modify action is add

Re: [dpdk-dev] Dropping python 2 support

2020-02-12 Thread Bruce Richardson
On Wed, Feb 12, 2020 at 02:41:56PM +0100, Robin Jarry wrote: > Hi all, > > As you may have noticed, Python 2 is officially end-of-life since > January 1st 2020. > > https://www.python.org/doc/sunset-python-2/ > > Some projects have already decided to drop python 2 support: > > https://github.co

Re: [dpdk-dev] [PATCH v2] test/compress: replace test vector

2020-02-12 Thread Trybula, ArturX
Hi Akhil, > Hi Artur, > > > > > 12/02/2020 14:25, Akhil Goyal: > > > Hi Thomas, > > > > > > > > > > > This patch replaces an existing test vector with a new one > > > > containing public domain text only. This is to avoid any potential > > > > issues re-licensing content as BSD-3 which has no c

Re: [dpdk-dev] [PATCH] net/mlx5: fix meter header modify before decap issue

2020-02-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Thursday, February 6, 2020 6:14 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; xiangxia.m@gmail.com; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix meter header modify before dec

Re: [dpdk-dev] [dpdklab] Re: [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Jeremy Plsek
On Wed, Feb 12, 2020 at 4:32 AM Thomas Monjalon wrote: > > 12/02/2020 10:26, Xu, Rosen: > > I find some build error in patchwork. > > This is a failure in the unit tests, probably unrelated: > https://lab.dpdk.org/results/dashboard/patchsets/9573/ > > This is the error message: > b

Re: [dpdk-dev] [dpdklab] Re: [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Jeremy Plsek
On Wed, Feb 12, 2020 at 10:04 AM Jeremy Plsek wrote: > > On Wed, Feb 12, 2020 at 4:32 AM Thomas Monjalon wrote: > > > > 12/02/2020 10:26, Xu, Rosen: > > > I find some build error in patchwork. > > > > This is a failure in the unit tests, probably unrelated: > > https://lab.dpdk.org/result

Re: [dpdk-dev] [dpdklab] Re: [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Thomas Monjalon
12/02/2020 16:18, Jeremy Plsek: > On Wed, Feb 12, 2020 at 10:04 AM Jeremy Plsek wrote: > > > > On Wed, Feb 12, 2020 at 4:32 AM Thomas Monjalon wrote: > > > > > > 12/02/2020 10:26, Xu, Rosen: > > > > I find some build error in patchwork. > > > > > > This is a failure in the unit tests, probably un

Re: [dpdk-dev] [dpdklab] Re: [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Jeremy Plsek
On Wed, Feb 12, 2020 at 11:30 AM Thomas Monjalon wrote: > > 12/02/2020 16:18, Jeremy Plsek: > > On Wed, Feb 12, 2020 at 10:04 AM Jeremy Plsek wrote: > > > > > > On Wed, Feb 12, 2020 at 4:32 AM Thomas Monjalon > > > wrote: > > > > > > > > 12/02/2020 10:26, Xu, Rosen: > > > > > I find some build

Re: [dpdk-dev] [dpdklab] Re: [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Thomas Monjalon
12/02/2020 17:36, Jeremy Plsek: > On Wed, Feb 12, 2020 at 11:30 AM Thomas Monjalon wrote: > > > > 12/02/2020 16:18, Jeremy Plsek: > > > On Wed, Feb 12, 2020 at 10:04 AM Jeremy Plsek wrote: > > > > > > > > On Wed, Feb 12, 2020 at 4:32 AM Thomas Monjalon > > > > wrote: > > > > > > > > > > 12/02/2

Re: [dpdk-dev] [dpdklab] Re: [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Jeremy Plsek
On Wed, Feb 12, 2020 at 11:42 AM Thomas Monjalon wrote: > > 12/02/2020 17:36, Jeremy Plsek: > > On Wed, Feb 12, 2020 at 11:30 AM Thomas Monjalon > > wrote: > > > > > > 12/02/2020 16:18, Jeremy Plsek: > > > > On Wed, Feb 12, 2020 at 10:04 AM Jeremy Plsek > > > > wrote: > > > > > > > > > > On We

[dpdk-dev] [PATCH] kni: fix build with Linux 5.6

2020-02-12 Thread Ferruh Yigit
With the following Linux commit a new parameter 'txqueue' has been added to 'ndo_tx_timeout' ndo: commit 0290bd291cc0 ("netdev: pass the stuck queue to the timeout handler") The change reflected to the KNI with version check. Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- kernel/linux/kni

Re: [dpdk-dev] [PATCH v2] config: disable all kmods by default from v20.02

2020-02-12 Thread Lipiec, Herakliusz
This change also affects usertools/dpdk-setup.sh When following this: https://doc.dpdk.org/guides/linux_gsg/quick_start.html And trying to insert igb_uio, it gives following error: ## ERROR: Target does not have the DPDK UIO Kernel Module. To fix, please try to rebuild target. Should this

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix txonly flow generation entropy

2020-02-12 Thread Ferruh Yigit
On 2/9/2020 5:02 PM, Viacheslav Ovsiienko wrote: > The testpmd application in txonly forwarding mode has an option > to generate the packet flows by varying the destination IP address. > The patch increments the IP for each packet sent, this improves > the entropy and RSS distibution on the peer re

Re: [dpdk-dev] [PATCH v9] app/testpmd: add portlist option

2020-02-12 Thread Lipiec, Herakliusz
> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday, February 12, 2020 2:00 PM > To: Burakov, Anatoly ; Govindharajan, > Hariprasad ; Lu, Wenzhuo > ; Wu, Jingjing ; Iremonger, > Bernard ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; step...@networkp

Re: [dpdk-dev] [dpdklab] Re: [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Thomas Monjalon
12/02/2020 17:46, Jeremy Plsek: > On Wed, Feb 12, 2020 at 11:42 AM Thomas Monjalon wrote: > > > > 12/02/2020 17:36, Jeremy Plsek: > > > On Wed, Feb 12, 2020 at 11:30 AM Thomas Monjalon > > > wrote: > > > > > > > > 12/02/2020 16:18, Jeremy Plsek: > > > > > On Wed, Feb 12, 2020 at 10:04 AM Jeremy

Re: [dpdk-dev] [PATCH v2] config: disable all kmods by default from v20.02

2020-02-12 Thread Thomas Monjalon
12/02/2020 18:18, Lipiec, Herakliusz: > This change also affects usertools/dpdk-setup.sh > When following this: https://doc.dpdk.org/guides/linux_gsg/quick_start.html > And trying to insert igb_uio, it gives following error: > > ## ERROR: Target does not have the DPDK UIO Kernel Module. >T

[dpdk-dev] [PATCH] net/mlx5: fix legacy non inline multi packet session

2020-02-12 Thread Viacheslav Ovsiienko
The commit being fixed introduced the different format for the transmitting descriptor multi-packet session for ConnectX-4LX. The session was assumed always opened if not-inlinable packet was encountered. The patch checks whether the inline multi-packet is opened and it allows to proceed with norma

Re: [dpdk-dev] [dpdklab] Re: [PATCH v4 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Jeremy Plsek
On Wed, Feb 12, 2020 at 12:38 PM Thomas Monjalon wrote: > > 12/02/2020 17:46, Jeremy Plsek: > > On Wed, Feb 12, 2020 at 11:42 AM Thomas Monjalon > > wrote: > > > > > > 12/02/2020 17:36, Jeremy Plsek: > > > > On Wed, Feb 12, 2020 at 11:30 AM Thomas Monjalon > > > > wrote: > > > > > > > > > > 12

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: add link speed devarg

2020-02-12 Thread Ivan Dyukov
Hi Tiwei, 12.02.2020 13:35, Tiwei Bie пишет: > On Fri, Feb 07, 2020 at 02:25:26PM +0300, Ivan Dyukov wrote: >> Some applications like pktgen use link_speed to calculate >> transmit rate. It limits outcome traffic to hardcoded 10G. >> >> This patch adds link_speed devarg which allows to configure

[dpdk-dev] segmentation fault in lthread_run() on ARM64 processor - regarding

2020-02-12 Thread hema sai chandra
Hi, I am trying to launch a function called lthread_init(), on a logical core using rte_eal_remote_launch from main (), then creating an lthread which has only lthread_exit() in the thread body and lthread_run() in the lthread_init() and then calling a function lthread_main_spawner() from main(

Re: [dpdk-dev] [PATCH v8 1/9] license: add license exception for windows

2020-02-12 Thread Thomas Monjalon
07/02/2020 04:14, Pallavi Kadam: > The Governing Board and Tech Board have provided exceptions for > MIT and BSD-2-Clause license files for DPDK support on Windows. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > +-

Re: [dpdk-dev] [PATCH v8 0/9] Windows patchset with additional EAL functionalities

2020-02-12 Thread Thomas Monjalon
07/02/2020 20:05, Dmitry Kozlyuk: > > This patchset includes additional functionalities for Windows EAL > > to support command-line parsing feature and some EAL common code > > on Windows. > > > > This patchset can be applied to windpdk-next-dev branch in the draft repo. > > > > v8 changes: > >

Re: [dpdk-dev] [PATCH v8 1/9] license: add license exception for windows

2020-02-12 Thread Ranjit Menon
On 2/12/2020 1:38 PM, Thomas Monjalon wrote: 07/02/2020 04:14, Pallavi Kadam: The Governing Board and Tech Board have provided exceptions for MIT and BSD-2-Clause license files for DPDK support on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- +---

[dpdk-dev] [PATCH v5 2/6] net/mlx: add static ibverbs linkage with meson

2020-02-12 Thread Thomas Monjalon
The libibverbs (and libmlx4/5) can be statically embedded in the shared PMD library, or in the application with the static PMD. It was supported with make build system in commit 2c0dd7b69fb0 ("config: add static linkage of mlx dependency"). The same feature is enabled with meson when using pkg-con

[dpdk-dev] [PATCH v5 0/6] mlx ibverbs linking in meson

2020-02-12 Thread Thomas Monjalon
This is the follow-up of the feature I added one year ago: static linkage of libibverbs in mlx PMDs. The first implementation was focused on "make". This second round does the same with "meson". With the meson option ibverbs_link, only the mode "shared" was working correctly. This patchset adds th

[dpdk-dev] [PATCH v5 3/6] buildtools: get static mlx dependencies for meson

2020-02-12 Thread Thomas Monjalon
The shell script options-ibverbs-static.sh was used with make in forcing static linkage of ibverbs libraries. When choosing to link with a static dependency in meson, the generated .pc file will not force such static linkage. The solution will rely on using this script in meson. If linking with l

[dpdk-dev] [PATCH v5 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Thomas Monjalon
The variable build is already initialized as true in drivers/meson.build. Duplicate initializations can be removed from mlx. When the variable build is set to false, it is easier to call subdir_done() than branch the rest of the code on build condition. Suggested-by: Bruce Richardson Signed-off-

[dpdk-dev] [PATCH v5 4/6] net/mlx: workaround static linkage with meson

2020-02-12 Thread Thomas Monjalon
If ibverbs_link is static and the application choose to link DPDK as static libraries, both PMD and ibverbs libraries must be linked as static libraries. And the dependencies of ibverbs (netlink) must still be linked as shared libraries. Unfortunately, meson forget about the static requirement for

[dpdk-dev] [PATCH v5 5/6] net/mlx: rename meson variable for dlopen option

2020-02-12 Thread Thomas Monjalon
The name of the variable pmd_dlopen is confusing because it can be understood as true if the PMD is dlopen, whereas it means the ibverbs glue layer is a dlopen library. That's why it is renamed dlopen_ibverbs. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson --- drivers/common/mlx5/mes

[dpdk-dev] [PATCH v5 6/6] net/mlx: fix overlinking with meson and glue dlopen

2020-02-12 Thread Thomas Monjalon
If ibverbs_link is dlopen, the PMD and application should not be linked with ibverbs, but the glue library is. Unfortunately the ibverbs dependency was exported in the variable ext_deps, so there were overlinking. It is fixed by not exporting the dependency in ext_deps, and recreating a limited de

[dpdk-dev] [RFC 2/4] hash: check flags on creation

2020-02-12 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_hash/rte_cuckoo_hash.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_hash/rte_

[dpdk-dev] [RFC 3/4] stack: check flags on creation

2020-02-12 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_stack/rte_stack.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_stack/rte_stack.c

[dpdk-dev] [RFC 1/4] ring: future proof flag settings

2020-02-12 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_ring/rte_ring.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_ring/rte_ring.c b/

[dpdk-dev] [RFC 0/4] Enforce flag checking in API's

2020-02-12 Thread Stephen Hemminger
Since the DPDK api's are lazy about checking for flag values it means the flags can never be extended in future releases without causing ABI breakage. This means we end up doing unnecessary symbol versioning just to work around applications that might pass in naughty bits. This is the DPDK analog

[dpdk-dev] [RFC 4/4] cfgfile: check flags value

2020-02-12 Thread Stephen Hemminger
All API's should check that they support the flag values passed. If an application passes an invalid flag it could cause problems in later ABI. Signed-off-by: Stephen Hemminger --- lib/librte_cfgfile/rte_cfgfile.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_cfgfile/rte_cfg

Re: [dpdk-dev] [PATCH v5 1/6] drivers: cleanup meson build variable

2020-02-12 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, February 13, 2020 6:07 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Matan Azrad > ; Shahaf Shuler ; > Viacheslav Ovsiienko ; Xu, Rosen > ; Zhang, Tianfei > Subject: [PATCH v5 1/6] drivers: cleanup meson build variable >

[dpdk-dev] [PATCH v1] doc: add release notes for virtio-PMD

2020-02-12 Thread Cheng Jiang
Add release notes for the notification data feature of virtio-PMD. Signed-off-by: Cheng Jiang --- doc/guides/rel_notes/release_20_02.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_20_02.rst index 690e7dba7..0

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: update Rx offload after setting MTU sccessfully

2020-02-12 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2020/2/12 8:25, Wei Hu (Xavier) wrote: Hi, Ferruh Yigit On 2020/1/28 19:27, Ferruh Yigit wrote: On 1/21/2020 11:44 AM, Wei Hu (Xavier) wrote: From: "Wei Hu (Xavier)" Currently, Rx offload capabilities and max_rx_pkt_len in the struct variable named rte_port are not updat

[dpdk-dev] [PATCH v2] app/testpmd: update Rx offload after setting MTU sccessfully

2020-02-12 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" Currently, Rx offload capabilities and max_rx_pkt_len in the struct variable named rte_port are not updated after setting mtu successfully in port_mtu_set function by 'port config mtu ' command. This may lead to reconfig mtu to the initial value in the driver when recalli

Re: [dpdk-dev] [PATCH v3 1/3] net/af_xdp: fix umem frame size & headroom calculations

2020-02-12 Thread Ye Xiaolong
On 02/10, Ciara Loftus wrote: >The previous frame size calculation incorrectly used >mb_pool->private_data_size and didn't include mb_pool->header_size. >Instead of performing a manual calculation, use the >rte_mempool_calc_obj_size API to determine the frame size. > >The previous frame headroom ca

[dpdk-dev] [Bug 397] support-multi-driver=1 does not work in i40e PMD

2020-02-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=397 Bug ID: 397 Summary: support-multi-driver=1 does not work in i40e PMD Product: DPDK Version: 18.05 Hardware: All OS: All Status: UNCONFIRMED Severity: major

Re: [dpdk-dev] [PATCH v3 3/3] net/af_xdp: fix maximum MTU value

2020-02-12 Thread Ye Xiaolong
On 02/10, Ciara Loftus wrote: >The maximum MTU for af_xdp zero copy is equal to the page size less the >frame overhead introduced by AF_XDP (XDP HR = 256) and DPDK (frame headroom >= 320). The patch updates this value to reflect this. > >This change also makes it possible to remove unneeded constan

Re: [dpdk-dev] [PATCH v3 2/3] net/af_xdp: use correct fill queue addresses

2020-02-12 Thread Ye Xiaolong
On 02/10, Ciara Loftus wrote: >The fill queue addresses should start at the beginning of the mempool >object instead of the beginning of the mbuf. This is because the umem >frame headroom includes the mp hdrobj size. Starting at this point >ensures AF_XDP doesn't write past the available room in th

[dpdk-dev] app/testpmd: parse flow command line for AH

2020-02-12 Thread Xiao Zhang
add ITEM_AH add ITEM_AH_SPI Signed-off-by: Xiao Zhang --- app/test-pmd/cmdline_flow.c | 29 + 1 file changed, 29 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index c2cc4c5..680cb1c 100644 --- a/app/test-pmd/cmdline_flow.c +++ b

Re: [dpdk-dev] app/testpmd: parse flow command line for AH

2020-02-12 Thread Ye Xiaolong
Hi, Xiao On 02/13, Xiao Zhang wrote: >add ITEM_AH >add ITEM_AH_SPI Better to add some descriptive sentence about this patch in commit log instead of some simple bullets. Thanks, Xiaolong > >Signed-off-by: Xiao Zhang >--- > app/test-pmd/cmdline_flow.c | 29 + > 1 file

Re: [dpdk-dev] [PATCH v1] doc: add release notes for virtio-PMD

2020-02-12 Thread Maxime Coquelin
On 2/13/20 2:41 AM, Cheng Jiang wrote: > Add release notes for the notification data feature of virtio-PMD. > > Signed-off-by: Cheng Jiang > --- > doc/guides/rel_notes/release_20_02.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/rel_notes/release_20_02.rst >