Re: [dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures definitions

> On 20 Dec 2019, at 01:16, Stephen Hemminger > wrote: > > On Thu, 19 Dec 2019 23:18:32 +0100 > Alfredo Cardigliano wrote: > >> + >> +#pragma pack(push, 1) >> + > > Really, packing leads to unaligned data structures and is generally > a bad idea. This specific file defines data structures

Re: [dpdk-dev] [PATCH v6 3/4] net/ixgbe: cleanup Tx buffers

Hi, > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, December 30, 2019 8:54 PM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Yang, Qiming ; Di, ChenxuX > > Subject: RE: [dpdk-dev] [PATCH v6 3/4] net/ixgbe: cleanup Tx buffers > > Hi, > > > Add support to the ixgbe driver for th

Re: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup based on eventdev

> -Original Message- > From: Jerin Jacob > Sent: Thursday, January 2, 2020 3:04 PM > To: Nipun Gupta > Cc: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; Marko Kovacevic > ; Ori Kam ; Bruce > Richardson ; Radu Nicolau > ; Akhil Goyal ; Tomasz > Kantecki ; Sunil Kumar Kori ;

Re: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup based on eventdev

On Fri, Jan 3, 2020 at 2:36 PM Nipun Gupta wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, January 2, 2020 3:04 PM > > To: Nipun Gupta > > Cc: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > > Kollanukkaran ; Marko Kovacevic > > ; Ori Kam ; Bruce > > Richardson

Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: relax the io barrier for aarch64

Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Friday, January 3, 2020 3:35 PM > To: Gavin Hu > Cc: dpdk-dev ; nd ; David Marchand > ; tho...@monjalon.net; > rasl...@mellanox.com; maxime.coque...@redhat.com; tiwei@intel.com; > hemant.agra...@nxp.com; jer...@marvell.com; P

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Monday, December 23, 2019 10:13 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran > ; Naray

Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw

Hi Konstantin Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, December 24, 2019 6:18 PM > To: Anoob Joseph ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju At

[dpdk-dev] [Bug 379] Build fail using dpdk-setup.sh in RedHat version 3.10.0-862.rt56.804.el7.x86_64

https://bugs.dpdk.org/show_bug.cgi?id=379 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolutio

Re: [dpdk-dev] [PATCH] add ABI checks

> -Original Message- > From: Richardson, Bruce > Sent: Friday 20 December 2019 15:32 > To: David Marchand ; dev@dpdk.org > Cc: tho...@monjalon.net; Laatz, Kevin ; > acon...@redhat.com; nhor...@tuxdriver.com; Michael Santana > ; Mcnamara, John ; > Kovacevic, Marko ; Kinsella, Ray > > Subje

[dpdk-dev] Offloading L4 checksum to crypto device

Hi, This is Heng from Ericsson. We are now developing a platform based on dpdk. The platform usually processes the ipsec packets encapsulating udp packets. You know, calculating udp checksum is always time consuming. We found a hardware solution where our crypto device can calculate the udp ch

Re: [dpdk-dev] dpdk : windows build issue

Hi, Any pointers to the windows10 build is a great help. Now the linux setup is running; need is to evaluate on windows. Regards Srinivas -Original Message- From: Pallavi Kadam Sent: Monday, September 23, 2019 11:54 PM To: Revanur Srinivasa Kumar (RBEI/ETA) ; dev@dpdk.org Subject:

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

Hi Kevin, I'd like to sign off validation dpdk-stable-18.11.6-rc1 against Azure gallery images. Version used - https://git.dpdk.org/dpdk-stable/snapshot/dpdk-stable-18.11.6-rc1.tar.xz

Re: [dpdk-dev] [PATCH] mbuf: document how to set length when attaching ext buffer

Looks good to me! Olivier Matz writes: > From: Jörg Thalheim > > Enhance API documentation of rte_pktmbuf_attach_extbuf() to > explain that the attached mbuf is initialized with length = 0. > > Link: https://bugs.dpdk.org/show_bug.cgi?id=362 > > Signed-off-by: Jörg Thalheim > Signed-off-by:

Re: [dpdk-dev] [PATCH v3 36/36] net/i40e/base: add new link speed constants

Good day dear ALL It's a new feature /*new speed display*/ but from other point of view it's a fix /*because it was found after new feature release*/ -Original Message- From: Xing, Beilei Sent: Friday, December 27, 2019 6:38 AM To: Ye, Xiaolong ; Zhang, Qi Z Cc: dev@dpdk.org; Stillwel

Re: [dpdk-dev] [dpdk-dev PATCH v2 2/6] raw/octeontx2_ep: add device configuration

Hi Gavin, Please see response inline. > -Original Message- > From: Gavin Hu > Sent: Thursday, January 2, 2020 3:48 PM > To: Mahipal Challa ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Subrahmanyam Nilla > ; Venkateshwarlu Nalla ; nd > > Subject: [EXT

Re: [dpdk-dev] [dpdk-dev PATCH v2 4/6] raw/octeontx2_ep: add enqueue operation

Hi Gavin, Please see response inline. > -Original Message- > From: Gavin Hu > Sent: Thursday, January 2, 2020 4:13 PM > To: Mahipal Challa ; dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; Subrahmanyam Nilla > ; Venkateshwarlu Nalla ; nd > > Subject: [EX

[dpdk-dev] [PATCH] event/dsw: avoid credit leak on oversized enqueue bursts

If an application issues rte_event_enqueue_new_burst() or rte_event_enqueue_forward_burst() call with a burst of events longer than the configured max enqueue burst size, DSW allocates credits not only for events actually enqueued, but for the complete burst. If this process is repeated, enough cre

[dpdk-dev] [PATCH 1/2] eal/freebsd: update CPU macro for FreeBSD 13 support

In (currently unreleased) FreeBSD 13, the CPU_NAND macro has been renamed to CPU_ANDNOT, so we need to use different DPDK-specific macros depending on what system-defined ones are present. Signed-off-by: Bruce Richardson --- lib/librte_eal/freebsd/eal/include/rte_os.h | 12 1 file c

[dpdk-dev] [PATCH 0/2] Fix build with FreeBSD 13-CURRENT

The FreeBSD CI system is reporting errors with DPDK on the current head of the FreeBSD development branch for FreeBSD 13. Ahead of BSD 13's release, we need to apply fixes to ensure DPDK continues to compile on the various versions. Bruce Richardson (2): eal/freebsd: update CPU macro for FreeBSD

[dpdk-dev] [PATCH 2/2] kernel/freebsd: update contigmem for FreeBSD 13

FreeBSD 13 has changed the definition of vm_page_replace so we need to have slightly different code paths around this function depending on the BSD version. Signed-off-by: Bruce Richardson --- kernel/freebsd/contigmem/contigmem.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

Re: [dpdk-dev] [PATCH v2 01/11] examples/l3fwd: add framework for event device

> Add framework to enable event device as a producer of packets. > To switch between event mode and poll mode the following options > have been added: > `--mode="eventdev"` or `--mode="poll"` > Also, allow the user to select the schedule type to be either > RTE_SCHED_TYPE_ORDERED, RTE_SCHED

Re: [dpdk-dev] [PATCH v2 07/11] examples/l3fwd: add service core setup based on caps

> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index 20df12748..69d212bc2 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -826,6 +826,93 @@ prepare_ptype_parser(uint16_t portid, uint16_t queueid) > return 0; > } > > +static inline int > +l3fwd_service

Re: [dpdk-dev] [PATCH v2 08/11] examples/l3fwd: add event lpm main loop

> Add lpm main loop for handling events based on capabilities of the > event device. > > Signed-off-by: Pavan Nikhilesh > --- > examples/l3fwd/l3fwd.h | 9 ++ > examples/l3fwd/l3fwd_event.c | 9 ++ > examples/l3fwd/l3fwd_event.h | 5 + > examples/l3fwd/l3fwd_lpm.c | 231 +++

Re: [dpdk-dev] [PATCH v2 09/11] examples/l3fwd: add event em main loop

> Add em main loop for handling events based on capabilities of the > event device. > > Signed-off-by: Pavan Nikhilesh > --- > examples/l3fwd/l3fwd.h | 10 ++ > examples/l3fwd/l3fwd_em.c| 177 +++ > examples/l3fwd/l3fwd_em.h| 159

Re: [dpdk-dev] [PATCH v2 10/11] examples/l3fwd: add graceful teardown for eventdevice

> Add graceful teardown that addresses both event mode and poll mode. > > Signed-off-by: Pavan Nikhilesh > --- > examples/l3fwd/main.c | 49 ++- > 1 file changed, 34 insertions(+), 15 deletions(-) > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/ma

Re: [dpdk-dev] [PATCH v2] build: explicitly enable sse4 for meson builds

+stable This patch is probably worthwhile taking into 19.11 and 18.11 branches to reduce chances of failures on CI of stable trees. On Mon, Dec 23, 2019 at 10:38:40AM +, Bruce Richardson wrote: > If the compiler does not recognise the specific CPU when building with the > default "native" mac

[dpdk-dev] [PATCH] build: skip processing docs folder if docs disabled

While each target is set to be ignored if the docs are disabled in the meson build, there is little reason to process the docs folder at all. Signed-off-by: Bruce Richardson --- doc/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/doc/meson.build b/doc/meson.build index c5410d

Re: [dpdk-dev] [PATCH v2] build: explicitly enable sse4 for meson builds

On Fri, Jan 3, 2020 at 2:55 PM Bruce Richardson wrote: > > +stable > > This patch is probably worthwhile taking into 19.11 and 18.11 branches to > reduce chances of failures on CI of stable trees. +1 > > On Mon, Dec 23, 2019 at 10:38:40AM +, Bruce Richardson wrote: > > If the compiler does n

[dpdk-dev] [PATCH v2] net/iavf/base: change the base code as common

Change the iavf base code as driver common library, it is used by iavf PMD now, and it can be used by i40evf PMD in the future. Signed-off-by: Haiyue Wang --- v2: update the commit message, and rename the iavf_main.c to iavf_impl.c drivers/common/Makefile | 5 + drivers/

[dpdk-dev] [PATCH 0/5] Update docs for installing on FreeBSD

Update the FreeBSD GSG guide to cover: * installing from package as well as via ports collection * building and installing manually via meson and ninja * building examples using the pkg-config file, since both the port/pkg and building from source use meson. * other general tidy-up. Bruce Richa

[dpdk-dev] [PATCH 2/5] doc: document installing from FreeBSD package

Update the FreeBSD GSG to cover installing from the pre-built package as well as installing from a port. Also, since the port is now based on meson, update the instructions for compiling and running the example applications. Signed-off-by: Bruce Richardson --- Note: at this stage, DPDK is in the

[dpdk-dev] [PATCH 1/5] doc: update intro to FreeBSD GSG

Update the introduction section note, to add in the fact that DPDK is now packaged in FreeBSD, i.e. available as a pre-built binary package, as well as being in the ports collection for manual building. Signed-off-by: Bruce Richardson --- Note: at this stage, DPDK is in the "latest" package snaps

[dpdk-dev] [PATCH 3/5] doc: add meson install instructions for FreeBSD

Update the FreeBSD GSG doc with instructions for installing using meson and ninja rather than make. Signed-off-by: Bruce Richardson Acked-by: Anatoly Burakov --- doc/guides/freebsd_gsg/build_dpdk.rst | 164 +++--- 1 file changed, 40 insertions(+), 124 deletions(-) diff --gi

[dpdk-dev] [PATCH 4/5] doc: update section on loading FreeBSD kernel modules

The kernel modules are now installed in the correct system location on install when using meson and ninja, so update the documentation to remove any references to the "kmod" directory. Also, make a few additional updates to improve clarity. Signed-off-by: Bruce Richardson --- doc/guides/freebsd_

[dpdk-dev] [PATCH 5/5] doc: update documentation on build and running FreeBSD apps

Update the documentation on building and running apps on FreeBSD, taking account of having used meson for building. We can also update the section on the command-line parameters, rather than claiming to be a complete list of parameters, it should describe how to get the complete list and only cover

Re: [dpdk-dev] [PATCH v3 0/5] GSG Documentation updates

On Thu, Nov 28, 2019 at 07:56:42PM +0100, Thomas Monjalon wrote: > 28/11/2019 17:33, Bruce Richardson: > > This patchset includes documentation updates for both the Linux and > > FreeBSD Getting Started Guide Docs. The majority of changes are to add > > information on building using meson and ninja

[dpdk-dev] [PATCH 00/14] cleanup resources on shutdown

Recently started using valgrind with DPDK, and the results are not clean. The DPDK has a function that applications can use to tell it to cleanup resources on shutdown (rte_eal_cleanup). But the current coverage of that API is spotty. Many internal parts of DPDK leave files and allocated memory be

[dpdk-dev] [PATCH 02/14] eal: log: free dynamic state on cleanup

When rte_eal_cleanup is called, free all the memory associated with dynamic log levels and types. Fixes: c1b5fa94a46f ("eal: support dynamic log types") Cc: olivier.m...@6wind.com Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_log.c | 18 +- 1 file changed,

[dpdk-dev] [PATCH 01/14] eal: log: close on cleanup

When application calls rte_eal_cleanup on shutdown, the DPDK log should be closed and cleaned up. Fixes: af75078fece3 ("first public release") Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_log.c | 12 lib/librte_eal/common/eal_private.h| 13 +

[dpdk-dev] [PATCH 03/14] eal: alarm: close timerfd on eal cleanup

Calling rte_eal_cleanup() should cause DPDK to cleanup all outstanding resources including file descriptors. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_private.h | 7 +++ lib/librte_eal/linux/eal/eal.c | 1 + lib/librte_eal/linux/eal/eal_alarm.c | 11 +++

[dpdk-dev] [PATCH 04/14] eal: cleanup threads

When rte_eal_cleanup is called it should stop all the child threads and close the pipes between threads. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/ea

[dpdk-dev] [PATCH 08/14] eal: vfio: cleanup the mp sync handle

When rte_eal_cleanup is called the rte_mp_action for VFIO should be freed. Fixes: edf73dd33072 ("ipc: handle unsupported IPC in action register") Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal.c | 3 +++ lib/librte

[dpdk-dev] [PATCH 05/14] eal: intr: cleanup resources

When rte_eal_cleanup is called the interrupt thread and associated resources should be cleaned up. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_private.h | 10 ++ lib/librte_eal/linux/eal/eal.c| 1 + lib/librte_eal/linux/eal/eal_interrupts.c | 9

[dpdk-dev] [PATCH 09/14] eal: close mem config on cleanup

Resolves file descriptor left open after rte_eal_cleanup. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c index 9ad81378f23c..e5c2a24322e9 100644 --- a/li

[dpdk-dev] [PATCH 11/14] eal: cleanup plugins data

When rte_eal_cleanup is called walk through the list of shared objects loaded, and close them and free the data structure. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_options.c | 12 lib/librte_eal/common/eal_options.h| 1 + lib/librte_eal/linux/ea

[dpdk-dev] [PATCH 10/14] tap: close netlink socket on device close

The netlink socket for flow creation was left open and never closed. Fixes: bf7b7f437b49 ("net/tap: create netdevice during probing") Cc: pascal.ma...@6wind.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 7 ++- 1 file changed, 6 insertions(+), 1

[dpdk-dev] [PATCH 07/14] eal: interrupts close epoll fd on shutdown

Use pthread callbacks to ensure that the epoll fd is closed when rte_eal_cleanup is called. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linux/eal/eal_interrupts.c | 26 ++- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_int

[dpdk-dev] [PATCH 06/14] eal: mp: end the multiprocess thread during cleanup

When rte_eal_cleanup is called, all control threads should exit. For the mp thread, this best handled by closing the mp_socket and letting the thread see that. This also fixes potential problems where the mp_socket gets another hard error, and the thread runs away repeating itself by reading the s

[dpdk-dev] [PATCH 13/14] eal: hotplug: cleanup multiprocess resources

When rte_eal_cleanup is called, hotplug should unregister the resources associated with the multi-process server. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/hotplug_mp.c | 5 + lib/librte_eal/common/hotplug_mp.h | 6 ++ lib/librte_eal/linux/eal/eal.c | 1 + 3 files ch

[dpdk-dev] [PATCH 14/14] eal: malloc: cleanup mp resources

The mp action resources in malloc should be cleaned up via rte_eal_cleanup. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/malloc_heap.c | 6 ++ lib/librte_eal/common/malloc_heap.h | 3 +++ lib/librte_eal/common/malloc_mp.c | 12 lib/librte_eal/common/malloc_mp.h

[dpdk-dev] [PATCH 12/14] ethdev: raise priority of old driver warning

The priority of the message about drivers not using new (correct) behaviour on close was debug. And debug messages are typically surpressed and never seen. Raise the priority so that broken drivers are visible and hopefully get developers to fix. Signed-off-by: Stephen Hemminger --- lib/librte_