Re: [dpdk-dev] [PATCH] net/mlx5: fix eagain on admin down

2019-12-14 Thread Slava Ovsiienko
Hi, Mike > -Original Message- > From: Mike Manning > Sent: Friday, December 13, 2019 17:12 > To: Slava Ovsiienko ; Thomas Monjalon > ; dev@dpdk.org > Cc: NĂ©lio Laranjeiro ; Matan Azrad > ; Shahaf Shuler ; Raslan > Darawsheh > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix eagain on admin

Re: [dpdk-dev] [PATCH 2/9] net/hns3: get link state change through mailbox

2019-12-14 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2019/12/3 21:19, Ferruh Yigit wrote: On 12/3/2019 1:16 PM, Ferruh Yigit wrote: On 12/2/2019 2:51 AM, Wei Hu (Xavier) wrote: From: Hongbo Zheng When link down occurs, firmware adds the function of sending message to PF driver through mailbox, hns3 PMD driver can recognize

Re: [dpdk-dev] [PATCH 2/9] net/hns3: get link state change through mailbox

2019-12-14 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2019/12/3 21:16, Ferruh Yigit wrote: On 12/2/2019 2:51 AM, Wei Hu (Xavier) wrote: From: Hongbo Zheng When link down occurs, firmware adds the function of sending message to PF driver through mailbox, hns3 PMD driver can recognize link state change faster through the messag

[dpdk-dev] [PATCH v2 5/9] net/hns3: optimize RSS's default algorithm

2019-12-14 Thread Wei Hu (Xavier)
From: Hao Chen This patch changed the default algorithm of RSS from simle_xor to toeplitz because toeplitz is used more frequently by upper applications such as ceph. Signed-off-by: Hao Chen Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rss.c | 14 +++--- 1 file changed, 11

[dpdk-dev] [PATCH v2 4/9] net/hns3: modify custom macro

2019-12-14 Thread Wei Hu (Xavier)
From: Huisong Li This patch replaces custom macro named HNS3_MIN_FRAME_LEN for ethernet minimum frame length with the macro named RTE_ETHER_MIN_LEN that defined in dpdk framework. Signed-off-by: Huisong Li Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c | 2 +- drivers/net/h

[dpdk-dev] [PATCH v2 8/9] net/hns3: remove the unnecessary assignment

2019-12-14 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch removes the unncessary assignment in hns3_xmit_pkts function to avoid performance loss. Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rxtx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns

[dpdk-dev] [PATCH v2 1/9] net/hns3: support Rx interrupt

2019-12-14 Thread Wei Hu (Xavier)
From: Hao Chen This patch supports of receive packets through interrupt mode for hns3 PF/VF driver. The following ops functions should be implemented defined in struct eth_dev_ops: rx_queue_intr_enable rx_queue_intr_disable rx_queue_count Signed-off-by: Hao Chen Signed-off-by: Wei Hu (Xavier)

[dpdk-dev] [PATCH v2 2/9] net/hns3: get link state change through mailbox

2019-12-14 Thread Wei Hu (Xavier)
From: Hongbo Zheng Currently, firmware adds the function of sending message to PF driver through mailbox when the link status is changed, hns3 PMD driver can usually recognize link state change faster through the message. And in some extreme cases, this way is not faster than existing method reg

[dpdk-dev] [PATCH v2 3/9] net/hns3: modify the return value of enable msix

2019-12-14 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch replaces the return value "-1" with "-ENXIO". Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c index

[dpdk-dev] [PATCH v2 7/9] net/hns3: remove the redundant variable initialization

2019-12-14 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch removes the redundant initialization of the variable named ret. Signed-off-by: Hongbo Zheng Signed-off-by: Hao Chen Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_ethdev.c| 10 +- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- 2 files chan

[dpdk-dev] [PATCH v2 0/9] updates for hns3 PMD driver

2019-12-14 Thread Wei Hu (Xavier)
This series are updates for hns3 ethernet PMD driver. v1 -> v2: There are changes in the No.02 patch, and the other patches are not updated. Hao Chen (4): net/hns3: support Rx interrupt net/hns3: optimize RSS's default algorithm net/hns3: remove the redundant function call net/hns3: remov

[dpdk-dev] [PATCH v2 6/9] net/hns3: remove the redundant function call

2019-12-14 Thread Wei Hu (Xavier)
From: Hao Chen This patch removes the redundant statement calling hns3_stats_reset() to clear statistical information explicitly in the initialization of VF device, because hardware has been reseted by FLR in the initialization and the initial hardware and software statistics values are 0. Signe

[dpdk-dev] [PATCH v2 9/9] net/hns3: remove the unused macros

2019-12-14 Thread Wei Hu (Xavier)
From: Hao Chen This patch removed some unused macros defined in hns3_rss.h, these macros are used to set tuples for abandoned RTE_ETH_FILTER_HASH in hns3_dev_filter_ctrl(). Signed-off-by: Hao Chen Signed-off-by: Wei Hu (Xavier) --- drivers/net/hns3/hns3_rss.h | 10 -- 1 file changed,

Re: [dpdk-dev] [PATCH] raw/ntb: fix write memory barrier issue

2019-12-14 Thread Gavin Hu (Arm Technology China)
Hi Xiaoyun, > -Original Message- > From: dev On Behalf Of Xiaoyun Li > Sent: Wednesday, December 4, 2019 11:19 PM > To: jingjing...@intel.com > Cc: dev@dpdk.org; Xiaoyun Li ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] raw/ntb: fix write memory barrier issue > > All buffers and ring in

Re: [dpdk-dev] [PATCH 14/15] crypto/octeontx2: add inline tx path changes

2019-12-14 Thread Gavin Hu (Arm Technology China)
Went through the patch, from the barrier usage perspective, Reviewed-by: Gavin Hu

Re: [dpdk-dev] [PATCH v1 2/6] raw/octeontx2_ep: add device configuration

2019-12-14 Thread Gavin Hu (Arm Technology China)
Hi Mahipal, > -Original Message- > From: dev On Behalf Of Mahipal Challa > Sent: Friday, December 6, 2019 2:39 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com; > venk...@marvell.com > Subject: [dpdk-dev] [PATCH v1 2/6] raw/octeontx2_ep: add device

Re: [dpdk-dev] What's possible reasons that may cause rx_total_missed_packets increase in ixgbe driver?

2019-12-14 Thread Haosong Huang
Hi, DPDK masters, I am debugging a `imissed` issue when we are using DPDK. We notice that imissed increase even when the traffic is slow. We are using x520 nic and ixgbe driver. Via check the code, imissed comes from rx_total_missed_packets in ixgbe. But what's the possible reason that make rx_to

Re: [dpdk-dev] [PATCH v1 5/6] raw/octeontx2_ep: add dequeue operation

2019-12-14 Thread Gavin Hu (Arm Technology China)
Hi Mahipal, > -Original Message- > From: dev On Behalf Of Mahipal Challa > Sent: Friday, December 6, 2019 2:39 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com; > venk...@marvell.com > Subject: [dpdk-dev] [PATCH v1 5/6] raw/octeontx2_ep: add dequeue

Re: [dpdk-dev] [PATCH v1 4/6] raw/octeontx2_ep: add enqueue operation

2019-12-14 Thread Gavin Hu (Arm Technology China)
Hi Mahipal, > -Original Message- > From: dev On Behalf Of Mahipal Challa > Sent: Friday, December 6, 2019 2:39 PM > To: dev@dpdk.org > Cc: jer...@marvell.com; pathr...@marvell.com; sni...@marvell.com; > venk...@marvell.com > Subject: [dpdk-dev] [PATCH v1 4/6] raw/octeontx2_ep: add enqueue

Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-14 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, December 13, 2019 5:25 PM > To: Anoob Joseph ; Akhil Goyal ; > Adrien Mazarguil ; Doherty, Declan > ; Yigit, Ferruh ; Jerin > Jacob > Kollanukkaran ; Thomas Monjalon > > Cc