Re: [dpdk-dev] [PATCH 1/4] net/ice: add devargs to control pipeline mode

2019-09-10 Thread Yang, Qiming
I got you, will fix it in v2 Qiming -Original Message- From: Ye, Xiaolong Sent: Monday, September 9, 2019 17:17 To: Yang, Qiming Cc: Wang, Ying A ; Zhang, Qi Z ; dev@dpdk.org; Zhao1, Wei Subject: Re: [PATCH 1/4] net/ice: add devargs to control pipeline mode On 09/09, Yang, Qiming wro

[dpdk-dev] [PATCH v2] usertools: fix py3 support with pyelftools>=0.24

2019-09-10 Thread Robin Jarry
Running dpdk-pmdinfo.py on Ubuntu 18.04 (bionic) with python 3 and pyelftools installed produces no output but no error is reported neither: ~$ python3 usertools/dpdk-pmdinfo.py -r build/app/testpmd ~$ echo $? 0 While with python 2, it works: ~# python2 usertools/dpdk-pmdinfo.py -r build

[dpdk-dev] examples/l3fwd-power: fix RX interrupt disable

2019-09-10 Thread Xiao Zhang
Interrupt will not be received when disabling RX interrupt without synchronization mechanism sometimes which leads to wake up issue, add spinlock to fix it. Fixes: b736d64787fc ("mples/l3fwd-power: disable Rx interrupt when waking up") Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang --- examples/

Re: [dpdk-dev] [PATCH v2 4/5] event/dpaa2: add selftest cases

2019-09-10 Thread Hemant Agrawal
Hi Aaron, Thanks! I will take care of your comments in v3 Regards, Hemant

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix Rx CQ doorbell synchronization on aarch64

2019-09-10 Thread Matan Azrad
From: Phil Yang > Subject: [PATCH 1/2] net/mlx5: fix Rx CQ doorbell synchronization on aarch64 > > The Rx completion queue doorbell field needs to be updated after the last > CQE decompressed. For the weaker memory model processors, the compiler > barrier is not sufficient to guarantee the ord

[dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-09-10 Thread Agalya Babu RadhaKrishnan
From: Agalya Babu RadhaKrishnan 1 issue caught by 344967 Leaked_storage: Variable sep going out of scope leaks the storage it points to. When 'sep' is not null and sep_exist is 0, 'sep' is freed before going out of scope of the function irrespective of 'addr' exists or not. Coverity Issue: 3449

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-10 Thread Matan Azrad
From: Viacheslav Ovsiienko > If VLAN tag insertion transmit offload is engaged > (DEV_TX_OFFLOAD_VLAN_INSERT in tx queue configuration is set) the > transmit descriptor may be built with wrong format, due to packet length is > not adjusted. Also, the ring buffer wrapup is not handled correctly.

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-09-10 Thread Babu Radhakrishnan, AgalyaX
Hi, > -Original Message- > From: Babu Radhakrishnan, AgalyaX > Sent: Tuesday, September 10, 2019 1:01 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; > hemant.agra...@nxp.com; sachin.sax...@nxp.com; Parthasarathy, > JananeeX M ; Babu Radhakrishnan, > AgalyaX ; sta...@dpdk.org > Subject: [PATC

Re: [dpdk-dev] [PATCH 2/2] net/virtio: on demand cleanup when doing in order xmit

2019-09-10 Thread Liu, Yong
> -Original Message- > From: Bie, Tiwei > Sent: Tuesday, September 10, 2019 2:17 PM > To: Liu, Yong > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Wang, Zhihong > > Subject: Re: [PATCH 2/2] net/virtio: on demand cleanup when doing in order > xmit > > On Tue, Aug 27, 2019 at 06:24:07PM

Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver

2019-09-10 Thread Maxime Coquelin
Hi Shahaf, On 9/9/19 1:55 PM, Shahaf Shuler wrote: > Hi Maxime, > > Thursday, August 29, 2019 11:00 AM, Maxime Coquelin: >> Subject: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver >> >> vDPA allows to offload Virtio Datapath processing by supported NICs, like >> IFCVF for example. >> >> T

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-10 Thread Matan Azrad
Hi Review for mlx5 part: Added not very important comment below. You can stay it as is if no new version will be created. Acked-by: Matan Azrad Thanks. From: Andrew Rybchenko > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to

[dpdk-dev] [PATCH] net/mlx5: fix netlink rdma socket callback routine

2019-09-10 Thread Viacheslav Ovsiienko
The mlx5 PMD uses Netlink socket to communicate with Infiniband devices kernel drivers to perform some control and setup operations. The kernel drivers send the information back to the user mode with Netlink messages which are processed in libnl callback routine. This routine perform reply message

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-09-10 Thread Jerin Jacob Kollanukkaran
Hi Xiang, Sorry for delay in response(Was busy with 19.11 proposal deadline). Please see inline. > > Reply to Xiang's queries in main thread: > > Hi all, > > Some questions regarding APIs. Could you please give more insights? > > 1) rte_regex_ops > a) rsp_flags > These two flags

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

2019-09-10 Thread Ferruh Yigit
On 9/10/2019 5:36 AM, Wang, Haiyue wrote: > Thanks Ferruh, Bruce. > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Monday, September 9, 2019 21:18 >> To: Richardson, Bruce >> Cc: Wang, Haiyue ; Ray Kinsella ; >> dev@dpdk.org; Sun, Chenmin >> >> Subject: Re: [dpdk-dev] [RFC v2 1/3

Re: [dpdk-dev] [PATCH v5 2/7] net/mlx5: add VLAN push/pop DR commands to glue

2019-09-10 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Monday, September 9, 2019 18:57 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v5 2/7] net/mlx5: add VLAN push/pop DR commands to glue > > This commit adds the mlx5dv VLAN push and pop commands to mlx5_g

Re: [dpdk-dev] [PATCH v5 1/7] net/mlx5: support for an action search in a list

2019-09-10 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Monday, September 9, 2019 18:57 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v5 1/7] net/mlx5: support for an action search in a list > > This commit adds a helper routine that supports searching for a

Re: [dpdk-dev] [PATCH v5 3/7] net/mlx5: support pop flow action on VLAN header

2019-09-10 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Monday, September 9, 2019 18:57 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v5 3/7] net/mlx5: support pop flow action on VLAN header > > This commit adds support for RTE_FLOW_ACTION_TYPE_OF_POP_VLAN v

Re: [dpdk-dev] [PATCH v5 7/7] net/mlx5: supp modify VLAN ID on existing VLAN hdr

2019-09-10 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Monday, September 9, 2019 18:57 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v5 7/7] net/mlx5: supp modify VLAN ID on existing VLAN hdr > > This commit adds support for modifying the VID of the outermo

Re: [dpdk-dev] [PATCH v5 5/7] net/mlx5: support modify VLAN priority on VLAN hdr

2019-09-10 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Monday, September 9, 2019 18:57 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v5 5/7] net/mlx5: support modify VLAN priority on VLAN hdr > > This commit adds support for modifying the VLAN priority (PCP

Re: [dpdk-dev] [PATCH v5 5/7] net/mlx5: support modify VLAN priority on VLAN hdr

2019-09-10 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Monday, September 9, 2019 18:57 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v5 5/7] net/mlx5: support modify VLAN priority on VLAN hdr > > This commit adds support for modifying the VLAN priority (PCP

[dpdk-dev] [PATCH 01/18] net/bonding: fix link speed update in broadcast mode

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov Fix the issue that the link speed of the bond device was set to the link speed of the first active slave in broadcast mode. Set the link speed of the bond device to the minimum value across all of the slaves in that case. Fixes: deba8a2f8b0b ("net/bonding: fix link properties

[dpdk-dev] [PATCH 03/18] app/testpmd: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov Add a wrapper for rte_eth_eth_link_get_nowait() that prints an error and returns a status code if the function fails. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- app/test-pmd/config.c | 13 ++--- app/test-pmd/softnicfwd.c | 16 +--

[dpdk-dev] [PATCH 05/18] net/ixgbe: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 -

[dpdk-dev] [PATCH 04/18] net/bonding: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_8023ad.c |

[dpdk-dev] [PATCH 00/18] ethdev: change link status get functions return value to int

2019-09-10 Thread Andrew Rybchenko
It is the fifth patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. It should be applied on top of [2], [3], [4] and [5]. Functions which return void are bad since they do not provide explicit information to the caller if everything is OK or no

[dpdk-dev] [PATCH 06/18] net/memif: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
The return value of rte_eth_link_get() was changed from void to int. Update the usage of the function according to the new return type. Just log error if something goes wrong. Signed-off-by: Andrew Rybchenko --- drivers/net/memif/rte_eth_memif.c | 12 ++-- 1 file changed, 10 insertions(

[dpdk-dev] [PATCH 07/18] app/proc-info: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- app/proc-info/main.c | 19 -

[dpdk-dev] [PATCH 02/18] ethdev: change link status get functions return value to int

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov Change rte_eth_link_get() and rte_eth_link_get_nowait() return value from void to int and return negative errno values in case of error conditions. Return value of link_update callback is ignored since the callback returns not errors but whether link up status has changed or n

[dpdk-dev] [PATCH 09/18] app/pipeline: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
The return value of rte_eth_link_get_nowait() was changed from void to int. Update the usage of the function according to the new return type. Signed-off-by: Andrew Rybchenko --- app/test-pipeline/init.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/app/test-pip

[dpdk-dev] [PATCH 12/18] examples/ip_pipeline: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/ip_pipeline/cli.c | 9 -

[dpdk-dev] [PATCH 08/18] app/test: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- app/test/test_link_bonding.c | 12 +

[dpdk-dev] [PATCH 14/18] examples/flow_filtering: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/flow_filtering/main.c | 8 ++--

[dpdk-dev] [PATCH 11/18] examples/bbdev_app: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/bbdev_app/main.c | 12 +---

[dpdk-dev] [PATCH 13/18] examples/ethtool: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/ethtool/lib/rte_ethtool.c | 6

[dpdk-dev] [PATCH 15/18] examples/link_status_interrupt: check status of getting link

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/link_status_interrupt/main.c | 16

[dpdk-dev] [PATCH 17/18] examples/qos_sched: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/qos_sched/init.c | 13 +++-

[dpdk-dev] [PATCH 16/18] examples/distributor: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/distributor/main.c | 14 ++

[dpdk-dev] [PATCH 18/18] examples/kni: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_link_get() and rte_eth_link_get_nowait() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/kni/main.c | 9 - 1 file c

[dpdk-dev] [PATCH 10/18] examples: check status of getting link info

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov Check return code of rte_eth_link_get_nowait() in all check_all_ports_link_status() functions in examples. Check is repeated for every function since the logic of some of them is different from others. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- example

[dpdk-dev] [PATCH v2 2/2] net/virtio: on demand cleanup when doing in order xmit

2019-09-10 Thread Marvin Liu
Check whether space are enough before burst enqueue operation. If more space is needed, will try to cleanup used descriptors for space on demand. It can give more chances to free used descriptors, thus will help RFC2544 performance. Signed-off-by: Marvin Liu --- drivers/net/virtio/virtio_rxtx.c

[dpdk-dev] [PATCH v2 1/2] net/virtio: update stats when in order xmit done

2019-09-10 Thread Marvin Liu
When doing xmit in-order enqueue, packets are buffered and then flushed into avail ring. Buffered packets can be dropped due to insufficient space. Moving stats update action just after successful avail ring updates can guarantee correctness. Signed-off-by: Marvin Liu --- drivers/net/virtio/virt

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

2019-09-10 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, September 10, 2019 16:07 > To: Wang, Haiyue ; Richardson, Bruce > > Cc: Ray Kinsella ; dev@dpdk.org; Sun, Chenmin > > Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace > information > > On 9/10/2019 5

[dpdk-dev] [PATCH v4] net/i40e: validate all messages from VF

2019-09-10 Thread alvinx . zhang
From: Alvin Zhang If VF driver in VM continuous sending invalid messages by mailbox, it will waste CPU cycles on PF driver and impact other VF drivers configuration. I40E PF PMD can count the numbers of invalid and unsupported messages from VFs, when the counter of statistics from a VF exceed max

[dpdk-dev] net/e1000: fix wrong mac type checking

2019-09-10 Thread Xiao Zhang
The mac types of i219 are e1000_pch_spt and e1000_pch_cnp, correct the checking code of mac type when flushing i219 descriptor rings. Fixes: 1fc9701238ed ("net/e1000: fix i219 hang on reset/close") Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang --- drivers/net/e1000/em_ethdev.c | 2 +- 1 file ch

[dpdk-dev] net/e1000: correct mb function

2019-09-10 Thread Xiao Zhang
Use rte_cio_wmb instead of rte_wmb when writing TX descriptor since it's CIO memory. Replace rte_io_wmb and E1000_PCI_REG_WRITE_RELAXED with E1000_PCI_REG_WRITE since it has rte_io_wmb inside, which will be more clear. Fixes: 1fc9701238ed ("net/e1000: fix i219 hang on reset/close") Cc: sta...@dpdk

[dpdk-dev] [PATCH 4/7] app/test: check status of getting MAC address

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_macaddr_get() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- app/test/test_event_eth_rx_adapter.c | 4 +++- app/test/test_event_eth

[dpdk-dev] [PATCH 2/7] app/testpmd: check status of getting MAC address

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov Add a wrapper for rte_eth_macaddr_get() that prints an error and returns a status code if the function fails. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- app/test-pmd/config.c | 14 +- app/test-pmd/testpmd.c | 13 + app/test-pmd/

[dpdk-dev] [PATCH 3/7] app/pdump: check status of getting MAC address

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_macaddr_get() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- app/pdump/main.c | 5 - 1 file changed, 4 insertions(+), 1 deletio

[dpdk-dev] [PATCH 0/7] ethdev: change MAC addr get function return value to int

2019-09-10 Thread Andrew Rybchenko
It is the sixth patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. It should be applied on top of [2], [3], [4], [5] and [6]. Functions which return void are bad since they do not provide explicit information to the caller if everything is OK

[dpdk-dev] [PATCH 1/7] ethdev: change MAC addr get function return value to int

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov Change rte_eth_macaddr_get() return value from void to int and return negative errno values in case of error conditions. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 1 - doc/guides/rel_notes/release_19_11.rst

[dpdk-dev] [PATCH 5/7] app/test: check status of getting MAC address in bonding

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_macaddr_get() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- app/test/test_link_bonding.c | 304 +

[dpdk-dev] [PATCH 6/7] examples: check status of getting MAC address

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_macaddr_get() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/bbdev_app/main.c | 8 +++- examples

[dpdk-dev] [PATCH 7/7] examples/bond: check status of getting MAC address

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov The return value of rte_eth_macaddr_get() was changed from void to int. Update the usage of the functions according to the new return type. Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- examples/bond/main.c | 58 +++-

[dpdk-dev] [PATCH 0/1] ethdev: change owner delete function return value to int

2019-09-10 Thread Andrew Rybchenko
It is the seventh patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. It should be applied on top of [2], [3], [4], [5], [6] and [7]. It can be applied separately with simple merge coflicts resolved in documentation. Functions which return void

[dpdk-dev] [PATCH 1/1] ethdev: change owner delete function return value to int

2019-09-10 Thread Andrew Rybchenko
From: Igor Romanov Change rte_eth_dev_owner_delete() return value from void to int and return negative errno values in case of error conditions. Right now there is only one error case for rte_eth_dev_owner_delete() - invalid owner, but it still makes sense to return error to catch bugs in the co

Re: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd

2019-09-10 Thread Ananyev, Konstantin
> > > > > > > > Lock-free mode is supported by hash library and LPM library. > > > Now we add an option for l3fwd example to enable the lock-free mode. > > > Necessary preparation steps are added to use lock-free LPM mode. > > > > Can I ask about the purpose of these changes? > > Right now in l

[dpdk-dev] [Bug 346] Set the link speed / duplex of a DPDK port

2019-09-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=346 Bug ID: 346 Summary: Set the link speed / duplex of a DPDK port Product: DPDK Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED Severity: enhancemen

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

2019-09-10 Thread Ferruh Yigit
On 9/10/2019 9:37 AM, Wang, Haiyue wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, September 10, 2019 16:07 >> To: Wang, Haiyue ; Richardson, Bruce >> >> Cc: Ray Kinsella ; dev@dpdk.org; Sun, Chenmin >> >> Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API fo

Re: [dpdk-dev] net/e1000: fix wrong mac type checking

2019-09-10 Thread Kevin Traynor
On 10/09/2019 18:40, Xiao Zhang wrote: > The mac types of i219 are e1000_pch_spt and e1000_pch_cnp, correct the > checking code of mac type when flushing i219 descriptor rings. > > Fixes: 1fc9701238ed ("net/e1000: fix i219 hang on reset/close") > Cc: sta...@dpdk.org > > Signed-off-by: Xiao Zhang

Re: [dpdk-dev] [PATCH 2/9] eal: syslog implementation for windows

2019-09-10 Thread Stephen Hemminger
On Mon, 9 Sep 2019 12:53:57 -0700 Pallavi Kadam wrote: > +/* Copyright (c) 1982, 1986, 1988, 1993 > + * The Regents of the University of California. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided t

Re: [dpdk-dev] [PATCH 3/9] eal: add windows compatible header files

2019-09-10 Thread Stephen Hemminger
On Mon, 9 Sep 2019 12:53:58 -0700 Pallavi Kadam wrote: > --- /dev/null > +++ b/lib/librte_eal/windows/eal/include/getopt.h > @@ -0,0 +1,59 @@ > +/* musl as a whole is licensed under the following standard MIT license: > + * > + * --

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix Tx CQ doorbell synchronization on aarch64

2019-09-10 Thread Phil Yang (Arm Technology China)
Hi, Slava Thank you for taking the time to review this patch. I agree with you. The current design is very comprehensive. I will abandon this patch. Thanks, Phil Yang

Re: [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for packed vring desc avail flags

2019-09-10 Thread Gavin Hu (Arm Technology China)
Hi Yinan, We have done a comparative analysis and found with the old code the if(weak_barriers) and else branches were saved on x86 as rte_smp_wmb and rte_cio_wmb are identical. http://git.dpdk.org/dpdk/tree/drivers/net/virtio/virtqueue.h#n49 For the new code, with Joyce's patches applied, th

Re: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd

2019-09-10 Thread Ruifeng Wang (Arm Technology China)
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, September 10, 2019 17:06 > To: Ruifeng Wang (Arm Technology China) ; > Kantecki, Tomasz > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > Honnappa Nagarahalli ; nd > ; nd > Subject: RE: [dpdk-dev] [PATCH 0/2] add l

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Zapolski, MarcinX A
<...> > @@ -3994,7 +4054,55 @@ void * > rte_eth_dev_get_sec_ctx(uint16_t port_id); > > > -#include > +struct rte_eth_dev_callback; > +/** Structure to keep track of registered callbacks */ > +TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback); > + > +/** > + * Structure used to hold informat

[dpdk-dev] [PATCH 1/2] net/enic: enable Geneve with options offload

2019-09-10 Thread Hyong Youb Kim
Latest firmware supports Geneve with options offload. Current overlay offload only supports Geneve with no options. This new feature is disabled by default, as it is intrusive and cannot be used with flow API. Add a new devarg 'geneve-opt' so the user can explicitly enable it. Signed-off-by: Hyong

[dpdk-dev] [PATCH 0/2] net/enic: a couple new features

2019-09-10 Thread Hyong Youb Kim
The first patch enables Geneve offload that supports Geneve header options. Previous Geneve offload does not work when options are present. The second patch adds the new flow implementation based on Flow Manager. So the driver now has two implementations: one based on the old filter API, and this

[dpdk-dev] [PATCH 2/2] net/enic: add flow implementation based on Flow Manager API

2019-09-10 Thread Hyong Youb Kim
Flow Manager API is the new firmware interface that exposes match action capabilities in 1400 series VIC adapters. It is intended for virtual switch offloads and enables more advanced features than the existing filter API. For example, it supports VXLAN encap and decap actions, and exposes TCAM and

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Bruce Richardson
On Tue, Sep 10, 2019 at 09:59:51AM +, Zapolski, MarcinX A wrote: > <...> > > @@ -3994,7 +4054,55 @@ void * > > rte_eth_dev_get_sec_ctx(uint16_t port_id); > > > > > > -#include > > +struct rte_eth_dev_callback; > > +/** Structure to keep track of registered callbacks */ > > +TAILQ_HEAD(rte_e

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Zapolski, MarcinX A
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, September 10, 2019 12:07 PM > To: Zapolski, MarcinX A > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > structures from public API > > On Tue, Sep 10,

Re: [dpdk-dev] [PATCH v3 1/2] virtio: one way barrier for packed vring desc avail flags

2019-09-10 Thread Maxime Coquelin
Thanks Yinan for reporting the regresion and Gavin for the analysis. On 9/10/19 11:48 AM, Gavin Hu (Arm Technology China) wrote: > Hi Yinan, > > We have done a comparative analysis and found with the old code the > if(weak_barriers) and else branches were saved on x86 as rte_smp_wmb and > rte_c

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-09-10 Thread Jerin Jacob Kollanukkaran
> Hi Jerin, > > Thursday, August 15, 2019 2:34 PM, Thomas Monjalon: > > Subject: Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev > > subsystem > > > > +Cc more > > > > > > > > From: Jerin Jacob > > > > Even though there are some vendors which offer Regex HW offlo

[dpdk-dev] [PATCH v1 0/2] Update MC firmware version for FSLMC bus and DPAA2 devices

2019-09-10 Thread Sachin Saxena
This patch add the support for new Management Complex Firmware version to 10.18.x. Sachin Saxena (2): bus/fslmc: update MC firmware version for FSLMC bus net/dpaa2: update MC firmware version for FSLMC bus drivers/bus/fslmc/mc/fsl_dpio_cmd.h| 4 +-- drivers/bus/fslmc/mc/fsl_dpmng.h

[dpdk-dev] [PATCH v1 1/2] bus/fslmc: update MC firmware version for FSLMC bus

2019-09-10 Thread Sachin Saxena
MC firmware is the core component of FSLMC bus and DPAA2 devices. Prior to this patch, MC firmware supported 10.14.x version. This patch bumps the min supported version to 10.18.x. Signed-off-by: Sachin Saxena --- drivers/bus/fslmc/mc/fsl_dpio_cmd.h | 4 ++-- drivers/bus/fslmc/mc/fsl

[dpdk-dev] [PATCH v1 2/2] net/dpaa2: update MC firmware version for FSLMC bus

2019-09-10 Thread Sachin Saxena
MC firmware is the core component of FSLMC bus and net/DPAA2 devices. Prior to this patch, MC firmware supported 10.14.x version. This patch bumps the min supported version to 10.18.x. Signed-off-by: Sachin Saxena --- drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 1 + drivers/net/dpaa2/d

Re: [dpdk-dev] [PATCH v5 4/7] net/mlx5: support push flow action on VLAN header

2019-09-10 Thread Slava Ovsiienko
> -Original Message- > From: Moti Haimovsky > Sent: Monday, September 9, 2019 18:57 > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v5 4/7] net/mlx5: support push flow action on VLAN header > > This commit adds support for RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-10 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > This action type allows the burst of symmetric crypto workload using the > same > > > algorithm, key, and direction being processed by CPU cycles synchronously. > > > This flexible action type does not require external hardware involvement, > > > having the

Re: [dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

2019-09-10 Thread Jerin Jacob Kollanukkaran
> Hi Jerin, Hi Shahaf, Sorry for delay in response(Was busy with 19.11 proposal deadline). Please see inline. > > > > RegEx pattern matching applications: > > • Next Generation Firewalls (NGFW) > > • Deep Packet and Flow Inspection (DPI) > > • Intrusion Prevention Systems (IPS) > > • DDoS Mitig

[dpdk-dev] [PATCH v1 1/1] mempool/octeontx2: remove minimum chunck size limitation

2019-09-10 Thread vattunuru
From: Vamsi Attunuru Memory required for the mempool objects need not be physically contiguous on octeontx2's HW, mempool pmd supports the minimum chunk size set by the default handler. Hence discarding the limitation set by the pmd on the min_chunk_size value. Signed-off-by: Vamsi Attunuru ---

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-10 Thread Akhil Goyal
Hi Fan, > > Hi Akhil, > > You are right, the new API will process the crypto workload, no heavy enqueue > Dequeue operations required. > > Cryptodev tends to support multiple crypto devices, including HW and SW. > The 3-cache line access, iova address computation and assignment, simulation > of

Re: [dpdk-dev] [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto asym support

2019-09-10 Thread Anoob Joseph
Hi Thomas, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, September 10, 2019 12:00 PM > To: Jerin Jacob Kollanukkaran ; Anoob Joseph > > Cc: Akhil Goyal ; Pablo de Lara > ; Narayana Prasad Raju Athreya > ; Fiona Trahe ; Kanaka > Durga Kot

Re: [dpdk-dev] [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto asym support

2019-09-10 Thread Akhil Goyal
Hi Anoob, > > Hi Thomas, > > Please see inline. > > Thanks, > Anoob > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday, September 10, 2019 12:00 PM > > To: Jerin Jacob Kollanukkaran ; Anoob Joseph > > > > Cc: Akhil Goyal ; Pablo de Lara > > ; Narayana Prasad Raju At

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

2019-09-10 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, September 10, 2019 17:15 > To: Wang, Haiyue ; Richardson, Bruce > > Cc: Ray Kinsella ; dev@dpdk.org; Sun, Chenmin > > Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace > information > > On 9/10/2019 9

Re: [dpdk-dev] [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto asym support

2019-09-10 Thread Thomas Monjalon
10/09/2019 13:33, Anoob Joseph: > From: Thomas Monjalon > > 10/09/2019 06:13, Jerin Jacob Kollanukkaran: > > > From: Anoob Joseph > > > > Adding documentation for asymmetric features supported by > > > > crypto_octeontx2 PMD. > > > > > > > > Signed-off-by: Anoob Joseph > > > > Signed-off-by: Kan

Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files

2019-09-10 Thread Wei Hu (Xavier)
Hi, Ferruh Yigit On 2019/8/30 22:58, Ferruh Yigit wrote: > On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote: >> This patch add build related files for hns3 PMD driver. >> >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Min Hu (Connor) >> Signed-off-by: Chunsong Feng >> Signed-off-by: Hao Chen

Re: [dpdk-dev] [PATCH] net/mlx5: fix netlink rdma socket callback routine

2019-09-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Tuesday, September 10, 2019 11:05 AM > To: dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix netlink rdma socket callback > routine > > The mlx5 PMD uses Netlink socke

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Tuesday, September 3, 2019 3:35 PM > To: dev@dpdk.org > Cc: Matan Azrad ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN > insertions > > If VLAN tag insertion transmi

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Bruce Richardson
On Tue, Sep 10, 2019 at 11:13:50AM +0100, Zapolski, MarcinX A wrote: > > -Original Message- > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Tuesday, September 10, 2019 12:07 PM > > To: Zapolski, MarcinX A > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [RFC 19.11

Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev structures from public API

2019-09-10 Thread Zapolski, MarcinX A
> -Original Message- > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, September 10, 2019 2:20 PM > To: Zapolski, MarcinX A > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC 19.11 v2 1/3] ethdev: hide key ethdev > structures from public API > > On Tue, Sep 10,

Re: [dpdk-dev] [PATCH 6/6] doc: add documentation for OCTEON TX2 crypto asym support

2019-09-10 Thread Anoob Joseph
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Tuesday, September 10, 2019 5:10 PM > To: Anoob Joseph ; Thomas Monjalon > ; Jerin Jacob Kollanukkaran > Cc: Pablo de Lara ; Narayana Prasad Raju > Athreya ; Fiona Trahe ; > Kanaka Durga Kotamarthy ; Shally Verma > ; Sunila Sahu

Re: [dpdk-dev] [PATCH] net/ixgbe: add security statistics

2019-09-10 Thread Ananyev, Konstantin
Hi Radu, > > > >> Update IXGBE PMD with support for IPsec statistics. > > The proposed approach - have a new hash table per device, > > plus parse each packet on RX and TX and do hash lookup > > seems way too heavy to put it into PMD. > > It is indeed heavy, but it's disabled by default and it o

[dpdk-dev] [PATCH] app/test: add unit test cases to mempool library

2019-09-10 Thread Pallantla Poornima
Added UT in mempool.c to cover below functions: rte_mempool_populate_anon() rte_mempool_memchunk_anon_free() get_anon_size() rte_mempool_mem_iter() Signed-off-by: Pallantla Poornima --- app/test/test_mempool.c | 74 + 1 file changed, 74 insertions(

Re: [dpdk-dev] [PATCH v5 0/7] net/mlx5: support for flow action on VLAN header

2019-09-10 Thread Raslan Darawsheh
Hi, Series applied to next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: Moti Haimovsky > Sent: Monday, September 9, 2019 6:57 PM > To: Slava Ovsiienko ; Raslan Darawsheh > > Cc: dev@dpdk.org > Subject: [PATCH v5 0/7] net/mlx5: support for flow action on VLAN

Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver

2019-09-10 Thread Shahaf Shuler
Tuesday, September 10, 2019 10:46 AM, Maxime Coquelin: > Subject: Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver > > Hi Shahaf, > > On 9/9/19 1:55 PM, Shahaf Shuler wrote: > > Hi Maxime, > > > > Thursday, August 29, 2019 11:00 AM, Maxime Coquelin: > >> Subject: [dpdk-dev] [PATCH 00/15]

Re: [dpdk-dev] [PATCH] net/mlx5: support reading module EEPROM data

2019-09-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Monday, September 9, 2019 2:05 PM > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: support reading module EEPROM > data > > This patch implemen

[dpdk-dev] [PATCH v2] net/mlx5: fix netlink rdma socket callback routine

2019-09-10 Thread Viacheslav Ovsiienko
The mlx5 PMD uses Netlink socket to communicate with Infiniband devices kernel drivers to perform some control and setup operations. The kernel drivers send the information back to the user mode with Netlink messages which are processed in libnl callback routine. This routine perform reply message

Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver

2019-09-10 Thread Maxime Coquelin
On 9/10/19 3:44 PM, Shahaf Shuler wrote: > Tuesday, September 10, 2019 10:46 AM, Maxime Coquelin: >> Subject: Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver >> >> Hi Shahaf, >> >> On 9/9/19 1:55 PM, Shahaf Shuler wrote: >>> Hi Maxime, >>> >>> Thursday, August 29, 2019 11:00 AM, Maxime

Re: [dpdk-dev] [PATCH] net/af_xdp: fix Tx halt when no recv packets

2019-09-10 Thread Ye Xiaolong
On 09/10, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Tuesday, September 10, 2019 12:13 AM >> To: Yigit, Ferruh ; Loftus, Ciara >> ; Ye, Xiaolong ; Zhang, Qi Z >> >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: [PATCH] net/af_xdp: fix Tx halt when no recv p

Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information

2019-09-10 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, September 10, 2019 17:15 > To: Wang, Haiyue ; Richardson, Bruce > > Cc: Ray Kinsella ; dev@dpdk.org; Sun, Chenmin > > Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace > information > > On 9/10/2019 9

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix netlink rdma socket callback routine

2019-09-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, September 10, 2019 4:52 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix netlink rdma socket callback routine > > The mlx5 PMD uses Netlink socket to communicate with

  1   2   >