Re: [dpdk-dev] unable to receive packets less than 4 with rte_eth_rx_burst Api -regarding.

2019-09-03 Thread Wang, Haiyue
Some PMD Vector Rx for performance has an hidden limitation like : /* nb_pkts shall be less equal than RTE_I40E_MAX_RX_BURST */ nb_pkts = RTE_MIN(nb_pkts, RTE_I40E_MAX_RX_BURST); /* nb_pkts has to be floor-aligned to RTE_I40E_DESCS_PER_LOOP */ nb_pkts = RTE_ALIGN_F

[dpdk-dev] [RFC] net/mlx5: add metering support

2019-09-03 Thread Suanming Mou
The mlx5 PMD will support the rte_mtr APIs with type srTCM(IETF RFC 2697) color blind mode. The metering flow will be composed of three flow tables, the prefix table, the metering table and the suffix table.     packet > prefix table > metering table > suffix table The prefix t

Re: [dpdk-dev] [PATCH 01/15] vhost: remove vhost kernel header inclusion

2019-09-03 Thread Maxime Coquelin
On 9/2/19 8:03 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:46AM +0200, Maxime Coquelin wrote: >> This is preliminary rework for virtio-vdpa driver, in >> order to avoid conflicts with Virtio PMD headers. >> >> Generally, I think it is better not to include kernel >> headers in RTE heade

Re: [dpdk-dev] [PATCH 06/15] net/virtio: add skeleton for virtio vDPA driver

2019-09-03 Thread Maxime Coquelin
On 9/2/19 8:27 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:51AM +0200, Maxime Coquelin wrote: >> + >> +RTE_PMD_REGISTER_PCI(net_virtio_vdpa, rte_virtio_vdpa); >> +RTE_PMD_REGISTER_PCI_TABLE(net_virtio_vdpa, pci_id_virtio_vdpa_map); >> +RTE_PMD_REGISTER_KMOD_DEP(net_virtio_vdpa, "* vfio-

Re: [dpdk-dev] [PATCH 04/15] net/virtio: add virtio PCI subsystem device ID declaration

2019-09-03 Thread Maxime Coquelin
On 9/2/19 8:14 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:49AM +0200, Maxime Coquelin wrote: >> The Virtio PCI susbsytem IDs need to be specified to >> prevent it to probe IFC vDPA VFs. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio_pci.h | 1 + >> 1 file ch

[dpdk-dev] [PATCH] pmdinfogen: add SPDX license tag

2019-09-03 Thread Hemant Agrawal
This patch adds SPDX license tag to pmdinfogen files. These files are originally drived from kernel. They are being used as binary tool to support internal build. This patch requires license exception approval from DPDK Technical Board and Governing Board. Signed-off-by: Hemant Agrawal --- bui

Re: [dpdk-dev] [PATCH 08/15] net/virtio: add virtio vDPA op to get features

2019-09-03 Thread Maxime Coquelin
On 9/2/19 8:43 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:53AM +0200, Maxime Coquelin wrote: >> This patch implements the vDPA .get_features() callback. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio_vdpa.c | 32 >> 1 file ch

[dpdk-dev] [PATCH v3] net/ice: support device-specific DDP package loading

2019-09-03 Thread Ting Xu
This patch adds the feature that supports loading DDP package according to the device serial number. Prior to loading the default DDP package (ice.pkg), the driver will check for the presence of a device-specific DDP package with the name containing 64-bit PCIe Device Serial Number (ice-xxx

Re: [dpdk-dev] [PATCH 11/15] net/virtio: add vDPA op to stop and close the device

2019-09-03 Thread Maxime Coquelin
On 9/2/19 9:07 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:56AM +0200, Maxime Coquelin wrote: >> This patch implements the vDPA .dev_close() callback. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio_vdpa.c | 52 >> 1 file chang

Re: [dpdk-dev] [PATCH 02/15] vhost: configure vDPA as soon as the device is ready

2019-09-03 Thread Maxime Coquelin
On 9/2/19 11:02 AM, Wang, Xiao W wrote: > Hi, > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Monday, September 2, 2019 4:35 PM >> To: Maxime Coquelin >> Cc: Bie, Tiwei ; Wang, Zhihong >> ; amore...@redhat.com; Wang, Xiao W >> ; dev@dpdk.org; jfreim...@redhat.com; >> sta...@dpdk

Re: [dpdk-dev] [PATCH 14/15] net/virtio: add vDPA op to get notification area

2019-09-03 Thread Maxime Coquelin
On 9/3/19 7:02 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:59AM +0200, Maxime Coquelin wrote: >> This patch implements the vDPA .get_notify_area() >> callback. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio_vdpa.c | 33 >> 1 f

Re: [dpdk-dev] [PATCH 10/15] net/virtio: add vDPA op to configure and start the device

2019-09-03 Thread Maxime Coquelin
On 9/3/19 7:30 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:55AM +0200, Maxime Coquelin wrote: >> In order to support multi-queue, we need to implement the control >> path. The problem is that both the Vhost-user master and slave use >> VAs in their processes address spaces as IOVAs, whi

Re: [dpdk-dev] [PATCH 00/11] Fixing log levels for dynamically loaded drivers

2019-09-03 Thread David Marchand
On Mon, Sep 2, 2019 at 4:17 PM Ferruh Yigit wrote: > > On 8/19/2019 12:41 PM, David Marchand wrote: > > All (but the Solarflare net driver) drivers currently do not care about > > the log level the user might have passed at init time. > > Is this comment for the shared libraries? > Because otherwi

Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-09-03 Thread David Marchand
On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit wrote: > > On 8/19/2019 12:41 PM, David Marchand wrote: > > The function rte_log_register_type_and_pick_level() fills a gap for > > dynamically loaded code (especially drivers) who would not pick up > > the log level passed at startup. > > > > Let's prom

Re: [dpdk-dev] [PATCH 10/11] drivers/net: use new logtype wrapper

2019-09-03 Thread David Marchand
On Mon, Sep 2, 2019 at 6:11 PM Ferruh Yigit wrote: > > On 8/19/2019 12:41 PM, David Marchand wrote: > > Make use of the newly introduced wrapper. > > > > Signed-off-by: David Marchand > > <...> > > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > > index 931e4f4..c71b68e 100644

Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-03 Thread Ye Xiaolong
On 09/03, Pei, Andy wrote: >Hi Xiaolong, > >I tried, but compile issue exist. Er, what's the exact compiling issue after the type cast? We can see the similar usage in function like replay_num_bucket @lib/librte_ipsec/sa.c. Thanks, Xiaolong > >-Original Message- >From: Ye, Xiaolong >Sent

Re: [dpdk-dev] [PATCH 14/15] net/virtio: add vDPA op to get notification area

2019-09-03 Thread Tiwei Bie
On Tue, Sep 03, 2019 at 09:36:54AM +0200, Maxime Coquelin wrote: > On 9/3/19 7:02 AM, Tiwei Bie wrote: > > On Thu, Aug 29, 2019 at 09:59:59AM +0200, Maxime Coquelin wrote: > >> This patch implements the vDPA .get_notify_area() > >> callback. > >> > >> Signed-off-by: Maxime Coquelin > >> --- > >>

Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-03 Thread Pei, Andy
Oh, I misuse () when casting. Now it works. -Original Message- From: Ye, Xiaolong Sent: Tuesday, September 3, 2019 4:35 PM To: Pei, Andy Cc: dev@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh ; Xu, Rosen Subject: Re: [PATCH v3] net/ipn3ke: setup MTU when HW init On 09/03, Pei, Andy wrote: >Hi

Re: [dpdk-dev] [PATCH 02/11] log: define logtype register wrapper for drivers

2019-09-03 Thread Ferruh Yigit
On 9/3/2019 9:06 AM, David Marchand wrote: > On Mon, Sep 2, 2019 at 4:29 PM Ferruh Yigit wrote: >> >> On 8/19/2019 12:41 PM, David Marchand wrote: >>> The function rte_log_register_type_and_pick_level() fills a gap for >>> dynamically loaded code (especially drivers) who would not pick up >>> the

Re: [dpdk-dev] [PATCH 10/15] net/virtio: add vDPA op to configure and start the device

2019-09-03 Thread Tiwei Bie
On Tue, Sep 03, 2019 at 09:40:25AM +0200, Maxime Coquelin wrote: > On 9/3/19 7:30 AM, Tiwei Bie wrote: > > On Thu, Aug 29, 2019 at 09:59:55AM +0200, Maxime Coquelin wrote: > >> In order to support multi-queue, we need to implement the control > >> path. The problem is that both the Vhost-user maste

[dpdk-dev] [PATCH v4] net/ipn3ke: setup MTU when HW init

2019-09-03 Thread Andy Pei
set up mtu to the minimun in tx mtu, rx mtu and IPN3KE_MAC_FRAME_SIZE_MAX. Signed-off-by: Andy Pei --- Cc: qi.z.zh...@intel.com Cc: ferruh.yi...@intel.com Cc: rosen...@intel.com Cc: xiaolong...@intel.com v2: modify low bound and upper bound. v3: delete unnecessary MACROs. extract the duplicate

Re: [dpdk-dev] unable to receive packets less than 4 with rte_eth_rx_burst Api -regarding.

2019-09-03 Thread Perugu Hemasai Chandra Prasad
Hi, I tried changing "RTE_I40E_DESCS_PER_LOOP" located in i40e_rxtx.h to 1 and recompiling DPDK but it didn't work. Is there any procedure to make it work for rx_burst of 1 packet? On Tue, 3 Sep, 2019, 12:32 Wang, Haiyue, wrote: > Some PMD Vector Rx for performance has an hidden limitation like

[dpdk-dev] [PATCH v2] security: add statistics definitions and update API

2019-09-03 Thread Radu Nicolau
Update IPsec statistics struct definition, add per SA statistics collection enable flag. Signed-off-by: Radu Nicolau --- v2: added second reserved field lib/librte_security/rte_security.h | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/lib/librte_se

Re: [dpdk-dev] [PATCH v3] net/ice: support device-specific DDP package loading

2019-09-03 Thread Ye Xiaolong
Hi, Ting On 09/03, Ting Xu wrote: >This patch adds the feature that supports loading DDP package >according to the device serial number. Prior to loading the >default DDP package (ice.pkg), the driver will check for the >presence of a device-specific DDP package with the name containing >64-bit PC

[dpdk-dev] [PATCH 0/2] Add external mbufs option

2019-09-03 Thread Adam Dybkowski
This patchset adds a unit test of the external buffers functionality and adds a new option to the compression performance benchmark tool to use memzones as external buffers instead of the data put directly inside mbufs. Adam Dybkowski (2): test/compress: add external buffer in mbuf API test ap

Re: [dpdk-dev] unable to receive packets less than 4 with rte_eth_rx_burst Api -regarding.

2019-09-03 Thread Perugu Hemasai Chandra Prasad
Hi Haiyue, It is working ,thanks for your response. can you please tell what kind of performance limitation we have if RTE_I40E_DESCS_PER_LOOP value is less than 4 ? Thanks & Regards, Hemasai On Tue, Sep 3, 2019 at 2:53 PM Perugu Hemasai Chandra Prasad < hemasaiper...@5g.iith.ac

[dpdk-dev] [PATCH 1/2] test/compress: add external buffer in mbuf API test

2019-09-03 Thread Adam Dybkowski
Adds a new test to verify external buffer in mbuf APIs. Initialize fields in test_data_params structures by name for better readability. Signed-off-by: Adam Dybkowski --- app/test/test_compressdev.c | 245 1 file changed, 194 insertions(+), 51 deletions(-) d

[dpdk-dev] [PATCH 2/2] app/compress-perf: add external mbufs option

2019-09-03 Thread Adam Dybkowski
This patch adds new performance measurement option --external-mbufs that allocates and uses memzones as external buffers instead of putting the data directly inside mbufs. Signed-off-by: Adam Dybkowski --- app/test-compress-perf/comp_perf_options.h| 2 + .../comp_perf_options_parse.c

Re: [dpdk-dev] [PATCH v2] security: add statistics definitions and update API

2019-09-03 Thread Anoob Joseph
Hi Radu, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Radu Nicolau > Sent: Tuesday, September 3, 2019 3:12 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; konstantin.anan...@intel.com; > bernard.iremon...@intel.com; declan.dohe...@intel.com; > step...@

Re: [dpdk-dev] [PATCH v2] security: add statistics definitions and update API

2019-09-03 Thread Nicolau, Radu
Hi, replies inline: On 9/3/2019 11:04 AM, Anoob Joseph wrote: Hi Radu, Please see inline. Thanks, Anoob -Original Message- From: dev On Behalf Of Radu Nicolau Sent: Tuesday, September 3, 2019 3:12 PM To: dev@dpdk.org Cc: akhil.go...@nxp.com; konstantin.anan...@intel.com; bernard.ire

[dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-09-03 Thread jerinj
From: Jerin Jacob Added eBPF arm64 JIT support to improve the eBPF program performance on arm64. dpdk.org/examples/bpf/t1.c application shows around 50% improvement on OCTEON TX2 platform in JIT vs interpreter mode. Verified the implementation using existing bpf_autotest application. # echo "b

Re: [dpdk-dev] [PATCH 02/15] vhost: configure vDPA as soon as the device is ready

2019-09-03 Thread Wang, Xiao W
Hi > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, September 3, 2019 3:35 PM > To: Wang, Xiao W ; Ye, Xiaolong > > Cc: Bie, Tiwei ; Wang, Zhihong > ; amore...@redhat.com; dev@dpdk.org; > jfreim...@redhat.com; sta...@dpdk.org > Subject: Re:

[dpdk-dev] [PATCH 1/8] bpf/arm64: add build infrastructure

2019-09-03 Thread jerinj
From: Jerin Jacob Add build infrastructure and documentation update for arm64 JIT support. Signed-off-by: Jerin Jacob --- MAINTAINERS| 1 + doc/guides/prog_guide/bpf_lib.rst | 2 +- doc/guides/rel_notes/release_19_11.rst | 5 + lib/librte_bpf/Makefile

[dpdk-dev] [PATCH 3/8] bpf/arm64: add basic arithmetic operations

2019-09-03 Thread jerinj
From: Jerin Jacob Add mov, add, sub, mul, div and mod arithmetic operations for immediate and source register variants. Signed-off-by: Jerin Jacob --- lib/librte_bpf/bpf_jit_arm64.c | 300 - 1 file changed, 299 insertions(+), 1 deletion(-) diff --git a/lib/libr

[dpdk-dev] [PATCH 4/8] bpf/arm64: add logical operations

2019-09-03 Thread jerinj
From: Jerin Jacob Add OR, AND, NEG, XOR, shift operations for immediate and source register variants. Signed-off-by: Jerin Jacob --- lib/librte_bpf/bpf_jit_arm64.c | 189 + 1 file changed, 189 insertions(+) diff --git a/lib/librte_bpf/bpf_jit_arm64.c b/lib/libr

[dpdk-dev] [PATCH 6/8] bpf/arm64: add load and store operations

2019-09-03 Thread jerinj
From: Jerin Jacob Add load and store operations. Signed-off-by: Jerin Jacob --- lib/librte_bpf/bpf_jit_arm64.c | 84 ++ 1 file changed, 84 insertions(+) diff --git a/lib/librte_bpf/bpf_jit_arm64.c b/lib/librte_bpf/bpf_jit_arm64.c index ec165d627..c797c9c62 1006

[dpdk-dev] [PATCH 2/8] bpf/arm64: add prologue and epilogue

2019-09-03 Thread jerinj
From: Jerin Jacob Add prologue and epilogue as per arm64 procedure call standard. As an optimization the generated instructions are the function of whether eBPF program has stack and/or CALL class. Signed-off-by: Jerin Jacob --- lib/librte_bpf/bpf_jit_arm64.c | 466 +++

[dpdk-dev] [PATCH 7/8] bpf/arm64: add atomic-exchange-and-add operation

2019-09-03 Thread jerinj
From: Jerin Jacob Implement XADD eBPF instruction using STADD arm64 instruction. If the given platform does not have atomics support, use LDXR and STXR pair for critical section instead of STADD. Signed-off-by: Jerin Jacob --- lib/librte_bpf/bpf_jit_arm64.c | 85 +++

[dpdk-dev] [PATCH 5/8] bpf/arm64: add byte swap operations

2019-09-03 Thread jerinj
From: Jerin Jacob add le16, le32, le64, be16, be32 and be64 operations. Signed-off-by: Jerin Jacob --- lib/librte_bpf/bpf_jit_arm64.c | 87 ++ 1 file changed, 87 insertions(+) diff --git a/lib/librte_bpf/bpf_jit_arm64.c b/lib/librte_bpf/bpf_jit_arm64.c index fc

[dpdk-dev] [PATCH 8/8] bpf/arm64: add branch operation

2019-09-03 Thread jerinj
From: Jerin Jacob Add branch and call operations. jump_offset_* APIs used for finding the relative offset to jump w.r.t current eBPF program PC. Signed-off-by: Jerin Jacob --- lib/librte_bpf/bpf_jit_arm64.c | 229 + 1 file changed, 229 insertions(+) diff --git

Re: [dpdk-dev] [PATCH 11/11] doc: add documentation for OCTEON TX2 crypto PMD

2019-09-03 Thread Anoob Joseph
Hi Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, September 3, 2019 10:52 AM > To: Anoob Joseph ; Akhil Goyal > ; Pablo de Lara ; > Thomas Monjalon > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; Ankur Dwivedi ; > T

Re: [dpdk-dev] [EXT] Re: [PATCH v2] security: add statistics definitions and update API

2019-09-03 Thread Anoob Joseph
Hi Radu, Please see inline. Thanks, Anoob > -Original Message- > From: Nicolau, Radu > Sent: Tuesday, September 3, 2019 3:44 PM > To: Anoob Joseph ; dev@dpdk.org > Cc: akhil.go...@nxp.com; konstantin.anan...@intel.com; > bernard.iremon...@intel.com; declan.dohe...@intel.com; > step...@n

Re: [dpdk-dev] unable to receive packets less than 4 with rte_eth_rx_burst Api -regarding.

2019-09-03 Thread Wang, Haiyue
Hi Hemasai You can see the comments in code like " /* A.1 load 4 pkts desc */ ", it use vector instruction to handle HW desc *in batch*. And also, you can change it to non-vector function by adjust some parameters, please refer to i40e_set_rx_function for detail, it has debug message for your

Re: [dpdk-dev] [PATCH 02/51] app/testpmd: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
On 9/2/19 3:40 PM, Ferruh Yigit wrote: On 8/27/2019 3:25 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Add eth_dev_info_get_print_err() which is a wrapper for rte_eth_dev_info_get() printing error if rte_eth_dev_info_get() fails and returning its status code. Signed-off-by: Ivan Ilchenko S

Re: [dpdk-dev] [PATCH 01/51] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-03 Thread Andrew Rybchenko
On 9/2/19 12:33 PM, Ferruh Yigit wrote: On 8/29/2019 5:56 PM, Thomas Monjalon wrote: 28/08/2019 16:39, Andrew Rybchenko: On 8/28/19 2:26 PM, Jan Viktorin wrote: Andrew Rybchenko wrote: On 8/28/19 12:51 PM, Jan Viktorin wrote: Andrew Rybchenko wrote: From: Ivan Ilchenko + * @return + *

Re: [dpdk-dev] [PATCH 00/51] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-03 Thread Andrew Rybchenko
On 8/29/19 8:05 PM, Thomas Monjalon wrote: 28/08/2019 16:29, Andrew Rybchenko: On 8/28/19 4:42 PM, Aaron Conole wrote: Andrew Rybchenko writes: On 8/27/19 11:47 PM, Aaron Conole wrote: Andrew Rybchenko writes: It is the first patch series to get rid of void returning functions in ethdev i

[dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-03 Thread Viacheslav Ovsiienko
If VLAN tag insertion transmit offload is engaged (DEV_TX_OFFLOAD_VLAN_INSERT in tx queue configuration is set) the transmit descriptor may be built with wrong format, due to packet length is not adjusted. Also, the ring buffer wrapup is not handled correctly. Fixes: 18a1c20044c0 ("net/mlx5: imple

Re: [dpdk-dev] [PATCH 01/51] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-03 Thread Ferruh Yigit
On 9/3/2019 1:09 PM, Andrew Rybchenko wrote: > On 9/2/19 12:33 PM, Ferruh Yigit wrote: >> On 8/29/2019 5:56 PM, Thomas Monjalon wrote: >>> 28/08/2019 16:39, Andrew Rybchenko: On 8/28/19 2:26 PM, Jan Viktorin wrote: > Andrew Rybchenko wrote: >> On 8/28/19 12:51 PM, Jan Viktorin wrote:

[dpdk-dev] [PATCH] security: update doxygen fields

2019-09-03 Thread Radu Nicolau
Replace /**< with /** for multiline doxygen comments. Signed-off-by: Radu Nicolau --- lib/librte_security/rte_security.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h index 96806e3..d569

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-03 Thread Matan Azrad
Hi Slava From: Viacheslav Ovsiienko > If VLAN tag insertion transmit offload is engaged > (DEV_TX_OFFLOAD_VLAN_INSERT in tx queue configuration is set) the > transmit descriptor may be built with wrong format, due to packet length is > not adjusted. Also, the ring buffer wrapup is not handled cor

[dpdk-dev] [PATCH v3] security: add statistics definitions and update API

2019-09-03 Thread Radu Nicolau
Update IPsec statistics struct definition, add per SA statistics collection enable flag. Signed-off-by: Radu Nicolau --- v2: added second reserved field v3: update doc lib/librte_security/rte_security.h | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git

Re: [dpdk-dev] [PATCH] pmdinfogen: add SPDX license tag

2019-09-03 Thread Neil Horman
On Tue, Sep 03, 2019 at 12:54:35PM +0530, Hemant Agrawal wrote: > This patch adds SPDX license tag to pmdinfogen files. > > These files are originally drived from kernel. > They are being used as binary tool to support internal > build. > > This patch requires license exception approval from > DP

Re: [dpdk-dev] [PATCH v1] net/tap: fix blocked rx packets error

2019-09-03 Thread Ananyev, Konstantin
> -Original Message- > From: Smoczynski, MarcinX > Sent: Monday, September 2, 2019 12:43 PM > To: Ananyev, Konstantin ; Wiles, Keith > ; adrien.mazarg...@6wind.com > Cc: dev@dpdk.org; sta...@dpdk.org; Smoczynski, MarcinX > ; Drost, MariuszX > Subject: [PATCH v1] net/tap: fix blocked r

Re: [dpdk-dev] [PATCH v4] net/ipn3ke: setup MTU when HW init

2019-09-03 Thread Ye Xiaolong
On 09/03, Andy Pei wrote: >set up mtu to the minimun in tx mtu, rx mtu and IPN3KE_MAC_FRAME_SIZE_MAX. > >Signed-off-by: Andy Pei >--- > >Cc: qi.z.zh...@intel.com >Cc: ferruh.yi...@intel.com >Cc: rosen...@intel.com >Cc: xiaolong...@intel.com > >v2: >modify low bound and upper bound. > >v3: >delete

Re: [dpdk-dev] [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions

2019-09-03 Thread Slava Ovsiienko
Hi, Matan Please, see below. > -Original Message- > From: Matan Azrad > Sent: Tuesday, September 3, 2019 16:05 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH] net/mlx5: fix transmit descriptor with VLAN insertions > > Hi Slava > > From: Viacheslav Ovsi

[dpdk-dev] [PATCH v2 04/54] app/eventdev: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test-eventdev according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-eventdev/test_perf_commo

[dpdk-dev] [PATCH v2 01/54] ethdev: remove redundunt device info cleanup before get

2019-09-03 Thread Andrew Rybchenko
rte_eth_dev_info_get() always fills in device information memory with zeros on entry. Fixes: b6719879855d ("ethdev: avoid getting uninitialized info for bad port") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 4 app/test-pmd/config.c

[dpdk-dev] [PATCH v2 05/54] kni: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test/test_kni.c according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_kni.c | 27 ++

[dpdk-dev] [PATCH v2 00/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-03 Thread Andrew Rybchenko
It is the first patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. Functions which return void are bad since they do not provide explicit information to the caller if everything is OK or not. It was bugs in rte_eth_dev_info_get() recently which

[dpdk-dev] [PATCH v2 03/54] app/testpmd: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko Add eth_dev_info_get_print_err() which is a wrapper for rte_eth_dev_info_get() printing error if rte_eth_dev_info_get() fails and returning its status code. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 120 +

[dpdk-dev] [PATCH v2 06/54] latency: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across latency component according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- lib/librte_latencystats/rte_laten

[dpdk-dev] [PATCH v2 07/54] pdump: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across pdump component according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- lib/librte_pdump/rte_pdump.c | 9 ++

[dpdk-dev] [PATCH v2 09/54] app/procinfo: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/procinfo according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/proc-info/main.c | 15

[dpdk-dev] [PATCH v2 08/54] ring: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test/test_pmd_ring.c according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_pmd_ring.c |

[dpdk-dev] [PATCH v2 10/54] app/test: check status of getting ethdev info in bonding

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test/test_link_bonding_rssconf.c according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_

[dpdk-dev] [PATCH v2 12/54] net/bnxt: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/bnxt according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko Acked-by: Somnath Kotur --- drivers/net/bnxt/

[dpdk-dev] [PATCH v2 11/54] app/test: check ethdev info get result in event Rx adapter

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across app/test/test_event_eth_rx_adapter.c according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/test_

[dpdk-dev] [PATCH v2 13/54] net/bonding: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/bonding according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_api.c

[dpdk-dev] [PATCH v2 02/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko Change rte_eth_dev_info_get() return value from void to int and return negative errno values in case of error conditions. Modify rte_eth_dev_info_get() usage across the ethdev according to new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- do

[dpdk-dev] [PATCH v2 15/54] net/netvsc: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/netvsc according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/netvsc/hn_var.h | 2 +- dri

[dpdk-dev] [PATCH v2 18/54] examples/rxtx_callbacks: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/rxtx_callbacks according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/rxtx_callbacks/mai

[dpdk-dev] [PATCH v2 14/54] net/failsafe: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/failsafe according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/failsafe/failsafe_ops.c |

[dpdk-dev] [PATCH v2 20/54] examples/qos_meter: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/qos_meter according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/qos_meter/main.c | 16 +

[dpdk-dev] [PATCH v2 16/54] net/softnic: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across net/softnic according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- drivers/net/softnic/rte_eth_softnic_lin

[dpdk-dev] [PATCH v2 19/54] examples/l3fwd: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l3fwd according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l3fwd/main.c | 14 +

[dpdk-dev] [PATCH v2 21/54] examples/ip_frag: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ip_frag according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ip_fragmentation/main.c |

[dpdk-dev] [PATCH v2 22/54] examples/performance-thread: check dev info get result

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/performance-thread according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/performance-th

[dpdk-dev] [PATCH v2 23/54] examples/vmdq: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vmdq according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/vmdq/main.c | 16 +++

[dpdk-dev] [PATCH v2 24/54] examples/distributor: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/distributor according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/distributor/main.c |

[dpdk-dev] [PATCH v2 25/54] examples/l3fwd-acl: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l3fwd-acl according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l3fwd-acl/main.c | 22 +

[dpdk-dev] [PATCH v2 26/54] examples/vm_power: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vm_power according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/vm_power_manager/main.c

[dpdk-dev] [PATCH v2 17/54] ethdev: change eth_dev_infos_get_t to return int

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko Change eth_dev_infos_get_t return value from void to int. Make eth_dev_infos_get_t implementations across all drivers to return negative errno values if case of error conditions. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- app/test/virtual_pmd.c

[dpdk-dev] [PATCH v2 28/54] examples/flow_filtering: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/flow_filtering according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/flow_filtering/mai

[dpdk-dev] [PATCH v2 29/54] examples/l3fwd-power: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l3fwd-power according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l3fwd-power/main.c |

[dpdk-dev] [PATCH v2 27/54] examples/qos_sched: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/qos_sched according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/qos_sched/init.c | 8 ++

[dpdk-dev] [PATCH v2 30/54] examples/l2fwd: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l2fwd according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l2fwd/main.c | 8 +++-

[dpdk-dev] [PATCH v2 31/54] examples/skeleton: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/skeleton according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/skeleton/basicfwd.c | 8

[dpdk-dev] [PATCH v2 34/54] examples/l2fwd-jobstats: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/l2fwd-jobstats according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/l2fwd-jobstats/mai

[dpdk-dev] [PATCH v2 32/54] examples/vmdq_dcb: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vmdq_dcb according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/vmdq_dcb/main.c | 18 +++

[dpdk-dev] [PATCH v2 33/54] examples/ipv4_multicast: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ipv4_multicast according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ipv4_multicast/mai

[dpdk-dev] [PATCH v2 35/54] examples/bond: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/bond according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/bond/main.c | 14 +++

[dpdk-dev] [PATCH v2 36/54] examples/eventdev: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/eventdev according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/eventdev_pipeline/main.c

[dpdk-dev] [PATCH v2 37/54] examples/ip_reassembly: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ip_reassembly according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ip_reassembly/main.

[dpdk-dev] [PATCH v2 39/54] examples/ptpclient: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/ptpclient according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/ptpclient/ptpclient.c |

[dpdk-dev] [PATCH v2 38/54] examples/vhost: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/vhost according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/vhost/main.c | 9 -

[dpdk-dev] [PATCH v2 40/54] examples/link_status_interrupt: check dev info get result

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/link_status_interrupt according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/link_status

[dpdk-dev] [PATCH v2 42/54] examples/server_node_efd: check dev info get result

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/server_node_efd according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/server_node_efd/s

[dpdk-dev] [PATCH v2 41/54] examples/tep_termination: check dev info get result

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/tep_termination according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/tep_termination/v

[dpdk-dev] [PATCH v2 44/54] examples/packet_ordering: check dev info get result

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/packet_ordering according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/packet_ordering/m

[dpdk-dev] [PATCH v2 43/54] examples/flow_classify: check status of getting ethdev info

2019-09-03 Thread Andrew Rybchenko
From: Ivan Ilchenko rte_eth_dev_info_get() return value was changed from void to int, so this patch modify rte_eth_dev_info_get() usage across examples/flow_classify according to its new return type. Signed-off-by: Ivan Ilchenko Signed-off-by: Andrew Rybchenko --- examples/flow_classify/flow_

  1   2   >