Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 17, 2019 3:15 PM > To: Hyong Youb Kim (hyonkim) ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johndale) ; Shahed Shaikh > ; dev@dpdk.or

Re: [dpdk-dev] [EXT] [PATCH v4 1/1] app/test-compress-perf: report header improvement

2019-07-17 Thread Shally Verma
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, July 16, 2019 7:20 PM > To: Trybula, ArturX ; Shally Verma > ; dev@dpdk.org; Dybkowski, AdamX > ; akhil.go...@nxp.com > Cc: Trahe, Fiona > Subject: RE: [EXT] [PATCH v4 1/1] app/test-compress-perf: report header > improvement >

Re: [dpdk-dev] [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments about primes

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments about > primes > > External Email

Re: [dpdk-dev] [EXT] [PATCH v3 02/11] cryptodev: add cipher field to RSA op

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 02/11] cryptodev: add cipher field to RSA op > > External Email > > --

Re: [dpdk-dev] [EXT] [PATCH v3 04/11] test: add cipher field to RSA test

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 04/11] test: add cipher field to RSA test > > External Email > > -

[dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-17 Thread viveksharma
From: Vivek Sharma Support QinQ strip RX offload configuration through testpmd command line and boot time arguments. Signed-off-by: Vivek Sharma --- app/test-pmd/cmdline.c | 24 ++- app/test-pmd/config.c | 36 ++

Re: [dpdk-dev] [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt handlers

2019-07-17 Thread Nithin Kumar Dabilpuram
On Wed, Jul 17, 2019 at 06:01:47AM +, Hyong Youb Kim (hyonkim) wrote: > > -Original Message- > > From: Nithin Dabilpuram > > Sent: Wednesday, July 17, 2019 1:44 AM > [...] > > Subject: [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt > > handlers > > > > Replace rte_intr_en

Re: [dpdk-dev] [EXT] [PATCH v3 03/11] crypto/openssl: add cipher field to openssl RSA implementation

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 03/11] crypto/openssl: add cipher field to openssl > RSA implementation > >

[dpdk-dev] [v2 2/3] examples/ip_fragmentation: fix use of internal struct

2019-07-17 Thread Marcin Zapolski
Modify ip_fragmentation example app to use rte_eth_info_get instead of global rte_eth_devices structure. Apps should not be using internal DPDK data structures directly. Fixes: 9758b956dcf4 ("examples/ip_fragmentation: fix Tx queues init") Cc: alia...@mellanox.com Signed-off-by: Marcin Zapolski

[dpdk-dev] [v2 1/3] examples/l3fwd*: fix use of internal struct

2019-07-17 Thread Marcin Zapolski
Modify l3fwd and related example apps to use locally defined port_conf instead of global rte_eth_devices which is not a part of public API. Apps should not be using internal DPDK data structures directly. Fixes: 1ef9600b2d20 ("examples/l3fwd: convert to ethdev offloads API") Fixes: ba8c103d2455 ("

[dpdk-dev] [v2 0/3] examples: fix use of internal struct

2019-07-17 Thread Marcin Zapolski
Some example applications have references to rte_eth_dev structure, which is not a part of public API. These patches replace them with calls to API functions. v2: * adjust commit titles * add fixlines for the original commits Marcin Zapolski (3): examples/l3fwd*: fix use of internal struct ex

[dpdk-dev] [v2 3/3] examples/ipsec-secgw: fix use of internal struct

2019-07-17 Thread Marcin Zapolski
Modify ipsec-secgw example app to use rte_eth_dev_info_get instead of rte_eth_dev. Apps should not be using internal DPDK data structures directly. Fixes: a4677f78368b ("examples/ipsec-secgw: add target queues in flow actions") Cc: nelio.laranje...@6wind.com Signed-off-by: Marcin Zapolski Review

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Jerin Jacob Kollanukkaran
> > > -Original Message- > > > From: Hyong Youb Kim (hyonkim) > > > Sent: Wednesday, July 17, 2019 11:26 AM > > > To: Nithin Kumar Dabilpuram ; David > > Marchand > > > ; Thomas Monjalon > ; > > > Ferruh Yigit ; Bruce Richardson > > > > > > Cc: Jerin Jacob Kollanukkaran ; John Daley > > >

Re: [dpdk-dev] [EXT] Re: [PATCH v2] app/testpmd: add device related cmds

2019-07-17 Thread Nithin Kumar Dabilpuram
On Tue, Jul 16, 2019 at 07:30:23PM +0100, Ferruh Yigit wrote: > External Email > > -- > On 7/10/2019 2:07 PM, Nithin Dabilpuram wrote: > > With the latest published interface of > > rte_eal_hotplug_[add,remove](), and rte_eth_dev_

[dpdk-dev] [PATCH v3] net/pcap: create null Rx function

2019-07-17 Thread A.McLoughlin
Previously in the PCAP PMD it was only possibe to specify an rxq which uses an iface or a pcap file. This patch creates a 'dummy Rx' function which is used when no rx_pcap or rx_iface is passed but a tx queue is passed. This function can be polled and receives no packets. Signed-off-by: A.McLoughl

Re: [dpdk-dev] [PATCH v3 1/3] app/testpmd: support raw encap/decap actions

2019-07-17 Thread Ferruh Yigit
On 7/17/2019 2:24 AM, Jack Min wrote: > On Tue, 19-07-16, 18:41, Ferruh Yigit wrote: >> On 7/10/2019 11:43 AM, Xiaoyu Min wrote: >>> This patch intend to support >>> action_raw_encap/decap [1] in a generic and convenient way. >>> >>> Two new commands - set raw_encap, set raw_decap are introduced ju

Re: [dpdk-dev] [EXT] [PATCH v3 04/11] test: add cipher field to RSA test

2019-07-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Wednesday, July 17, 2019 9:42 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: RE: [EXT] [PATCH v3 04/11] test: add cipher field to RSA test > > > > > -Ori

Re: [dpdk-dev] [EXT] Re: [PATCH v2 4/4] eal: select IOVA mode as VA for default case

2019-07-17 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 16, 2019 8:03 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; John > McNamara ; Marko Kovacevic > > Cc: tho...@monjalon.net; david.march...@redhat.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 4/4] eal: select IOVA mod

Re: [dpdk-dev] [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments about primes

2019-07-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Wednesday, July 17, 2019 9:32 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: RE: [EXT] [PATCH v3 01/11] cryptodev: change RSA API comments > about primes > >

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 17, 2019 5:03 PM > To: Hyong Youb Kim (hyonkim) ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johndale) ; Shahed Shaikh > ; dev@dpdk.or

[dpdk-dev] [PATCH] eal: update comment about --no-huge option

2019-07-17 Thread Thomas Monjalon
The old comment, on top of the function rte_eal_has_hugepages(), is really outdated and not generic enough. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/rte_eal.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/librte_eal/common/include/rte_eal.h

[dpdk-dev] [PATCH v7 0/4] kni: add IOVA=VA support

2019-07-17 Thread vattunuru
From: Vamsi Attunuru V7 Changes: * Removed previously proposed mempool flag and made those page boundary checks default in mempool populate() except for the objects size bigger than the size of page. * Removed KNI example application related changes since pool related requirement is taken ca

[dpdk-dev] [PATCH v7 2/4] kni: add IOVA = VA support in KNI lib

2019-07-17 Thread vattunuru
From: Vamsi Attunuru Current KNI implmentation only operates in IOVA=PA mode, patch adds required functionality in KNI lib to support IOVA=VA mode. KNI kernel module requires device info to get iommu domain related information for IOVA addr related translations. Patch defines device related info

[dpdk-dev] [PATCH v7 4/4] kni: modify IOVA mode checks to support VA

2019-07-17 Thread vattunuru
From: Vamsi Attunuru Patch addresses checks in KNI and eal that enforce IOVA=PA when IOVA=VA mode is enabled, since KNI kernel module supports VA mode for kernel versions >= 4.4.0. Signed-off-by: Vamsi Attunuru Signed-off-by: Kiran Kumar K --- lib/librte_eal/linux/eal/eal.c | 4 +++- lib/libr

[dpdk-dev] [PATCH v7 1/4] mempool: modify mempool populate() to skip objects from page boundaries

2019-07-17 Thread vattunuru
From: Vamsi Attunuru Currently the phys address of a mempool object populated by the mempool populate default() routine may not be contiguous with in that mbuf range. Patch ensures that each object's phys address is contiguous by modifying default behaviour of mempool populate() to prevent objec

[dpdk-dev] [PATCH v7 3/4] kni: add IOVA=VA support in KNI module

2019-07-17 Thread vattunuru
From: Kiran Kumar K Patch adds support for kernel module to work in IOVA = VA mode, the idea is to get physical address from IOVA address using iommu_iova_to_phys API and later use phys_to_virt API to convert the physical address to kernel virtual address. When compared with IOVA = PA mode, ther

Re: [dpdk-dev] [PATCH v3 1/3] app/testpmd: support raw encap/decap actions

2019-07-17 Thread Jack Min
On Wed, 19-07-17, 09:20, Ferruh Yigit wrote: > On 7/17/2019 2:24 AM, Jack Min wrote: > > On Tue, 19-07-16, 18:41, Ferruh Yigit wrote: > >> On 7/10/2019 11:43 AM, Xiaoyu Min wrote: > >>> This patch intend to support > >>> action_raw_encap/decap [1] in a generic and convenient way. > >>> > >>> Two ne

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Jerin Jacob Kollanukkaran
> > > Not sure. I do not have a good suggestion here :-) Like to hear from > > > David when he comes back, as he spent most time on this issue.. > > > > Sure. He is on vacation. > > Any reason for thinking, rte_intr_ack() may not be semantically correct? > > I think, it is very much correct if the

Re: [dpdk-dev] [EXT] [PATCH v3 04/11] test: add cipher field to RSA test

2019-07-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 17, 2019 10:27 AM > To: 'Shally Verma' ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: RE: [EXT] [PATCH v3 04/11] test: add cipher field to RSA test > > > > > -Original Message- > > Fro

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 17, 2019 6:21 PM > To: Hyong Youb Kim (hyonkim) ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johndale) ; Shahed Shaikh > ; dev@dpdk.or

Re: [dpdk-dev] [EXT] [PATCH v3 05/11] cryptodev: add information about message format when signing with RSA

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 05/11] cryptodev: add information about message > format when signing with R

Re: [dpdk-dev] [EXT] [PATCH v3 06/11] cryptodev: remove RSA PKCS1 BT0 padding

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 06/11] cryptodev: remove RSA PKCS1 BT0 padding > > External Email > >

Re: [dpdk-dev] [EXT] [PATCH v3 08/11] test: remove RSA PKCS1_5 BT0 padding from test cases

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 08/11] test: remove RSA PKCS1_5 BT0 padding from > test cases > > External

Re: [dpdk-dev] [EXT] [PATCH v3 09/11] cryptodev: add RSA padding none description

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 09/11] cryptodev: add RSA padding none > description > > External Email >

Re: [dpdk-dev] [EXT] [PATCH v3 07/11] openssl: remove RSA PKCS1_5 BT0 padding

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 07/11] openssl: remove RSA PKCS1_5 BT0 padding > > External Email > >

Re: [dpdk-dev] [EXT] [PATCH v3 10/11] test: add pkcs1_5 padding simulation

2019-07-17 Thread Shally Verma
> -Original Message- > From: Arek Kusztal > Sent: Wednesday, July 17, 2019 12:23 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > ; Arek Kusztal > Subject: [EXT] [PATCH v3 10/11] test: add pkcs1_5 padding simulation > > External Email > > ---

Re: [dpdk-dev] [EXT] [PATCH v3 05/11] cryptodev: add information about message format when signing with RSA

2019-07-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Wednesday, July 17, 2019 12:08 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: RE: [EXT] [PATCH v3 05/11] cryptodev: add information about > message format when

Re: [dpdk-dev] [EXT] [PATCH v3 10/11] test: add pkcs1_5 padding simulation

2019-07-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Wednesday, July 17, 2019 12:23 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: RE: [EXT] [PATCH v3 10/11] test: add pkcs1_5 padding simulation > > > > > -

[dpdk-dev] [PATCH v3 01/15] net/bnxt: fix extended port counter statistics

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP 1. refactor stats allocation code to new routine 2. check for extended statistics support depends on "hwrm_spec_code" which is set in bnxt_hwrm_ver_get called later. Hence we were never querying extended port stats as flags field was not updated. Fixed this by moving the

[dpdk-dev] [PATCH v3 00/15] bnxt patch series

2019-07-17 Thread Ajit Khaparde
Patchset fixing various bugs in bnxt PMD based on recent commit: 1e101412320061a4a1cd47db4227b4f8a163e9f6 Ajit Khaparde (3): net/bnxt: fix for doorbell register offset for Tx ring net/bnxt: save the number of EM flow count net/bnxt: fix a compilation warning Jay Ding (1): net/bnxt: fix to

[dpdk-dev] [PATCH v3 02/15] net/bnxt: fix possible segfault in case of probe failure

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP Fixed couple of possible segfaults due to NULL pointer dereference in case of probe failure. Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_irq.c | 3

[dpdk-dev] [PATCH v3 07/15] net/bnxt: fix for doorbell register offset for Tx ring

2019-07-17 Thread Ajit Khaparde
For Tx-ring # 104 and higher, the doorbell register was incorrectly configured due to which FW was not able to receive the notification of packet to transmit. With this fix, user can run traffic upto 256 rings. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: sta...@dpdk.org Signed-off-b

[dpdk-dev] [PATCH v3 08/15] net/bnxt: save the number of EM flow count

2019-07-17 Thread Ajit Khaparde
Save the number of EM flow count returned by the FW in HWRM_FUNC_QCFG and use it to calculate the overall pool of L2 contexts supported by FW. Fixes: 6d8109bcb398 ("net/bnxt: check VF resources if resource manager is enabled") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh

[dpdk-dev] [PATCH v3 06/15] net/bnxt: fix L4 checksum error indication in Rx path

2019-07-17 Thread Ajit Khaparde
From: Rahul Gupta Update ol_flags correctly for checksum errors in case of tunnel and non-tunnel packet. Fixes: 65ee636872eb ("net/bnxt: fix Rx checksum flags") Cc: sta...@dpdk.org Signed-off-by: Rahul Gupta Signed-off-by: Ajit Khaparde -- v1->v3: Fix check-git-log output. --- drivers/net/bn

[dpdk-dev] [PATCH v3 05/15] net/bnxt: reset Rx allocation state on port restart

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson Move call site of bnxt_rxq_vec_setup() to ensure that rxq->rxrearm_nb and rxq->rxrearm_start are reinitialized correctly when a port is restarted. Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode") Reviewed-by: Christopher Reder Signed-off-by: Lance Richardson S

Re: [dpdk-dev] [EXT] [PATCH v3 09/11] cryptodev: add RSA padding none description

2019-07-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Wednesday, July 17, 2019 12:18 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: RE: [EXT] [PATCH v3 09/11] cryptodev: add RSA padding none > description > > >

[dpdk-dev] [PATCH v3 03/15] net/bnxt: do not fail VF probe when the MAC address is zero

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP VF driver should not fail probe if the host PF driver has not assigned any MAC address for the VF. It should generate a random MAC address and configure the MAC and then continue probing the device. Fixes: be160484a48d ("net/bnxt: check if MAC address is all zeros") Cc: sta...@dp

[dpdk-dev] [PATCH v3 10/15] net/bnxt: avoid null pointer dereference

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson Avoid null pointer dereference when allocating an insolated completion ring by basing nq ring allocation on whether an nq ring was requested instead of whether the device supports nq rings. Fixes: f8168ca0e690 ("net/bnxt: support thor controller") Signed-off-by: Lance Rich

[dpdk-dev] [PATCH v3 12/15] net/bnxt: fix to check for invalid VNIC in cleanup path

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP The cleanup/rollback operation post rte_eth_dev_start failure might end up invoking an HWRM cmd even on an invalid vNIC resulting in error messages being logged needlessly. Fix to check for the same before issuing the HWRM cmd. Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link

[dpdk-dev] [PATCH v3 15/15] net/bnxt: fix to avoid sending invalid VNIC id to firmware

2019-07-17 Thread Ajit Khaparde
From: Jay Ding Add checking for vinc id before sending message to chimp in bnxt_hwrm_vnic_plcmode_cfg(). Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") Cc: sta...@dpdk.org Reviewed-by: Ajit Khaparde Reviewed-by: Randy Schacher Signed-off-by: Jay Ding Signed-off-by: Ajit Khaparde

[dpdk-dev] [PATCH v3 04/15] net/bnxt: fix Tx hang after port stop/start

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson Initialize the state of the the completion valid indicator when a completion ring is freed, otherwise completions may not be processed when a new ring is allocated. Fixes: 5735eb241947 ("net/bnxt: support Tx batching") Reviewed-by: Kalesh Anakkur Purayil Signed-off-by: La

[dpdk-dev] [PATCH v3 09/15] net/bnxt: nq doorbell cleanups

2019-07-17 Thread Ajit Khaparde
From: Lance Richardson Simplify nq doorbell handling code by removing redundant db parameter and consolidating NQ doorbell macro into the inline function that uses it. Add "enable interrupt" variant of nq write. This will be used in a subsequent commit. When initializing nq doorbell, don't assu

[dpdk-dev] [PATCH v3 11/15] net/bnxt: fix to enable disable interrupts correctly

2019-07-17 Thread Ajit Khaparde
From: Kalesh AP 1. disable interrupts in dev_stop_op() 2. enable interrupts in dev_start_op() 3. Clean queue intr-vector mapping in dev_stop_op() and thus fix a possible memory leak. Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations") Cc: sta...@dpdk.org Signed-off-by: Ka

[dpdk-dev] [PATCH v3 13/15] net/bnxt: fix a compilation warning

2019-07-17 Thread Ajit Khaparde
Compiler complains of an uninitialized variable. Initializing it to avoid the issue. Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Rahul Gupta --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[dpdk-dev] [PATCH v3 14/15] net/bnxt: fix rxq count if ntuple filtering is disabled

2019-07-17 Thread Ajit Khaparde
From: Qingmin Liu If ntuple filtering is disabled, FW will return max_vnics=1. Due to this only single Rxq is created. Change to max_rx_rings = RTE_MIN(bp->max_rx_rings, bp->max_stat_ctx) to fix it. Fixes: 6d8109bcb398 ("net/bnxt: check VF resources if resource manager is enabled") Cc: sta...@d

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Jerin Jacob Kollanukkaran
> > I think, it vary from the perspective of IRQ Chip(or controller) vs > > NIC > > register(Source) PoV. > > Since the API starts from rte_intr_* it is more of controller so _ack_ > > make sense Other reason for ack: > > 1) It will enforce that it needs to be called form ISR > > 2) It would be hav

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Wednesday, July 17, 2019 7:44 PM > To: Hyong Youb Kim (hyonkim) ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johndale) ; Shahed Shaikh > ; dev@dpdk.or

[dpdk-dev] [PATCH v5 0/1] add extra features to test-compress-perf

2019-07-17 Thread Artur Trybula
v5 changes: - some minor changes (rewording, structure renaming, etc.) v4 changes: - information about compression threads printed on screen v3 changes: - commented code removed v2 changes: - merged with the series "add multiple cores feature to te

[dpdk-dev] [PATCH v5 1/1] app/test-compress-perf: report header improvement

2019-07-17 Thread Artur Trybula
This patch adds extra features to the compress performance test. Some important parameters (memory allocation, number of ops, number of segments) are calculated and printed out on the screen. Information about compression threads is also provided. Signed-off-by: Artur Trybula --- .../comp_perf_t

Re: [dpdk-dev] [EXT] [PATCH v5 1/1] app/test-compress-perf: report header improvement

2019-07-17 Thread Shally Verma
> -Original Message- > From: Artur Trybula > Sent: Wednesday, July 17, 2019 4:33 PM > To: dev@dpdk.org; fiona.tr...@intel.com; Shally Verma > ; adamx.dybkow...@intel.com; > arturx.tryb...@intel.com; akhil.go...@nxp.com > Subject: [EXT] [PATCH v5 1/1] app/test-compress-perf: report header

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Hyong Youb Kim (hyonkim) > Sent: Wednesday, July 17, 2019 4:36 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: John Daley (johndale) ; Shahed Shaikh > ; dev@dpdk.or

Re: [dpdk-dev] [EXT] [PATCH v5 0/1] add extra features to test-compress-perf

2019-07-17 Thread Shally Verma
> -Original Message- > From: Artur Trybula > Sent: Wednesday, July 17, 2019 4:33 PM > To: dev@dpdk.org; fiona.tr...@intel.com; Shally Verma > ; adamx.dybkow...@intel.com; > arturx.tryb...@intel.com; akhil.go...@nxp.com > Subject: [EXT] [PATCH v5 0/1] add extra features to test-compress-

[dpdk-dev] [PATCH] devtools: fix null test

2019-07-17 Thread Thomas Monjalon
This small testpmd test was not working for a long time because of several changes in EAL and mempool. The 3 main issues solved are: - Make --no-huge working by specifying an amount of memory to allocate in legacy mode, and disabling mlockall. - Load a mempool handle

Re: [dpdk-dev] [EXT] [PATCH v5 1/1] app/test-compress-perf: report header improvement

2019-07-17 Thread Trybula, ArturX
-Original Message- From: Shally Verma [mailto:shal...@marvell.com] Sent: Wednesday, July 17, 2019 13:16 To: Trybula, ArturX ; dev@dpdk.org; Trahe, Fiona ; Dybkowski, AdamX ; akhil.go...@nxp.com Subject: RE: [EXT] [PATCH v5 1/1] app/test-compress-perf: report header improvement > --

[dpdk-dev] [PATCH 0/3] vfio: fix broken msix interrupt initialization

2019-07-17 Thread Nithin Dabilpuram
A final patch for below mentioned RFC patch discussions. [RFC PATCH v3 1/3] vfio: revert change that does intr eventfd setup at probe http://mails.dpdk.org/archives/dev/2019-July/138358.html [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs http://mails.dpdk.org/archives/dev/2019-July/13

[dpdk-dev] [PATCH 2/3] eal: add ack interrupt API

2019-07-17 Thread Nithin Dabilpuram
Add new ack interrupt API to avoid using VFIO_IRQ_SET_ACTION_TRIGGER(rte_intr_enable()) for acking interrupt purpose for VFIO based interrupt handlers. This implementation is specific to Linux. Using rte_intr_enable() for acking interrupt has below issues * Time consuming to do for every interru

[dpdk-dev] [PATCH 3/3] drivers/net: use ack API in interrupt handlers

2019-07-17 Thread Nithin Dabilpuram
Replace rte_intr_enable() with rte_intr_ack() API for acking an interrupt in interrupt handlers and rx_queue_intr_enable() callbacks of PMD's. This is inline with original intent of this change in PMDs to ack interrupts after handling is completed if device is backed by UIO, IGB_UIO or VFIO(with I

[dpdk-dev] [PATCH 1/3] vfio: revert change that does intr eventfd setup at probe

2019-07-17 Thread Nithin Dabilpuram
This reverts commit 89aac60e0be9ed95a87b16e3595f102f9faaffb4. "vfio: fix interrupts race condition" The above mentioned commit moves the interrupt's eventfd setup to probe time but only enables one interrupt for all types of interrupt handles i.e VFIO_MSI, VFIO_LEGACY, VFIO_MSIX, UIO. It works fin

Re: [dpdk-dev] [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs

2019-07-17 Thread Nithin Kumar Dabilpuram
On 7/17/2019 4:46 PM, Jerin Jacob Kollanukkaran wrote: >> -Original Message- >> From: Hyong Youb Kim (hyonkim) >> Sent: Wednesday, July 17, 2019 4:36 PM >> To: Jerin Jacob Kollanukkaran ; Nithin Kumar >> Dabilpuram ; David Marchand >> ; Thomas Monjalon >> ; Ferruh Yigit ; Bruce >> Richard

[dpdk-dev] [PATCH v4 0/4] app/testpmd: support raw encap/decap actions

2019-07-17 Thread Xiaoyu Min
This series is based on RFC [1], which enable the testpmd to support the raw_encap/raw_decap actions in a generic and convenient way. Some rte_flow_item's fields are also opened in testpmd cmdline i.e. MPLS's TC & S in order to make sure the encapsulated tunnel header has the correct data. [1] ht

[dpdk-dev] [PATCH v4 1/4] app/testpmd: put set vxlan/nvgre help in filters section

2019-07-17 Thread Xiaoyu Min
The help string of set vxlan*, set nvgre* are in "config"" section. But they acutally do not alter NIC or testpmd's configuration and they will be used by "flow" command later. Put them in "filters" section along with "flow" command seems more reasonable. Signed-off-by: Xiaoyu Min --- app/test-

[dpdk-dev] [PATCH v4 2/4] app/testpmd: support raw encap/decap actions

2019-07-17 Thread Xiaoyu Min
This patch intend to support action_raw_encap/decap [1] in a generic and convenient way. Two new commands - set raw_encap, set raw_decap are introduced just like the other commands for encap/decap, i.e. set vxlan. These two commands have corresponding global buffers which can be used by PMD as th

[dpdk-dev] [PATCH v4 4/4] app/testpmd: add GRE key for raw encap/decap

2019-07-17 Thread Xiaoyu Min
GRE key (rte_flow_item_type_gre_key) is also needed in raw encapsulation/decapsulation. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 8409e41ea0..d08f016bec 1006

[dpdk-dev] [PATCH v4 3/4] app/testpmd: support MPLS's TC and S bits

2019-07-17 Thread Xiaoyu Min
Open the MPLS's TC and S bits of rte_flow_item_mpls in command line. Signed-off-by: Xiaoyu Min --- app/test-pmd/cmdline_flow.c | 20 1 file changed, 20 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a15a756461..8409e41ea0 100644 -

[dpdk-dev] [PATCH v3] app/testpmd: add device related cmds

2019-07-17 Thread Nithin Dabilpuram
With the latest published interface of rte_eal_hotplug_[add,remove](), and rte_eth_dev_close(), rte_eth_dev_close() would cleanup all the data structures of port's eth dev leaving the device common resource intact if RTE_ETH_DEV_CLOSE_REMOVE is set in dev flags. So a new command "detach device" (~

[dpdk-dev] [RFC] mark asym session-buffer non-reuseable

2019-07-17 Thread Ayuj Verma
This RFC proposes changes in asymmetric session usability of transform structure. In current implementation asym xform is seen as temporary entity that can be re-used by application once sessions are initialized with it. This enforces PMD to copy all key buffers during session setup time. Since li

[dpdk-dev] [RFC] lib/crypto: mark asym session-buffer non-reuseable

2019-07-17 Thread Ayuj Verma
Update asym xform usage in cryptodev documentation. Xform are immutable, non-reuseable entity till life time of session. This allow some PMD to optimize session setup time. Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- doc/guides/prog_guide/cryptodev_lib.rst | 6 ++ lib/librte

Re: [dpdk-dev] [PATCH] eal: update comment about --no-huge option

2019-07-17 Thread Burakov, Anatoly
On 17-Jul-19 9:56 AM, Thomas Monjalon wrote: The old comment, on top of the function rte_eal_has_hugepages(), is really outdated and not generic enough. Signed-off-by: Thomas Monjalon --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [EXT] Re: [PATCH v2 4/4] eal: select IOVA mode as VA for default case

2019-07-17 Thread Burakov, Anatoly
On 17-Jul-19 9:33 AM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Tuesday, July 16, 2019 8:03 PM To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; John McNamara ; Marko Kovacevic Cc: tho...@monjalon.net; david.march...@redhat.com Subject: [EXT] Re: [dpdk

[dpdk-dev] [PATCH v2 1/3] vfio: revert change that does intr eventfd setup at probe

2019-07-17 Thread Nithin Dabilpuram
This reverts commit 89aac60e0be9ed95a87b16e3595f102f9faaffb4. "vfio: fix interrupts race condition" The above mentioned commit moves the interrupt's eventfd setup to probe time but only enables one interrupt for all types of interrupt handles i.e VFIO_MSI, VFIO_LEGACY, VFIO_MSIX, UIO. It works fin

[dpdk-dev] [PATCH v2 2/3] eal: add ack interrupt API

2019-07-17 Thread Nithin Dabilpuram
Add new ack interrupt API to avoid using VFIO_IRQ_SET_ACTION_TRIGGER(rte_intr_enable()) for acking interrupt purpose for VFIO based interrupt handlers. This implementation is specific to Linux. Using rte_intr_enable() for acking interrupt has below issues * Time consuming to do for every interru

[dpdk-dev] [PATCH v2 3/3] drivers/net: use ack API in interrupt handlers

2019-07-17 Thread Nithin Dabilpuram
Replace rte_intr_enable() with rte_intr_ack() API for acking an interrupt in interrupt handlers and rx_queue_intr_enable() callbacks of PMD's. This is inline with original intent of this change in PMDs to ack interrupts after handling is completed if device is backed by UIO, IGB_UIO or VFIO(with I

[dpdk-dev] [PATCH v2 0/3] vfio: fix broken msix interrupt initialization

2019-07-17 Thread Nithin Dabilpuram
A final patch for below mentioned RFC patch discussions. [RFC PATCH v3 1/3] vfio: revert change that does intr eventfd setup at probe http://mails.dpdk.org/archives/dev/2019-July/138358.html [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs http://mails.dpdk.org/archives/dev/2019-July/13

Re: [dpdk-dev] [PATCH 3/3] drivers/net: use ack API in interrupt handlers

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 8:59 PM [...] > Subject: [PATCH 3/3] drivers/net: use ack API in interrupt handlers > > Replace rte_intr_enable() with rte_intr_ack() API > for acking an interrupt in interrupt handlers and > rx_queue_intr_ena

[dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto

2019-07-17 Thread Arek Kusztal
Split into smaller commits, in order from least disputable ones. Open things beside this: 1. Creating padding struct 2. Padding parameters (seedlen, optional label etc) 3. Leading zeroes questions. 4. Random number requirements. 5. Capabilities. 6. Verify signature field when none padding. v4: -

[dpdk-dev] [PATCH v4 02/11] cryptodev: add cipher field to RSA op

2019-07-17 Thread Arek Kusztal
Asymmetric nature of RSA algorithm suggest to use additional field for output. In place operations still can be done by setting cipher and message pointers with the same memory address. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_asym.h | 26 +- 1 file

Re: [dpdk-dev] [EXT] [PATCH v3 04/11] test: add cipher field to RSA test

2019-07-17 Thread Shally Verma
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 17, 2019 3:12 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona > Subject: RE: [EXT] [PATCH v3 04/11] test: add cipher field to RSA test > > > > > -Original Message- > > From:

[dpdk-dev] [PATCH v4 01/11] cryptodev: change RSA API comments about primes

2019-07-17 Thread Arek Kusztal
RSA modulus cannot be prime as its security basing on integer factorization. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_asym.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_

[dpdk-dev] [PATCH v4 03/11] crypto/openssl: add cipher field to openssl RSA implementation

2019-07-17 Thread Arek Kusztal
This commit adds cipher field to openssl pmd to comfort to API change. Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_opens

[dpdk-dev] [PATCH v4 05/11] cryptodev: add information about message format when signing with RSA

2019-07-17 Thread Arek Kusztal
This patch adds information about format of the message should have before sending it to the signing operation when using RSA algorithm. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_asym.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v4 06/11] cryptodev: remove RSA PKCS1 BT0 padding

2019-07-17 Thread Arek Kusztal
BT0 block type padding after rfc2313 has been discontinued. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_asym.h | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h

[dpdk-dev] [PATCH v4 04/11] test: add cipher field to RSA test

2019-07-17 Thread Arek Kusztal
This patch adds cipher field to RSA test cases Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 4dee164..8391545 100644 --- a/app/test/test_cryptodev_asym.c

[dpdk-dev] [PATCH v4 08/11] test: remove RSA PKCS1_5 BT0 padding from test cases

2019-07-17 Thread Arek Kusztal
This patch removes RSA PKCS1_5 BT0 padding from test cases Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index 8391545..0e1277b 100644 ---

[dpdk-dev] [PATCH v4 07/11] openssl: remove RSA PKCS1_5 BT0 padding

2019-07-17 Thread Arek Kusztal
This patch removes RSA PKCS1_5 BT0 padding from openssl PMD. Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c index

[dpdk-dev] [PATCH v4 10/11] test: add pkcs1_5 padding simulation

2019-07-17 Thread Arek Kusztal
This patch adds function to simulate pkcs1_5 padding, it serves nothing else than example. It provides no security and should not be used in security context. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym_util.h | 54 + 1 file changed, 54 insert

[dpdk-dev] [PATCH v4 09/11] cryptodev: add RSA padding none description

2019-07-17 Thread Arek Kusztal
This patch adds RSA padding none description. Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_asym.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h index 5e05de5..a021c

[dpdk-dev] [PATCH v4 11/11] test: add RSA PKCS1_5 padding case when no padding selected

2019-07-17 Thread Arek Kusztal
This patch adds an example how to use padding none option with RSA. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 46 +- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_crypto

Re: [dpdk-dev] [PATCH v2 2/3] eal: add ack interrupt API

2019-07-17 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: Nithin Dabilpuram > Sent: Wednesday, July 17, 2019 9:44 PM > To: Hyong Youb Kim (hyonkim) ; David Marchand > ; Thomas Monjalon > ; Ferruh Yigit ; Bruce > Richardson > Cc: jer...@marvell.com; John Daley (johndale) ; > Shahed Shaikh ; dev@dpdk.org; Nithin Dabilp

Re: [dpdk-dev] [PATCH v7 1/4] mempool: modify mempool populate() to skip objects from page boundaries

2019-07-17 Thread Andrew Rybchenko
On 7/17/19 12:04 PM, vattun...@marvell.com wrote: From: Vamsi Attunuru Currently the phys address of a mempool object populated by the mempool populate default() routine may not be contiguous with in that mbuf range. Patch ensures that each object's phys address is contiguous by modifying defa

Re: [dpdk-dev] [PATCH 0/3] cfgfile: cleanup patches

2019-07-17 Thread Bruce Richardson
On Tue, Jul 16, 2019 at 10:27:38AM -0700, Stephen Hemminger wrote: > Some small patches for the cfgfile library > > Stephen Hemminger (3): > cfgfile: remove unnecessary initialization > cfgfile: use RTE_LOG for errors > cfgfile: use calloc > Looks ok to me, and compile testing showed no iss

  1   2   3   >