Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-27 Thread David Marchand
On Wed, Jun 26, 2019 at 11:03 PM Thomas Monjalon wrote: > 07/06/2019 10:32, David Marchand: > > On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets > > wrote: > > > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > > > return 0 or negative error code. Bus code returns positive valu

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix build with ICC

2019-06-27 Thread Ferruh Yigit
On 6/27/2019 12:07 AM, Stephen Hemminger wrote: > The Intel compiler is pickier about casts and generates: > otx2_mempool_ops.c(344): error #191: type qualifier is meaningless on cast > type > int64_t * const addr = (int64_t * const) > ^ > This is because of the

[dpdk-dev] [PATCH v6 00/15] A new net PMD - hinic

2019-06-27 Thread Ziyang Xuan
This patch set adds support of a new net PMD for Huawei Intelligent nic. This patch provides supoort for basic RX/TX and the contorl path needed for it. Later on new features will be added like VLAN, VFs, etc. Basic features: 1. Basic device operations: probe, initialization, start/stop, config

[dpdk-dev] [PATCH v6 01/15] net/hinic/base: add HW registers definition

2019-06-27 Thread Ziyang Xuan
Add HW registers definition header file for Hi1822 NIC. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_csr.h | 160 + 1 file changed, 160 insertions(+) create mode 100644 drivers/net/hinic/base/hinic_csr.h diff --git a/drivers/net/hinic/base/hinic_csr.h

[dpdk-dev] [PATCH v6 02/15] net/hinic/base: add HW interfaces of bar operation

2019-06-27 Thread Ziyang Xuan
This patch adds some HW interfaces for bar operatioin interfaces, including: mapped bar address geeting, HW attributes getting, msi-x reg operation, function type getting and so on. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_hwif.c | 474 drivers/net

[dpdk-dev] [PATCH v6 03/15] net/hinic/base: add API command channel code

2019-06-27 Thread Ziyang Xuan
API command channel is for communicating with mgmt module of chip. This patch introduces data structures, initialization, interfaces, and commands sending functions of API command channel. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_api_cmd.c | 1042 driv

[dpdk-dev] [PATCH v6 04/15] net/hinic/base: add support for cmdq mechanism

2019-06-27 Thread Ziyang Xuan
Micocode is named ucode in Hi1822. Its main responsibility is data transmission and reception. But it can also handle some administration works. It uses cmdq mechanism. This patch introduces data structures, initialization, interfaces, and commands sending functions of cmdq. Signed-off-by: Ziyang

[dpdk-dev] [PATCH v6 05/15] net/hinic/base: add eq mechanism function code

2019-06-27 Thread Ziyang Xuan
Eqs include aeq and ceq. PMD supports aeq only. Aeq is a kind of queue for mgmt asynchronous message and mgmt command response message. This patch introduces data structures, initialization, and related interfaces about aeq. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_eqs.c |

[dpdk-dev] [PATCH v6 06/15] net/hinic/base: add mgmt module function code

2019-06-27 Thread Ziyang Xuan
Mgmt module is a kinkd of administration module for the chip. It is responsible for handling administration command from host. It uses api channel. This patch adds related data structures, packaged interfaces and function codes. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_mgm

[dpdk-dev] [PATCH v6 07/15] net/hinic/base: add code about hardware operation

2019-06-27 Thread Ziyang Xuan
Add code for hardware operation, including configuration, query and so on. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_cfg.c | 208 drivers/net/hinic/base/hinic_pmd_cfg.h | 145 +++ drivers/net/hinic/base/hinic_pmd_hwdev.c | 1414 ++ drivers/net

[dpdk-dev] [PATCH v6 08/15] net/hinic/base: add NIC business configurations

2019-06-27 Thread Ziyang Xuan
The items of configurations and queries for NIC business include MAC, VLAN, MTU, RSS and so on. These configurations and queries are handled by mgmt module. This patch introduces related data structures and function codes. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_niccfg.c

[dpdk-dev] [PATCH v6 09/15] net/hinic/base: add context and work queue support

2019-06-27 Thread Ziyang Xuan
Work queue is used for cmdq and tx/rx buff description. Nic business needs to configure cmdq context and txq/rxq context. This patch adds data structures and function codes for work queue and context. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_pmd_nicio.c | 894 +

[dpdk-dev] [PATCH v6 11/15] net/hinic: add hinic PMD build and doc files

2019-06-27 Thread Ziyang Xuan
Add build and doc files along with hinic_pmd_ethdev.c which just includes PMD register and log initialization for compilation. Signed-off-by: Ziyang Xuan --- MAINTAINERS | 8 + config/common_base | 5 + config/common_linux

[dpdk-dev] [PATCH v6 10/15] net/hinic/base: add various headers

2019-06-27 Thread Ziyang Xuan
Add various headers that define mgmt commands, cmdq commands and basic defines for use in the code. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/base/hinic_compat.h | 256 ++ drivers/net/hinic/base/hinic_pmd_cmd.h | 453 + 2 files changed, 709 insertions(

[dpdk-dev] [PATCH v6 13/15] net/hinic: add start stop close queue ops

2019-06-27 Thread Ziyang Xuan
Add dev_start, dev_stop, link_update, queue_setup, queue_release related function codes. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/hinic_pmd_ethdev.c | 684 +++ drivers/net/hinic/hinic_pmd_rx.c | 420 drivers/net/hinic/hinic_pmd_tx.c | 68

[dpdk-dev] [PATCH v6 12/15] net/hinic: add device initailization

2019-06-27 Thread Ziyang Xuan
Add device initialization function codes. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile | 2 + drivers/net/hinic/hinic_pmd_ethdev.c | 700 ++- drivers/net/hinic/hinic_pmd_rx.c | 178 +++ drivers/net/hinic/hinic_pmd_rx.h | 128 + dri

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] test/hash: free allocated memory

2019-06-27 Thread David Marchand
On Thu, Jun 27, 2019 at 5:25 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > Free allocated memory. > > Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") > Cc: sta...@dpdk.org > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Dharmik Thakkar > --- > app/

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] test/hash: init hash parameters in the correct function

2019-06-27 Thread David Marchand
On Thu, Jun 27, 2019 at 5:25 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > Each test case initializes its hash parameters in the test case > function. To be consistent, generate keys function should initialize > hash parameters similarly. > > Fixes: c7eb0972e74b ("test/hash: add

[dpdk-dev] [PATCH v6 14/15] net/hinic: add Rx/Tx package burst

2019-06-27 Thread Ziyang Xuan
This patch add package sending and receiving function codes. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/hinic_pmd_ethdev.c |4 + drivers/net/hinic/hinic_pmd_rx.c | 451 +++ drivers/net/hinic/hinic_pmd_tx.c | 1088 ++ 3 files changed, 1543 insert

Re: [dpdk-dev] [PATCH 0/4] lacp rx/tx handlers fixes for bonding pmd

2019-06-27 Thread Ferruh Yigit
On 4/10/2019 1:53 PM, David Marchand wrote: > Another series with focus on the fast/normal rx/tx handlers for 802.3ad. > > The first two patches make sure that the rx (resp. tx) fast and normal > handlers are equivalent. > > The third one will most likely have an impact on performance which I > t

[dpdk-dev] [PATCH v6 15/15] net/hinic: add RSS stats promiscuous ops

2019-06-27 Thread Ziyang Xuan
Add RSS, stats, promiscuous ops related function codes. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/hinic_pmd_ethdev.c | 735 +++ 1 file changed, 735 insertions(+) diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c index 6bd35a

Re: [dpdk-dev] [PATCH] malloc: deprecate unused set limit

2019-06-27 Thread Burakov, Anatoly
On 26-Jun-19 11:32 PM, Stephen Hemminger wrote: The function rte_malloc_set_limit was defined but never implemented. Mark it as deprecated for now, and remove in next release. There is no point in keeping dead code. "You Aren't Going to Need It" Signed-off-by: Stephen Hemminger --- Acked-by:

Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and mempool driver

2019-06-27 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, June 26, 2019 6:44 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Thomas Monjalon > Subject: [EXT] Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and > mempool driver > On 6/22/2019 2:23 PM, jer...@marvell.com wrot

Re: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging

2019-06-27 Thread Matan Azrad
Hi all Thanks Jerin for your comments. Looks like we agree that the feature is relevant at least for mlx5... Anyone else has more comments? From: Jerin Jacob Kollanukkaran > > -Original Message- > > From: Matan Azrad > > Sent: Tuesday, June 18, 2019 11:27 AM > > To: Jerin Jacob Kollan

Re: [dpdk-dev] [PATCH] app/test-compress-perf: report header improvement

2019-06-27 Thread Trybula, ArturX
-Original Message- From: Shally Verma [mailto:shal...@marvell.com] Sent: Wednesday, June 26, 2019 19:04 To: Trybula, ArturX ; dev@dpdk.org; Trahe, Fiona ; Dybkowski, AdamX Subject: RE: [dpdk-dev] [PATCH] app/test-compress-perf: report header improvement > -Original Message-

Re: [dpdk-dev] [PATCH 1/5] bus/fslmc: support device iteration

2019-06-27 Thread Hemant Agrawal
Hi Thomas,     Apologies for late in the cycle. We will take care of it next time. I will be re-sending series with cover letter. Regards, Hemant On 27-Jun-19 3:20 AM, Thomas Monjalon wrote: > Hi Hemant, > > Your series may deserve a cover letter to explain the general idea. > > I'm embarass

Re: [dpdk-dev] [PATCH v2 02/14] drivers: use new memory locking API

2019-06-27 Thread Hemant Agrawal
For fslmc changes: Acked-by: Hemant Agrawal

[dpdk-dev] [PATCH v2 0/5] FSLMC bus enchancements

2019-06-27 Thread Hemant Agrawal
This patch series makes few enhancements w.r.t functionality and usabilty of FSLMC bus. 1. Applications like OVS has mandated the use of hotplug of dpdk ports. The fslmc bus shall support hotplug now to support dpaa2 ports with OVS. 2. DPAA2 usages it hw based mempool. So, if applications like VP

Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI

2019-06-27 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 25, 2019 7:09 PM > To: Jerin Jacob Kollanukkaran ; Vamsi Krishna Attunuru > ; dev@dpdk.org > Cc: ferruh.yi...@intel.com; olivier.m...@6wind.com; > arybche...@solarflare.com > Subject: Re: [dpdk-dev] [PATCH v6 0/4] add IOVA

[dpdk-dev] [PATCH v2 1/5] bus/fslmc: support device iteration

2019-06-27 Thread Hemant Agrawal
From: Shreyansh Jain Recent (18.11+), devargs structure was changed and so was DPDK port usage in applications like OVS. Applications are now allowed to plug/unplug ports (eth) using APIs (hotplug) based on device arguments. This patch enables the plug/unplug function (which are dummy for FSLMC)

[dpdk-dev] [PATCH v2 2/5] bus/fslmc: enhance error handling for dev parsing

2019-06-27 Thread Hemant Agrawal
From: Shreyansh Jain In case an incorrect device is found, it was quiting further search rather than skipping it. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/bus/fslmc/fsl

[dpdk-dev] [PATCH v2 3/5] bus/fslmc: dynamic iommu mode detection

2019-06-27 Thread Hemant Agrawal
From: Shreyansh Jain This patch adds following: 1. 'g_container' variable name is not right way to represent the FSLMC container. Renaming it to fslmc_container. 2. dynamic selection of IOMMU mode based on run environment Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_vfio.c | 38 ++

[dpdk-dev] [PATCH v2 4/5] bus/fslmc: use cinh read for eqcr ci on ls1088 platform

2019-06-27 Thread Hemant Agrawal
From: Nipun Gupta LS1088 platform CENA operation are causing issues at high load. CINH (cache inhibited) mode is working fine with minor performance impact. This patch enables CINH mode selectively on LS1088 platform Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.h

[dpdk-dev] [PATCH v2 5/5] mempool/dpaa2: vfio dmamap for user allocated memory

2019-06-27 Thread Hemant Agrawal
From: Sachin Saxena Signed-off-by: Sachin Saxena --- drivers/bus/fslmc/fslmc_vfio.c | 39 + drivers/bus/fslmc/fslmc_vfio.h | 4 ++- drivers/bus/fslmc/rte_bus_fslmc_version.map | 6 drivers/mempool/dpaa2/dpaa2_hw_mempool.c| 13 +++ 4 f

[dpdk-dev] [PATCH] event/dpaa2: fix to return correct value for timeout ticks

2019-06-27 Thread Hemant Agrawal
From: Nipun Gupta Fixes: 0ce3ce7c275c ("event/dpaa2: add configuration functions") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/d

[dpdk-dev] [PATCH v3 2/3] lib/lpm: memory orderings to avoid race conditions for v1604

2019-06-27 Thread Ruifeng Wang
When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 group is allocated and tbl24 entry is changed to point

[dpdk-dev] [PATCH v3 3/3] lib/lpm: memory orderings to avoid race conditions for v20

2019-06-27 Thread Ruifeng Wang
When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 group is allocated and tbl24 entry is changed to point

[dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

2019-06-27 Thread Ruifeng Wang
Tests showed that the function inlining caused performance drop on some x86 platforms with the memory ordering patches applied. By force no-inline functions, the performance was better than before on x86 and no impact to arm64 platforms. Suggested-by: Medvedkin Vladimir Signed-off-by: Ruifeng Wan

Re: [dpdk-dev] [EXT] Re: [PATCH v6 2/4] lib/kni: add PCI related information

2019-06-27 Thread Vamsi Krishna Attunuru
From: Stephen Hemminger Sent: Wednesday, June 26, 2019 8:28 PM To: Vamsi Krishna Attunuru Cc: dev@dpdk.org; ferruh.yi...@intel.com; olivier.m...@6wind.com; arybche...@solarflare.com Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v6 2/4] lib/kni: add PCI related inf

[dpdk-dev] [PATCH v3 0/8] raw/ioat: driver for Intel QuickData Technology

2019-06-27 Thread Bruce Richardson
This patch series adds support for the Intel QuickData Technology device, part of the Intel I/O Acceleration Technology (Intel I/OAT). It is a raw device for allowing hardware DMA i.e. data copies in hardware. Performing the copies in hardware can provide performance improvements for applications

[dpdk-dev] [PATCH v3 4/8] raw/ioat: create device on probe and destroy on release

2019-06-27 Thread Bruce Richardson
Add the create/destroy driver functions so that we can actually allocate a rawdev and destroy it when done. No rawdev API functions are actually implemented at this point. Signed-off-by: Bruce Richardson --- doc/guides/rawdevs/ioat_rawdev.rst | 11 drivers/raw/ioat/ioat_rawdev.c | 93 ++

[dpdk-dev] [PATCH v3 3/8] raw/ioat: add register definition file

2019-06-27 Thread Bruce Richardson
Add in the list of registers for the device. File is taken from the SPDK project: https://github.com/spdk/spdk/blob/master/include/spdk/ioat_spec.h Signed-off-by: Bruce Richardson --- drivers/raw/ioat/Makefile| 1 + drivers/raw/ioat/meson.build | 3 +- drivers/raw/ioat/rte_ioa

[dpdk-dev] [PATCH v3 5/8] raw/ioat: add device info function

2019-06-27 Thread Bruce Richardson
Add in the "info_get" function to the driver, to allow us to query the device. This allows us to have the unit test pick up the presence of supported hardware or not. Signed-off-by: Bruce Richardson --- V2: Test case is placed in driver self-test routine --- app/test/test_rawdev.c

[dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start and stop functions

2019-06-27 Thread Bruce Richardson
Allow initializing a driver instance. Include selftest to validate these functions. Signed-off-by: Bruce Richardson --- V3: don't add a new descriptor format struct, reuse from rte_ioat_spec.h V2: test cases placed in self-test routine --- app/test/test_rawdev.c | 2 +- doc/guide

[dpdk-dev] [PATCH v3 2/8] usertools/dpdk-devbind.py: add support for IOAT devices

2019-06-27 Thread Bruce Richardson
In order to allow binding/unbinding of devices for use by the ioat_rawdev, we need to update the devbind script to add a new class of device, and add device ids for the specific HW instances. Signed-off-by: Bruce Richardson --- V2: rather than adding a DMA section, add to "misc (rawdev)" sectio

[dpdk-dev] [PATCH v3 1/8] raw/ioat: add initial support for ioat rawdev driver

2019-06-27 Thread Bruce Richardson
Add stubs for ioat rawdev driver support in DPDK, specifically: * makefile and meson build hooks * initial public header file * rawdev main C file, with probe and release functions * release note update announcing the driver * initial documentation for the new section in the rawdev doc

[dpdk-dev] [PATCH v3 8/8] raw/ioat: add local API to perform copies

2019-06-27 Thread Bruce Richardson
Add local APIs to trigger data copies, and retrieve handle values once those copies are completed. Included are unit tests to validate the data is copies correctly. Signed-off-by: Bruce Richardson --- V3: updated to use descriptor format in rte_ioat_spec.h V2: test cases moved to self-test rout

[dpdk-dev] [PATCH v3 7/8] raw/ioat: add statistics functions

2019-06-27 Thread Bruce Richardson
Add stats functions to track what is happening in the driver, and put unit tests to check those. Signed-off-by: Bruce Richardson --- V2: test cases moved to self-test routine --- doc/guides/rawdevs/ioat_rawdev.rst | 14 + drivers/raw/ioat/ioat_rawdev.c | 44 +++

Re: [dpdk-dev] [DPDK v3] net/ipn3ke: modifications on AFU configurations

2019-06-27 Thread Xu, Rosen
> -Original Message- > From: Wei, Dan > Sent: Saturday, June 22, 2019 22:25 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Chen, Santos > ; Wei, Dan ; Xu, Rosen > ; sta...@dpdk.org > Subject: [DPDK v3] net/ipn3ke: modifications on AFU configurations > > Modify AFU configurations for new BBS(B

Re: [dpdk-dev] [PATCH v2 00/28] sched: feature enhancements

2019-06-27 Thread Singh, Jasvinder
> > > > app/test/test_sched.c | 39 +- > > doc/guides/rel_notes/deprecation.rst |6 - > > doc/guides/rel_notes/release_19_08.rst|7 +- > > drivers/net/softnic/rte_eth_softnic.c | 131 + > > drivers/net/softnic/rte_eth_softnic_cli.c

Re: [dpdk-dev] [PATCH v2 28/28] sched: add release note

2019-06-27 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, June 26, 2019 10:31 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian ; > Krakowiak, LukaszX ; Tovar, AbrahamX > > Subject: Re: [dpdk-dev] [PATCH v2 28/28] sched: add release n

[dpdk-dev] DPDK Release Status Meeting 27/6/2019

2019-06-27 Thread Ferruh Yigit
Minutes 27 June 2019 Agenda: * Release Dates * Subtrees * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v19.08 dates: * RC1 Monday 08 July * Release Thurs  01 August * Remin

Re: [dpdk-dev] [PATCH v2 00/28] sched: feature enhancements

2019-06-27 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, June 26, 2019 10:34 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v2 00/28] sched: feature enhancements > > 25/06/2019 17:31, Jasvinder Si

Re: [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics library

2019-06-27 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harman Kalra > Sent: Friday, March 1, 2019 10:08 AM > To: Horton, Remy ; Burakov, Anatoly > ; Kovacevic, Marko > ; Mcnamara, John > > Cc: dev@dpdk.org; sta...@dpdk.org; Harman Kalra > Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] app/test-compress-perf: report header improvement

2019-06-27 Thread Shally Verma
> -Original Message- > From: Trybula, ArturX > Sent: Thursday, June 27, 2019 2:29 PM > To: Shally Verma ; dev@dpdk.org; Trahe, Fiona > ; Dybkowski, AdamX > > Subject: [EXT] RE: [dpdk-dev] [PATCH] app/test-compress-perf: report > header improvement > > External Email > > --

Re: [dpdk-dev] [PATCH v2 1/2] metrics: new API to deinitialise metrics library

2019-06-27 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harman Kalra > Sent: Friday, March 1, 2019 10:08 AM > To: Horton, Remy ; Burakov, Anatoly > ; Kovacevic, Marko > ; Mcnamara, John > > Cc: dev@dpdk.org; sta...@dpdk.org; Harman Kalra > Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v3] ethdev: support QinQ strip dynamic configuration

2019-06-27 Thread Ferruh Yigit
On 4/19/2019 6:59 AM, viveksha...@marvell.com wrote: > From: Vivek Sharma > > Enable missing support for runtime configuration (setting/getting) > of QinQ strip rx offload for a given ethdev. > > Signed-off-by: Vivek Sharma <...> > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethd

[dpdk-dev] [PATCH v2 2/2] eal/freebsd: add config reattach

2019-06-27 Thread Anatoly Burakov
Linux EAL will attach the shared config at an arbitrary address, find out where the shared config is mapped in the primary, and then will reattach it at that exact address. FreeBSD version doesn't seem to go for that extra reattach step, which makes one wonder how did it ever work in the first pla

[dpdk-dev] [PATCH v2 1/2] eal/freebsd: fix missing write to internal config

2019-06-27 Thread Anatoly Burakov
When init is complete, EAL is supposed to update internal config to indicate that initialization is complete. Add missing write. Fixes: a99c96e96ad3 ("eal: add internal flag of init completed") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Reviewed-by: David Marchand --- lib/librte_eal/fr

[dpdk-dev] [PATCH 2/9] devargs: remove incorrect experimental tags

2019-06-27 Thread David Marchand
The incriminated commit promoted those symbols as stable but the prototypes still have the tag. Fixes: 73eca2f77f4c ("devargs: promote experimental API as stable") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_eal/common/include/rte_devargs.h | 2 -- 1 file changed, 2 deletio

[dpdk-dev] [PATCH 3/9] vfio: remove incorrect experimental tag

2019-06-27 Thread David Marchand
The incriminated commit promoted this symbol as stable but the definition still has the tag. Fixes: 787ae736a3d9 ("vfio: remove experimental tag") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_eal/linux/eal/eal_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[dpdk-dev] [PATCH 1/9] eal: hide internal hotplug symbol

2019-06-27 Thread David Marchand
This api was experimental and not properly marked in the map file. But looking more closely, this is just an internal wrapper for EAL init. Hide it in the hotplug code. Fixes: 244d5130719c ("eal: enable hotplug on multi-process") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_

[dpdk-dev] [PATCH 0/9] experimental tags fixes

2019-06-27 Thread David Marchand
Here is a new series on __rte_experimental tags. Following the build error reported by Aaron [1], I noticed that some experimental functions could go unnoticed because of a gcc peculiarity. To catch those, I went and added a new check on the object files to ensure that any experimental api flagge

[dpdk-dev] [PATCH 5/9] buildtools: detect discrepancies for experimental symbols

2019-06-27 Thread David Marchand
When promoting those symbols as stable, there is no check to ensure that the final result is consistent. Add a little script to get the symbols per section from the library map files. Validate that all experimental symbols in object files are referenced by library map files. Signed-off-by: David

[dpdk-dev] [PATCH 4/9] raw/dpaa2_qdma: remove incorrect experimental tag

2019-06-27 Thread David Marchand
The incriminated commit promoted this symbol as stable but the prototype still has the tag. Fixes: fb1a20331d70 ("raw/dpaa2_qdma: remove experimental tag from APIs") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH 6/9] net/atlantic: add missing experimental api tags

2019-06-27 Thread David Marchand
Those symbols are declared in the library map but the prototypes are missing the experimental tag. Without it, existing users won't notice it is experimental. Fixes: ec0dec44ecb9 ("net/atlantic: enable MACsec configuration") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/atla

[dpdk-dev] [PATCH 9/9] enforce __rte_experimental at the start of symbol declarations

2019-06-27 Thread David Marchand
Putting a '__attribute__((deprecated))' in the middle of a function prototype does not result in the expected result with gcc (while clang is fine with this syntax). $ cat deprecated.c void * __attribute__((deprecated)) incorrect() { return 0; } __attribute__((deprecated)) void *correct(void) { re

[dpdk-dev] [PATCH 7/9] mem: remove incorrect experimental tag on static symbol

2019-06-27 Thread David Marchand
This function is not visible from outside this code unit. Fixes: 84e7477e10b1 ("mem: add thread unsafe version for DMA mask check") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions

2019-06-27 Thread David Marchand
We had some inconsistencies between functions prototypes and actual definitions. Let's avoid this by only adding the experimental tag to the prototypes. Tests with gcc and clang show it is enough. git grep -l __rte_experimental |grep \.c$ |while read file; do sed -i -e '/^__rte_experimenta

[dpdk-dev] [PATCH v3 01/14] eal: add API to lock/unlock memory hotplug

2019-06-27 Thread Anatoly Burakov
Currently, the memory hotplug is locked automatically by all memory-related _walk() functions, but sometimes locking the memory subsystem outside of them is needed. There is no public API to do that, so it creates a dependency on shared memory config to be public. Fix this by introducing a new API

[dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public

2019-06-27 Thread Anatoly Burakov
This patchset removes the shared memory config from public API, and replaces all usages of said config with new API calls. A lot of the patchset is a search-and-replace job and should be pretty easy to review. The rest are pretty trivial EAL changes. This patchset depends on FreeBSD fixes patchse

[dpdk-dev] [PATCH v3 03/14] lib: use new memory locking API

2019-06-27 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 43 ++- lib/librte_eal/common/malloc_heap.c | 14 lib/librte_eal/common/rte_malloc.c| 32 ++

[dpdk-dev] [PATCH v3 04/14] eal: add EAL tailq list lock/unlock API

2019-06-27 Thread Anatoly Burakov
Currently, locking/unlocking the TAILQ list requires direct access to the shared memory config. Add an API to do the same. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 28 +++ .../common/include/rte_eal_memconfig.h| 24 +++

[dpdk-dev] [PATCH v3 02/14] drivers: use new memory locking API

2019-06-27 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov Acked-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 8 +++- drivers/net/mlx4/mlx4_mr.c | 11 +-- drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH v3 05/14] lib: use new tailq locking API

2019-06-27 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_acl/rte_acl.c | 18 +++ lib/librte_distributor/rte_distributor.c | 4 ++-- lib/librte_distributor/rte_distributor_v20.c | 4 ++--

[dpdk-dev] [PATCH v3 08/14] eal: remove unused macros

2019-06-27 Thread Anatoly Burakov
These macros are not used anymore and can be removed. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_eal.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h index cf701e177..7042

[dpdk-dev] [PATCH v3 09/14] eal: hide shared memory config

2019-06-27 Thread Anatoly Burakov
Now that everything that has ever accessed the shared memory config is doing so through the public API's, we can make it internal. Since we're removing quite a few headers from rte_eal_memconfig.h, we need to add them back in places where this header is used. This bumps the ABI, so also change all

[dpdk-dev] [PATCH v3 06/14] eal: add new API to lock/unlock mempool list

2019-06-27 Thread Anatoly Burakov
Currently, in order to lock access to the mempool list, a direct access to the shared memory structure is needed. Add an API to do the same. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 28 +++ .../common/include/rte_eal_memconfig.h|

[dpdk-dev] [PATCH v3 07/14] mempool: use new mempool list locking API

2019-06-27 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov Reviewed-by: Andrew Rybchenko --- lib/librte_mempool/rte_mempool.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/librte_mempool/rte_memp

[dpdk-dev] [PATCH v3 11/14] eal: uninline wait for mcfg complete function

2019-06-27 Thread Anatoly Burakov
Currently, the function to wait until config completion is static inline for no reason. Move its implementation to an EAL common file. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 10 ++ lib/librte_eal/common/eal_memcfg.h | 10 +++--- lib/librte_e

[dpdk-dev] [PATCH v3 12/14] eal: unify and move mcfg complete function

2019-06-27 Thread Anatoly Burakov
Currently, mcfg completion function exists in two independent implementations doing the same thing, which is bug prone. Unify the two functions and move them into one place. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 14 ++ lib/librte_eal/common/eal_

[dpdk-dev] [PATCH v3 13/14] eal: unify internal config initialization

2019-06-27 Thread Anatoly Burakov
Currently, each EAL will update internal/shared config in their own way at init, resulting in needless duplication of code and OS-dependent behavior. Move the functions to a common file and add missing FreeBSD steps. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_mcfg.c | 18

[dpdk-dev] [PATCH v3 10/14] eal: remove packed attribute from mcfg structure

2019-06-27 Thread Anatoly Burakov
There is no reason to pack the memconfig structure, and doing so gives out warnings in some static analyzers. Fix it by removing the packed attributed. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_memcfg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/li

[dpdk-dev] [PATCH v3 14/14] eal: prevent different primary/secondary process versions

2019-06-27 Thread Anatoly Burakov
Currently, nothing stops DPDK to attempt to run primary and secondary processes while having different versions. This can lead to all sorts of weird behavior and makes it harder to maintain compatibility without breaking ABI every once in a while. Fix it by explicitly disallowing running different

Re: [dpdk-dev] [PATCH v2 2/2] eal/freebsd: add config reattach

2019-06-27 Thread David Marchand
On Thu, Jun 27, 2019 at 1:33 PM Anatoly Burakov wrote: > Linux EAL will attach the shared config at an arbitrary address, > find out where the shared config is mapped in the primary, and > then will reattach it at that exact address. > > FreeBSD version doesn't seem to go for that extra reattach

Re: [dpdk-dev] [PATCH] app/test-compress-perf: report header improvement

2019-06-27 Thread Trybula, ArturX
-Original Message- From: Shally Verma [mailto:shal...@marvell.com] Sent: Thursday, June 27, 2019 13:01 To: Trybula, ArturX ; dev@dpdk.org; Trahe, Fiona ; Dybkowski, AdamX Subject: RE: [dpdk-dev] [PATCH] app/test-compress-perf: report header improvement > -Original Message-

Re: [dpdk-dev] [PATCH v2 1/4] raw/skeleton: fix failing test case

2019-06-27 Thread Hemant Agrawal
Series-Acked-by: Hemant Agrawal On 21-Jun-19 9:26 PM, Bruce Richardson wrote: > Rawdev unit test for setting and getting parameters is failing because > of a pointer value being dereferenced after the memory it pointed to is > freed. > > The freeing of the malloced memory is difficult when using

Re: [dpdk-dev] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless

2019-06-27 Thread Trahe, Fiona
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, June 24, 2019 8:05 AM > To: Trahe, Fiona ; Kusztal, ArkadiuszX > ; > dev@dpdk.org; Shally Verma > Subject: RE: [PATCH] cryptodev: extend api of asymmetric crypto by sessionless > > Hi Fiona >

Re: [dpdk-dev] [PATCH v3 1/8] raw/ioat: add initial support for ioat rawdev driver

2019-06-27 Thread Burakov, Anatoly
On 27-Jun-19 11:40 AM, Bruce Richardson wrote: Add stubs for ioat rawdev driver support in DPDK, specifically: * makefile and meson build hooks * initial public header file * rawdev main C file, with probe and release functions * release note update announcing the driver * initial

Re: [dpdk-dev] [PATCH v3 2/8] usertools/dpdk-devbind.py: add support for IOAT devices

2019-06-27 Thread Burakov, Anatoly
On 27-Jun-19 11:40 AM, Bruce Richardson wrote: In order to allow binding/unbinding of devices for use by the ioat_rawdev, we need to update the devbind script to add a new class of device, and add device ids for the specific HW instances. Signed-off-by: Bruce Richardson --- Acked-by: Anatoly

Re: [dpdk-dev] [PATCH v3 3/8] raw/ioat: add register definition file

2019-06-27 Thread Burakov, Anatoly
On 27-Jun-19 11:40 AM, Bruce Richardson wrote: Add in the list of registers for the device. File is taken from the SPDK project: https://github.com/spdk/spdk/blob/master/include/spdk/ioat_spec.h Signed-off-by: Bruce Richardson --- The indentation is slightly inconsistent across the file,

Re: [dpdk-dev] [PATCH v3 4/8] raw/ioat: create device on probe and destroy on release

2019-06-27 Thread Burakov, Anatoly
On 27-Jun-19 11:40 AM, Bruce Richardson wrote: Add the create/destroy driver functions so that we can actually allocate a rawdev and destroy it when done. No rawdev API functions are actually implemented at this point. Signed-off-by: Bruce Richardson --- ioat_rawdev_create(const char *na

Re: [dpdk-dev] [PATCH v3 2/8] usertools/dpdk-devbind.py: add support for IOAT devices

2019-06-27 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Bruce Richardson > Sent: Thursday, June 27, 2019 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > Bruce Richardson > Subject: [PATCH v3 2/8] usertools/dpdk-devbind.py: add support for > IOAT devices > In order to allow bin

Re: [dpdk-dev] [PATCH v3 5/8] raw/ioat: add device info function

2019-06-27 Thread Burakov, Anatoly
On 27-Jun-19 11:40 AM, Bruce Richardson wrote: Add in the "info_get" function to the driver, to allow us to query the device. This allows us to have the unit test pick up the presence of supported hardware or not. Signed-off-by: Bruce Richardson --- V2: Test case is placed in driver self-test

[dpdk-dev] [PATCH v2] test/eal: add ut for eal options proc-type and uio

2019-06-27 Thread Lavanya Govindarajan
Added unit test cases for EAL flags --proc-type=auto and --create-uio-dev in order to cover the below functions eal_proc_type_detect() rte_eal_create_uio_dev() Signed-off-by: Lavanya Govindarajan Acked-by: Anatoly Burakov --- v2: Removed core and channels eal options as they are not significant

Re: [dpdk-dev] [PATCH 0/4] lacp rx/tx handlers fixes for bonding pmd

2019-06-27 Thread Chas Williams
On 6/27/19 4:08 AM, Ferruh Yigit wrote: On 4/10/2019 1:53 PM, David Marchand wrote: Another series with focus on the fast/normal rx/tx handlers for 802.3ad. The first two patches make sure that the rx (resp. tx) fast and normal handlers are equivalent. The third one will most likely have an

Re: [dpdk-dev] [PATCH 9/9] enforce __rte_experimental at the start of symbol declarations

2019-06-27 Thread Adrien Mazarguil
Hey David, On Thu, Jun 27, 2019 at 01:33:55PM +0200, David Marchand wrote: > Putting a '__attribute__((deprecated))' in the middle of a function > prototype does not result in the expected result with gcc (while clang > is fine with this syntax). > > $ cat deprecated.c > void * __attribute__((dep

Re: [dpdk-dev] [PATCH v3 4/8] raw/ioat: create device on probe and destroy on release

2019-06-27 Thread Burakov, Anatoly
On 27-Jun-19 11:40 AM, Bruce Richardson wrote: Add the create/destroy driver functions so that we can actually allocate a rawdev and destroy it when done. No rawdev API functions are actually implemented at this point. Signed-off-by: Bruce Richardson --- + rawdev->driver_name = dev->

Re: [dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start and stop functions

2019-06-27 Thread Burakov, Anatoly
On 27-Jun-19 11:40 AM, Bruce Richardson wrote: Allow initializing a driver instance. Include selftest to validate these functions. Signed-off-by: Bruce Richardson --- V3: don't add a new descriptor format struct, reuse from rte_ioat_spec.h V2: test cases placed in self-test routine --- app/

Re: [dpdk-dev] [PATCH 1/4] ethdev: add GRE key field to flow API

2019-06-27 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Monday, June 24, 2019 6:40 PM > To: Adrien Mazarguil ; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon ; > Ferruh Yigit ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/4] ethdev: add GRE key f

  1   2   3   >